======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.0.141/6790 is trying to acquire lock:
ffff8881b8feb058 (&ocfs2_file_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_try_remove_refcount_tree+0xb6/0x340

but task is already holding lock:
ffff8881b8feb0e8 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_try_remove_refcount_tree+0xa4/0x340

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&oi->ip_xattr_sem){++++}-{4:4}:
       down_read+0x47/0x2e0
       ocfs2_init_acl+0x2fd/0x7e0
       ocfs2_mknod+0x1679/0x2260
       vfs_mknod+0x447/0x610
       filename_mknodat+0x3cb/0x660
       __se_sys_mknod+0x3a/0x150
       do_syscall_64+0x15f/0xf80
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (&journal->j_trans_barrier){.+.+}-{4:4}:
       down_read+0x47/0x2e0
       ocfs2_start_trans+0x3ab/0x700
       ocfs2_mknod+0x1181/0x2260
       ocfs2_create+0x195/0x460
       path_openat+0x1395/0x3860
       do_file_open+0x23e/0x4a0
       do_sys_openat2+0x113/0x200
       __x64_sys_openat+0x138/0x170
       do_syscall_64+0x15f/0xf80
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (sb_internal#4){.+.+}-{0:0}:
       ocfs2_start_trans+0x2ac/0x700
       ocfs2_extend_dir+0x1116/0x4a30
       ocfs2_prepare_dir_for_insert+0x347a/0x52f0
       ocfs2_mknod+0xa1b/0x2260
       ocfs2_create+0x195/0x460
       vfs_create+0x2d1/0x460
       filename_mknodat+0x3e8/0x660
       __se_sys_mknod+0x3a/0x150
       do_syscall_64+0x15f/0xf80
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&ocfs2_file_ip_alloc_sem_key){++++}-{4:4}:
       __lock_acquire+0x15a5/0x2cf0
       lock_acquire+0x106/0x350
       down_write+0x96/0x200
       ocfs2_try_remove_refcount_tree+0xb6/0x340
       ocfs2_xattr_set+0x61a/0x13e0
       ocfs2_set_acl+0x701/0x7b0
       ocfs2_iop_set_acl+0x1b1/0x2b0
       vfs_remove_acl+0x542/0x830
       ovl_workdir_create+0x5b3/0x940
       ovl_fill_super+0x1a38/0x5e20
       get_tree_nodev+0xbb/0x150
       vfs_get_tree+0x92/0x2a0
       do_new_mount+0x341/0xd30
       __se_sys_mount+0x31d/0x420
       do_syscall_64+0x15f/0xf80
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &ocfs2_file_ip_alloc_sem_key --> &journal->j_trans_barrier --> &oi->ip_xattr_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_xattr_sem);
                               lock(&journal->j_trans_barrier);
                               lock(&oi->ip_xattr_sem);
  lock(&ocfs2_file_ip_alloc_sem_key);

 *** DEADLOCK ***

4 locks held by syz.0.141/6790:
 #0: ffff8881bac660d8 (&type->s_umount_key#94/1){+.+.}-{4:4}, at: alloc_super+0x28c/0xab0
 #1: ffff888114f44410 (sb_writers#15){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90
 #2: ffff8881b8feb3a0 (&sb->s_type->i_mutex_key#26){+.+.}-{4:4}, at: vfs_remove_acl+0x10b/0x830
 #3: ffff8881b8feb0e8 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_try_remove_refcount_tree+0xa4/0x340

stack backtrace:
CPU: 1 UID: 0 PID: 6790 Comm: syz.0.141 Not tainted syzkaller #0 PREEMPT(full) 
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.2-debian-1.16.2-1 04/01/2014
Call Trace:
 <TASK>
 dump_stack_lvl+0xe8/0x150
 print_circular_bug+0x2e1/0x300
 check_noncircular+0x12e/0x150
 __lock_acquire+0x15a5/0x2cf0
 lock_acquire+0x106/0x350
 down_write+0x96/0x200
 ocfs2_try_remove_refcount_tree+0xb6/0x340
 ocfs2_xattr_set+0x61a/0x13e0
 ocfs2_set_acl+0x701/0x7b0
 ocfs2_iop_set_acl+0x1b1/0x2b0
 vfs_remove_acl+0x542/0x830
 ovl_workdir_create+0x5b3/0x940
 ovl_fill_super+0x1a38/0x5e20
 get_tree_nodev+0xbb/0x150
 vfs_get_tree+0x92/0x2a0
 do_new_mount+0x341/0xd30
 __se_sys_mount+0x31d/0x420
 do_syscall_64+0x15f/0xf80
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f3c3e79cdd9
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f3c3c9f6028 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007f3c3ea15fa0 RCX: 00007f3c3e79cdd9
RDX: 0000200000000080 RSI: 00002000000000c0 RDI: 0000000000000000
RBP: 00007f3c3e832d69 R08: 0000200000000380 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f3c3ea16038 R14: 00007f3c3ea15fa0 R15: 00007ffe1f2f8d18
 </TASK>
overlayfs: upper fs does not support tmpfile.
overlayfs: upper fs does not support RENAME_WHITEOUT.
overlayfs: upper fs missing required features.
