smc: removing ib device syz0
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
kworker/u9:4/24031 is trying to acquire lock:
ffff8881012acaa0 (&root->kernfs_supers_rwsem){++++}-{4:4}, at: kernfs_remove+0x35/0x80

but task is already holding lock:
ffffffff8f38d660 (gdp_mutex){+.+.}-{4:4}, at: cleanup_glue_dir+0xc3/0x220

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #10 (gdp_mutex){+.+.}-{4:4}:
       __mutex_lock+0x1a3/0x1550
       get_device_parent+0x16f/0x3a0
       device_add+0x2e1/0xbb0
       device_create+0x269/0x300
       msr_device_create+0x33/0x50
       cpuhp_invoke_callback+0x445/0x860
       cpuhp_thread_fun+0x36b/0x780
       smpboot_thread_fn+0x541/0xa50
       kthread+0x388/0x470
       ret_from_fork+0x514/0xb70
       ret_from_fork_asm+0x1a/0x30

-> #9 (cpuhp_state-up){+.+.}-{0:0}:
       cpuhp_thread_fun+0x127/0x780
       smpboot_thread_fn+0x541/0xa50
       kthread+0x388/0x470
       ret_from_fork+0x514/0xb70
       ret_from_fork_asm+0x1a/0x30

-> #8 (cpu_hotplug_lock){++++}-{0:0}:
       cpus_read_lock+0x42/0x160
       static_key_slow_inc+0x12/0x30
       nbd_genl_reconfigure+0x132f/0x1ea0
       genl_family_rcv_msg_doit+0x22a/0x330
       genl_rcv_msg+0x61c/0x7a0
       netlink_rcv_skb+0x232/0x4b0
       genl_rcv+0x28/0x40
       netlink_unicast+0x75c/0x8e0
       netlink_sendmsg+0x813/0xb40
       ____sys_sendmsg+0x972/0x9f0
       ___sys_sendmsg+0x2a5/0x360
       __x64_sys_sendmsg+0x1bd/0x2a0
       do_syscall_64+0x15f/0xf80
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #7 (&nsock->tx_lock){+.+.}-{4:4}:
       __mutex_lock+0x1a3/0x1550
       nbd_queue_rq+0x37b/0x1100
       blk_mq_dispatch_rq_list+0xa70/0x1910
       __blk_mq_sched_dispatch_requests+0xdcc/0x1600
       blk_mq_sched_dispatch_requests+0xd7/0x190
       blk_mq_run_hw_queue+0x348/0x4f0
       blk_mq_dispatch_list+0xd16/0xe10
       blk_mq_flush_plug_list+0x48d/0x570
       __blk_flush_plug+0x3ed/0x4d0
       __submit_bio+0x28d/0x580
       submit_bio_noacct_nocheck+0x2f4/0xa40
       block_read_full_folio+0x599/0x830
       filemap_read_folio+0x137/0x3b0
       do_read_cache_folio+0x358/0x590
       read_part_sector+0xb6/0x2b0
       adfspart_check_ICS+0xb1/0x960
       bdev_disk_changed+0x817/0x1770
       blkdev_get_whole+0x380/0x510
       bdev_open+0x31e/0xd30
       blkdev_open+0x470/0x610
       do_dentry_open+0x785/0x14e0
       vfs_open+0x3b/0x340
       path_openat+0x2e08/0x3860
       do_file_open+0x23e/0x4a0
       do_sys_openat2+0x113/0x200
       __x64_sys_openat+0x138/0x170
       do_syscall_64+0x15f/0xf80
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #6 (&cmd->lock){+.+.}-{4:4}:
       __mutex_lock+0x1a3/0x1550
       nbd_queue_rq+0xc6/0x1100
       blk_mq_dispatch_rq_list+0xa70/0x1910
       __blk_mq_sched_dispatch_requests+0xdcc/0x1600
       blk_mq_sched_dispatch_requests+0xd7/0x190
       blk_mq_run_hw_queue+0x348/0x4f0
       blk_mq_dispatch_list+0xd16/0xe10
       blk_mq_flush_plug_list+0x48d/0x570
       __blk_flush_plug+0x3ed/0x4d0
       __submit_bio+0x28d/0x580
       submit_bio_noacct_nocheck+0x2f4/0xa40
       block_read_full_folio+0x599/0x830
       filemap_read_folio+0x137/0x3b0
       do_read_cache_folio+0x358/0x590
       read_part_sector+0xb6/0x2b0
       adfspart_check_ICS+0xb1/0x960
       bdev_disk_changed+0x817/0x1770
       blkdev_get_whole+0x380/0x510
       bdev_open+0x31e/0xd30
       blkdev_open+0x470/0x610
       do_dentry_open+0x785/0x14e0
       vfs_open+0x3b/0x340
       path_openat+0x2e08/0x3860
       do_file_open+0x23e/0x4a0
       do_sys_openat2+0x113/0x200
       __x64_sys_openat+0x138/0x170
       do_syscall_64+0x15f/0xf80
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #5 (set->srcu){.+.+}-{0:0}:
       __synchronize_srcu+0xca/0x300
       elevator_switch+0x1e8/0x7a0
       elevator_change+0x2cc/0x450
       elevator_set_default+0x36c/0x430
       blk_register_queue+0x3e9/0x4e0
       __add_disk+0x677/0xd50
       add_disk_fwnode+0xfb/0x480
       nbd_dev_add+0x72c/0xb50
       nbd_init+0x168/0x1f0
       do_one_initcall+0x250/0x870
       do_initcall_level+0x104/0x190
       do_initcalls+0x59/0xa0
       kernel_init_freeable+0x2a6/0x3e0
       kernel_init+0x1d/0x1d0
       ret_from_fork+0x514/0xb70
       ret_from_fork_asm+0x1a/0x30

-> #4 (&q->elevator_lock){+.+.}-{4:4}:
       __mutex_lock+0x1a3/0x1550
       elevator_change+0x1b3/0x450
       elevator_set_none+0xb5/0x140
       blk_mq_update_nr_hw_queues+0x5e7/0x1a60
       nbd_start_device+0x17f/0xb10
       nbd_genl_connect+0x165b/0x1cf0
       genl_family_rcv_msg_doit+0x22a/0x330
       genl_rcv_msg+0x61c/0x7a0
       netlink_rcv_skb+0x232/0x4b0
       genl_rcv+0x28/0x40
       netlink_unicast+0x75c/0x8e0
       netlink_sendmsg+0x813/0xb40
       ____sys_sendmsg+0x972/0x9f0
       ___sys_sendmsg+0x2a5/0x360
       __x64_sys_sendmsg+0x1bd/0x2a0
       do_syscall_64+0x15f/0xf80
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #3 (&q->q_usage_counter(io)#50){++++}-{0:0}:
       blk_alloc_queue+0x546/0x680
       __blk_mq_alloc_disk+0x197/0x390
       nbd_dev_add+0x499/0xb50
       nbd_init+0x168/0x1f0
       do_one_initcall+0x250/0x870
       do_initcall_level+0x104/0x190
       do_initcalls+0x59/0xa0
       kernel_init_freeable+0x2a6/0x3e0
       kernel_init+0x1d/0x1d0
       ret_from_fork+0x514/0xb70
       ret_from_fork_asm+0x1a/0x30

-> #2 (fs_reclaim){+.+.}-{0:0}:
       fs_reclaim_acquire+0x71/0x100
       kmem_cache_alloc_lru_noprof+0x45/0x640
       alloc_inode+0xb8/0x1b0
       iget_locked+0x131/0x6a0
       kernfs_get_inode+0x4f/0x780
       kernfs_get_tree+0x5cd/0x980
       sysfs_get_tree+0x46/0x110
       vfs_get_tree+0x92/0x2a0
       do_new_mount+0x341/0xd30
       __se_sys_mount+0x31d/0x420
       do_syscall_64+0x15f/0xf80
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&root->kernfs_rwsem){++++}-{4:4}:
       down_write+0x96/0x200
       kernfs_remove_by_name_ns+0x4e/0x140
       device_links_driver_bound+0x54f/0x14e0
       driver_bound+0xd8/0x2e0
       really_probe+0x789/0xaf0
       __driver_probe_device+0x1ef/0x380
       driver_probe_device+0x4f/0x240
       __device_attach_driver+0x279/0x430
       bus_for_each_drv+0x258/0x2f0
       __device_attach+0x2c5/0x450
       device_initial_probe+0xa1/0xd0
       bus_probe_device+0x12a/0x220
       device_add+0x7e9/0xbb0
       faux_device_create_with_groups+0x189/0x290
       regulator_dummy_init+0x19/0x40
       regulator_init+0xca/0x110
       do_one_initcall+0x250/0x870
       do_initcall_level+0x104/0x190
       do_initcalls+0x59/0xa0
       kernel_init_freeable+0x2a6/0x3e0
       kernel_init+0x1d/0x1d0
       ret_from_fork+0x514/0xb70
       ret_from_fork_asm+0x1a/0x30

-> #0 (&root->kernfs_supers_rwsem){++++}-{4:4}:
       __lock_acquire+0x15a5/0x2cf0
       lock_acquire+0x106/0x350
       down_read+0x47/0x2e0
       kernfs_remove+0x35/0x80
       __kobject_del+0xe1/0x330
       kobject_del+0x45/0x60
       cleanup_glue_dir+0x1a3/0x220
       device_del+0x780/0x8f0
       cdev_device_del+0x27/0xf0
       ib_umad_kill_port+0xf9/0x320
       ib_umad_remove_one+0x160/0x270
       remove_client_context+0xb9/0x1e0
       disable_device+0x137/0x330
       __ib_unregister_device+0x2cb/0x3f0
       ib_unregister_work+0x19/0x30
       process_scheduled_works+0xb5d/0x1860
       worker_thread+0xa53/0xfc0
       kthread+0x388/0x470
       ret_from_fork+0x514/0xb70
       ret_from_fork_asm+0x1a/0x30

other info that might help us debug this:

Chain exists of:
  &root->kernfs_supers_rwsem --> cpuhp_state-up --> gdp_mutex

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(gdp_mutex);
                               lock(cpuhp_state-up);
                               lock(gdp_mutex);
  rlock(&root->kernfs_supers_rwsem);

 *** DEADLOCK ***

4 locks held by kworker/u9:4/24031:
 #0: ffff888106abc140 ((wq_completion)ib-unreg-wq){+.+.}-{0:0}, at: process_scheduled_works+0xa35/0x1860
 #1: ffffc90004377c40 ((work_completion)(&device->unregistration_work)){+.+.}-{0:0}, at: process_scheduled_works+0xa70/0x1860
 #2: ffff8881207346f8 (&device->unregistration_lock){+.+.}-{4:4}, at: __ib_unregister_device+0x284/0x3f0
 #3: ffffffff8f38d660 (gdp_mutex){+.+.}-{4:4}, at: cleanup_glue_dir+0xc3/0x220

stack backtrace:
CPU: 0 UID: 0 PID: 24031 Comm: kworker/u9:4 Not tainted syzkaller #0 PREEMPT(full) 
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.2-debian-1.16.2-1 04/01/2014
Workqueue: ib-unreg-wq ib_unregister_work
Call Trace:
 <TASK>
 dump_stack_lvl+0xe8/0x150
 print_circular_bug+0x2e1/0x300
 check_noncircular+0x12e/0x150
 __lock_acquire+0x15a5/0x2cf0
 lock_acquire+0x106/0x350
 down_read+0x47/0x2e0
 kernfs_remove+0x35/0x80
 __kobject_del+0xe1/0x330
 kobject_del+0x45/0x60
 cleanup_glue_dir+0x1a3/0x220
 device_del+0x780/0x8f0
 cdev_device_del+0x27/0xf0
 ib_umad_kill_port+0xf9/0x320
 ib_umad_remove_one+0x160/0x270
 remove_client_context+0xb9/0x1e0
 disable_device+0x137/0x330
 __ib_unregister_device+0x2cb/0x3f0
 ib_unregister_work+0x19/0x30
 process_scheduled_works+0xb5d/0x1860
 worker_thread+0xa53/0xfc0
 kthread+0x388/0x470
 ret_from_fork+0x514/0xb70
 ret_from_fork_asm+0x1a/0x30
 </TASK>
smbdirect: ib_dev[syz0] removed
