======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.2.237/8281 is trying to acquire lock:
ffff888173122610 (sb_internal#6){.+.+}-{0:0}, at: ocfs2_setattr+0xcc6/0x1cc0

but task is already holding lock:
ffff88811696b1e0 (&oi->ip_alloc_sem){+.+.}-{4:4}, at: ocfs2_setattr+0xcb7/0x1cc0

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&oi->ip_alloc_sem){+.+.}-{4:4}:
       down_write+0x96/0x200
       ocfs2_try_remove_refcount_tree+0xb6/0x340
       ocfs2_xattr_set+0x61a/0x13e0
       ocfs2_set_acl+0x701/0x7b0
       ocfs2_iop_set_acl+0x1b1/0x2b0
       vfs_remove_acl+0x542/0x830
       ovl_workdir_create+0x5b3/0x940
       ovl_fill_super+0x1a3f/0x5e00
       get_tree_nodev+0xbb/0x150
       vfs_get_tree+0x92/0x2a0
       do_new_mount+0x341/0xd30
       __se_sys_mount+0x31d/0x420
       do_syscall_64+0x14d/0xf80
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (&oi->ip_xattr_sem){++++}-{4:4}:
       down_read+0x47/0x2e0
       ocfs2_init_acl+0x2fd/0x7e0
       ocfs2_mknod+0x1679/0x2290
       ocfs2_mkdir+0x181/0x490
       vfs_mkdir+0x413/0x630
       filename_mkdirat+0x285/0x510
       __se_sys_mkdirat+0x35/0x150
       do_syscall_64+0x14d/0xf80
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&journal->j_trans_barrier){.+.+}-{4:4}:
       down_read+0x47/0x2e0
       ocfs2_start_trans+0x3ab/0x700
       ocfs2_reserve_suballoc_bits+0x7ae/0x4940
       ocfs2_reserve_new_metadata_blocks+0x415/0x9a0
       ocfs2_extend_dir+0xcc8/0x4a60
       ocfs2_prepare_dir_for_insert+0x34b0/0x5360
       ocfs2_mknod+0xa1b/0x2290
       ocfs2_mkdir+0x181/0x490
       vfs_mkdir+0x413/0x630
       filename_mkdirat+0x285/0x510
       __se_sys_mkdirat+0x35/0x150
       do_syscall_64+0x14d/0xf80
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (sb_internal#6){.+.+}-{0:0}:
       __lock_acquire+0x15a5/0x2cf0
       lock_acquire+0xf0/0x2e0
       ocfs2_start_trans+0x2ac/0x700
       ocfs2_setattr+0xcc6/0x1cc0
       notify_change+0xc1a/0xf40
       ovl_workdir_create+0x716/0x940
       ovl_fill_super+0x1a3f/0x5e00
       get_tree_nodev+0xbb/0x150
       vfs_get_tree+0x92/0x2a0
       do_new_mount+0x341/0xd30
       __se_sys_mount+0x31d/0x420
       do_syscall_64+0x14d/0xf80
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  sb_internal#6 --> &oi->ip_xattr_sem --> &oi->ip_alloc_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_alloc_sem);
                               lock(&oi->ip_xattr_sem);
                               lock(&oi->ip_alloc_sem);
  rlock(sb_internal#6);

 *** DEADLOCK ***

4 locks held by syz.2.237/8281:
 #0: ffff88812093a0e0 (&type->s_umount_key#63/1){+.+.}-{4:4}, at: alloc_super+0x28c/0xab0
 #1: ffff888173122420 (sb_writers#29){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90
 #2: ffff88811696b540 (&sb->s_type->i_mutex_key#39){+.+.}-{4:4}, at: ovl_workdir_create+0x6b7/0x940
 #3: ffff88811696b1e0 (&oi->ip_alloc_sem){+.+.}-{4:4}, at: ocfs2_setattr+0xcb7/0x1cc0

stack backtrace:
CPU: 0 UID: 0 PID: 8281 Comm: syz.2.237 Not tainted syzkaller #0 PREEMPT(full) 
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.2-debian-1.16.2-1 04/01/2014
Call Trace:
 <TASK>
 dump_stack_lvl+0xe8/0x150
 print_circular_bug+0x2e1/0x300
 check_noncircular+0x12e/0x150
 __lock_acquire+0x15a5/0x2cf0
 lock_acquire+0xf0/0x2e0
 ocfs2_start_trans+0x2ac/0x700
 ocfs2_setattr+0xcc6/0x1cc0
 notify_change+0xc1a/0xf40
 ovl_workdir_create+0x716/0x940
 ovl_fill_super+0x1a3f/0x5e00
 get_tree_nodev+0xbb/0x150
 vfs_get_tree+0x92/0x2a0
 do_new_mount+0x341/0xd30
 __se_sys_mount+0x31d/0x420
 do_syscall_64+0x14d/0xf80
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f09fb19c799
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f09fbfb2028 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007f09fb415fa0 RCX: 00007f09fb19c799
RDX: 0000200000000000 RSI: 0000200000000100 RDI: 0000000000000000
RBP: 00007f09fb232c99 R08: 0000200000000140 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f09fb416038 R14: 00007f09fb415fa0 R15: 00007fff15e576d8
 </TASK>
overlayfs: upper fs does not support tmpfile.
overlayfs: upper fs does not support RENAME_WHITEOUT.
overlayfs: upper fs missing required features.
