======================================================
WARNING: possible circular locking dependency detected
6.16.0-rc5-syzkaller-00193-g40f92e79b0aa #0 Not tainted
------------------------------------------------------
syz.6.10291/9196 is trying to acquire lock:
ffff88803580c3c0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{4:4}, at: ocfs2_reserve_local_alloc_bits+0x125/0x24e0

but task is already holding lock:
ffff888129426be0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_lock_global_qf+0x1e8/0x270

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #7 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}:
       lock_acquire+0x120/0x360
       down_write+0x96/0x1f0
       ocfs2_lock_global_qf+0x1e8/0x270
       ocfs2_acquire_dquot+0x2b0/0xb30
       dqget+0x7b1/0xf10
       dquot_set_dqblk+0x2b/0xfa0
       quota_setquota+0x4b7/0x540
       __se_sys_quotactl+0x279/0x950
       do_syscall_64+0xfa/0x3b0
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #6 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{4:4}:
       lock_acquire+0x120/0x360
       down_write+0x96/0x1f0
       ocfs2_lock_global_qf+0x1ca/0x270
       ocfs2_acquire_dquot+0x2b0/0xb30
       dqget+0x7b1/0xf10
       dquot_set_dqblk+0x2b/0xfa0
       quota_setquota+0x4b7/0x540
       __se_sys_quotactl+0x279/0x950
       do_syscall_64+0xfa/0x3b0
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #5 (&dquot->dq_lock){+.+.}-{4:4}:
       lock_acquire+0x120/0x360
       __mutex_lock+0x182/0xe80
       dqget+0x72a/0xf10
       dquot_transfer+0x2f8/0x6d0
       ext4_setattr+0x865/0x1bc0
       notify_change+0xb36/0xe40
       chown_common+0x40c/0x5c0
       do_fchownat+0x161/0x270
       __x64_sys_lchown+0x85/0xa0
       do_syscall_64+0xfa/0x3b0
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #4 (&ei->xattr_sem){++++}-{4:4}:
       lock_acquire+0x120/0x360
       down_read+0x46/0x2e0
       ext4_setattr+0x855/0x1bc0
       notify_change+0xb36/0xe40
       chown_common+0x40c/0x5c0
       do_fchownat+0x161/0x270
       __x64_sys_chown+0x82/0xa0
       do_syscall_64+0xfa/0x3b0
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #3 (jbd2_handle){++++}-{0:0}:
       lock_acquire+0x120/0x360
       start_this_handle+0x1fa7/0x21c0
       jbd2__journal_start+0x2c1/0x5b0
       jbd2_journal_start+0x2a/0x40
       ocfs2_start_trans+0x376/0x6d0
       ocfs2_mknod+0xe93/0x2050
       ocfs2_create+0x1a5/0x440
       path_openat+0x14f4/0x3830
       do_filp_open+0x1fa/0x410
       do_sys_openat2+0x121/0x1c0
       __x64_sys_openat+0x138/0x170
       do_syscall_64+0xfa/0x3b0
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (&journal->j_trans_barrier){.+.+}-{4:4}:
       lock_acquire+0x120/0x360
       down_read+0x46/0x2e0
       ocfs2_start_trans+0x36a/0x6d0
       ocfs2_mknod+0xe93/0x2050
       ocfs2_create+0x1a5/0x440
       path_openat+0x14f4/0x3830
       do_filp_open+0x1fa/0x410
       do_sys_openat2+0x121/0x1c0
       __x64_sys_openat+0x138/0x170
       do_syscall_64+0xfa/0x3b0
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (sb_internal#4){.+.+}-{0:0}:
       lock_acquire+0x120/0x360
       ocfs2_start_trans+0x26b/0x6d0
       ocfs2_mknod+0xe93/0x2050
       ocfs2_create+0x1a5/0x440
       path_openat+0x14f4/0x3830
       do_filp_open+0x1fa/0x410
       do_sys_openat2+0x121/0x1c0
       __x64_sys_openat+0x138/0x170
       do_syscall_64+0xfa/0x3b0
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4){+.+.}-{4:4}:
       validate_chain+0xb9b/0x2140
       __lock_acquire+0xab9/0xd20
       lock_acquire+0x120/0x360
       down_write+0x96/0x1f0
       ocfs2_reserve_local_alloc_bits+0x125/0x24e0
       ocfs2_reserve_clusters_with_limit+0x1be/0xba0
       ocfs2_lock_allocators+0x2fa/0x5c0
       ocfs2_extend_allocation+0x39b/0x17a0
       ocfs2_extend_no_holes+0x20e/0x4a0
       ocfs2_acquire_dquot+0x6c6/0xb30
       dqget+0x7b1/0xf10
       dquot_set_dqblk+0x2b/0xfa0
       quota_setquota+0x4b7/0x540
       __se_sys_quotactl+0x279/0x950
       do_syscall_64+0xfa/0x3b0
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4 --> &ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7 --> &ocfs2_quota_ip_alloc_sem_key

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_quota_ip_alloc_sem_key);
                               lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7);
                               lock(&ocfs2_quota_ip_alloc_sem_key);
  lock(&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#4);

 *** DEADLOCK ***

4 locks held by syz.6.10291/9196:
 #0: ffff8880398c20e0 (&type->s_umount_key#112){++++}-{4:4}, at: super_lock+0x2a9/0x3b0
 #1: ffff8881294ea0a8 (&dquot->dq_lock){+.+.}-{4:4}, at: ocfs2_acquire_dquot+0x2a3/0xb30
 #2: ffff888129426f40 (&ocfs2_sysfile_lock_key[args->fi_sysfile_type]#7){+.+.}-{4:4}, at: ocfs2_lock_global_qf+0x1ca/0x270
 #3: ffff888129426be0 (&ocfs2_quota_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_lock_global_qf+0x1e8/0x270

stack backtrace:
CPU: 1 UID: 0 PID: 9196 Comm: syz.6.10291 Not tainted 6.16.0-rc5-syzkaller-00193-g40f92e79b0aa #0 PREEMPT(full) 
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.2-debian-1.16.2-1 04/01/2014
Call Trace:
 <TASK>
 dump_stack_lvl+0x189/0x250
 print_circular_bug+0x2ee/0x310
 check_noncircular+0x134/0x160
 validate_chain+0xb9b/0x2140
 __lock_acquire+0xab9/0xd20
 lock_acquire+0x120/0x360
 down_write+0x96/0x1f0
 ocfs2_reserve_local_alloc_bits+0x125/0x24e0
 ocfs2_reserve_clusters_with_limit+0x1be/0xba0
 ocfs2_lock_allocators+0x2fa/0x5c0
 ocfs2_extend_allocation+0x39b/0x17a0
 ocfs2_extend_no_holes+0x20e/0x4a0
 ocfs2_acquire_dquot+0x6c6/0xb30
 dqget+0x7b1/0xf10
 dquot_set_dqblk+0x2b/0xfa0
 quota_setquota+0x4b7/0x540
 __se_sys_quotactl+0x279/0x950
 do_syscall_64+0xfa/0x3b0
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f479558e929
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f47963e0038 EFLAGS: 00000246 ORIG_RAX: 00000000000000b3
RAX: ffffffffffffffda RBX: 00007f47957b6080 RCX: 00007f479558e929
RDX: 000000003a736e6f RSI: 0000200000000040 RDI: ffffffff80000801
RBP: 00007f4795610b39 R08: 0000000000000000 R09: 0000000000000000
R10: 00002000000000c0 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000001 R14: 00007f47957b6080 R15: 00007fffcc6ffc08
 </TASK>
