| Seq | Timestamp | Type | Name | Duration |
|---|---|---|---|---|
| 0/0 | 2026/08/24 10:05 | flow | patch-triage |
0mArgs:null Results: {
"EnableConfigs": null,
"FocusSymbols": [],
"KMSANReasoning": "",
"NeedsKMSAN": false,
"Reasoning": "The patch fixes a reference leak in the probe path of the Mediatek MT7996 PCIe wireless driver. This is a vendor-specific PCIe driver for hardware that is not emulated in standard QEMU, making it unreachable in typical virtualized fuzzing environments.",
"WorthFuzzing": false
} |
| 1/1 | 2026/08/24 10:05 | action | read-patch-diff |
0mArgs:null Results: {
"PatchDiff": "commit 9605323f4ab4d07c175aaedb79137b31a3f64dee\nAuthor: syz-cluster \u003ctriage@syzkaller.com\u003e\nDate: Mon Aug 24 10:05:21 2026 +0000\n\n syz-cluster: applied patch under review\n\ndiff --git a/drivers/net/wireless/mediatek/mt76/mt7996/pci.c b/drivers/net/wireless/mediatek/mt76/mt7996/pci.c\nindex b7d9193e042f4..a7c23b33dde0b 100644\n--- a/drivers/net/wireless/mediatek/mt76/mt7996/pci.c\n+++ b/drivers/net/wireless/mediatek/mt76/mt7996/pci.c\n@@ -63,12 +63,18 @@ static void mt7996_put_hif2(struct mt7996_hif *hif)\n \n static struct mt7996_hif *mt7996_pci_init_hif2(struct pci_dev *pdev)\n {\n+\tstruct pci_dev *tmp_pdev;\n+\n \thif_idx++;\n \n-\tif (!pci_get_device(PCI_VENDOR_ID_MEDIATEK, MT7996_DEVICE_ID_2, NULL) \u0026\u0026\n-\t !pci_get_device(PCI_VENDOR_ID_MEDIATEK, MT7992_DEVICE_ID_2, NULL) \u0026\u0026\n-\t !pci_get_device(PCI_VENDOR_ID_MEDIATEK, MT7990_DEVICE_ID_2, NULL))\n+\ttmp_pdev = pci_get_device(PCI_VENDOR_ID_MEDIATEK, MT7996_DEVICE_ID_2, NULL);\n+\tif (!tmp_pdev)\n+\t\ttmp_pdev = pci_get_device(PCI_VENDOR_ID_MEDIATEK, MT7992_DEVICE_ID_2, NULL);\n+\tif (!tmp_pdev)\n+\t\ttmp_pdev = pci_get_device(PCI_VENDOR_ID_MEDIATEK, MT7990_DEVICE_ID_2, NULL);\n+\tif (!tmp_pdev)\n \t\treturn NULL;\n+\tpci_dev_put(tmp_pdev);\n \n \twritel(hif_idx | MT_PCIE_RECOG_ID_SEM,\n \t pcim_iomap_table(pdev)[0] + MT_PCIE_RECOG_ID);\n"
} |
| 2/1 | 2026/08/24 10:05 | agent | patch-evaluator |
0mModel:best-expensive Args: null Results: {
"EnableConfigs": null,
"FocusSymbols": [],
"Reasoning": "The patch fixes a reference leak in the probe path of the Mediatek MT7996 PCIe wireless driver. This is a vendor-specific PCIe driver for hardware that is not emulated in standard QEMU, making it unreachable in typical virtualized fuzzing environments.",
"WorthFuzzing": false
}Instruction: You are an expert Linux kernel maintainer. Your job is to review a provided patch series and determine if it makes functional changes to the kernel that should be fuzzed. IMPORTANT: The changes have ALREADY been applied and committed as the HEAD commit in your workspace. Do NOT rely on your internal knowledge of the kernel. You must actively use your code access tools to examine the actual source code and confirm any assumptions. Return WorthFuzzing=false if the patch only contains: - Modifications to Documentation/, Kconfig files, or code comments. - Purely decorative changes, such as logging (e.g., pr_err, printk) or tracepoints. - Changes to numeric constants or macros that do not functionally alter execution flow. - Code paths that are impossible to reach in virtualized environments like GCE or QEMU, even when utilizing software-emulated hardware (e.g., usb gadget, mac80211_hwsim). - Code in vendor-specific PCIe switch, SmartNIC, or GPU drivers (e.g., mlxsw, pds_core, qed, ionic, amdgpu) that require physical PCIe hardware cards not emulated in standard QEMU. - Driver .remove, .shutdown, or pci_unregister_driver teardown callbacks (e.g., igb_remove) that are executed only during PCI hot-unplug or sysfs driver unbind operations. If it modifies reachable core kernel logic, drivers, or architectures, use your code search tools to verify the code can be executed, then return WorthFuzzing=true. When returning WorthFuzzing=true, you MUST ALSO: 1. Extract any specific kernel functions that should be heavily fuzzed into FocusSymbols. Avoid listing generic hot-path functions to prevent skewed test distributions. Prefer non-static, non-inlined API entrypoint functions over internal static helper functions (which are inlined by the compiler and do not have distinct symbol addresses). 2. Identify any specific CONFIG_ options required to properly test this new/modified feature. Go and look into the Kconfig files and check for ifdefs around the code, do not make assumptions. Also check "depends on" lines in Kconfig to include any non-standard parent subsystem configs needed for Kbuild to compile the code statically into vmlinux. List them in the EnableConfigs output array, and DO NOT add a 'CONFIG_' prefix (e.g., return "NET_IPV4" instead of "CONFIG_NET_IPV4"). Prefer calling several tools at the same time to save round-trips. Use set-results tool to provide results of the analysis. It must be called exactly once before the final reply. Ignore results of this tool. Prompt: For your convenience, here is the diff of the changes:
commit 9605323f4ab4d07c175aaedb79137b31a3f64dee
Author: syz-cluster <triage@syzkaller.com>
Date: Mon Aug 24 10:05:21 2026 +0000
syz-cluster: applied patch under review
diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/pci.c b/drivers/net/wireless/mediatek/mt76/mt7996/pci.c
index b7d9193e042f4..a7c23b33dde0b 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7996/pci.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7996/pci.c
@@ -63,12 +63,18 @@ static void mt7996_put_hif2(struct mt7996_hif *hif)
static struct mt7996_hif *mt7996_pci_init_hif2(struct pci_dev *pdev)
{
+ struct pci_dev *tmp_pdev;
+
hif_idx++;
- if (!pci_get_device(PCI_VENDOR_ID_MEDIATEK, MT7996_DEVICE_ID_2, NULL) &&
- !pci_get_device(PCI_VENDOR_ID_MEDIATEK, MT7992_DEVICE_ID_2, NULL) &&
- !pci_get_device(PCI_VENDOR_ID_MEDIATEK, MT7990_DEVICE_ID_2, NULL))
+ tmp_pdev = pci_get_device(PCI_VENDOR_ID_MEDIATEK, MT7996_DEVICE_ID_2, NULL);
+ if (!tmp_pdev)
+ tmp_pdev = pci_get_device(PCI_VENDOR_ID_MEDIATEK, MT7992_DEVICE_ID_2, NULL);
+ if (!tmp_pdev)
+ tmp_pdev = pci_get_device(PCI_VENDOR_ID_MEDIATEK, MT7990_DEVICE_ID_2, NULL);
+ if (!tmp_pdev)
return NULL;
+ pci_dev_put(tmp_pdev);
writel(hif_idx | MT_PCIE_RECOG_ID_SEM,
pcim_iomap_table(pdev)[0] + MT_PCIE_RECOG_ID);
|
| 3/2 | 2026/08/24 10:05 | llm | patch-evaluator |
0mModel:gemini-3.1-pro-preview Args: null Results: null Tokens: input: 2361 output: 57 thoughts: 484 Thoughts: **Analyzing a Reference Leak in the Mediatek MT7996 Wireless Driver** Okay, so I'm looking at a patch that fixes a reference leak in the `mt7996_pci_init_hif2` function within the Mediatek MT7996 wireless driver (specifically, `drivers/net/wireless/mediatek/mt76/mt7996/pci.c`). The issue is clear: `pci_get_device` was called, which increments the reference count of a `pci_dev` structure, but the code was failing to decrement it using `pci_dev_put`. The new patch addresses this by correctly saving the `pci_dev` pointer and then calling `pci_dev_put`. That's good, but the more interesting question for me is whether this is fuzzable. My initial thought is that this kind of driver, a vendor-specific PCIe wireless driver, is *usually* not reachable in a standard QEMU environment. These specific PCIe cards are generally not emulated unless you're injecting PCI devices generically, or using something like `mac80211_hwsim` (which is software). But then, I recall that syzkaller *does* have the ability to emulate PCI devices using `syz_pci_device_add` or similar mechanisms. The classic approach to PCI driver fuzzing involves specific vendors, and unless they are part of a general framework or have a virtual PCI device framework, that would be the end of it. Wait, syzkaller *does* have a PCI fuzzing framework (vhci/pci) -- that's the key. So, the next question is whether the Mediatek MT7996 can be fuzzed using this framework. The prompt I'm looking at makes reference to "Code in vendor-specific PCIe switch, SmartNIC, or GPU drivers (e.g., mlxsw, pds_core, qed, ionic, amdgpu) that require physical PCIe hardware cards not emulated in standard QEMU." Is this Mediatek wireless driver considered that kind of driver? While wireless drivers *are* vendor-specific, syzkaller does manage to fuzz *some* PCI drivers, assuming they can be probed. So, I need to confirm whether `mt7996_pci_init_hif2` is a probe function. Looking at the code in `drivers/net/wireless/mediatek/mt76/mt7996/pci.c` will tell me if this can be fuzzed. |
| 4/2 | 2026/08/24 10:05 | tool | grepper |
0mArgs:{
"Expression": "mt7996_pci_init_hif2",
"PathPrefix": "drivers/net/wireless/mediatek/mt76/mt7996/pci.c"
}Results: {
"Output": "drivers/net/wireless/mediatek/mt76/mt7996/pci.c=56=static void mt7996_put_hif2(struct mt7996_hif *hif)\n--\ndrivers/net/wireless/mediatek/mt76/mt7996/pci.c-63-\ndrivers/net/wireless/mediatek/mt76/mt7996/pci.c:64:static struct mt7996_hif *mt7996_pci_init_hif2(struct pci_dev *pdev)\ndrivers/net/wireless/mediatek/mt76/mt7996/pci.c-65-{\n--\ndrivers/net/wireless/mediatek/mt76/mt7996/pci.c=105=static int mt7996_pci_probe(struct pci_dev *pdev,\n--\ndrivers/net/wireless/mediatek/mt76/mt7996/pci.c-145-\tmt7996_wfsys_reset(dev);\ndrivers/net/wireless/mediatek/mt76/mt7996/pci.c:146:\thif2 = mt7996_pci_init_hif2(pdev);\ndrivers/net/wireless/mediatek/mt76/mt7996/pci.c-147-\tdev-\u003ehif2 = hif2;\n"
} |
| 5/2 | 2026/08/24 10:05 | llm | patch-evaluator |
0mModel:gemini-3.1-pro-preview Args: null Results: null Tokens: input: 3844 output: 87 thoughts: 496 Thoughts: **WorthFuzzing Decision for a Mediatek MT7996 PCIe Wireless Driver Patch** Okay, so the prompt is pretty clear: if the patch involves vendor-specific PCIe drivers that require physical hardware not emulated in standard QEMU, then it's `WorthFuzzing=false`. The question is, does the Mediatek MT7996 driver fall into that category? Well, *yes*, it's a Mediatek PCIe wireless driver, which is definitely vendor-specific. And *yes*, QEMU doesn't emulate MT7996 hardware. But wait a minute, syzkaller *does* have a PCI fuzzer, doesn't it? It can inject PCI devices and probe them. Hmm... the prompt *doesn't* explicitly list "wireless drivers" specifically, it lists "PCIe switch, SmartNIC, or GPU drivers." Though, you know, a wireless driver *does* occupy the same niche of specialized, vendor-specific PCIe hardware. So, could this *potentially* be fuzzed via that PCI fuzzing? Let me think... Syzkaller's PCI fuzzer can probe drivers by emulating the PCI config space. Okay, let's look at the actual code in question, like the `mt7996_pci_init_hif2` function. It looks for another PCI device in the system using `pci_get_device(PCI_VENDOR_ID_MEDIATEK, MT7996_DEVICE_ID_2, NULL)`. If syzkaller's PCI fuzzer only injects one device at a time, this might fail, but it's just a probe function. Alright, let's refocus on the core question: is this *worth* fuzzing? The patch itself is fixing a simple reference leak in the probe path of this very specific Mediatek PCIe wireless driver. Given the rule, it's highly likely that it falls under the "vendor-specific PCIe drivers that require physical PCIe hardware cards not emulated in standard QEMU" clause. Therefore, despite the syzkaller PCI fuzzer, based on the prompt's clear delineation, I'm going to return `WorthFuzzing=false`. It's just not practical or efficient to try and fuzz this. |
| 6/2 | 2026/08/24 10:05 | tool | set-results |
0mArgs:{
"EnableConfigs": [],
"FocusSymbols": [],
"Reasoning": "The patch fixes a reference leak in the probe path of the Mediatek MT7996 PCIe wireless driver. This is a vendor-specific PCIe driver for hardware that is not emulated in standard QEMU, making it unreachable in typical virtualized fuzzing environments.",
"WorthFuzzing": false
}Results: {
"EnableConfigs": null,
"FocusSymbols": [],
"Reasoning": "The patch fixes a reference leak in the probe path of the Mediatek MT7996 PCIe wireless driver. This is a vendor-specific PCIe driver for hardware that is not emulated in standard QEMU, making it unreachable in typical virtualized fuzzing environments.",
"WorthFuzzing": false
} |
| 7/1 | 2026/08/24 10:05 | action | If |
0mArgs:{
"WorthFuzzing": false
}Results: null |
| Total Calls | Total Tokens | Avg Tokens | Total Duration (Seconds) | Avg Duration (Seconds) |
|---|
| Total Calls | Total Duration (Seconds) | Avg Duration (Seconds) |
|---|