======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
kworker/u10:4/3336 is trying to acquire lock:
ffff888172799af0 (&HFS_I(tree->inode)->extents_lock){+.+.}-{4:4}, at: hfs_extend_file+0xf2/0x15e0

but task is already holding lock:
ffff8881738ca0a8 (&tree->tree_lock#2/1){+.+.}-{4:4}, at: hfs_find_init+0x18e/0x300

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&tree->tree_lock#2/1){+.+.}-{4:4}:
       __mutex_lock+0x1a3/0x1550
       hfs_find_init+0x18e/0x300
       hfs_extend_file+0x35c/0x15e0
       hfs_bmap_reserve+0x107/0x430
       hfs_cat_create+0x20f/0x800
       hfs_create+0x75/0xe0
       path_openat+0x1395/0x3860
       do_file_open+0x23e/0x4a0
       do_sys_openat2+0x113/0x200
       __x64_sys_openat+0x138/0x170
       do_syscall_64+0x15f/0xf80
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&HFS_I(tree->inode)->extents_lock){+.+.}-{4:4}:
       __lock_acquire+0x15a5/0x2cf0
       lock_acquire+0x106/0x350
       __mutex_lock+0x1a3/0x1550
       hfs_extend_file+0xf2/0x15e0
       hfs_bmap_reserve+0x107/0x430
       __hfs_ext_write_extent+0x1fa/0x470
       hfs_ext_write_extent+0x17e/0x210
       hfs_write_inode+0x117/0x960
       __writeback_single_inode+0x75a/0x10e0
       writeback_sb_inodes+0x979/0x19d0
       wb_writeback+0x445/0xb00
       wb_workfn+0x3f8/0xf10
       process_scheduled_works+0xb5d/0x1860
       worker_thread+0xa53/0xfc0
       kthread+0x388/0x470
       ret_from_fork+0x514/0xb70
       ret_from_fork_asm+0x1a/0x30

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&tree->tree_lock#2/1);
                               lock(&HFS_I(tree->inode)->extents_lock);
                               lock(&tree->tree_lock#2/1);
  lock(&HFS_I(tree->inode)->extents_lock);

 *** DEADLOCK ***

3 locks held by kworker/u10:4/3336:
 #0: ffff8881626cf940 ((wq_completion)writeback){+.+.}-{0:0}, at: process_scheduled_works+0xa35/0x1860
 #1: ffffc90022897c40 ((work_completion)(&(&wb->dwork)->work)){+.+.}-{0:0}, at: process_scheduled_works+0xa70/0x1860
 #2: ffff8881738ca0a8 (&tree->tree_lock#2/1){+.+.}-{4:4}, at: hfs_find_init+0x18e/0x300

stack backtrace:
CPU: 1 UID: 0 PID: 3336 Comm: kworker/u10:4 Not tainted syzkaller #0 PREEMPT(full) 
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.2-debian-1.16.2-1 04/01/2014
Workqueue: writeback wb_workfn (flush-7:0)
Call Trace:
 <TASK>
 dump_stack_lvl+0xe8/0x150
 print_circular_bug+0x2e1/0x300
 check_noncircular+0x12e/0x150
 __lock_acquire+0x15a5/0x2cf0
 lock_acquire+0x106/0x350
 __mutex_lock+0x1a3/0x1550
 hfs_extend_file+0xf2/0x15e0
 hfs_bmap_reserve+0x107/0x430
 __hfs_ext_write_extent+0x1fa/0x470
 hfs_ext_write_extent+0x17e/0x210
 hfs_write_inode+0x117/0x960
 __writeback_single_inode+0x75a/0x10e0
 writeback_sb_inodes+0x979/0x19d0
 wb_writeback+0x445/0xb00
 wb_workfn+0x3f8/0xf10
 process_scheduled_works+0xb5d/0x1860
 worker_thread+0xa53/0xfc0
 kthread+0x388/0x470
 ret_from_fork+0x514/0xb70
 ret_from_fork_asm+0x1a/0x30
 </TASK>
hfs: new node 0 already hashed?
------------[ cut here ]------------
1
WARNING: fs/hfs/bnode.c:520 at hfs_bnode_create+0x461/0x4f0, CPU#1: kworker/u10:4/3336
Modules linked in:
CPU: 1 UID: 0 PID: 3336 Comm: kworker/u10:4 Not tainted syzkaller #0 PREEMPT(full) 
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.2-debian-1.16.2-1 04/01/2014
Workqueue: writeback wb_workfn (flush-7:0)
RIP: 0010:hfs_bnode_create+0x461/0x4f0
Code: e8 8b 89 ee e8 20 af 77 fe e9 cf fc ff ff e8 66 c3 15 ff 4c 89 ef e8 fe 80 fb 08 48 c7 c7 e0 32 e8 8b 89 ee e8 00 af 77 fe 90 <0f> 0b 90 eb b0 44 89 f1 80 e1 07 80 c1 03 38 c1 0f 8c d6 fb ff ff
RSP: 0018:ffffc90022896c60 EFLAGS: 00010246
RAX: 000000000000001f RBX: ffff8881738ca000 RCX: 53b49055646ad200
RDX: 0000000000000000 RSI: 0000000080000000 RDI: 0000000000000000
RBP: 0000000000000000 R08: ffffffff9030bdf7 R09: 1ffffffff20617be
R10: dffffc0000000000 R11: fffffbfff20617bf R12: 0000000000000000
R13: ffff8881738ca0d8 R14: ffff8881622af700 R15: dffffc0000000000
FS:  0000000000000000(0000) GS:ffff8882a928c000(0000) knlGS:0000000000000000
CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: 0000561cc0c4d000 CR3: 000000016c86c000 CR4: 00000000000006f0
Call Trace:
 <TASK>
 hfs_bmap_alloc+0x5c1/0x650
 hfs_btree_inc_height+0x100/0xad0
 hfs_brec_insert+0x7ef/0xc90
 __hfs_ext_write_extent+0x2a1/0x470
 hfs_ext_write_extent+0x17e/0x210
 hfs_write_inode+0x117/0x960
 __writeback_single_inode+0x75a/0x10e0
 writeback_sb_inodes+0x979/0x19d0
 wb_writeback+0x445/0xb00
 wb_workfn+0x3f8/0xf10
 process_scheduled_works+0xb5d/0x1860
 worker_thread+0xa53/0xfc0
 kthread+0x388/0x470
 ret_from_fork+0x514/0xb70
 ret_from_fork_asm+0x1a/0x30
 </TASK>
