| Seq | Timestamp | Type | Name | Duration |
|---|---|---|---|---|
| 0/0 | 2026/10/02 16:17 | flow | patch-triage |
1mArgs:null Results: {
"EnableConfigs": null,
"FocusSymbols": [],
"KMSANReasoning": "",
"NeedsKMSAN": false,
"Reasoning": "The patch series refactors TC and ACL handling and updates ACL port activation logic in the Motorcomm YT9215 Ethernet switch driver (drivers/net/dsa/motorcomm/). This driver requires a physical Motorcomm YT9215 switch ASIC on an MDIO bus with matching device tree bindings, which is not emulated in standard QEMU/virtualized environments. Thus, the modified code is structurally unreachable hardware and does not warrant fuzzing.",
"WorthFuzzing": false
} |
| 1/1 | 2026/10/02 16:17 | action | read-patch-diff |
0mArgs:null Results: {
"PatchDiff": "commit 71e25225fb34cd132334bf068343c5e16cab4b5b\nAuthor: syz-cluster \u003ctriage@syzkaller.com\u003e\nDate: Fri Oct 2 16:17:28 2026 +0000\n\n syz-cluster: applied patch under review\n\ndiff --git a/drivers/net/dsa/motorcomm/Makefile b/drivers/net/dsa/motorcomm/Makefile\nindex 1d2c1b3064c41..b4a577012b0fb 100644\n--- a/drivers/net/dsa/motorcomm/Makefile\n+++ b/drivers/net/dsa/motorcomm/Makefile\n@@ -5,3 +5,4 @@ yt921x-$(CONFIG_NET_DSA_YT921X_LEDS) += leds.o\n yt921x-objs += mdio_bus.o\n yt921x-objs += pcs-921x.o\n yt921x-objs += smi.o\n+yt921x-objs += tc.o\ndiff --git a/drivers/net/dsa/motorcomm/chip.c b/drivers/net/dsa/motorcomm/chip.c\nindex 3ff2de383157a..4b8cb2ba28b73 100644\n--- a/drivers/net/dsa/motorcomm/chip.c\n+++ b/drivers/net/dsa/motorcomm/chip.c\n@@ -23,13 +23,13 @@\n #include \u003cnet/dsa.h\u003e\n #include \u003cnet/dscp.h\u003e\n #include \u003cnet/ieee8021q.h\u003e\n-#include \u003cnet/pkt_cls.h\u003e\n \n #include \"chip.h\"\n #include \"leds.h\"\n #include \"mdio_bus.h\"\n #include \"pcs.h\"\n #include \"smi.h\"\n+#include \"tc.h\"\n \n struct yt921x_mib_desc {\n \tunsigned int size;\n@@ -171,19 +171,6 @@ struct yt921x_reg_mdio {\n \n /* TODO: SPI/I2C */\n \n-#define to_yt921x_priv(_ds) container_of_const(_ds, struct yt921x_priv, ds)\n-#define to_device(priv) ((priv)-\u003eds.dev)\n-\n-static u32 ethaddr_hi4_to_u32(const unsigned char *addr)\n-{\n-\treturn (addr[0] \u003c\u003c 24) | (addr[1] \u003c\u003c 16) | (addr[2] \u003c\u003c 8) | addr[3];\n-}\n-\n-static u32 ethaddr_lo2_to_u32(const unsigned char *addr)\n-{\n-\treturn (addr[4] \u003c\u003c 8) | addr[5];\n-}\n-\n static int yt921x_reg_mdio_read(void *context, u32 reg, u32 *valp)\n {\n \tstruct yt921x_reg_mdio *mdio = context;\n@@ -272,7 +259,7 @@ static const struct yt921x_reg_ops yt921x_reg_ops_mdio = {\n static int yt921x_read_mib(struct yt921x_priv *priv, int port)\n {\n \tstruct yt921x_port *pp = \u0026priv-\u003eports[port];\n-\tstruct device *dev = to_device(priv);\n+\tstruct device *dev = yt921x_priv_to_device(priv);\n \tstruct yt921x_mib *mib = \u0026pp-\u003emib;\n \tint res = 0;\n \n@@ -364,7 +351,7 @@ yt921x_dsa_get_strings(struct dsa_switch *ds, int port, u32 stringset,\n static void\n yt921x_dsa_get_ethtool_stats(struct dsa_switch *ds, int port, uint64_t *data)\n {\n-\tstruct yt921x_priv *priv = to_yt921x_priv(ds);\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(ds);\n \tstruct yt921x_port *pp = \u0026priv-\u003eports[port];\n \tstruct yt921x_mib *mib = \u0026pp-\u003emib;\n \tsize_t j;\n@@ -406,7 +393,7 @@ static void\n yt921x_dsa_get_eth_mac_stats(struct dsa_switch *ds, int port,\n \t\t\t struct ethtool_eth_mac_stats *mac_stats)\n {\n-\tstruct yt921x_priv *priv = to_yt921x_priv(ds);\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(ds);\n \tstruct yt921x_port *pp = \u0026priv-\u003eports[port];\n \tstruct yt921x_mib *mib = \u0026pp-\u003emib;\n \n@@ -442,7 +429,7 @@ static void\n yt921x_dsa_get_eth_ctrl_stats(struct dsa_switch *ds, int port,\n \t\t\t struct ethtool_eth_ctrl_stats *ctrl_stats)\n {\n-\tstruct yt921x_priv *priv = to_yt921x_priv(ds);\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(ds);\n \tstruct yt921x_port *pp = \u0026priv-\u003eports[port];\n \tstruct yt921x_mib *mib = \u0026pp-\u003emib;\n \n@@ -471,7 +458,7 @@ yt921x_dsa_get_rmon_stats(struct dsa_switch *ds, int port,\n \t\t\t struct ethtool_rmon_stats *rmon_stats,\n \t\t\t const struct ethtool_rmon_hist_range **ranges)\n {\n-\tstruct yt921x_priv *priv = to_yt921x_priv(ds);\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(ds);\n \tstruct yt921x_port *pp = \u0026priv-\u003eports[port];\n \tstruct yt921x_mib *mib = \u0026pp-\u003emib;\n \n@@ -507,7 +494,7 @@ static void\n yt921x_dsa_get_stats64(struct dsa_switch *ds, int port,\n \t\t struct rtnl_link_stats64 *stats)\n {\n-\tstruct yt921x_priv *priv = to_yt921x_priv(ds);\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(ds);\n \tstruct yt921x_port *pp = \u0026priv-\u003eports[port];\n \tstruct yt921x_mib *mib = \u0026pp-\u003emib;\n \n@@ -543,7 +530,7 @@ static void\n yt921x_dsa_get_pause_stats(struct dsa_switch *ds, int port,\n \t\t\t struct ethtool_pause_stats *pause_stats)\n {\n-\tstruct yt921x_priv *priv = to_yt921x_priv(ds);\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(ds);\n \tstruct yt921x_port *pp = \u0026priv-\u003eports[port];\n \tstruct yt921x_mib *mib = \u0026pp-\u003emib;\n \n@@ -598,7 +585,7 @@ yt921x_set_eee(struct yt921x_priv *priv, int port, struct ethtool_keee *e)\n static int\n yt921x_dsa_set_mac_eee(struct dsa_switch *ds, int port, struct ethtool_keee *e)\n {\n-\tstruct yt921x_priv *priv = to_yt921x_priv(ds);\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(ds);\n \tint res;\n \n \tmutex_lock(\u0026priv-\u003ereg_lock);\n@@ -608,13 +595,6 @@ yt921x_dsa_set_mac_eee(struct dsa_switch *ds, int port, struct ethtool_keee *e)\n \treturn res;\n }\n \n-static int yt921x_mtu_fetch(struct yt921x_priv *priv, int port)\n-{\n-\tstruct dsa_port *dp = dsa_to_port(\u0026priv-\u003eds, port);\n-\n-\treturn dp-\u003euser ? READ_ONCE(dp-\u003euser-\u003emtu) : ETH_DATA_LEN;\n-}\n-\n static int\n yt921x_dsa_port_change_mtu(struct dsa_switch *ds, int port, int new_mtu)\n {\n@@ -622,7 +602,7 @@ yt921x_dsa_port_change_mtu(struct dsa_switch *ds, int port, int new_mtu)\n \t * maximum after reset\n \t */\n \n-\tstruct yt921x_priv *priv = to_yt921x_priv(ds);\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(ds);\n \tstruct dsa_port *dp = dsa_to_port(ds, port);\n \tint frame_size;\n \tint res;\n@@ -646,1445 +626,6 @@ static int yt921x_dsa_port_max_mtu(struct dsa_switch *ds, int port)\n \treturn YT921X_FRAME_SIZE_MAX - ETH_HLEN - ETH_FCS_LEN - YT921X_TAG_LEN;\n }\n \n-/* v * 2^e */\n-static u64 ldexpu64(u64 v, int e)\n-{\n-\treturn e \u003e= 0 ? v \u003c\u003c e : v \u003e\u003e -e;\n-}\n-\n-/* slot (ns) * rate (/s) / 10^9 (ns/s) = 2^C * token * 4^unit */\n-static u32 rate2token(u64 rate, unsigned int slot_ns, int unit, int C)\n-{\n-\tint e = 2 * unit + C + YT921X_TOKEN_RATE_C;\n-\n-\treturn div_u64(ldexpu64(slot_ns * rate, -e), 1000000000);\n-}\n-\n-static u64 token2rate(u32 token, unsigned int slot_ns, int unit, int C)\n-{\n-\tint e = 2 * unit + C + YT921X_TOKEN_RATE_C;\n-\n-\treturn div_u64(ldexpu64(mul_u32_u32(1000000000, token), e), slot_ns);\n-}\n-\n-/* burst = 2^C * token * 4^unit */\n-static u32 burst2token(u64 burst, int unit, int C)\n-{\n-\treturn ldexpu64(burst, -(2 * unit + C));\n-}\n-\n-static u64 token2burst(u32 token, int unit, int C)\n-{\n-\treturn ldexpu64(token, 2 * unit + C);\n-}\n-\n-struct yt921x_marker {\n-\tu32 cir;\n-\tu32 cbs;\n-\tu32 ebs;\n-\tint unit;\n-\tbool pkt_mode;\n-};\n-\n-#define YT921X_MARKER_PKT_MODE\t\tBIT(0)\n-#define YT921X_MARKER_SINGLE_BUCKET\tBIT(1)\n-\n-static int\n-yt921x_marker_tfm(struct yt921x_marker *marker, u64 rate, u64 burst,\n-\t\t unsigned int flags, unsigned int slot_ns, u32 cir_max,\n-\t\t u32 cbs_max, int unit_max, struct yt921x_priv *priv, int port,\n-\t\t struct netlink_ext_ack *extack)\n-{\n-\tconst int C = flags \u0026 YT921X_MARKER_PKT_MODE ? YT921X_TOKEN_PKT_C :\n-\t\t YT921X_TOKEN_BYTE_C;\n-\tstruct device *dev = to_device(priv);\n-\tstruct yt921x_marker m;\n-\tu64 burst_est;\n-\tu64 burst_sug;\n-\tu64 burst_max;\n-\tu64 rate_max;\n-\n-\tm.unit = unit_max;\n-\trate_max = token2rate(cir_max, slot_ns, m.unit, C);\n-\tburst_max = token2burst(cbs_max, m.unit, C);\n-\n-\t/* Check for unusual values */\n-\tif (rate \u003e rate_max || burst \u003e burst_max) {\n-\t\tNL_SET_ERR_MSG_MOD(extack, \"Unexpected tremendous rate\");\n-\t\treturn -ERANGE;\n-\t}\n-\n-\t/* Check for matching burst */\n-\tburst_est = div_u64(slot_ns * rate, 1000000000);\n-\tburst_sug = burst_est;\n-\tif (flags \u0026 YT921X_MARKER_PKT_MODE)\n-\t\tburst_sug++;\n-\telse\n-\t\tburst_sug += ETH_HLEN + yt921x_mtu_fetch(priv, port) +\n-\t\t\t ETH_FCS_LEN;\n-\tif (burst_sug \u003e burst)\n-\t\tNL_SET_ERR_MSG_FMT_MOD(extack,\n-\t\t\t\t \"Consider match rate %llu with burst at least %llu\",\n-\t\t\t\t rate, burst_sug);\n-\n-\t/* Select unit */\n-\tfor (; m.unit \u003e 0; m.unit--) {\n-\t\tif (rate \u003e (rate_max \u003e\u003e 2) || burst \u003e (burst_max \u003e\u003e 2))\n-\t\t\tbreak;\n-\t\trate_max \u003e\u003e= 2;\n-\t\tburst_max \u003e\u003e= 2;\n-\t}\n-\n-\t/* Calculate information rate and bucket size */\n-\tm.cir = rate2token(rate, slot_ns, m.unit, C);\n-\tif (!m.cir)\n-\t\tm.cir = 1;\n-\telse if (WARN_ON(m.cir \u003e cir_max))\n-\t\tm.cir = cir_max;\n-\tm.cbs = burst2token(burst, m.unit, C);\n-\tif (!m.cbs)\n-\t\tm.cbs = 1;\n-\telse if (WARN_ON(m.cbs \u003e cbs_max))\n-\t\tm.cbs = cbs_max;\n-\n-\t/* Cut EBS */\n-\tm.ebs = 0;\n-\tif (!(flags \u0026 YT921X_MARKER_SINGLE_BUCKET)) {\n-\t\t/* We don't have a chance to adjust rate when MTU is changed */\n-\t\tif (flags \u0026 YT921X_MARKER_PKT_MODE)\n-\t\t\tburst_est++;\n-\t\telse\n-\t\t\tburst_est += YT921X_FRAME_SIZE_MAX;\n-\n-\t\tif (burst_est \u003c burst) {\n-\t\t\tu32 pbs = m.cbs;\n-\n-\t\t\tm.cbs = burst2token(burst_est, m.unit, C);\n-\t\t\tif (!m.cbs)\n-\t\t\t\tm.cbs = 1;\n-\t\t\telse if (WARN_ON(m.cbs \u003e cbs_max))\n-\t\t\t\tm.cbs = cbs_max;\n-\n-\t\t\tif (pbs \u003e m.cbs)\n-\t\t\t\tm.ebs = pbs - m.cbs;\n-\t\t}\n-\t}\n-\n-\tdev_dbg(dev,\n-\t\t\"slot %u ns, rate %llu, burst %llu -\u003e unit %d, cir %u, cbs %u, ebs %u\\n\",\n-\t\tslot_ns, rate, burst, m.unit, m.cir, m.cbs, m.ebs);\n-\n-\tm.pkt_mode = flags \u0026 YT921X_MARKER_PKT_MODE;\n-\t*marker = m;\n-\treturn 0;\n-}\n-\n-static int\n-yt921x_marker_tfm_police(struct yt921x_marker *marker,\n-\t\t\t const struct flow_action_police *police,\n-\t\t\t unsigned int flags, struct yt921x_priv *priv, int port,\n-\t\t\t struct netlink_ext_ack *extack)\n-{\n-\tbool pkt_mode = !!police-\u003erate_pkt_ps;\n-\tu64 burst;\n-\tu64 rate;\n-\n-\trate = pkt_mode ? police-\u003erate_pkt_ps : police-\u003erate_bytes_ps;\n-\tburst = pkt_mode ? police-\u003eburst_pkt : police-\u003eburst;\n-\tif (pkt_mode)\n-\t\tflags |= YT921X_MARKER_PKT_MODE;\n-\n-\treturn yt921x_marker_tfm(marker, rate, burst, flags,\n-\t\t\t\t priv-\u003emeter_slot_ns, YT921X_METER_CIR_MAX,\n-\t\t\t\t YT921X_METER_CBS_MAX, YT921X_METER_UNIT_MAX,\n-\t\t\t\t priv, port, extack);\n-}\n-\n-static int\n-yt921x_marker_tfm_shape(struct yt921x_marker *marker, u64 rate, u64 burst,\n-\t\t\tunsigned int flags, struct yt921x_priv *priv, int port,\n-\t\t\tstruct netlink_ext_ack *extack)\n-{\n-\treturn yt921x_marker_tfm(marker, rate, burst, flags,\n-\t\t\t\t priv-\u003eport_shape_slot_ns, YT921X_SHAPE_CIR_MAX,\n-\t\t\t\t YT921X_SHAPE_CBS_MAX, YT921X_SHAPE_UNIT_MAX,\n-\t\t\t\t priv, port, extack);\n-}\n-\n-static int\n-yt921x_police_validate(const struct flow_action_police *police,\n-\t\t const struct flow_action *action,\n-\t\t const struct flow_action_entry *act,\n-\t\t struct netlink_ext_ack *extack)\n-{\n-\tif (police-\u003eexceed.act_id != FLOW_ACTION_DROP) {\n-\t\tNL_SET_ERR_MSG_MOD(extack,\n-\t\t\t\t \"Offload not supported when exceed action is not drop\");\n-\t\treturn -EOPNOTSUPP;\n-\t}\n-\n-\tif (police-\u003enotexceed.act_id != FLOW_ACTION_PIPE \u0026\u0026\n-\t police-\u003enotexceed.act_id != FLOW_ACTION_ACCEPT) {\n-\t\tNL_SET_ERR_MSG_MOD(extack,\n-\t\t\t\t \"Offload not supported when conform action is not pipe or ok\");\n-\t\treturn -EOPNOTSUPP;\n-\t}\n-\n-\tif (police-\u003enotexceed.act_id == FLOW_ACTION_ACCEPT \u0026\u0026 action \u0026\u0026 act \u0026\u0026\n-\t !flow_action_is_last_entry(action, act)) {\n-\t\tNL_SET_ERR_MSG_MOD(extack,\n-\t\t\t\t \"Offload not supported when conform action is ok, but action is not last\");\n-\t\treturn -EOPNOTSUPP;\n-\t}\n-\n-\t/* mtu defaults to unlimited but we got 2040 here, don't know why */\n-\tif (police-\u003epeakrate_bytes_ps || police-\u003eavrate || police-\u003eoverhead) {\n-\t\tNL_SET_ERR_MSG_MOD(extack,\n-\t\t\t\t \"Offload not supported when peakrate/avrate/overhead is configured\");\n-\t\treturn -EOPNOTSUPP;\n-\t}\n-\n-\treturn 0;\n-}\n-\n-static int\n-yt921x_meter_config(struct yt921x_priv *priv, unsigned int id,\n-\t\t const struct yt921x_marker *marker)\n-{\n-\tu32 ctrls[3];\n-\n-\tctrls[0] = 0;\n-\tctrls[1] = YT921X_METER_CTRLb_CIR(marker-\u003ecir);\n-\tctrls[2] = YT921X_METER_CTRLc_UNIT(marker-\u003eunit) |\n-\t\t YT921X_METER_CTRLc_DROP_R |\n-\t\t YT921X_METER_CTRLc_TOKEN_OVERFLOW_EN |\n-\t\t YT921X_METER_CTRLc_METER_EN;\n-\tif (marker-\u003epkt_mode)\n-\t\tctrls[2] |= YT921X_METER_CTRLc_PKT_MODE;\n-\tupdate_ctrls_unaligned(\u0026ctrls[0], \u0026ctrls[1],\n-\t\t\t YT921X_METER_CTRLab_EBS_M,\n-\t\t\t YT921X_METER_CTRLab_EBS(marker-\u003eebs));\n-\tupdate_ctrls_unaligned(\u0026ctrls[1], \u0026ctrls[2],\n-\t\t\t YT921X_METER_CTRLbc_CBS_M,\n-\t\t\t YT921X_METER_CTRLbc_CBS(marker-\u003ecbs));\n-\n-\treturn yt921x_reg96_write(priv, YT921X_METERn_CTRL(id), ctrls);\n-}\n-\n-static void yt921x_dsa_port_policer_del(struct dsa_switch *ds, int port)\n-{\n-\tstruct yt921x_priv *priv = to_yt921x_priv(ds);\n-\tstruct device *dev = to_device(priv);\n-\tint res;\n-\n-\tmutex_lock(\u0026priv-\u003ereg_lock);\n-\tres = yt921x_reg_write(priv, YT921X_PORTn_METER(port), 0);\n-\tmutex_unlock(\u0026priv-\u003ereg_lock);\n-\n-\tif (res)\n-\t\tdev_err(dev, \"Failed to %s port %d: %i\\n\", \"delete policer on\",\n-\t\t\tport, res);\n-}\n-\n-static int\n-yt921x_dsa_port_policer_add(struct dsa_switch *ds, int port,\n-\t\t\t const struct flow_action_police *police,\n-\t\t\t struct netlink_ext_ack *extack)\n-{\n-\tstruct yt921x_priv *priv = to_yt921x_priv(ds);\n-\tstruct yt921x_marker marker;\n-\tu32 ctrl;\n-\tint res;\n-\n-\tres = yt921x_police_validate(police, NULL, NULL, extack);\n-\tif (res)\n-\t\treturn res;\n-\n-\tres = yt921x_marker_tfm_police(\u0026marker, police, 0, priv, port, extack);\n-\tif (res)\n-\t\treturn res;\n-\n-\tmutex_lock(\u0026priv-\u003ereg_lock);\n-\tres = yt921x_meter_config(priv, port + YT921X_METER_NUM, \u0026marker);\n-\tif (res)\n-\t\tgoto end;\n-\n-\tctrl = YT921X_PORT_METER_ID(port) | YT921X_PORT_METER_EN;\n-\tres = yt921x_reg_write(priv, YT921X_PORTn_METER(port), ctrl);\n-end:\n-\tmutex_unlock(\u0026priv-\u003ereg_lock);\n-\n-\treturn res;\n-}\n-\n-static int\n-yt921x_dsa_port_setup_tc_tbf_port(struct dsa_switch *ds, int port,\n-\t\t\t\t const struct tc_tbf_qopt_offload *qopt)\n-{\n-\tstruct yt921x_priv *priv = to_yt921x_priv(ds);\n-\tstruct netlink_ext_ack *extack = qopt-\u003eextack;\n-\tu32 ctrls[2];\n-\tint res;\n-\n-\tif (qopt-\u003eparent != TC_H_ROOT)\n-\t\treturn -EOPNOTSUPP;\n-\n-\tswitch (qopt-\u003ecommand) {\n-\tcase TC_TBF_STATS:\n-\t\t/* Unfortunately the convention for TC_*_STATS is a mess,\n-\t\t * neither 0 nor -EOPNOTSUPP is perfect here.\n-\t\t */\n-\t\treturn -EOPNOTSUPP;\n-\tcase TC_TBF_DESTROY:\n-\t\tctrls[0] = 0;\n-\t\tctrls[1] = 0;\n-\t\tbreak;\n-\tcase TC_TBF_REPLACE: {\n-\t\tconst struct tc_tbf_qopt_offload_replace_params *p;\n-\t\tstruct yt921x_marker marker;\n-\n-\t\tp = \u0026qopt-\u003ereplace_params;\n-\n-\t\tres = yt921x_marker_tfm_shape(\u0026marker, p-\u003erate.rate_bytes_ps,\n-\t\t\t\t\t p-\u003emax_size,\n-\t\t\t\t\t YT921X_MARKER_SINGLE_BUCKET,\n-\t\t\t\t\t priv, port, extack);\n-\t\tif (res)\n-\t\t\treturn res;\n-\n-\t\tctrls[0] = YT921X_PORT_SHAPE_CTRLa_CIR(marker.cir) |\n-\t\t\t YT921X_PORT_SHAPE_CTRLa_CBS(marker.cbs);\n-\t\tctrls[1] = YT921X_PORT_SHAPE_CTRLb_UNIT(marker.unit) |\n-\t\t\t YT921X_PORT_SHAPE_CTRLb_EN;\n-\t\tbreak;\n-\t}\n-\tdefault:\n-\t\treturn -EOPNOTSUPP;\n-\t}\n-\n-\tmutex_lock(\u0026priv-\u003ereg_lock);\n-\tres = yt921x_reg64_write(priv, YT921X_PORTn_SHAPE_CTRL(port), ctrls);\n-\tmutex_unlock(\u0026priv-\u003ereg_lock);\n-\n-\treturn res;\n-}\n-\n-static int\n-yt921x_dsa_port_setup_tc(struct dsa_switch *ds, int port,\n-\t\t\t enum tc_setup_type type, void *type_data)\n-{\n-\tswitch (type) {\n-\tcase TC_SETUP_QDISC_TBF: {\n-\t\tconst struct tc_tbf_qopt_offload *qopt = type_data;\n-\n-\t\treturn yt921x_dsa_port_setup_tc_tbf_port(ds, port, qopt);\n-\t}\n-\tdefault:\n-\t\treturn -EOPNOTSUPP;\n-\t}\n-}\n-\n-/* ACL: 48 blocks * 8 entries\n- *\n- * One rule can span multiple entries, but within a block.\n- */\n-\n-static void\n-yt921x_acl_entry_set(struct yt921x_acl_entry *entry, unsigned int offset,\n-\t\t u32 flags, bool set)\n-{\n-\tif (set)\n-\t\tentry-\u003ekey[offset] |= flags;\n-\tentry-\u003emask[offset] |= flags;\n-}\n-\n-static unsigned int\n-yt921x_acl_entries_set_is_fragment(struct yt921x_acl_entry *entries,\n-\t\t\t\t unsigned int size, bool set)\n-{\n-\tfor (unsigned int i = 0; i \u003c size; i++)\n-\t\tswitch (FIELD_GET(YT921X_ACL_KEYb_TYPE_M, entries[i].key[1])) {\n-\t\tcase YT921X_ACL_TYPE_IPV4_DA:\n-\t\tcase YT921X_ACL_TYPE_IPV4_SA:\n-\t\t\tyt921x_acl_entry_set(\u0026entries[i], 1,\n-\t\t\t\t\t YT921X_ACL_BINb_IPV4_FRAG, set);\n-\t\t\treturn size;\n-\t\tcase YT921X_ACL_TYPE_IPV6_DA3:\n-\t\tcase YT921X_ACL_TYPE_IPV6_SA3:\n-\t\t\tyt921x_acl_entry_set(\u0026entries[i], 1,\n-\t\t\t\t\t YT921X_ACL_BINb_IPV6_xA3_FRAG,\n-\t\t\t\t\t set);\n-\t\t\treturn size;\n-\t\tcase YT921X_ACL_TYPE_MISC:\n-\t\t\tyt921x_acl_entry_set(\u0026entries[i], 1,\n-\t\t\t\t\t YT921X_ACL_BINb_MISC_FRAG, set);\n-\t\t\treturn size;\n-\t\tcase YT921X_ACL_TYPE_L4:\n-\t\t\tyt921x_acl_entry_set(\u0026entries[i], 1,\n-\t\t\t\t\t YT921X_ACL_BINb_L4_FRAG, set);\n-\t\t\treturn size;\n-\t\t}\n-\n-\tif (size \u003e= YT921X_ACL_ENT_PER_BLK)\n-\t\treturn 0;\n-\n-\tentries[size] = (typeof(*entries)){};\n-\tentries[size].key[1] = YT921X_ACL_KEYb_TYPE(YT921X_ACL_TYPE_MISC);\n-\tyt921x_acl_entry_set(\u0026entries[size], 1, YT921X_ACL_BINb_MISC_FRAG, set);\n-\n-\treturn size + 1;\n-}\n-\n-static unsigned int\n-yt921x_acl_entries_set_first_frag(struct yt921x_acl_entry *entries,\n-\t\t\t\t unsigned int size, bool set)\n-{\n-\tfor (unsigned int i = 0; i \u003c size; i++)\n-\t\tswitch (FIELD_GET(YT921X_ACL_KEYb_TYPE_M, entries[i].key[1])) {\n-\t\tcase YT921X_ACL_TYPE_IPV6_DA2:\n-\t\tcase YT921X_ACL_TYPE_IPV6_SA2:\n-\t\t\tyt921x_acl_entry_set(\u0026entries[i], 1,\n-\t\t\t\t\t YT921X_ACL_BINb_IPV6_xA2_FIRST_FRAG,\n-\t\t\t\t\t set);\n-\t\t\treturn size;\n-\t\tcase YT921X_ACL_TYPE_MISC:\n-\t\t\tyt921x_acl_entry_set(\u0026entries[i], 0,\n-\t\t\t\t\t YT921X_ACL_BINa_MISC_FIRST_FRAG,\n-\t\t\t\t\t set);\n-\t\t\treturn size;\n-\t\t}\n-\n-\tif (size \u003e= YT921X_ACL_ENT_PER_BLK)\n-\t\treturn 0;\n-\n-\tentries[size] = (typeof(*entries)){};\n-\tentries[size].key[1] = YT921X_ACL_KEYb_TYPE(YT921X_ACL_TYPE_MISC);\n-\tyt921x_acl_entry_set(\u0026entries[size], 0,\n-\t\t\t YT921X_ACL_BINa_MISC_FIRST_FRAG, set);\n-\n-\treturn size + 1;\n-}\n-\n-static unsigned int\n-yt921x_acl_entries_set_l3_type(struct yt921x_acl_entry *entries,\n-\t\t\t unsigned int size, enum yt921x_l3_type type)\n-{\n-\tfor (unsigned int i = 0; i \u003c size; i++)\n-\t\tswitch (FIELD_GET(YT921X_ACL_KEYb_TYPE_M, entries[i].key[1])) {\n-\t\tcase YT921X_ACL_TYPE_MAC_DA0:\n-\t\tcase YT921X_ACL_TYPE_MAC_SA0:\n-\t\t\tentries[i].key[1] |= YT921X_ACL_BINb_MAC_xA0_L3_TYPE(type);\n-\t\t\tentries[i].mask[1] |= YT921X_ACL_BINb_MAC_xA0_L3_TYPE_M;\n-\t\t\treturn size;\n-\t\tcase YT921X_ACL_TYPE_MISC:\n-\t\t\tentries[i].key[0] |= YT921X_ACL_BINa_MISC_L3_TYPE(type);\n-\t\t\tentries[i].mask[0] |= YT921X_ACL_BINa_MISC_L3_TYPE_M;\n-\t\t\treturn size;\n-\t\t}\n-\n-\tif (size \u003e= YT921X_ACL_ENT_PER_BLK)\n-\t\treturn 0;\n-\n-\tentries[size] = (typeof(*entries)){};\n-\tentries[size].key[0] = YT921X_ACL_BINa_MISC_L3_TYPE(type);\n-\tentries[size].key[1] = YT921X_ACL_KEYb_TYPE(YT921X_ACL_TYPE_MISC);\n-\tentries[size].mask[0] = YT921X_ACL_BINa_MISC_L3_TYPE_M;\n-\n-\treturn size + 1;\n-}\n-\n-static unsigned int\n-yt921x_acl_entries_set_l4_type(struct yt921x_acl_entry *entries,\n-\t\t\t unsigned int size, enum yt921x_l4_type type)\n-{\n-\tfor (unsigned int i = 0; i \u003c size; i++)\n-\t\tswitch (FIELD_GET(YT921X_ACL_KEYb_TYPE_M, entries[i].key[1])) {\n-\t\tcase YT921X_ACL_TYPE_IPV4_DA:\n-\t\tcase YT921X_ACL_TYPE_IPV4_SA:\n-\t\t\tentries[i].key[1] |= YT921X_ACL_BINb_IPV4_L4_TYPE(type);\n-\t\t\tentries[i].mask[1] |= YT921X_ACL_BINb_IPV4_L4_TYPE_M;\n-\t\t\treturn size;\n-\t\tcase YT921X_ACL_TYPE_IPV6_DA0:\n-\t\tcase YT921X_ACL_TYPE_IPV6_DA1:\n-\t\tcase YT921X_ACL_TYPE_IPV6_DA2:\n-\t\tcase YT921X_ACL_TYPE_IPV6_DA3:\n-\t\tcase YT921X_ACL_TYPE_IPV6_SA0:\n-\t\tcase YT921X_ACL_TYPE_IPV6_SA1:\n-\t\tcase YT921X_ACL_TYPE_IPV6_SA2:\n-\t\tcase YT921X_ACL_TYPE_IPV6_SA3:\n-\t\t\tentries[i].key[1] |= YT921X_ACL_BINb_IPV6_L4_TYPE(type);\n-\t\t\tentries[i].mask[1] |= YT921X_ACL_BINb_IPV6_L4_TYPE_M;\n-\t\t\treturn size;\n-\t\tcase YT921X_ACL_TYPE_L4:\n-\t\t\tentries[i].key[1] |= YT921X_ACL_BINb_L4_TYPE(type);\n-\t\t\tentries[i].mask[1] |= YT921X_ACL_BINb_L4_TYPE_M;\n-\t\t\treturn size;\n-\t\tcase YT921X_ACL_TYPE_MISC:\n-\t\t\tentries[i].key[1] |= YT921X_ACL_BINb_MISC_L4_TYPE(type);\n-\t\t\tentries[i].mask[1] |= YT921X_ACL_BINb_MISC_L4_TYPE_M;\n-\t\t\treturn size;\n-\t\t}\n-\n-\tif (size \u003e= YT921X_ACL_ENT_PER_BLK)\n-\t\treturn 0;\n-\n-\tentries[size] = (typeof(*entries)){};\n-\tentries[size].key[1] = YT921X_ACL_BINb_MISC_L4_TYPE(type) |\n-\t\t\t YT921X_ACL_KEYb_TYPE(YT921X_ACL_TYPE_MISC);\n-\tentries[size].mask[1] = YT921X_ACL_BINb_MISC_L4_TYPE_M;\n-\n-\treturn size + 1;\n-}\n-\n-static struct yt921x_acl_entry *\n-yt921x_acl_entries_new(struct yt921x_acl_entry *entries, unsigned int *sizep,\n-\t\t u32 type)\n-{\n-\tunsigned int size = *sizep;\n-\n-\tif (size \u003e= YT921X_ACL_ENT_PER_BLK)\n-\t\treturn NULL;\n-\n-\tentries[size] = (typeof(*entries)){};\n-\tentries[size].key[1] = YT921X_ACL_KEYb_TYPE(type);\n-\n-\t(*sizep)++;\n-\treturn \u0026entries[size];\n-}\n-\n-static struct yt921x_acl_entry *\n-yt921x_acl_entries_find(struct yt921x_acl_entry *entries, unsigned int *sizep,\n-\t\t\tu32 type)\n-{\n-\tfor (unsigned int i = 0; i \u003c *sizep; i++)\n-\t\tif (FIELD_GET(YT921X_ACL_KEYb_TYPE_M, entries[i].key[1]) ==\n-\t\t type)\n-\t\t\treturn \u0026entries[i];\n-\treturn yt921x_acl_entries_new(entries, sizep, type);\n-}\n-\n-static void\n-yt921x_acl_rule_set_ports(struct yt921x_acl_rule *aclrule, u16 ord,\n-\t\t\t u16 ports_mask)\n-{\n-\tstruct yt921x_acl_entry *entries = aclrule-\u003eentries;\n-\n-\tfor (unsigned int i = 0; i \u003c hweight8(aclrule-\u003emask); i++) {\n-\t\tentries[i].key[1] |= YT921X_ACL_KEYb_SPORTS(ports_mask) |\n-\t\t\t\t YT921X_ACL_KEYb_ORD(ord);\n-\t}\n-}\n-\n-struct yt921x_acl_rule_ext {\n-\tstruct yt921x_acl_rule r;\n-\n-\tstruct yt921x_marker marker;\n-};\n-\n-static int\n-yt921x_acl_rule_ext_parse_flow_entries(struct yt921x_acl_rule_ext *ruleext,\n-\t\t\t\t const struct flow_cls_offload *cls)\n-{\n-\tconst struct flow_rule *rule = flow_cls_offload_flow_rule(cls);\n-\tstruct yt921x_acl_entry *entries = ruleext-\u003er.entries;\n-\tstruct netlink_ext_ack *extack = cls-\u003ecommon.extack;\n-\tconst struct flow_dissector *dissector;\n-\tstruct yt921x_acl_entry *entry;\n-\tunsigned int size = 0;\n-\tbool use_dport;\n-\tbool use_sport;\n-\n-\t/* Incomplete and probably won't, since it supports custom u32 filters.\n-\t * New adapters are welcome.\n-\t */\n-\tdissector = rule-\u003ematch.dissector;\n-\tif (dissector-\u003eused_keys \u0026\n-\t ~(BIT_ULL(FLOW_DISSECTOR_KEY_CONTROL) |\n-\t BIT_ULL(FLOW_DISSECTOR_KEY_BASIC) |\n-\t BIT_ULL(FLOW_DISSECTOR_KEY_IPV4_ADDRS) |\n-\t BIT_ULL(FLOW_DISSECTOR_KEY_IPV6_ADDRS) |\n-\t BIT_ULL(FLOW_DISSECTOR_KEY_PORTS) |\n-\t BIT_ULL(FLOW_DISSECTOR_KEY_PORTS_RANGE) |\n-\t BIT_ULL(FLOW_DISSECTOR_KEY_ETH_ADDRS) |\n-\t BIT_ULL(FLOW_DISSECTOR_KEY_IP) |\n-\t BIT_ULL(FLOW_DISSECTOR_KEY_TCP))) {\n-\t\tNL_SET_ERR_MSG_MOD(extack, \"Unsupported keys used\");\n-\t\treturn -EOPNOTSUPP;\n-\t}\n-\n-\t/* Entries */\n-\tif (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_IPV4_ADDRS)) {\n-\t\tstruct flow_match_ipv4_addrs match;\n-\n-\t\tflow_rule_match_ipv4_addrs(rule, \u0026match);\n-\n-\t\tif (match.mask-\u003edst) {\n-\t\t\tentry = yt921x_acl_entries_new(entries, \u0026size,\n-\t\t\t\t\t\t YT921X_ACL_TYPE_IPV4_DA);\n-\t\t\tif (!entry)\n-\t\t\t\tgoto err;\n-\n-\t\t\tentry-\u003ekey[0] |= ntohl(match.key-\u003edst);\n-\t\t\tentry-\u003emask[0] |= ntohl(match.mask-\u003edst);\n-\t\t}\n-\n-\t\tif (match.mask-\u003esrc) {\n-\t\t\tentry = yt921x_acl_entries_new(entries, \u0026size,\n-\t\t\t\t\t\t YT921X_ACL_TYPE_IPV4_SA);\n-\t\t\tif (!entry)\n-\t\t\t\tgoto err;\n-\n-\t\t\tentry-\u003ekey[0] |= ntohl(match.key-\u003esrc);\n-\t\t\tentry-\u003emask[0] |= ntohl(match.mask-\u003esrc);\n-\t\t}\n-\t}\n-\n-\tif (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_IPV6_ADDRS)) {\n-\t\tstruct flow_match_ipv6_addrs match;\n-\n-\t\tflow_rule_match_ipv6_addrs(rule, \u0026match);\n-\n-\t\tfor (unsigned int i = 0; i \u003c 4; i++) {\n-\t\t\tif (!match.mask-\u003edst.s6_addr32[i])\n-\t\t\t\tcontinue;\n-\n-\t\t\tentry = yt921x_acl_entries_new(entries, \u0026size,\n-\t\t\t\t\t\t YT921X_ACL_TYPE_IPV6_DA0 + i);\n-\t\t\tif (!entry)\n-\t\t\t\tgoto err;\n-\n-\t\t\tentry-\u003ekey[0] |= ntohl(match.key-\u003edst.s6_addr32[i]);\n-\t\t\tentry-\u003emask[0] |= ntohl(match.mask-\u003edst.s6_addr32[i]);\n-\t\t}\n-\n-\t\tfor (unsigned int i = 0; i \u003c 4; i++) {\n-\t\t\tif (!match.mask-\u003esrc.s6_addr32[i])\n-\t\t\t\tcontinue;\n-\n-\t\t\tentry = yt921x_acl_entries_new(entries, \u0026size,\n-\t\t\t\t\t\t YT921X_ACL_TYPE_IPV6_SA0 + i);\n-\t\t\tif (!entry)\n-\t\t\t\tgoto err;\n-\n-\t\t\tentry-\u003ekey[0] |= ntohl(match.key-\u003esrc.s6_addr32[i]);\n-\t\t\tentry-\u003emask[0] |= ntohl(match.mask-\u003esrc.s6_addr32[i]);\n-\t\t}\n-\t}\n-\n-\tuse_dport = false;\n-\tuse_sport = false;\n-\tif (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_PORTS)) {\n-\t\tstruct flow_match_ports match;\n-\n-\t\tentry = yt921x_acl_entries_new(entries, \u0026size,\n-\t\t\t\t\t YT921X_ACL_TYPE_L4);\n-\t\tif (!entry)\n-\t\t\tgoto err;\n-\n-\t\tflow_rule_match_ports(rule, \u0026match);\n-\n-\t\tuse_dport = !!match.mask-\u003edst;\n-\t\tuse_sport = !!match.mask-\u003esrc;\n-\n-\t\tentry-\u003ekey[0] |= (ntohs(match.key-\u003edst) \u003c\u003c 16) |\n-\t\t\t\t ntohs(match.key-\u003esrc);\n-\t\tentry-\u003emask[0] |= (ntohs(match.mask-\u003edst) \u003c\u003c 16) |\n-\t\t\t\t ntohs(match.mask-\u003esrc);\n-\t}\n-\n-\tif (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_PORTS_RANGE)) {\n-\t\tstruct flow_match_ports_range match;\n-\n-\t\tentry = yt921x_acl_entries_find(entries, \u0026size,\n-\t\t\t\t\t\tYT921X_ACL_TYPE_L4);\n-\t\tif (!entry)\n-\t\t\tgoto err;\n-\n-\t\tflow_rule_match_ports_range(rule, \u0026match);\n-\n-\t\tif ((use_dport \u0026\u0026 match.mask-\u003etp.dst) ||\n-\t\t (use_sport \u0026\u0026 match.mask-\u003etp.src)) {\n-\t\t\tNL_SET_ERR_MSG_MOD(extack,\n-\t\t\t\t\t \"Port mask and range are mutually exclusive\");\n-\t\t\treturn -EINVAL;\n-\t\t}\n-\n-\t\tif (match.mask-\u003etp.dst) {\n-\t\t\tentry-\u003ekey[0] |= ntohs(match.key-\u003etp_min.dst) \u003c\u003c 16;\n-\t\t\tentry-\u003ekey[1] |= YT921X_ACL_KEYb_L4_DPORT_RANGE_EN;\n-\t\t\tentry-\u003emask[0] |= ntohs(match.key-\u003etp_max.dst) \u003c\u003c 16;\n-\t\t}\n-\n-\t\tif (match.mask-\u003etp.src) {\n-\t\t\tentry-\u003ekey[0] |= ntohs(match.key-\u003etp_min.src);\n-\t\t\tentry-\u003ekey[1] |= YT921X_ACL_KEYb_L4_SPORT_RANGE_EN;\n-\t\t\tentry-\u003emask[0] |= ntohs(match.key-\u003etp_max.src);\n-\t\t}\n-\t}\n-\n-\tif (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_ETH_ADDRS)) {\n-\t\tstruct flow_match_eth_addrs match;\n-\t\tu32 mask;\n-\n-\t\tflow_rule_match_eth_addrs(rule, \u0026match);\n-\n-\t\tmask = ethaddr_hi4_to_u32(match.mask-\u003edst);\n-\t\tif (mask) {\n-\t\t\tentry = yt921x_acl_entries_new(entries, \u0026size,\n-\t\t\t\t\t\t YT921X_ACL_TYPE_MAC_DA0);\n-\t\t\tif (!entry)\n-\t\t\t\tgoto err;\n-\n-\t\t\tentry-\u003ekey[0] |= ethaddr_hi4_to_u32(match.key-\u003edst);\n-\t\t\tentry-\u003emask[0] |= mask;\n-\t\t}\n-\n-\t\tmask = ethaddr_hi4_to_u32(match.mask-\u003esrc);\n-\t\tif (mask) {\n-\t\t\tentry = yt921x_acl_entries_new(entries, \u0026size,\n-\t\t\t\t\t\t YT921X_ACL_TYPE_MAC_SA0);\n-\t\t\tif (!entry)\n-\t\t\t\tgoto err;\n-\n-\t\t\tentry-\u003ekey[0] |= ethaddr_hi4_to_u32(match.key-\u003esrc);\n-\t\t\tentry-\u003emask[0] |= mask;\n-\t\t}\n-\n-\t\tmask = (ethaddr_lo2_to_u32(match.mask-\u003edst) \u003c\u003c 16) |\n-\t\t ethaddr_lo2_to_u32(match.mask-\u003esrc);\n-\t\tif (mask) {\n-\t\t\tentry = yt921x_acl_entries_new(entries, \u0026size,\n-\t\t\t\t\t\t YT921X_ACL_TYPE_MAC_DA1_SA1);\n-\t\t\tif (!entry)\n-\t\t\t\tgoto err;\n-\n-\t\t\tentry-\u003ekey[0] |= (ethaddr_lo2_to_u32(match.key-\u003edst) \u003c\u003c 16) |\n-\t\t\t\t\t ethaddr_lo2_to_u32(match.key-\u003esrc);\n-\t\t\tentry-\u003emask[0] |= mask;\n-\t\t}\n-\t}\n-\n-\t/* Entries + Misc */\n-\tif (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_BASIC)) {\n-\t\tstruct flow_match_basic match;\n-\n-\t\tflow_rule_match_basic(rule, \u0026match);\n-\n-\t\tif (match.mask-\u003en_proto) {\n-\t\t\tenum yt921x_l3_type l3type = YT921X_L3_TYPE_OTHER;\n-\n-\t\t\tif (match.mask-\u003en_proto == htons(~0))\n-\t\t\t\tswitch (match.key-\u003en_proto) {\n-\t\t\t\tcase htons(ETH_P_IP):\n-\t\t\t\t\tl3type = YT921X_L3_TYPE_IPV4;\n-\t\t\t\t\tbreak;\n-\t\t\t\tcase htons(ETH_P_IPV6):\n-\t\t\t\t\tl3type = YT921X_L3_TYPE_IPV6;\n-\t\t\t\t\tbreak;\n-\t\t\t\tcase htons(ETH_P_ARP):\n-\t\t\t\t\tl3type = YT921X_L3_TYPE_ARP;\n-\t\t\t\t\tbreak;\n-\t\t\t\tcase htons(ETH_P_LLDP):\n-\t\t\t\t\tl3type = YT921X_L3_TYPE_LLDP;\n-\t\t\t\t\tbreak;\n-\t\t\t\tcase htons(ETH_P_PAE):\n-\t\t\t\t\tl3type = YT921X_L3_TYPE_PAE;\n-\t\t\t\t\tbreak;\n-\t\t\t\tcase htons(ETH_P_CFM):\n-\t\t\t\t\tl3type = YT921X_L3_TYPE_ERP;\n-\t\t\t\t\tbreak;\n-\t\t\t\t}\n-\n-\t\t\tif (l3type != YT921X_L3_TYPE_OTHER) {\n-\t\t\t\tsize = yt921x_acl_entries_set_l3_type(entries,\n-\t\t\t\t\t\t\t\t size,\n-\t\t\t\t\t\t\t\t l3type);\n-\t\t\t\tif (!size)\n-\t\t\t\t\tgoto err;\n-\t\t\t} else {\n-\t\t\t\tentry = yt921x_acl_entries_new(entries, \u0026size,\n-\t\t\t\t\t\t\t YT921X_ACL_TYPE_ETHERTYPE);\n-\t\t\t\tif (!entry)\n-\t\t\t\t\tgoto err;\n-\n-\t\t\t\tentry-\u003ekey[0] |= ntohs(match.key-\u003en_proto);\n-\t\t\t\tentry-\u003emask[0] |= ntohs(match.mask-\u003en_proto);\n-\t\t\t}\n-\t\t}\n-\n-\t\tif (match.mask-\u003eip_proto) {\n-\t\t\tenum yt921x_l4_type l4type = YT921X_L4_TYPE_OTHER;\n-\n-\t\t\tif (match.mask-\u003eip_proto == (u8)~0)\n-\t\t\t\tswitch (match.key-\u003eip_proto) {\n-\t\t\t\tcase IPPROTO_TCP:\n-\t\t\t\t\tl4type = YT921X_L4_TYPE_TCP;\n-\t\t\t\t\tbreak;\n-\t\t\t\tcase IPPROTO_UDP:\n-\t\t\t\t\tl4type = YT921X_L4_TYPE_UDP;\n-\t\t\t\t\tbreak;\n-\t\t\t\tcase IPPROTO_UDPLITE:\n-\t\t\t\t\tl4type = YT921X_L4_TYPE_UDPLITE;\n-\t\t\t\t\tbreak;\n-\t\t\t\tcase IPPROTO_ICMP:\n-\t\t\t\t\tl4type = YT921X_L4_TYPE_ICMP;\n-\t\t\t\t\tbreak;\n-\t\t\t\tcase IPPROTO_IGMP:\n-\t\t\t\t\tl4type = YT921X_L4_TYPE_IGMP;\n-\t\t\t\t\tbreak;\n-\t\t\t\t}\n-\n-\t\t\tif (l4type != YT921X_L4_TYPE_OTHER) {\n-\t\t\t\tsize = yt921x_acl_entries_set_l4_type(entries,\n-\t\t\t\t\t\t\t\t size,\n-\t\t\t\t\t\t\t\t l4type);\n-\t\t\t\tif (!size)\n-\t\t\t\t\tgoto err;\n-\t\t\t} else {\n-\t\t\t\tentry = yt921x_acl_entries_find(entries, \u0026size,\n-\t\t\t\t\t\t\t\tYT921X_ACL_TYPE_MISC);\n-\t\t\t\tif (!entry)\n-\t\t\t\t\tgoto err;\n-\n-\t\t\t\tentry-\u003ekey[0] |= YT921X_ACL_BINa_MISC_IP_PROTO(match.key-\u003eip_proto);\n-\t\t\t\tentry-\u003emask[0] |= YT921X_ACL_BINa_MISC_IP_PROTO(match.mask-\u003eip_proto);\n-\t\t\t}\n-\t\t}\n-\t}\n-\n-\tif (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_CONTROL)) {\n-\t\tu32 supp_flags = FLOW_DIS_IS_FRAGMENT | FLOW_DIS_FIRST_FRAG;\n-\t\tstruct flow_match_control match;\n-\n-\t\tflow_rule_match_control(rule, \u0026match);\n-\t\tif (!flow_rule_is_supp_control_flags(supp_flags,\n-\t\t\t\t\t\t match.mask-\u003eflags, extack))\n-\t\t\treturn -EOPNOTSUPP;\n-\n-\t\tif (match.mask-\u003eflags \u0026 FLOW_DIS_IS_FRAGMENT) {\n-\t\t\tbool set = match.key-\u003eflags \u0026 FLOW_DIS_IS_FRAGMENT;\n-\n-\t\t\tsize = yt921x_acl_entries_set_is_fragment(entries, size,\n-\t\t\t\t\t\t\t\t set);\n-\t\t\tif (!size)\n-\t\t\t\tgoto err;\n-\t\t}\n-\t\tif (match.mask-\u003eflags \u0026 FLOW_DIS_FIRST_FRAG) {\n-\t\t\tbool set = match.key-\u003eflags \u0026 FLOW_DIS_FIRST_FRAG;\n-\n-\t\t\tsize = yt921x_acl_entries_set_first_frag(entries, size,\n-\t\t\t\t\t\t\t\t set);\n-\t\t\tif (!size)\n-\t\t\t\tgoto err;\n-\t\t}\n-\t}\n-\n-\t/* Misc only */\n-\tif (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_IP)) {\n-\t\tstruct flow_match_ip match;\n-\n-\t\tflow_rule_match_ip(rule, \u0026match);\n-\t\tif (match.mask-\u003ettl) {\n-\t\t\tNL_SET_ERR_MSG_MOD(extack,\n-\t\t\t\t\t \"Matching on TTL not supported\");\n-\t\t\treturn -EOPNOTSUPP;\n-\t\t}\n-\n-\t\tif (match.mask-\u003etos) {\n-\t\t\tentry = yt921x_acl_entries_find(entries, \u0026size,\n-\t\t\t\t\t\t\tYT921X_ACL_TYPE_MISC);\n-\t\t\tif (!entry)\n-\t\t\t\tgoto err;\n-\n-\t\t\tentry-\u003ekey[0] |= YT921X_ACL_BINa_MISC_TOS(match.key-\u003etos);\n-\t\t\tentry-\u003emask[0] |= YT921X_ACL_BINa_MISC_TOS(match.mask-\u003etos);\n-\t\t}\n-\t}\n-\n-\tif (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_TCP)) {\n-\t\tstruct flow_match_tcp match;\n-\n-\t\tflow_rule_match_tcp(rule, \u0026match);\n-\t\tif (match.mask-\u003eflags \u0026 htons(~0xff)) {\n-\t\t\tNL_SET_ERR_MSG_MOD(extack, \"Unsupported TCP flags\");\n-\t\t\treturn -EOPNOTSUPP;\n-\t\t}\n-\n-\t\tif (match.mask-\u003eflags) {\n-\t\t\tentry = yt921x_acl_entries_find(entries, \u0026size,\n-\t\t\t\t\t\t\tYT921X_ACL_TYPE_MISC);\n-\t\t\tif (!entry)\n-\t\t\t\tgoto err;\n-\n-\t\t\tentry-\u003ekey[0] |= YT921X_ACL_BINa_MISC_TCP_FLAGS(ntohs(match.key-\u003eflags));\n-\t\t\tentry-\u003emask[0] |= YT921X_ACL_BINa_MISC_TCP_FLAGS(ntohs(match.mask-\u003eflags));\n-\t\t}\n-\t}\n-\n-\tif (!size) {\n-\t\tNL_SET_ERR_MSG_MOD(extack, \"Empty rule generated, this should not happen\");\n-\t\treturn -EOPNOTSUPP;\n-\t}\n-\n-\truleext-\u003er.mask = (1 \u003c\u003c size) - 1;\n-\treturn 0;\n-\n-err:\n-\tNL_SET_ERR_MSG_MOD(extack, \"Rule too complex\");\n-\treturn -EOPNOTSUPP;\n-}\n-\n-static int\n-yt921x_acl_rule_ext_parse_flow_action(struct yt921x_acl_rule_ext *ruleext,\n-\t\t\t\t const struct flow_cls_offload *cls,\n-\t\t\t\t struct yt921x_priv *priv, int port)\n-{\n-\tconst struct flow_rule *rule = flow_cls_offload_flow_rule(cls);\n-\tconst struct flow_action *flow_action = \u0026rule-\u003eaction;\n-\tstruct netlink_ext_ack *extack = cls-\u003ecommon.extack;\n-\tenum flow_action_id redir_act = NUM_FLOW_ACTIONS;\n-\tconst struct flow_action_entry *act;\n-\tu32 *action = ruleext-\u003er.action;\n-\tbool seen_priority = false;\n-\tconst char *reason = NULL;\n-\tbool seen_police = false;\n-\tunsigned int i;\n-\tint res;\n-\n-\tmemset(action, 0, 3 * sizeof(*action));\n-\tflow_action_for_each(i, act, flow_action)\n-\t\tswitch (act-\u003eid) {\n-\t\tcase FLOW_ACTION_ACCEPT:\n-\t\tcase FLOW_ACTION_DROP:\n-\t\tcase FLOW_ACTION_REDIRECT:\n-\t\t\tif (redir_act != NUM_FLOW_ACTIONS \u0026\u0026\n-\t\t\t redir_act != act-\u003eid) {\n-\t\t\t\treason = \"Different redirect actions\";\n-\t\t\t\tgoto fallback;\n-\t\t\t}\n-\t\t\tredir_act = act-\u003eid;\n-\n-\t\t\tswitch (act-\u003eid) {\n-\t\t\tcase FLOW_ACTION_ACCEPT:\n-\t\t\t\taction[2] |= YT921X_ACL_ACTc_FWD_EN |\n-\t\t\t\t\t YT921X_ACL_ACTc_FWD_FWD;\n-\t\t\t\tbreak;\n-\t\t\tcase FLOW_ACTION_DROP:\n-\t\t\t\taction[2] |= YT921X_ACL_ACTc_FWD_EN |\n-\t\t\t\t\t YT921X_ACL_ACTc_FWD_REDIR;\n-\t\t\t\tbreak;\n-\t\t\tcase FLOW_ACTION_REDIRECT: {\n-\t\t\t\tstruct dsa_port *to_dp;\n-\n-\t\t\t\tto_dp = dsa_port_from_netdev(act-\u003edev);\n-\t\t\t\tif (IS_ERR(to_dp) || to_dp-\u003eds != \u0026priv-\u003eds) {\n-\t\t\t\t\treason = \"Redirect to non-local port\";\n-\t\t\t\t\tgoto fallback;\n-\t\t\t\t}\n-\n-\t\t\t\taction[2] |= YT921X_ACL_ACTc_FWD_EN |\n-\t\t\t\t\t YT921X_ACL_ACTc_FWD_REDIR |\n-\t\t\t\t\t YT921X_ACL_ACTc_FWD_REDIR_DPORTn(to_dp-\u003eindex);\n-\t\t\t\tbreak;\n-\t\t\t}\n-\t\t\tdefault:\n-\t\t\t\tbreak;\n-\t\t\t}\n-\t\t\tbreak;\n-\t\tcase FLOW_ACTION_PRIORITY:\n-\t\t\tif (seen_priority) {\n-\t\t\t\taction[0] \u0026= ~YT921X_ACL_ACTa_PRIO_EN;\n-\t\t\t\taction[1] \u0026= ~YT921X_ACL_ACTb_PRIO_M;\n-\n-\t\t\t\treason = \"Multiple priority actions\";\n-\t\t\t\tgoto fallback;\n-\t\t\t}\n-\t\t\tseen_priority = true;\n-\n-\t\t\tif (act-\u003epriority \u003e= YT921X_PRIO_NUM) {\n-\t\t\t\tNL_SET_ERR_MSG_MOD(extack,\n-\t\t\t\t\t\t \"Priority value is too high\");\n-\t\t\t\treturn -EOPNOTSUPP;\n-\t\t\t}\n-\t\t\taction[0] |= YT921X_ACL_ACTa_PRIO_EN;\n-\t\t\taction[1] |= YT921X_ACL_ACTb_PRIO(act-\u003epriority);\n-\t\t\tbreak;\n-\t\tcase FLOW_ACTION_POLICE: {\n-\t\t\tconst struct flow_action_police *police = \u0026act-\u003epolice;\n-\n-\t\t\tif (seen_police) {\n-\t\t\t\taction[0] \u0026= ~YT921X_ACL_ACTa_METER_EN;\n-\n-\t\t\t\treason = \"Multiple police actions\";\n-\t\t\t\tgoto fallback;\n-\t\t\t}\n-\t\t\tseen_police = true;\n-\n-\t\t\tres = yt921x_police_validate(police, flow_action, act,\n-\t\t\t\t\t\t extack);\n-\t\t\tif (res)\n-\t\t\t\treturn res;\n-\n-\t\t\tres = yt921x_marker_tfm_police(\u0026ruleext-\u003emarker, police,\n-\t\t\t\t\t\t 0, priv, port, extack);\n-\t\t\tif (res)\n-\t\t\t\treturn res;\n-\n-\t\t\taction[0] |= YT921X_ACL_ACTa_METER_EN;\n-\t\t\tbreak;\n-\t\t}\n-\t\tdefault:\n-fallback:\n-\t\t\tif (cls-\u003ecommon.skip_sw) {\n-\t\t\t\tNL_SET_ERR_MSG_FMT_MOD(extack,\n-\t\t\t\t\t\t \"Action not supported when skip_sw: %s\",\n-\t\t\t\t\t\t reason);\n-\t\t\t\treturn -EOPNOTSUPP;\n-\t\t\t}\n-\t\t\tfallthrough;\n-\t\tcase FLOW_ACTION_TRAP:\n-\t\t\tredir_act = FLOW_ACTION_TRAP;\n-\n-\t\t\taction[2] \u0026= ~YT921X_ACL_ACTc_FWD_REDIR_DPORTS_M \u0026\n-\t\t\t\t ~YT921X_ACL_ACTc_FWD_M;\n-\t\t\taction[2] |= YT921X_ACL_ACTc_FWD_EN |\n-\t\t\t\t YT921X_ACL_ACTc_FWD_TRAP;\n-\t\t\tbreak;\n-\t\t}\n-\n-\truleext-\u003er.sw_assisted = !cls-\u003ecommon.skip_sw;\n-\treturn 0;\n-}\n-\n-static int\n-yt921x_acl_rule_ext_parse_flow(struct yt921x_acl_rule_ext *ruleext, int port,\n-\t\t\t const struct flow_cls_offload *cls, bool ingress,\n-\t\t\t struct yt921x_priv *priv)\n-{\n-\tstruct netlink_ext_ack *extack = cls-\u003ecommon.extack;\n-\tint res;\n-\n-\tif (!ingress) {\n-\t\tNL_SET_ERR_MSG_MOD(extack, \"Only ingress is supported\");\n-\t\treturn -EOPNOTSUPP;\n-\t}\n-\n-\tif (cls-\u003ecommon.chain_index) {\n-\t\tNL_SET_ERR_MSG(extack, \"Only chain 0 is supported\");\n-\t\treturn -EOPNOTSUPP;\n-\t}\n-\n-\tres = yt921x_acl_rule_ext_parse_flow_action(ruleext, cls, priv, port);\n-\tif (res)\n-\t\treturn res;\n-\tres = yt921x_acl_rule_ext_parse_flow_entries(ruleext, cls);\n-\tif (res)\n-\t\treturn res;\n-\n-\tyt921x_acl_rule_set_ports(\u0026ruleext-\u003er, 0, BIT(port));\n-\truleext-\u003er.tag = cls-\u003ecookie;\n-\truleext-\u003er.type = TC_SETUP_CLSFLOWER;\n-\treturn 0;\n-}\n-\n-static unsigned int\n-yt921x_acl_find(const struct yt921x_priv *priv, enum tc_setup_type type,\n-\t\tunsigned long tag)\n-{\n-\tfor (unsigned int blkid = 0; blkid \u003c YT921X_ACL_BLK_NUM; blkid++) {\n-\t\tconst struct yt921x_acl_blk *aclblk = priv-\u003eacl_blks[blkid];\n-\n-\t\tif (!aclblk)\n-\t\t\tcontinue;\n-\n-\t\tfor (unsigned int i = 0; i \u003c YT921X_ACL_ENT_PER_BLK; i++)\n-\t\t\tif (aclblk-\u003erules[i] \u0026\u0026 aclblk-\u003erules[i]-\u003etag == tag \u0026\u0026\n-\t\t\t aclblk-\u003erules[i]-\u003etype == type)\n-\t\t\t\treturn YT921X_ACL_ENT_PER_BLK * blkid + i;\n-\t}\n-\n-\treturn UINT_MAX;\n-}\n-\n-static unsigned int\n-yt921x_acl_reserve(struct yt921x_priv *priv, unsigned int entscnt,\n-\t\t struct netlink_ext_ack *extack)\n-{\n-\tint candidates[YT921X_ACL_ENT_PER_BLK + 1];\n-\tunsigned int acl_used_cnt = 0;\n-\n-\tif (WARN_ON(entscnt \u003e YT921X_ACL_ENT_PER_BLK))\n-\t\treturn UINT_MAX;\n-\n-\tfor (unsigned int i = 0; i \u003c ARRAY_SIZE(candidates); i++)\n-\t\tcandidates[i] = -1;\n-\tfor (unsigned int i = YT921X_ACL_BLK_NUM; i-- \u003e 0;) {\n-\t\tunsigned int blk_used_cnt = hweight8(priv-\u003eacl_masks[i]);\n-\n-\t\tcandidates[blk_used_cnt] = i;\n-\t\tacl_used_cnt += blk_used_cnt;\n-\t}\n-\n-\tif (acl_used_cnt \u003e= YT921X_ACL_NUM) {\n-\t\tNL_SET_ERR_MSG_MOD(extack, \"ACL entry limit reached\");\n-\t\treturn UINT_MAX;\n-\t}\n-\tif (acl_used_cnt + entscnt \u003c= YT921X_ACL_NUM)\n-\t\tfor (unsigned int i = YT921X_ACL_ENT_PER_BLK - entscnt + 1;\n-\t\t i-- \u003e 0;)\n-\t\t\tif (candidates[i] \u003e= 0)\n-\t\t\t\treturn YT921X_ACL_ENT_PER_BLK * candidates[i] +\n-\t\t\t\t ffz(priv-\u003eacl_masks[candidates[i]]);\n-\n-\tNL_SET_ERR_MSG_MOD(extack,\n-\t\t\t \"ACL entry allocation failed, simplify your rules or remove existing rules\");\n-\treturn UINT_MAX;\n-}\n-\n-static int\n-yt921x_acl_commit(struct yt921x_priv *priv, unsigned int entid, u8 entsmask)\n-{\n-\tconst struct yt921x_acl_rule *aclrule;\n-\tconst struct yt921x_acl_blk *aclblk;\n-\tunsigned int blkid;\n-\tunsigned int binid;\n-\tunsigned long mask;\n-\tu32 zeros[3] = {};\n-\tunsigned int i;\n-\tunsigned int o;\n-\tu32 ctrl;\n-\tint res;\n-\n-\tblkid = entid / YT921X_ACL_ENT_PER_BLK;\n-\tbinid = entid % YT921X_ACL_ENT_PER_BLK;\n-\taclblk = priv-\u003eacl_blks[blkid];\n-\taclrule = aclblk-\u003erules[binid];\n-\n-\t/* Write actions */\n-\tres = yt921x_reg96_write(priv, YT921X_ACLn_ACT(entid),\n-\t\t\t\t aclrule ? aclrule-\u003eaction : zeros);\n-\tif (res)\n-\t\treturn res;\n-\n-\t/* Select the block */\n-\tctrl = YT921X_ACL_BLK_CMD_MODIFY | YT921X_ACL_BLK_CMD_BLKID(blkid);\n-\tres = yt921x_reg_write(priv, YT921X_ACL_BLK_CMD, ctrl);\n-\tif (res)\n-\t\treturn res;\n-\n-\t/* Write keys and masks */\n-\tctrl = 0;\n-\tfor (unsigned int i = 0; i \u003c YT921X_ACL_ENT_PER_BLK; i++)\n-\t\tctrl |= YT921X_ACL_BLK_KEEP_KEEPn(i);\n-\n-\tmask = entsmask;\n-\ti = 0;\n-\tfor_each_set_bit(o, \u0026mask, YT921X_ACL_ENT_PER_BLK) {\n-\t\tres = yt921x_reg64_write(priv, YT921X_ACLn_KEYm(blkid, o),\n-\t\t\t\t\t aclrule ? aclrule-\u003eentries[i].key :\n-\t\t\t\t\t zeros);\n-\t\tif (res)\n-\t\t\treturn res;\n-\n-\t\tres = yt921x_reg64_write(priv, YT921X_ACLn_MASKm(blkid, o),\n-\t\t\t\t\t aclrule ? aclrule-\u003eentries[i].mask :\n-\t\t\t\t\t zeros);\n-\t\tif (res)\n-\t\t\treturn res;\n-\n-\t\tctrl \u0026= ~YT921X_ACL_BLK_KEEP_KEEPn(o);\n-\t\ti++;\n-\t}\n-\n-\tres = yt921x_reg_write(priv, YT921X_ACL_BLK_KEEP, ctrl);\n-\tif (res)\n-\t\treturn res;\n-\n-\tctrl = 0;\n-\tfor (unsigned int i = 0; i \u003c YT921X_ACL_ENT_PER_BLK; i++) {\n-\t\tconst struct yt921x_acl_rule *other = aclblk-\u003erules[i];\n-\n-\t\tif (!other)\n-\t\t\tcontinue;\n-\n-\t\tmask = other-\u003emask;\n-\t\tfor_each_set_bit(o, \u0026mask, YT921X_ACL_ENT_PER_BLK)\n-\t\t\tctrl |= YT921X_ACL_ENTRY_ENm(o) |\n-\t\t\t\tYT921X_ACL_ENTRY_GRPIDm(o, i);\n-\t}\n-\tres = yt921x_reg_write(priv, YT921X_ACLn_ENTRY(blkid), ctrl);\n-\tif (res)\n-\t\treturn res;\n-\n-\t/* Commit the block */\n-\tctrl = YT921X_ACL_BLK_CMD_BLKID(blkid);\n-\tres = yt921x_reg_write(priv, YT921X_ACL_BLK_CMD, ctrl);\n-\tif (res)\n-\t\treturn res;\n-\n-\treturn 0;\n-}\n-\n-static int\n-yt921x_acl_del(struct yt921x_priv *priv, enum tc_setup_type type,\n-\t unsigned long tag)\n-{\n-\tstruct yt921x_acl_rule *aclrule;\n-\tstruct yt921x_acl_blk *aclblk;\n-\tunsigned int binid;\n-\tunsigned int blkid;\n-\tunsigned int entid;\n-\tint res;\n-\n-\tentid = yt921x_acl_find(priv, type, tag);\n-\tif (entid == UINT_MAX)\n-\t\treturn -ENOENT;\n-\n-\tblkid = entid / YT921X_ACL_ENT_PER_BLK;\n-\tbinid = entid % YT921X_ACL_ENT_PER_BLK;\n-\taclblk = priv-\u003eacl_blks[blkid];\n-\taclrule = aclblk-\u003erules[binid];\n-\n-\taclblk-\u003erules[binid] = NULL;\n-\tres = yt921x_acl_commit(priv, entid, aclrule-\u003emask);\n-\t/* the kernel never rolls back on failure */\n-\n-\tif (aclrule-\u003eaction[0] \u0026 YT921X_ACL_ACTa_METER_EN)\n-\t\tclear_bit(FIELD_GET(YT921X_ACL_ACTa_METER_ID_M,\n-\t\t\t\t aclrule-\u003eaction[0]),\n-\t\t\t priv-\u003emeters_map);\n-\tpriv-\u003eacl_masks[blkid] \u0026= ~aclrule-\u003emask;\n-\tkvfree(aclrule);\n-\tif (!priv-\u003eacl_masks[blkid]) {\n-\t\tkvfree(aclblk);\n-\t\tpriv-\u003eacl_blks[blkid] = NULL;\n-\t}\n-\treturn res;\n-}\n-\n-static int\n-yt921x_acl_add(struct yt921x_priv *priv,\n-\t const struct yt921x_acl_rule_ext *ruleext,\n-\t struct netlink_ext_ack *extack)\n-{\n-\tunsigned int entscnt = hweight8(ruleext-\u003er.mask);\n-\tstruct yt921x_acl_rule *aclrule;\n-\tstruct yt921x_acl_blk *aclblk;\n-\tbool use_trap = false;\n-\tunsigned int meterid;\n-\tunsigned long mask;\n-\tunsigned int binid;\n-\tunsigned int blkid;\n-\tunsigned int entid;\n-\tunsigned int o;\n-\tint res;\n-\n-\t/* Allocate resources */\n-\tentid = yt921x_acl_reserve(priv, entscnt, extack);\n-\tif (entid == UINT_MAX)\n-\t\treturn -EOPNOTSUPP;\n-\n-\tif (!(ruleext-\u003er.action[0] \u0026 YT921X_ACL_ACTa_METER_EN)) {\n-\t\tmeterid = YT921X_METER_NUM;\n-\t} else {\n-\t\tmeterid = find_first_zero_bit(priv-\u003emeters_map,\n-\t\t\t\t\t YT921X_METER_NUM);\n-\t\tif (meterid \u003c YT921X_METER_NUM) {\n-\t\t\tres = yt921x_meter_config(priv, meterid,\n-\t\t\t\t\t\t \u0026ruleext-\u003emarker);\n-\t\t\tif (res)\n-\t\t\t\treturn res;\n-\t\t} else if (ruleext-\u003er.sw_assisted) {\n-\t\t\tuse_trap = true;\n-\t\t} else {\n-\t\t\tNL_SET_ERR_MSG_MOD(extack,\n-\t\t\t\t\t \"No more meters available\");\n-\t\t\treturn -EOPNOTSUPP;\n-\t\t}\n-\t}\n-\n-\t/* Prepare acl block ctrlblk */\n-\tblkid = entid / YT921X_ACL_ENT_PER_BLK;\n-\tbinid = entid % YT921X_ACL_ENT_PER_BLK;\n-\taclblk = priv-\u003eacl_blks[blkid];\n-\tif (!aclblk) {\n-\t\taclblk = kvzalloc_obj(*aclblk);\n-\t\tif (!aclblk)\n-\t\t\treturn -ENOMEM;\n-\t\tpriv-\u003eacl_blks[blkid] = aclblk;\n-\t}\n-\n-\t/* Prepare acl rule ctrlblk */\n-\taclrule = kvmemdup(\u0026ruleext-\u003er,\n-\t\t\t offsetof(struct yt921x_acl_rule, entries[entscnt]),\n-\t\t\t GFP_KERNEL);\n-\tif (!aclrule) {\n-\t\tres = -ENOMEM;\n-\t\tgoto err;\n-\t}\n-\n-\t/* Replace the placeholder resource IDs */\n-\taclrule-\u003emask = 0;\n-\tmask = priv-\u003eacl_masks[blkid];\n-\tfor_each_clear_bit(o, \u0026mask, YT921X_ACL_ENT_PER_BLK) {\n-\t\taclrule-\u003emask |= BIT(o);\n-\t\tentscnt--;\n-\t\tif (!entscnt)\n-\t\t\tbreak;\n-\t}\n-\n-\tif (use_trap) {\n-\t\taclrule-\u003eaction[2] \u0026= ~YT921X_ACL_ACTc_FWD_REDIR_DPORTS_M \u0026\n-\t\t\t\t ~YT921X_ACL_ACTc_FWD_M;\n-\t\taclrule-\u003eaction[2] |= YT921X_ACL_ACTc_FWD_EN |\n-\t\t\t\t YT921X_ACL_ACTc_FWD_TRAP;\n-\t}\n-\tif (meterid \u003c YT921X_METER_NUM)\n-\t\taclrule-\u003eaction[0] |= YT921X_ACL_ACTa_METER_ID(meterid);\n-\telse\n-\t\taclrule-\u003eaction[0] \u0026= ~YT921X_ACL_ACTa_METER_EN;\n-\n-\t/* Write rules */\n-\taclblk-\u003erules[binid] = aclrule;\n-\tres = yt921x_acl_commit(priv, entid, aclrule-\u003emask);\n-\tif (res) {\n-\t\taclblk-\u003erules[binid] = NULL;\n-\t\tkvfree(aclrule);\n-\t\tgoto err;\n-\t}\n-\n-\tif (meterid \u003c YT921X_METER_NUM)\n-\t\tset_bit(meterid, priv-\u003emeters_map);\n-\tpriv-\u003eacl_masks[blkid] |= aclrule-\u003emask;\n-\treturn 0;\n-\n-err:\n-\tif (!priv-\u003eacl_masks[blkid]) {\n-\t\tkvfree(aclblk);\n-\t\tpriv-\u003eacl_blks[blkid] = NULL;\n-\t}\n-\treturn res;\n-}\n-\n-static int\n-yt921x_dsa_cls_flower_del(struct dsa_switch *ds, int port,\n-\t\t\t struct flow_cls_offload *cls, bool ingress)\n-{\n-\tstruct yt921x_priv *priv = to_yt921x_priv(ds);\n-\tint res;\n-\n-\tmutex_lock(\u0026priv-\u003ereg_lock);\n-\tres = yt921x_acl_del(priv, TC_SETUP_CLSFLOWER, cls-\u003ecookie);\n-\tmutex_unlock(\u0026priv-\u003ereg_lock);\n-\n-\treturn res;\n-}\n-\n-static int\n-yt921x_dsa_cls_flower_add(struct dsa_switch *ds, int port,\n-\t\t\t struct flow_cls_offload *cls, bool ingress)\n-{\n-\tstruct netlink_ext_ack *extack = cls-\u003ecommon.extack;\n-\tstruct yt921x_priv *priv = to_yt921x_priv(ds);\n-\tstruct yt921x_acl_rule_ext ruleext;\n-\tint res;\n-\n-\tres = yt921x_acl_rule_ext_parse_flow(\u0026ruleext, port, cls, ingress,\n-\t\t\t\t\t priv);\n-\tif (res)\n-\t\treturn res;\n-\n-\tmutex_lock(\u0026priv-\u003ereg_lock);\n-\tres = yt921x_acl_add(priv, \u0026ruleext, extack);\n-\tmutex_unlock(\u0026priv-\u003ereg_lock);\n-\n-\treturn res;\n-}\n-\n-static int\n-yt921x_mirror_del(struct yt921x_priv *priv, int port, bool ingress)\n-{\n-\tu32 mask;\n-\n-\tif (ingress)\n-\t\tmask = YT921X_MIRROR_IGR_PORTn(port);\n-\telse\n-\t\tmask = YT921X_MIRROR_EGR_PORTn(port);\n-\treturn yt921x_reg_clear_bits(priv, YT921X_MIRROR, mask);\n-}\n-\n-static int\n-yt921x_mirror_add(struct yt921x_priv *priv, int port, bool ingress,\n-\t\t int to_local_port, struct netlink_ext_ack *extack)\n-{\n-\tu32 srcs;\n-\tu32 ctrl;\n-\tu32 val;\n-\tu32 dst;\n-\tint res;\n-\n-\tif (ingress)\n-\t\tsrcs = YT921X_MIRROR_IGR_PORTn(port);\n-\telse\n-\t\tsrcs = YT921X_MIRROR_EGR_PORTn(port);\n-\tdst = YT921X_MIRROR_PORT(to_local_port);\n-\n-\tres = yt921x_reg_read(priv, YT921X_MIRROR, \u0026val);\n-\tif (res)\n-\t\treturn res;\n-\n-\t/* other mirror tasks \u0026 different dst port -\u003e conflict */\n-\tif ((val \u0026 ~srcs \u0026 (YT921X_MIRROR_EGR_PORTS_M |\n-\t\t\t YT921X_MIRROR_IGR_PORTS_M)) \u0026\u0026\n-\t (val \u0026 YT921X_MIRROR_PORT_M) != dst) {\n-\t\tNL_SET_ERR_MSG_MOD(extack,\n-\t\t\t\t \"Sniffer port is already configured, delete existing rules \u0026 retry\");\n-\t\treturn -EBUSY;\n-\t}\n-\n-\tctrl = val \u0026 ~YT921X_MIRROR_PORT_M;\n-\tctrl |= srcs;\n-\tctrl |= dst;\n-\n-\tif (ctrl == val)\n-\t\treturn 0;\n-\n-\treturn yt921x_reg_write(priv, YT921X_MIRROR, ctrl);\n-}\n-\n-static void\n-yt921x_dsa_port_mirror_del(struct dsa_switch *ds, int port,\n-\t\t\t struct dsa_mall_mirror_tc_entry *mirror)\n-{\n-\tstruct yt921x_priv *priv = to_yt921x_priv(ds);\n-\tstruct device *dev = to_device(priv);\n-\tint res;\n-\n-\tmutex_lock(\u0026priv-\u003ereg_lock);\n-\tres = yt921x_mirror_del(priv, port, mirror-\u003eingress);\n-\tmutex_unlock(\u0026priv-\u003ereg_lock);\n-\n-\tif (res)\n-\t\tdev_err(dev, \"Failed to %s port %d: %i\\n\", \"unmirror\",\n-\t\t\tport, res);\n-}\n-\n-static int\n-yt921x_dsa_port_mirror_add(struct dsa_switch *ds, int port,\n-\t\t\t struct dsa_mall_mirror_tc_entry *mirror,\n-\t\t\t bool ingress, struct netlink_ext_ack *extack)\n-{\n-\tstruct yt921x_priv *priv = to_yt921x_priv(ds);\n-\tint res;\n-\n-\tmutex_lock(\u0026priv-\u003ereg_lock);\n-\tres = yt921x_mirror_add(priv, port, ingress,\n-\t\t\t\tmirror-\u003eto_local_port, extack);\n-\tmutex_unlock(\u0026priv-\u003ereg_lock);\n-\n-\treturn res;\n-}\n-\n static int yt921x_lag_hash(struct yt921x_priv *priv, u32 ctrl, bool unique_lag,\n \t\t\t struct netlink_ext_ack *extack)\n {\n@@ -2143,7 +684,7 @@ static int yt921x_lag_set(struct yt921x_priv *priv, u8 index, u16 ports_mask)\n static int\n yt921x_dsa_port_lag_leave(struct dsa_switch *ds, int port, struct dsa_lag lag)\n {\n-\tstruct yt921x_priv *priv = to_yt921x_priv(ds);\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(ds);\n \tstruct dsa_port *dp;\n \tu32 ctrl;\n \tint res;\n@@ -2206,7 +747,7 @@ yt921x_dsa_port_lag_join(struct dsa_switch *ds, int port, struct dsa_lag lag,\n \t\t\t struct netdev_lag_upper_info *info,\n \t\t\t struct netlink_ext_ack *extack)\n {\n-\tstruct yt921x_priv *priv = to_yt921x_priv(ds);\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(ds);\n \tstruct dsa_port *dp;\n \tbool unique_lag;\n \tunsigned int i;\n@@ -2269,7 +810,7 @@ yt921x_dsa_port_lag_join(struct dsa_switch *ds, int port, struct dsa_lag lag,\n \n static int yt921x_fdb_wait(struct yt921x_priv *priv, u32 *valp)\n {\n-\tstruct device *dev = to_device(priv);\n+\tstruct device *dev = yt921x_priv_to_device(priv);\n \tu32 val = YT921X_FDB_RESULT_DONE;\n \tint res;\n \n@@ -2338,7 +879,7 @@ static int\n yt921x_fdb_read(struct yt921x_priv *priv, unsigned char *addr, u16 *vidp,\n \t\tu16 *ports_maskp, u16 *indexp, u8 *statusp)\n {\n-\tstruct device *dev = to_device(priv);\n+\tstruct device *dev = yt921x_priv_to_device(priv);\n \tu16 index;\n \tu32 data0;\n \tu32 data1;\n@@ -2629,7 +1170,7 @@ static int\n yt921x_dsa_port_fdb_dump(struct dsa_switch *ds, int port,\n \t\t\t dsa_fdb_dump_cb_t *cb, void *data)\n {\n-\tstruct yt921x_priv *priv = to_yt921x_priv(ds);\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(ds);\n \tint res;\n \n \tmutex_lock(\u0026priv-\u003ereg_lock);\n@@ -2644,8 +1185,8 @@ yt921x_dsa_port_fdb_dump(struct dsa_switch *ds, int port,\n \n static void yt921x_dsa_port_fast_age(struct dsa_switch *ds, int port)\n {\n-\tstruct yt921x_priv *priv = to_yt921x_priv(ds);\n-\tstruct device *dev = to_device(priv);\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(ds);\n+\tstruct device *dev = yt921x_priv_to_device(priv);\n \tint res;\n \n \tmutex_lock(\u0026priv-\u003ereg_lock);\n@@ -2660,7 +1201,7 @@ static void yt921x_dsa_port_fast_age(struct dsa_switch *ds, int port)\n static int\n yt921x_dsa_set_ageing_time(struct dsa_switch *ds, unsigned int msecs)\n {\n-\tstruct yt921x_priv *priv = to_yt921x_priv(ds);\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(ds);\n \tu32 ctrl;\n \tint res;\n \n@@ -2678,7 +1219,7 @@ static int\n yt921x_dsa_port_fdb_del(struct dsa_switch *ds, int port,\n \t\t\tconst unsigned char *addr, u16 vid, struct dsa_db db)\n {\n-\tstruct yt921x_priv *priv = to_yt921x_priv(ds);\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(ds);\n \tint res;\n \n \tmutex_lock(\u0026priv-\u003ereg_lock);\n@@ -2692,7 +1233,7 @@ static int\n yt921x_dsa_port_fdb_add(struct dsa_switch *ds, int port,\n \t\t\tconst unsigned char *addr, u16 vid, struct dsa_db db)\n {\n-\tstruct yt921x_priv *priv = to_yt921x_priv(ds);\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(ds);\n \tint res;\n \n \tmutex_lock(\u0026priv-\u003ereg_lock);\n@@ -2707,7 +1248,7 @@ yt921x_dsa_port_mdb_del(struct dsa_switch *ds, int port,\n \t\t\tconst struct switchdev_obj_port_mdb *mdb,\n \t\t\tstruct dsa_db db)\n {\n-\tstruct yt921x_priv *priv = to_yt921x_priv(ds);\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(ds);\n \tconst unsigned char *addr = mdb-\u003eaddr;\n \tu16 vid = mdb-\u003evid;\n \tint res;\n@@ -2724,7 +1265,7 @@ yt921x_dsa_port_mdb_add(struct dsa_switch *ds, int port,\n \t\t\tconst struct switchdev_obj_port_mdb *mdb,\n \t\t\tstruct dsa_db db)\n {\n-\tstruct yt921x_priv *priv = to_yt921x_priv(ds);\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(ds);\n \tconst unsigned char *addr = mdb-\u003eaddr;\n \tu16 vid = mdb-\u003evid;\n \tint res;\n@@ -2889,7 +1430,7 @@ yt921x_dsa_port_vlan_filtering(struct dsa_switch *ds, int port,\n \t\t\t bool vlan_filtering,\n \t\t\t struct netlink_ext_ack *extack)\n {\n-\tstruct yt921x_priv *priv = to_yt921x_priv(ds);\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(ds);\n \tint res;\n \n \tif (dsa_is_cpu_port(ds, port))\n@@ -2906,7 +1447,7 @@ static int\n yt921x_dsa_port_vlan_del(struct dsa_switch *ds, int port,\n \t\t\t const struct switchdev_obj_port_vlan *vlan)\n {\n-\tstruct yt921x_priv *priv = to_yt921x_priv(ds);\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(ds);\n \tu16 vid = vlan-\u003evid;\n \tu16 pvid;\n \tint res;\n@@ -2940,7 +1481,7 @@ yt921x_dsa_port_vlan_add(struct dsa_switch *ds, int port,\n \t\t\t const struct switchdev_obj_port_vlan *vlan,\n \t\t\t struct netlink_ext_ack *extack)\n {\n-\tstruct yt921x_priv *priv = to_yt921x_priv(ds);\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(ds);\n \tu16 vid = vlan-\u003evid;\n \tu16 pvid;\n \tint res;\n@@ -3185,7 +1726,7 @@ yt921x_dsa_port_bridge_flags(struct dsa_switch *ds, int port,\n \t\t\t struct switchdev_brport_flags flags,\n \t\t\t struct netlink_ext_ack *extack)\n {\n-\tstruct yt921x_priv *priv = to_yt921x_priv(ds);\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(ds);\n \tint res;\n \n \tif (dsa_is_cpu_port(ds, port))\n@@ -3202,8 +1743,8 @@ static void\n yt921x_dsa_port_bridge_leave(struct dsa_switch *ds, int port,\n \t\t\t struct dsa_bridge bridge)\n {\n-\tstruct yt921x_priv *priv = to_yt921x_priv(ds);\n-\tstruct device *dev = to_device(priv);\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(ds);\n+\tstruct device *dev = yt921x_priv_to_device(priv);\n \tint res;\n \n \tif (dsa_is_cpu_port(ds, port))\n@@ -3223,7 +1764,7 @@ yt921x_dsa_port_bridge_join(struct dsa_switch *ds, int port,\n \t\t\t struct dsa_bridge bridge, bool *tx_fwd_offload,\n \t\t\t struct netlink_ext_ack *extack)\n {\n-\tstruct yt921x_priv *priv = to_yt921x_priv(ds);\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(ds);\n \tu16 ports_mask;\n \tint res;\n \n@@ -3244,7 +1785,7 @@ static int\n yt921x_dsa_port_mst_state_set(struct dsa_switch *ds, int port,\n \t\t\t const struct switchdev_mst_state *st)\n {\n-\tstruct yt921x_priv *priv = to_yt921x_priv(ds);\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(ds);\n \tu32 mask;\n \tu32 ctrl;\n \tint res;\n@@ -3278,7 +1819,7 @@ static int\n yt921x_dsa_vlan_msti_set(struct dsa_switch *ds, struct dsa_bridge bridge,\n \t\t\t const struct switchdev_vlan_msti *msti)\n {\n-\tstruct yt921x_priv *priv = to_yt921x_priv(ds);\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(ds);\n \tu32 masks[2];\n \tu32 ctrls[2];\n \tint res;\n@@ -3304,9 +1845,9 @@ yt921x_dsa_vlan_msti_set(struct dsa_switch *ds, struct dsa_bridge bridge,\n static void\n yt921x_dsa_port_stp_state_set(struct dsa_switch *ds, int port, u8 state)\n {\n-\tstruct yt921x_priv *priv = to_yt921x_priv(ds);\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(ds);\n \tstruct dsa_port *dp = dsa_to_port(ds, port);\n-\tstruct device *dev = to_device(priv);\n+\tstruct device *dev = yt921x_priv_to_device(priv);\n \tbool learning;\n \tu32 mask;\n \tu32 ctrl;\n@@ -3356,7 +1897,7 @@ yt921x_dsa_port_stp_state_set(struct dsa_switch *ds, int port, u8 state)\n static int __maybe_unused\n yt921x_dsa_port_get_default_prio(struct dsa_switch *ds, int port)\n {\n-\tstruct yt921x_priv *priv = to_yt921x_priv(ds);\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(ds);\n \tu32 val;\n \tint res;\n \n@@ -3373,7 +1914,7 @@ yt921x_dsa_port_get_default_prio(struct dsa_switch *ds, int port)\n static int __maybe_unused\n yt921x_dsa_port_set_default_prio(struct dsa_switch *ds, int port, u8 prio)\n {\n-\tstruct yt921x_priv *priv = to_yt921x_priv(ds);\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(ds);\n \tu32 mask;\n \tu32 ctrl;\n \tint res;\n@@ -3399,7 +1940,7 @@ static int __maybe_unused\n yt921x_dsa_port_get_apptrust(struct dsa_switch *ds, int port, u8 *sel,\n \t\t\t int *nselp)\n {\n-\tstruct yt921x_priv *priv = to_yt921x_priv(ds);\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(ds);\n \tu8 appprios[2][2] = {};\n \tint nsel;\n \tu32 val;\n@@ -3433,8 +1974,8 @@ static int __maybe_unused\n yt921x_dsa_port_set_apptrust(struct dsa_switch *ds, int port, const u8 *sel,\n \t\t\t int nsel)\n {\n-\tstruct yt921x_priv *priv = to_yt921x_priv(ds);\n-\tstruct device *dev = to_device(priv);\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(ds);\n+\tstruct device *dev = yt921x_priv_to_device(priv);\n \tu32 ctrl;\n \tint res;\n \n@@ -3576,7 +2117,7 @@ yt921x_port_config(struct yt921x_priv *priv, int port, unsigned int mode,\n {\n \tconst struct yt921x_info *info = priv-\u003einfo;\n \tstruct yt921x_port *pp = \u0026priv-\u003eports[port];\n-\tstruct device *dev = to_device(priv);\n+\tstruct device *dev = yt921x_priv_to_device(priv);\n \tu32 mask;\n \tint res;\n \n@@ -3628,7 +2169,7 @@ yt921x_phylink_mac_select_pcs(struct phylink_config *config,\n \t\t\t phy_interface_t interface)\n {\n \tstruct dsa_port *dp = dsa_phylink_to_port(config);\n-\tstruct yt921x_priv *priv = to_yt921x_priv(dp-\u003eds);\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(dp-\u003eds);\n \tconst struct yt921x_info *info = priv-\u003einfo;\n \tint port = dp-\u003eindex;\n \n@@ -3651,7 +2192,7 @@ yt921x_phylink_mac_link_down(struct phylink_config *config, unsigned int mode,\n \t\t\t phy_interface_t interface)\n {\n \tstruct dsa_port *dp = dsa_phylink_to_port(config);\n-\tstruct yt921x_priv *priv = to_yt921x_priv(dp-\u003eds);\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(dp-\u003eds);\n \tint port = dp-\u003eindex;\n \tint res;\n \n@@ -3674,7 +2215,7 @@ yt921x_phylink_mac_link_up(struct phylink_config *config,\n \t\t\t bool tx_pause, bool rx_pause)\n {\n \tstruct dsa_port *dp = dsa_phylink_to_port(config);\n-\tstruct yt921x_priv *priv = to_yt921x_priv(dp-\u003eds);\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(dp-\u003eds);\n \tint port = dp-\u003eindex;\n \tint res;\n \n@@ -3695,7 +2236,7 @@ yt921x_phylink_mac_config(struct phylink_config *config, unsigned int mode,\n \t\t\t const struct phylink_link_state *state)\n {\n \tstruct dsa_port *dp = dsa_phylink_to_port(config);\n-\tstruct yt921x_priv *priv = to_yt921x_priv(dp-\u003eds);\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(dp-\u003eds);\n \tint port = dp-\u003eindex;\n \tint res;\n \n@@ -3712,7 +2253,7 @@ static void\n yt921x_dsa_phylink_get_caps(struct dsa_switch *ds, int port,\n \t\t\t struct phylink_config *config)\n {\n-\tstruct yt921x_priv *priv = to_yt921x_priv(ds);\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(ds);\n \tconst struct yt921x_info *info = priv-\u003einfo;\n \n \tconfig-\u003emac_capabilities = MAC_ASYM_PAUSE | MAC_SYM_PAUSE |\n@@ -3803,7 +2344,7 @@ yt921x_dsa_get_tag_protocol(struct dsa_switch *ds, int port,\n \n static int yt921x_dsa_port_setup(struct dsa_switch *ds, int port)\n {\n-\tstruct yt921x_priv *priv = to_yt921x_priv(ds);\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(ds);\n \tint res;\n \n \tmutex_lock(\u0026priv-\u003ereg_lock);\n@@ -3817,7 +2358,7 @@ static int yt921x_dsa_port_setup(struct dsa_switch *ds, int port)\n static int __maybe_unused\n yt921x_dsa_port_get_dscp_prio(struct dsa_switch *ds, int port, u8 dscp)\n {\n-\tstruct yt921x_priv *priv = to_yt921x_priv(ds);\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(ds);\n \tu32 val;\n \tint res;\n \n@@ -3834,7 +2375,7 @@ yt921x_dsa_port_get_dscp_prio(struct dsa_switch *ds, int port, u8 dscp)\n static int __maybe_unused\n yt921x_dsa_port_del_dscp_prio(struct dsa_switch *ds, int port, u8 dscp, u8 prio)\n {\n-\tstruct yt921x_priv *priv = to_yt921x_priv(ds);\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(ds);\n \tu32 val;\n \tint res;\n \n@@ -3859,7 +2400,7 @@ yt921x_dsa_port_del_dscp_prio(struct dsa_switch *ds, int port, u8 dscp, u8 prio)\n static int __maybe_unused\n yt921x_dsa_port_add_dscp_prio(struct dsa_switch *ds, int port, u8 dscp, u8 prio)\n {\n-\tstruct yt921x_priv *priv = to_yt921x_priv(ds);\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(ds);\n \tint res;\n \n \tif (prio \u003e= YT921X_PRIO_NUM)\n@@ -3920,7 +2461,7 @@ static int yt921x_edata_read(struct yt921x_priv *priv, u8 addr, u8 *valp)\n static void yt921x_dsa_teardown(struct dsa_switch *ds)\n {\n #if IS_ENABLED(CONFIG_NET_DSA_YT921X_LEDS)\n-\tstruct yt921x_priv *priv = to_yt921x_priv(ds);\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(ds);\n \n \tyt921x_leds_remove(priv);\n #endif\n@@ -3928,7 +2469,7 @@ static void yt921x_dsa_teardown(struct dsa_switch *ds)\n \n static int yt921x_chip_detect(struct yt921x_priv *priv)\n {\n-\tstruct device *dev = to_device(priv);\n+\tstruct device *dev = yt921x_priv_to_device(priv);\n \tconst struct yt921x_info *info;\n \tu8 extmode;\n \tu32 chipid;\n@@ -3995,7 +2536,7 @@ static int yt921x_chip_detect(struct yt921x_priv *priv)\n \n static int yt921x_chip_reset(struct yt921x_priv *priv)\n {\n-\tstruct device *dev = to_device(priv);\n+\tstruct device *dev = yt921x_priv_to_device(priv);\n \tu16 eth_p_tag;\n \tu32 val;\n \tint res;\n@@ -4145,8 +2686,7 @@ static int yt921x_chip_setup_acl(struct yt921x_priv *priv)\n \tif (res)\n \t\treturn res;\n \n-\tctrl = YT921X_ACL_PORT_PORTS_M;\n-\tres = yt921x_reg_write(priv, YT921X_ACL_PORT, ctrl);\n+\tres = yt921x_reg_write(priv, YT921X_ACL_PORT, 0);\n \tif (res)\n \t\treturn res;\n \n@@ -4243,8 +2783,8 @@ static int yt921x_chip_setup(struct yt921x_priv *priv)\n \n static int yt921x_dsa_setup(struct dsa_switch *ds)\n {\n-\tstruct yt921x_priv *priv = to_yt921x_priv(ds);\n-\tstruct device *dev = to_device(priv);\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(ds);\n+\tstruct device *dev = yt921x_priv_to_device(priv);\n \tstruct device_node *np = dev-\u003eof_node;\n \tstruct device_node *child;\n \tunsigned long mask;\ndiff --git a/drivers/net/dsa/motorcomm/chip.h b/drivers/net/dsa/motorcomm/chip.h\nindex 28e4f26f9cc49..68cbbc9b9b78d 100644\n--- a/drivers/net/dsa/motorcomm/chip.h\n+++ b/drivers/net/dsa/motorcomm/chip.h\n@@ -434,249 +434,6 @@ enum yt921x_app_selector {\n #define YT921X_VLAN_CTRLa_METER_EN\t\tBIT(5)\n #define YT921X_VLAN_CTRLa_METER_ID_M\t\tGENMASK(4, 0)\n \n-#define YT921X_ACLn_ACT(n)\t\t(0x1c0000 + 0x10 * (n))\n-#define YT921X_ACL_ACTc_STAG_M\t\t\tGENMASK(26, 25)\n-#define YT921X_ACL_ACTc_STAG(x)\t\t\tFIELD_PREP(YT921X_ACL_ACTc_STAG_M, (x))\n-#define YT921X_ACL_ACTc_STAG_DONTCARE\t\t\tYT921X_ACL_ACTc_STAG(0)\n-#define YT921X_ACL_ACTc_STAG_UNTAG\t\t\tYT921X_ACL_ACTc_STAG(1)\n-#define YT921X_ACL_ACTc_STAG_TAG\t\t\tYT921X_ACL_ACTc_STAG(2)\n-#define YT921X_ACL_ACTc_STAG_KEEP\t\t\tYT921X_ACL_ACTc_STAG(3)\n-#define YT921X_ACL_ACTc_CTAG_M\t\t\tGENMASK(24, 23)\n-#define YT921X_ACL_ACTc_CTAG(x)\t\t\tFIELD_PREP(YT921X_ACL_ACTc_CTAG_M, (x))\n-#define YT921X_ACL_ACTc_CTAG_DONTCARE\t\t\tYT921X_ACL_ACTc_CTAG(0)\n-#define YT921X_ACL_ACTc_CTAG_UNTAG\t\t\tYT921X_ACL_ACTc_CTAG(1)\n-#define YT921X_ACL_ACTc_CTAG_TAG\t\t\tYT921X_ACL_ACTc_CTAG(2)\n-#define YT921X_ACL_ACTc_CTAG_KEEP\t\t\tYT921X_ACL_ACTc_CTAG(3)\n-#define YT921X_ACL_ACTc_FWD_M\t\t\tGENMASK(22, 21)\n-#define YT921X_ACL_ACTc_FWD(x)\t\t\tFIELD_PREP(YT921X_ACL_ACTc_FWD_M, (x))\n-#define YT921X_ACL_ACTc_FWD_FWD\t\t\tYT921X_ACL_ACTc_FWD(0)\n-#define YT921X_ACL_ACTc_FWD_COPY\t\t\tYT921X_ACL_ACTc_FWD(1)\n-#define YT921X_ACL_ACTc_FWD_REDIR\t\t\tYT921X_ACL_ACTc_FWD(2)\n-#define YT921X_ACL_ACTc_FWD_TRAP\t\t\tYT921X_ACL_ACTc_FWD(3)\n-#define YT921X_ACL_ACTc_FWD_REDIR_DPORTS_M\tGENMASK(20, 10)\n-#define YT921X_ACL_ACTc_FWD_REDIR_DPORTS(x)\t\tFIELD_PREP(YT921X_ACL_ACTc_FWD_REDIR_DPORTS_M, (x))\n-#define YT921X_ACL_ACTc_FWD_REDIR_DPORTn(port)\tBIT((port) + 10)\n-#define YT921X_ACL_ACTc_FWD_EN\t\t\tBIT(9)\n-#define YT921X_ACL_ACTc_SDEI\t\t\tBIT(8)\n-#define YT921X_ACL_ACTc_SDEI_REPLACE\t\tBIT(7)\n-#define YT921X_ACL_ACTc_SPRI_M\t\t\tGENMASK(6, 4)\n-#define YT921X_ACL_ACTc_SPRI(x)\t\t\tFIELD_PREP(YT921X_ACL_ACTc_SPRI_M, (x))\n-#define YT921X_ACL_ACTc_SPRI_REPLACE\t\tBIT(3)\n-#define YT921X_ACL_ACTbc_SVID_M\t\tGENMASK_ULL(34, 23)\n-#define YT921X_ACL_ACTbc_SVID(x)\t\t\tFIELD_PREP(YT921X_ACL_ACTbc_SVID_M, (x))\n-#define YT921X_ACL_ACTb_SVID_REPLACE\t\tBIT(22)\n-#define YT921X_ACL_ACTb_CDEI\t\t\tBIT(21)\n-#define YT921X_ACL_ACTb_CDEI_REPLACE\t\tBIT(20)\n-#define YT921X_ACL_ACTb_CPRI_M\t\t\tGENMASK(19, 17)\n-#define YT921X_ACL_ACTb_CPRI(x)\t\t\tFIELD_PREP(YT921X_ACL_ACTb_CPRI_M, (x))\n-#define YT921X_ACL_ACTb_CPRI_REPLACE\t\tBIT(16)\n-#define YT921X_ACL_ACTb_CVID_M\t\t\tGENMASK(15, 4)\n-#define YT921X_ACL_ACTb_CVID(x)\t\t\tFIELD_PREP(YT921X_ACL_ACTb_CVID_M, (x))\n-#define YT921X_ACL_ACTb_CVID_REPLACE\t\tBIT(3)\n-#define YT921X_ACL_ACTb_PRIO_M\t\t\tGENMASK(2, 0)\n-#define YT921X_ACL_ACTb_PRIO(x)\t\t\tFIELD_PREP(YT921X_ACL_ACTb_PRIO_M, (x))\n-#define YT921X_ACL_ACTa_PRIO_EN\t\tBIT(31)\n-#define YT921X_ACL_ACTa_COLOR_M\t\tGENMASK(30, 29)\n-#define YT921X_ACL_ACTa_COLOR(x)\t\t\tFIELD_PREP(YT921X_ACL_ACTa_COLOR_M, (x))\n-#define YT921X_ACL_ACTa_COLOR_GREEN\t\t\tYT921X_ACL_ACTa_COLOR(0)\n-#define YT921X_ACL_ACTa_COLOR_YELLOW\t\t\tYT921X_ACL_ACTa_COLOR(1)\n-#define YT921X_ACL_ACTa_COLOR_RED\t\t\tYT921X_ACL_ACTa_COLOR(2)\n-#define YT921X_ACL_ACTa_COLOR_EN\t\tBIT(28)\n-#define YT921X_ACL_ACTa_DSCP_M\t\t\tGENMASK(27, 22)\n-#define YT921X_ACL_ACTa_DSCP(x)\t\t\tFIELD_PREP(YT921X_ACL_ACTa_DSCP_M, (x))\n-#define YT921X_ACL_ACTa_DSCP_REPLACE\t\tBIT(21)\n-#define YT921X_ACL_ACTa_METER_ID_M\t\tGENMASK(20, 15)\n-#define YT921X_ACL_ACTa_METER_ID(x)\t\t\tFIELD_PREP(YT921X_ACL_ACTa_METER_ID_M, (x))\n-#define YT921X_ACL_ACTa_METER_EN\t\tBIT(14)\n-#define YT921X_ACL_ACTa_MIRROR_EN\t\tBIT(13)\n-#define YT921X_ACL_ACTa_FLOWSTAT_EN\t\tBIT(12)\n-#define YT921X_ACL_ACTa_FLOWSTAT_ID_M\t\tGENMASK(11, 6)\n-#define YT921X_ACL_ACTa_FLOWSTAT_ID(x)\t\tFIELD_PREP(YT921X_ACL_ACTa_FLOWSTAT_ID_M, (x))\n-#define YT921X_ACL_ACTa_GPIO_EN\t\tBIT(5)\n-#define YT921X_ACL_ACTa_GPIO_PIN_M\t\tGENMASK(4, 1)\n-#define YT921X_ACL_ACTa_GPIO_PIN(x)\t\t\tFIELD_PREP(YT921X_ACL_ACTa_GPIO_PIN_M, (x))\n-#define YT921X_ACL_ACTa_INTR_EN\t\tBIT(0)\n-#define YT921X_ACL_BLK_KEEP\t\t0x201000\n-#define YT921X_ACL_BLK_KEEP_GRPIDn_M(bin)\t(7 \u003c\u003c (4 * (bin) + 1))\n-#define YT921X_ACL_BLK_KEEP_GRPIDn(bin, x)\t\t((x) \u003c\u003c (4 * (bin) + 1))\n-#define YT921X_ACL_BLK_KEEP_KEEPn(bin)\t\tBIT(4 * (bin))\n-#define YT921X_ACL_PORT\t\t\t0x202000\n-#define YT921X_ACL_PORT_PORTS_M\t\tGENMASK(10, 0)\n-#define YT921X_ACL_PORT_PORTS(x)\t\t\tFIELD_PREP(YT921X_ACL_PORT_PORTS_M, (x))\n-#define YT921X_ACL_PORT_PORTn(port)\t\tBIT(port)\n-#define YT921X_ACL_BLK_CMD\t\t0x202004\n-#define YT921X_ACL_BLK_CMD_BLKID_M\t\tGENMASK(6, 1)\n-#define YT921X_ACL_BLK_CMD_BLKID(x)\t\t\tFIELD_PREP(YT921X_ACL_BLK_CMD_BLKID_M, (x))\n-#define YT921X_ACL_BLK_CMD_MODIFY\t\tBIT(0)\n-#define YT921X_ACLn_ENTRY(blk)\t\t(0x203000 + 4 * (blk))\n-#define YT921X_ACL_ENTRY_GRPIDm_M(bin)\t\t(7 \u003c\u003c (4 * (bin) + 1))\n-#define YT921X_ACL_ENTRY_GRPIDm(bin, x)\t\t((x) \u003c\u003c (4 * (bin) + 1))\n-#define YT921X_ACL_ENTRY_ENm(bin)\t\tBIT(4 * (bin))\n-#define YT921X_ACLn_KEYm(blk, bin)\t(0x204000 + 0x200 * (bin) + 8 * (blk))\n-#define YT921X_ACL_KEYb_ORD_M\t\t\tGENMASK(29, 21)\n-#define YT921X_ACL_KEYb_ORD(x)\t\t\tFIELD_PREP(YT921X_ACL_KEYb_ORD_M, (x))\n-#define YT921X_ACL_KEYb_SPORTS_M\t\tGENMASK(20, 10)\n-#define YT921X_ACL_KEYb_SPORTS(x)\t\t\tFIELD_PREP(YT921X_ACL_KEYb_SPORTS_M, (x))\n-#define YT921X_ACL_KEYb_SPORTn(port)\t\tBIT((port) + 10)\n-#define YT921X_ACL_KEYb_REVERSE\t\tBIT(9)\t/* reverse match */\n-#define YT921X_ACL_KEYb_TYPE_M\t\t\tGENMASK(8, 4)\n-#define YT921X_ACL_KEYb_TYPE(x)\t\t\tFIELD_PREP(YT921X_ACL_KEYb_TYPE_M, (x))\n-/* KEY_* fields need no masks */\n-#define YT921X_ACLn_MASKm(blk, bin)\t(0x205000 + 0x200 * (bin) + 8 * (blk))\n-\n-enum yt921x_acl_type {\n-\tYT921X_ACL_TYPE_NA,\n-\tYT921X_ACL_TYPE_MAC_DA0,\n-\tYT921X_ACL_TYPE_MAC_SA0,\n-\tYT921X_ACL_TYPE_MAC_DA1_SA1,\n-\tYT921X_ACL_TYPE_VLAN,\n-\tYT921X_ACL_TYPE_VTAG,\n-\tYT921X_ACL_TYPE_IPV4_DA,\n-\tYT921X_ACL_TYPE_IPV4_SA,\n-\tYT921X_ACL_TYPE_IPV6_DA0,\n-\tYT921X_ACL_TYPE_IPV6_DA1,\n-\tYT921X_ACL_TYPE_IPV6_DA2,\n-\tYT921X_ACL_TYPE_IPV6_DA3,\n-\tYT921X_ACL_TYPE_IPV6_SA0,\n-\tYT921X_ACL_TYPE_IPV6_SA1,\n-\tYT921X_ACL_TYPE_IPV6_SA2,\n-\tYT921X_ACL_TYPE_IPV6_SA3,\n-\tYT921X_ACL_TYPE_MISC,\n-\tYT921X_ACL_TYPE_L4,\n-\tYT921X_ACL_TYPE_UDF0,\n-\tYT921X_ACL_TYPE_UDF1,\n-\tYT921X_ACL_TYPE_UDF2,\n-\tYT921X_ACL_TYPE_UDF3,\n-\tYT921X_ACL_TYPE_UDF4,\n-\tYT921X_ACL_TYPE_UDF5,\n-\tYT921X_ACL_TYPE_UDF6,\n-\tYT921X_ACL_TYPE_UDF7,\n-\tYT921X_ACL_TYPE_ETHERTYPE,\n-\tYT921X_ACL_TYPE_NUM\n-};\n-\n-/* Range: turn KEY:MASK into MIN:MAX */\n-\n-#define YT921X_ACL_BINb_MAC_xA0_L3_TYPE_M\tGENMASK(3, 0)\n-#define YT921X_ACL_BINb_MAC_xA0_L3_TYPE(x)\t\tFIELD_PREP(YT921X_ACL_BINb_MAC_xA0_L3_TYPE_M, (x))\n-#define YT921X_ACL_BINa_MAC_xA0_MAC_xA0_M\tGENMASK(31, 0)\n-\n-#define YT921X_ACL_BINb_MAC_DA1_SA1_L2_TYPE_M\tGENMASK(2, 0)\n-#define YT921X_ACL_BINb_MAC_DA1_SA1_L2_TYPE(x)\tFIELD_PREP(YT921X_ACL_BINb_MAC_DA1_SA1_L2_TYPE_M, (x))\n-#define YT921X_ACL_BINa_MAC_DA1_SA1_MAC_DA1_M\tGENMASK(31, 16)\n-#define YT921X_ACL_BINa_MAC_DA1_SA1_MAC_SA1_M\tGENMASK(15, 0)\n-\n-#define YT921X_ACL_KEYb_VLAN_SVID_RANGE_EN\tBIT(31)\n-#define YT921X_ACL_KEYb_VLAN_CVID_RANGE_EN\tBIT(30)\n-#define YT921X_ACL_BINb_VLAN_CDEI\t\tBIT(3)\n-#define YT921X_ACL_BINb_VLAN_CPRI_M\t\tGENMASK(2, 0)\n-#define YT921X_ACL_BINb_VLAN_CPRI(x)\t\t\tFIELD_PREP(YT921X_ACL_BINb_VLAN_CPRI_M, (x))\n-#define YT921X_ACL_BINa_VLAN_CTAG_FMT_M\tGENMASK(31, 30)\n-#define YT921X_ACL_BINa_VLAN_CTAG_FMT(x)\t\tFIELD_PREP(YT921X_ACL_BINa_VLAN_CTAG_FMT_M, (x))\n-#define YT921X_ACL_BINa_VLAN_SDEI\t\tBIT(29)\n-#define YT921X_ACL_BINa_VLAN_SPRI_M\t\tGENMASK(28, 26)\n-#define YT921X_ACL_BINa_VLAN_SPRI(x)\t\t\tFIELD_PREP(YT921X_ACL_BINa_VLAN_SPRI_M, (x))\n-#define YT921X_ACL_BINa_VLAN_STAG_FMT_M\tGENMASK(25, 24)\n-#define YT921X_ACL_BINa_VLAN_STAG_FMT(x)\t\tFIELD_PREP(YT921X_ACL_BINa_VLAN_STAG_FMT_M, (x))\n-#define YT921X_ACL_BINa_VLAN_SVID_M\t\tGENMASK(23, 12)\n-#define YT921X_ACL_BINa_VLAN_SVID(x)\t\t\tFIELD_PREP(YT921X_ACL_BINa_VLAN_SVID_M, (x))\n-#define YT921X_ACL_BINa_VLAN_CVID_M\t\tGENMASK(11, 0)\n-#define YT921X_ACL_BINa_VLAN_CVID(x)\t\t\tFIELD_PREP(YT921X_ACL_BINa_VLAN_CVID_M, (x))\n-\n-#define YT921X_ACL_KEYb_VTAG_SVID_RANGE_EN\tBIT(31)\n-#define YT921X_ACL_KEYb_VTAG_CVID_RANGE_EN\tBIT(30)\n-#define YT921X_ACL_BINa_VTAG_CDEI\t\tBIT(31)\n-#define YT921X_ACL_BINa_VTAG_CPRI_M\t\tGENMASK(30, 28)\n-#define YT921X_ACL_BINa_VTAG_CPRI(x)\t\t\tFIELD_PREP(YT921X_ACL_BINa_VTAG_CPRI_M, (x))\n-#define YT921X_ACL_BINa_VTAG_SDEI\t\tBIT(27)\n-#define YT921X_ACL_BINa_VTAG_SPRI_M\t\tGENMASK(26, 24)\n-#define YT921X_ACL_BINa_VTAG_SPRI(x)\t\t\tFIELD_PREP(YT921X_ACL_BINa_VTAG_SPRI_M, (x))\n-#define YT921X_ACL_BINa_VTAG_SVID_M\t\tGENMASK(23, 12)\n-#define YT921X_ACL_BINa_VTAG_SVID(x)\t\t\tFIELD_PREP(YT921X_ACL_BINa_VTAG_SVID_M, (x))\n-#define YT921X_ACL_BINa_VTAG_CVID_M\t\tGENMASK(11, 0)\n-#define YT921X_ACL_BINa_VTAG_CVID(x)\t\t\tFIELD_PREP(YT921X_ACL_BINa_VTAG_CVID_M, (x))\n-\n-#define YT921X_ACL_KEYb_IPV4_ADDR_RANGE_EN\tBIT(30)\n-#define YT921X_ACL_BINb_IPV4_FRAG\t\tBIT(3)\n-#define YT921X_ACL_BINb_IPV4_L4_TYPE_M\t\tGENMASK(2, 0)\n-#define YT921X_ACL_BINb_IPV4_L4_TYPE(x)\t\tFIELD_PREP(YT921X_ACL_BINb_IPV4_L4_TYPE_M, (x))\n-#define YT921X_ACL_BINa_IPV4_ADDR_M\t\tGENMASK(31, 0)\n-\n-#define YT921X_ACL_BINb_IPV6_L4_TYPE_M\t\tGENMASK(2, 0)\n-#define YT921X_ACL_BINb_IPV6_L4_TYPE(x)\t\tFIELD_PREP(YT921X_ACL_BINb_IPV6_L4_TYPE_M, (x))\n-#define YT921X_ACL_BINa_IPV6_ADDRx_M\t\tGENMASK(31, 0)\n-\n-#define YT921X_ACL_BINb_IPV6_xA1_IP_OPTION\tBIT(3)\n-\n-#define YT921X_ACL_BINb_IPV6_xA2_FIRST_FRAG\tBIT(3)\n-\n-#define YT921X_ACL_KEYb_IPV6_xA3_ADDR_RANGE_EN\tBIT(30)\n-#define YT921X_ACL_BINb_IPV6_xA3_FRAG\t\tBIT(3)\n-\n-#define YT921X_ACL_BINb_MISC_FRAG\t\tBIT(3)\n-#define YT921X_ACL_BINb_MISC_L4_TYPE_M\t\tGENMASK(2, 0)\n-#define YT921X_ACL_BINb_MISC_L4_TYPE(x)\t\tFIELD_PREP(YT921X_ACL_BINb_MISC_L4_TYPE_M, (x))\n-#define YT921X_ACL_BINa_MISC_PPPOE_FLAG\tBIT(30)\n-#define YT921X_ACL_BINa_MISC_FIRST_FRAG\tBIT(29)\n-#define YT921X_ACL_BINa_MISC_IP_OPTION\t\tBIT(28)\n-#define YT921X_ACL_BINa_MISC_TCP_FLAGS_M\tGENMASK(27, 20)\n-#define YT921X_ACL_BINa_MISC_TCP_FLAGS(x)\t\tFIELD_PREP(YT921X_ACL_BINa_MISC_TCP_FLAGS_M, (x))\n-#define YT921X_ACL_BINa_MISC_IP_PROTO_M\tGENMASK(19, 12)\n-#define YT921X_ACL_BINa_MISC_IP_PROTO(x)\t\tFIELD_PREP(YT921X_ACL_BINa_MISC_IP_PROTO_M, (x))\n-#define YT921X_ACL_BINa_MISC_TOS_M\t\tGENMASK(11, 4)\n-#define YT921X_ACL_BINa_MISC_TOS(x)\t\t\tFIELD_PREP(YT921X_ACL_BINa_MISC_TOS_M, (x))\n-#define YT921X_ACL_BINa_MISC_L3_TYPE_M\t\tGENMASK(3, 0)\n-#define YT921X_ACL_BINa_MISC_L3_TYPE(x)\t\tFIELD_PREP(YT921X_ACL_BINa_MISC_L3_TYPE_M, (x))\n-\n-#define YT921X_ACL_KEYb_L4_DPORT_RANGE_EN\tBIT(31)\n-#define YT921X_ACL_KEYb_L4_SPORT_RANGE_EN\tBIT(30)\n-#define YT921X_ACL_BINb_L4_FRAG\t\tBIT(3)\n-#define YT921X_ACL_BINb_L4_TYPE_M\t\tGENMASK(2, 0)\n-#define YT921X_ACL_BINb_L4_TYPE(x)\t\t\tFIELD_PREP(YT921X_ACL_BINb_L4_TYPE_M, (x))\n-#define YT921X_ACL_BINa_L4_DPORT_M\t\tGENMASK(31, 16)\n-#define YT921X_ACL_BINa_L4_SPORT_M\t\tGENMASK(15, 0)\n-\n-#define YT921X_ACL_BINb_UDF_IS_IGMP\t\tBIT(0)\n-#define YT921X_ACL_BINa_UDF_UDF0_M\t\tGENMASK(31, 16)\n-#define YT921X_ACL_BINa_UDF_UDF0(x)\t\t\tFIELD_PREP(YT921X_ACL_BINa_UDF_UDF0_M, (x))\n-#define YT921X_ACL_BINa_UDF_UDF1_M\t\tGENMASK(15, 0)\n-#define YT921X_ACL_BINa_UDF_UDF1(x)\t\t\tFIELD_PREP(YT921X_ACL_BINa_UDF_UDF1_M, (x))\n-\n-#define YT921X_ACL_KEYb_ETHERTYPE_ETHERTYPE_RANGE_EN\tBIT(30)\n-#define YT921X_ACL_BINb_ETHERTYPE_L4_TYPE_M\tGENMASK(2, 0)\n-#define YT921X_ACL_BINb_ETHERTYPE_L4_TYPE(x)\t\tFIELD_PREP(YT921X_ACL_BINb_ETHERTYPE_L4_TYPE_M, (x))\n-#define YT921X_ACL_BINa_ETHERTYPE_ETHERTYPE_M\tGENMASK(15, 0)\n-#define YT921X_ACL_BINa_ETHERTYPE_ETHERTYPE(x)\tFIELD_PREP(YT921X_ACL_BINa_ETHERTYPE_ETHERTYPE_M, (x))\n-\n-enum yt921x_l2_type {\n-\tYT921X_L2_TYPE_ETH,\n-\tYT921X_L2_TYPE_ETHV2,\n-\tYT921X_L2_TYPE_ETHSAP,\n-\tYT921X_L2_TYPE_ETHSNAP,\n-};\n-\n-enum yt921x_l3_type {\n-\tYT921X_L3_TYPE_OTHER,\n-\tYT921X_L3_TYPE_IPV4,\n-\tYT921X_L3_TYPE_IPV6,\n-\tYT921X_L3_TYPE_ARP,\n-\tYT921X_L3_TYPE_LLDP,\n-\tYT921X_L3_TYPE_PAE,\n-\tYT921X_L3_TYPE_ERP,\n-\tYT921X_L3_TYPE_SLOW_PROTOCOL,\n-};\n-\n-enum yt921x_l4_type {\n-\tYT921X_L4_TYPE_OTHER,\n-\tYT921X_L4_TYPE_TCP,\n-\tYT921X_L4_TYPE_UDP,\n-\tYT921X_L4_TYPE_UDPLITE,\n-\tYT921X_L4_TYPE_ICMP,\n-\tYT921X_L4_TYPE_IGMP,\n-\tYT921X_L4_TYPE_MLD,\n-\tYT921X_L4_TYPE_ND,\n-};\n-\n #define YT921X_TPID_IGRn(x)\t\t(0x210000 + 4 * (x))\t/* [0, 3] */\n #define YT921X_TPID_IGR_TPID_M\t\t\tGENMASK(15, 0)\n #define YT921X_PORTn_IGR_TPID(port)\t(0x210010 + 4 * (port))\n@@ -693,47 +450,6 @@ enum yt921x_l4_type {\n #define YT921X_LAG_HASH_MAC_SA\t\t\tBIT(2)\n #define YT921X_LAG_HASH_MAC_DA\t\t\tBIT(1)\n #define YT921X_LAG_HASH_SRC_PORT\t\tBIT(0)\n-#define YT921X_UDFn_CTRL(x)\t\t(0x210094 + 4 * (x))\n-#define YT921X_UDF_CTRL_UDF_TYPE_M\t\tGENMASK(8, 7)\n-#define YT921X_UDF_CTRL_UDF_TYPE(x)\t\t\tFIELD_PREP(YT921X_UDF_CTRL_UDF_TYPE_M, (x))\n-#define YT921X_UDF_CTRL_UDF_TYPE_ETH\t\t\tYT921X_UDF_CTRL_UDF_TYPE(0)\n-#define YT921X_UDF_CTRL_UDF_TYPE_L3\t\t\tYT921X_UDF_CTRL_UDF_TYPE(1)\n-#define YT921X_UDF_CTRL_UDF_TYPE_L4\t\t\tYT921X_UDF_CTRL_UDF_TYPE(2)\n-#define YT921X_UDF_CTRL_UDF_OFFSET_M\t\tGENMASK(6, 0)\n-#define YT921X_UDF_CTRL_UDF_OFFSET(x)\t\t\tFIELD_PREP(YT921X_UDF_CTRL_UDF_OFFSET_M, (x))\n-\n-#define YT921X_PORTn_RATE(port)\t\t(0x220000 + 4 * (port))\n-#define YT921X_PORT_RATE_GAP_VALUE\t\tGENMASK(4, 0)\t/* default 20 */\n-#define YT921X_METER_SLOT\t\t0x220104\n-#define YT921X_METER_SLOT_SLOT_M\t\tGENMASK(11, 0)\n-#define YT921X_PORTn_METER(port)\t(0x220108 + 4 * (port))\n-#define YT921X_PORT_METER_EN\t\t\tBIT(4)\n-#define YT921X_PORT_METER_ID_M\t\t\tGENMASK(3, 0)\n-#define YT921X_PORT_METER_ID(x)\t\t\tFIELD_PREP(YT921X_PORT_METER_ID_M, (x))\n-#define YT921X_METERn_CTRL(x)\t\t(0x220800 + 0x10 * (x))\n-#define YT921X_METER_CTRLc_METER_EN\t\tBIT(14)\n-#define YT921X_METER_CTRLc_TOKEN_OVERFLOW_EN\tBIT(13)\t/* RFC4115: yellow use unused green bw */\n-#define YT921X_METER_CTRLc_DROP_M\t\tGENMASK(12, 11)\n-#define YT921X_METER_CTRLc_DROP(x)\t\t\tFIELD_PREP(YT921X_METER_CTRLc_DROP_M, (x))\n-#define YT921X_METER_CTRLc_DROP_GYR\t\t\tYT921X_METER_CTRLc_DROP(0)\n-#define YT921X_METER_CTRLc_DROP_YR\t\t\tYT921X_METER_CTRLc_DROP(1)\n-#define YT921X_METER_CTRLc_DROP_R\t\t\tYT921X_METER_CTRLc_DROP(2)\n-#define YT921X_METER_CTRLc_DROP_NONE\t\t\tYT921X_METER_CTRLc_DROP(3)\n-#define YT921X_METER_CTRLc_COLOR_BLIND\t\tBIT(10)\n-#define YT921X_METER_CTRLc_UNIT_M\t\tGENMASK(9, 7)\n-#define YT921X_METER_CTRLc_UNIT(x)\t\t\tFIELD_PREP(YT921X_METER_CTRLc_UNIT_M, (x))\n-#define YT921X_METER_CTRLc_BYTE_MODE_INCLUDE_GAP\tBIT(6)\t/* +GAP_VALUE bytes each packet */\n-#define YT921X_METER_CTRLc_PKT_MODE\t\tBIT(5)\t/* 0: byte rate mode */\n-#define YT921X_METER_CTRLc_RFC2698\t\tBIT(4)\t/* 0: RFC4115 */\n-#define YT921X_METER_CTRLbc_CBS_M\t\tGENMASK_ULL(35, 20)\n-#define YT921X_METER_CTRLbc_CBS(x)\t\t\tFIELD_PREP(YT921X_METER_CTRLbc_CBS_M, (x))\n-#define YT921X_METER_CTRLb_CIR_M\t\tGENMASK(19, 2)\n-#define YT921X_METER_CTRLb_CIR(x)\t\t\tFIELD_PREP(YT921X_METER_CTRLb_CIR_M, (x))\n-#define YT921X_METER_CTRLab_EBS_M\t\tGENMASK_ULL(33, 18)\n-#define YT921X_METER_CTRLab_EBS(x)\t\t\tFIELD_PREP(YT921X_METER_CTRLab_EBS_M, (x))\n-#define YT921X_METER_CTRLa_EIR_M\t\tGENMASK(17, 0)\n-#define YT921X_METER_CTRLa_EIR(x)\t\t\tFIELD_PREP(YT921X_METER_CTRLa_EIR_M, (x))\n-#define YT921X_METERn_STAT(x)\t\t(0x221000 + 8 * (x))\n \n #define YT921X_PORTn_VLAN_CTRL(port)\t(0x230010 + 4 * (port))\n #define YT921X_PORT_VLAN_CTRL_SVLAN_PRIO_EN\tBIT(31)\n@@ -752,29 +468,6 @@ enum yt921x_l4_type {\n #define YT921X_PORT_VLAN_CTRL1_CVLAN_DROP_TAGGED\tBIT(1)\n #define YT921X_PORT_VLAN_CTRL1_CVLAN_DROP_UNTAGGED\tBIT(0)\n \n-#define YT921X_MIRROR\t\t\t0x300300\n-#define YT921X_MIRROR_IGR_PORTS_M\t\tGENMASK(26, 16)\n-#define YT921X_MIRROR_IGR_PORTS(x)\t\t\tFIELD_PREP(YT921X_MIRROR_IGR_PORTS_M, (x))\n-#define YT921X_MIRROR_IGR_PORTn(port)\t\tBIT((port) + 16)\n-#define YT921X_MIRROR_EGR_PORTS_M\t\tGENMASK(14, 4)\n-#define YT921X_MIRROR_EGR_PORTS(x)\t\t\tFIELD_PREP(YT921X_MIRROR_EGR_PORTS_M, (x))\n-#define YT921X_MIRROR_EGR_PORTn(port)\t\tBIT((port) + 4)\n-#define YT921X_MIRROR_PORT_M\t\t\tGENMASK(3, 0)\n-#define YT921X_MIRROR_PORT(x)\t\t\t\tFIELD_PREP(YT921X_MIRROR_PORT_M, (x))\n-\n-#define YT921X_PORT_SHAPE_SLOT\t\t0x34000c\n-#define YT921X_PORT_SHAPE_SLOT_SLOT_M\t\tGENMASK(11, 0)\n-#define YT921X_PORTn_SHAPE_CTRL(port)\t(0x354000 + 8 * (port))\n-#define YT921X_PORT_SHAPE_CTRLb_EN\t\tBIT(4)\n-#define YT921X_PORT_SHAPE_CTRLb_PKT_MODE\tBIT(3)\t/* 0: byte rate mode */\n-#define YT921X_PORT_SHAPE_CTRLb_UNIT_M\t\tGENMASK(2, 0)\n-#define YT921X_PORT_SHAPE_CTRLb_UNIT(x)\t\tFIELD_PREP(YT921X_PORT_SHAPE_CTRLb_UNIT_M, (x))\n-#define YT921X_PORT_SHAPE_CTRLa_CBS_M\t\tGENMASK(31, 18)\n-#define YT921X_PORT_SHAPE_CTRLa_CBS(x)\t\tFIELD_PREP(YT921X_PORT_SHAPE_CTRLa_CBS_M, (x))\n-#define YT921X_PORT_SHAPE_CTRLa_CIR_M\t\tGENMASK(17, 0)\n-#define YT921X_PORT_SHAPE_CTRLa_CIR(x)\t\tFIELD_PREP(YT921X_PORT_SHAPE_CTRLa_CIR_M, (x))\n-#define YT921X_PORTn_SHAPE_STAT(port)\t(0x356000 + 4 * (port))\n-\n #define YT921X_EDATA_EXTMODE\t0xfb\n #define YT921X_EDATA_LEN\t0x100\n \n@@ -791,19 +484,8 @@ enum yt921x_fdb_entry_status {\n \n #define YT921X_MSTI_NUM\t\t16\n \n-#define YT921X_TOKEN_BYTE_C\t1\t/* 1 token = 2^1 byte */\n-#define YT921X_TOKEN_PKT_C\t-6\t/* 1 token = 2^-6 packets */\n-#define YT921X_TOKEN_RATE_C\t-15\n /* Custom meters only, not including dedicated port meters (11) */\n #define YT921X_METER_NUM\t64\n-#define YT921X_METER_SLOT_MIN\t80\n-#define YT921X_METER_UNIT_MAX\t((1 \u003c\u003c 3) - 1)\n-#define YT921X_METER_CIR_MAX\t((1 \u003c\u003c 18) - 1)\n-#define YT921X_METER_CBS_MAX\t((1 \u003c\u003c 16) - 1)\n-#define YT921X_PORT_SHAPE_SLOT_MIN\t80\n-#define YT921X_SHAPE_UNIT_MAX\t((1 \u003c\u003c 3) - 1)\n-#define YT921X_SHAPE_CIR_MAX\t((1 \u003c\u003c 18) - 1)\n-#define YT921X_SHAPE_CBS_MAX\t((1 \u003c\u003c 14) - 1)\n \n #define YT921X_LAG_NUM\t\t2\n #define YT921X_LAG_PORT_NUM\t4\n@@ -821,9 +503,6 @@ enum yt921x_fdb_entry_status {\n #define YT921X_TAG_LEN\t8\n \n #define YT921X_ACL_BLK_NUM\t48\n-#define YT921X_ACL_ENT_PER_BLK\t8\n-#define YT921X_ACL_NUM\t\t(YT921X_ACL_BLK_NUM * YT921X_ACL_ENT_PER_BLK)\n-#define YT921X_UDF_NUM\t\t8\n \n #define YT921X_LED_GROUP_NUM\t3\n #define YT921X_LED_PORT_NUM\t10\n@@ -885,26 +564,6 @@ struct yt921x_mib {\n \tu64 tx_oam;\n };\n \n-struct yt921x_acl_entry {\n-\tu32 key[2];\n-\tu32 mask[2];\n-};\n-\n-struct yt921x_acl_rule {\n-\tunsigned long tag;\n-\tenum tc_setup_type type;\n-\n-\tu32 action[3];\n-\tbool sw_assisted;\n-\n-\tu8 mask;\n-\tstruct yt921x_acl_entry entries[YT921X_ACL_ENT_PER_BLK];\n-};\n-\n-struct yt921x_acl_blk {\n-\tstruct yt921x_acl_rule *rules[YT921X_ACL_ENT_PER_BLK];\n-};\n-\n struct yt921x_port {\n \tunsigned char index;\n \n@@ -922,6 +581,8 @@ struct yt921x_port {\n \tu64 rx_frames;\n \tu64 tx_frames;\n \n+\tunsigned short acl_cnt;\n+\n #if IS_ENABLED(CONFIG_NET_DSA_YT921X_LEDS)\n \tunsigned char led_duty;\n \tunsigned short led_cycle;\n@@ -984,8 +645,10 @@ struct yt921x_priv {\n \tstruct yt921x_acl_blk *acl_blks[YT921X_ACL_BLK_NUM];\n };\n \n+#define dsa_to_yt921x_priv(_ds) container_of_const(_ds, struct yt921x_priv, ds)\n #define yt921x_port_to_priv(pp) \\\n \tcontainer_of_const((pp), struct yt921x_priv, ports[(pp)-\u003eindex])\n+#define yt921x_priv_to_device(priv) ((priv)-\u003eds.dev)\n \n static inline int ethtool_speed_to_yt921x(int speed)\n {\n@@ -1005,4 +668,14 @@ static inline int ethtool_speed_to_yt921x(int speed)\n \t}\n }\n \n+static inline u32 ethaddr_hi4_to_u32(const unsigned char *addr)\n+{\n+\treturn (addr[0] \u003c\u003c 24) | (addr[1] \u003c\u003c 16) | (addr[2] \u003c\u003c 8) | addr[3];\n+}\n+\n+static inline u32 ethaddr_lo2_to_u32(const unsigned char *addr)\n+{\n+\treturn (addr[4] \u003c\u003c 8) | addr[5];\n+}\n+\n #endif\ndiff --git a/drivers/net/dsa/motorcomm/leds.c b/drivers/net/dsa/motorcomm/leds.c\nindex 6613fe3b0471e..a402d1cf28d13 100644\n--- a/drivers/net/dsa/motorcomm/leds.c\n+++ b/drivers/net/dsa/motorcomm/leds.c\n@@ -12,7 +12,6 @@\n #define to_yt921x_led(led_cdev) \\\n \tcontainer_of_const((led_cdev), struct yt921x_led, cdev)\n #define to_yt921x_port(led) ((led)-\u003eport)\n-#define to_device(priv) ((priv)-\u003eds.dev)\n \n static u32 yt921x_led_regaddr(struct yt921x_priv *priv, int port, int group)\n {\n@@ -414,7 +413,7 @@ yt921x_led_setup(struct yt921x_priv *priv, int port,\n \t\t struct fwnode_handle *fwnode)\n {\n \tstruct yt921x_port *pp = \u0026priv-\u003eports[port];\n-\tstruct device *dev = to_device(priv);\n+\tstruct device *dev = yt921x_priv_to_device(priv);\n \tstruct led_init_data init_data;\n \tstruct led_classdev *led_cdev;\n \tchar name[LED_MAX_NAME_SIZE];\n@@ -569,7 +568,7 @@ yt921x_led_setup(struct yt921x_priv *priv, int port,\n static void yt921x_leds_remove_port(struct yt921x_priv *priv, int port)\n {\n \tstruct yt921x_port *pp = \u0026priv-\u003eports[port];\n-\tstruct device *dev = to_device(priv);\n+\tstruct device *dev = yt921x_priv_to_device(priv);\n \n \tfor (int group = 0; group \u003c YT921X_LED_GROUP_NUM; group++) {\n \t\tstruct yt921x_led *led = pp-\u003eleds[group];\n@@ -587,7 +586,7 @@ static void yt921x_leds_remove_port(struct yt921x_priv *priv, int port)\n \n static int yt921x_leds_setup_port(struct yt921x_priv *priv, int port)\n {\n-\tstruct device *dev = to_device(priv);\n+\tstruct device *dev = yt921x_priv_to_device(priv);\n \tstruct dsa_switch *ds = \u0026priv-\u003eds;\n \tstruct device_node *leds_np;\n \tstruct dsa_port *dp;\ndiff --git a/drivers/net/dsa/motorcomm/mdio_bus.c b/drivers/net/dsa/motorcomm/mdio_bus.c\nindex 1a3f3cc68275d..dd6c52f37bbf5 100644\n--- a/drivers/net/dsa/motorcomm/mdio_bus.c\n+++ b/drivers/net/dsa/motorcomm/mdio_bus.c\n@@ -9,8 +9,6 @@\n #include \"mdio_bus.h\"\n #include \"smi.h\"\n \n-#define to_device(priv) ((priv)-\u003eds.dev)\n-\n static int yt921x_intif_wait(struct yt921x_priv *priv)\n {\n \tu32 val = 0;\n@@ -21,7 +19,7 @@ static int yt921x_intif_wait(struct yt921x_priv *priv)\n \n int yt921x_intif_read(struct yt921x_priv *priv, int port, int reg, u16 *valp)\n {\n-\tstruct device *dev = to_device(priv);\n+\tstruct device *dev = yt921x_priv_to_device(priv);\n \tu32 mask;\n \tu32 ctrl;\n \tu32 val;\n@@ -145,7 +143,7 @@ yt921x_mbus_int_write(struct mii_bus *mbus, int port, int reg, u16 data)\n \n int yt921x_mbus_int_init(struct yt921x_priv *priv, struct device_node *mnp)\n {\n-\tstruct device *dev = to_device(priv);\n+\tstruct device *dev = yt921x_priv_to_device(priv);\n \tstruct mii_bus *mbus;\n \tint res;\n \n@@ -181,7 +179,7 @@ static int yt921x_extif_wait(struct yt921x_priv *priv)\n static int\n yt921x_extif_read(struct yt921x_priv *priv, int port, int reg, u16 *valp)\n {\n-\tstruct device *dev = to_device(priv);\n+\tstruct device *dev = yt921x_priv_to_device(priv);\n \tu32 mask;\n \tu32 ctrl;\n \tu32 val;\n@@ -275,7 +273,7 @@ yt921x_mbus_ext_write(struct mii_bus *mbus, int port, int reg, u16 data)\n \n int yt921x_mbus_ext_init(struct yt921x_priv *priv, struct device_node *mnp)\n {\n-\tstruct device *dev = to_device(priv);\n+\tstruct device *dev = yt921x_priv_to_device(priv);\n \tstruct mii_bus *mbus;\n \tint res;\n \ndiff --git a/drivers/net/dsa/motorcomm/pcs-921x.c b/drivers/net/dsa/motorcomm/pcs-921x.c\nindex 47467d803e136..e942b61d8eb2f 100644\n--- a/drivers/net/dsa/motorcomm/pcs-921x.c\n+++ b/drivers/net/dsa/motorcomm/pcs-921x.c\n@@ -8,8 +8,6 @@\n #include \"pcs.h\"\n #include \"smi.h\"\n \n-#define to_device(priv) ((priv)-\u003eds.dev)\n-\n static int\n yt921x_serdes_config(struct yt921x_priv *priv, int port, unsigned int neg_mode,\n \t\t phy_interface_t interface,\n@@ -116,7 +114,7 @@ yt921x_phylink_pcs_get_state(struct phylink_pcs *pcs, unsigned int neg_mode,\n {\n \tstruct yt921x_port *pp = pcs_to_yt921x_port(pcs);\n \tstruct yt921x_priv *priv = yt921x_port_to_priv(pp);\n-\tstruct device *dev = to_device(priv);\n+\tstruct device *dev = yt921x_priv_to_device(priv);\n \tint port = pp-\u003eindex;\n \tu16 bmsr;\n \tu16 lpa;\n@@ -155,7 +153,7 @@ static void yt921x_phylink_pcs_an_restart(struct phylink_pcs *pcs)\n {\n \tstruct yt921x_port *pp = pcs_to_yt921x_port(pcs);\n \tstruct yt921x_priv *priv = yt921x_port_to_priv(pp);\n-\tstruct device *dev = to_device(priv);\n+\tstruct device *dev = yt921x_priv_to_device(priv);\n \tint port = pp-\u003eindex;\n \tu16 val;\n \tint res;\n@@ -181,7 +179,7 @@ static void yt921x_phylink_pcs_disable(struct phylink_pcs *pcs)\n {\n \tstruct yt921x_port *pp = pcs_to_yt921x_port(pcs);\n \tstruct yt921x_priv *priv = yt921x_port_to_priv(pp);\n-\tstruct device *dev = to_device(priv);\n+\tstruct device *dev = yt921x_priv_to_device(priv);\n \tint port = pp-\u003eindex;\n \tint res;\n \ndiff --git a/drivers/net/dsa/motorcomm/tc.c b/drivers/net/dsa/motorcomm/tc.c\nnew file mode 100644\nindex 0000000000000..c5581e85208f3\n--- /dev/null\n+++ b/drivers/net/dsa/motorcomm/tc.c\n@@ -0,0 +1,1524 @@\n+// SPDX-License-Identifier: GPL-2.0-or-later\n+/*\n+ * Copyright (c) 2026 David Yang\n+ */\n+\n+#include \"chip.h\"\n+#include \"smi.h\"\n+#include \"tc.h\"\n+\n+static int yt921x_mtu_fetch(struct yt921x_priv *priv, int port)\n+{\n+\tstruct dsa_port *dp = dsa_to_port(\u0026priv-\u003eds, port);\n+\n+\treturn dp-\u003euser ? READ_ONCE(dp-\u003euser-\u003emtu) : ETH_DATA_LEN;\n+}\n+\n+/* v * 2^e */\n+static u64 ldexpu64(u64 v, int e)\n+{\n+\treturn e \u003e= 0 ? v \u003c\u003c e : v \u003e\u003e -e;\n+}\n+\n+/* slot (ns) * rate (/s) / 10^9 (ns/s) = 2^C * token * 4^unit */\n+static u32 rate2token(u64 rate, unsigned int slot_ns, int unit, int C)\n+{\n+\tint e = 2 * unit + C + YT921X_TOKEN_RATE_C;\n+\n+\treturn div_u64(ldexpu64(slot_ns * rate, -e), NSEC_PER_SEC);\n+}\n+\n+static u64 token2rate(u32 token, unsigned int slot_ns, int unit, int C)\n+{\n+\tint e = 2 * unit + C + YT921X_TOKEN_RATE_C;\n+\n+\treturn div_u64(ldexpu64(mul_u32_u32(NSEC_PER_SEC, token), e), slot_ns);\n+}\n+\n+/* burst = 2^C * token * 4^unit */\n+static u32 burst2token(u64 burst, int unit, int C)\n+{\n+\treturn ldexpu64(burst, -(2 * unit + C));\n+}\n+\n+static u64 token2burst(u32 token, int unit, int C)\n+{\n+\treturn ldexpu64(token, 2 * unit + C);\n+}\n+\n+struct yt921x_marker {\n+\tu32 cir;\n+\tu32 cbs;\n+\tu32 ebs;\n+\tint unit;\n+\tbool pkt_mode;\n+};\n+\n+#define YT921X_MARKER_PKT_MODE\t\tBIT(0)\n+#define YT921X_MARKER_SINGLE_BUCKET\tBIT(1)\n+\n+static int\n+yt921x_marker_tfm(struct yt921x_marker *marker, u64 rate, u64 burst,\n+\t\t unsigned int flags, unsigned int slot_ns, u32 cir_max,\n+\t\t u32 cbs_max, int unit_max, struct yt921x_priv *priv, int port,\n+\t\t struct netlink_ext_ack *extack)\n+{\n+\tconst int C = flags \u0026 YT921X_MARKER_PKT_MODE ? YT921X_TOKEN_PKT_C :\n+\t\t YT921X_TOKEN_BYTE_C;\n+\tstruct device *dev = yt921x_priv_to_device(priv);\n+\tstruct yt921x_marker m;\n+\tu64 burst_est;\n+\tu64 burst_sug;\n+\tu64 burst_max;\n+\tu64 rate_max;\n+\n+\tm.unit = unit_max;\n+\trate_max = token2rate(cir_max, slot_ns, m.unit, C);\n+\tburst_max = token2burst(cbs_max, m.unit, C);\n+\n+\t/* Check for unusual values */\n+\tif (rate \u003e rate_max || burst \u003e burst_max) {\n+\t\tNL_SET_ERR_MSG_MOD(extack, \"Unexpected tremendous rate\");\n+\t\treturn -ERANGE;\n+\t}\n+\n+\t/* Check for matching burst */\n+\tburst_est = div_u64(slot_ns * rate, NSEC_PER_SEC);\n+\tburst_sug = burst_est;\n+\tif (flags \u0026 YT921X_MARKER_PKT_MODE)\n+\t\tburst_sug++;\n+\telse\n+\t\tburst_sug += ETH_HLEN + yt921x_mtu_fetch(priv, port) +\n+\t\t\t ETH_FCS_LEN;\n+\tif (burst_sug \u003e burst)\n+\t\tNL_SET_ERR_MSG_FMT_MOD(extack,\n+\t\t\t\t \"Consider match rate %llu with burst at least %llu\",\n+\t\t\t\t rate, burst_sug);\n+\n+\t/* Select unit */\n+\tfor (; m.unit \u003e 0; m.unit--) {\n+\t\tif (rate \u003e (rate_max \u003e\u003e 2) || burst \u003e (burst_max \u003e\u003e 2))\n+\t\t\tbreak;\n+\t\trate_max \u003e\u003e= 2;\n+\t\tburst_max \u003e\u003e= 2;\n+\t}\n+\n+\t/* Calculate information rate and bucket size */\n+\tm.cir = rate2token(rate, slot_ns, m.unit, C);\n+\tif (!m.cir)\n+\t\tm.cir = 1;\n+\telse if (WARN_ON(m.cir \u003e cir_max))\n+\t\tm.cir = cir_max;\n+\tm.cbs = burst2token(burst, m.unit, C);\n+\tif (!m.cbs)\n+\t\tm.cbs = 1;\n+\telse if (WARN_ON(m.cbs \u003e cbs_max))\n+\t\tm.cbs = cbs_max;\n+\n+\t/* Cut EBS */\n+\tm.ebs = 0;\n+\tif (!(flags \u0026 YT921X_MARKER_SINGLE_BUCKET)) {\n+\t\t/* We don't have a chance to adjust rate when MTU is changed */\n+\t\tif (flags \u0026 YT921X_MARKER_PKT_MODE)\n+\t\t\tburst_est++;\n+\t\telse\n+\t\t\tburst_est += YT921X_FRAME_SIZE_MAX;\n+\n+\t\tif (burst_est \u003c burst) {\n+\t\t\tu32 pbs = m.cbs;\n+\n+\t\t\tm.cbs = burst2token(burst_est, m.unit, C);\n+\t\t\tif (!m.cbs)\n+\t\t\t\tm.cbs = 1;\n+\t\t\telse if (WARN_ON(m.cbs \u003e cbs_max))\n+\t\t\t\tm.cbs = cbs_max;\n+\n+\t\t\tif (pbs \u003e m.cbs)\n+\t\t\t\tm.ebs = pbs - m.cbs;\n+\t\t}\n+\t}\n+\n+\tdev_dbg(dev,\n+\t\t\"slot %u ns, rate %llu, burst %llu -\u003e unit %d, cir %u, cbs %u, ebs %u\\n\",\n+\t\tslot_ns, rate, burst, m.unit, m.cir, m.cbs, m.ebs);\n+\n+\tm.pkt_mode = flags \u0026 YT921X_MARKER_PKT_MODE;\n+\t*marker = m;\n+\treturn 0;\n+}\n+\n+static int\n+yt921x_marker_tfm_police(struct yt921x_marker *marker,\n+\t\t\t const struct flow_action_police *police,\n+\t\t\t unsigned int flags, struct yt921x_priv *priv, int port,\n+\t\t\t struct netlink_ext_ack *extack)\n+{\n+\tbool pkt_mode = !!police-\u003erate_pkt_ps;\n+\tu64 burst;\n+\tu64 rate;\n+\n+\trate = pkt_mode ? police-\u003erate_pkt_ps : police-\u003erate_bytes_ps;\n+\tburst = pkt_mode ? police-\u003eburst_pkt : police-\u003eburst;\n+\tif (pkt_mode)\n+\t\tflags |= YT921X_MARKER_PKT_MODE;\n+\n+\treturn yt921x_marker_tfm(marker, rate, burst, flags,\n+\t\t\t\t priv-\u003emeter_slot_ns, YT921X_METER_CIR_MAX,\n+\t\t\t\t YT921X_METER_CBS_MAX, YT921X_METER_UNIT_MAX,\n+\t\t\t\t priv, port, extack);\n+}\n+\n+static int\n+yt921x_marker_tfm_shape(struct yt921x_marker *marker, u64 rate, u64 burst,\n+\t\t\tunsigned int flags, struct yt921x_priv *priv, int port,\n+\t\t\tstruct netlink_ext_ack *extack)\n+{\n+\treturn yt921x_marker_tfm(marker, rate, burst, flags,\n+\t\t\t\t priv-\u003eport_shape_slot_ns, YT921X_SHAPE_CIR_MAX,\n+\t\t\t\t YT921X_SHAPE_CBS_MAX, YT921X_SHAPE_UNIT_MAX,\n+\t\t\t\t priv, port, extack);\n+}\n+\n+static int\n+yt921x_police_validate(const struct flow_action_police *police,\n+\t\t const struct flow_action *action,\n+\t\t const struct flow_action_entry *act,\n+\t\t struct netlink_ext_ack *extack)\n+{\n+\tif (police-\u003eexceed.act_id != FLOW_ACTION_DROP) {\n+\t\tNL_SET_ERR_MSG_MOD(extack,\n+\t\t\t\t \"Offload not supported when exceed action is not drop\");\n+\t\treturn -EOPNOTSUPP;\n+\t}\n+\n+\tif (police-\u003enotexceed.act_id != FLOW_ACTION_PIPE \u0026\u0026\n+\t police-\u003enotexceed.act_id != FLOW_ACTION_ACCEPT) {\n+\t\tNL_SET_ERR_MSG_MOD(extack,\n+\t\t\t\t \"Offload not supported when conform action is not pipe or ok\");\n+\t\treturn -EOPNOTSUPP;\n+\t}\n+\n+\tif (police-\u003enotexceed.act_id == FLOW_ACTION_ACCEPT \u0026\u0026 action \u0026\u0026 act \u0026\u0026\n+\t !flow_action_is_last_entry(action, act)) {\n+\t\tNL_SET_ERR_MSG_MOD(extack,\n+\t\t\t\t \"Offload not supported when conform action is ok, but action is not last\");\n+\t\treturn -EOPNOTSUPP;\n+\t}\n+\n+\t/* mtu defaults to unlimited but we got 2040 here, don't know why */\n+\tif (police-\u003epeakrate_bytes_ps || police-\u003eavrate || police-\u003eoverhead) {\n+\t\tNL_SET_ERR_MSG_MOD(extack,\n+\t\t\t\t \"Offload not supported when peakrate/avrate/overhead is configured\");\n+\t\treturn -EOPNOTSUPP;\n+\t}\n+\n+\treturn 0;\n+}\n+\n+static int\n+yt921x_meter_config(struct yt921x_priv *priv, unsigned int id,\n+\t\t const struct yt921x_marker *marker)\n+{\n+\tu32 ctrls[3];\n+\n+\tctrls[0] = 0;\n+\tctrls[1] = YT921X_METER_CTRLb_CIR(marker-\u003ecir);\n+\tctrls[2] = YT921X_METER_CTRLc_UNIT(marker-\u003eunit) |\n+\t\t YT921X_METER_CTRLc_DROP_R |\n+\t\t YT921X_METER_CTRLc_TOKEN_OVERFLOW_EN |\n+\t\t YT921X_METER_CTRLc_METER_EN;\n+\tif (marker-\u003epkt_mode)\n+\t\tctrls[2] |= YT921X_METER_CTRLc_PKT_MODE;\n+\tupdate_ctrls_unaligned(\u0026ctrls[0], \u0026ctrls[1],\n+\t\t\t YT921X_METER_CTRLab_EBS_M,\n+\t\t\t YT921X_METER_CTRLab_EBS(marker-\u003eebs));\n+\tupdate_ctrls_unaligned(\u0026ctrls[1], \u0026ctrls[2],\n+\t\t\t YT921X_METER_CTRLbc_CBS_M,\n+\t\t\t YT921X_METER_CTRLbc_CBS(marker-\u003ecbs));\n+\n+\treturn yt921x_reg96_write(priv, YT921X_METERn_CTRL(id), ctrls);\n+}\n+\n+void yt921x_dsa_port_policer_del(struct dsa_switch *ds, int port)\n+{\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(ds);\n+\tstruct device *dev = yt921x_priv_to_device(priv);\n+\tint res;\n+\n+\tmutex_lock(\u0026priv-\u003ereg_lock);\n+\tres = yt921x_reg_write(priv, YT921X_PORTn_METER(port), 0);\n+\tmutex_unlock(\u0026priv-\u003ereg_lock);\n+\n+\tif (res)\n+\t\tdev_err(dev, \"Failed to %s port %d: %i\\n\", \"delete policer on\",\n+\t\t\tport, res);\n+}\n+\n+int\n+yt921x_dsa_port_policer_add(struct dsa_switch *ds, int port,\n+\t\t\t const struct flow_action_police *police,\n+\t\t\t struct netlink_ext_ack *extack)\n+{\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(ds);\n+\tstruct yt921x_marker marker;\n+\tu32 ctrl;\n+\tint res;\n+\n+\tres = yt921x_police_validate(police, NULL, NULL, extack);\n+\tif (res)\n+\t\treturn res;\n+\n+\tres = yt921x_marker_tfm_police(\u0026marker, police, 0, priv, port, extack);\n+\tif (res)\n+\t\treturn res;\n+\n+\tmutex_lock(\u0026priv-\u003ereg_lock);\n+\tres = yt921x_meter_config(priv, port + YT921X_METER_NUM, \u0026marker);\n+\tif (res)\n+\t\tgoto end;\n+\n+\tctrl = YT921X_PORT_METER_ID(port) | YT921X_PORT_METER_EN;\n+\tres = yt921x_reg_write(priv, YT921X_PORTn_METER(port), ctrl);\n+end:\n+\tmutex_unlock(\u0026priv-\u003ereg_lock);\n+\n+\treturn res;\n+}\n+\n+static int\n+yt921x_dsa_port_setup_tc_tbf_port(struct dsa_switch *ds, int port,\n+\t\t\t\t const struct tc_tbf_qopt_offload *qopt)\n+{\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(ds);\n+\tstruct netlink_ext_ack *extack = qopt-\u003eextack;\n+\tu32 ctrls[2];\n+\tint res;\n+\n+\tif (qopt-\u003eparent != TC_H_ROOT)\n+\t\treturn -EOPNOTSUPP;\n+\n+\tswitch (qopt-\u003ecommand) {\n+\tcase TC_TBF_STATS:\n+\t\t/* Unfortunately the convention for TC_*_STATS is a mess,\n+\t\t * neither 0 nor -EOPNOTSUPP is perfect here.\n+\t\t */\n+\t\treturn -EOPNOTSUPP;\n+\tcase TC_TBF_DESTROY:\n+\t\tctrls[0] = 0;\n+\t\tctrls[1] = 0;\n+\t\tbreak;\n+\tcase TC_TBF_REPLACE: {\n+\t\tconst struct tc_tbf_qopt_offload_replace_params *p;\n+\t\tstruct yt921x_marker marker;\n+\n+\t\tp = \u0026qopt-\u003ereplace_params;\n+\n+\t\tres = yt921x_marker_tfm_shape(\u0026marker, p-\u003erate.rate_bytes_ps,\n+\t\t\t\t\t p-\u003emax_size,\n+\t\t\t\t\t YT921X_MARKER_SINGLE_BUCKET,\n+\t\t\t\t\t priv, port, extack);\n+\t\tif (res)\n+\t\t\treturn res;\n+\n+\t\tctrls[0] = YT921X_PORT_SHAPE_CTRLa_CIR(marker.cir) |\n+\t\t\t YT921X_PORT_SHAPE_CTRLa_CBS(marker.cbs);\n+\t\tctrls[1] = YT921X_PORT_SHAPE_CTRLb_UNIT(marker.unit) |\n+\t\t\t YT921X_PORT_SHAPE_CTRLb_EN;\n+\t\tbreak;\n+\t}\n+\tdefault:\n+\t\treturn -EOPNOTSUPP;\n+\t}\n+\n+\tmutex_lock(\u0026priv-\u003ereg_lock);\n+\tres = yt921x_reg64_write(priv, YT921X_PORTn_SHAPE_CTRL(port), ctrls);\n+\tmutex_unlock(\u0026priv-\u003ereg_lock);\n+\n+\treturn res;\n+}\n+\n+int\n+yt921x_dsa_port_setup_tc(struct dsa_switch *ds, int port,\n+\t\t\t enum tc_setup_type type, void *type_data)\n+{\n+\tswitch (type) {\n+\tcase TC_SETUP_QDISC_TBF: {\n+\t\tconst struct tc_tbf_qopt_offload *qopt = type_data;\n+\n+\t\treturn yt921x_dsa_port_setup_tc_tbf_port(ds, port, qopt);\n+\t}\n+\tdefault:\n+\t\treturn -EOPNOTSUPP;\n+\t}\n+}\n+\n+/* ACL: 48 blocks * 8 entries\n+ *\n+ * One rule can span multiple entries, but within a block.\n+ */\n+\n+static void\n+yt921x_acl_entry_set(struct yt921x_acl_entry *entry, unsigned int offset,\n+\t\t u32 flags, bool set)\n+{\n+\tif (set)\n+\t\tentry-\u003ekey[offset] |= flags;\n+\tentry-\u003emask[offset] |= flags;\n+}\n+\n+static unsigned int\n+yt921x_acl_entries_set_is_fragment(struct yt921x_acl_entry *entries,\n+\t\t\t\t unsigned int size, bool set)\n+{\n+\tfor (unsigned int i = 0; i \u003c size; i++)\n+\t\tswitch (FIELD_GET(YT921X_ACL_KEYb_TYPE_M, entries[i].key[1])) {\n+\t\tcase YT921X_ACL_TYPE_IPV4_DA:\n+\t\tcase YT921X_ACL_TYPE_IPV4_SA:\n+\t\t\tyt921x_acl_entry_set(\u0026entries[i], 1,\n+\t\t\t\t\t YT921X_ACL_BINb_IPV4_FRAG, set);\n+\t\t\treturn size;\n+\t\tcase YT921X_ACL_TYPE_IPV6_DA3:\n+\t\tcase YT921X_ACL_TYPE_IPV6_SA3:\n+\t\t\tyt921x_acl_entry_set(\u0026entries[i], 1,\n+\t\t\t\t\t YT921X_ACL_BINb_IPV6_xA3_FRAG,\n+\t\t\t\t\t set);\n+\t\t\treturn size;\n+\t\tcase YT921X_ACL_TYPE_MISC:\n+\t\t\tyt921x_acl_entry_set(\u0026entries[i], 1,\n+\t\t\t\t\t YT921X_ACL_BINb_MISC_FRAG, set);\n+\t\t\treturn size;\n+\t\tcase YT921X_ACL_TYPE_L4:\n+\t\t\tyt921x_acl_entry_set(\u0026entries[i], 1,\n+\t\t\t\t\t YT921X_ACL_BINb_L4_FRAG, set);\n+\t\t\treturn size;\n+\t\t}\n+\n+\tif (size \u003e= YT921X_ACL_ENT_PER_BLK)\n+\t\treturn 0;\n+\n+\tentries[size] = (typeof(*entries)){};\n+\tentries[size].key[1] = YT921X_ACL_KEYb_TYPE(YT921X_ACL_TYPE_MISC);\n+\tyt921x_acl_entry_set(\u0026entries[size], 1, YT921X_ACL_BINb_MISC_FRAG, set);\n+\n+\treturn size + 1;\n+}\n+\n+static unsigned int\n+yt921x_acl_entries_set_first_frag(struct yt921x_acl_entry *entries,\n+\t\t\t\t unsigned int size, bool set)\n+{\n+\tfor (unsigned int i = 0; i \u003c size; i++)\n+\t\tswitch (FIELD_GET(YT921X_ACL_KEYb_TYPE_M, entries[i].key[1])) {\n+\t\tcase YT921X_ACL_TYPE_IPV6_DA2:\n+\t\tcase YT921X_ACL_TYPE_IPV6_SA2:\n+\t\t\tyt921x_acl_entry_set(\u0026entries[i], 1,\n+\t\t\t\t\t YT921X_ACL_BINb_IPV6_xA2_FIRST_FRAG,\n+\t\t\t\t\t set);\n+\t\t\treturn size;\n+\t\tcase YT921X_ACL_TYPE_MISC:\n+\t\t\tyt921x_acl_entry_set(\u0026entries[i], 0,\n+\t\t\t\t\t YT921X_ACL_BINa_MISC_FIRST_FRAG,\n+\t\t\t\t\t set);\n+\t\t\treturn size;\n+\t\t}\n+\n+\tif (size \u003e= YT921X_ACL_ENT_PER_BLK)\n+\t\treturn 0;\n+\n+\tentries[size] = (typeof(*entries)){};\n+\tentries[size].key[1] = YT921X_ACL_KEYb_TYPE(YT921X_ACL_TYPE_MISC);\n+\tyt921x_acl_entry_set(\u0026entries[size], 0,\n+\t\t\t YT921X_ACL_BINa_MISC_FIRST_FRAG, set);\n+\n+\treturn size + 1;\n+}\n+\n+static unsigned int\n+yt921x_acl_entries_set_l3_type(struct yt921x_acl_entry *entries,\n+\t\t\t unsigned int size, enum yt921x_l3_type type)\n+{\n+\tfor (unsigned int i = 0; i \u003c size; i++)\n+\t\tswitch (FIELD_GET(YT921X_ACL_KEYb_TYPE_M, entries[i].key[1])) {\n+\t\tcase YT921X_ACL_TYPE_MAC_DA0:\n+\t\tcase YT921X_ACL_TYPE_MAC_SA0:\n+\t\t\tentries[i].key[1] |= YT921X_ACL_BINb_MAC_xA0_L3_TYPE(type);\n+\t\t\tentries[i].mask[1] |= YT921X_ACL_BINb_MAC_xA0_L3_TYPE_M;\n+\t\t\treturn size;\n+\t\tcase YT921X_ACL_TYPE_MISC:\n+\t\t\tentries[i].key[0] |= YT921X_ACL_BINa_MISC_L3_TYPE(type);\n+\t\t\tentries[i].mask[0] |= YT921X_ACL_BINa_MISC_L3_TYPE_M;\n+\t\t\treturn size;\n+\t\t}\n+\n+\tif (size \u003e= YT921X_ACL_ENT_PER_BLK)\n+\t\treturn 0;\n+\n+\tentries[size] = (typeof(*entries)){};\n+\tentries[size].key[0] = YT921X_ACL_BINa_MISC_L3_TYPE(type);\n+\tentries[size].key[1] = YT921X_ACL_KEYb_TYPE(YT921X_ACL_TYPE_MISC);\n+\tentries[size].mask[0] = YT921X_ACL_BINa_MISC_L3_TYPE_M;\n+\n+\treturn size + 1;\n+}\n+\n+static unsigned int\n+yt921x_acl_entries_set_l4_type(struct yt921x_acl_entry *entries,\n+\t\t\t unsigned int size, enum yt921x_l4_type type)\n+{\n+\tfor (unsigned int i = 0; i \u003c size; i++)\n+\t\tswitch (FIELD_GET(YT921X_ACL_KEYb_TYPE_M, entries[i].key[1])) {\n+\t\tcase YT921X_ACL_TYPE_IPV4_DA:\n+\t\tcase YT921X_ACL_TYPE_IPV4_SA:\n+\t\t\tentries[i].key[1] |= YT921X_ACL_BINb_IPV4_L4_TYPE(type);\n+\t\t\tentries[i].mask[1] |= YT921X_ACL_BINb_IPV4_L4_TYPE_M;\n+\t\t\treturn size;\n+\t\tcase YT921X_ACL_TYPE_IPV6_DA0:\n+\t\tcase YT921X_ACL_TYPE_IPV6_DA1:\n+\t\tcase YT921X_ACL_TYPE_IPV6_DA2:\n+\t\tcase YT921X_ACL_TYPE_IPV6_DA3:\n+\t\tcase YT921X_ACL_TYPE_IPV6_SA0:\n+\t\tcase YT921X_ACL_TYPE_IPV6_SA1:\n+\t\tcase YT921X_ACL_TYPE_IPV6_SA2:\n+\t\tcase YT921X_ACL_TYPE_IPV6_SA3:\n+\t\t\tentries[i].key[1] |= YT921X_ACL_BINb_IPV6_L4_TYPE(type);\n+\t\t\tentries[i].mask[1] |= YT921X_ACL_BINb_IPV6_L4_TYPE_M;\n+\t\t\treturn size;\n+\t\tcase YT921X_ACL_TYPE_L4:\n+\t\t\tentries[i].key[1] |= YT921X_ACL_BINb_L4_TYPE(type);\n+\t\t\tentries[i].mask[1] |= YT921X_ACL_BINb_L4_TYPE_M;\n+\t\t\treturn size;\n+\t\tcase YT921X_ACL_TYPE_MISC:\n+\t\t\tentries[i].key[1] |= YT921X_ACL_BINb_MISC_L4_TYPE(type);\n+\t\t\tentries[i].mask[1] |= YT921X_ACL_BINb_MISC_L4_TYPE_M;\n+\t\t\treturn size;\n+\t\t}\n+\n+\tif (size \u003e= YT921X_ACL_ENT_PER_BLK)\n+\t\treturn 0;\n+\n+\tentries[size] = (typeof(*entries)){};\n+\tentries[size].key[1] = YT921X_ACL_BINb_MISC_L4_TYPE(type) |\n+\t\t\t YT921X_ACL_KEYb_TYPE(YT921X_ACL_TYPE_MISC);\n+\tentries[size].mask[1] = YT921X_ACL_BINb_MISC_L4_TYPE_M;\n+\n+\treturn size + 1;\n+}\n+\n+static struct yt921x_acl_entry *\n+yt921x_acl_entries_new(struct yt921x_acl_entry *entries, unsigned int *sizep,\n+\t\t u32 type)\n+{\n+\tunsigned int size = *sizep;\n+\n+\tif (size \u003e= YT921X_ACL_ENT_PER_BLK)\n+\t\treturn NULL;\n+\n+\tentries[size] = (typeof(*entries)){};\n+\tentries[size].key[1] = YT921X_ACL_KEYb_TYPE(type);\n+\n+\t(*sizep)++;\n+\treturn \u0026entries[size];\n+}\n+\n+static struct yt921x_acl_entry *\n+yt921x_acl_entries_find(struct yt921x_acl_entry *entries, unsigned int *sizep,\n+\t\t\tu32 type)\n+{\n+\tfor (unsigned int i = 0; i \u003c *sizep; i++)\n+\t\tif (FIELD_GET(YT921X_ACL_KEYb_TYPE_M, entries[i].key[1]) ==\n+\t\t type)\n+\t\t\treturn \u0026entries[i];\n+\treturn yt921x_acl_entries_new(entries, sizep, type);\n+}\n+\n+static void\n+yt921x_acl_rule_set_ports(struct yt921x_acl_rule *aclrule, u16 ord,\n+\t\t\t u16 ports_mask)\n+{\n+\tstruct yt921x_acl_entry *entries = aclrule-\u003eentries;\n+\n+\tfor (unsigned int i = 0; i \u003c hweight8(aclrule-\u003emask); i++) {\n+\t\tentries[i].key[1] |= YT921X_ACL_KEYb_SPORTS(ports_mask) |\n+\t\t\t\t YT921X_ACL_KEYb_ORD(ord);\n+\t}\n+}\n+\n+struct yt921x_acl_rule_ext {\n+\tstruct yt921x_acl_rule r;\n+\n+\tstruct yt921x_marker marker;\n+};\n+\n+static int\n+yt921x_acl_rule_ext_parse_flow_entries(struct yt921x_acl_rule_ext *ruleext,\n+\t\t\t\t const struct flow_cls_offload *cls)\n+{\n+\tconst struct flow_rule *rule = flow_cls_offload_flow_rule(cls);\n+\tstruct yt921x_acl_entry *entries = ruleext-\u003er.entries;\n+\tstruct netlink_ext_ack *extack = cls-\u003ecommon.extack;\n+\tconst struct flow_dissector *dissector;\n+\tstruct yt921x_acl_entry *entry;\n+\tunsigned int size = 0;\n+\tbool use_dport;\n+\tbool use_sport;\n+\n+\t/* Incomplete and probably won't, since it supports custom u32 filters.\n+\t * New adapters are welcome.\n+\t */\n+\tdissector = rule-\u003ematch.dissector;\n+\tif (dissector-\u003eused_keys \u0026\n+\t ~(BIT_ULL(FLOW_DISSECTOR_KEY_CONTROL) |\n+\t BIT_ULL(FLOW_DISSECTOR_KEY_BASIC) |\n+\t BIT_ULL(FLOW_DISSECTOR_KEY_IPV4_ADDRS) |\n+\t BIT_ULL(FLOW_DISSECTOR_KEY_IPV6_ADDRS) |\n+\t BIT_ULL(FLOW_DISSECTOR_KEY_PORTS) |\n+\t BIT_ULL(FLOW_DISSECTOR_KEY_PORTS_RANGE) |\n+\t BIT_ULL(FLOW_DISSECTOR_KEY_ETH_ADDRS) |\n+\t BIT_ULL(FLOW_DISSECTOR_KEY_IP) |\n+\t BIT_ULL(FLOW_DISSECTOR_KEY_TCP))) {\n+\t\tNL_SET_ERR_MSG_MOD(extack, \"Unsupported keys used\");\n+\t\treturn -EOPNOTSUPP;\n+\t}\n+\n+\t/* Entries */\n+\tif (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_IPV4_ADDRS)) {\n+\t\tstruct flow_match_ipv4_addrs match;\n+\n+\t\tflow_rule_match_ipv4_addrs(rule, \u0026match);\n+\n+\t\tif (match.mask-\u003edst) {\n+\t\t\tentry = yt921x_acl_entries_new(entries, \u0026size,\n+\t\t\t\t\t\t YT921X_ACL_TYPE_IPV4_DA);\n+\t\t\tif (!entry)\n+\t\t\t\tgoto err;\n+\n+\t\t\tentry-\u003ekey[0] |= ntohl(match.key-\u003edst);\n+\t\t\tentry-\u003emask[0] |= ntohl(match.mask-\u003edst);\n+\t\t}\n+\n+\t\tif (match.mask-\u003esrc) {\n+\t\t\tentry = yt921x_acl_entries_new(entries, \u0026size,\n+\t\t\t\t\t\t YT921X_ACL_TYPE_IPV4_SA);\n+\t\t\tif (!entry)\n+\t\t\t\tgoto err;\n+\n+\t\t\tentry-\u003ekey[0] |= ntohl(match.key-\u003esrc);\n+\t\t\tentry-\u003emask[0] |= ntohl(match.mask-\u003esrc);\n+\t\t}\n+\t}\n+\n+\tif (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_IPV6_ADDRS)) {\n+\t\tstruct flow_match_ipv6_addrs match;\n+\n+\t\tflow_rule_match_ipv6_addrs(rule, \u0026match);\n+\n+\t\tfor (unsigned int i = 0; i \u003c 4; i++) {\n+\t\t\tif (!match.mask-\u003edst.s6_addr32[i])\n+\t\t\t\tcontinue;\n+\n+\t\t\tentry = yt921x_acl_entries_new(entries, \u0026size,\n+\t\t\t\t\t\t YT921X_ACL_TYPE_IPV6_DA0 + i);\n+\t\t\tif (!entry)\n+\t\t\t\tgoto err;\n+\n+\t\t\tentry-\u003ekey[0] |= ntohl(match.key-\u003edst.s6_addr32[i]);\n+\t\t\tentry-\u003emask[0] |= ntohl(match.mask-\u003edst.s6_addr32[i]);\n+\t\t}\n+\n+\t\tfor (unsigned int i = 0; i \u003c 4; i++) {\n+\t\t\tif (!match.mask-\u003esrc.s6_addr32[i])\n+\t\t\t\tcontinue;\n+\n+\t\t\tentry = yt921x_acl_entries_new(entries, \u0026size,\n+\t\t\t\t\t\t YT921X_ACL_TYPE_IPV6_SA0 + i);\n+\t\t\tif (!entry)\n+\t\t\t\tgoto err;\n+\n+\t\t\tentry-\u003ekey[0] |= ntohl(match.key-\u003esrc.s6_addr32[i]);\n+\t\t\tentry-\u003emask[0] |= ntohl(match.mask-\u003esrc.s6_addr32[i]);\n+\t\t}\n+\t}\n+\n+\tuse_dport = false;\n+\tuse_sport = false;\n+\tif (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_PORTS)) {\n+\t\tstruct flow_match_ports match;\n+\n+\t\tentry = yt921x_acl_entries_new(entries, \u0026size,\n+\t\t\t\t\t YT921X_ACL_TYPE_L4);\n+\t\tif (!entry)\n+\t\t\tgoto err;\n+\n+\t\tflow_rule_match_ports(rule, \u0026match);\n+\n+\t\tuse_dport = !!match.mask-\u003edst;\n+\t\tuse_sport = !!match.mask-\u003esrc;\n+\n+\t\tentry-\u003ekey[0] |= (ntohs(match.key-\u003edst) \u003c\u003c 16) |\n+\t\t\t\t ntohs(match.key-\u003esrc);\n+\t\tentry-\u003emask[0] |= (ntohs(match.mask-\u003edst) \u003c\u003c 16) |\n+\t\t\t\t ntohs(match.mask-\u003esrc);\n+\t}\n+\n+\tif (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_PORTS_RANGE)) {\n+\t\tstruct flow_match_ports_range match;\n+\n+\t\tentry = yt921x_acl_entries_find(entries, \u0026size,\n+\t\t\t\t\t\tYT921X_ACL_TYPE_L4);\n+\t\tif (!entry)\n+\t\t\tgoto err;\n+\n+\t\tflow_rule_match_ports_range(rule, \u0026match);\n+\n+\t\tif ((use_dport \u0026\u0026 match.mask-\u003etp.dst) ||\n+\t\t (use_sport \u0026\u0026 match.mask-\u003etp.src)) {\n+\t\t\tNL_SET_ERR_MSG_MOD(extack,\n+\t\t\t\t\t \"Port mask and range are mutually exclusive\");\n+\t\t\treturn -EINVAL;\n+\t\t}\n+\n+\t\tif (match.mask-\u003etp.dst) {\n+\t\t\tentry-\u003ekey[0] |= ntohs(match.key-\u003etp_min.dst) \u003c\u003c 16;\n+\t\t\tentry-\u003ekey[1] |= YT921X_ACL_KEYb_L4_DPORT_RANGE_EN;\n+\t\t\tentry-\u003emask[0] |= ntohs(match.key-\u003etp_max.dst) \u003c\u003c 16;\n+\t\t}\n+\n+\t\tif (match.mask-\u003etp.src) {\n+\t\t\tentry-\u003ekey[0] |= ntohs(match.key-\u003etp_min.src);\n+\t\t\tentry-\u003ekey[1] |= YT921X_ACL_KEYb_L4_SPORT_RANGE_EN;\n+\t\t\tentry-\u003emask[0] |= ntohs(match.key-\u003etp_max.src);\n+\t\t}\n+\t}\n+\n+\tif (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_ETH_ADDRS)) {\n+\t\tstruct flow_match_eth_addrs match;\n+\t\tu32 mask;\n+\n+\t\tflow_rule_match_eth_addrs(rule, \u0026match);\n+\n+\t\tmask = ethaddr_hi4_to_u32(match.mask-\u003edst);\n+\t\tif (mask) {\n+\t\t\tentry = yt921x_acl_entries_new(entries, \u0026size,\n+\t\t\t\t\t\t YT921X_ACL_TYPE_MAC_DA0);\n+\t\t\tif (!entry)\n+\t\t\t\tgoto err;\n+\n+\t\t\tentry-\u003ekey[0] |= ethaddr_hi4_to_u32(match.key-\u003edst);\n+\t\t\tentry-\u003emask[0] |= mask;\n+\t\t}\n+\n+\t\tmask = ethaddr_hi4_to_u32(match.mask-\u003esrc);\n+\t\tif (mask) {\n+\t\t\tentry = yt921x_acl_entries_new(entries, \u0026size,\n+\t\t\t\t\t\t YT921X_ACL_TYPE_MAC_SA0);\n+\t\t\tif (!entry)\n+\t\t\t\tgoto err;\n+\n+\t\t\tentry-\u003ekey[0] |= ethaddr_hi4_to_u32(match.key-\u003esrc);\n+\t\t\tentry-\u003emask[0] |= mask;\n+\t\t}\n+\n+\t\tmask = (ethaddr_lo2_to_u32(match.mask-\u003edst) \u003c\u003c 16) |\n+\t\t ethaddr_lo2_to_u32(match.mask-\u003esrc);\n+\t\tif (mask) {\n+\t\t\tentry = yt921x_acl_entries_new(entries, \u0026size,\n+\t\t\t\t\t\t YT921X_ACL_TYPE_MAC_DA1_SA1);\n+\t\t\tif (!entry)\n+\t\t\t\tgoto err;\n+\n+\t\t\tentry-\u003ekey[0] |= (ethaddr_lo2_to_u32(match.key-\u003edst) \u003c\u003c 16) |\n+\t\t\t\t\t ethaddr_lo2_to_u32(match.key-\u003esrc);\n+\t\t\tentry-\u003emask[0] |= mask;\n+\t\t}\n+\t}\n+\n+\t/* Entries + Misc */\n+\tif (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_BASIC)) {\n+\t\tstruct flow_match_basic match;\n+\n+\t\tflow_rule_match_basic(rule, \u0026match);\n+\n+\t\tif (match.mask-\u003en_proto) {\n+\t\t\tenum yt921x_l3_type l3type = YT921X_L3_TYPE_OTHER;\n+\n+\t\t\tif (match.mask-\u003en_proto == htons(~0))\n+\t\t\t\tswitch (match.key-\u003en_proto) {\n+\t\t\t\tcase htons(ETH_P_IP):\n+\t\t\t\t\tl3type = YT921X_L3_TYPE_IPV4;\n+\t\t\t\t\tbreak;\n+\t\t\t\tcase htons(ETH_P_IPV6):\n+\t\t\t\t\tl3type = YT921X_L3_TYPE_IPV6;\n+\t\t\t\t\tbreak;\n+\t\t\t\tcase htons(ETH_P_ARP):\n+\t\t\t\t\tl3type = YT921X_L3_TYPE_ARP;\n+\t\t\t\t\tbreak;\n+\t\t\t\tcase htons(ETH_P_LLDP):\n+\t\t\t\t\tl3type = YT921X_L3_TYPE_LLDP;\n+\t\t\t\t\tbreak;\n+\t\t\t\tcase htons(ETH_P_PAE):\n+\t\t\t\t\tl3type = YT921X_L3_TYPE_PAE;\n+\t\t\t\t\tbreak;\n+\t\t\t\tcase htons(ETH_P_CFM):\n+\t\t\t\t\tl3type = YT921X_L3_TYPE_ERP;\n+\t\t\t\t\tbreak;\n+\t\t\t\t}\n+\n+\t\t\tif (l3type != YT921X_L3_TYPE_OTHER) {\n+\t\t\t\tsize = yt921x_acl_entries_set_l3_type(entries,\n+\t\t\t\t\t\t\t\t size,\n+\t\t\t\t\t\t\t\t l3type);\n+\t\t\t\tif (!size)\n+\t\t\t\t\tgoto err;\n+\t\t\t} else {\n+\t\t\t\tentry = yt921x_acl_entries_new(entries, \u0026size,\n+\t\t\t\t\t\t\t YT921X_ACL_TYPE_ETHERTYPE);\n+\t\t\t\tif (!entry)\n+\t\t\t\t\tgoto err;\n+\n+\t\t\t\tentry-\u003ekey[0] |= ntohs(match.key-\u003en_proto);\n+\t\t\t\tentry-\u003emask[0] |= ntohs(match.mask-\u003en_proto);\n+\t\t\t}\n+\t\t}\n+\n+\t\tif (match.mask-\u003eip_proto) {\n+\t\t\tenum yt921x_l4_type l4type = YT921X_L4_TYPE_OTHER;\n+\n+\t\t\tif (match.mask-\u003eip_proto == (u8)~0)\n+\t\t\t\tswitch (match.key-\u003eip_proto) {\n+\t\t\t\tcase IPPROTO_TCP:\n+\t\t\t\t\tl4type = YT921X_L4_TYPE_TCP;\n+\t\t\t\t\tbreak;\n+\t\t\t\tcase IPPROTO_UDP:\n+\t\t\t\t\tl4type = YT921X_L4_TYPE_UDP;\n+\t\t\t\t\tbreak;\n+\t\t\t\tcase IPPROTO_UDPLITE:\n+\t\t\t\t\tl4type = YT921X_L4_TYPE_UDPLITE;\n+\t\t\t\t\tbreak;\n+\t\t\t\tcase IPPROTO_ICMP:\n+\t\t\t\t\tl4type = YT921X_L4_TYPE_ICMP;\n+\t\t\t\t\tbreak;\n+\t\t\t\tcase IPPROTO_IGMP:\n+\t\t\t\t\tl4type = YT921X_L4_TYPE_IGMP;\n+\t\t\t\t\tbreak;\n+\t\t\t\t}\n+\n+\t\t\tif (l4type != YT921X_L4_TYPE_OTHER) {\n+\t\t\t\tsize = yt921x_acl_entries_set_l4_type(entries,\n+\t\t\t\t\t\t\t\t size,\n+\t\t\t\t\t\t\t\t l4type);\n+\t\t\t\tif (!size)\n+\t\t\t\t\tgoto err;\n+\t\t\t} else {\n+\t\t\t\tentry = yt921x_acl_entries_find(entries, \u0026size,\n+\t\t\t\t\t\t\t\tYT921X_ACL_TYPE_MISC);\n+\t\t\t\tif (!entry)\n+\t\t\t\t\tgoto err;\n+\n+\t\t\t\tentry-\u003ekey[0] |= YT921X_ACL_BINa_MISC_IP_PROTO(match.key-\u003eip_proto);\n+\t\t\t\tentry-\u003emask[0] |= YT921X_ACL_BINa_MISC_IP_PROTO(match.mask-\u003eip_proto);\n+\t\t\t}\n+\t\t}\n+\t}\n+\n+\tif (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_CONTROL)) {\n+\t\tu32 supp_flags = FLOW_DIS_IS_FRAGMENT | FLOW_DIS_FIRST_FRAG;\n+\t\tstruct flow_match_control match;\n+\n+\t\tflow_rule_match_control(rule, \u0026match);\n+\t\tif (!flow_rule_is_supp_control_flags(supp_flags,\n+\t\t\t\t\t\t match.mask-\u003eflags, extack))\n+\t\t\treturn -EOPNOTSUPP;\n+\n+\t\tif (match.mask-\u003eflags \u0026 FLOW_DIS_IS_FRAGMENT) {\n+\t\t\tbool set = match.key-\u003eflags \u0026 FLOW_DIS_IS_FRAGMENT;\n+\n+\t\t\tsize = yt921x_acl_entries_set_is_fragment(entries, size,\n+\t\t\t\t\t\t\t\t set);\n+\t\t\tif (!size)\n+\t\t\t\tgoto err;\n+\t\t}\n+\t\tif (match.mask-\u003eflags \u0026 FLOW_DIS_FIRST_FRAG) {\n+\t\t\tbool set = match.key-\u003eflags \u0026 FLOW_DIS_FIRST_FRAG;\n+\n+\t\t\tsize = yt921x_acl_entries_set_first_frag(entries, size,\n+\t\t\t\t\t\t\t\t set);\n+\t\t\tif (!size)\n+\t\t\t\tgoto err;\n+\t\t}\n+\t}\n+\n+\t/* Misc only */\n+\tif (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_IP)) {\n+\t\tstruct flow_match_ip match;\n+\n+\t\tflow_rule_match_ip(rule, \u0026match);\n+\t\tif (match.mask-\u003ettl) {\n+\t\t\tNL_SET_ERR_MSG_MOD(extack,\n+\t\t\t\t\t \"Matching on TTL not supported\");\n+\t\t\treturn -EOPNOTSUPP;\n+\t\t}\n+\n+\t\tif (match.mask-\u003etos) {\n+\t\t\tentry = yt921x_acl_entries_find(entries, \u0026size,\n+\t\t\t\t\t\t\tYT921X_ACL_TYPE_MISC);\n+\t\t\tif (!entry)\n+\t\t\t\tgoto err;\n+\n+\t\t\tentry-\u003ekey[0] |= YT921X_ACL_BINa_MISC_TOS(match.key-\u003etos);\n+\t\t\tentry-\u003emask[0] |= YT921X_ACL_BINa_MISC_TOS(match.mask-\u003etos);\n+\t\t}\n+\t}\n+\n+\tif (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_TCP)) {\n+\t\tstruct flow_match_tcp match;\n+\n+\t\tflow_rule_match_tcp(rule, \u0026match);\n+\t\tif (match.mask-\u003eflags \u0026 htons(~0xff)) {\n+\t\t\tNL_SET_ERR_MSG_MOD(extack, \"Unsupported TCP flags\");\n+\t\t\treturn -EOPNOTSUPP;\n+\t\t}\n+\n+\t\tif (match.mask-\u003eflags) {\n+\t\t\tentry = yt921x_acl_entries_find(entries, \u0026size,\n+\t\t\t\t\t\t\tYT921X_ACL_TYPE_MISC);\n+\t\t\tif (!entry)\n+\t\t\t\tgoto err;\n+\n+\t\t\tentry-\u003ekey[0] |= YT921X_ACL_BINa_MISC_TCP_FLAGS(ntohs(match.key-\u003eflags));\n+\t\t\tentry-\u003emask[0] |= YT921X_ACL_BINa_MISC_TCP_FLAGS(ntohs(match.mask-\u003eflags));\n+\t\t}\n+\t}\n+\n+\tif (!size) {\n+\t\tNL_SET_ERR_MSG_MOD(extack, \"Empty rule generated, this should not happen\");\n+\t\treturn -EOPNOTSUPP;\n+\t}\n+\n+\truleext-\u003er.mask = (1 \u003c\u003c size) - 1;\n+\treturn 0;\n+\n+err:\n+\tNL_SET_ERR_MSG_MOD(extack, \"Rule too complex\");\n+\treturn -EOPNOTSUPP;\n+}\n+\n+static int\n+yt921x_acl_rule_ext_parse_flow_action(struct yt921x_acl_rule_ext *ruleext,\n+\t\t\t\t const struct flow_cls_offload *cls,\n+\t\t\t\t struct yt921x_priv *priv, int port)\n+{\n+\tconst struct flow_rule *rule = flow_cls_offload_flow_rule(cls);\n+\tconst struct flow_action *flow_action = \u0026rule-\u003eaction;\n+\tstruct netlink_ext_ack *extack = cls-\u003ecommon.extack;\n+\tenum flow_action_id redir_act = NUM_FLOW_ACTIONS;\n+\tconst struct flow_action_entry *act;\n+\tu32 *action = ruleext-\u003er.action;\n+\tbool seen_priority = false;\n+\tconst char *reason = NULL;\n+\tbool seen_police = false;\n+\tunsigned int i;\n+\tint res;\n+\n+\tmemset(action, 0, 3 * sizeof(*action));\n+\tflow_action_for_each(i, act, flow_action)\n+\t\tswitch (act-\u003eid) {\n+\t\tcase FLOW_ACTION_ACCEPT:\n+\t\tcase FLOW_ACTION_DROP:\n+\t\tcase FLOW_ACTION_REDIRECT:\n+\t\t\tif (redir_act != NUM_FLOW_ACTIONS \u0026\u0026\n+\t\t\t redir_act != act-\u003eid) {\n+\t\t\t\treason = \"Different redirect actions\";\n+\t\t\t\tgoto fallback;\n+\t\t\t}\n+\t\t\tredir_act = act-\u003eid;\n+\n+\t\t\tswitch (act-\u003eid) {\n+\t\t\tcase FLOW_ACTION_ACCEPT:\n+\t\t\t\taction[2] |= YT921X_ACL_ACTc_FWD_EN |\n+\t\t\t\t\t YT921X_ACL_ACTc_FWD_FWD;\n+\t\t\t\tbreak;\n+\t\t\tcase FLOW_ACTION_DROP:\n+\t\t\t\taction[2] |= YT921X_ACL_ACTc_FWD_EN |\n+\t\t\t\t\t YT921X_ACL_ACTc_FWD_REDIR;\n+\t\t\t\tbreak;\n+\t\t\tcase FLOW_ACTION_REDIRECT: {\n+\t\t\t\tstruct dsa_port *to_dp;\n+\n+\t\t\t\tto_dp = dsa_port_from_netdev(act-\u003edev);\n+\t\t\t\tif (IS_ERR(to_dp) || to_dp-\u003eds != \u0026priv-\u003eds) {\n+\t\t\t\t\treason = \"Redirect to non-local port\";\n+\t\t\t\t\tgoto fallback;\n+\t\t\t\t}\n+\n+\t\t\t\taction[2] |= YT921X_ACL_ACTc_FWD_EN |\n+\t\t\t\t\t YT921X_ACL_ACTc_FWD_REDIR |\n+\t\t\t\t\t YT921X_ACL_ACTc_FWD_REDIR_DPORTn(to_dp-\u003eindex);\n+\t\t\t\tbreak;\n+\t\t\t}\n+\t\t\tdefault:\n+\t\t\t\tbreak;\n+\t\t\t}\n+\t\t\tbreak;\n+\t\tcase FLOW_ACTION_PRIORITY:\n+\t\t\tif (seen_priority) {\n+\t\t\t\taction[0] \u0026= ~YT921X_ACL_ACTa_PRIO_EN;\n+\t\t\t\taction[1] \u0026= ~YT921X_ACL_ACTb_PRIO_M;\n+\n+\t\t\t\treason = \"Multiple priority actions\";\n+\t\t\t\tgoto fallback;\n+\t\t\t}\n+\t\t\tseen_priority = true;\n+\n+\t\t\tif (act-\u003epriority \u003e= YT921X_PRIO_NUM) {\n+\t\t\t\tNL_SET_ERR_MSG_MOD(extack,\n+\t\t\t\t\t\t \"Priority value is too high\");\n+\t\t\t\treturn -EOPNOTSUPP;\n+\t\t\t}\n+\t\t\taction[0] |= YT921X_ACL_ACTa_PRIO_EN;\n+\t\t\taction[1] |= YT921X_ACL_ACTb_PRIO(act-\u003epriority);\n+\t\t\tbreak;\n+\t\tcase FLOW_ACTION_POLICE: {\n+\t\t\tconst struct flow_action_police *police = \u0026act-\u003epolice;\n+\n+\t\t\tif (seen_police) {\n+\t\t\t\taction[0] \u0026= ~YT921X_ACL_ACTa_METER_EN;\n+\n+\t\t\t\treason = \"Multiple police actions\";\n+\t\t\t\tgoto fallback;\n+\t\t\t}\n+\t\t\tseen_police = true;\n+\n+\t\t\tres = yt921x_police_validate(police, flow_action, act,\n+\t\t\t\t\t\t extack);\n+\t\t\tif (res)\n+\t\t\t\treturn res;\n+\n+\t\t\tres = yt921x_marker_tfm_police(\u0026ruleext-\u003emarker, police,\n+\t\t\t\t\t\t 0, priv, port, extack);\n+\t\t\tif (res)\n+\t\t\t\treturn res;\n+\n+\t\t\taction[0] |= YT921X_ACL_ACTa_METER_EN;\n+\t\t\tbreak;\n+\t\t}\n+\t\tdefault:\n+fallback:\n+\t\t\tif (cls-\u003ecommon.skip_sw) {\n+\t\t\t\tNL_SET_ERR_MSG_FMT_MOD(extack,\n+\t\t\t\t\t\t \"Action not supported when skip_sw: %s\",\n+\t\t\t\t\t\t reason);\n+\t\t\t\treturn -EOPNOTSUPP;\n+\t\t\t}\n+\t\t\tfallthrough;\n+\t\tcase FLOW_ACTION_TRAP:\n+\t\t\tredir_act = FLOW_ACTION_TRAP;\n+\n+\t\t\taction[2] \u0026= ~YT921X_ACL_ACTc_FWD_REDIR_DPORTS_M \u0026\n+\t\t\t\t ~YT921X_ACL_ACTc_FWD_M;\n+\t\t\taction[2] |= YT921X_ACL_ACTc_FWD_EN |\n+\t\t\t\t YT921X_ACL_ACTc_FWD_TRAP;\n+\t\t\tbreak;\n+\t\t}\n+\n+\truleext-\u003er.sw_assisted = !cls-\u003ecommon.skip_sw;\n+\treturn 0;\n+}\n+\n+static int\n+yt921x_acl_rule_ext_parse_flow(struct yt921x_acl_rule_ext *ruleext, int port,\n+\t\t\t const struct flow_cls_offload *cls, bool ingress,\n+\t\t\t struct yt921x_priv *priv)\n+{\n+\tconst unsigned int scale = (U16_MAX + 1) / YT921X_ACL_ORD_NUM;\n+\tstruct netlink_ext_ack *extack = cls-\u003ecommon.extack;\n+\tu32 prio = cls-\u003ecommon.prio;\n+\tu32 ord;\n+\tint res;\n+\n+\tif (!ingress) {\n+\t\tNL_SET_ERR_MSG_MOD(extack, \"Only ingress is supported\");\n+\t\treturn -EOPNOTSUPP;\n+\t}\n+\n+\tif (cls-\u003ecommon.chain_index) {\n+\t\tNL_SET_ERR_MSG(extack, \"Only chain 0 is supported\");\n+\t\treturn -EOPNOTSUPP;\n+\t}\n+\n+\t/* TC prio can't be 0 \u0026 TC lowest first -\u003e HW highest first\n+\t * map 1...U16_MAX to (ACL_ORD_NUM - 1)...0\n+\t */\n+\tif (prio == U16_MAX) {\n+\t\tord = 0;\n+\t} else if (!(prio % scale)) {\n+\t\tord = YT921X_ACL_ORD_NUM - prio / scale;\n+\t} else {\n+\t\tNL_SET_ERR_MSG_FMT_MOD(extack,\n+\t\t\t\t \"Invalid priority %u, must be a multiple of %u or 65535\",\n+\t\t\t\t prio, scale);\n+\t\treturn -EOPNOTSUPP;\n+\t}\n+\n+\tres = yt921x_acl_rule_ext_parse_flow_action(ruleext, cls, priv, port);\n+\tif (res)\n+\t\treturn res;\n+\tres = yt921x_acl_rule_ext_parse_flow_entries(ruleext, cls);\n+\tif (res)\n+\t\treturn res;\n+\n+\tyt921x_acl_rule_set_ports(\u0026ruleext-\u003er, ord, BIT(port));\n+\truleext-\u003er.tag = cls-\u003ecookie;\n+\truleext-\u003er.type = TC_SETUP_CLSFLOWER;\n+\treturn 0;\n+}\n+\n+static u16 yt921x_acl_activated_ports(const struct yt921x_priv *priv)\n+{\n+\tu16 mask = 0;\n+\n+\tfor (int port = 0; port \u003c YT921X_PORT_NUM; port++)\n+\t\tif (priv-\u003eports[port].acl_cnt)\n+\t\t\tmask |= BIT(port);\n+\n+\treturn mask;\n+}\n+\n+static unsigned int\n+yt921x_acl_find(const struct yt921x_priv *priv, enum tc_setup_type type,\n+\t\tunsigned long tag)\n+{\n+\tfor (unsigned int blkid = 0; blkid \u003c YT921X_ACL_BLK_NUM; blkid++) {\n+\t\tconst struct yt921x_acl_blk *aclblk = priv-\u003eacl_blks[blkid];\n+\n+\t\tif (!aclblk)\n+\t\t\tcontinue;\n+\n+\t\tfor (unsigned int i = 0; i \u003c YT921X_ACL_ENT_PER_BLK; i++)\n+\t\t\tif (aclblk-\u003erules[i] \u0026\u0026 aclblk-\u003erules[i]-\u003etag == tag \u0026\u0026\n+\t\t\t aclblk-\u003erules[i]-\u003etype == type)\n+\t\t\t\treturn YT921X_ACL_ENT_PER_BLK * blkid + i;\n+\t}\n+\n+\treturn UINT_MAX;\n+}\n+\n+static unsigned int\n+yt921x_acl_reserve(struct yt921x_priv *priv, unsigned int entscnt,\n+\t\t struct netlink_ext_ack *extack)\n+{\n+\tint candidates[YT921X_ACL_ENT_PER_BLK + 1];\n+\tunsigned int acl_used_cnt = 0;\n+\n+\tif (WARN_ON(entscnt \u003e YT921X_ACL_ENT_PER_BLK))\n+\t\treturn UINT_MAX;\n+\n+\tfor (unsigned int i = 0; i \u003c ARRAY_SIZE(candidates); i++)\n+\t\tcandidates[i] = -1;\n+\tfor (unsigned int i = YT921X_ACL_BLK_NUM; i-- \u003e 0;) {\n+\t\tunsigned int blk_used_cnt = hweight8(priv-\u003eacl_masks[i]);\n+\n+\t\tcandidates[blk_used_cnt] = i;\n+\t\tacl_used_cnt += blk_used_cnt;\n+\t}\n+\n+\tif (acl_used_cnt \u003e= YT921X_ACL_NUM) {\n+\t\tNL_SET_ERR_MSG_MOD(extack, \"ACL entry limit reached\");\n+\t\treturn UINT_MAX;\n+\t}\n+\tif (acl_used_cnt + entscnt \u003c= YT921X_ACL_NUM)\n+\t\tfor (unsigned int i = YT921X_ACL_ENT_PER_BLK - entscnt + 1;\n+\t\t i-- \u003e 0;)\n+\t\t\tif (candidates[i] \u003e= 0)\n+\t\t\t\treturn YT921X_ACL_ENT_PER_BLK * candidates[i] +\n+\t\t\t\t ffz(priv-\u003eacl_masks[candidates[i]]);\n+\n+\tNL_SET_ERR_MSG_MOD(extack,\n+\t\t\t \"ACL entry allocation failed, simplify your rules or remove existing rules\");\n+\treturn UINT_MAX;\n+}\n+\n+static int\n+yt921x_acl_commit(struct yt921x_priv *priv, unsigned int entid, u8 entsmask)\n+{\n+\tconst struct yt921x_acl_rule *aclrule;\n+\tconst struct yt921x_acl_blk *aclblk;\n+\tunsigned int blkid;\n+\tunsigned int binid;\n+\tunsigned long mask;\n+\tu32 zeros[3] = {};\n+\tunsigned int i;\n+\tunsigned int o;\n+\tu32 ctrl;\n+\tint res;\n+\n+\tblkid = entid / YT921X_ACL_ENT_PER_BLK;\n+\tbinid = entid % YT921X_ACL_ENT_PER_BLK;\n+\taclblk = priv-\u003eacl_blks[blkid];\n+\taclrule = aclblk-\u003erules[binid];\n+\n+\t/* Write actions */\n+\tres = yt921x_reg96_write(priv, YT921X_ACLn_ACT(entid),\n+\t\t\t\t aclrule ? aclrule-\u003eaction : zeros);\n+\tif (res)\n+\t\treturn res;\n+\n+\t/* Select the block */\n+\tctrl = YT921X_ACL_BLK_CMD_MODIFY | YT921X_ACL_BLK_CMD_BLKID(blkid);\n+\tres = yt921x_reg_write(priv, YT921X_ACL_BLK_CMD, ctrl);\n+\tif (res)\n+\t\treturn res;\n+\n+\t/* Write keys and masks */\n+\tctrl = 0;\n+\tfor (unsigned int i = 0; i \u003c YT921X_ACL_ENT_PER_BLK; i++)\n+\t\tctrl |= YT921X_ACL_BLK_KEEP_KEEPn(i);\n+\n+\tmask = entsmask;\n+\ti = 0;\n+\tfor_each_set_bit(o, \u0026mask, YT921X_ACL_ENT_PER_BLK) {\n+\t\tres = yt921x_reg64_write(priv, YT921X_ACLn_KEYm(blkid, o),\n+\t\t\t\t\t aclrule ? aclrule-\u003eentries[i].key :\n+\t\t\t\t\t zeros);\n+\t\tif (res)\n+\t\t\treturn res;\n+\n+\t\tres = yt921x_reg64_write(priv, YT921X_ACLn_MASKm(blkid, o),\n+\t\t\t\t\t aclrule ? aclrule-\u003eentries[i].mask :\n+\t\t\t\t\t zeros);\n+\t\tif (res)\n+\t\t\treturn res;\n+\n+\t\tctrl \u0026= ~YT921X_ACL_BLK_KEEP_KEEPn(o);\n+\t\ti++;\n+\t}\n+\n+\tres = yt921x_reg_write(priv, YT921X_ACL_BLK_KEEP, ctrl);\n+\tif (res)\n+\t\treturn res;\n+\n+\tctrl = 0;\n+\tfor (unsigned int i = 0; i \u003c YT921X_ACL_ENT_PER_BLK; i++) {\n+\t\tconst struct yt921x_acl_rule *other = aclblk-\u003erules[i];\n+\n+\t\tif (!other)\n+\t\t\tcontinue;\n+\n+\t\tmask = other-\u003emask;\n+\t\tfor_each_set_bit(o, \u0026mask, YT921X_ACL_ENT_PER_BLK)\n+\t\t\tctrl |= YT921X_ACL_ENTRY_ENm(o) |\n+\t\t\t\tYT921X_ACL_ENTRY_GRPIDm(o, i);\n+\t}\n+\tres = yt921x_reg_write(priv, YT921X_ACLn_ENTRY(blkid), ctrl);\n+\tif (res)\n+\t\treturn res;\n+\n+\t/* Commit the block */\n+\tctrl = YT921X_ACL_BLK_CMD_BLKID(blkid);\n+\tres = yt921x_reg_write(priv, YT921X_ACL_BLK_CMD, ctrl);\n+\tif (res)\n+\t\treturn res;\n+\n+\treturn 0;\n+}\n+\n+static int\n+yt921x_acl_del(struct yt921x_priv *priv, enum tc_setup_type type,\n+\t unsigned long tag)\n+{\n+\tstruct yt921x_acl_rule *aclrule;\n+\tstruct yt921x_acl_blk *aclblk;\n+\tbool refresh_en = false;\n+\tunsigned int binid;\n+\tunsigned int blkid;\n+\tunsigned int entid;\n+\tunsigned long m;\n+\tunsigned int o;\n+\tu32 ctrl;\n+\tint res;\n+\tint ret;\n+\n+\tentid = yt921x_acl_find(priv, type, tag);\n+\tif (entid == UINT_MAX)\n+\t\treturn -ENOENT;\n+\n+\tblkid = entid / YT921X_ACL_ENT_PER_BLK;\n+\tbinid = entid % YT921X_ACL_ENT_PER_BLK;\n+\taclblk = priv-\u003eacl_blks[blkid];\n+\taclrule = aclblk-\u003erules[binid];\n+\n+\taclblk-\u003erules[binid] = NULL;\n+\tret = yt921x_acl_commit(priv, entid, aclrule-\u003emask);\n+\t/* the kernel never rolls back on failure */\n+\n+\tm = FIELD_GET(YT921X_ACL_KEYb_SPORTS_M, aclrule-\u003eentries[0].key[1]);\n+\tfor_each_set_bit(o, \u0026m, YT921X_PORT_NUM) {\n+\t\tstruct yt921x_port *pp = \u0026priv-\u003eports[o];\n+\n+\t\tif (!WARN_ON(!pp-\u003eacl_cnt)) {\n+\t\t\tpp-\u003eacl_cnt--;\n+\t\t\tif (pp-\u003eacl_cnt)\n+\t\t\t\tcontinue;\n+\t\t}\n+\t\trefresh_en = true;\n+\t}\n+\tif (refresh_en) {\n+\t\tctrl = yt921x_acl_activated_ports(priv);\n+\t\tres = yt921x_reg_write(priv, YT921X_ACL_PORT, ctrl);\n+\t\tif (res)\n+\t\t\tret = res;\n+\t}\n+\n+\tif (aclrule-\u003eaction[0] \u0026 YT921X_ACL_ACTa_METER_EN)\n+\t\tclear_bit(FIELD_GET(YT921X_ACL_ACTa_METER_ID_M,\n+\t\t\t\t aclrule-\u003eaction[0]),\n+\t\t\t priv-\u003emeters_map);\n+\tpriv-\u003eacl_masks[blkid] \u0026= ~aclrule-\u003emask;\n+\tkvfree(aclrule);\n+\tif (!priv-\u003eacl_masks[blkid]) {\n+\t\tkvfree(aclblk);\n+\t\tpriv-\u003eacl_blks[blkid] = NULL;\n+\t}\n+\treturn ret;\n+}\n+\n+static int\n+yt921x_acl_add(struct yt921x_priv *priv,\n+\t const struct yt921x_acl_rule_ext *ruleext,\n+\t struct netlink_ext_ack *extack)\n+{\n+\tunsigned int entscnt = hweight8(ruleext-\u003er.mask);\n+\tstruct yt921x_acl_rule *aclrule;\n+\tstruct yt921x_acl_blk *aclblk;\n+\tbool use_trap = false;\n+\tunsigned int meterid;\n+\tunsigned int binid;\n+\tunsigned int blkid;\n+\tunsigned int entid;\n+\tunsigned long m;\n+\tunsigned int o;\n+\tu32 ctrl;\n+\tint res;\n+\n+\t/* Allocate resources */\n+\tentid = yt921x_acl_reserve(priv, entscnt, extack);\n+\tif (entid == UINT_MAX)\n+\t\treturn -EOPNOTSUPP;\n+\n+\tif (!(ruleext-\u003er.action[0] \u0026 YT921X_ACL_ACTa_METER_EN)) {\n+\t\tmeterid = YT921X_METER_NUM;\n+\t} else {\n+\t\tmeterid = find_first_zero_bit(priv-\u003emeters_map,\n+\t\t\t\t\t YT921X_METER_NUM);\n+\t\tif (meterid \u003c YT921X_METER_NUM) {\n+\t\t\tres = yt921x_meter_config(priv, meterid,\n+\t\t\t\t\t\t \u0026ruleext-\u003emarker);\n+\t\t\tif (res)\n+\t\t\t\treturn res;\n+\t\t} else if (ruleext-\u003er.sw_assisted) {\n+\t\t\tuse_trap = true;\n+\t\t} else {\n+\t\t\tNL_SET_ERR_MSG_MOD(extack,\n+\t\t\t\t\t \"No more meters available\");\n+\t\t\treturn -EOPNOTSUPP;\n+\t\t}\n+\t}\n+\n+\t/* Prepare acl block ctrlblk */\n+\tblkid = entid / YT921X_ACL_ENT_PER_BLK;\n+\tbinid = entid % YT921X_ACL_ENT_PER_BLK;\n+\taclblk = priv-\u003eacl_blks[blkid];\n+\tif (!aclblk) {\n+\t\taclblk = kvzalloc_obj(*aclblk);\n+\t\tif (!aclblk)\n+\t\t\treturn -ENOMEM;\n+\t\tpriv-\u003eacl_blks[blkid] = aclblk;\n+\t}\n+\n+\t/* Prepare acl rule ctrlblk */\n+\taclrule = kvmemdup(\u0026ruleext-\u003er,\n+\t\t\t offsetof(struct yt921x_acl_rule, entries[entscnt]),\n+\t\t\t GFP_KERNEL);\n+\tif (!aclrule) {\n+\t\tres = -ENOMEM;\n+\t\tgoto err;\n+\t}\n+\n+\t/* Replace the placeholder resource IDs */\n+\taclrule-\u003emask = 0;\n+\tm = priv-\u003eacl_masks[blkid];\n+\tfor_each_clear_bit(o, \u0026m, YT921X_ACL_ENT_PER_BLK) {\n+\t\taclrule-\u003emask |= BIT(o);\n+\t\tentscnt--;\n+\t\tif (!entscnt)\n+\t\t\tbreak;\n+\t}\n+\n+\tif (use_trap) {\n+\t\taclrule-\u003eaction[2] \u0026= ~YT921X_ACL_ACTc_FWD_REDIR_DPORTS_M \u0026\n+\t\t\t\t ~YT921X_ACL_ACTc_FWD_M;\n+\t\taclrule-\u003eaction[2] |= YT921X_ACL_ACTc_FWD_EN |\n+\t\t\t\t YT921X_ACL_ACTc_FWD_TRAP;\n+\t}\n+\tif (meterid \u003c YT921X_METER_NUM)\n+\t\taclrule-\u003eaction[0] |= YT921X_ACL_ACTa_METER_ID(meterid);\n+\telse\n+\t\taclrule-\u003eaction[0] \u0026= ~YT921X_ACL_ACTa_METER_EN;\n+\n+\t/* Activate ACL if needed */\n+\tctrl = 0;\n+\tm = FIELD_GET(YT921X_ACL_KEYb_SPORTS_M, ruleext-\u003er.entries[0].key[1]);\n+\tfor_each_set_bit(o, \u0026m, YT921X_PORT_NUM)\n+\t\tif (!priv-\u003eports[o].acl_cnt)\n+\t\t\tctrl |= YT921X_ACL_PORT_PORTn(o);\n+\tif (ctrl) {\n+\t\tctrl |= yt921x_acl_activated_ports(priv);\n+\t\tres = yt921x_reg_write(priv, YT921X_ACL_PORT, ctrl);\n+\t\tif (res)\n+\t\t\treturn res;\n+\t}\n+\n+\t/* Write rules */\n+\taclblk-\u003erules[binid] = aclrule;\n+\tres = yt921x_acl_commit(priv, entid, aclrule-\u003emask);\n+\tif (res) {\n+\t\taclblk-\u003erules[binid] = NULL;\n+\t\tkvfree(aclrule);\n+\t\tgoto err;\n+\t}\n+\n+\t/* Bookkeeping */\n+\tm = FIELD_GET(YT921X_ACL_KEYb_SPORTS_M, ruleext-\u003er.entries[0].key[1]);\n+\tfor_each_set_bit(o, \u0026m, YT921X_PORT_NUM)\n+\t\tpriv-\u003eports[o].acl_cnt++;\n+\n+\tif (meterid \u003c YT921X_METER_NUM)\n+\t\tset_bit(meterid, priv-\u003emeters_map);\n+\tpriv-\u003eacl_masks[blkid] |= aclrule-\u003emask;\n+\treturn 0;\n+\n+err:\n+\tif (!priv-\u003eacl_masks[blkid]) {\n+\t\tkvfree(aclblk);\n+\t\tpriv-\u003eacl_blks[blkid] = NULL;\n+\t}\n+\treturn res;\n+}\n+\n+int\n+yt921x_dsa_cls_flower_del(struct dsa_switch *ds, int port,\n+\t\t\t struct flow_cls_offload *cls, bool ingress)\n+{\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(ds);\n+\tint res;\n+\n+\tmutex_lock(\u0026priv-\u003ereg_lock);\n+\tres = yt921x_acl_del(priv, TC_SETUP_CLSFLOWER, cls-\u003ecookie);\n+\tmutex_unlock(\u0026priv-\u003ereg_lock);\n+\n+\treturn res;\n+}\n+\n+int\n+yt921x_dsa_cls_flower_add(struct dsa_switch *ds, int port,\n+\t\t\t struct flow_cls_offload *cls, bool ingress)\n+{\n+\tstruct netlink_ext_ack *extack = cls-\u003ecommon.extack;\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(ds);\n+\tstruct yt921x_acl_rule_ext ruleext;\n+\tint res;\n+\n+\tres = yt921x_acl_rule_ext_parse_flow(\u0026ruleext, port, cls, ingress,\n+\t\t\t\t\t priv);\n+\tif (res)\n+\t\treturn res;\n+\n+\tmutex_lock(\u0026priv-\u003ereg_lock);\n+\tres = yt921x_acl_add(priv, \u0026ruleext, extack);\n+\tmutex_unlock(\u0026priv-\u003ereg_lock);\n+\n+\treturn res;\n+}\n+\n+static int\n+yt921x_mirror_del(struct yt921x_priv *priv, int port, bool ingress)\n+{\n+\tu32 mask;\n+\n+\tif (ingress)\n+\t\tmask = YT921X_MIRROR_IGR_PORTn(port);\n+\telse\n+\t\tmask = YT921X_MIRROR_EGR_PORTn(port);\n+\treturn yt921x_reg_clear_bits(priv, YT921X_MIRROR, mask);\n+}\n+\n+static int\n+yt921x_mirror_add(struct yt921x_priv *priv, int port, bool ingress,\n+\t\t int to_local_port, struct netlink_ext_ack *extack)\n+{\n+\tu32 srcs;\n+\tu32 ctrl;\n+\tu32 val;\n+\tu32 dst;\n+\tint res;\n+\n+\tif (ingress)\n+\t\tsrcs = YT921X_MIRROR_IGR_PORTn(port);\n+\telse\n+\t\tsrcs = YT921X_MIRROR_EGR_PORTn(port);\n+\tdst = YT921X_MIRROR_PORT(to_local_port);\n+\n+\tres = yt921x_reg_read(priv, YT921X_MIRROR, \u0026val);\n+\tif (res)\n+\t\treturn res;\n+\n+\t/* other mirror tasks \u0026 different dst port -\u003e conflict */\n+\tif ((val \u0026 ~srcs \u0026 (YT921X_MIRROR_EGR_PORTS_M |\n+\t\t\t YT921X_MIRROR_IGR_PORTS_M)) \u0026\u0026\n+\t (val \u0026 YT921X_MIRROR_PORT_M) != dst) {\n+\t\tNL_SET_ERR_MSG_MOD(extack,\n+\t\t\t\t \"Sniffer port is already configured, delete existing rules \u0026 retry\");\n+\t\treturn -EBUSY;\n+\t}\n+\n+\tctrl = val \u0026 ~YT921X_MIRROR_PORT_M;\n+\tctrl |= srcs;\n+\tctrl |= dst;\n+\n+\tif (ctrl == val)\n+\t\treturn 0;\n+\n+\treturn yt921x_reg_write(priv, YT921X_MIRROR, ctrl);\n+}\n+\n+void\n+yt921x_dsa_port_mirror_del(struct dsa_switch *ds, int port,\n+\t\t\t struct dsa_mall_mirror_tc_entry *mirror)\n+{\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(ds);\n+\tstruct device *dev = yt921x_priv_to_device(priv);\n+\tint res;\n+\n+\tmutex_lock(\u0026priv-\u003ereg_lock);\n+\tres = yt921x_mirror_del(priv, port, mirror-\u003eingress);\n+\tmutex_unlock(\u0026priv-\u003ereg_lock);\n+\n+\tif (res)\n+\t\tdev_err(dev, \"Failed to %s port %d: %i\\n\", \"unmirror\",\n+\t\t\tport, res);\n+}\n+\n+int\n+yt921x_dsa_port_mirror_add(struct dsa_switch *ds, int port,\n+\t\t\t struct dsa_mall_mirror_tc_entry *mirror,\n+\t\t\t bool ingress, struct netlink_ext_ack *extack)\n+{\n+\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(ds);\n+\tint res;\n+\n+\tmutex_lock(\u0026priv-\u003ereg_lock);\n+\tres = yt921x_mirror_add(priv, port, ingress,\n+\t\t\t\tmirror-\u003eto_local_port, extack);\n+\tmutex_unlock(\u0026priv-\u003ereg_lock);\n+\n+\treturn res;\n+}\ndiff --git a/drivers/net/dsa/motorcomm/tc.h b/drivers/net/dsa/motorcomm/tc.h\nnew file mode 100644\nindex 0000000000000..99d4abf5dacdc\n--- /dev/null\n+++ b/drivers/net/dsa/motorcomm/tc.h\n@@ -0,0 +1,379 @@\n+/* SPDX-License-Identifier: GPL-2.0-or-later */\n+/*\n+ * Copyright (c) 2026 David Yang\n+ */\n+\n+#ifndef _YT_TC_H\n+#define _YT_TC_H\n+\n+#include \u003cnet/dsa.h\u003e\n+#include \u003cnet/pkt_cls.h\u003e\n+\n+#define YT921X_ACLn_ACT(n)\t\t(0x1c0000 + 0x10 * (n))\n+#define YT921X_ACL_ACTc_STAG_M\t\t\tGENMASK(26, 25)\n+#define YT921X_ACL_ACTc_STAG(x)\t\t\tFIELD_PREP(YT921X_ACL_ACTc_STAG_M, (x))\n+#define YT921X_ACL_ACTc_STAG_DONTCARE\t\t\tYT921X_ACL_ACTc_STAG(0)\n+#define YT921X_ACL_ACTc_STAG_UNTAG\t\t\tYT921X_ACL_ACTc_STAG(1)\n+#define YT921X_ACL_ACTc_STAG_TAG\t\t\tYT921X_ACL_ACTc_STAG(2)\n+#define YT921X_ACL_ACTc_STAG_KEEP\t\t\tYT921X_ACL_ACTc_STAG(3)\n+#define YT921X_ACL_ACTc_CTAG_M\t\t\tGENMASK(24, 23)\n+#define YT921X_ACL_ACTc_CTAG(x)\t\t\tFIELD_PREP(YT921X_ACL_ACTc_CTAG_M, (x))\n+#define YT921X_ACL_ACTc_CTAG_DONTCARE\t\t\tYT921X_ACL_ACTc_CTAG(0)\n+#define YT921X_ACL_ACTc_CTAG_UNTAG\t\t\tYT921X_ACL_ACTc_CTAG(1)\n+#define YT921X_ACL_ACTc_CTAG_TAG\t\t\tYT921X_ACL_ACTc_CTAG(2)\n+#define YT921X_ACL_ACTc_CTAG_KEEP\t\t\tYT921X_ACL_ACTc_CTAG(3)\n+#define YT921X_ACL_ACTc_FWD_M\t\t\tGENMASK(22, 21)\n+#define YT921X_ACL_ACTc_FWD(x)\t\t\tFIELD_PREP(YT921X_ACL_ACTc_FWD_M, (x))\n+#define YT921X_ACL_ACTc_FWD_FWD\t\t\tYT921X_ACL_ACTc_FWD(0)\n+#define YT921X_ACL_ACTc_FWD_COPY\t\t\tYT921X_ACL_ACTc_FWD(1)\n+#define YT921X_ACL_ACTc_FWD_REDIR\t\t\tYT921X_ACL_ACTc_FWD(2)\n+#define YT921X_ACL_ACTc_FWD_TRAP\t\t\tYT921X_ACL_ACTc_FWD(3)\n+#define YT921X_ACL_ACTc_FWD_REDIR_DPORTS_M\tGENMASK(20, 10)\n+#define YT921X_ACL_ACTc_FWD_REDIR_DPORTS(x)\t\tFIELD_PREP(YT921X_ACL_ACTc_FWD_REDIR_DPORTS_M, (x))\n+#define YT921X_ACL_ACTc_FWD_REDIR_DPORTn(port)\tBIT((port) + 10)\n+#define YT921X_ACL_ACTc_FWD_EN\t\t\tBIT(9)\n+#define YT921X_ACL_ACTc_SDEI\t\t\tBIT(8)\n+#define YT921X_ACL_ACTc_SDEI_REPLACE\t\tBIT(7)\n+#define YT921X_ACL_ACTc_SPRI_M\t\t\tGENMASK(6, 4)\n+#define YT921X_ACL_ACTc_SPRI(x)\t\t\tFIELD_PREP(YT921X_ACL_ACTc_SPRI_M, (x))\n+#define YT921X_ACL_ACTc_SPRI_REPLACE\t\tBIT(3)\n+#define YT921X_ACL_ACTbc_SVID_M\t\tGENMASK_ULL(34, 23)\n+#define YT921X_ACL_ACTbc_SVID(x)\t\t\tFIELD_PREP(YT921X_ACL_ACTbc_SVID_M, (x))\n+#define YT921X_ACL_ACTb_SVID_REPLACE\t\tBIT(22)\n+#define YT921X_ACL_ACTb_CDEI\t\t\tBIT(21)\n+#define YT921X_ACL_ACTb_CDEI_REPLACE\t\tBIT(20)\n+#define YT921X_ACL_ACTb_CPRI_M\t\t\tGENMASK(19, 17)\n+#define YT921X_ACL_ACTb_CPRI(x)\t\t\tFIELD_PREP(YT921X_ACL_ACTb_CPRI_M, (x))\n+#define YT921X_ACL_ACTb_CPRI_REPLACE\t\tBIT(16)\n+#define YT921X_ACL_ACTb_CVID_M\t\t\tGENMASK(15, 4)\n+#define YT921X_ACL_ACTb_CVID(x)\t\t\tFIELD_PREP(YT921X_ACL_ACTb_CVID_M, (x))\n+#define YT921X_ACL_ACTb_CVID_REPLACE\t\tBIT(3)\n+#define YT921X_ACL_ACTb_PRIO_M\t\t\tGENMASK(2, 0)\n+#define YT921X_ACL_ACTb_PRIO(x)\t\t\tFIELD_PREP(YT921X_ACL_ACTb_PRIO_M, (x))\n+#define YT921X_ACL_ACTa_PRIO_EN\t\tBIT(31)\n+#define YT921X_ACL_ACTa_COLOR_M\t\tGENMASK(30, 29)\n+#define YT921X_ACL_ACTa_COLOR(x)\t\t\tFIELD_PREP(YT921X_ACL_ACTa_COLOR_M, (x))\n+#define YT921X_ACL_ACTa_COLOR_GREEN\t\t\tYT921X_ACL_ACTa_COLOR(0)\n+#define YT921X_ACL_ACTa_COLOR_YELLOW\t\t\tYT921X_ACL_ACTa_COLOR(1)\n+#define YT921X_ACL_ACTa_COLOR_RED\t\t\tYT921X_ACL_ACTa_COLOR(2)\n+#define YT921X_ACL_ACTa_COLOR_EN\t\tBIT(28)\n+#define YT921X_ACL_ACTa_DSCP_M\t\t\tGENMASK(27, 22)\n+#define YT921X_ACL_ACTa_DSCP(x)\t\t\tFIELD_PREP(YT921X_ACL_ACTa_DSCP_M, (x))\n+#define YT921X_ACL_ACTa_DSCP_REPLACE\t\tBIT(21)\n+#define YT921X_ACL_ACTa_METER_ID_M\t\tGENMASK(20, 15)\n+#define YT921X_ACL_ACTa_METER_ID(x)\t\t\tFIELD_PREP(YT921X_ACL_ACTa_METER_ID_M, (x))\n+#define YT921X_ACL_ACTa_METER_EN\t\tBIT(14)\n+#define YT921X_ACL_ACTa_MIRROR_EN\t\tBIT(13)\n+#define YT921X_ACL_ACTa_FLOWSTAT_EN\t\tBIT(12)\n+#define YT921X_ACL_ACTa_FLOWSTAT_ID_M\t\tGENMASK(11, 6)\n+#define YT921X_ACL_ACTa_FLOWSTAT_ID(x)\t\tFIELD_PREP(YT921X_ACL_ACTa_FLOWSTAT_ID_M, (x))\n+#define YT921X_ACL_ACTa_GPIO_EN\t\tBIT(5)\n+#define YT921X_ACL_ACTa_GPIO_PIN_M\t\tGENMASK(4, 1)\n+#define YT921X_ACL_ACTa_GPIO_PIN(x)\t\t\tFIELD_PREP(YT921X_ACL_ACTa_GPIO_PIN_M, (x))\n+#define YT921X_ACL_ACTa_INTR_EN\t\tBIT(0)\n+#define YT921X_ACL_BLK_KEEP\t\t0x201000\n+#define YT921X_ACL_BLK_KEEP_GRPIDn_M(bin)\t(7 \u003c\u003c (4 * (bin) + 1))\n+#define YT921X_ACL_BLK_KEEP_GRPIDn(bin, x)\t\t((x) \u003c\u003c (4 * (bin) + 1))\n+#define YT921X_ACL_BLK_KEEP_KEEPn(bin)\t\tBIT(4 * (bin))\n+#define YT921X_ACL_PORT\t\t\t0x202000\n+#define YT921X_ACL_PORT_PORTS_M\t\tGENMASK(10, 0)\n+#define YT921X_ACL_PORT_PORTS(x)\t\t\tFIELD_PREP(YT921X_ACL_PORT_PORTS_M, (x))\n+#define YT921X_ACL_PORT_PORTn(port)\t\tBIT(port)\n+#define YT921X_ACL_BLK_CMD\t\t0x202004\n+#define YT921X_ACL_BLK_CMD_BLKID_M\t\tGENMASK(6, 1)\n+#define YT921X_ACL_BLK_CMD_BLKID(x)\t\t\tFIELD_PREP(YT921X_ACL_BLK_CMD_BLKID_M, (x))\n+#define YT921X_ACL_BLK_CMD_MODIFY\t\tBIT(0)\n+#define YT921X_ACLn_ENTRY(blk)\t\t(0x203000 + 4 * (blk))\n+#define YT921X_ACL_ENTRY_GRPIDm_M(bin)\t\t(7 \u003c\u003c (4 * (bin) + 1))\n+#define YT921X_ACL_ENTRY_GRPIDm(bin, x)\t\t((x) \u003c\u003c (4 * (bin) + 1))\n+#define YT921X_ACL_ENTRY_ENm(bin)\t\tBIT(4 * (bin))\n+#define YT921X_ACLn_KEYm(blk, bin)\t(0x204000 + 0x200 * (bin) + 8 * (blk))\n+#define YT921X_ACL_KEYb_ORD_M\t\t\tGENMASK(29, 21)\n+#define YT921X_ACL_KEYb_ORD(x)\t\t\tFIELD_PREP(YT921X_ACL_KEYb_ORD_M, (x))\n+#define YT921X_ACL_KEYb_SPORTS_M\t\tGENMASK(20, 10)\n+#define YT921X_ACL_KEYb_SPORTS(x)\t\t\tFIELD_PREP(YT921X_ACL_KEYb_SPORTS_M, (x))\n+#define YT921X_ACL_KEYb_SPORTn(port)\t\tBIT((port) + 10)\n+#define YT921X_ACL_KEYb_REVERSE\t\tBIT(9)\t/* reverse match */\n+#define YT921X_ACL_KEYb_TYPE_M\t\t\tGENMASK(8, 4)\n+#define YT921X_ACL_KEYb_TYPE(x)\t\t\tFIELD_PREP(YT921X_ACL_KEYb_TYPE_M, (x))\n+/* KEY_* fields need no masks */\n+#define YT921X_ACLn_MASKm(blk, bin)\t(0x205000 + 0x200 * (bin) + 8 * (blk))\n+\n+enum yt921x_acl_type {\n+\tYT921X_ACL_TYPE_NA,\n+\tYT921X_ACL_TYPE_MAC_DA0,\n+\tYT921X_ACL_TYPE_MAC_SA0,\n+\tYT921X_ACL_TYPE_MAC_DA1_SA1,\n+\tYT921X_ACL_TYPE_VLAN,\n+\tYT921X_ACL_TYPE_VTAG,\n+\tYT921X_ACL_TYPE_IPV4_DA,\n+\tYT921X_ACL_TYPE_IPV4_SA,\n+\tYT921X_ACL_TYPE_IPV6_DA0,\n+\tYT921X_ACL_TYPE_IPV6_DA1,\n+\tYT921X_ACL_TYPE_IPV6_DA2,\n+\tYT921X_ACL_TYPE_IPV6_DA3,\n+\tYT921X_ACL_TYPE_IPV6_SA0,\n+\tYT921X_ACL_TYPE_IPV6_SA1,\n+\tYT921X_ACL_TYPE_IPV6_SA2,\n+\tYT921X_ACL_TYPE_IPV6_SA3,\n+\tYT921X_ACL_TYPE_MISC,\n+\tYT921X_ACL_TYPE_L4,\n+\tYT921X_ACL_TYPE_UDF0,\n+\tYT921X_ACL_TYPE_UDF1,\n+\tYT921X_ACL_TYPE_UDF2,\n+\tYT921X_ACL_TYPE_UDF3,\n+\tYT921X_ACL_TYPE_UDF4,\n+\tYT921X_ACL_TYPE_UDF5,\n+\tYT921X_ACL_TYPE_UDF6,\n+\tYT921X_ACL_TYPE_UDF7,\n+\tYT921X_ACL_TYPE_ETHERTYPE,\n+\tYT921X_ACL_TYPE_NUM\n+};\n+\n+/* Range: turn KEY:MASK into MIN:MAX */\n+\n+#define YT921X_ACL_BINb_MAC_xA0_L3_TYPE_M\tGENMASK(3, 0)\n+#define YT921X_ACL_BINb_MAC_xA0_L3_TYPE(x)\t\tFIELD_PREP(YT921X_ACL_BINb_MAC_xA0_L3_TYPE_M, (x))\n+#define YT921X_ACL_BINa_MAC_xA0_MAC_xA0_M\tGENMASK(31, 0)\n+\n+#define YT921X_ACL_BINb_MAC_DA1_SA1_L2_TYPE_M\tGENMASK(2, 0)\n+#define YT921X_ACL_BINb_MAC_DA1_SA1_L2_TYPE(x)\tFIELD_PREP(YT921X_ACL_BINb_MAC_DA1_SA1_L2_TYPE_M, (x))\n+#define YT921X_ACL_BINa_MAC_DA1_SA1_MAC_DA1_M\tGENMASK(31, 16)\n+#define YT921X_ACL_BINa_MAC_DA1_SA1_MAC_SA1_M\tGENMASK(15, 0)\n+\n+#define YT921X_ACL_KEYb_VLAN_SVID_RANGE_EN\tBIT(31)\n+#define YT921X_ACL_KEYb_VLAN_CVID_RANGE_EN\tBIT(30)\n+#define YT921X_ACL_BINb_VLAN_CDEI\t\tBIT(3)\n+#define YT921X_ACL_BINb_VLAN_CPRI_M\t\tGENMASK(2, 0)\n+#define YT921X_ACL_BINb_VLAN_CPRI(x)\t\t\tFIELD_PREP(YT921X_ACL_BINb_VLAN_CPRI_M, (x))\n+#define YT921X_ACL_BINa_VLAN_CTAG_FMT_M\tGENMASK(31, 30)\n+#define YT921X_ACL_BINa_VLAN_CTAG_FMT(x)\t\tFIELD_PREP(YT921X_ACL_BINa_VLAN_CTAG_FMT_M, (x))\n+#define YT921X_ACL_BINa_VLAN_SDEI\t\tBIT(29)\n+#define YT921X_ACL_BINa_VLAN_SPRI_M\t\tGENMASK(28, 26)\n+#define YT921X_ACL_BINa_VLAN_SPRI(x)\t\t\tFIELD_PREP(YT921X_ACL_BINa_VLAN_SPRI_M, (x))\n+#define YT921X_ACL_BINa_VLAN_STAG_FMT_M\tGENMASK(25, 24)\n+#define YT921X_ACL_BINa_VLAN_STAG_FMT(x)\t\tFIELD_PREP(YT921X_ACL_BINa_VLAN_STAG_FMT_M, (x))\n+#define YT921X_ACL_BINa_VLAN_SVID_M\t\tGENMASK(23, 12)\n+#define YT921X_ACL_BINa_VLAN_SVID(x)\t\t\tFIELD_PREP(YT921X_ACL_BINa_VLAN_SVID_M, (x))\n+#define YT921X_ACL_BINa_VLAN_CVID_M\t\tGENMASK(11, 0)\n+#define YT921X_ACL_BINa_VLAN_CVID(x)\t\t\tFIELD_PREP(YT921X_ACL_BINa_VLAN_CVID_M, (x))\n+\n+#define YT921X_ACL_KEYb_VTAG_SVID_RANGE_EN\tBIT(31)\n+#define YT921X_ACL_KEYb_VTAG_CVID_RANGE_EN\tBIT(30)\n+#define YT921X_ACL_BINa_VTAG_CDEI\t\tBIT(31)\n+#define YT921X_ACL_BINa_VTAG_CPRI_M\t\tGENMASK(30, 28)\n+#define YT921X_ACL_BINa_VTAG_CPRI(x)\t\t\tFIELD_PREP(YT921X_ACL_BINa_VTAG_CPRI_M, (x))\n+#define YT921X_ACL_BINa_VTAG_SDEI\t\tBIT(27)\n+#define YT921X_ACL_BINa_VTAG_SPRI_M\t\tGENMASK(26, 24)\n+#define YT921X_ACL_BINa_VTAG_SPRI(x)\t\t\tFIELD_PREP(YT921X_ACL_BINa_VTAG_SPRI_M, (x))\n+#define YT921X_ACL_BINa_VTAG_SVID_M\t\tGENMASK(23, 12)\n+#define YT921X_ACL_BINa_VTAG_SVID(x)\t\t\tFIELD_PREP(YT921X_ACL_BINa_VTAG_SVID_M, (x))\n+#define YT921X_ACL_BINa_VTAG_CVID_M\t\tGENMASK(11, 0)\n+#define YT921X_ACL_BINa_VTAG_CVID(x)\t\t\tFIELD_PREP(YT921X_ACL_BINa_VTAG_CVID_M, (x))\n+\n+#define YT921X_ACL_KEYb_IPV4_ADDR_RANGE_EN\tBIT(30)\n+#define YT921X_ACL_BINb_IPV4_FRAG\t\tBIT(3)\n+#define YT921X_ACL_BINb_IPV4_L4_TYPE_M\t\tGENMASK(2, 0)\n+#define YT921X_ACL_BINb_IPV4_L4_TYPE(x)\t\tFIELD_PREP(YT921X_ACL_BINb_IPV4_L4_TYPE_M, (x))\n+#define YT921X_ACL_BINa_IPV4_ADDR_M\t\tGENMASK(31, 0)\n+\n+#define YT921X_ACL_BINb_IPV6_L4_TYPE_M\t\tGENMASK(2, 0)\n+#define YT921X_ACL_BINb_IPV6_L4_TYPE(x)\t\tFIELD_PREP(YT921X_ACL_BINb_IPV6_L4_TYPE_M, (x))\n+#define YT921X_ACL_BINa_IPV6_ADDRx_M\t\tGENMASK(31, 0)\n+\n+#define YT921X_ACL_BINb_IPV6_xA1_IP_OPTION\tBIT(3)\n+\n+#define YT921X_ACL_BINb_IPV6_xA2_FIRST_FRAG\tBIT(3)\n+\n+#define YT921X_ACL_KEYb_IPV6_xA3_ADDR_RANGE_EN\tBIT(30)\n+#define YT921X_ACL_BINb_IPV6_xA3_FRAG\t\tBIT(3)\n+\n+#define YT921X_ACL_BINb_MISC_FRAG\t\tBIT(3)\n+#define YT921X_ACL_BINb_MISC_L4_TYPE_M\t\tGENMASK(2, 0)\n+#define YT921X_ACL_BINb_MISC_L4_TYPE(x)\t\tFIELD_PREP(YT921X_ACL_BINb_MISC_L4_TYPE_M, (x))\n+#define YT921X_ACL_BINa_MISC_PPPOE_FLAG\tBIT(30)\n+#define YT921X_ACL_BINa_MISC_FIRST_FRAG\tBIT(29)\n+#define YT921X_ACL_BINa_MISC_IP_OPTION\t\tBIT(28)\n+#define YT921X_ACL_BINa_MISC_TCP_FLAGS_M\tGENMASK(27, 20)\n+#define YT921X_ACL_BINa_MISC_TCP_FLAGS(x)\t\tFIELD_PREP(YT921X_ACL_BINa_MISC_TCP_FLAGS_M, (x))\n+#define YT921X_ACL_BINa_MISC_IP_PROTO_M\tGENMASK(19, 12)\n+#define YT921X_ACL_BINa_MISC_IP_PROTO(x)\t\tFIELD_PREP(YT921X_ACL_BINa_MISC_IP_PROTO_M, (x))\n+#define YT921X_ACL_BINa_MISC_TOS_M\t\tGENMASK(11, 4)\n+#define YT921X_ACL_BINa_MISC_TOS(x)\t\t\tFIELD_PREP(YT921X_ACL_BINa_MISC_TOS_M, (x))\n+#define YT921X_ACL_BINa_MISC_L3_TYPE_M\t\tGENMASK(3, 0)\n+#define YT921X_ACL_BINa_MISC_L3_TYPE(x)\t\tFIELD_PREP(YT921X_ACL_BINa_MISC_L3_TYPE_M, (x))\n+\n+#define YT921X_ACL_KEYb_L4_DPORT_RANGE_EN\tBIT(31)\n+#define YT921X_ACL_KEYb_L4_SPORT_RANGE_EN\tBIT(30)\n+#define YT921X_ACL_BINb_L4_FRAG\t\tBIT(3)\n+#define YT921X_ACL_BINb_L4_TYPE_M\t\tGENMASK(2, 0)\n+#define YT921X_ACL_BINb_L4_TYPE(x)\t\t\tFIELD_PREP(YT921X_ACL_BINb_L4_TYPE_M, (x))\n+#define YT921X_ACL_BINa_L4_DPORT_M\t\tGENMASK(31, 16)\n+#define YT921X_ACL_BINa_L4_SPORT_M\t\tGENMASK(15, 0)\n+\n+#define YT921X_ACL_BINb_UDF_IS_IGMP\t\tBIT(0)\n+#define YT921X_ACL_BINa_UDF_UDF0_M\t\tGENMASK(31, 16)\n+#define YT921X_ACL_BINa_UDF_UDF0(x)\t\t\tFIELD_PREP(YT921X_ACL_BINa_UDF_UDF0_M, (x))\n+#define YT921X_ACL_BINa_UDF_UDF1_M\t\tGENMASK(15, 0)\n+#define YT921X_ACL_BINa_UDF_UDF1(x)\t\t\tFIELD_PREP(YT921X_ACL_BINa_UDF_UDF1_M, (x))\n+\n+#define YT921X_ACL_KEYb_ETHERTYPE_ETHERTYPE_RANGE_EN\tBIT(30)\n+#define YT921X_ACL_BINb_ETHERTYPE_L4_TYPE_M\tGENMASK(2, 0)\n+#define YT921X_ACL_BINb_ETHERTYPE_L4_TYPE(x)\t\tFIELD_PREP(YT921X_ACL_BINb_ETHERTYPE_L4_TYPE_M, (x))\n+#define YT921X_ACL_BINa_ETHERTYPE_ETHERTYPE_M\tGENMASK(15, 0)\n+#define YT921X_ACL_BINa_ETHERTYPE_ETHERTYPE(x)\tFIELD_PREP(YT921X_ACL_BINa_ETHERTYPE_ETHERTYPE_M, (x))\n+\n+enum yt921x_l2_type {\n+\tYT921X_L2_TYPE_ETH,\n+\tYT921X_L2_TYPE_ETHV2,\n+\tYT921X_L2_TYPE_ETHSAP,\n+\tYT921X_L2_TYPE_ETHSNAP,\n+};\n+\n+enum yt921x_l3_type {\n+\tYT921X_L3_TYPE_OTHER,\n+\tYT921X_L3_TYPE_IPV4,\n+\tYT921X_L3_TYPE_IPV6,\n+\tYT921X_L3_TYPE_ARP,\n+\tYT921X_L3_TYPE_LLDP,\n+\tYT921X_L3_TYPE_PAE,\n+\tYT921X_L3_TYPE_ERP,\n+\tYT921X_L3_TYPE_SLOW_PROTOCOL,\n+};\n+\n+enum yt921x_l4_type {\n+\tYT921X_L4_TYPE_OTHER,\n+\tYT921X_L4_TYPE_TCP,\n+\tYT921X_L4_TYPE_UDP,\n+\tYT921X_L4_TYPE_UDPLITE,\n+\tYT921X_L4_TYPE_ICMP,\n+\tYT921X_L4_TYPE_IGMP,\n+\tYT921X_L4_TYPE_MLD,\n+\tYT921X_L4_TYPE_ND,\n+};\n+\n+#define YT921X_UDFn_CTRL(x)\t\t(0x210094 + 4 * (x))\n+#define YT921X_UDF_CTRL_UDF_TYPE_M\t\tGENMASK(8, 7)\n+#define YT921X_UDF_CTRL_UDF_TYPE(x)\t\t\tFIELD_PREP(YT921X_UDF_CTRL_UDF_TYPE_M, (x))\n+#define YT921X_UDF_CTRL_UDF_TYPE_ETH\t\t\tYT921X_UDF_CTRL_UDF_TYPE(0)\n+#define YT921X_UDF_CTRL_UDF_TYPE_L3\t\t\tYT921X_UDF_CTRL_UDF_TYPE(1)\n+#define YT921X_UDF_CTRL_UDF_TYPE_L4\t\t\tYT921X_UDF_CTRL_UDF_TYPE(2)\n+#define YT921X_UDF_CTRL_UDF_OFFSET_M\t\tGENMASK(6, 0)\n+#define YT921X_UDF_CTRL_UDF_OFFSET(x)\t\t\tFIELD_PREP(YT921X_UDF_CTRL_UDF_OFFSET_M, (x))\n+\n+#define YT921X_PORTn_RATE(port)\t\t(0x220000 + 4 * (port))\n+#define YT921X_PORT_RATE_GAP_VALUE\t\tGENMASK(4, 0)\t/* default 20 */\n+#define YT921X_METER_SLOT\t\t0x220104\n+#define YT921X_METER_SLOT_SLOT_M\t\tGENMASK(11, 0)\n+#define YT921X_PORTn_METER(port)\t(0x220108 + 4 * (port))\n+#define YT921X_PORT_METER_EN\t\t\tBIT(4)\n+#define YT921X_PORT_METER_ID_M\t\t\tGENMASK(3, 0)\n+#define YT921X_PORT_METER_ID(x)\t\t\tFIELD_PREP(YT921X_PORT_METER_ID_M, (x))\n+#define YT921X_METERn_CTRL(x)\t\t(0x220800 + 0x10 * (x))\n+#define YT921X_METER_CTRLc_METER_EN\t\tBIT(14)\n+#define YT921X_METER_CTRLc_TOKEN_OVERFLOW_EN\tBIT(13)\t/* RFC4115: yellow use unused green bw */\n+#define YT921X_METER_CTRLc_DROP_M\t\tGENMASK(12, 11)\n+#define YT921X_METER_CTRLc_DROP(x)\t\t\tFIELD_PREP(YT921X_METER_CTRLc_DROP_M, (x))\n+#define YT921X_METER_CTRLc_DROP_GYR\t\t\tYT921X_METER_CTRLc_DROP(0)\n+#define YT921X_METER_CTRLc_DROP_YR\t\t\tYT921X_METER_CTRLc_DROP(1)\n+#define YT921X_METER_CTRLc_DROP_R\t\t\tYT921X_METER_CTRLc_DROP(2)\n+#define YT921X_METER_CTRLc_DROP_NONE\t\t\tYT921X_METER_CTRLc_DROP(3)\n+#define YT921X_METER_CTRLc_COLOR_BLIND\t\tBIT(10)\n+#define YT921X_METER_CTRLc_UNIT_M\t\tGENMASK(9, 7)\n+#define YT921X_METER_CTRLc_UNIT(x)\t\t\tFIELD_PREP(YT921X_METER_CTRLc_UNIT_M, (x))\n+#define YT921X_METER_CTRLc_BYTE_MODE_INCLUDE_GAP\tBIT(6)\t/* +GAP_VALUE bytes each packet */\n+#define YT921X_METER_CTRLc_PKT_MODE\t\tBIT(5)\t/* 0: byte rate mode */\n+#define YT921X_METER_CTRLc_RFC2698\t\tBIT(4)\t/* 0: RFC4115 */\n+#define YT921X_METER_CTRLbc_CBS_M\t\tGENMASK_ULL(35, 20)\n+#define YT921X_METER_CTRLbc_CBS(x)\t\t\tFIELD_PREP(YT921X_METER_CTRLbc_CBS_M, (x))\n+#define YT921X_METER_CTRLb_CIR_M\t\tGENMASK(19, 2)\n+#define YT921X_METER_CTRLb_CIR(x)\t\t\tFIELD_PREP(YT921X_METER_CTRLb_CIR_M, (x))\n+#define YT921X_METER_CTRLab_EBS_M\t\tGENMASK_ULL(33, 18)\n+#define YT921X_METER_CTRLab_EBS(x)\t\t\tFIELD_PREP(YT921X_METER_CTRLab_EBS_M, (x))\n+#define YT921X_METER_CTRLa_EIR_M\t\tGENMASK(17, 0)\n+#define YT921X_METER_CTRLa_EIR(x)\t\t\tFIELD_PREP(YT921X_METER_CTRLa_EIR_M, (x))\n+#define YT921X_METERn_STAT(x)\t\t(0x221000 + 8 * (x))\n+\n+#define YT921X_MIRROR\t\t\t0x300300\n+#define YT921X_MIRROR_IGR_PORTS_M\t\tGENMASK(26, 16)\n+#define YT921X_MIRROR_IGR_PORTS(x)\t\t\tFIELD_PREP(YT921X_MIRROR_IGR_PORTS_M, (x))\n+#define YT921X_MIRROR_IGR_PORTn(port)\t\tBIT((port) + 16)\n+#define YT921X_MIRROR_EGR_PORTS_M\t\tGENMASK(14, 4)\n+#define YT921X_MIRROR_EGR_PORTS(x)\t\t\tFIELD_PREP(YT921X_MIRROR_EGR_PORTS_M, (x))\n+#define YT921X_MIRROR_EGR_PORTn(port)\t\tBIT((port) + 4)\n+#define YT921X_MIRROR_PORT_M\t\t\tGENMASK(3, 0)\n+#define YT921X_MIRROR_PORT(x)\t\t\t\tFIELD_PREP(YT921X_MIRROR_PORT_M, (x))\n+\n+#define YT921X_PORT_SHAPE_SLOT\t\t0x34000c\n+#define YT921X_PORT_SHAPE_SLOT_SLOT_M\t\tGENMASK(11, 0)\n+#define YT921X_PORTn_SHAPE_CTRL(port)\t(0x354000 + 8 * (port))\n+#define YT921X_PORT_SHAPE_CTRLb_EN\t\tBIT(4)\n+#define YT921X_PORT_SHAPE_CTRLb_PKT_MODE\tBIT(3)\t/* 0: byte rate mode */\n+#define YT921X_PORT_SHAPE_CTRLb_UNIT_M\t\tGENMASK(2, 0)\n+#define YT921X_PORT_SHAPE_CTRLb_UNIT(x)\t\tFIELD_PREP(YT921X_PORT_SHAPE_CTRLb_UNIT_M, (x))\n+#define YT921X_PORT_SHAPE_CTRLa_CBS_M\t\tGENMASK(31, 18)\n+#define YT921X_PORT_SHAPE_CTRLa_CBS(x)\t\tFIELD_PREP(YT921X_PORT_SHAPE_CTRLa_CBS_M, (x))\n+#define YT921X_PORT_SHAPE_CTRLa_CIR_M\t\tGENMASK(17, 0)\n+#define YT921X_PORT_SHAPE_CTRLa_CIR(x)\t\tFIELD_PREP(YT921X_PORT_SHAPE_CTRLa_CIR_M, (x))\n+#define YT921X_PORTn_SHAPE_STAT(port)\t(0x356000 + 4 * (port))\n+\n+#define YT921X_TOKEN_BYTE_C\t1\t/* 1 token = 2^1 byte */\n+#define YT921X_TOKEN_PKT_C\t-6\t/* 1 token = 2^-6 packets */\n+#define YT921X_TOKEN_RATE_C\t-15\n+#define YT921X_METER_SLOT_MIN\t80\n+#define YT921X_METER_UNIT_MAX\t((1 \u003c\u003c 3) - 1)\n+#define YT921X_METER_CIR_MAX\t((1 \u003c\u003c 18) - 1)\n+#define YT921X_METER_CBS_MAX\t((1 \u003c\u003c 16) - 1)\n+#define YT921X_PORT_SHAPE_SLOT_MIN\t80\n+#define YT921X_SHAPE_UNIT_MAX\t((1 \u003c\u003c 3) - 1)\n+#define YT921X_SHAPE_CIR_MAX\t((1 \u003c\u003c 18) - 1)\n+#define YT921X_SHAPE_CBS_MAX\t((1 \u003c\u003c 14) - 1)\n+\n+#define YT921X_ACL_ENT_PER_BLK\t8\n+#define YT921X_ACL_NUM\t\t384\n+#define YT921X_ACL_ORD_NUM\t512\n+#define YT921X_UDF_NUM\t\t8\n+\n+struct yt921x_acl_entry {\n+\tu32 key[2];\n+\tu32 mask[2];\n+};\n+\n+struct yt921x_acl_rule {\n+\tunsigned long tag;\n+\tenum tc_setup_type type;\n+\n+\tu32 action[3];\n+\tbool sw_assisted;\n+\n+\tu8 mask;\n+\tstruct yt921x_acl_entry entries[YT921X_ACL_ENT_PER_BLK];\n+};\n+\n+struct yt921x_acl_blk {\n+\tstruct yt921x_acl_rule *rules[YT921X_ACL_ENT_PER_BLK];\n+};\n+\n+void yt921x_dsa_port_policer_del(struct dsa_switch *ds, int port);\n+int\n+yt921x_dsa_port_policer_add(struct dsa_switch *ds, int port,\n+\t\t\t const struct flow_action_police *police,\n+\t\t\t struct netlink_ext_ack *extack);\n+int\n+yt921x_dsa_port_setup_tc(struct dsa_switch *ds, int port,\n+\t\t\t enum tc_setup_type type, void *type_data);\n+int\n+yt921x_dsa_cls_flower_del(struct dsa_switch *ds, int port,\n+\t\t\t struct flow_cls_offload *cls, bool ingress);\n+int\n+yt921x_dsa_cls_flower_add(struct dsa_switch *ds, int port,\n+\t\t\t struct flow_cls_offload *cls, bool ingress);\n+void\n+yt921x_dsa_port_mirror_del(struct dsa_switch *ds, int port,\n+\t\t\t struct dsa_mall_mirror_tc_entry *mirror);\n+int\n+yt921x_dsa_port_mirror_add(struct dsa_switch *ds, int port,\n+\t\t\t struct dsa_mall_mirror_tc_entry *mirror,\n+\t\t\t bool ingress, struct netlink_ext_ack *extack);\n+\n+#endif\n"
} |
| 2/1 | 2026/10/02 16:17 | agent | patch-evaluator |
1mModel:core Args: null Results: {
"EnableConfigs": null,
"FocusSymbols": [],
"Reasoning": "The patch series refactors TC and ACL handling and updates ACL port activation logic in the Motorcomm YT9215 Ethernet switch driver (drivers/net/dsa/motorcomm/). This driver requires a physical Motorcomm YT9215 switch ASIC on an MDIO bus with matching device tree bindings, which is not emulated in standard QEMU/virtualized environments. Thus, the modified code is structurally unreachable hardware and does not warrant fuzzing.",
"WorthFuzzing": false
}Instruction: You are an expert Linux kernel maintainer and security engineer.
Your job is to review a provided patch series and evaluate whether it warrants fuzzing with syzkaller.
IMPORTANT: The changes have ALREADY been applied and committed as the HEAD commit in
your workspace. Do NOT rely on internal assumptions. You must actively use your code access
tools to inspect the actual source code, callers, and surrounding context.
================================================================================
1. CORE TRIAGE PHILOSOPHY
================================================================================
The goal of patch fuzzing is to discover crashes, regressions, exposed latent bugs,
and newly triggered assertions introduced by the patch series.
- REACHABILITY IS THE PRIMARY GATE:
Fuzzing can only discover bugs in code that can actually execute in standard virtualized
environments (GCE or QEMU, utilizing software-emulated devices like USB gadgets, netdev, tun/tap).
If the modified code is structurally unreachable (see Section 2), it MUST NOT be fuzzed,
regardless of whether it adds assertions or complex logic.
- DO NOT BLINDLY TRUST "NO FUNCTIONAL CHANGE" (NFCI) OR "REFACTORING" CLAIMS:
Patch authors routinely label changes as "cleanups", "refactorings", or state
"No functional change intended". Do NOT take these claims at face value.
Code refactorings that rearrange logic, introduce helper functions, or alter state management
in core subsystems frequently introduce subtle semantic shifts or uncover latent kernel bugs.
If reachable executable code is modified or refactored, it MUST be fuzzed.
- NEW OR MODIFIED ASSERTIONS IN REACHABLE CODE MUST BE FUZZED:
When a patch introduces or modifies runtime checks or assertions (e.g., WARN_ON*, VM_WARN_ON*,
BUG_ON*, lockdep_assert*) in reachable code paths, it enforces new or stricter invariants.
Even if the author believes the invariant always holds, fuzzing is essential to verify whether
an unusual sequence of operations can violate it.
================================================================================
2. WHEN TO RETURN WorthFuzzing=false (NEGATIVE CRITERIA)
================================================================================
Return WorthFuzzing=false ONLY IF all modified code falls strictly into one or more of these categories:
- Non-kernel and non-executable changes:
* Modifications to Documentation/, comments, or spelling fixes.
* User-space directories, self-tests, samples, or scripts (e.g., tools/, samples/, scripts/, usr/)
that do not affect the compiled kernel image (vmlinux) or kernel modules.
* Purely decorative logging (e.g., message strings in pr_err, printk, dev_info) or tracepoints
that do not alter control flow or data structures.
* Build system or Kconfig changes that do not alter compiled C logic.
- Structurally unreachable hardware:
* Vendor-specific PCIe switches, SmartNICs, or GPU drivers (e.g., mlxsw, pds_core, qed,
ionic, amdgpu) requiring physical ASIC/PCIe cards not emulated in standard QEMU.
- Unreachable execution paths:
* Driver teardown callbacks (.remove, .shutdown, pci_unregister_driver) executed only during
physical PCI hot-unplug or manual sysfs driver unbinding.
* Code paths exclusive to architectures other than the target architecture.
================================================================================
3. WHEN TO RETURN WorthFuzzing=true (POSITIVE CRITERIA)
================================================================================
Return WorthFuzzing=true whenever the patch touches reachable executable code, including:
- Core Subsystems:
* Any logic modifications in memory management (mm/), synchronization/locking (kernel/locking/),
BPF, scheduler, core networking, VFS, or syscall handling.
- Refactorings and Code Cleanups:
* Any restructuring of reachable data structures, helper abstractions, or algorithm flows.
- Runtime Assertions and Defensive Checks:
* Any introduction or alteration of assertions (WARN_ON*, VM_WARN_ON*, BUG_ON*, etc.) in reachable paths.
- Reachable Drivers and Protocols:
* Drivers accessible via virtual buses (virtio, USB gadget, loopback, netlink, binder, sockets, etc.).
================================================================================
4. EXTRACTING FocusSymbols (PREVENTING DILUTION)
================================================================================
When WorthFuzzing=true, you must extract specific kernel functions into FocusSymbols to guide the fuzzer:
- AVOID UBIQUITOUS LIFECYCLE HOT-PATHS:
Do NOT list generic, ubiquitous functions called by almost every program in the corpus
(including, but not limited to: general memory allocators and deallocators, page fault
and trap handlers, or core synchronization primitives; this is not an exhaustive list).
Listing ubiquitous functions causes the fuzzer to classify thousands of unrelated tests as "focused",
which severely dilutes fuzzing effort away from the actual changes.
- TARGET SPECIFIC FEATURE LOGIC AND ENTRYPOINTS:
List functions that specifically implement the logic being added or altered, or direct API entrypoints
for the subsystem feature under review.
- HANDLING STATIC INLINE FUNCTIONS IN HEADERS (.h):
Compiler-inlined static functions (such as static inlines in mm/*.h or include/linux/*.h) lack
distinct symbol addresses in vmlinux and cannot be targeted directly by symbol coverage filters.
If the changes are primarily in static inline helpers, identify non-static, feature-specific caller
functions in .c files that exercise them (avoiding ubiquitous lifecycle wrappers).
================================================================================
5. IDENTIFYING EnableConfigs
================================================================================
Identify any specific CONFIG_ options required to properly compile and reach the modified code:
- Inspect Kconfig files and #ifdef guards; do not make assumptions.
- Check "depends on" lines in Kconfig to include any non-standard parent subsystem configs needed.
- Strip any 'CONFIG_' prefix (e.g., return "NET_IPV4" instead of "CONFIG_NET_IPV4").
Prefer calling several tools at the same time to save round-trips.
Use set-results tool to provide results of the analysis.
It must be called exactly once before the final reply.
Ignore results of this tool.
Prompt: Target architecture: amd64
For your convenience, here is the diff of the changes:
commit 71e25225fb34cd132334bf068343c5e16cab4b5b
Author: syz-cluster <triage@syzkaller.com>
Date: Fri Oct 2 16:17:28 2026 +0000
syz-cluster: applied patch under review
diff --git a/drivers/net/dsa/motorcomm/Makefile b/drivers/net/dsa/motorcomm/Makefile
index 1d2c1b3064c41..b4a577012b0fb 100644
--- a/drivers/net/dsa/motorcomm/Makefile
+++ b/drivers/net/dsa/motorcomm/Makefile
@@ -5,3 +5,4 @@ yt921x-$(CONFIG_NET_DSA_YT921X_LEDS) += leds.o
yt921x-objs += mdio_bus.o
yt921x-objs += pcs-921x.o
yt921x-objs += smi.o
+yt921x-objs += tc.o
diff --git a/drivers/net/dsa/motorcomm/chip.c b/drivers/net/dsa/motorcomm/chip.c
index 3ff2de383157a..4b8cb2ba28b73 100644
--- a/drivers/net/dsa/motorcomm/chip.c
+++ b/drivers/net/dsa/motorcomm/chip.c
@@ -23,13 +23,13 @@
#include <net/dsa.h>
#include <net/dscp.h>
#include <net/ieee8021q.h>
-#include <net/pkt_cls.h>
#include "chip.h"
#include "leds.h"
#include "mdio_bus.h"
#include "pcs.h"
#include "smi.h"
+#include "tc.h"
struct yt921x_mib_desc {
unsigned int size;
@@ -171,19 +171,6 @@ struct yt921x_reg_mdio {
/* TODO: SPI/I2C */
-#define to_yt921x_priv(_ds) container_of_const(_ds, struct yt921x_priv, ds)
-#define to_device(priv) ((priv)->ds.dev)
-
-static u32 ethaddr_hi4_to_u32(const unsigned char *addr)
-{
- return (addr[0] << 24) | (addr[1] << 16) | (addr[2] << 8) | addr[3];
-}
-
-static u32 ethaddr_lo2_to_u32(const unsigned char *addr)
-{
- return (addr[4] << 8) | addr[5];
-}
-
static int yt921x_reg_mdio_read(void *context, u32 reg, u32 *valp)
{
struct yt921x_reg_mdio *mdio = context;
@@ -272,7 +259,7 @@ static const struct yt921x_reg_ops yt921x_reg_ops_mdio = {
static int yt921x_read_mib(struct yt921x_priv *priv, int port)
{
struct yt921x_port *pp = &priv->ports[port];
- struct device *dev = to_device(priv);
+ struct device *dev = yt921x_priv_to_device(priv);
struct yt921x_mib *mib = &pp->mib;
int res = 0;
@@ -364,7 +351,7 @@ yt921x_dsa_get_strings(struct dsa_switch *ds, int port, u32 stringset,
static void
yt921x_dsa_get_ethtool_stats(struct dsa_switch *ds, int port, uint64_t *data)
{
- struct yt921x_priv *priv = to_yt921x_priv(ds);
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(ds);
struct yt921x_port *pp = &priv->ports[port];
struct yt921x_mib *mib = &pp->mib;
size_t j;
@@ -406,7 +393,7 @@ static void
yt921x_dsa_get_eth_mac_stats(struct dsa_switch *ds, int port,
struct ethtool_eth_mac_stats *mac_stats)
{
- struct yt921x_priv *priv = to_yt921x_priv(ds);
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(ds);
struct yt921x_port *pp = &priv->ports[port];
struct yt921x_mib *mib = &pp->mib;
@@ -442,7 +429,7 @@ static void
yt921x_dsa_get_eth_ctrl_stats(struct dsa_switch *ds, int port,
struct ethtool_eth_ctrl_stats *ctrl_stats)
{
- struct yt921x_priv *priv = to_yt921x_priv(ds);
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(ds);
struct yt921x_port *pp = &priv->ports[port];
struct yt921x_mib *mib = &pp->mib;
@@ -471,7 +458,7 @@ yt921x_dsa_get_rmon_stats(struct dsa_switch *ds, int port,
struct ethtool_rmon_stats *rmon_stats,
const struct ethtool_rmon_hist_range **ranges)
{
- struct yt921x_priv *priv = to_yt921x_priv(ds);
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(ds);
struct yt921x_port *pp = &priv->ports[port];
struct yt921x_mib *mib = &pp->mib;
@@ -507,7 +494,7 @@ static void
yt921x_dsa_get_stats64(struct dsa_switch *ds, int port,
struct rtnl_link_stats64 *stats)
{
- struct yt921x_priv *priv = to_yt921x_priv(ds);
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(ds);
struct yt921x_port *pp = &priv->ports[port];
struct yt921x_mib *mib = &pp->mib;
@@ -543,7 +530,7 @@ static void
yt921x_dsa_get_pause_stats(struct dsa_switch *ds, int port,
struct ethtool_pause_stats *pause_stats)
{
- struct yt921x_priv *priv = to_yt921x_priv(ds);
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(ds);
struct yt921x_port *pp = &priv->ports[port];
struct yt921x_mib *mib = &pp->mib;
@@ -598,7 +585,7 @@ yt921x_set_eee(struct yt921x_priv *priv, int port, struct ethtool_keee *e)
static int
yt921x_dsa_set_mac_eee(struct dsa_switch *ds, int port, struct ethtool_keee *e)
{
- struct yt921x_priv *priv = to_yt921x_priv(ds);
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(ds);
int res;
mutex_lock(&priv->reg_lock);
@@ -608,13 +595,6 @@ yt921x_dsa_set_mac_eee(struct dsa_switch *ds, int port, struct ethtool_keee *e)
return res;
}
-static int yt921x_mtu_fetch(struct yt921x_priv *priv, int port)
-{
- struct dsa_port *dp = dsa_to_port(&priv->ds, port);
-
- return dp->user ? READ_ONCE(dp->user->mtu) : ETH_DATA_LEN;
-}
-
static int
yt921x_dsa_port_change_mtu(struct dsa_switch *ds, int port, int new_mtu)
{
@@ -622,7 +602,7 @@ yt921x_dsa_port_change_mtu(struct dsa_switch *ds, int port, int new_mtu)
* maximum after reset
*/
- struct yt921x_priv *priv = to_yt921x_priv(ds);
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(ds);
struct dsa_port *dp = dsa_to_port(ds, port);
int frame_size;
int res;
@@ -646,1445 +626,6 @@ static int yt921x_dsa_port_max_mtu(struct dsa_switch *ds, int port)
return YT921X_FRAME_SIZE_MAX - ETH_HLEN - ETH_FCS_LEN - YT921X_TAG_LEN;
}
-/* v * 2^e */
-static u64 ldexpu64(u64 v, int e)
-{
- return e >= 0 ? v << e : v >> -e;
-}
-
-/* slot (ns) * rate (/s) / 10^9 (ns/s) = 2^C * token * 4^unit */
-static u32 rate2token(u64 rate, unsigned int slot_ns, int unit, int C)
-{
- int e = 2 * unit + C + YT921X_TOKEN_RATE_C;
-
- return div_u64(ldexpu64(slot_ns * rate, -e), 1000000000);
-}
-
-static u64 token2rate(u32 token, unsigned int slot_ns, int unit, int C)
-{
- int e = 2 * unit + C + YT921X_TOKEN_RATE_C;
-
- return div_u64(ldexpu64(mul_u32_u32(1000000000, token), e), slot_ns);
-}
-
-/* burst = 2^C * token * 4^unit */
-static u32 burst2token(u64 burst, int unit, int C)
-{
- return ldexpu64(burst, -(2 * unit + C));
-}
-
-static u64 token2burst(u32 token, int unit, int C)
-{
- return ldexpu64(token, 2 * unit + C);
-}
-
-struct yt921x_marker {
- u32 cir;
- u32 cbs;
- u32 ebs;
- int unit;
- bool pkt_mode;
-};
-
-#define YT921X_MARKER_PKT_MODE BIT(0)
-#define YT921X_MARKER_SINGLE_BUCKET BIT(1)
-
-static int
-yt921x_marker_tfm(struct yt921x_marker *marker, u64 rate, u64 burst,
- unsigned int flags, unsigned int slot_ns, u32 cir_max,
- u32 cbs_max, int unit_max, struct yt921x_priv *priv, int port,
- struct netlink_ext_ack *extack)
-{
- const int C = flags & YT921X_MARKER_PKT_MODE ? YT921X_TOKEN_PKT_C :
- YT921X_TOKEN_BYTE_C;
- struct device *dev = to_device(priv);
- struct yt921x_marker m;
- u64 burst_est;
- u64 burst_sug;
- u64 burst_max;
- u64 rate_max;
-
- m.unit = unit_max;
- rate_max = token2rate(cir_max, slot_ns, m.unit, C);
- burst_max = token2burst(cbs_max, m.unit, C);
-
- /* Check for unusual values */
- if (rate > rate_max || burst > burst_max) {
- NL_SET_ERR_MSG_MOD(extack, "Unexpected tremendous rate");
- return -ERANGE;
- }
-
- /* Check for matching burst */
- burst_est = div_u64(slot_ns * rate, 1000000000);
- burst_sug = burst_est;
- if (flags & YT921X_MARKER_PKT_MODE)
- burst_sug++;
- else
- burst_sug += ETH_HLEN + yt921x_mtu_fetch(priv, port) +
- ETH_FCS_LEN;
- if (burst_sug > burst)
- NL_SET_ERR_MSG_FMT_MOD(extack,
- "Consider match rate %llu with burst at least %llu",
- rate, burst_sug);
-
- /* Select unit */
- for (; m.unit > 0; m.unit--) {
- if (rate > (rate_max >> 2) || burst > (burst_max >> 2))
- break;
- rate_max >>= 2;
- burst_max >>= 2;
- }
-
- /* Calculate information rate and bucket size */
- m.cir = rate2token(rate, slot_ns, m.unit, C);
- if (!m.cir)
- m.cir = 1;
- else if (WARN_ON(m.cir > cir_max))
- m.cir = cir_max;
- m.cbs = burst2token(burst, m.unit, C);
- if (!m.cbs)
- m.cbs = 1;
- else if (WARN_ON(m.cbs > cbs_max))
- m.cbs = cbs_max;
-
- /* Cut EBS */
- m.ebs = 0;
- if (!(flags & YT921X_MARKER_SINGLE_BUCKET)) {
- /* We don't have a chance to adjust rate when MTU is changed */
- if (flags & YT921X_MARKER_PKT_MODE)
- burst_est++;
- else
- burst_est += YT921X_FRAME_SIZE_MAX;
-
- if (burst_est < burst) {
- u32 pbs = m.cbs;
-
- m.cbs = burst2token(burst_est, m.unit, C);
- if (!m.cbs)
- m.cbs = 1;
- else if (WARN_ON(m.cbs > cbs_max))
- m.cbs = cbs_max;
-
- if (pbs > m.cbs)
- m.ebs = pbs - m.cbs;
- }
- }
-
- dev_dbg(dev,
- "slot %u ns, rate %llu, burst %llu -> unit %d, cir %u, cbs %u, ebs %u\n",
- slot_ns, rate, burst, m.unit, m.cir, m.cbs, m.ebs);
-
- m.pkt_mode = flags & YT921X_MARKER_PKT_MODE;
- *marker = m;
- return 0;
-}
-
-static int
-yt921x_marker_tfm_police(struct yt921x_marker *marker,
- const struct flow_action_police *police,
- unsigned int flags, struct yt921x_priv *priv, int port,
- struct netlink_ext_ack *extack)
-{
- bool pkt_mode = !!police->rate_pkt_ps;
- u64 burst;
- u64 rate;
-
- rate = pkt_mode ? police->rate_pkt_ps : police->rate_bytes_ps;
- burst = pkt_mode ? police->burst_pkt : police->burst;
- if (pkt_mode)
- flags |= YT921X_MARKER_PKT_MODE;
-
- return yt921x_marker_tfm(marker, rate, burst, flags,
- priv->meter_slot_ns, YT921X_METER_CIR_MAX,
- YT921X_METER_CBS_MAX, YT921X_METER_UNIT_MAX,
- priv, port, extack);
-}
-
-static int
-yt921x_marker_tfm_shape(struct yt921x_marker *marker, u64 rate, u64 burst,
- unsigned int flags, struct yt921x_priv *priv, int port,
- struct netlink_ext_ack *extack)
-{
- return yt921x_marker_tfm(marker, rate, burst, flags,
- priv->port_shape_slot_ns, YT921X_SHAPE_CIR_MAX,
- YT921X_SHAPE_CBS_MAX, YT921X_SHAPE_UNIT_MAX,
- priv, port, extack);
-}
-
-static int
-yt921x_police_validate(const struct flow_action_police *police,
- const struct flow_action *action,
- const struct flow_action_entry *act,
- struct netlink_ext_ack *extack)
-{
- if (police->exceed.act_id != FLOW_ACTION_DROP) {
- NL_SET_ERR_MSG_MOD(extack,
- "Offload not supported when exceed action is not drop");
- return -EOPNOTSUPP;
- }
-
- if (police->notexceed.act_id != FLOW_ACTION_PIPE &&
- police->notexceed.act_id != FLOW_ACTION_ACCEPT) {
- NL_SET_ERR_MSG_MOD(extack,
- "Offload not supported when conform action is not pipe or ok");
- return -EOPNOTSUPP;
- }
-
- if (police->notexceed.act_id == FLOW_ACTION_ACCEPT && action && act &&
- !flow_action_is_last_entry(action, act)) {
- NL_SET_ERR_MSG_MOD(extack,
- "Offload not supported when conform action is ok, but action is not last");
- return -EOPNOTSUPP;
- }
-
- /* mtu defaults to unlimited but we got 2040 here, don't know why */
- if (police->peakrate_bytes_ps || police->avrate || police->overhead) {
- NL_SET_ERR_MSG_MOD(extack,
- "Offload not supported when peakrate/avrate/overhead is configured");
- return -EOPNOTSUPP;
- }
-
- return 0;
-}
-
-static int
-yt921x_meter_config(struct yt921x_priv *priv, unsigned int id,
- const struct yt921x_marker *marker)
-{
- u32 ctrls[3];
-
- ctrls[0] = 0;
- ctrls[1] = YT921X_METER_CTRLb_CIR(marker->cir);
- ctrls[2] = YT921X_METER_CTRLc_UNIT(marker->unit) |
- YT921X_METER_CTRLc_DROP_R |
- YT921X_METER_CTRLc_TOKEN_OVERFLOW_EN |
- YT921X_METER_CTRLc_METER_EN;
- if (marker->pkt_mode)
- ctrls[2] |= YT921X_METER_CTRLc_PKT_MODE;
- update_ctrls_unaligned(&ctrls[0], &ctrls[1],
- YT921X_METER_CTRLab_EBS_M,
- YT921X_METER_CTRLab_EBS(marker->ebs));
- update_ctrls_unaligned(&ctrls[1], &ctrls[2],
- YT921X_METER_CTRLbc_CBS_M,
- YT921X_METER_CTRLbc_CBS(marker->cbs));
-
- return yt921x_reg96_write(priv, YT921X_METERn_CTRL(id), ctrls);
-}
-
-static void yt921x_dsa_port_policer_del(struct dsa_switch *ds, int port)
-{
- struct yt921x_priv *priv = to_yt921x_priv(ds);
- struct device *dev = to_device(priv);
- int res;
-
- mutex_lock(&priv->reg_lock);
- res = yt921x_reg_write(priv, YT921X_PORTn_METER(port), 0);
- mutex_unlock(&priv->reg_lock);
-
- if (res)
- dev_err(dev, "Failed to %s port %d: %i\n", "delete policer on",
- port, res);
-}
-
-static int
-yt921x_dsa_port_policer_add(struct dsa_switch *ds, int port,
- const struct flow_action_police *police,
- struct netlink_ext_ack *extack)
-{
- struct yt921x_priv *priv = to_yt921x_priv(ds);
- struct yt921x_marker marker;
- u32 ctrl;
- int res;
-
- res = yt921x_police_validate(police, NULL, NULL, extack);
- if (res)
- return res;
-
- res = yt921x_marker_tfm_police(&marker, police, 0, priv, port, extack);
- if (res)
- return res;
-
- mutex_lock(&priv->reg_lock);
- res = yt921x_meter_config(priv, port + YT921X_METER_NUM, &marker);
- if (res)
- goto end;
-
- ctrl = YT921X_PORT_METER_ID(port) | YT921X_PORT_METER_EN;
- res = yt921x_reg_write(priv, YT921X_PORTn_METER(port), ctrl);
-end:
- mutex_unlock(&priv->reg_lock);
-
- return res;
-}
-
-static int
-yt921x_dsa_port_setup_tc_tbf_port(struct dsa_switch *ds, int port,
- const struct tc_tbf_qopt_offload *qopt)
-{
- struct yt921x_priv *priv = to_yt921x_priv(ds);
- struct netlink_ext_ack *extack = qopt->extack;
- u32 ctrls[2];
- int res;
-
- if (qopt->parent != TC_H_ROOT)
- return -EOPNOTSUPP;
-
- switch (qopt->command) {
- case TC_TBF_STATS:
- /* Unfortunately the convention for TC_*_STATS is a mess,
- * neither 0 nor -EOPNOTSUPP is perfect here.
- */
- return -EOPNOTSUPP;
- case TC_TBF_DESTROY:
- ctrls[0] = 0;
- ctrls[1] = 0;
- break;
- case TC_TBF_REPLACE: {
- const struct tc_tbf_qopt_offload_replace_params *p;
- struct yt921x_marker marker;
-
- p = &qopt->replace_params;
-
- res = yt921x_marker_tfm_shape(&marker, p->rate.rate_bytes_ps,
- p->max_size,
- YT921X_MARKER_SINGLE_BUCKET,
- priv, port, extack);
- if (res)
- return res;
-
- ctrls[0] = YT921X_PORT_SHAPE_CTRLa_CIR(marker.cir) |
- YT921X_PORT_SHAPE_CTRLa_CBS(marker.cbs);
- ctrls[1] = YT921X_PORT_SHAPE_CTRLb_UNIT(marker.unit) |
- YT921X_PORT_SHAPE_CTRLb_EN;
- break;
- }
- default:
- return -EOPNOTSUPP;
- }
-
- mutex_lock(&priv->reg_lock);
- res = yt921x_reg64_write(priv, YT921X_PORTn_SHAPE_CTRL(port), ctrls);
- mutex_unlock(&priv->reg_lock);
-
- return res;
-}
-
-static int
-yt921x_dsa_port_setup_tc(struct dsa_switch *ds, int port,
- enum tc_setup_type type, void *type_data)
-{
- switch (type) {
- case TC_SETUP_QDISC_TBF: {
- const struct tc_tbf_qopt_offload *qopt = type_data;
-
- return yt921x_dsa_port_setup_tc_tbf_port(ds, port, qopt);
- }
- default:
- return -EOPNOTSUPP;
- }
-}
-
-/* ACL: 48 blocks * 8 entries
- *
- * One rule can span multiple entries, but within a block.
- */
-
-static void
-yt921x_acl_entry_set(struct yt921x_acl_entry *entry, unsigned int offset,
- u32 flags, bool set)
-{
- if (set)
- entry->key[offset] |= flags;
- entry->mask[offset] |= flags;
-}
-
-static unsigned int
-yt921x_acl_entries_set_is_fragment(struct yt921x_acl_entry *entries,
- unsigned int size, bool set)
-{
- for (unsigned int i = 0; i < size; i++)
- switch (FIELD_GET(YT921X_ACL_KEYb_TYPE_M, entries[i].key[1])) {
- case YT921X_ACL_TYPE_IPV4_DA:
- case YT921X_ACL_TYPE_IPV4_SA:
- yt921x_acl_entry_set(&entries[i], 1,
- YT921X_ACL_BINb_IPV4_FRAG, set);
- return size;
- case YT921X_ACL_TYPE_IPV6_DA3:
- case YT921X_ACL_TYPE_IPV6_SA3:
- yt921x_acl_entry_set(&entries[i], 1,
- YT921X_ACL_BINb_IPV6_xA3_FRAG,
- set);
- return size;
- case YT921X_ACL_TYPE_MISC:
- yt921x_acl_entry_set(&entries[i], 1,
- YT921X_ACL_BINb_MISC_FRAG, set);
- return size;
- case YT921X_ACL_TYPE_L4:
- yt921x_acl_entry_set(&entries[i], 1,
- YT921X_ACL_BINb_L4_FRAG, set);
- return size;
- }
-
- if (size >= YT921X_ACL_ENT_PER_BLK)
- return 0;
-
- entries[size] = (typeof(*entries)){};
- entries[size].key[1] = YT921X_ACL_KEYb_TYPE(YT921X_ACL_TYPE_MISC);
- yt921x_acl_entry_set(&entries[size], 1, YT921X_ACL_BINb_MISC_FRAG, set);
-
- return size + 1;
-}
-
-static unsigned int
-yt921x_acl_entries_set_first_frag(struct yt921x_acl_entry *entries,
- unsigned int size, bool set)
-{
- for (unsigned int i = 0; i < size; i++)
- switch (FIELD_GET(YT921X_ACL_KEYb_TYPE_M, entries[i].key[1])) {
- case YT921X_ACL_TYPE_IPV6_DA2:
- case YT921X_ACL_TYPE_IPV6_SA2:
- yt921x_acl_entry_set(&entries[i], 1,
- YT921X_ACL_BINb_IPV6_xA2_FIRST_FRAG,
- set);
- return size;
- case YT921X_ACL_TYPE_MISC:
- yt921x_acl_entry_set(&entries[i], 0,
- YT921X_ACL_BINa_MISC_FIRST_FRAG,
- set);
- return size;
- }
-
- if (size >= YT921X_ACL_ENT_PER_BLK)
- return 0;
-
- entries[size] = (typeof(*entries)){};
- entries[size].key[1] = YT921X_ACL_KEYb_TYPE(YT921X_ACL_TYPE_MISC);
- yt921x_acl_entry_set(&entries[size], 0,
- YT921X_ACL_BINa_MISC_FIRST_FRAG, set);
-
- return size + 1;
-}
-
-static unsigned int
-yt921x_acl_entries_set_l3_type(struct yt921x_acl_entry *entries,
- unsigned int size, enum yt921x_l3_type type)
-{
- for (unsigned int i = 0; i < size; i++)
- switch (FIELD_GET(YT921X_ACL_KEYb_TYPE_M, entries[i].key[1])) {
- case YT921X_ACL_TYPE_MAC_DA0:
- case YT921X_ACL_TYPE_MAC_SA0:
- entries[i].key[1] |= YT921X_ACL_BINb_MAC_xA0_L3_TYPE(type);
- entries[i].mask[1] |= YT921X_ACL_BINb_MAC_xA0_L3_TYPE_M;
- return size;
- case YT921X_ACL_TYPE_MISC:
- entries[i].key[0] |= YT921X_ACL_BINa_MISC_L3_TYPE(type);
- entries[i].mask[0] |= YT921X_ACL_BINa_MISC_L3_TYPE_M;
- return size;
- }
-
- if (size >= YT921X_ACL_ENT_PER_BLK)
- return 0;
-
- entries[size] = (typeof(*entries)){};
- entries[size].key[0] = YT921X_ACL_BINa_MISC_L3_TYPE(type);
- entries[size].key[1] = YT921X_ACL_KEYb_TYPE(YT921X_ACL_TYPE_MISC);
- entries[size].mask[0] = YT921X_ACL_BINa_MISC_L3_TYPE_M;
-
- return size + 1;
-}
-
-static unsigned int
-yt921x_acl_entries_set_l4_type(struct yt921x_acl_entry *entries,
- unsigned int size, enum yt921x_l4_type type)
-{
- for (unsigned int i = 0; i < size; i++)
- switch (FIELD_GET(YT921X_ACL_KEYb_TYPE_M, entries[i].key[1])) {
- case YT921X_ACL_TYPE_IPV4_DA:
- case YT921X_ACL_TYPE_IPV4_SA:
- entries[i].key[1] |= YT921X_ACL_BINb_IPV4_L4_TYPE(type);
- entries[i].mask[1] |= YT921X_ACL_BINb_IPV4_L4_TYPE_M;
- return size;
- case YT921X_ACL_TYPE_IPV6_DA0:
- case YT921X_ACL_TYPE_IPV6_DA1:
- case YT921X_ACL_TYPE_IPV6_DA2:
- case YT921X_ACL_TYPE_IPV6_DA3:
- case YT921X_ACL_TYPE_IPV6_SA0:
- case YT921X_ACL_TYPE_IPV6_SA1:
- case YT921X_ACL_TYPE_IPV6_SA2:
- case YT921X_ACL_TYPE_IPV6_SA3:
- entries[i].key[1] |= YT921X_ACL_BINb_IPV6_L4_TYPE(type);
- entries[i].mask[1] |= YT921X_ACL_BINb_IPV6_L4_TYPE_M;
- return size;
- case YT921X_ACL_TYPE_L4:
- entries[i].key[1] |= YT921X_ACL_BINb_L4_TYPE(type);
- entries[i].mask[1] |= YT921X_ACL_BINb_L4_TYPE_M;
- return size;
- case YT921X_ACL_TYPE_MISC:
- entries[i].key[1] |= YT921X_ACL_BINb_MISC_L4_TYPE(type);
- entries[i].mask[1] |= YT921X_ACL_BINb_MISC_L4_TYPE_M;
- return size;
- }
-
- if (size >= YT921X_ACL_ENT_PER_BLK)
- return 0;
-
- entries[size] = (typeof(*entries)){};
- entries[size].key[1] = YT921X_ACL_BINb_MISC_L4_TYPE(type) |
- YT921X_ACL_KEYb_TYPE(YT921X_ACL_TYPE_MISC);
- entries[size].mask[1] = YT921X_ACL_BINb_MISC_L4_TYPE_M;
-
- return size + 1;
-}
-
-static struct yt921x_acl_entry *
-yt921x_acl_entries_new(struct yt921x_acl_entry *entries, unsigned int *sizep,
- u32 type)
-{
- unsigned int size = *sizep;
-
- if (size >= YT921X_ACL_ENT_PER_BLK)
- return NULL;
-
- entries[size] = (typeof(*entries)){};
- entries[size].key[1] = YT921X_ACL_KEYb_TYPE(type);
-
- (*sizep)++;
- return &entries[size];
-}
-
-static struct yt921x_acl_entry *
-yt921x_acl_entries_find(struct yt921x_acl_entry *entries, unsigned int *sizep,
- u32 type)
-{
- for (unsigned int i = 0; i < *sizep; i++)
- if (FIELD_GET(YT921X_ACL_KEYb_TYPE_M, entries[i].key[1]) ==
- type)
- return &entries[i];
- return yt921x_acl_entries_new(entries, sizep, type);
-}
-
-static void
-yt921x_acl_rule_set_ports(struct yt921x_acl_rule *aclrule, u16 ord,
- u16 ports_mask)
-{
- struct yt921x_acl_entry *entries = aclrule->entries;
-
- for (unsigned int i = 0; i < hweight8(aclrule->mask); i++) {
- entries[i].key[1] |= YT921X_ACL_KEYb_SPORTS(ports_mask) |
- YT921X_ACL_KEYb_ORD(ord);
- }
-}
-
-struct yt921x_acl_rule_ext {
- struct yt921x_acl_rule r;
-
- struct yt921x_marker marker;
-};
-
-static int
-yt921x_acl_rule_ext_parse_flow_entries(struct yt921x_acl_rule_ext *ruleext,
- const struct flow_cls_offload *cls)
-{
- const struct flow_rule *rule = flow_cls_offload_flow_rule(cls);
- struct yt921x_acl_entry *entries = ruleext->r.entries;
- struct netlink_ext_ack *extack = cls->common.extack;
- const struct flow_dissector *dissector;
- struct yt921x_acl_entry *entry;
- unsigned int size = 0;
- bool use_dport;
- bool use_sport;
-
- /* Incomplete and probably won't, since it supports custom u32 filters.
- * New adapters are welcome.
- */
- dissector = rule->match.dissector;
- if (dissector->used_keys &
- ~(BIT_ULL(FLOW_DISSECTOR_KEY_CONTROL) |
- BIT_ULL(FLOW_DISSECTOR_KEY_BASIC) |
- BIT_ULL(FLOW_DISSECTOR_KEY_IPV4_ADDRS) |
- BIT_ULL(FLOW_DISSECTOR_KEY_IPV6_ADDRS) |
- BIT_ULL(FLOW_DISSECTOR_KEY_PORTS) |
- BIT_ULL(FLOW_DISSECTOR_KEY_PORTS_RANGE) |
- BIT_ULL(FLOW_DISSECTOR_KEY_ETH_ADDRS) |
- BIT_ULL(FLOW_DISSECTOR_KEY_IP) |
- BIT_ULL(FLOW_DISSECTOR_KEY_TCP))) {
- NL_SET_ERR_MSG_MOD(extack, "Unsupported keys used");
- return -EOPNOTSUPP;
- }
-
- /* Entries */
- if (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_IPV4_ADDRS)) {
- struct flow_match_ipv4_addrs match;
-
- flow_rule_match_ipv4_addrs(rule, &match);
-
- if (match.mask->dst) {
- entry = yt921x_acl_entries_new(entries, &size,
- YT921X_ACL_TYPE_IPV4_DA);
- if (!entry)
- goto err;
-
- entry->key[0] |= ntohl(match.key->dst);
- entry->mask[0] |= ntohl(match.mask->dst);
- }
-
- if (match.mask->src) {
- entry = yt921x_acl_entries_new(entries, &size,
- YT921X_ACL_TYPE_IPV4_SA);
- if (!entry)
- goto err;
-
- entry->key[0] |= ntohl(match.key->src);
- entry->mask[0] |= ntohl(match.mask->src);
- }
- }
-
- if (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_IPV6_ADDRS)) {
- struct flow_match_ipv6_addrs match;
-
- flow_rule_match_ipv6_addrs(rule, &match);
-
- for (unsigned int i = 0; i < 4; i++) {
- if (!match.mask->dst.s6_addr32[i])
- continue;
-
- entry = yt921x_acl_entries_new(entries, &size,
- YT921X_ACL_TYPE_IPV6_DA0 + i);
- if (!entry)
- goto err;
-
- entry->key[0] |= ntohl(match.key->dst.s6_addr32[i]);
- entry->mask[0] |= ntohl(match.mask->dst.s6_addr32[i]);
- }
-
- for (unsigned int i = 0; i < 4; i++) {
- if (!match.mask->src.s6_addr32[i])
- continue;
-
- entry = yt921x_acl_entries_new(entries, &size,
- YT921X_ACL_TYPE_IPV6_SA0 + i);
- if (!entry)
- goto err;
-
- entry->key[0] |= ntohl(match.key->src.s6_addr32[i]);
- entry->mask[0] |= ntohl(match.mask->src.s6_addr32[i]);
- }
- }
-
- use_dport = false;
- use_sport = false;
- if (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_PORTS)) {
- struct flow_match_ports match;
-
- entry = yt921x_acl_entries_new(entries, &size,
- YT921X_ACL_TYPE_L4);
- if (!entry)
- goto err;
-
- flow_rule_match_ports(rule, &match);
-
- use_dport = !!match.mask->dst;
- use_sport = !!match.mask->src;
-
- entry->key[0] |= (ntohs(match.key->dst) << 16) |
- ntohs(match.key->src);
- entry->mask[0] |= (ntohs(match.mask->dst) << 16) |
- ntohs(match.mask->src);
- }
-
- if (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_PORTS_RANGE)) {
- struct flow_match_ports_range match;
-
- entry = yt921x_acl_entries_find(entries, &size,
- YT921X_ACL_TYPE_L4);
- if (!entry)
- goto err;
-
- flow_rule_match_ports_range(rule, &match);
-
- if ((use_dport && match.mask->tp.dst) ||
- (use_sport && match.mask->tp.src)) {
- NL_SET_ERR_MSG_MOD(extack,
- "Port mask and range are mutually exclusive");
- return -EINVAL;
- }
-
- if (match.mask->tp.dst) {
- entry->key[0] |= ntohs(match.key->tp_min.dst) << 16;
- entry->key[1] |= YT921X_ACL_KEYb_L4_DPORT_RANGE_EN;
- entry->mask[0] |= ntohs(match.key->tp_max.dst) << 16;
- }
-
- if (match.mask->tp.src) {
- entry->key[0] |= ntohs(match.key->tp_min.src);
- entry->key[1] |= YT921X_ACL_KEYb_L4_SPORT_RANGE_EN;
- entry->mask[0] |= ntohs(match.key->tp_max.src);
- }
- }
-
- if (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_ETH_ADDRS)) {
- struct flow_match_eth_addrs match;
- u32 mask;
-
- flow_rule_match_eth_addrs(rule, &match);
-
- mask = ethaddr_hi4_to_u32(match.mask->dst);
- if (mask) {
- entry = yt921x_acl_entries_new(entries, &size,
- YT921X_ACL_TYPE_MAC_DA0);
- if (!entry)
- goto err;
-
- entry->key[0] |= ethaddr_hi4_to_u32(match.key->dst);
- entry->mask[0] |= mask;
- }
-
- mask = ethaddr_hi4_to_u32(match.mask->src);
- if (mask) {
- entry = yt921x_acl_entries_new(entries, &size,
- YT921X_ACL_TYPE_MAC_SA0);
- if (!entry)
- goto err;
-
- entry->key[0] |= ethaddr_hi4_to_u32(match.key->src);
- entry->mask[0] |= mask;
- }
-
- mask = (ethaddr_lo2_to_u32(match.mask->dst) << 16) |
- ethaddr_lo2_to_u32(match.mask->src);
- if (mask) {
- entry = yt921x_acl_entries_new(entries, &size,
- YT921X_ACL_TYPE_MAC_DA1_SA1);
- if (!entry)
- goto err;
-
- entry->key[0] |= (ethaddr_lo2_to_u32(match.key->dst) << 16) |
- ethaddr_lo2_to_u32(match.key->src);
- entry->mask[0] |= mask;
- }
- }
-
- /* Entries + Misc */
- if (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_BASIC)) {
- struct flow_match_basic match;
-
- flow_rule_match_basic(rule, &match);
-
- if (match.mask->n_proto) {
- enum yt921x_l3_type l3type = YT921X_L3_TYPE_OTHER;
-
- if (match.mask->n_proto == htons(~0))
- switch (match.key->n_proto) {
- case htons(ETH_P_IP):
- l3type = YT921X_L3_TYPE_IPV4;
- break;
- case htons(ETH_P_IPV6):
- l3type = YT921X_L3_TYPE_IPV6;
- break;
- case htons(ETH_P_ARP):
- l3type = YT921X_L3_TYPE_ARP;
- break;
- case htons(ETH_P_LLDP):
- l3type = YT921X_L3_TYPE_LLDP;
- break;
- case htons(ETH_P_PAE):
- l3type = YT921X_L3_TYPE_PAE;
- break;
- case htons(ETH_P_CFM):
- l3type = YT921X_L3_TYPE_ERP;
- break;
- }
-
- if (l3type != YT921X_L3_TYPE_OTHER) {
- size = yt921x_acl_entries_set_l3_type(entries,
- size,
- l3type);
- if (!size)
- goto err;
- } else {
- entry = yt921x_acl_entries_new(entries, &size,
- YT921X_ACL_TYPE_ETHERTYPE);
- if (!entry)
- goto err;
-
- entry->key[0] |= ntohs(match.key->n_proto);
- entry->mask[0] |= ntohs(match.mask->n_proto);
- }
- }
-
- if (match.mask->ip_proto) {
- enum yt921x_l4_type l4type = YT921X_L4_TYPE_OTHER;
-
- if (match.mask->ip_proto == (u8)~0)
- switch (match.key->ip_proto) {
- case IPPROTO_TCP:
- l4type = YT921X_L4_TYPE_TCP;
- break;
- case IPPROTO_UDP:
- l4type = YT921X_L4_TYPE_UDP;
- break;
- case IPPROTO_UDPLITE:
- l4type = YT921X_L4_TYPE_UDPLITE;
- break;
- case IPPROTO_ICMP:
- l4type = YT921X_L4_TYPE_ICMP;
- break;
- case IPPROTO_IGMP:
- l4type = YT921X_L4_TYPE_IGMP;
- break;
- }
-
- if (l4type != YT921X_L4_TYPE_OTHER) {
- size = yt921x_acl_entries_set_l4_type(entries,
- size,
- l4type);
- if (!size)
- goto err;
- } else {
- entry = yt921x_acl_entries_find(entries, &size,
- YT921X_ACL_TYPE_MISC);
- if (!entry)
- goto err;
-
- entry->key[0] |= YT921X_ACL_BINa_MISC_IP_PROTO(match.key->ip_proto);
- entry->mask[0] |= YT921X_ACL_BINa_MISC_IP_PROTO(match.mask->ip_proto);
- }
- }
- }
-
- if (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_CONTROL)) {
- u32 supp_flags = FLOW_DIS_IS_FRAGMENT | FLOW_DIS_FIRST_FRAG;
- struct flow_match_control match;
-
- flow_rule_match_control(rule, &match);
- if (!flow_rule_is_supp_control_flags(supp_flags,
- match.mask->flags, extack))
- return -EOPNOTSUPP;
-
- if (match.mask->flags & FLOW_DIS_IS_FRAGMENT) {
- bool set = match.key->flags & FLOW_DIS_IS_FRAGMENT;
-
- size = yt921x_acl_entries_set_is_fragment(entries, size,
- set);
- if (!size)
- goto err;
- }
- if (match.mask->flags & FLOW_DIS_FIRST_FRAG) {
- bool set = match.key->flags & FLOW_DIS_FIRST_FRAG;
-
- size = yt921x_acl_entries_set_first_frag(entries, size,
- set);
- if (!size)
- goto err;
- }
- }
-
- /* Misc only */
- if (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_IP)) {
- struct flow_match_ip match;
-
- flow_rule_match_ip(rule, &match);
- if (match.mask->ttl) {
- NL_SET_ERR_MSG_MOD(extack,
- "Matching on TTL not supported");
- return -EOPNOTSUPP;
- }
-
- if (match.mask->tos) {
- entry = yt921x_acl_entries_find(entries, &size,
- YT921X_ACL_TYPE_MISC);
- if (!entry)
- goto err;
-
- entry->key[0] |= YT921X_ACL_BINa_MISC_TOS(match.key->tos);
- entry->mask[0] |= YT921X_ACL_BINa_MISC_TOS(match.mask->tos);
- }
- }
-
- if (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_TCP)) {
- struct flow_match_tcp match;
-
- flow_rule_match_tcp(rule, &match);
- if (match.mask->flags & htons(~0xff)) {
- NL_SET_ERR_MSG_MOD(extack, "Unsupported TCP flags");
- return -EOPNOTSUPP;
- }
-
- if (match.mask->flags) {
- entry = yt921x_acl_entries_find(entries, &size,
- YT921X_ACL_TYPE_MISC);
- if (!entry)
- goto err;
-
- entry->key[0] |= YT921X_ACL_BINa_MISC_TCP_FLAGS(ntohs(match.key->flags));
- entry->mask[0] |= YT921X_ACL_BINa_MISC_TCP_FLAGS(ntohs(match.mask->flags));
- }
- }
-
- if (!size) {
- NL_SET_ERR_MSG_MOD(extack, "Empty rule generated, this should not happen");
- return -EOPNOTSUPP;
- }
-
- ruleext->r.mask = (1 << size) - 1;
- return 0;
-
-err:
- NL_SET_ERR_MSG_MOD(extack, "Rule too complex");
- return -EOPNOTSUPP;
-}
-
-static int
-yt921x_acl_rule_ext_parse_flow_action(struct yt921x_acl_rule_ext *ruleext,
- const struct flow_cls_offload *cls,
- struct yt921x_priv *priv, int port)
-{
- const struct flow_rule *rule = flow_cls_offload_flow_rule(cls);
- const struct flow_action *flow_action = &rule->action;
- struct netlink_ext_ack *extack = cls->common.extack;
- enum flow_action_id redir_act = NUM_FLOW_ACTIONS;
- const struct flow_action_entry *act;
- u32 *action = ruleext->r.action;
- bool seen_priority = false;
- const char *reason = NULL;
- bool seen_police = false;
- unsigned int i;
- int res;
-
- memset(action, 0, 3 * sizeof(*action));
- flow_action_for_each(i, act, flow_action)
- switch (act->id) {
- case FLOW_ACTION_ACCEPT:
- case FLOW_ACTION_DROP:
- case FLOW_ACTION_REDIRECT:
- if (redir_act != NUM_FLOW_ACTIONS &&
- redir_act != act->id) {
- reason = "Different redirect actions";
- goto fallback;
- }
- redir_act = act->id;
-
- switch (act->id) {
- case FLOW_ACTION_ACCEPT:
- action[2] |= YT921X_ACL_ACTc_FWD_EN |
- YT921X_ACL_ACTc_FWD_FWD;
- break;
- case FLOW_ACTION_DROP:
- action[2] |= YT921X_ACL_ACTc_FWD_EN |
- YT921X_ACL_ACTc_FWD_REDIR;
- break;
- case FLOW_ACTION_REDIRECT: {
- struct dsa_port *to_dp;
-
- to_dp = dsa_port_from_netdev(act->dev);
- if (IS_ERR(to_dp) || to_dp->ds != &priv->ds) {
- reason = "Redirect to non-local port";
- goto fallback;
- }
-
- action[2] |= YT921X_ACL_ACTc_FWD_EN |
- YT921X_ACL_ACTc_FWD_REDIR |
- YT921X_ACL_ACTc_FWD_REDIR_DPORTn(to_dp->index);
- break;
- }
- default:
- break;
- }
- break;
- case FLOW_ACTION_PRIORITY:
- if (seen_priority) {
- action[0] &= ~YT921X_ACL_ACTa_PRIO_EN;
- action[1] &= ~YT921X_ACL_ACTb_PRIO_M;
-
- reason = "Multiple priority actions";
- goto fallback;
- }
- seen_priority = true;
-
- if (act->priority >= YT921X_PRIO_NUM) {
- NL_SET_ERR_MSG_MOD(extack,
- "Priority value is too high");
- return -EOPNOTSUPP;
- }
- action[0] |= YT921X_ACL_ACTa_PRIO_EN;
- action[1] |= YT921X_ACL_ACTb_PRIO(act->priority);
- break;
- case FLOW_ACTION_POLICE: {
- const struct flow_action_police *police = &act->police;
-
- if (seen_police) {
- action[0] &= ~YT921X_ACL_ACTa_METER_EN;
-
- reason = "Multiple police actions";
- goto fallback;
- }
- seen_police = true;
-
- res = yt921x_police_validate(police, flow_action, act,
- extack);
- if (res)
- return res;
-
- res = yt921x_marker_tfm_police(&ruleext->marker, police,
- 0, priv, port, extack);
- if (res)
- return res;
-
- action[0] |= YT921X_ACL_ACTa_METER_EN;
- break;
- }
- default:
-fallback:
- if (cls->common.skip_sw) {
- NL_SET_ERR_MSG_FMT_MOD(extack,
- "Action not supported when skip_sw: %s",
- reason);
- return -EOPNOTSUPP;
- }
- fallthrough;
- case FLOW_ACTION_TRAP:
- redir_act = FLOW_ACTION_TRAP;
-
- action[2] &= ~YT921X_ACL_ACTc_FWD_REDIR_DPORTS_M &
- ~YT921X_ACL_ACTc_FWD_M;
- action[2] |= YT921X_ACL_ACTc_FWD_EN |
- YT921X_ACL_ACTc_FWD_TRAP;
- break;
- }
-
- ruleext->r.sw_assisted = !cls->common.skip_sw;
- return 0;
-}
-
-static int
-yt921x_acl_rule_ext_parse_flow(struct yt921x_acl_rule_ext *ruleext, int port,
- const struct flow_cls_offload *cls, bool ingress,
- struct yt921x_priv *priv)
-{
- struct netlink_ext_ack *extack = cls->common.extack;
- int res;
-
- if (!ingress) {
- NL_SET_ERR_MSG_MOD(extack, "Only ingress is supported");
- return -EOPNOTSUPP;
- }
-
- if (cls->common.chain_index) {
- NL_SET_ERR_MSG(extack, "Only chain 0 is supported");
- return -EOPNOTSUPP;
- }
-
- res = yt921x_acl_rule_ext_parse_flow_action(ruleext, cls, priv, port);
- if (res)
- return res;
- res = yt921x_acl_rule_ext_parse_flow_entries(ruleext, cls);
- if (res)
- return res;
-
- yt921x_acl_rule_set_ports(&ruleext->r, 0, BIT(port));
- ruleext->r.tag = cls->cookie;
- ruleext->r.type = TC_SETUP_CLSFLOWER;
- return 0;
-}
-
-static unsigned int
-yt921x_acl_find(const struct yt921x_priv *priv, enum tc_setup_type type,
- unsigned long tag)
-{
- for (unsigned int blkid = 0; blkid < YT921X_ACL_BLK_NUM; blkid++) {
- const struct yt921x_acl_blk *aclblk = priv->acl_blks[blkid];
-
- if (!aclblk)
- continue;
-
- for (unsigned int i = 0; i < YT921X_ACL_ENT_PER_BLK; i++)
- if (aclblk->rules[i] && aclblk->rules[i]->tag == tag &&
- aclblk->rules[i]->type == type)
- return YT921X_ACL_ENT_PER_BLK * blkid + i;
- }
-
- return UINT_MAX;
-}
-
-static unsigned int
-yt921x_acl_reserve(struct yt921x_priv *priv, unsigned int entscnt,
- struct netlink_ext_ack *extack)
-{
- int candidates[YT921X_ACL_ENT_PER_BLK + 1];
- unsigned int acl_used_cnt = 0;
-
- if (WARN_ON(entscnt > YT921X_ACL_ENT_PER_BLK))
- return UINT_MAX;
-
- for (unsigned int i = 0; i < ARRAY_SIZE(candidates); i++)
- candidates[i] = -1;
- for (unsigned int i = YT921X_ACL_BLK_NUM; i-- > 0;) {
- unsigned int blk_used_cnt = hweight8(priv->acl_masks[i]);
-
- candidates[blk_used_cnt] = i;
- acl_used_cnt += blk_used_cnt;
- }
-
- if (acl_used_cnt >= YT921X_ACL_NUM) {
- NL_SET_ERR_MSG_MOD(extack, "ACL entry limit reached");
- return UINT_MAX;
- }
- if (acl_used_cnt + entscnt <= YT921X_ACL_NUM)
- for (unsigned int i = YT921X_ACL_ENT_PER_BLK - entscnt + 1;
- i-- > 0;)
- if (candidates[i] >= 0)
- return YT921X_ACL_ENT_PER_BLK * candidates[i] +
- ffz(priv->acl_masks[candidates[i]]);
-
- NL_SET_ERR_MSG_MOD(extack,
- "ACL entry allocation failed, simplify your rules or remove existing rules");
- return UINT_MAX;
-}
-
-static int
-yt921x_acl_commit(struct yt921x_priv *priv, unsigned int entid, u8 entsmask)
-{
- const struct yt921x_acl_rule *aclrule;
- const struct yt921x_acl_blk *aclblk;
- unsigned int blkid;
- unsigned int binid;
- unsigned long mask;
- u32 zeros[3] = {};
- unsigned int i;
- unsigned int o;
- u32 ctrl;
- int res;
-
- blkid = entid / YT921X_ACL_ENT_PER_BLK;
- binid = entid % YT921X_ACL_ENT_PER_BLK;
- aclblk = priv->acl_blks[blkid];
- aclrule = aclblk->rules[binid];
-
- /* Write actions */
- res = yt921x_reg96_write(priv, YT921X_ACLn_ACT(entid),
- aclrule ? aclrule->action : zeros);
- if (res)
- return res;
-
- /* Select the block */
- ctrl = YT921X_ACL_BLK_CMD_MODIFY | YT921X_ACL_BLK_CMD_BLKID(blkid);
- res = yt921x_reg_write(priv, YT921X_ACL_BLK_CMD, ctrl);
- if (res)
- return res;
-
- /* Write keys and masks */
- ctrl = 0;
- for (unsigned int i = 0; i < YT921X_ACL_ENT_PER_BLK; i++)
- ctrl |= YT921X_ACL_BLK_KEEP_KEEPn(i);
-
- mask = entsmask;
- i = 0;
- for_each_set_bit(o, &mask, YT921X_ACL_ENT_PER_BLK) {
- res = yt921x_reg64_write(priv, YT921X_ACLn_KEYm(blkid, o),
- aclrule ? aclrule->entries[i].key :
- zeros);
- if (res)
- return res;
-
- res = yt921x_reg64_write(priv, YT921X_ACLn_MASKm(blkid, o),
- aclrule ? aclrule->entries[i].mask :
- zeros);
- if (res)
- return res;
-
- ctrl &= ~YT921X_ACL_BLK_KEEP_KEEPn(o);
- i++;
- }
-
- res = yt921x_reg_write(priv, YT921X_ACL_BLK_KEEP, ctrl);
- if (res)
- return res;
-
- ctrl = 0;
- for (unsigned int i = 0; i < YT921X_ACL_ENT_PER_BLK; i++) {
- const struct yt921x_acl_rule *other = aclblk->rules[i];
-
- if (!other)
- continue;
-
- mask = other->mask;
- for_each_set_bit(o, &mask, YT921X_ACL_ENT_PER_BLK)
- ctrl |= YT921X_ACL_ENTRY_ENm(o) |
- YT921X_ACL_ENTRY_GRPIDm(o, i);
- }
- res = yt921x_reg_write(priv, YT921X_ACLn_ENTRY(blkid), ctrl);
- if (res)
- return res;
-
- /* Commit the block */
- ctrl = YT921X_ACL_BLK_CMD_BLKID(blkid);
- res = yt921x_reg_write(priv, YT921X_ACL_BLK_CMD, ctrl);
- if (res)
- return res;
-
- return 0;
-}
-
-static int
-yt921x_acl_del(struct yt921x_priv *priv, enum tc_setup_type type,
- unsigned long tag)
-{
- struct yt921x_acl_rule *aclrule;
- struct yt921x_acl_blk *aclblk;
- unsigned int binid;
- unsigned int blkid;
- unsigned int entid;
- int res;
-
- entid = yt921x_acl_find(priv, type, tag);
- if (entid == UINT_MAX)
- return -ENOENT;
-
- blkid = entid / YT921X_ACL_ENT_PER_BLK;
- binid = entid % YT921X_ACL_ENT_PER_BLK;
- aclblk = priv->acl_blks[blkid];
- aclrule = aclblk->rules[binid];
-
- aclblk->rules[binid] = NULL;
- res = yt921x_acl_commit(priv, entid, aclrule->mask);
- /* the kernel never rolls back on failure */
-
- if (aclrule->action[0] & YT921X_ACL_ACTa_METER_EN)
- clear_bit(FIELD_GET(YT921X_ACL_ACTa_METER_ID_M,
- aclrule->action[0]),
- priv->meters_map);
- priv->acl_masks[blkid] &= ~aclrule->mask;
- kvfree(aclrule);
- if (!priv->acl_masks[blkid]) {
- kvfree(aclblk);
- priv->acl_blks[blkid] = NULL;
- }
- return res;
-}
-
-static int
-yt921x_acl_add(struct yt921x_priv *priv,
- const struct yt921x_acl_rule_ext *ruleext,
- struct netlink_ext_ack *extack)
-{
- unsigned int entscnt = hweight8(ruleext->r.mask);
- struct yt921x_acl_rule *aclrule;
- struct yt921x_acl_blk *aclblk;
- bool use_trap = false;
- unsigned int meterid;
- unsigned long mask;
- unsigned int binid;
- unsigned int blkid;
- unsigned int entid;
- unsigned int o;
- int res;
-
- /* Allocate resources */
- entid = yt921x_acl_reserve(priv, entscnt, extack);
- if (entid == UINT_MAX)
- return -EOPNOTSUPP;
-
- if (!(ruleext->r.action[0] & YT921X_ACL_ACTa_METER_EN)) {
- meterid = YT921X_METER_NUM;
- } else {
- meterid = find_first_zero_bit(priv->meters_map,
- YT921X_METER_NUM);
- if (meterid < YT921X_METER_NUM) {
- res = yt921x_meter_config(priv, meterid,
- &ruleext->marker);
- if (res)
- return res;
- } else if (ruleext->r.sw_assisted) {
- use_trap = true;
- } else {
- NL_SET_ERR_MSG_MOD(extack,
- "No more meters available");
- return -EOPNOTSUPP;
- }
- }
-
- /* Prepare acl block ctrlblk */
- blkid = entid / YT921X_ACL_ENT_PER_BLK;
- binid = entid % YT921X_ACL_ENT_PER_BLK;
- aclblk = priv->acl_blks[blkid];
- if (!aclblk) {
- aclblk = kvzalloc_obj(*aclblk);
- if (!aclblk)
- return -ENOMEM;
- priv->acl_blks[blkid] = aclblk;
- }
-
- /* Prepare acl rule ctrlblk */
- aclrule = kvmemdup(&ruleext->r,
- offsetof(struct yt921x_acl_rule, entries[entscnt]),
- GFP_KERNEL);
- if (!aclrule) {
- res = -ENOMEM;
- goto err;
- }
-
- /* Replace the placeholder resource IDs */
- aclrule->mask = 0;
- mask = priv->acl_masks[blkid];
- for_each_clear_bit(o, &mask, YT921X_ACL_ENT_PER_BLK) {
- aclrule->mask |= BIT(o);
- entscnt--;
- if (!entscnt)
- break;
- }
-
- if (use_trap) {
- aclrule->action[2] &= ~YT921X_ACL_ACTc_FWD_REDIR_DPORTS_M &
- ~YT921X_ACL_ACTc_FWD_M;
- aclrule->action[2] |= YT921X_ACL_ACTc_FWD_EN |
- YT921X_ACL_ACTc_FWD_TRAP;
- }
- if (meterid < YT921X_METER_NUM)
- aclrule->action[0] |= YT921X_ACL_ACTa_METER_ID(meterid);
- else
- aclrule->action[0] &= ~YT921X_ACL_ACTa_METER_EN;
-
- /* Write rules */
- aclblk->rules[binid] = aclrule;
- res = yt921x_acl_commit(priv, entid, aclrule->mask);
- if (res) {
- aclblk->rules[binid] = NULL;
- kvfree(aclrule);
- goto err;
- }
-
- if (meterid < YT921X_METER_NUM)
- set_bit(meterid, priv->meters_map);
- priv->acl_masks[blkid] |= aclrule->mask;
- return 0;
-
-err:
- if (!priv->acl_masks[blkid]) {
- kvfree(aclblk);
- priv->acl_blks[blkid] = NULL;
- }
- return res;
-}
-
-static int
-yt921x_dsa_cls_flower_del(struct dsa_switch *ds, int port,
- struct flow_cls_offload *cls, bool ingress)
-{
- struct yt921x_priv *priv = to_yt921x_priv(ds);
- int res;
-
- mutex_lock(&priv->reg_lock);
- res = yt921x_acl_del(priv, TC_SETUP_CLSFLOWER, cls->cookie);
- mutex_unlock(&priv->reg_lock);
-
- return res;
-}
-
-static int
-yt921x_dsa_cls_flower_add(struct dsa_switch *ds, int port,
- struct flow_cls_offload *cls, bool ingress)
-{
- struct netlink_ext_ack *extack = cls->common.extack;
- struct yt921x_priv *priv = to_yt921x_priv(ds);
- struct yt921x_acl_rule_ext ruleext;
- int res;
-
- res = yt921x_acl_rule_ext_parse_flow(&ruleext, port, cls, ingress,
- priv);
- if (res)
- return res;
-
- mutex_lock(&priv->reg_lock);
- res = yt921x_acl_add(priv, &ruleext, extack);
- mutex_unlock(&priv->reg_lock);
-
- return res;
-}
-
-static int
-yt921x_mirror_del(struct yt921x_priv *priv, int port, bool ingress)
-{
- u32 mask;
-
- if (ingress)
- mask = YT921X_MIRROR_IGR_PORTn(port);
- else
- mask = YT921X_MIRROR_EGR_PORTn(port);
- return yt921x_reg_clear_bits(priv, YT921X_MIRROR, mask);
-}
-
-static int
-yt921x_mirror_add(struct yt921x_priv *priv, int port, bool ingress,
- int to_local_port, struct netlink_ext_ack *extack)
-{
- u32 srcs;
- u32 ctrl;
- u32 val;
- u32 dst;
- int res;
-
- if (ingress)
- srcs = YT921X_MIRROR_IGR_PORTn(port);
- else
- srcs = YT921X_MIRROR_EGR_PORTn(port);
- dst = YT921X_MIRROR_PORT(to_local_port);
-
- res = yt921x_reg_read(priv, YT921X_MIRROR, &val);
- if (res)
- return res;
-
- /* other mirror tasks & different dst port -> conflict */
- if ((val & ~srcs & (YT921X_MIRROR_EGR_PORTS_M |
- YT921X_MIRROR_IGR_PORTS_M)) &&
- (val & YT921X_MIRROR_PORT_M) != dst) {
- NL_SET_ERR_MSG_MOD(extack,
- "Sniffer port is already configured, delete existing rules & retry");
- return -EBUSY;
- }
-
- ctrl = val & ~YT921X_MIRROR_PORT_M;
- ctrl |= srcs;
- ctrl |= dst;
-
- if (ctrl == val)
- return 0;
-
- return yt921x_reg_write(priv, YT921X_MIRROR, ctrl);
-}
-
-static void
-yt921x_dsa_port_mirror_del(struct dsa_switch *ds, int port,
- struct dsa_mall_mirror_tc_entry *mirror)
-{
- struct yt921x_priv *priv = to_yt921x_priv(ds);
- struct device *dev = to_device(priv);
- int res;
-
- mutex_lock(&priv->reg_lock);
- res = yt921x_mirror_del(priv, port, mirror->ingress);
- mutex_unlock(&priv->reg_lock);
-
- if (res)
- dev_err(dev, "Failed to %s port %d: %i\n", "unmirror",
- port, res);
-}
-
-static int
-yt921x_dsa_port_mirror_add(struct dsa_switch *ds, int port,
- struct dsa_mall_mirror_tc_entry *mirror,
- bool ingress, struct netlink_ext_ack *extack)
-{
- struct yt921x_priv *priv = to_yt921x_priv(ds);
- int res;
-
- mutex_lock(&priv->reg_lock);
- res = yt921x_mirror_add(priv, port, ingress,
- mirror->to_local_port, extack);
- mutex_unlock(&priv->reg_lock);
-
- return res;
-}
-
static int yt921x_lag_hash(struct yt921x_priv *priv, u32 ctrl, bool unique_lag,
struct netlink_ext_ack *extack)
{
@@ -2143,7 +684,7 @@ static int yt921x_lag_set(struct yt921x_priv *priv, u8 index, u16 ports_mask)
static int
yt921x_dsa_port_lag_leave(struct dsa_switch *ds, int port, struct dsa_lag lag)
{
- struct yt921x_priv *priv = to_yt921x_priv(ds);
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(ds);
struct dsa_port *dp;
u32 ctrl;
int res;
@@ -2206,7 +747,7 @@ yt921x_dsa_port_lag_join(struct dsa_switch *ds, int port, struct dsa_lag lag,
struct netdev_lag_upper_info *info,
struct netlink_ext_ack *extack)
{
- struct yt921x_priv *priv = to_yt921x_priv(ds);
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(ds);
struct dsa_port *dp;
bool unique_lag;
unsigned int i;
@@ -2269,7 +810,7 @@ yt921x_dsa_port_lag_join(struct dsa_switch *ds, int port, struct dsa_lag lag,
static int yt921x_fdb_wait(struct yt921x_priv *priv, u32 *valp)
{
- struct device *dev = to_device(priv);
+ struct device *dev = yt921x_priv_to_device(priv);
u32 val = YT921X_FDB_RESULT_DONE;
int res;
@@ -2338,7 +879,7 @@ static int
yt921x_fdb_read(struct yt921x_priv *priv, unsigned char *addr, u16 *vidp,
u16 *ports_maskp, u16 *indexp, u8 *statusp)
{
- struct device *dev = to_device(priv);
+ struct device *dev = yt921x_priv_to_device(priv);
u16 index;
u32 data0;
u32 data1;
@@ -2629,7 +1170,7 @@ static int
yt921x_dsa_port_fdb_dump(struct dsa_switch *ds, int port,
dsa_fdb_dump_cb_t *cb, void *data)
{
- struct yt921x_priv *priv = to_yt921x_priv(ds);
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(ds);
int res;
mutex_lock(&priv->reg_lock);
@@ -2644,8 +1185,8 @@ yt921x_dsa_port_fdb_dump(struct dsa_switch *ds, int port,
static void yt921x_dsa_port_fast_age(struct dsa_switch *ds, int port)
{
- struct yt921x_priv *priv = to_yt921x_priv(ds);
- struct device *dev = to_device(priv);
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(ds);
+ struct device *dev = yt921x_priv_to_device(priv);
int res;
mutex_lock(&priv->reg_lock);
@@ -2660,7 +1201,7 @@ static void yt921x_dsa_port_fast_age(struct dsa_switch *ds, int port)
static int
yt921x_dsa_set_ageing_time(struct dsa_switch *ds, unsigned int msecs)
{
- struct yt921x_priv *priv = to_yt921x_priv(ds);
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(ds);
u32 ctrl;
int res;
@@ -2678,7 +1219,7 @@ static int
yt921x_dsa_port_fdb_del(struct dsa_switch *ds, int port,
const unsigned char *addr, u16 vid, struct dsa_db db)
{
- struct yt921x_priv *priv = to_yt921x_priv(ds);
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(ds);
int res;
mutex_lock(&priv->reg_lock);
@@ -2692,7 +1233,7 @@ static int
yt921x_dsa_port_fdb_add(struct dsa_switch *ds, int port,
const unsigned char *addr, u16 vid, struct dsa_db db)
{
- struct yt921x_priv *priv = to_yt921x_priv(ds);
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(ds);
int res;
mutex_lock(&priv->reg_lock);
@@ -2707,7 +1248,7 @@ yt921x_dsa_port_mdb_del(struct dsa_switch *ds, int port,
const struct switchdev_obj_port_mdb *mdb,
struct dsa_db db)
{
- struct yt921x_priv *priv = to_yt921x_priv(ds);
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(ds);
const unsigned char *addr = mdb->addr;
u16 vid = mdb->vid;
int res;
@@ -2724,7 +1265,7 @@ yt921x_dsa_port_mdb_add(struct dsa_switch *ds, int port,
const struct switchdev_obj_port_mdb *mdb,
struct dsa_db db)
{
- struct yt921x_priv *priv = to_yt921x_priv(ds);
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(ds);
const unsigned char *addr = mdb->addr;
u16 vid = mdb->vid;
int res;
@@ -2889,7 +1430,7 @@ yt921x_dsa_port_vlan_filtering(struct dsa_switch *ds, int port,
bool vlan_filtering,
struct netlink_ext_ack *extack)
{
- struct yt921x_priv *priv = to_yt921x_priv(ds);
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(ds);
int res;
if (dsa_is_cpu_port(ds, port))
@@ -2906,7 +1447,7 @@ static int
yt921x_dsa_port_vlan_del(struct dsa_switch *ds, int port,
const struct switchdev_obj_port_vlan *vlan)
{
- struct yt921x_priv *priv = to_yt921x_priv(ds);
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(ds);
u16 vid = vlan->vid;
u16 pvid;
int res;
@@ -2940,7 +1481,7 @@ yt921x_dsa_port_vlan_add(struct dsa_switch *ds, int port,
const struct switchdev_obj_port_vlan *vlan,
struct netlink_ext_ack *extack)
{
- struct yt921x_priv *priv = to_yt921x_priv(ds);
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(ds);
u16 vid = vlan->vid;
u16 pvid;
int res;
@@ -3185,7 +1726,7 @@ yt921x_dsa_port_bridge_flags(struct dsa_switch *ds, int port,
struct switchdev_brport_flags flags,
struct netlink_ext_ack *extack)
{
- struct yt921x_priv *priv = to_yt921x_priv(ds);
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(ds);
int res;
if (dsa_is_cpu_port(ds, port))
@@ -3202,8 +1743,8 @@ static void
yt921x_dsa_port_bridge_leave(struct dsa_switch *ds, int port,
struct dsa_bridge bridge)
{
- struct yt921x_priv *priv = to_yt921x_priv(ds);
- struct device *dev = to_device(priv);
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(ds);
+ struct device *dev = yt921x_priv_to_device(priv);
int res;
if (dsa_is_cpu_port(ds, port))
@@ -3223,7 +1764,7 @@ yt921x_dsa_port_bridge_join(struct dsa_switch *ds, int port,
struct dsa_bridge bridge, bool *tx_fwd_offload,
struct netlink_ext_ack *extack)
{
- struct yt921x_priv *priv = to_yt921x_priv(ds);
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(ds);
u16 ports_mask;
int res;
@@ -3244,7 +1785,7 @@ static int
yt921x_dsa_port_mst_state_set(struct dsa_switch *ds, int port,
const struct switchdev_mst_state *st)
{
- struct yt921x_priv *priv = to_yt921x_priv(ds);
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(ds);
u32 mask;
u32 ctrl;
int res;
@@ -3278,7 +1819,7 @@ static int
yt921x_dsa_vlan_msti_set(struct dsa_switch *ds, struct dsa_bridge bridge,
const struct switchdev_vlan_msti *msti)
{
- struct yt921x_priv *priv = to_yt921x_priv(ds);
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(ds);
u32 masks[2];
u32 ctrls[2];
int res;
@@ -3304,9 +1845,9 @@ yt921x_dsa_vlan_msti_set(struct dsa_switch *ds, struct dsa_bridge bridge,
static void
yt921x_dsa_port_stp_state_set(struct dsa_switch *ds, int port, u8 state)
{
- struct yt921x_priv *priv = to_yt921x_priv(ds);
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(ds);
struct dsa_port *dp = dsa_to_port(ds, port);
- struct device *dev = to_device(priv);
+ struct device *dev = yt921x_priv_to_device(priv);
bool learning;
u32 mask;
u32 ctrl;
@@ -3356,7 +1897,7 @@ yt921x_dsa_port_stp_state_set(struct dsa_switch *ds, int port, u8 state)
static int __maybe_unused
yt921x_dsa_port_get_default_prio(struct dsa_switch *ds, int port)
{
- struct yt921x_priv *priv = to_yt921x_priv(ds);
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(ds);
u32 val;
int res;
@@ -3373,7 +1914,7 @@ yt921x_dsa_port_get_default_prio(struct dsa_switch *ds, int port)
static int __maybe_unused
yt921x_dsa_port_set_default_prio(struct dsa_switch *ds, int port, u8 prio)
{
- struct yt921x_priv *priv = to_yt921x_priv(ds);
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(ds);
u32 mask;
u32 ctrl;
int res;
@@ -3399,7 +1940,7 @@ static int __maybe_unused
yt921x_dsa_port_get_apptrust(struct dsa_switch *ds, int port, u8 *sel,
int *nselp)
{
- struct yt921x_priv *priv = to_yt921x_priv(ds);
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(ds);
u8 appprios[2][2] = {};
int nsel;
u32 val;
@@ -3433,8 +1974,8 @@ static int __maybe_unused
yt921x_dsa_port_set_apptrust(struct dsa_switch *ds, int port, const u8 *sel,
int nsel)
{
- struct yt921x_priv *priv = to_yt921x_priv(ds);
- struct device *dev = to_device(priv);
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(ds);
+ struct device *dev = yt921x_priv_to_device(priv);
u32 ctrl;
int res;
@@ -3576,7 +2117,7 @@ yt921x_port_config(struct yt921x_priv *priv, int port, unsigned int mode,
{
const struct yt921x_info *info = priv->info;
struct yt921x_port *pp = &priv->ports[port];
- struct device *dev = to_device(priv);
+ struct device *dev = yt921x_priv_to_device(priv);
u32 mask;
int res;
@@ -3628,7 +2169,7 @@ yt921x_phylink_mac_select_pcs(struct phylink_config *config,
phy_interface_t interface)
{
struct dsa_port *dp = dsa_phylink_to_port(config);
- struct yt921x_priv *priv = to_yt921x_priv(dp->ds);
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(dp->ds);
const struct yt921x_info *info = priv->info;
int port = dp->index;
@@ -3651,7 +2192,7 @@ yt921x_phylink_mac_link_down(struct phylink_config *config, unsigned int mode,
phy_interface_t interface)
{
struct dsa_port *dp = dsa_phylink_to_port(config);
- struct yt921x_priv *priv = to_yt921x_priv(dp->ds);
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(dp->ds);
int port = dp->index;
int res;
@@ -3674,7 +2215,7 @@ yt921x_phylink_mac_link_up(struct phylink_config *config,
bool tx_pause, bool rx_pause)
{
struct dsa_port *dp = dsa_phylink_to_port(config);
- struct yt921x_priv *priv = to_yt921x_priv(dp->ds);
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(dp->ds);
int port = dp->index;
int res;
@@ -3695,7 +2236,7 @@ yt921x_phylink_mac_config(struct phylink_config *config, unsigned int mode,
const struct phylink_link_state *state)
{
struct dsa_port *dp = dsa_phylink_to_port(config);
- struct yt921x_priv *priv = to_yt921x_priv(dp->ds);
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(dp->ds);
int port = dp->index;
int res;
@@ -3712,7 +2253,7 @@ static void
yt921x_dsa_phylink_get_caps(struct dsa_switch *ds, int port,
struct phylink_config *config)
{
- struct yt921x_priv *priv = to_yt921x_priv(ds);
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(ds);
const struct yt921x_info *info = priv->info;
config->mac_capabilities = MAC_ASYM_PAUSE | MAC_SYM_PAUSE |
@@ -3803,7 +2344,7 @@ yt921x_dsa_get_tag_protocol(struct dsa_switch *ds, int port,
static int yt921x_dsa_port_setup(struct dsa_switch *ds, int port)
{
- struct yt921x_priv *priv = to_yt921x_priv(ds);
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(ds);
int res;
mutex_lock(&priv->reg_lock);
@@ -3817,7 +2358,7 @@ static int yt921x_dsa_port_setup(struct dsa_switch *ds, int port)
static int __maybe_unused
yt921x_dsa_port_get_dscp_prio(struct dsa_switch *ds, int port, u8 dscp)
{
- struct yt921x_priv *priv = to_yt921x_priv(ds);
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(ds);
u32 val;
int res;
@@ -3834,7 +2375,7 @@ yt921x_dsa_port_get_dscp_prio(struct dsa_switch *ds, int port, u8 dscp)
static int __maybe_unused
yt921x_dsa_port_del_dscp_prio(struct dsa_switch *ds, int port, u8 dscp, u8 prio)
{
- struct yt921x_priv *priv = to_yt921x_priv(ds);
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(ds);
u32 val;
int res;
@@ -3859,7 +2400,7 @@ yt921x_dsa_port_del_dscp_prio(struct dsa_switch *ds, int port, u8 dscp, u8 prio)
static int __maybe_unused
yt921x_dsa_port_add_dscp_prio(struct dsa_switch *ds, int port, u8 dscp, u8 prio)
{
- struct yt921x_priv *priv = to_yt921x_priv(ds);
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(ds);
int res;
if (prio >= YT921X_PRIO_NUM)
@@ -3920,7 +2461,7 @@ static int yt921x_edata_read(struct yt921x_priv *priv, u8 addr, u8 *valp)
static void yt921x_dsa_teardown(struct dsa_switch *ds)
{
#if IS_ENABLED(CONFIG_NET_DSA_YT921X_LEDS)
- struct yt921x_priv *priv = to_yt921x_priv(ds);
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(ds);
yt921x_leds_remove(priv);
#endif
@@ -3928,7 +2469,7 @@ static void yt921x_dsa_teardown(struct dsa_switch *ds)
static int yt921x_chip_detect(struct yt921x_priv *priv)
{
- struct device *dev = to_device(priv);
+ struct device *dev = yt921x_priv_to_device(priv);
const struct yt921x_info *info;
u8 extmode;
u32 chipid;
@@ -3995,7 +2536,7 @@ static int yt921x_chip_detect(struct yt921x_priv *priv)
static int yt921x_chip_reset(struct yt921x_priv *priv)
{
- struct device *dev = to_device(priv);
+ struct device *dev = yt921x_priv_to_device(priv);
u16 eth_p_tag;
u32 val;
int res;
@@ -4145,8 +2686,7 @@ static int yt921x_chip_setup_acl(struct yt921x_priv *priv)
if (res)
return res;
- ctrl = YT921X_ACL_PORT_PORTS_M;
- res = yt921x_reg_write(priv, YT921X_ACL_PORT, ctrl);
+ res = yt921x_reg_write(priv, YT921X_ACL_PORT, 0);
if (res)
return res;
@@ -4243,8 +2783,8 @@ static int yt921x_chip_setup(struct yt921x_priv *priv)
static int yt921x_dsa_setup(struct dsa_switch *ds)
{
- struct yt921x_priv *priv = to_yt921x_priv(ds);
- struct device *dev = to_device(priv);
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(ds);
+ struct device *dev = yt921x_priv_to_device(priv);
struct device_node *np = dev->of_node;
struct device_node *child;
unsigned long mask;
diff --git a/drivers/net/dsa/motorcomm/chip.h b/drivers/net/dsa/motorcomm/chip.h
index 28e4f26f9cc49..68cbbc9b9b78d 100644
--- a/drivers/net/dsa/motorcomm/chip.h
+++ b/drivers/net/dsa/motorcomm/chip.h
@@ -434,249 +434,6 @@ enum yt921x_app_selector {
#define YT921X_VLAN_CTRLa_METER_EN BIT(5)
#define YT921X_VLAN_CTRLa_METER_ID_M GENMASK(4, 0)
-#define YT921X_ACLn_ACT(n) (0x1c0000 + 0x10 * (n))
-#define YT921X_ACL_ACTc_STAG_M GENMASK(26, 25)
-#define YT921X_ACL_ACTc_STAG(x) FIELD_PREP(YT921X_ACL_ACTc_STAG_M, (x))
-#define YT921X_ACL_ACTc_STAG_DONTCARE YT921X_ACL_ACTc_STAG(0)
-#define YT921X_ACL_ACTc_STAG_UNTAG YT921X_ACL_ACTc_STAG(1)
-#define YT921X_ACL_ACTc_STAG_TAG YT921X_ACL_ACTc_STAG(2)
-#define YT921X_ACL_ACTc_STAG_KEEP YT921X_ACL_ACTc_STAG(3)
-#define YT921X_ACL_ACTc_CTAG_M GENMASK(24, 23)
-#define YT921X_ACL_ACTc_CTAG(x) FIELD_PREP(YT921X_ACL_ACTc_CTAG_M, (x))
-#define YT921X_ACL_ACTc_CTAG_DONTCARE YT921X_ACL_ACTc_CTAG(0)
-#define YT921X_ACL_ACTc_CTAG_UNTAG YT921X_ACL_ACTc_CTAG(1)
-#define YT921X_ACL_ACTc_CTAG_TAG YT921X_ACL_ACTc_CTAG(2)
-#define YT921X_ACL_ACTc_CTAG_KEEP YT921X_ACL_ACTc_CTAG(3)
-#define YT921X_ACL_ACTc_FWD_M GENMASK(22, 21)
-#define YT921X_ACL_ACTc_FWD(x) FIELD_PREP(YT921X_ACL_ACTc_FWD_M, (x))
-#define YT921X_ACL_ACTc_FWD_FWD YT921X_ACL_ACTc_FWD(0)
-#define YT921X_ACL_ACTc_FWD_COPY YT921X_ACL_ACTc_FWD(1)
-#define YT921X_ACL_ACTc_FWD_REDIR YT921X_ACL_ACTc_FWD(2)
-#define YT921X_ACL_ACTc_FWD_TRAP YT921X_ACL_ACTc_FWD(3)
-#define YT921X_ACL_ACTc_FWD_REDIR_DPORTS_M GENMASK(20, 10)
-#define YT921X_ACL_ACTc_FWD_REDIR_DPORTS(x) FIELD_PREP(YT921X_ACL_ACTc_FWD_REDIR_DPORTS_M, (x))
-#define YT921X_ACL_ACTc_FWD_REDIR_DPORTn(port) BIT((port) + 10)
-#define YT921X_ACL_ACTc_FWD_EN BIT(9)
-#define YT921X_ACL_ACTc_SDEI BIT(8)
-#define YT921X_ACL_ACTc_SDEI_REPLACE BIT(7)
-#define YT921X_ACL_ACTc_SPRI_M GENMASK(6, 4)
-#define YT921X_ACL_ACTc_SPRI(x) FIELD_PREP(YT921X_ACL_ACTc_SPRI_M, (x))
-#define YT921X_ACL_ACTc_SPRI_REPLACE BIT(3)
-#define YT921X_ACL_ACTbc_SVID_M GENMASK_ULL(34, 23)
-#define YT921X_ACL_ACTbc_SVID(x) FIELD_PREP(YT921X_ACL_ACTbc_SVID_M, (x))
-#define YT921X_ACL_ACTb_SVID_REPLACE BIT(22)
-#define YT921X_ACL_ACTb_CDEI BIT(21)
-#define YT921X_ACL_ACTb_CDEI_REPLACE BIT(20)
-#define YT921X_ACL_ACTb_CPRI_M GENMASK(19, 17)
-#define YT921X_ACL_ACTb_CPRI(x) FIELD_PREP(YT921X_ACL_ACTb_CPRI_M, (x))
-#define YT921X_ACL_ACTb_CPRI_REPLACE BIT(16)
-#define YT921X_ACL_ACTb_CVID_M GENMASK(15, 4)
-#define YT921X_ACL_ACTb_CVID(x) FIELD_PREP(YT921X_ACL_ACTb_CVID_M, (x))
-#define YT921X_ACL_ACTb_CVID_REPLACE BIT(3)
-#define YT921X_ACL_ACTb_PRIO_M GENMASK(2, 0)
-#define YT921X_ACL_ACTb_PRIO(x) FIELD_PREP(YT921X_ACL_ACTb_PRIO_M, (x))
-#define YT921X_ACL_ACTa_PRIO_EN BIT(31)
-#define YT921X_ACL_ACTa_COLOR_M GENMASK(30, 29)
-#define YT921X_ACL_ACTa_COLOR(x) FIELD_PREP(YT921X_ACL_ACTa_COLOR_M, (x))
-#define YT921X_ACL_ACTa_COLOR_GREEN YT921X_ACL_ACTa_COLOR(0)
-#define YT921X_ACL_ACTa_COLOR_YELLOW YT921X_ACL_ACTa_COLOR(1)
-#define YT921X_ACL_ACTa_COLOR_RED YT921X_ACL_ACTa_COLOR(2)
-#define YT921X_ACL_ACTa_COLOR_EN BIT(28)
-#define YT921X_ACL_ACTa_DSCP_M GENMASK(27, 22)
-#define YT921X_ACL_ACTa_DSCP(x) FIELD_PREP(YT921X_ACL_ACTa_DSCP_M, (x))
-#define YT921X_ACL_ACTa_DSCP_REPLACE BIT(21)
-#define YT921X_ACL_ACTa_METER_ID_M GENMASK(20, 15)
-#define YT921X_ACL_ACTa_METER_ID(x) FIELD_PREP(YT921X_ACL_ACTa_METER_ID_M, (x))
-#define YT921X_ACL_ACTa_METER_EN BIT(14)
-#define YT921X_ACL_ACTa_MIRROR_EN BIT(13)
-#define YT921X_ACL_ACTa_FLOWSTAT_EN BIT(12)
-#define YT921X_ACL_ACTa_FLOWSTAT_ID_M GENMASK(11, 6)
-#define YT921X_ACL_ACTa_FLOWSTAT_ID(x) FIELD_PREP(YT921X_ACL_ACTa_FLOWSTAT_ID_M, (x))
-#define YT921X_ACL_ACTa_GPIO_EN BIT(5)
-#define YT921X_ACL_ACTa_GPIO_PIN_M GENMASK(4, 1)
-#define YT921X_ACL_ACTa_GPIO_PIN(x) FIELD_PREP(YT921X_ACL_ACTa_GPIO_PIN_M, (x))
-#define YT921X_ACL_ACTa_INTR_EN BIT(0)
-#define YT921X_ACL_BLK_KEEP 0x201000
-#define YT921X_ACL_BLK_KEEP_GRPIDn_M(bin) (7 << (4 * (bin) + 1))
-#define YT921X_ACL_BLK_KEEP_GRPIDn(bin, x) ((x) << (4 * (bin) + 1))
-#define YT921X_ACL_BLK_KEEP_KEEPn(bin) BIT(4 * (bin))
-#define YT921X_ACL_PORT 0x202000
-#define YT921X_ACL_PORT_PORTS_M GENMASK(10, 0)
-#define YT921X_ACL_PORT_PORTS(x) FIELD_PREP(YT921X_ACL_PORT_PORTS_M, (x))
-#define YT921X_ACL_PORT_PORTn(port) BIT(port)
-#define YT921X_ACL_BLK_CMD 0x202004
-#define YT921X_ACL_BLK_CMD_BLKID_M GENMASK(6, 1)
-#define YT921X_ACL_BLK_CMD_BLKID(x) FIELD_PREP(YT921X_ACL_BLK_CMD_BLKID_M, (x))
-#define YT921X_ACL_BLK_CMD_MODIFY BIT(0)
-#define YT921X_ACLn_ENTRY(blk) (0x203000 + 4 * (blk))
-#define YT921X_ACL_ENTRY_GRPIDm_M(bin) (7 << (4 * (bin) + 1))
-#define YT921X_ACL_ENTRY_GRPIDm(bin, x) ((x) << (4 * (bin) + 1))
-#define YT921X_ACL_ENTRY_ENm(bin) BIT(4 * (bin))
-#define YT921X_ACLn_KEYm(blk, bin) (0x204000 + 0x200 * (bin) + 8 * (blk))
-#define YT921X_ACL_KEYb_ORD_M GENMASK(29, 21)
-#define YT921X_ACL_KEYb_ORD(x) FIELD_PREP(YT921X_ACL_KEYb_ORD_M, (x))
-#define YT921X_ACL_KEYb_SPORTS_M GENMASK(20, 10)
-#define YT921X_ACL_KEYb_SPORTS(x) FIELD_PREP(YT921X_ACL_KEYb_SPORTS_M, (x))
-#define YT921X_ACL_KEYb_SPORTn(port) BIT((port) + 10)
-#define YT921X_ACL_KEYb_REVERSE BIT(9) /* reverse match */
-#define YT921X_ACL_KEYb_TYPE_M GENMASK(8, 4)
-#define YT921X_ACL_KEYb_TYPE(x) FIELD_PREP(YT921X_ACL_KEYb_TYPE_M, (x))
-/* KEY_* fields need no masks */
-#define YT921X_ACLn_MASKm(blk, bin) (0x205000 + 0x200 * (bin) + 8 * (blk))
-
-enum yt921x_acl_type {
- YT921X_ACL_TYPE_NA,
- YT921X_ACL_TYPE_MAC_DA0,
- YT921X_ACL_TYPE_MAC_SA0,
- YT921X_ACL_TYPE_MAC_DA1_SA1,
- YT921X_ACL_TYPE_VLAN,
- YT921X_ACL_TYPE_VTAG,
- YT921X_ACL_TYPE_IPV4_DA,
- YT921X_ACL_TYPE_IPV4_SA,
- YT921X_ACL_TYPE_IPV6_DA0,
- YT921X_ACL_TYPE_IPV6_DA1,
- YT921X_ACL_TYPE_IPV6_DA2,
- YT921X_ACL_TYPE_IPV6_DA3,
- YT921X_ACL_TYPE_IPV6_SA0,
- YT921X_ACL_TYPE_IPV6_SA1,
- YT921X_ACL_TYPE_IPV6_SA2,
- YT921X_ACL_TYPE_IPV6_SA3,
- YT921X_ACL_TYPE_MISC,
- YT921X_ACL_TYPE_L4,
- YT921X_ACL_TYPE_UDF0,
- YT921X_ACL_TYPE_UDF1,
- YT921X_ACL_TYPE_UDF2,
- YT921X_ACL_TYPE_UDF3,
- YT921X_ACL_TYPE_UDF4,
- YT921X_ACL_TYPE_UDF5,
- YT921X_ACL_TYPE_UDF6,
- YT921X_ACL_TYPE_UDF7,
- YT921X_ACL_TYPE_ETHERTYPE,
- YT921X_ACL_TYPE_NUM
-};
-
-/* Range: turn KEY:MASK into MIN:MAX */
-
-#define YT921X_ACL_BINb_MAC_xA0_L3_TYPE_M GENMASK(3, 0)
-#define YT921X_ACL_BINb_MAC_xA0_L3_TYPE(x) FIELD_PREP(YT921X_ACL_BINb_MAC_xA0_L3_TYPE_M, (x))
-#define YT921X_ACL_BINa_MAC_xA0_MAC_xA0_M GENMASK(31, 0)
-
-#define YT921X_ACL_BINb_MAC_DA1_SA1_L2_TYPE_M GENMASK(2, 0)
-#define YT921X_ACL_BINb_MAC_DA1_SA1_L2_TYPE(x) FIELD_PREP(YT921X_ACL_BINb_MAC_DA1_SA1_L2_TYPE_M, (x))
-#define YT921X_ACL_BINa_MAC_DA1_SA1_MAC_DA1_M GENMASK(31, 16)
-#define YT921X_ACL_BINa_MAC_DA1_SA1_MAC_SA1_M GENMASK(15, 0)
-
-#define YT921X_ACL_KEYb_VLAN_SVID_RANGE_EN BIT(31)
-#define YT921X_ACL_KEYb_VLAN_CVID_RANGE_EN BIT(30)
-#define YT921X_ACL_BINb_VLAN_CDEI BIT(3)
-#define YT921X_ACL_BINb_VLAN_CPRI_M GENMASK(2, 0)
-#define YT921X_ACL_BINb_VLAN_CPRI(x) FIELD_PREP(YT921X_ACL_BINb_VLAN_CPRI_M, (x))
-#define YT921X_ACL_BINa_VLAN_CTAG_FMT_M GENMASK(31, 30)
-#define YT921X_ACL_BINa_VLAN_CTAG_FMT(x) FIELD_PREP(YT921X_ACL_BINa_VLAN_CTAG_FMT_M, (x))
-#define YT921X_ACL_BINa_VLAN_SDEI BIT(29)
-#define YT921X_ACL_BINa_VLAN_SPRI_M GENMASK(28, 26)
-#define YT921X_ACL_BINa_VLAN_SPRI(x) FIELD_PREP(YT921X_ACL_BINa_VLAN_SPRI_M, (x))
-#define YT921X_ACL_BINa_VLAN_STAG_FMT_M GENMASK(25, 24)
-#define YT921X_ACL_BINa_VLAN_STAG_FMT(x) FIELD_PREP(YT921X_ACL_BINa_VLAN_STAG_FMT_M, (x))
-#define YT921X_ACL_BINa_VLAN_SVID_M GENMASK(23, 12)
-#define YT921X_ACL_BINa_VLAN_SVID(x) FIELD_PREP(YT921X_ACL_BINa_VLAN_SVID_M, (x))
-#define YT921X_ACL_BINa_VLAN_CVID_M GENMASK(11, 0)
-#define YT921X_ACL_BINa_VLAN_CVID(x) FIELD_PREP(YT921X_ACL_BINa_VLAN_CVID_M, (x))
-
-#define YT921X_ACL_KEYb_VTAG_SVID_RANGE_EN BIT(31)
-#define YT921X_ACL_KEYb_VTAG_CVID_RANGE_EN BIT(30)
-#define YT921X_ACL_BINa_VTAG_CDEI BIT(31)
-#define YT921X_ACL_BINa_VTAG_CPRI_M GENMASK(30, 28)
-#define YT921X_ACL_BINa_VTAG_CPRI(x) FIELD_PREP(YT921X_ACL_BINa_VTAG_CPRI_M, (x))
-#define YT921X_ACL_BINa_VTAG_SDEI BIT(27)
-#define YT921X_ACL_BINa_VTAG_SPRI_M GENMASK(26, 24)
-#define YT921X_ACL_BINa_VTAG_SPRI(x) FIELD_PREP(YT921X_ACL_BINa_VTAG_SPRI_M, (x))
-#define YT921X_ACL_BINa_VTAG_SVID_M GENMASK(23, 12)
-#define YT921X_ACL_BINa_VTAG_SVID(x) FIELD_PREP(YT921X_ACL_BINa_VTAG_SVID_M, (x))
-#define YT921X_ACL_BINa_VTAG_CVID_M GENMASK(11, 0)
-#define YT921X_ACL_BINa_VTAG_CVID(x) FIELD_PREP(YT921X_ACL_BINa_VTAG_CVID_M, (x))
-
-#define YT921X_ACL_KEYb_IPV4_ADDR_RANGE_EN BIT(30)
-#define YT921X_ACL_BINb_IPV4_FRAG BIT(3)
-#define YT921X_ACL_BINb_IPV4_L4_TYPE_M GENMASK(2, 0)
-#define YT921X_ACL_BINb_IPV4_L4_TYPE(x) FIELD_PREP(YT921X_ACL_BINb_IPV4_L4_TYPE_M, (x))
-#define YT921X_ACL_BINa_IPV4_ADDR_M GENMASK(31, 0)
-
-#define YT921X_ACL_BINb_IPV6_L4_TYPE_M GENMASK(2, 0)
-#define YT921X_ACL_BINb_IPV6_L4_TYPE(x) FIELD_PREP(YT921X_ACL_BINb_IPV6_L4_TYPE_M, (x))
-#define YT921X_ACL_BINa_IPV6_ADDRx_M GENMASK(31, 0)
-
-#define YT921X_ACL_BINb_IPV6_xA1_IP_OPTION BIT(3)
-
-#define YT921X_ACL_BINb_IPV6_xA2_FIRST_FRAG BIT(3)
-
-#define YT921X_ACL_KEYb_IPV6_xA3_ADDR_RANGE_EN BIT(30)
-#define YT921X_ACL_BINb_IPV6_xA3_FRAG BIT(3)
-
-#define YT921X_ACL_BINb_MISC_FRAG BIT(3)
-#define YT921X_ACL_BINb_MISC_L4_TYPE_M GENMASK(2, 0)
-#define YT921X_ACL_BINb_MISC_L4_TYPE(x) FIELD_PREP(YT921X_ACL_BINb_MISC_L4_TYPE_M, (x))
-#define YT921X_ACL_BINa_MISC_PPPOE_FLAG BIT(30)
-#define YT921X_ACL_BINa_MISC_FIRST_FRAG BIT(29)
-#define YT921X_ACL_BINa_MISC_IP_OPTION BIT(28)
-#define YT921X_ACL_BINa_MISC_TCP_FLAGS_M GENMASK(27, 20)
-#define YT921X_ACL_BINa_MISC_TCP_FLAGS(x) FIELD_PREP(YT921X_ACL_BINa_MISC_TCP_FLAGS_M, (x))
-#define YT921X_ACL_BINa_MISC_IP_PROTO_M GENMASK(19, 12)
-#define YT921X_ACL_BINa_MISC_IP_PROTO(x) FIELD_PREP(YT921X_ACL_BINa_MISC_IP_PROTO_M, (x))
-#define YT921X_ACL_BINa_MISC_TOS_M GENMASK(11, 4)
-#define YT921X_ACL_BINa_MISC_TOS(x) FIELD_PREP(YT921X_ACL_BINa_MISC_TOS_M, (x))
-#define YT921X_ACL_BINa_MISC_L3_TYPE_M GENMASK(3, 0)
-#define YT921X_ACL_BINa_MISC_L3_TYPE(x) FIELD_PREP(YT921X_ACL_BINa_MISC_L3_TYPE_M, (x))
-
-#define YT921X_ACL_KEYb_L4_DPORT_RANGE_EN BIT(31)
-#define YT921X_ACL_KEYb_L4_SPORT_RANGE_EN BIT(30)
-#define YT921X_ACL_BINb_L4_FRAG BIT(3)
-#define YT921X_ACL_BINb_L4_TYPE_M GENMASK(2, 0)
-#define YT921X_ACL_BINb_L4_TYPE(x) FIELD_PREP(YT921X_ACL_BINb_L4_TYPE_M, (x))
-#define YT921X_ACL_BINa_L4_DPORT_M GENMASK(31, 16)
-#define YT921X_ACL_BINa_L4_SPORT_M GENMASK(15, 0)
-
-#define YT921X_ACL_BINb_UDF_IS_IGMP BIT(0)
-#define YT921X_ACL_BINa_UDF_UDF0_M GENMASK(31, 16)
-#define YT921X_ACL_BINa_UDF_UDF0(x) FIELD_PREP(YT921X_ACL_BINa_UDF_UDF0_M, (x))
-#define YT921X_ACL_BINa_UDF_UDF1_M GENMASK(15, 0)
-#define YT921X_ACL_BINa_UDF_UDF1(x) FIELD_PREP(YT921X_ACL_BINa_UDF_UDF1_M, (x))
-
-#define YT921X_ACL_KEYb_ETHERTYPE_ETHERTYPE_RANGE_EN BIT(30)
-#define YT921X_ACL_BINb_ETHERTYPE_L4_TYPE_M GENMASK(2, 0)
-#define YT921X_ACL_BINb_ETHERTYPE_L4_TYPE(x) FIELD_PREP(YT921X_ACL_BINb_ETHERTYPE_L4_TYPE_M, (x))
-#define YT921X_ACL_BINa_ETHERTYPE_ETHERTYPE_M GENMASK(15, 0)
-#define YT921X_ACL_BINa_ETHERTYPE_ETHERTYPE(x) FIELD_PREP(YT921X_ACL_BINa_ETHERTYPE_ETHERTYPE_M, (x))
-
-enum yt921x_l2_type {
- YT921X_L2_TYPE_ETH,
- YT921X_L2_TYPE_ETHV2,
- YT921X_L2_TYPE_ETHSAP,
- YT921X_L2_TYPE_ETHSNAP,
-};
-
-enum yt921x_l3_type {
- YT921X_L3_TYPE_OTHER,
- YT921X_L3_TYPE_IPV4,
- YT921X_L3_TYPE_IPV6,
- YT921X_L3_TYPE_ARP,
- YT921X_L3_TYPE_LLDP,
- YT921X_L3_TYPE_PAE,
- YT921X_L3_TYPE_ERP,
- YT921X_L3_TYPE_SLOW_PROTOCOL,
-};
-
-enum yt921x_l4_type {
- YT921X_L4_TYPE_OTHER,
- YT921X_L4_TYPE_TCP,
- YT921X_L4_TYPE_UDP,
- YT921X_L4_TYPE_UDPLITE,
- YT921X_L4_TYPE_ICMP,
- YT921X_L4_TYPE_IGMP,
- YT921X_L4_TYPE_MLD,
- YT921X_L4_TYPE_ND,
-};
-
#define YT921X_TPID_IGRn(x) (0x210000 + 4 * (x)) /* [0, 3] */
#define YT921X_TPID_IGR_TPID_M GENMASK(15, 0)
#define YT921X_PORTn_IGR_TPID(port) (0x210010 + 4 * (port))
@@ -693,47 +450,6 @@ enum yt921x_l4_type {
#define YT921X_LAG_HASH_MAC_SA BIT(2)
#define YT921X_LAG_HASH_MAC_DA BIT(1)
#define YT921X_LAG_HASH_SRC_PORT BIT(0)
-#define YT921X_UDFn_CTRL(x) (0x210094 + 4 * (x))
-#define YT921X_UDF_CTRL_UDF_TYPE_M GENMASK(8, 7)
-#define YT921X_UDF_CTRL_UDF_TYPE(x) FIELD_PREP(YT921X_UDF_CTRL_UDF_TYPE_M, (x))
-#define YT921X_UDF_CTRL_UDF_TYPE_ETH YT921X_UDF_CTRL_UDF_TYPE(0)
-#define YT921X_UDF_CTRL_UDF_TYPE_L3 YT921X_UDF_CTRL_UDF_TYPE(1)
-#define YT921X_UDF_CTRL_UDF_TYPE_L4 YT921X_UDF_CTRL_UDF_TYPE(2)
-#define YT921X_UDF_CTRL_UDF_OFFSET_M GENMASK(6, 0)
-#define YT921X_UDF_CTRL_UDF_OFFSET(x) FIELD_PREP(YT921X_UDF_CTRL_UDF_OFFSET_M, (x))
-
-#define YT921X_PORTn_RATE(port) (0x220000 + 4 * (port))
-#define YT921X_PORT_RATE_GAP_VALUE GENMASK(4, 0) /* default 20 */
-#define YT921X_METER_SLOT 0x220104
-#define YT921X_METER_SLOT_SLOT_M GENMASK(11, 0)
-#define YT921X_PORTn_METER(port) (0x220108 + 4 * (port))
-#define YT921X_PORT_METER_EN BIT(4)
-#define YT921X_PORT_METER_ID_M GENMASK(3, 0)
-#define YT921X_PORT_METER_ID(x) FIELD_PREP(YT921X_PORT_METER_ID_M, (x))
-#define YT921X_METERn_CTRL(x) (0x220800 + 0x10 * (x))
-#define YT921X_METER_CTRLc_METER_EN BIT(14)
-#define YT921X_METER_CTRLc_TOKEN_OVERFLOW_EN BIT(13) /* RFC4115: yellow use unused green bw */
-#define YT921X_METER_CTRLc_DROP_M GENMASK(12, 11)
-#define YT921X_METER_CTRLc_DROP(x) FIELD_PREP(YT921X_METER_CTRLc_DROP_M, (x))
-#define YT921X_METER_CTRLc_DROP_GYR YT921X_METER_CTRLc_DROP(0)
-#define YT921X_METER_CTRLc_DROP_YR YT921X_METER_CTRLc_DROP(1)
-#define YT921X_METER_CTRLc_DROP_R YT921X_METER_CTRLc_DROP(2)
-#define YT921X_METER_CTRLc_DROP_NONE YT921X_METER_CTRLc_DROP(3)
-#define YT921X_METER_CTRLc_COLOR_BLIND BIT(10)
-#define YT921X_METER_CTRLc_UNIT_M GENMASK(9, 7)
-#define YT921X_METER_CTRLc_UNIT(x) FIELD_PREP(YT921X_METER_CTRLc_UNIT_M, (x))
-#define YT921X_METER_CTRLc_BYTE_MODE_INCLUDE_GAP BIT(6) /* +GAP_VALUE bytes each packet */
-#define YT921X_METER_CTRLc_PKT_MODE BIT(5) /* 0: byte rate mode */
-#define YT921X_METER_CTRLc_RFC2698 BIT(4) /* 0: RFC4115 */
-#define YT921X_METER_CTRLbc_CBS_M GENMASK_ULL(35, 20)
-#define YT921X_METER_CTRLbc_CBS(x) FIELD_PREP(YT921X_METER_CTRLbc_CBS_M, (x))
-#define YT921X_METER_CTRLb_CIR_M GENMASK(19, 2)
-#define YT921X_METER_CTRLb_CIR(x) FIELD_PREP(YT921X_METER_CTRLb_CIR_M, (x))
-#define YT921X_METER_CTRLab_EBS_M GENMASK_ULL(33, 18)
-#define YT921X_METER_CTRLab_EBS(x) FIELD_PREP(YT921X_METER_CTRLab_EBS_M, (x))
-#define YT921X_METER_CTRLa_EIR_M GENMASK(17, 0)
-#define YT921X_METER_CTRLa_EIR(x) FIELD_PREP(YT921X_METER_CTRLa_EIR_M, (x))
-#define YT921X_METERn_STAT(x) (0x221000 + 8 * (x))
#define YT921X_PORTn_VLAN_CTRL(port) (0x230010 + 4 * (port))
#define YT921X_PORT_VLAN_CTRL_SVLAN_PRIO_EN BIT(31)
@@ -752,29 +468,6 @@ enum yt921x_l4_type {
#define YT921X_PORT_VLAN_CTRL1_CVLAN_DROP_TAGGED BIT(1)
#define YT921X_PORT_VLAN_CTRL1_CVLAN_DROP_UNTAGGED BIT(0)
-#define YT921X_MIRROR 0x300300
-#define YT921X_MIRROR_IGR_PORTS_M GENMASK(26, 16)
-#define YT921X_MIRROR_IGR_PORTS(x) FIELD_PREP(YT921X_MIRROR_IGR_PORTS_M, (x))
-#define YT921X_MIRROR_IGR_PORTn(port) BIT((port) + 16)
-#define YT921X_MIRROR_EGR_PORTS_M GENMASK(14, 4)
-#define YT921X_MIRROR_EGR_PORTS(x) FIELD_PREP(YT921X_MIRROR_EGR_PORTS_M, (x))
-#define YT921X_MIRROR_EGR_PORTn(port) BIT((port) + 4)
-#define YT921X_MIRROR_PORT_M GENMASK(3, 0)
-#define YT921X_MIRROR_PORT(x) FIELD_PREP(YT921X_MIRROR_PORT_M, (x))
-
-#define YT921X_PORT_SHAPE_SLOT 0x34000c
-#define YT921X_PORT_SHAPE_SLOT_SLOT_M GENMASK(11, 0)
-#define YT921X_PORTn_SHAPE_CTRL(port) (0x354000 + 8 * (port))
-#define YT921X_PORT_SHAPE_CTRLb_EN BIT(4)
-#define YT921X_PORT_SHAPE_CTRLb_PKT_MODE BIT(3) /* 0: byte rate mode */
-#define YT921X_PORT_SHAPE_CTRLb_UNIT_M GENMASK(2, 0)
-#define YT921X_PORT_SHAPE_CTRLb_UNIT(x) FIELD_PREP(YT921X_PORT_SHAPE_CTRLb_UNIT_M, (x))
-#define YT921X_PORT_SHAPE_CTRLa_CBS_M GENMASK(31, 18)
-#define YT921X_PORT_SHAPE_CTRLa_CBS(x) FIELD_PREP(YT921X_PORT_SHAPE_CTRLa_CBS_M, (x))
-#define YT921X_PORT_SHAPE_CTRLa_CIR_M GENMASK(17, 0)
-#define YT921X_PORT_SHAPE_CTRLa_CIR(x) FIELD_PREP(YT921X_PORT_SHAPE_CTRLa_CIR_M, (x))
-#define YT921X_PORTn_SHAPE_STAT(port) (0x356000 + 4 * (port))
-
#define YT921X_EDATA_EXTMODE 0xfb
#define YT921X_EDATA_LEN 0x100
@@ -791,19 +484,8 @@ enum yt921x_fdb_entry_status {
#define YT921X_MSTI_NUM 16
-#define YT921X_TOKEN_BYTE_C 1 /* 1 token = 2^1 byte */
-#define YT921X_TOKEN_PKT_C -6 /* 1 token = 2^-6 packets */
-#define YT921X_TOKEN_RATE_C -15
/* Custom meters only, not including dedicated port meters (11) */
#define YT921X_METER_NUM 64
-#define YT921X_METER_SLOT_MIN 80
-#define YT921X_METER_UNIT_MAX ((1 << 3) - 1)
-#define YT921X_METER_CIR_MAX ((1 << 18) - 1)
-#define YT921X_METER_CBS_MAX ((1 << 16) - 1)
-#define YT921X_PORT_SHAPE_SLOT_MIN 80
-#define YT921X_SHAPE_UNIT_MAX ((1 << 3) - 1)
-#define YT921X_SHAPE_CIR_MAX ((1 << 18) - 1)
-#define YT921X_SHAPE_CBS_MAX ((1 << 14) - 1)
#define YT921X_LAG_NUM 2
#define YT921X_LAG_PORT_NUM 4
@@ -821,9 +503,6 @@ enum yt921x_fdb_entry_status {
#define YT921X_TAG_LEN 8
#define YT921X_ACL_BLK_NUM 48
-#define YT921X_ACL_ENT_PER_BLK 8
-#define YT921X_ACL_NUM (YT921X_ACL_BLK_NUM * YT921X_ACL_ENT_PER_BLK)
-#define YT921X_UDF_NUM 8
#define YT921X_LED_GROUP_NUM 3
#define YT921X_LED_PORT_NUM 10
@@ -885,26 +564,6 @@ struct yt921x_mib {
u64 tx_oam;
};
-struct yt921x_acl_entry {
- u32 key[2];
- u32 mask[2];
-};
-
-struct yt921x_acl_rule {
- unsigned long tag;
- enum tc_setup_type type;
-
- u32 action[3];
- bool sw_assisted;
-
- u8 mask;
- struct yt921x_acl_entry entries[YT921X_ACL_ENT_PER_BLK];
-};
-
-struct yt921x_acl_blk {
- struct yt921x_acl_rule *rules[YT921X_ACL_ENT_PER_BLK];
-};
-
struct yt921x_port {
unsigned char index;
@@ -922,6 +581,8 @@ struct yt921x_port {
u64 rx_frames;
u64 tx_frames;
+ unsigned short acl_cnt;
+
#if IS_ENABLED(CONFIG_NET_DSA_YT921X_LEDS)
unsigned char led_duty;
unsigned short led_cycle;
@@ -984,8 +645,10 @@ struct yt921x_priv {
struct yt921x_acl_blk *acl_blks[YT921X_ACL_BLK_NUM];
};
+#define dsa_to_yt921x_priv(_ds) container_of_const(_ds, struct yt921x_priv, ds)
#define yt921x_port_to_priv(pp) \
container_of_const((pp), struct yt921x_priv, ports[(pp)->index])
+#define yt921x_priv_to_device(priv) ((priv)->ds.dev)
static inline int ethtool_speed_to_yt921x(int speed)
{
@@ -1005,4 +668,14 @@ static inline int ethtool_speed_to_yt921x(int speed)
}
}
+static inline u32 ethaddr_hi4_to_u32(const unsigned char *addr)
+{
+ return (addr[0] << 24) | (addr[1] << 16) | (addr[2] << 8) | addr[3];
+}
+
+static inline u32 ethaddr_lo2_to_u32(const unsigned char *addr)
+{
+ return (addr[4] << 8) | addr[5];
+}
+
#endif
diff --git a/drivers/net/dsa/motorcomm/leds.c b/drivers/net/dsa/motorcomm/leds.c
index 6613fe3b0471e..a402d1cf28d13 100644
--- a/drivers/net/dsa/motorcomm/leds.c
+++ b/drivers/net/dsa/motorcomm/leds.c
@@ -12,7 +12,6 @@
#define to_yt921x_led(led_cdev) \
container_of_const((led_cdev), struct yt921x_led, cdev)
#define to_yt921x_port(led) ((led)->port)
-#define to_device(priv) ((priv)->ds.dev)
static u32 yt921x_led_regaddr(struct yt921x_priv *priv, int port, int group)
{
@@ -414,7 +413,7 @@ yt921x_led_setup(struct yt921x_priv *priv, int port,
struct fwnode_handle *fwnode)
{
struct yt921x_port *pp = &priv->ports[port];
- struct device *dev = to_device(priv);
+ struct device *dev = yt921x_priv_to_device(priv);
struct led_init_data init_data;
struct led_classdev *led_cdev;
char name[LED_MAX_NAME_SIZE];
@@ -569,7 +568,7 @@ yt921x_led_setup(struct yt921x_priv *priv, int port,
static void yt921x_leds_remove_port(struct yt921x_priv *priv, int port)
{
struct yt921x_port *pp = &priv->ports[port];
- struct device *dev = to_device(priv);
+ struct device *dev = yt921x_priv_to_device(priv);
for (int group = 0; group < YT921X_LED_GROUP_NUM; group++) {
struct yt921x_led *led = pp->leds[group];
@@ -587,7 +586,7 @@ static void yt921x_leds_remove_port(struct yt921x_priv *priv, int port)
static int yt921x_leds_setup_port(struct yt921x_priv *priv, int port)
{
- struct device *dev = to_device(priv);
+ struct device *dev = yt921x_priv_to_device(priv);
struct dsa_switch *ds = &priv->ds;
struct device_node *leds_np;
struct dsa_port *dp;
diff --git a/drivers/net/dsa/motorcomm/mdio_bus.c b/drivers/net/dsa/motorcomm/mdio_bus.c
index 1a3f3cc68275d..dd6c52f37bbf5 100644
--- a/drivers/net/dsa/motorcomm/mdio_bus.c
+++ b/drivers/net/dsa/motorcomm/mdio_bus.c
@@ -9,8 +9,6 @@
#include "mdio_bus.h"
#include "smi.h"
-#define to_device(priv) ((priv)->ds.dev)
-
static int yt921x_intif_wait(struct yt921x_priv *priv)
{
u32 val = 0;
@@ -21,7 +19,7 @@ static int yt921x_intif_wait(struct yt921x_priv *priv)
int yt921x_intif_read(struct yt921x_priv *priv, int port, int reg, u16 *valp)
{
- struct device *dev = to_device(priv);
+ struct device *dev = yt921x_priv_to_device(priv);
u32 mask;
u32 ctrl;
u32 val;
@@ -145,7 +143,7 @@ yt921x_mbus_int_write(struct mii_bus *mbus, int port, int reg, u16 data)
int yt921x_mbus_int_init(struct yt921x_priv *priv, struct device_node *mnp)
{
- struct device *dev = to_device(priv);
+ struct device *dev = yt921x_priv_to_device(priv);
struct mii_bus *mbus;
int res;
@@ -181,7 +179,7 @@ static int yt921x_extif_wait(struct yt921x_priv *priv)
static int
yt921x_extif_read(struct yt921x_priv *priv, int port, int reg, u16 *valp)
{
- struct device *dev = to_device(priv);
+ struct device *dev = yt921x_priv_to_device(priv);
u32 mask;
u32 ctrl;
u32 val;
@@ -275,7 +273,7 @@ yt921x_mbus_ext_write(struct mii_bus *mbus, int port, int reg, u16 data)
int yt921x_mbus_ext_init(struct yt921x_priv *priv, struct device_node *mnp)
{
- struct device *dev = to_device(priv);
+ struct device *dev = yt921x_priv_to_device(priv);
struct mii_bus *mbus;
int res;
diff --git a/drivers/net/dsa/motorcomm/pcs-921x.c b/drivers/net/dsa/motorcomm/pcs-921x.c
index 47467d803e136..e942b61d8eb2f 100644
--- a/drivers/net/dsa/motorcomm/pcs-921x.c
+++ b/drivers/net/dsa/motorcomm/pcs-921x.c
@@ -8,8 +8,6 @@
#include "pcs.h"
#include "smi.h"
-#define to_device(priv) ((priv)->ds.dev)
-
static int
yt921x_serdes_config(struct yt921x_priv *priv, int port, unsigned int neg_mode,
phy_interface_t interface,
@@ -116,7 +114,7 @@ yt921x_phylink_pcs_get_state(struct phylink_pcs *pcs, unsigned int neg_mode,
{
struct yt921x_port *pp = pcs_to_yt921x_port(pcs);
struct yt921x_priv *priv = yt921x_port_to_priv(pp);
- struct device *dev = to_device(priv);
+ struct device *dev = yt921x_priv_to_device(priv);
int port = pp->index;
u16 bmsr;
u16 lpa;
@@ -155,7 +153,7 @@ static void yt921x_phylink_pcs_an_restart(struct phylink_pcs *pcs)
{
struct yt921x_port *pp = pcs_to_yt921x_port(pcs);
struct yt921x_priv *priv = yt921x_port_to_priv(pp);
- struct device *dev = to_device(priv);
+ struct device *dev = yt921x_priv_to_device(priv);
int port = pp->index;
u16 val;
int res;
@@ -181,7 +179,7 @@ static void yt921x_phylink_pcs_disable(struct phylink_pcs *pcs)
{
struct yt921x_port *pp = pcs_to_yt921x_port(pcs);
struct yt921x_priv *priv = yt921x_port_to_priv(pp);
- struct device *dev = to_device(priv);
+ struct device *dev = yt921x_priv_to_device(priv);
int port = pp->index;
int res;
diff --git a/drivers/net/dsa/motorcomm/tc.c b/drivers/net/dsa/motorcomm/tc.c
new file mode 100644
index 0000000000000..c5581e85208f3
--- /dev/null
+++ b/drivers/net/dsa/motorcomm/tc.c
@@ -0,0 +1,1524 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Copyright (c) 2026 David Yang
+ */
+
+#include "chip.h"
+#include "smi.h"
+#include "tc.h"
+
+static int yt921x_mtu_fetch(struct yt921x_priv *priv, int port)
+{
+ struct dsa_port *dp = dsa_to_port(&priv->ds, port);
+
+ return dp->user ? READ_ONCE(dp->user->mtu) : ETH_DATA_LEN;
+}
+
+/* v * 2^e */
+static u64 ldexpu64(u64 v, int e)
+{
+ return e >= 0 ? v << e : v >> -e;
+}
+
+/* slot (ns) * rate (/s) / 10^9 (ns/s) = 2^C * token * 4^unit */
+static u32 rate2token(u64 rate, unsigned int slot_ns, int unit, int C)
+{
+ int e = 2 * unit + C + YT921X_TOKEN_RATE_C;
+
+ return div_u64(ldexpu64(slot_ns * rate, -e), NSEC_PER_SEC);
+}
+
+static u64 token2rate(u32 token, unsigned int slot_ns, int unit, int C)
+{
+ int e = 2 * unit + C + YT921X_TOKEN_RATE_C;
+
+ return div_u64(ldexpu64(mul_u32_u32(NSEC_PER_SEC, token), e), slot_ns);
+}
+
+/* burst = 2^C * token * 4^unit */
+static u32 burst2token(u64 burst, int unit, int C)
+{
+ return ldexpu64(burst, -(2 * unit + C));
+}
+
+static u64 token2burst(u32 token, int unit, int C)
+{
+ return ldexpu64(token, 2 * unit + C);
+}
+
+struct yt921x_marker {
+ u32 cir;
+ u32 cbs;
+ u32 ebs;
+ int unit;
+ bool pkt_mode;
+};
+
+#define YT921X_MARKER_PKT_MODE BIT(0)
+#define YT921X_MARKER_SINGLE_BUCKET BIT(1)
+
+static int
+yt921x_marker_tfm(struct yt921x_marker *marker, u64 rate, u64 burst,
+ unsigned int flags, unsigned int slot_ns, u32 cir_max,
+ u32 cbs_max, int unit_max, struct yt921x_priv *priv, int port,
+ struct netlink_ext_ack *extack)
+{
+ const int C = flags & YT921X_MARKER_PKT_MODE ? YT921X_TOKEN_PKT_C :
+ YT921X_TOKEN_BYTE_C;
+ struct device *dev = yt921x_priv_to_device(priv);
+ struct yt921x_marker m;
+ u64 burst_est;
+ u64 burst_sug;
+ u64 burst_max;
+ u64 rate_max;
+
+ m.unit = unit_max;
+ rate_max = token2rate(cir_max, slot_ns, m.unit, C);
+ burst_max = token2burst(cbs_max, m.unit, C);
+
+ /* Check for unusual values */
+ if (rate > rate_max || burst > burst_max) {
+ NL_SET_ERR_MSG_MOD(extack, "Unexpected tremendous rate");
+ return -ERANGE;
+ }
+
+ /* Check for matching burst */
+ burst_est = div_u64(slot_ns * rate, NSEC_PER_SEC);
+ burst_sug = burst_est;
+ if (flags & YT921X_MARKER_PKT_MODE)
+ burst_sug++;
+ else
+ burst_sug += ETH_HLEN + yt921x_mtu_fetch(priv, port) +
+ ETH_FCS_LEN;
+ if (burst_sug > burst)
+ NL_SET_ERR_MSG_FMT_MOD(extack,
+ "Consider match rate %llu with burst at least %llu",
+ rate, burst_sug);
+
+ /* Select unit */
+ for (; m.unit > 0; m.unit--) {
+ if (rate > (rate_max >> 2) || burst > (burst_max >> 2))
+ break;
+ rate_max >>= 2;
+ burst_max >>= 2;
+ }
+
+ /* Calculate information rate and bucket size */
+ m.cir = rate2token(rate, slot_ns, m.unit, C);
+ if (!m.cir)
+ m.cir = 1;
+ else if (WARN_ON(m.cir > cir_max))
+ m.cir = cir_max;
+ m.cbs = burst2token(burst, m.unit, C);
+ if (!m.cbs)
+ m.cbs = 1;
+ else if (WARN_ON(m.cbs > cbs_max))
+ m.cbs = cbs_max;
+
+ /* Cut EBS */
+ m.ebs = 0;
+ if (!(flags & YT921X_MARKER_SINGLE_BUCKET)) {
+ /* We don't have a chance to adjust rate when MTU is changed */
+ if (flags & YT921X_MARKER_PKT_MODE)
+ burst_est++;
+ else
+ burst_est += YT921X_FRAME_SIZE_MAX;
+
+ if (burst_est < burst) {
+ u32 pbs = m.cbs;
+
+ m.cbs = burst2token(burst_est, m.unit, C);
+ if (!m.cbs)
+ m.cbs = 1;
+ else if (WARN_ON(m.cbs > cbs_max))
+ m.cbs = cbs_max;
+
+ if (pbs > m.cbs)
+ m.ebs = pbs - m.cbs;
+ }
+ }
+
+ dev_dbg(dev,
+ "slot %u ns, rate %llu, burst %llu -> unit %d, cir %u, cbs %u, ebs %u\n",
+ slot_ns, rate, burst, m.unit, m.cir, m.cbs, m.ebs);
+
+ m.pkt_mode = flags & YT921X_MARKER_PKT_MODE;
+ *marker = m;
+ return 0;
+}
+
+static int
+yt921x_marker_tfm_police(struct yt921x_marker *marker,
+ const struct flow_action_police *police,
+ unsigned int flags, struct yt921x_priv *priv, int port,
+ struct netlink_ext_ack *extack)
+{
+ bool pkt_mode = !!police->rate_pkt_ps;
+ u64 burst;
+ u64 rate;
+
+ rate = pkt_mode ? police->rate_pkt_ps : police->rate_bytes_ps;
+ burst = pkt_mode ? police->burst_pkt : police->burst;
+ if (pkt_mode)
+ flags |= YT921X_MARKER_PKT_MODE;
+
+ return yt921x_marker_tfm(marker, rate, burst, flags,
+ priv->meter_slot_ns, YT921X_METER_CIR_MAX,
+ YT921X_METER_CBS_MAX, YT921X_METER_UNIT_MAX,
+ priv, port, extack);
+}
+
+static int
+yt921x_marker_tfm_shape(struct yt921x_marker *marker, u64 rate, u64 burst,
+ unsigned int flags, struct yt921x_priv *priv, int port,
+ struct netlink_ext_ack *extack)
+{
+ return yt921x_marker_tfm(marker, rate, burst, flags,
+ priv->port_shape_slot_ns, YT921X_SHAPE_CIR_MAX,
+ YT921X_SHAPE_CBS_MAX, YT921X_SHAPE_UNIT_MAX,
+ priv, port, extack);
+}
+
+static int
+yt921x_police_validate(const struct flow_action_police *police,
+ const struct flow_action *action,
+ const struct flow_action_entry *act,
+ struct netlink_ext_ack *extack)
+{
+ if (police->exceed.act_id != FLOW_ACTION_DROP) {
+ NL_SET_ERR_MSG_MOD(extack,
+ "Offload not supported when exceed action is not drop");
+ return -EOPNOTSUPP;
+ }
+
+ if (police->notexceed.act_id != FLOW_ACTION_PIPE &&
+ police->notexceed.act_id != FLOW_ACTION_ACCEPT) {
+ NL_SET_ERR_MSG_MOD(extack,
+ "Offload not supported when conform action is not pipe or ok");
+ return -EOPNOTSUPP;
+ }
+
+ if (police->notexceed.act_id == FLOW_ACTION_ACCEPT && action && act &&
+ !flow_action_is_last_entry(action, act)) {
+ NL_SET_ERR_MSG_MOD(extack,
+ "Offload not supported when conform action is ok, but action is not last");
+ return -EOPNOTSUPP;
+ }
+
+ /* mtu defaults to unlimited but we got 2040 here, don't know why */
+ if (police->peakrate_bytes_ps || police->avrate || police->overhead) {
+ NL_SET_ERR_MSG_MOD(extack,
+ "Offload not supported when peakrate/avrate/overhead is configured");
+ return -EOPNOTSUPP;
+ }
+
+ return 0;
+}
+
+static int
+yt921x_meter_config(struct yt921x_priv *priv, unsigned int id,
+ const struct yt921x_marker *marker)
+{
+ u32 ctrls[3];
+
+ ctrls[0] = 0;
+ ctrls[1] = YT921X_METER_CTRLb_CIR(marker->cir);
+ ctrls[2] = YT921X_METER_CTRLc_UNIT(marker->unit) |
+ YT921X_METER_CTRLc_DROP_R |
+ YT921X_METER_CTRLc_TOKEN_OVERFLOW_EN |
+ YT921X_METER_CTRLc_METER_EN;
+ if (marker->pkt_mode)
+ ctrls[2] |= YT921X_METER_CTRLc_PKT_MODE;
+ update_ctrls_unaligned(&ctrls[0], &ctrls[1],
+ YT921X_METER_CTRLab_EBS_M,
+ YT921X_METER_CTRLab_EBS(marker->ebs));
+ update_ctrls_unaligned(&ctrls[1], &ctrls[2],
+ YT921X_METER_CTRLbc_CBS_M,
+ YT921X_METER_CTRLbc_CBS(marker->cbs));
+
+ return yt921x_reg96_write(priv, YT921X_METERn_CTRL(id), ctrls);
+}
+
+void yt921x_dsa_port_policer_del(struct dsa_switch *ds, int port)
+{
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(ds);
+ struct device *dev = yt921x_priv_to_device(priv);
+ int res;
+
+ mutex_lock(&priv->reg_lock);
+ res = yt921x_reg_write(priv, YT921X_PORTn_METER(port), 0);
+ mutex_unlock(&priv->reg_lock);
+
+ if (res)
+ dev_err(dev, "Failed to %s port %d: %i\n", "delete policer on",
+ port, res);
+}
+
+int
+yt921x_dsa_port_policer_add(struct dsa_switch *ds, int port,
+ const struct flow_action_police *police,
+ struct netlink_ext_ack *extack)
+{
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(ds);
+ struct yt921x_marker marker;
+ u32 ctrl;
+ int res;
+
+ res = yt921x_police_validate(police, NULL, NULL, extack);
+ if (res)
+ return res;
+
+ res = yt921x_marker_tfm_police(&marker, police, 0, priv, port, extack);
+ if (res)
+ return res;
+
+ mutex_lock(&priv->reg_lock);
+ res = yt921x_meter_config(priv, port + YT921X_METER_NUM, &marker);
+ if (res)
+ goto end;
+
+ ctrl = YT921X_PORT_METER_ID(port) | YT921X_PORT_METER_EN;
+ res = yt921x_reg_write(priv, YT921X_PORTn_METER(port), ctrl);
+end:
+ mutex_unlock(&priv->reg_lock);
+
+ return res;
+}
+
+static int
+yt921x_dsa_port_setup_tc_tbf_port(struct dsa_switch *ds, int port,
+ const struct tc_tbf_qopt_offload *qopt)
+{
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(ds);
+ struct netlink_ext_ack *extack = qopt->extack;
+ u32 ctrls[2];
+ int res;
+
+ if (qopt->parent != TC_H_ROOT)
+ return -EOPNOTSUPP;
+
+ switch (qopt->command) {
+ case TC_TBF_STATS:
+ /* Unfortunately the convention for TC_*_STATS is a mess,
+ * neither 0 nor -EOPNOTSUPP is perfect here.
+ */
+ return -EOPNOTSUPP;
+ case TC_TBF_DESTROY:
+ ctrls[0] = 0;
+ ctrls[1] = 0;
+ break;
+ case TC_TBF_REPLACE: {
+ const struct tc_tbf_qopt_offload_replace_params *p;
+ struct yt921x_marker marker;
+
+ p = &qopt->replace_params;
+
+ res = yt921x_marker_tfm_shape(&marker, p->rate.rate_bytes_ps,
+ p->max_size,
+ YT921X_MARKER_SINGLE_BUCKET,
+ priv, port, extack);
+ if (res)
+ return res;
+
+ ctrls[0] = YT921X_PORT_SHAPE_CTRLa_CIR(marker.cir) |
+ YT921X_PORT_SHAPE_CTRLa_CBS(marker.cbs);
+ ctrls[1] = YT921X_PORT_SHAPE_CTRLb_UNIT(marker.unit) |
+ YT921X_PORT_SHAPE_CTRLb_EN;
+ break;
+ }
+ default:
+ return -EOPNOTSUPP;
+ }
+
+ mutex_lock(&priv->reg_lock);
+ res = yt921x_reg64_write(priv, YT921X_PORTn_SHAPE_CTRL(port), ctrls);
+ mutex_unlock(&priv->reg_lock);
+
+ return res;
+}
+
+int
+yt921x_dsa_port_setup_tc(struct dsa_switch *ds, int port,
+ enum tc_setup_type type, void *type_data)
+{
+ switch (type) {
+ case TC_SETUP_QDISC_TBF: {
+ const struct tc_tbf_qopt_offload *qopt = type_data;
+
+ return yt921x_dsa_port_setup_tc_tbf_port(ds, port, qopt);
+ }
+ default:
+ return -EOPNOTSUPP;
+ }
+}
+
+/* ACL: 48 blocks * 8 entries
+ *
+ * One rule can span multiple entries, but within a block.
+ */
+
+static void
+yt921x_acl_entry_set(struct yt921x_acl_entry *entry, unsigned int offset,
+ u32 flags, bool set)
+{
+ if (set)
+ entry->key[offset] |= flags;
+ entry->mask[offset] |= flags;
+}
+
+static unsigned int
+yt921x_acl_entries_set_is_fragment(struct yt921x_acl_entry *entries,
+ unsigned int size, bool set)
+{
+ for (unsigned int i = 0; i < size; i++)
+ switch (FIELD_GET(YT921X_ACL_KEYb_TYPE_M, entries[i].key[1])) {
+ case YT921X_ACL_TYPE_IPV4_DA:
+ case YT921X_ACL_TYPE_IPV4_SA:
+ yt921x_acl_entry_set(&entries[i], 1,
+ YT921X_ACL_BINb_IPV4_FRAG, set);
+ return size;
+ case YT921X_ACL_TYPE_IPV6_DA3:
+ case YT921X_ACL_TYPE_IPV6_SA3:
+ yt921x_acl_entry_set(&entries[i], 1,
+ YT921X_ACL_BINb_IPV6_xA3_FRAG,
+ set);
+ return size;
+ case YT921X_ACL_TYPE_MISC:
+ yt921x_acl_entry_set(&entries[i], 1,
+ YT921X_ACL_BINb_MISC_FRAG, set);
+ return size;
+ case YT921X_ACL_TYPE_L4:
+ yt921x_acl_entry_set(&entries[i], 1,
+ YT921X_ACL_BINb_L4_FRAG, set);
+ return size;
+ }
+
+ if (size >= YT921X_ACL_ENT_PER_BLK)
+ return 0;
+
+ entries[size] = (typeof(*entries)){};
+ entries[size].key[1] = YT921X_ACL_KEYb_TYPE(YT921X_ACL_TYPE_MISC);
+ yt921x_acl_entry_set(&entries[size], 1, YT921X_ACL_BINb_MISC_FRAG, set);
+
+ return size + 1;
+}
+
+static unsigned int
+yt921x_acl_entries_set_first_frag(struct yt921x_acl_entry *entries,
+ unsigned int size, bool set)
+{
+ for (unsigned int i = 0; i < size; i++)
+ switch (FIELD_GET(YT921X_ACL_KEYb_TYPE_M, entries[i].key[1])) {
+ case YT921X_ACL_TYPE_IPV6_DA2:
+ case YT921X_ACL_TYPE_IPV6_SA2:
+ yt921x_acl_entry_set(&entries[i], 1,
+ YT921X_ACL_BINb_IPV6_xA2_FIRST_FRAG,
+ set);
+ return size;
+ case YT921X_ACL_TYPE_MISC:
+ yt921x_acl_entry_set(&entries[i], 0,
+ YT921X_ACL_BINa_MISC_FIRST_FRAG,
+ set);
+ return size;
+ }
+
+ if (size >= YT921X_ACL_ENT_PER_BLK)
+ return 0;
+
+ entries[size] = (typeof(*entries)){};
+ entries[size].key[1] = YT921X_ACL_KEYb_TYPE(YT921X_ACL_TYPE_MISC);
+ yt921x_acl_entry_set(&entries[size], 0,
+ YT921X_ACL_BINa_MISC_FIRST_FRAG, set);
+
+ return size + 1;
+}
+
+static unsigned int
+yt921x_acl_entries_set_l3_type(struct yt921x_acl_entry *entries,
+ unsigned int size, enum yt921x_l3_type type)
+{
+ for (unsigned int i = 0; i < size; i++)
+ switch (FIELD_GET(YT921X_ACL_KEYb_TYPE_M, entries[i].key[1])) {
+ case YT921X_ACL_TYPE_MAC_DA0:
+ case YT921X_ACL_TYPE_MAC_SA0:
+ entries[i].key[1] |= YT921X_ACL_BINb_MAC_xA0_L3_TYPE(type);
+ entries[i].mask[1] |= YT921X_ACL_BINb_MAC_xA0_L3_TYPE_M;
+ return size;
+ case YT921X_ACL_TYPE_MISC:
+ entries[i].key[0] |= YT921X_ACL_BINa_MISC_L3_TYPE(type);
+ entries[i].mask[0] |= YT921X_ACL_BINa_MISC_L3_TYPE_M;
+ return size;
+ }
+
+ if (size >= YT921X_ACL_ENT_PER_BLK)
+ return 0;
+
+ entries[size] = (typeof(*entries)){};
+ entries[size].key[0] = YT921X_ACL_BINa_MISC_L3_TYPE(type);
+ entries[size].key[1] = YT921X_ACL_KEYb_TYPE(YT921X_ACL_TYPE_MISC);
+ entries[size].mask[0] = YT921X_ACL_BINa_MISC_L3_TYPE_M;
+
+ return size + 1;
+}
+
+static unsigned int
+yt921x_acl_entries_set_l4_type(struct yt921x_acl_entry *entries,
+ unsigned int size, enum yt921x_l4_type type)
+{
+ for (unsigned int i = 0; i < size; i++)
+ switch (FIELD_GET(YT921X_ACL_KEYb_TYPE_M, entries[i].key[1])) {
+ case YT921X_ACL_TYPE_IPV4_DA:
+ case YT921X_ACL_TYPE_IPV4_SA:
+ entries[i].key[1] |= YT921X_ACL_BINb_IPV4_L4_TYPE(type);
+ entries[i].mask[1] |= YT921X_ACL_BINb_IPV4_L4_TYPE_M;
+ return size;
+ case YT921X_ACL_TYPE_IPV6_DA0:
+ case YT921X_ACL_TYPE_IPV6_DA1:
+ case YT921X_ACL_TYPE_IPV6_DA2:
+ case YT921X_ACL_TYPE_IPV6_DA3:
+ case YT921X_ACL_TYPE_IPV6_SA0:
+ case YT921X_ACL_TYPE_IPV6_SA1:
+ case YT921X_ACL_TYPE_IPV6_SA2:
+ case YT921X_ACL_TYPE_IPV6_SA3:
+ entries[i].key[1] |= YT921X_ACL_BINb_IPV6_L4_TYPE(type);
+ entries[i].mask[1] |= YT921X_ACL_BINb_IPV6_L4_TYPE_M;
+ return size;
+ case YT921X_ACL_TYPE_L4:
+ entries[i].key[1] |= YT921X_ACL_BINb_L4_TYPE(type);
+ entries[i].mask[1] |= YT921X_ACL_BINb_L4_TYPE_M;
+ return size;
+ case YT921X_ACL_TYPE_MISC:
+ entries[i].key[1] |= YT921X_ACL_BINb_MISC_L4_TYPE(type);
+ entries[i].mask[1] |= YT921X_ACL_BINb_MISC_L4_TYPE_M;
+ return size;
+ }
+
+ if (size >= YT921X_ACL_ENT_PER_BLK)
+ return 0;
+
+ entries[size] = (typeof(*entries)){};
+ entries[size].key[1] = YT921X_ACL_BINb_MISC_L4_TYPE(type) |
+ YT921X_ACL_KEYb_TYPE(YT921X_ACL_TYPE_MISC);
+ entries[size].mask[1] = YT921X_ACL_BINb_MISC_L4_TYPE_M;
+
+ return size + 1;
+}
+
+static struct yt921x_acl_entry *
+yt921x_acl_entries_new(struct yt921x_acl_entry *entries, unsigned int *sizep,
+ u32 type)
+{
+ unsigned int size = *sizep;
+
+ if (size >= YT921X_ACL_ENT_PER_BLK)
+ return NULL;
+
+ entries[size] = (typeof(*entries)){};
+ entries[size].key[1] = YT921X_ACL_KEYb_TYPE(type);
+
+ (*sizep)++;
+ return &entries[size];
+}
+
+static struct yt921x_acl_entry *
+yt921x_acl_entries_find(struct yt921x_acl_entry *entries, unsigned int *sizep,
+ u32 type)
+{
+ for (unsigned int i = 0; i < *sizep; i++)
+ if (FIELD_GET(YT921X_ACL_KEYb_TYPE_M, entries[i].key[1]) ==
+ type)
+ return &entries[i];
+ return yt921x_acl_entries_new(entries, sizep, type);
+}
+
+static void
+yt921x_acl_rule_set_ports(struct yt921x_acl_rule *aclrule, u16 ord,
+ u16 ports_mask)
+{
+ struct yt921x_acl_entry *entries = aclrule->entries;
+
+ for (unsigned int i = 0; i < hweight8(aclrule->mask); i++) {
+ entries[i].key[1] |= YT921X_ACL_KEYb_SPORTS(ports_mask) |
+ YT921X_ACL_KEYb_ORD(ord);
+ }
+}
+
+struct yt921x_acl_rule_ext {
+ struct yt921x_acl_rule r;
+
+ struct yt921x_marker marker;
+};
+
+static int
+yt921x_acl_rule_ext_parse_flow_entries(struct yt921x_acl_rule_ext *ruleext,
+ const struct flow_cls_offload *cls)
+{
+ const struct flow_rule *rule = flow_cls_offload_flow_rule(cls);
+ struct yt921x_acl_entry *entries = ruleext->r.entries;
+ struct netlink_ext_ack *extack = cls->common.extack;
+ const struct flow_dissector *dissector;
+ struct yt921x_acl_entry *entry;
+ unsigned int size = 0;
+ bool use_dport;
+ bool use_sport;
+
+ /* Incomplete and probably won't, since it supports custom u32 filters.
+ * New adapters are welcome.
+ */
+ dissector = rule->match.dissector;
+ if (dissector->used_keys &
+ ~(BIT_ULL(FLOW_DISSECTOR_KEY_CONTROL) |
+ BIT_ULL(FLOW_DISSECTOR_KEY_BASIC) |
+ BIT_ULL(FLOW_DISSECTOR_KEY_IPV4_ADDRS) |
+ BIT_ULL(FLOW_DISSECTOR_KEY_IPV6_ADDRS) |
+ BIT_ULL(FLOW_DISSECTOR_KEY_PORTS) |
+ BIT_ULL(FLOW_DISSECTOR_KEY_PORTS_RANGE) |
+ BIT_ULL(FLOW_DISSECTOR_KEY_ETH_ADDRS) |
+ BIT_ULL(FLOW_DISSECTOR_KEY_IP) |
+ BIT_ULL(FLOW_DISSECTOR_KEY_TCP))) {
+ NL_SET_ERR_MSG_MOD(extack, "Unsupported keys used");
+ return -EOPNOTSUPP;
+ }
+
+ /* Entries */
+ if (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_IPV4_ADDRS)) {
+ struct flow_match_ipv4_addrs match;
+
+ flow_rule_match_ipv4_addrs(rule, &match);
+
+ if (match.mask->dst) {
+ entry = yt921x_acl_entries_new(entries, &size,
+ YT921X_ACL_TYPE_IPV4_DA);
+ if (!entry)
+ goto err;
+
+ entry->key[0] |= ntohl(match.key->dst);
+ entry->mask[0] |= ntohl(match.mask->dst);
+ }
+
+ if (match.mask->src) {
+ entry = yt921x_acl_entries_new(entries, &size,
+ YT921X_ACL_TYPE_IPV4_SA);
+ if (!entry)
+ goto err;
+
+ entry->key[0] |= ntohl(match.key->src);
+ entry->mask[0] |= ntohl(match.mask->src);
+ }
+ }
+
+ if (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_IPV6_ADDRS)) {
+ struct flow_match_ipv6_addrs match;
+
+ flow_rule_match_ipv6_addrs(rule, &match);
+
+ for (unsigned int i = 0; i < 4; i++) {
+ if (!match.mask->dst.s6_addr32[i])
+ continue;
+
+ entry = yt921x_acl_entries_new(entries, &size,
+ YT921X_ACL_TYPE_IPV6_DA0 + i);
+ if (!entry)
+ goto err;
+
+ entry->key[0] |= ntohl(match.key->dst.s6_addr32[i]);
+ entry->mask[0] |= ntohl(match.mask->dst.s6_addr32[i]);
+ }
+
+ for (unsigned int i = 0; i < 4; i++) {
+ if (!match.mask->src.s6_addr32[i])
+ continue;
+
+ entry = yt921x_acl_entries_new(entries, &size,
+ YT921X_ACL_TYPE_IPV6_SA0 + i);
+ if (!entry)
+ goto err;
+
+ entry->key[0] |= ntohl(match.key->src.s6_addr32[i]);
+ entry->mask[0] |= ntohl(match.mask->src.s6_addr32[i]);
+ }
+ }
+
+ use_dport = false;
+ use_sport = false;
+ if (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_PORTS)) {
+ struct flow_match_ports match;
+
+ entry = yt921x_acl_entries_new(entries, &size,
+ YT921X_ACL_TYPE_L4);
+ if (!entry)
+ goto err;
+
+ flow_rule_match_ports(rule, &match);
+
+ use_dport = !!match.mask->dst;
+ use_sport = !!match.mask->src;
+
+ entry->key[0] |= (ntohs(match.key->dst) << 16) |
+ ntohs(match.key->src);
+ entry->mask[0] |= (ntohs(match.mask->dst) << 16) |
+ ntohs(match.mask->src);
+ }
+
+ if (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_PORTS_RANGE)) {
+ struct flow_match_ports_range match;
+
+ entry = yt921x_acl_entries_find(entries, &size,
+ YT921X_ACL_TYPE_L4);
+ if (!entry)
+ goto err;
+
+ flow_rule_match_ports_range(rule, &match);
+
+ if ((use_dport && match.mask->tp.dst) ||
+ (use_sport && match.mask->tp.src)) {
+ NL_SET_ERR_MSG_MOD(extack,
+ "Port mask and range are mutually exclusive");
+ return -EINVAL;
+ }
+
+ if (match.mask->tp.dst) {
+ entry->key[0] |= ntohs(match.key->tp_min.dst) << 16;
+ entry->key[1] |= YT921X_ACL_KEYb_L4_DPORT_RANGE_EN;
+ entry->mask[0] |= ntohs(match.key->tp_max.dst) << 16;
+ }
+
+ if (match.mask->tp.src) {
+ entry->key[0] |= ntohs(match.key->tp_min.src);
+ entry->key[1] |= YT921X_ACL_KEYb_L4_SPORT_RANGE_EN;
+ entry->mask[0] |= ntohs(match.key->tp_max.src);
+ }
+ }
+
+ if (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_ETH_ADDRS)) {
+ struct flow_match_eth_addrs match;
+ u32 mask;
+
+ flow_rule_match_eth_addrs(rule, &match);
+
+ mask = ethaddr_hi4_to_u32(match.mask->dst);
+ if (mask) {
+ entry = yt921x_acl_entries_new(entries, &size,
+ YT921X_ACL_TYPE_MAC_DA0);
+ if (!entry)
+ goto err;
+
+ entry->key[0] |= ethaddr_hi4_to_u32(match.key->dst);
+ entry->mask[0] |= mask;
+ }
+
+ mask = ethaddr_hi4_to_u32(match.mask->src);
+ if (mask) {
+ entry = yt921x_acl_entries_new(entries, &size,
+ YT921X_ACL_TYPE_MAC_SA0);
+ if (!entry)
+ goto err;
+
+ entry->key[0] |= ethaddr_hi4_to_u32(match.key->src);
+ entry->mask[0] |= mask;
+ }
+
+ mask = (ethaddr_lo2_to_u32(match.mask->dst) << 16) |
+ ethaddr_lo2_to_u32(match.mask->src);
+ if (mask) {
+ entry = yt921x_acl_entries_new(entries, &size,
+ YT921X_ACL_TYPE_MAC_DA1_SA1);
+ if (!entry)
+ goto err;
+
+ entry->key[0] |= (ethaddr_lo2_to_u32(match.key->dst) << 16) |
+ ethaddr_lo2_to_u32(match.key->src);
+ entry->mask[0] |= mask;
+ }
+ }
+
+ /* Entries + Misc */
+ if (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_BASIC)) {
+ struct flow_match_basic match;
+
+ flow_rule_match_basic(rule, &match);
+
+ if (match.mask->n_proto) {
+ enum yt921x_l3_type l3type = YT921X_L3_TYPE_OTHER;
+
+ if (match.mask->n_proto == htons(~0))
+ switch (match.key->n_proto) {
+ case htons(ETH_P_IP):
+ l3type = YT921X_L3_TYPE_IPV4;
+ break;
+ case htons(ETH_P_IPV6):
+ l3type = YT921X_L3_TYPE_IPV6;
+ break;
+ case htons(ETH_P_ARP):
+ l3type = YT921X_L3_TYPE_ARP;
+ break;
+ case htons(ETH_P_LLDP):
+ l3type = YT921X_L3_TYPE_LLDP;
+ break;
+ case htons(ETH_P_PAE):
+ l3type = YT921X_L3_TYPE_PAE;
+ break;
+ case htons(ETH_P_CFM):
+ l3type = YT921X_L3_TYPE_ERP;
+ break;
+ }
+
+ if (l3type != YT921X_L3_TYPE_OTHER) {
+ size = yt921x_acl_entries_set_l3_type(entries,
+ size,
+ l3type);
+ if (!size)
+ goto err;
+ } else {
+ entry = yt921x_acl_entries_new(entries, &size,
+ YT921X_ACL_TYPE_ETHERTYPE);
+ if (!entry)
+ goto err;
+
+ entry->key[0] |= ntohs(match.key->n_proto);
+ entry->mask[0] |= ntohs(match.mask->n_proto);
+ }
+ }
+
+ if (match.mask->ip_proto) {
+ enum yt921x_l4_type l4type = YT921X_L4_TYPE_OTHER;
+
+ if (match.mask->ip_proto == (u8)~0)
+ switch (match.key->ip_proto) {
+ case IPPROTO_TCP:
+ l4type = YT921X_L4_TYPE_TCP;
+ break;
+ case IPPROTO_UDP:
+ l4type = YT921X_L4_TYPE_UDP;
+ break;
+ case IPPROTO_UDPLITE:
+ l4type = YT921X_L4_TYPE_UDPLITE;
+ break;
+ case IPPROTO_ICMP:
+ l4type = YT921X_L4_TYPE_ICMP;
+ break;
+ case IPPROTO_IGMP:
+ l4type = YT921X_L4_TYPE_IGMP;
+ break;
+ }
+
+ if (l4type != YT921X_L4_TYPE_OTHER) {
+ size = yt921x_acl_entries_set_l4_type(entries,
+ size,
+ l4type);
+ if (!size)
+ goto err;
+ } else {
+ entry = yt921x_acl_entries_find(entries, &size,
+ YT921X_ACL_TYPE_MISC);
+ if (!entry)
+ goto err;
+
+ entry->key[0] |= YT921X_ACL_BINa_MISC_IP_PROTO(match.key->ip_proto);
+ entry->mask[0] |= YT921X_ACL_BINa_MISC_IP_PROTO(match.mask->ip_proto);
+ }
+ }
+ }
+
+ if (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_CONTROL)) {
+ u32 supp_flags = FLOW_DIS_IS_FRAGMENT | FLOW_DIS_FIRST_FRAG;
+ struct flow_match_control match;
+
+ flow_rule_match_control(rule, &match);
+ if (!flow_rule_is_supp_control_flags(supp_flags,
+ match.mask->flags, extack))
+ return -EOPNOTSUPP;
+
+ if (match.mask->flags & FLOW_DIS_IS_FRAGMENT) {
+ bool set = match.key->flags & FLOW_DIS_IS_FRAGMENT;
+
+ size = yt921x_acl_entries_set_is_fragment(entries, size,
+ set);
+ if (!size)
+ goto err;
+ }
+ if (match.mask->flags & FLOW_DIS_FIRST_FRAG) {
+ bool set = match.key->flags & FLOW_DIS_FIRST_FRAG;
+
+ size = yt921x_acl_entries_set_first_frag(entries, size,
+ set);
+ if (!size)
+ goto err;
+ }
+ }
+
+ /* Misc only */
+ if (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_IP)) {
+ struct flow_match_ip match;
+
+ flow_rule_match_ip(rule, &match);
+ if (match.mask->ttl) {
+ NL_SET_ERR_MSG_MOD(extack,
+ "Matching on TTL not supported");
+ return -EOPNOTSUPP;
+ }
+
+ if (match.mask->tos) {
+ entry = yt921x_acl_entries_find(entries, &size,
+ YT921X_ACL_TYPE_MISC);
+ if (!entry)
+ goto err;
+
+ entry->key[0] |= YT921X_ACL_BINa_MISC_TOS(match.key->tos);
+ entry->mask[0] |= YT921X_ACL_BINa_MISC_TOS(match.mask->tos);
+ }
+ }
+
+ if (flow_rule_match_key(rule, FLOW_DISSECTOR_KEY_TCP)) {
+ struct flow_match_tcp match;
+
+ flow_rule_match_tcp(rule, &match);
+ if (match.mask->flags & htons(~0xff)) {
+ NL_SET_ERR_MSG_MOD(extack, "Unsupported TCP flags");
+ return -EOPNOTSUPP;
+ }
+
+ if (match.mask->flags) {
+ entry = yt921x_acl_entries_find(entries, &size,
+ YT921X_ACL_TYPE_MISC);
+ if (!entry)
+ goto err;
+
+ entry->key[0] |= YT921X_ACL_BINa_MISC_TCP_FLAGS(ntohs(match.key->flags));
+ entry->mask[0] |= YT921X_ACL_BINa_MISC_TCP_FLAGS(ntohs(match.mask->flags));
+ }
+ }
+
+ if (!size) {
+ NL_SET_ERR_MSG_MOD(extack, "Empty rule generated, this should not happen");
+ return -EOPNOTSUPP;
+ }
+
+ ruleext->r.mask = (1 << size) - 1;
+ return 0;
+
+err:
+ NL_SET_ERR_MSG_MOD(extack, "Rule too complex");
+ return -EOPNOTSUPP;
+}
+
+static int
+yt921x_acl_rule_ext_parse_flow_action(struct yt921x_acl_rule_ext *ruleext,
+ const struct flow_cls_offload *cls,
+ struct yt921x_priv *priv, int port)
+{
+ const struct flow_rule *rule = flow_cls_offload_flow_rule(cls);
+ const struct flow_action *flow_action = &rule->action;
+ struct netlink_ext_ack *extack = cls->common.extack;
+ enum flow_action_id redir_act = NUM_FLOW_ACTIONS;
+ const struct flow_action_entry *act;
+ u32 *action = ruleext->r.action;
+ bool seen_priority = false;
+ const char *reason = NULL;
+ bool seen_police = false;
+ unsigned int i;
+ int res;
+
+ memset(action, 0, 3 * sizeof(*action));
+ flow_action_for_each(i, act, flow_action)
+ switch (act->id) {
+ case FLOW_ACTION_ACCEPT:
+ case FLOW_ACTION_DROP:
+ case FLOW_ACTION_REDIRECT:
+ if (redir_act != NUM_FLOW_ACTIONS &&
+ redir_act != act->id) {
+ reason = "Different redirect actions";
+ goto fallback;
+ }
+ redir_act = act->id;
+
+ switch (act->id) {
+ case FLOW_ACTION_ACCEPT:
+ action[2] |= YT921X_ACL_ACTc_FWD_EN |
+ YT921X_ACL_ACTc_FWD_FWD;
+ break;
+ case FLOW_ACTION_DROP:
+ action[2] |= YT921X_ACL_ACTc_FWD_EN |
+ YT921X_ACL_ACTc_FWD_REDIR;
+ break;
+ case FLOW_ACTION_REDIRECT: {
+ struct dsa_port *to_dp;
+
+ to_dp = dsa_port_from_netdev(act->dev);
+ if (IS_ERR(to_dp) || to_dp->ds != &priv->ds) {
+ reason = "Redirect to non-local port";
+ goto fallback;
+ }
+
+ action[2] |= YT921X_ACL_ACTc_FWD_EN |
+ YT921X_ACL_ACTc_FWD_REDIR |
+ YT921X_ACL_ACTc_FWD_REDIR_DPORTn(to_dp->index);
+ break;
+ }
+ default:
+ break;
+ }
+ break;
+ case FLOW_ACTION_PRIORITY:
+ if (seen_priority) {
+ action[0] &= ~YT921X_ACL_ACTa_PRIO_EN;
+ action[1] &= ~YT921X_ACL_ACTb_PRIO_M;
+
+ reason = "Multiple priority actions";
+ goto fallback;
+ }
+ seen_priority = true;
+
+ if (act->priority >= YT921X_PRIO_NUM) {
+ NL_SET_ERR_MSG_MOD(extack,
+ "Priority value is too high");
+ return -EOPNOTSUPP;
+ }
+ action[0] |= YT921X_ACL_ACTa_PRIO_EN;
+ action[1] |= YT921X_ACL_ACTb_PRIO(act->priority);
+ break;
+ case FLOW_ACTION_POLICE: {
+ const struct flow_action_police *police = &act->police;
+
+ if (seen_police) {
+ action[0] &= ~YT921X_ACL_ACTa_METER_EN;
+
+ reason = "Multiple police actions";
+ goto fallback;
+ }
+ seen_police = true;
+
+ res = yt921x_police_validate(police, flow_action, act,
+ extack);
+ if (res)
+ return res;
+
+ res = yt921x_marker_tfm_police(&ruleext->marker, police,
+ 0, priv, port, extack);
+ if (res)
+ return res;
+
+ action[0] |= YT921X_ACL_ACTa_METER_EN;
+ break;
+ }
+ default:
+fallback:
+ if (cls->common.skip_sw) {
+ NL_SET_ERR_MSG_FMT_MOD(extack,
+ "Action not supported when skip_sw: %s",
+ reason);
+ return -EOPNOTSUPP;
+ }
+ fallthrough;
+ case FLOW_ACTION_TRAP:
+ redir_act = FLOW_ACTION_TRAP;
+
+ action[2] &= ~YT921X_ACL_ACTc_FWD_REDIR_DPORTS_M &
+ ~YT921X_ACL_ACTc_FWD_M;
+ action[2] |= YT921X_ACL_ACTc_FWD_EN |
+ YT921X_ACL_ACTc_FWD_TRAP;
+ break;
+ }
+
+ ruleext->r.sw_assisted = !cls->common.skip_sw;
+ return 0;
+}
+
+static int
+yt921x_acl_rule_ext_parse_flow(struct yt921x_acl_rule_ext *ruleext, int port,
+ const struct flow_cls_offload *cls, bool ingress,
+ struct yt921x_priv *priv)
+{
+ const unsigned int scale = (U16_MAX + 1) / YT921X_ACL_ORD_NUM;
+ struct netlink_ext_ack *extack = cls->common.extack;
+ u32 prio = cls->common.prio;
+ u32 ord;
+ int res;
+
+ if (!ingress) {
+ NL_SET_ERR_MSG_MOD(extack, "Only ingress is supported");
+ return -EOPNOTSUPP;
+ }
+
+ if (cls->common.chain_index) {
+ NL_SET_ERR_MSG(extack, "Only chain 0 is supported");
+ return -EOPNOTSUPP;
+ }
+
+ /* TC prio can't be 0 & TC lowest first -> HW highest first
+ * map 1...U16_MAX to (ACL_ORD_NUM - 1)...0
+ */
+ if (prio == U16_MAX) {
+ ord = 0;
+ } else if (!(prio % scale)) {
+ ord = YT921X_ACL_ORD_NUM - prio / scale;
+ } else {
+ NL_SET_ERR_MSG_FMT_MOD(extack,
+ "Invalid priority %u, must be a multiple of %u or 65535",
+ prio, scale);
+ return -EOPNOTSUPP;
+ }
+
+ res = yt921x_acl_rule_ext_parse_flow_action(ruleext, cls, priv, port);
+ if (res)
+ return res;
+ res = yt921x_acl_rule_ext_parse_flow_entries(ruleext, cls);
+ if (res)
+ return res;
+
+ yt921x_acl_rule_set_ports(&ruleext->r, ord, BIT(port));
+ ruleext->r.tag = cls->cookie;
+ ruleext->r.type = TC_SETUP_CLSFLOWER;
+ return 0;
+}
+
+static u16 yt921x_acl_activated_ports(const struct yt921x_priv *priv)
+{
+ u16 mask = 0;
+
+ for (int port = 0; port < YT921X_PORT_NUM; port++)
+ if (priv->ports[port].acl_cnt)
+ mask |= BIT(port);
+
+ return mask;
+}
+
+static unsigned int
+yt921x_acl_find(const struct yt921x_priv *priv, enum tc_setup_type type,
+ unsigned long tag)
+{
+ for (unsigned int blkid = 0; blkid < YT921X_ACL_BLK_NUM; blkid++) {
+ const struct yt921x_acl_blk *aclblk = priv->acl_blks[blkid];
+
+ if (!aclblk)
+ continue;
+
+ for (unsigned int i = 0; i < YT921X_ACL_ENT_PER_BLK; i++)
+ if (aclblk->rules[i] && aclblk->rules[i]->tag == tag &&
+ aclblk->rules[i]->type == type)
+ return YT921X_ACL_ENT_PER_BLK * blkid + i;
+ }
+
+ return UINT_MAX;
+}
+
+static unsigned int
+yt921x_acl_reserve(struct yt921x_priv *priv, unsigned int entscnt,
+ struct netlink_ext_ack *extack)
+{
+ int candidates[YT921X_ACL_ENT_PER_BLK + 1];
+ unsigned int acl_used_cnt = 0;
+
+ if (WARN_ON(entscnt > YT921X_ACL_ENT_PER_BLK))
+ return UINT_MAX;
+
+ for (unsigned int i = 0; i < ARRAY_SIZE(candidates); i++)
+ candidates[i] = -1;
+ for (unsigned int i = YT921X_ACL_BLK_NUM; i-- > 0;) {
+ unsigned int blk_used_cnt = hweight8(priv->acl_masks[i]);
+
+ candidates[blk_used_cnt] = i;
+ acl_used_cnt += blk_used_cnt;
+ }
+
+ if (acl_used_cnt >= YT921X_ACL_NUM) {
+ NL_SET_ERR_MSG_MOD(extack, "ACL entry limit reached");
+ return UINT_MAX;
+ }
+ if (acl_used_cnt + entscnt <= YT921X_ACL_NUM)
+ for (unsigned int i = YT921X_ACL_ENT_PER_BLK - entscnt + 1;
+ i-- > 0;)
+ if (candidates[i] >= 0)
+ return YT921X_ACL_ENT_PER_BLK * candidates[i] +
+ ffz(priv->acl_masks[candidates[i]]);
+
+ NL_SET_ERR_MSG_MOD(extack,
+ "ACL entry allocation failed, simplify your rules or remove existing rules");
+ return UINT_MAX;
+}
+
+static int
+yt921x_acl_commit(struct yt921x_priv *priv, unsigned int entid, u8 entsmask)
+{
+ const struct yt921x_acl_rule *aclrule;
+ const struct yt921x_acl_blk *aclblk;
+ unsigned int blkid;
+ unsigned int binid;
+ unsigned long mask;
+ u32 zeros[3] = {};
+ unsigned int i;
+ unsigned int o;
+ u32 ctrl;
+ int res;
+
+ blkid = entid / YT921X_ACL_ENT_PER_BLK;
+ binid = entid % YT921X_ACL_ENT_PER_BLK;
+ aclblk = priv->acl_blks[blkid];
+ aclrule = aclblk->rules[binid];
+
+ /* Write actions */
+ res = yt921x_reg96_write(priv, YT921X_ACLn_ACT(entid),
+ aclrule ? aclrule->action : zeros);
+ if (res)
+ return res;
+
+ /* Select the block */
+ ctrl = YT921X_ACL_BLK_CMD_MODIFY | YT921X_ACL_BLK_CMD_BLKID(blkid);
+ res = yt921x_reg_write(priv, YT921X_ACL_BLK_CMD, ctrl);
+ if (res)
+ return res;
+
+ /* Write keys and masks */
+ ctrl = 0;
+ for (unsigned int i = 0; i < YT921X_ACL_ENT_PER_BLK; i++)
+ ctrl |= YT921X_ACL_BLK_KEEP_KEEPn(i);
+
+ mask = entsmask;
+ i = 0;
+ for_each_set_bit(o, &mask, YT921X_ACL_ENT_PER_BLK) {
+ res = yt921x_reg64_write(priv, YT921X_ACLn_KEYm(blkid, o),
+ aclrule ? aclrule->entries[i].key :
+ zeros);
+ if (res)
+ return res;
+
+ res = yt921x_reg64_write(priv, YT921X_ACLn_MASKm(blkid, o),
+ aclrule ? aclrule->entries[i].mask :
+ zeros);
+ if (res)
+ return res;
+
+ ctrl &= ~YT921X_ACL_BLK_KEEP_KEEPn(o);
+ i++;
+ }
+
+ res = yt921x_reg_write(priv, YT921X_ACL_BLK_KEEP, ctrl);
+ if (res)
+ return res;
+
+ ctrl = 0;
+ for (unsigned int i = 0; i < YT921X_ACL_ENT_PER_BLK; i++) {
+ const struct yt921x_acl_rule *other = aclblk->rules[i];
+
+ if (!other)
+ continue;
+
+ mask = other->mask;
+ for_each_set_bit(o, &mask, YT921X_ACL_ENT_PER_BLK)
+ ctrl |= YT921X_ACL_ENTRY_ENm(o) |
+ YT921X_ACL_ENTRY_GRPIDm(o, i);
+ }
+ res = yt921x_reg_write(priv, YT921X_ACLn_ENTRY(blkid), ctrl);
+ if (res)
+ return res;
+
+ /* Commit the block */
+ ctrl = YT921X_ACL_BLK_CMD_BLKID(blkid);
+ res = yt921x_reg_write(priv, YT921X_ACL_BLK_CMD, ctrl);
+ if (res)
+ return res;
+
+ return 0;
+}
+
+static int
+yt921x_acl_del(struct yt921x_priv *priv, enum tc_setup_type type,
+ unsigned long tag)
+{
+ struct yt921x_acl_rule *aclrule;
+ struct yt921x_acl_blk *aclblk;
+ bool refresh_en = false;
+ unsigned int binid;
+ unsigned int blkid;
+ unsigned int entid;
+ unsigned long m;
+ unsigned int o;
+ u32 ctrl;
+ int res;
+ int ret;
+
+ entid = yt921x_acl_find(priv, type, tag);
+ if (entid == UINT_MAX)
+ return -ENOENT;
+
+ blkid = entid / YT921X_ACL_ENT_PER_BLK;
+ binid = entid % YT921X_ACL_ENT_PER_BLK;
+ aclblk = priv->acl_blks[blkid];
+ aclrule = aclblk->rules[binid];
+
+ aclblk->rules[binid] = NULL;
+ ret = yt921x_acl_commit(priv, entid, aclrule->mask);
+ /* the kernel never rolls back on failure */
+
+ m = FIELD_GET(YT921X_ACL_KEYb_SPORTS_M, aclrule->entries[0].key[1]);
+ for_each_set_bit(o, &m, YT921X_PORT_NUM) {
+ struct yt921x_port *pp = &priv->ports[o];
+
+ if (!WARN_ON(!pp->acl_cnt)) {
+ pp->acl_cnt--;
+ if (pp->acl_cnt)
+ continue;
+ }
+ refresh_en = true;
+ }
+ if (refresh_en) {
+ ctrl = yt921x_acl_activated_ports(priv);
+ res = yt921x_reg_write(priv, YT921X_ACL_PORT, ctrl);
+ if (res)
+ ret = res;
+ }
+
+ if (aclrule->action[0] & YT921X_ACL_ACTa_METER_EN)
+ clear_bit(FIELD_GET(YT921X_ACL_ACTa_METER_ID_M,
+ aclrule->action[0]),
+ priv->meters_map);
+ priv->acl_masks[blkid] &= ~aclrule->mask;
+ kvfree(aclrule);
+ if (!priv->acl_masks[blkid]) {
+ kvfree(aclblk);
+ priv->acl_blks[blkid] = NULL;
+ }
+ return ret;
+}
+
+static int
+yt921x_acl_add(struct yt921x_priv *priv,
+ const struct yt921x_acl_rule_ext *ruleext,
+ struct netlink_ext_ack *extack)
+{
+ unsigned int entscnt = hweight8(ruleext->r.mask);
+ struct yt921x_acl_rule *aclrule;
+ struct yt921x_acl_blk *aclblk;
+ bool use_trap = false;
+ unsigned int meterid;
+ unsigned int binid;
+ unsigned int blkid;
+ unsigned int entid;
+ unsigned long m;
+ unsigned int o;
+ u32 ctrl;
+ int res;
+
+ /* Allocate resources */
+ entid = yt921x_acl_reserve(priv, entscnt, extack);
+ if (entid == UINT_MAX)
+ return -EOPNOTSUPP;
+
+ if (!(ruleext->r.action[0] & YT921X_ACL_ACTa_METER_EN)) {
+ meterid = YT921X_METER_NUM;
+ } else {
+ meterid = find_first_zero_bit(priv->meters_map,
+ YT921X_METER_NUM);
+ if (meterid < YT921X_METER_NUM) {
+ res = yt921x_meter_config(priv, meterid,
+ &ruleext->marker);
+ if (res)
+ return res;
+ } else if (ruleext->r.sw_assisted) {
+ use_trap = true;
+ } else {
+ NL_SET_ERR_MSG_MOD(extack,
+ "No more meters available");
+ return -EOPNOTSUPP;
+ }
+ }
+
+ /* Prepare acl block ctrlblk */
+ blkid = entid / YT921X_ACL_ENT_PER_BLK;
+ binid = entid % YT921X_ACL_ENT_PER_BLK;
+ aclblk = priv->acl_blks[blkid];
+ if (!aclblk) {
+ aclblk = kvzalloc_obj(*aclblk);
+ if (!aclblk)
+ return -ENOMEM;
+ priv->acl_blks[blkid] = aclblk;
+ }
+
+ /* Prepare acl rule ctrlblk */
+ aclrule = kvmemdup(&ruleext->r,
+ offsetof(struct yt921x_acl_rule, entries[entscnt]),
+ GFP_KERNEL);
+ if (!aclrule) {
+ res = -ENOMEM;
+ goto err;
+ }
+
+ /* Replace the placeholder resource IDs */
+ aclrule->mask = 0;
+ m = priv->acl_masks[blkid];
+ for_each_clear_bit(o, &m, YT921X_ACL_ENT_PER_BLK) {
+ aclrule->mask |= BIT(o);
+ entscnt--;
+ if (!entscnt)
+ break;
+ }
+
+ if (use_trap) {
+ aclrule->action[2] &= ~YT921X_ACL_ACTc_FWD_REDIR_DPORTS_M &
+ ~YT921X_ACL_ACTc_FWD_M;
+ aclrule->action[2] |= YT921X_ACL_ACTc_FWD_EN |
+ YT921X_ACL_ACTc_FWD_TRAP;
+ }
+ if (meterid < YT921X_METER_NUM)
+ aclrule->action[0] |= YT921X_ACL_ACTa_METER_ID(meterid);
+ else
+ aclrule->action[0] &= ~YT921X_ACL_ACTa_METER_EN;
+
+ /* Activate ACL if needed */
+ ctrl = 0;
+ m = FIELD_GET(YT921X_ACL_KEYb_SPORTS_M, ruleext->r.entries[0].key[1]);
+ for_each_set_bit(o, &m, YT921X_PORT_NUM)
+ if (!priv->ports[o].acl_cnt)
+ ctrl |= YT921X_ACL_PORT_PORTn(o);
+ if (ctrl) {
+ ctrl |= yt921x_acl_activated_ports(priv);
+ res = yt921x_reg_write(priv, YT921X_ACL_PORT, ctrl);
+ if (res)
+ return res;
+ }
+
+ /* Write rules */
+ aclblk->rules[binid] = aclrule;
+ res = yt921x_acl_commit(priv, entid, aclrule->mask);
+ if (res) {
+ aclblk->rules[binid] = NULL;
+ kvfree(aclrule);
+ goto err;
+ }
+
+ /* Bookkeeping */
+ m = FIELD_GET(YT921X_ACL_KEYb_SPORTS_M, ruleext->r.entries[0].key[1]);
+ for_each_set_bit(o, &m, YT921X_PORT_NUM)
+ priv->ports[o].acl_cnt++;
+
+ if (meterid < YT921X_METER_NUM)
+ set_bit(meterid, priv->meters_map);
+ priv->acl_masks[blkid] |= aclrule->mask;
+ return 0;
+
+err:
+ if (!priv->acl_masks[blkid]) {
+ kvfree(aclblk);
+ priv->acl_blks[blkid] = NULL;
+ }
+ return res;
+}
+
+int
+yt921x_dsa_cls_flower_del(struct dsa_switch *ds, int port,
+ struct flow_cls_offload *cls, bool ingress)
+{
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(ds);
+ int res;
+
+ mutex_lock(&priv->reg_lock);
+ res = yt921x_acl_del(priv, TC_SETUP_CLSFLOWER, cls->cookie);
+ mutex_unlock(&priv->reg_lock);
+
+ return res;
+}
+
+int
+yt921x_dsa_cls_flower_add(struct dsa_switch *ds, int port,
+ struct flow_cls_offload *cls, bool ingress)
+{
+ struct netlink_ext_ack *extack = cls->common.extack;
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(ds);
+ struct yt921x_acl_rule_ext ruleext;
+ int res;
+
+ res = yt921x_acl_rule_ext_parse_flow(&ruleext, port, cls, ingress,
+ priv);
+ if (res)
+ return res;
+
+ mutex_lock(&priv->reg_lock);
+ res = yt921x_acl_add(priv, &ruleext, extack);
+ mutex_unlock(&priv->reg_lock);
+
+ return res;
+}
+
+static int
+yt921x_mirror_del(struct yt921x_priv *priv, int port, bool ingress)
+{
+ u32 mask;
+
+ if (ingress)
+ mask = YT921X_MIRROR_IGR_PORTn(port);
+ else
+ mask = YT921X_MIRROR_EGR_PORTn(port);
+ return yt921x_reg_clear_bits(priv, YT921X_MIRROR, mask);
+}
+
+static int
+yt921x_mirror_add(struct yt921x_priv *priv, int port, bool ingress,
+ int to_local_port, struct netlink_ext_ack *extack)
+{
+ u32 srcs;
+ u32 ctrl;
+ u32 val;
+ u32 dst;
+ int res;
+
+ if (ingress)
+ srcs = YT921X_MIRROR_IGR_PORTn(port);
+ else
+ srcs = YT921X_MIRROR_EGR_PORTn(port);
+ dst = YT921X_MIRROR_PORT(to_local_port);
+
+ res = yt921x_reg_read(priv, YT921X_MIRROR, &val);
+ if (res)
+ return res;
+
+ /* other mirror tasks & different dst port -> conflict */
+ if ((val & ~srcs & (YT921X_MIRROR_EGR_PORTS_M |
+ YT921X_MIRROR_IGR_PORTS_M)) &&
+ (val & YT921X_MIRROR_PORT_M) != dst) {
+ NL_SET_ERR_MSG_MOD(extack,
+ "Sniffer port is already configured, delete existing rules & retry");
+ return -EBUSY;
+ }
+
+ ctrl = val & ~YT921X_MIRROR_PORT_M;
+ ctrl |= srcs;
+ ctrl |= dst;
+
+ if (ctrl == val)
+ return 0;
+
+ return yt921x_reg_write(priv, YT921X_MIRROR, ctrl);
+}
+
+void
+yt921x_dsa_port_mirror_del(struct dsa_switch *ds, int port,
+ struct dsa_mall_mirror_tc_entry *mirror)
+{
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(ds);
+ struct device *dev = yt921x_priv_to_device(priv);
+ int res;
+
+ mutex_lock(&priv->reg_lock);
+ res = yt921x_mirror_del(priv, port, mirror->ingress);
+ mutex_unlock(&priv->reg_lock);
+
+ if (res)
+ dev_err(dev, "Failed to %s port %d: %i\n", "unmirror",
+ port, res);
+}
+
+int
+yt921x_dsa_port_mirror_add(struct dsa_switch *ds, int port,
+ struct dsa_mall_mirror_tc_entry *mirror,
+ bool ingress, struct netlink_ext_ack *extack)
+{
+ struct yt921x_priv *priv = dsa_to_yt921x_priv(ds);
+ int res;
+
+ mutex_lock(&priv->reg_lock);
+ res = yt921x_mirror_add(priv, port, ingress,
+ mirror->to_local_port, extack);
+ mutex_unlock(&priv->reg_lock);
+
+ return res;
+}
diff --git a/drivers/net/dsa/motorcomm/tc.h b/drivers/net/dsa/motorcomm/tc.h
new file mode 100644
index 0000000000000..99d4abf5dacdc
--- /dev/null
+++ b/drivers/net/dsa/motorcomm/tc.h
@@ -0,0 +1,379 @@
+/* SPDX-License-Identifier: GPL-2.0-or-later */
+/*
+ * Copyright (c) 2026 David Yang
+ */
+
+#ifndef _YT_TC_H
+#define _YT_TC_H
+
+#include <net/dsa.h>
+#include <net/pkt_cls.h>
+
+#define YT921X_ACLn_ACT(n) (0x1c0000 + 0x10 * (n))
+#define YT921X_ACL_ACTc_STAG_M GENMASK(26, 25)
+#define YT921X_ACL_ACTc_STAG(x) FIELD_PREP(YT921X_ACL_ACTc_STAG_M, (x))
+#define YT921X_ACL_ACTc_STAG_DONTCARE YT921X_ACL_ACTc_STAG(0)
+#define YT921X_ACL_ACTc_STAG_UNTAG YT921X_ACL_ACTc_STAG(1)
+#define YT921X_ACL_ACTc_STAG_TAG YT921X_ACL_ACTc_STAG(2)
+#define YT921X_ACL_ACTc_STAG_KEEP YT921X_ACL_ACTc_STAG(3)
+#define YT921X_ACL_ACTc_CTAG_M GENMASK(24, 23)
+#define YT921X_ACL_ACTc_CTAG(x) FIELD_PREP(YT921X_ACL_ACTc_CTAG_M, (x))
+#define YT921X_ACL_ACTc_CTAG_DONTCARE YT921X_ACL_ACTc_CTAG(0)
+#define YT921X_ACL_ACTc_CTAG_UNTAG YT921X_ACL_ACTc_CTAG(1)
+#define YT921X_ACL_ACTc_CTAG_TAG YT921X_ACL_ACTc_CTAG(2)
+#define YT921X_ACL_ACTc_CTAG_KEEP YT921X_ACL_ACTc_CTAG(3)
+#define YT921X_ACL_ACTc_FWD_M GENMASK(22, 21)
+#define YT921X_ACL_ACTc_FWD(x) FIELD_PREP(YT921X_ACL_ACTc_FWD_M, (x))
+#define YT921X_ACL_ACTc_FWD_FWD YT921X_ACL_ACTc_FWD(0)
+#define YT921X_ACL_ACTc_FWD_COPY YT921X_ACL_ACTc_FWD(1)
+#define YT921X_ACL_ACTc_FWD_REDIR YT921X_ACL_ACTc_FWD(2)
+#define YT921X_ACL_ACTc_FWD_TRAP YT921X_ACL_ACTc_FWD(3)
+#define YT921X_ACL_ACTc_FWD_REDIR_DPORTS_M GENMASK(20, 10)
+#define YT921X_ACL_ACTc_FWD_REDIR_DPORTS(x) FIELD_PREP(YT921X_ACL_ACTc_FWD_REDIR_DPORTS_M, (x))
+#define YT921X_ACL_ACTc_FWD_REDIR_DPORTn(port) BIT((port) + 10)
+#define YT921X_ACL_ACTc_FWD_EN BIT(9)
+#define YT921X_ACL_ACTc_SDEI BIT(8)
+#define YT921X_ACL_ACTc_SDEI_REPLACE BIT(7)
+#define YT921X_ACL_ACTc_SPRI_M GENMASK(6, 4)
+#define YT921X_ACL_ACTc_SPRI(x) FIELD_PREP(YT921X_ACL_ACTc_SPRI_M, (x))
+#define YT921X_ACL_ACTc_SPRI_REPLACE BIT(3)
+#define YT921X_ACL_ACTbc_SVID_M GENMASK_ULL(34, 23)
+#define YT921X_ACL_ACTbc_SVID(x) FIELD_PREP(YT921X_ACL_ACTbc_SVID_M, (x))
+#define YT921X_ACL_ACTb_SVID_REPLACE BIT(22)
+#define YT921X_ACL_ACTb_CDEI BIT(21)
+#define YT921X_ACL_ACTb_CDEI_REPLACE BIT(20)
+#define YT921X_ACL_ACTb_CPRI_M GENMASK(19, 17)
+#define YT921X_ACL_ACTb_CPRI(x) FIELD_PREP(YT921X_ACL_ACTb_CPRI_M, (x))
+#define YT921X_ACL_ACTb_CPRI_REPLACE BIT(16)
+#define YT921X_ACL_ACTb_CVID_M GENMASK(15, 4)
+#define YT921X_ACL_ACTb_CVID(x) FIELD_PREP(YT921X_ACL_ACTb_CVID_M, (x))
+#define YT921X_ACL_ACTb_CVID_REPLACE BIT(3)
+#define YT921X_ACL_ACTb_PRIO_M GENMASK(2, 0)
+#define YT921X_ACL_ACTb_PRIO(x) FIELD_PREP(YT921X_ACL_ACTb_PRIO_M, (x))
+#define YT921X_ACL_ACTa_PRIO_EN BIT(31)
+#define YT921X_ACL_ACTa_COLOR_M GENMASK(30, 29)
+#define YT921X_ACL_ACTa_COLOR(x) FIELD_PREP(YT921X_ACL_ACTa_COLOR_M, (x))
+#define YT921X_ACL_ACTa_COLOR_GREEN YT921X_ACL_ACTa_COLOR(0)
+#define YT921X_ACL_ACTa_COLOR_YELLOW YT921X_ACL_ACTa_COLOR(1)
+#define YT921X_ACL_ACTa_COLOR_RED YT921X_ACL_ACTa_COLOR(2)
+#define YT921X_ACL_ACTa_COLOR_EN BIT(28)
+#define YT921X_ACL_ACTa_DSCP_M GENMASK(27, 22)
+#define YT921X_ACL_ACTa_DSCP(x) FIELD_PREP(YT921X_ACL_ACTa_DSCP_M, (x))
+#define YT921X_ACL_ACTa_DSCP_REPLACE BIT(21)
+#define YT921X_ACL_ACTa_METER_ID_M GENMASK(20, 15)
+#define YT921X_ACL_ACTa_METER_ID(x) FIELD_PREP(YT921X_ACL_ACTa_METER_ID_M, (x))
+#define YT921X_ACL_ACTa_METER_EN BIT(14)
+#define YT921X_ACL_ACTa_MIRROR_EN BIT(13)
+#define YT921X_ACL_ACTa_FLOWSTAT_EN BIT(12)
+#define YT921X_ACL_ACTa_FLOWSTAT_ID_M GENMASK(11, 6)
+#define YT921X_ACL_ACTa_FLOWSTAT_ID(x) FIELD_PREP(YT921X_ACL_ACTa_FLOWSTAT_ID_M, (x))
+#define YT921X_ACL_ACTa_GPIO_EN BIT(5)
+#define YT921X_ACL_ACTa_GPIO_PIN_M GENMASK(4, 1)
+#define YT921X_ACL_ACTa_GPIO_PIN(x) FIELD_PREP(YT921X_ACL_ACTa_GPIO_PIN_M, (x))
+#define YT921X_ACL_ACTa_INTR_EN BIT(0)
+#define YT921X_ACL_BLK_KEEP 0x201000
+#define YT921X_ACL_BLK_KEEP_GRPIDn_M(bin) (7 << (4 * (bin) + 1))
+#define YT921X_ACL_BLK_KEEP_GRPIDn(bin, x) ((x) << (4 * (bin) + 1))
+#define YT921X_ACL_BLK_KEEP_KEEPn(bin) BIT(4 * (bin))
+#define YT921X_ACL_PORT 0x202000
+#define YT921X_ACL_PORT_PORTS_M GENMASK(10, 0)
+#define YT921X_ACL_PORT_PORTS(x) FIELD_PREP(YT921X_ACL_PORT_PORTS_M, (x))
+#define YT921X_ACL_PORT_PORTn(port) BIT(port)
+#define YT921X_ACL_BLK_CMD 0x202004
+#define YT921X_ACL_BLK_CMD_BLKID_M GENMASK(6, 1)
+#define YT921X_ACL_BLK_CMD_BLKID(x) FIELD_PREP(YT921X_ACL_BLK_CMD_BLKID_M, (x))
+#define YT921X_ACL_BLK_CMD_MODIFY BIT(0)
+#define YT921X_ACLn_ENTRY(blk) (0x203000 + 4 * (blk))
+#define YT921X_ACL_ENTRY_GRPIDm_M(bin) (7 << (4 * (bin) + 1))
+#define YT921X_ACL_ENTRY_GRPIDm(bin, x) ((x) << (4 * (bin) + 1))
+#define YT921X_ACL_ENTRY_ENm(bin) BIT(4 * (bin))
+#define YT921X_ACLn_KEYm(blk, bin) (0x204000 + 0x200 * (bin) + 8 * (blk))
+#define YT921X_ACL_KEYb_ORD_M GENMASK(29, 21)
+#define YT921X_ACL_KEYb_ORD(x) FIELD_PREP(YT921X_ACL_KEYb_ORD_M, (x))
+#define YT921X_ACL_KEYb_SPORTS_M GENMASK(20, 10)
+#define YT921X_ACL_KEYb_SPORTS(x) FIELD_PREP(YT921X_ACL_KEYb_SPORTS_M, (x))
+#define YT921X_ACL_KEYb_SPORTn(port) BIT((port) + 10)
+#define YT921X_ACL_KEYb_REVERSE BIT(9) /* reverse match */
+#define YT921X_ACL_KEYb_TYPE_M GENMASK(8, 4)
+#define YT921X_ACL_KEYb_TYPE(x) FIELD_PREP(YT921X_ACL_KEYb_TYPE_M, (x))
+/* KEY_* fields need no masks */
+#define YT921X_ACLn_MASKm(blk, bin) (0x205000 + 0x200 * (bin) + 8 * (blk))
+
+enum yt921x_acl_type {
+ YT921X_ACL_TYPE_NA,
+ YT921X_ACL_TYPE_MAC_DA0,
+ YT921X_ACL_TYPE_MAC_SA0,
+ YT921X_ACL_TYPE_MAC_DA1_SA1,
+ YT921X_ACL_TYPE_VLAN,
+ YT921X_ACL_TYPE_VTAG,
+ YT921X_ACL_TYPE_IPV4_DA,
+ YT921X_ACL_TYPE_IPV4_SA,
+ YT921X_ACL_TYPE_IPV6_DA0,
+ YT921X_ACL_TYPE_IPV6_DA1,
+ YT921X_ACL_TYPE_IPV6_DA2,
+ YT921X_ACL_TYPE_IPV6_DA3,
+ YT921X_ACL_TYPE_IPV6_SA0,
+ YT921X_ACL_TYPE_IPV6_SA1,
+ YT921X_ACL_TYPE_IPV6_SA2,
+ YT921X_ACL_TYPE_IPV6_SA3,
+ YT921X_ACL_TYPE_MISC,
+ YT921X_ACL_TYPE_L4,
+ YT921X_ACL_TYPE_UDF0,
+ YT921X_ACL_TYPE_UDF1,
+ YT921X_ACL_TYPE_UDF2,
+ YT921X_ACL_TYPE_UDF3,
+ YT921X_ACL_TYPE_UDF4,
+ YT921X_ACL_TYPE_UDF5,
+ YT921X_ACL_TYPE_UDF6,
+ YT921X_ACL_TYPE_UDF7,
+ YT921X_ACL_TYPE_ETHERTYPE,
+ YT921X_ACL_TYPE_NUM
+};
+
+/* Range: turn KEY:MASK into MIN:MAX */
+
+#define YT921X_ACL_BINb_MAC_xA0_L3_TYPE_M GENMASK(3, 0)
+#define YT921X_ACL_BINb_MAC_xA0_L3_TYPE(x) FIELD_PREP(YT921X_ACL_BINb_MAC_xA0_L3_TYPE_M, (x))
+#define YT921X_ACL_BINa_MAC_xA0_MAC_xA0_M GENMASK(31, 0)
+
+#define YT921X_ACL_BINb_MAC_DA1_SA1_L2_TYPE_M GENMASK(2, 0)
+#define YT921X_ACL_BINb_MAC_DA1_SA1_L2_TYPE(x) FIELD_PREP(YT921X_ACL_BINb_MAC_DA1_SA1_L2_TYPE_M, (x))
+#define YT921X_ACL_BINa_MAC_DA1_SA1_MAC_DA1_M GENMASK(31, 16)
+#define YT921X_ACL_BINa_MAC_DA1_SA1_MAC_SA1_M GENMASK(15, 0)
+
+#define YT921X_ACL_KEYb_VLAN_SVID_RANGE_EN BIT(31)
+#define YT921X_ACL_KEYb_VLAN_CVID_RANGE_EN BIT(30)
+#define YT921X_ACL_BINb_VLAN_CDEI BIT(3)
+#define YT921X_ACL_BINb_VLAN_CPRI_M GENMASK(2, 0)
+#define YT921X_ACL_BINb_VLAN_CPRI(x) FIELD_PREP(YT921X_ACL_BINb_VLAN_CPRI_M, (x))
+#define YT921X_ACL_BINa_VLAN_CTAG_FMT_M GENMASK(31, 30)
+#define YT921X_ACL_BINa_VLAN_CTAG_FMT(x) FIELD_PREP(YT921X_ACL_BINa_VLAN_CTAG_FMT_M, (x))
+#define YT921X_ACL_BINa_VLAN_SDEI BIT(29)
+#define YT921X_ACL_BINa_VLAN_SPRI_M GENMASK(28, 26)
+#define YT921X_ACL_BINa_VLAN_SPRI(x) FIELD_PREP(YT921X_ACL_BINa_VLAN_SPRI_M, (x))
+#define YT921X_ACL_BINa_VLAN_STAG_FMT_M GENMASK(25, 24)
+#define YT921X_ACL_BINa_VLAN_STAG_FMT(x) FIELD_PREP(YT921X_ACL_BINa_VLAN_STAG_FMT_M, (x))
+#define YT921X_ACL_BINa_VLAN_SVID_M GENMASK(23, 12)
+#define YT921X_ACL_BINa_VLAN_SVID(x) FIELD_PREP(YT921X_ACL_BINa_VLAN_SVID_M, (x))
+#define YT921X_ACL_BINa_VLAN_CVID_M GENMASK(11, 0)
+#define YT921X_ACL_BINa_VLAN_CVID(x) FIELD_PREP(YT921X_ACL_BINa_VLAN_CVID_M, (x))
+
+#define YT921X_ACL_KEYb_VTAG_SVID_RANGE_EN BIT(31)
+#define YT921X_ACL_KEYb_VTAG_CVID_RANGE_EN BIT(30)
+#define YT921X_ACL_BINa_VTAG_CDEI BIT(31)
+#define YT921X_ACL_BINa_VTAG_CPRI_M GENMASK(30, 28)
+#define YT921X_ACL_BINa_VTAG_CPRI(x) FIELD_PREP(YT921X_ACL_BINa_VTAG_CPRI_M, (x))
+#define YT921X_ACL_BINa_VTAG_SDEI BIT(27)
+#define YT921X_ACL_BINa_VTAG_SPRI_M GENMASK(26, 24)
+#define YT921X_ACL_BINa_VTAG_SPRI(x) FIELD_PREP(YT921X_ACL_BINa_VTAG_SPRI_M, (x))
+#define YT921X_ACL_BINa_VTAG_SVID_M GENMASK(23, 12)
+#define YT921X_ACL_BINa_VTAG_SVID(x) FIELD_PREP(YT921X_ACL_BINa_VTAG_SVID_M, (x))
+#define YT921X_ACL_BINa_VTAG_CVID_M GENMASK(11, 0)
+#define YT921X_ACL_BINa_VTAG_CVID(x) FIELD_PREP(YT921X_ACL_BINa_VTAG_CVID_M, (x))
+
+#define YT921X_ACL_KEYb_IPV4_ADDR_RANGE_EN BIT(30)
+#define YT921X_ACL_BINb_IPV4_FRAG BIT(3)
+#define YT921X_ACL_BINb_IPV4_L4_TYPE_M GENMASK(2, 0)
+#define YT921X_ACL_BINb_IPV4_L4_TYPE(x) FIELD_PREP(YT921X_ACL_BINb_IPV4_L4_TYPE_M, (x))
+#define YT921X_ACL_BINa_IPV4_ADDR_M GENMASK(31, 0)
+
+#define YT921X_ACL_BINb_IPV6_L4_TYPE_M GENMASK(2, 0)
+#define YT921X_ACL_BINb_IPV6_L4_TYPE(x) FIELD_PREP(YT921X_ACL_BINb_IPV6_L4_TYPE_M, (x))
+#define YT921X_ACL_BINa_IPV6_ADDRx_M GENMASK(31, 0)
+
+#define YT921X_ACL_BINb_IPV6_xA1_IP_OPTION BIT(3)
+
+#define YT921X_ACL_BINb_IPV6_xA2_FIRST_FRAG BIT(3)
+
+#define YT921X_ACL_KEYb_IPV6_xA3_ADDR_RANGE_EN BIT(30)
+#define YT921X_ACL_BINb_IPV6_xA3_FRAG BIT(3)
+
+#define YT921X_ACL_BINb_MISC_FRAG BIT(3)
+#define YT921X_ACL_BINb_MISC_L4_TYPE_M GENMASK(2, 0)
+#define YT921X_ACL_BINb_MISC_L4_TYPE(x) FIELD_PREP(YT921X_ACL_BINb_MISC_L4_TYPE_M, (x))
+#define YT921X_ACL_BINa_MISC_PPPOE_FLAG BIT(30)
+#define YT921X_ACL_BINa_MISC_FIRST_FRAG BIT(29)
+#define YT921X_ACL_BINa_MISC_IP_OPTION BIT(28)
+#define YT921X_ACL_BINa_MISC_TCP_FLAGS_M GENMASK(27, 20)
+#define YT921X_ACL_BINa_MISC_TCP_FLAGS(x) FIELD_PREP(YT921X_ACL_BINa_MISC_TCP_FLAGS_M, (x))
+#define YT921X_ACL_BINa_MISC_IP_PROTO_M GENMASK(19, 12)
+#define YT921X_ACL_BINa_MISC_IP_PROTO(x) FIELD_PREP(YT921X_ACL_BINa_MISC_IP_PROTO_M, (x))
+#define YT921X_ACL_BINa_MISC_TOS_M GENMASK(11, 4)
+#define YT921X_ACL_BINa_MISC_TOS(x) FIELD_PREP(YT921X_ACL_BINa_MISC_TOS_M, (x))
+#define YT921X_ACL_BINa_MISC_L3_TYPE_M GENMASK(3, 0)
+#define YT921X_ACL_BINa_MISC_L3_TYPE(x) FIELD_PREP(YT921X_ACL_BINa_MISC_L3_TYPE_M, (x))
+
+#define YT921X_ACL_KEYb_L4_DPORT_RANGE_EN BIT(31)
+#define YT921X_ACL_KEYb_L4_SPORT_RANGE_EN BIT(30)
+#define YT921X_ACL_BINb_L4_FRAG BIT(3)
+#define YT921X_ACL_BINb_L4_TYPE_M GENMASK(2, 0)
+#define YT921X_ACL_BINb_L4_TYPE(x) FIELD_PREP(YT921X_ACL_BINb_L4_TYPE_M, (x))
+#define YT921X_ACL_BINa_L4_DPORT_M GENMASK(31, 16)
+#define YT921X_ACL_BINa_L4_SPORT_M GENMASK(15, 0)
+
+#define YT921X_ACL_BINb_UDF_IS_IGMP BIT(0)
+#define YT921X_ACL_BINa_UDF_UDF0_M GENMASK(31, 16)
+#define YT921X_ACL_BINa_UDF_UDF0(x) FIELD_PREP(YT921X_ACL_BINa_UDF_UDF0_M, (x))
+#define YT921X_ACL_BINa_UDF_UDF1_M GENMASK(15, 0)
+#define YT921X_ACL_BINa_UDF_UDF1(x) FIELD_PREP(YT921X_ACL_BINa_UDF_UDF1_M, (x))
+
+#define YT921X_ACL_KEYb_ETHERTYPE_ETHERTYPE_RANGE_EN BIT(30)
+#define YT921X_ACL_BINb_ETHERTYPE_L4_TYPE_M GENMASK(2, 0)
+#define YT921X_ACL_BINb_ETHERTYPE_L4_TYPE(x) FIELD_PREP(YT921X_ACL_BINb_ETHERTYPE_L4_TYPE_M, (x))
+#define YT921X_ACL_BINa_ETHERTYPE_ETHERTYPE_M GENMASK(15, 0)
+#define YT921X_ACL_BINa_ETHERTYPE_ETHERTYPE(x) FIELD_PREP(YT921X_ACL_BINa_ETHERTYPE_ETHERTYPE_M, (x))
+
+enum yt921x_l2_type {
+ YT921X_L2_TYPE_ETH,
+ YT921X_L2_TYPE_ETHV2,
+ YT921X_L2_TYPE_ETHSAP,
+ YT921X_L2_TYPE_ETHSNAP,
+};
+
+enum yt921x_l3_type {
+ YT921X_L3_TYPE_OTHER,
+ YT921X_L3_TYPE_IPV4,
+ YT921X_L3_TYPE_IPV6,
+ YT921X_L3_TYPE_ARP,
+ YT921X_L3_TYPE_LLDP,
+ YT921X_L3_TYPE_PAE,
+ YT921X_L3_TYPE_ERP,
+ YT921X_L3_TYPE_SLOW_PROTOCOL,
+};
+
+enum yt921x_l4_type {
+ YT921X_L4_TYPE_OTHER,
+ YT921X_L4_TYPE_TCP,
+ YT921X_L4_TYPE_UDP,
+ YT921X_L4_TYPE_UDPLITE,
+ YT921X_L4_TYPE_ICMP,
+ YT921X_L4_TYPE_IGMP,
+ YT921X_L4_TYPE_MLD,
+ YT921X_L4_TYPE_ND,
+};
+
+#define YT921X_UDFn_CTRL(x) (0x210094 + 4 * (x))
+#define YT921X_UDF_CTRL_UDF_TYPE_M GENMASK(8, 7)
+#define YT921X_UDF_CTRL_UDF_TYPE(x) FIELD_PREP(YT921X_UDF_CTRL_UDF_TYPE_M, (x))
+#define YT921X_UDF_CTRL_UDF_TYPE_ETH YT921X_UDF_CTRL_UDF_TYPE(0)
+#define YT921X_UDF_CTRL_UDF_TYPE_L3 YT921X_UDF_CTRL_UDF_TYPE(1)
+#define YT921X_UDF_CTRL_UDF_TYPE_L4 YT921X_UDF_CTRL_UDF_TYPE(2)
+#define YT921X_UDF_CTRL_UDF_OFFSET_M GENMASK(6, 0)
+#define YT921X_UDF_CTRL_UDF_OFFSET(x) FIELD_PREP(YT921X_UDF_CTRL_UDF_OFFSET_M, (x))
+
+#define YT921X_PORTn_RATE(port) (0x220000 + 4 * (port))
+#define YT921X_PORT_RATE_GAP_VALUE GENMASK(4, 0) /* default 20 */
+#define YT921X_METER_SLOT 0x220104
+#define YT921X_METER_SLOT_SLOT_M GENMASK(11, 0)
+#define YT921X_PORTn_METER(port) (0x220108 + 4 * (port))
+#define YT921X_PORT_METER_EN BIT(4)
+#define YT921X_PORT_METER_ID_M GENMASK(3, 0)
+#define YT921X_PORT_METER_ID(x) FIELD_PREP(YT921X_PORT_METER_ID_M, (x))
+#define YT921X_METERn_CTRL(x) (0x220800 + 0x10 * (x))
+#define YT921X_METER_CTRLc_METER_EN BIT(14)
+#define YT921X_METER_CTRLc_TOKEN_OVERFLOW_EN BIT(13) /* RFC4115: yellow use unused green bw */
+#define YT921X_METER_CTRLc_DROP_M GENMASK(12, 11)
+#define YT921X_METER_CTRLc_DROP(x) FIELD_PREP(YT921X_METER_CTRLc_DROP_M, (x))
+#define YT921X_METER_CTRLc_DROP_GYR YT921X_METER_CTRLc_DROP(0)
+#define YT921X_METER_CTRLc_DROP_YR YT921X_METER_CTRLc_DROP(1)
+#define YT921X_METER_CTRLc_DROP_R YT921X_METER_CTRLc_DROP(2)
+#define YT921X_METER_CTRLc_DROP_NONE YT921X_METER_CTRLc_DROP(3)
+#define YT921X_METER_CTRLc_COLOR_BLIND BIT(10)
+#define YT921X_METER_CTRLc_UNIT_M GENMASK(9, 7)
+#define YT921X_METER_CTRLc_UNIT(x) FIELD_PREP(YT921X_METER_CTRLc_UNIT_M, (x))
+#define YT921X_METER_CTRLc_BYTE_MODE_INCLUDE_GAP BIT(6) /* +GAP_VALUE bytes each packet */
+#define YT921X_METER_CTRLc_PKT_MODE BIT(5) /* 0: byte rate mode */
+#define YT921X_METER_CTRLc_RFC2698 BIT(4) /* 0: RFC4115 */
+#define YT921X_METER_CTRLbc_CBS_M GENMASK_ULL(35, 20)
+#define YT921X_METER_CTRLbc_CBS(x) FIELD_PREP(YT921X_METER_CTRLbc_CBS_M, (x))
+#define YT921X_METER_CTRLb_CIR_M GENMASK(19, 2)
+#define YT921X_METER_CTRLb_CIR(x) FIELD_PREP(YT921X_METER_CTRLb_CIR_M, (x))
+#define YT921X_METER_CTRLab_EBS_M GENMASK_ULL(33, 18)
+#define YT921X_METER_CTRLab_EBS(x) FIELD_PREP(YT921X_METER_CTRLab_EBS_M, (x))
+#define YT921X_METER_CTRLa_EIR_M GENMASK(17, 0)
+#define YT921X_METER_CTRLa_EIR(x) FIELD_PREP(YT921X_METER_CTRLa_EIR_M, (x))
+#define YT921X_METERn_STAT(x) (0x221000 + 8 * (x))
+
+#define YT921X_MIRROR 0x300300
+#define YT921X_MIRROR_IGR_PORTS_M GENMASK(26, 16)
+#define YT921X_MIRROR_IGR_PORTS(x) FIELD_PREP(YT921X_MIRROR_IGR_PORTS_M, (x))
+#define YT921X_MIRROR_IGR_PORTn(port) BIT((port) + 16)
+#define YT921X_MIRROR_EGR_PORTS_M GENMASK(14, 4)
+#define YT921X_MIRROR_EGR_PORTS(x) FIELD_PREP(YT921X_MIRROR_EGR_PORTS_M, (x))
+#define YT921X_MIRROR_EGR_PORTn(port) BIT((port) + 4)
+#define YT921X_MIRROR_PORT_M GENMASK(3, 0)
+#define YT921X_MIRROR_PORT(x) FIELD_PREP(YT921X_MIRROR_PORT_M, (x))
+
+#define YT921X_PORT_SHAPE_SLOT 0x34000c
+#define YT921X_PORT_SHAPE_SLOT_SLOT_M GENMASK(11, 0)
+#define YT921X_PORTn_SHAPE_CTRL(port) (0x354000 + 8 * (port))
+#define YT921X_PORT_SHAPE_CTRLb_EN BIT(4)
+#define YT921X_PORT_SHAPE_CTRLb_PKT_MODE BIT(3) /* 0: byte rate mode */
+#define YT921X_PORT_SHAPE_CTRLb_UNIT_M GENMASK(2, 0)
+#define YT921X_PORT_SHAPE_CTRLb_UNIT(x) FIELD_PREP(YT921X_PORT_SHAPE_CTRLb_UNIT_M, (x))
+#define YT921X_PORT_SHAPE_CTRLa_CBS_M GENMASK(31, 18)
+#define YT921X_PORT_SHAPE_CTRLa_CBS(x) FIELD_PREP(YT921X_PORT_SHAPE_CTRLa_CBS_M, (x))
+#define YT921X_PORT_SHAPE_CTRLa_CIR_M GENMASK(17, 0)
+#define YT921X_PORT_SHAPE_CTRLa_CIR(x) FIELD_PREP(YT921X_PORT_SHAPE_CTRLa_CIR_M, (x))
+#define YT921X_PORTn_SHAPE_STAT(port) (0x356000 + 4 * (port))
+
+#define YT921X_TOKEN_BYTE_C 1 /* 1 token = 2^1 byte */
+#define YT921X_TOKEN_PKT_C -6 /* 1 token = 2^-6 packets */
+#define YT921X_TOKEN_RATE_C -15
+#define YT921X_METER_SLOT_MIN 80
+#define YT921X_METER_UNIT_MAX ((1 << 3) - 1)
+#define YT921X_METER_CIR_MAX ((1 << 18) - 1)
+#define YT921X_METER_CBS_MAX ((1 << 16) - 1)
+#define YT921X_PORT_SHAPE_SLOT_MIN 80
+#define YT921X_SHAPE_UNIT_MAX ((1 << 3) - 1)
+#define YT921X_SHAPE_CIR_MAX ((1 << 18) - 1)
+#define YT921X_SHAPE_CBS_MAX ((1 << 14) - 1)
+
+#define YT921X_ACL_ENT_PER_BLK 8
+#define YT921X_ACL_NUM 384
+#define YT921X_ACL_ORD_NUM 512
+#define YT921X_UDF_NUM 8
+
+struct yt921x_acl_entry {
+ u32 key[2];
+ u32 mask[2];
+};
+
+struct yt921x_acl_rule {
+ unsigned long tag;
+ enum tc_setup_type type;
+
+ u32 action[3];
+ bool sw_assisted;
+
+ u8 mask;
+ struct yt921x_acl_entry entries[YT921X_ACL_ENT_PER_BLK];
+};
+
+struct yt921x_acl_blk {
+ struct yt921x_acl_rule *rules[YT921X_ACL_ENT_PER_BLK];
+};
+
+void yt921x_dsa_port_policer_del(struct dsa_switch *ds, int port);
+int
+yt921x_dsa_port_policer_add(struct dsa_switch *ds, int port,
+ const struct flow_action_police *police,
+ struct netlink_ext_ack *extack);
+int
+yt921x_dsa_port_setup_tc(struct dsa_switch *ds, int port,
+ enum tc_setup_type type, void *type_data);
+int
+yt921x_dsa_cls_flower_del(struct dsa_switch *ds, int port,
+ struct flow_cls_offload *cls, bool ingress);
+int
+yt921x_dsa_cls_flower_add(struct dsa_switch *ds, int port,
+ struct flow_cls_offload *cls, bool ingress);
+void
+yt921x_dsa_port_mirror_del(struct dsa_switch *ds, int port,
+ struct dsa_mall_mirror_tc_entry *mirror);
+int
+yt921x_dsa_port_mirror_add(struct dsa_switch *ds, int port,
+ struct dsa_mall_mirror_tc_entry *mirror,
+ bool ingress, struct netlink_ext_ack *extack);
+
+#endif
|
| 3/2 | 2026/10/02 16:17 | llm | patch-evaluator |
0mModel:gemini-3.8-flash Args: null Results: null Tokens: input: 71855 output: 35 thoughts: 283 Thoughts: **Analyzing the New Patch** Okay, so I need to evaluate this patch series that's been applied as HEAD in my workspace. My first step is to get a really good understanding of what this patch is actually *doing*. I'm going to dig into the code and determine which drivers and subsystems are impacted. Then, I need to figure out if this is even something worth fuzzing and if it's reachable. Looking at the file list, it seems like the patch touches a bunch of files within `drivers/net/dsa/motorcomm/`: the `Makefile`, `chip.c`, `chip.h`, `leds.c`, `mdio_bus.c`, `pcs-921x.c`, `tc.c`, and `tc.h`. That seems like a pretty focused area, but I need to understand the big picture. Next, I need to understand the intent of the commit itself. I'll need to examine the commit message and related history to understand why this was added, which would be done with the grepper, read-file or git commands - though, looks like I don't have git commands available, so I'll utilize grepper or read-file. Wait, what exactly is `drivers/net/dsa/motorcomm/`? I don't want to make assumptions. I'll need to check the relevant `Kconfig` files in `drivers/net/dsa/motorcomm/` and perhaps even `drivers/net/dsa/` more generally. This will give me the necessary context to determine what this driver does, what its purpose is, and how it fits into the overall networking stack. This is the first step in determining what level of interest this patch has. |
| 4/2 | 2026/10/02 16:17 | tool | grepper |
0mArgs:{
"Expression": "NET_DSA_YT921X",
"PathPrefix": "drivers/net/dsa"
}Results: {
"Output": "drivers/net/dsa/motorcomm/Kconfig-1-# SPDX-License-Identifier: GPL-2.0-only\ndrivers/net/dsa/motorcomm/Kconfig:2:config NET_DSA_YT921X\ndrivers/net/dsa/motorcomm/Kconfig-3-\ttristate \"Motorcomm YT9215 ethernet switch chip support\"\n--\ndrivers/net/dsa/motorcomm/Kconfig-9-\ndrivers/net/dsa/motorcomm/Kconfig:10:config NET_DSA_YT921X_LEDS\ndrivers/net/dsa/motorcomm/Kconfig-11-\tbool \"LED support for Motorcomm YT9215\"\ndrivers/net/dsa/motorcomm/Kconfig-12-\tdefault y\ndrivers/net/dsa/motorcomm/Kconfig:13:\tdepends on NET_DSA_YT921X\ndrivers/net/dsa/motorcomm/Kconfig:14:\tdepends on LEDS_CLASS=y || LEDS_CLASS=NET_DSA_YT921X\ndrivers/net/dsa/motorcomm/Kconfig-15-\thelp\n--\ndrivers/net/dsa/motorcomm/Makefile-1-# SPDX-License-Identifier: GPL-2.0\ndrivers/net/dsa/motorcomm/Makefile:2:obj-$(CONFIG_NET_DSA_YT921X) += yt921x.o\ndrivers/net/dsa/motorcomm/Makefile-3-yt921x-objs := chip.o\ndrivers/net/dsa/motorcomm/Makefile:4:yt921x-$(CONFIG_NET_DSA_YT921X_LEDS) += leds.o\ndrivers/net/dsa/motorcomm/Makefile-5-yt921x-objs += mdio_bus.o\n--\ndrivers/net/dsa/motorcomm/chip.c=2461=static void yt921x_dsa_teardown(struct dsa_switch *ds)\ndrivers/net/dsa/motorcomm/chip.c-2462-{\ndrivers/net/dsa/motorcomm/chip.c:2463:#if IS_ENABLED(CONFIG_NET_DSA_YT921X_LEDS)\ndrivers/net/dsa/motorcomm/chip.c-2464-\tstruct yt921x_priv *priv = dsa_to_yt921x_priv(ds);\n--\ndrivers/net/dsa/motorcomm/chip.c=2784=static int yt921x_dsa_setup(struct dsa_switch *ds)\n--\ndrivers/net/dsa/motorcomm/chip.c-2848-\ndrivers/net/dsa/motorcomm/chip.c:2849:#if IS_ENABLED(CONFIG_NET_DSA_YT921X_LEDS)\ndrivers/net/dsa/motorcomm/chip.c-2850-\tres = yt921x_leds_setup(priv);\n--\ndrivers/net/dsa/motorcomm/chip.h=567=struct yt921x_port {\n--\ndrivers/net/dsa/motorcomm/chip.h-585-\ndrivers/net/dsa/motorcomm/chip.h:586:#if IS_ENABLED(CONFIG_NET_DSA_YT921X_LEDS)\ndrivers/net/dsa/motorcomm/chip.h-587-\tunsigned char led_duty;\n--\ndrivers/net/dsa/motorcomm/leds.h=96=struct yt921x_led {\n--\ndrivers/net/dsa/motorcomm/leds.h-101-\ndrivers/net/dsa/motorcomm/leds.h:102:#if IS_ENABLED(CONFIG_NET_DSA_YT921X_LEDS)\ndrivers/net/dsa/motorcomm/leds.h-103-\n"
} |
| 5/2 | 2026/10/02 16:17 | llm | patch-evaluator |
0mModel:gemini-3.8-flash Args: null Results: null Tokens: input: 73516 output: 38 thoughts: 29 Thoughts: Okay, here's my take on those thoughts, tailored for an expert audience, presented in the first person: **Navigating the Driver Landscape** Right, let's dive in. Based on the filename, `drivers/net/dsa/motorcomm/Kconfig`, I need to immediately understand the underlying hardware or bus architecture we're dealing with. The "motorcomm" bit is the clue, but I need to quickly ascertain the specific chip or bus type to proceed. Kconfig is the obvious place to start. It's the central repository for build-time configuration, and it will immediately tell me what I am dealing with. From this Kconfig file, I can build an understanding of the available options and requirements this driver has. This should provide the foundation necessary to understand how this driver fits into the broader network ecosystem. |
| 6/2 | 2026/10/02 16:17 | tool | read-file |
0mArgs:{
"File": "drivers/net/dsa/motorcomm/Kconfig",
"FirstLine": 1,
"LineCount": 50
}Results: {
"Contents": " 1:\t# SPDX-License-Identifier: GPL-2.0-only\n 2:\tconfig NET_DSA_YT921X\n 3:\t\ttristate \"Motorcomm YT9215 ethernet switch chip support\"\n 4:\t\tselect NET_DSA_TAG_YT921X\n 5:\t\tselect NET_IEEE8021Q_HELPERS if DCB\n 6:\t\thelp\n 7:\t\t This enables support for the Motorcomm YT9215 ethernet switch\n 8:\t\t chip.\n 9:\t\n 10:\tconfig NET_DSA_YT921X_LEDS\n 11:\t\tbool \"LED support for Motorcomm YT9215\"\n 12:\t\tdefault y\n 13:\t\tdepends on NET_DSA_YT921X\n 14:\t\tdepends on LEDS_CLASS=y || LEDS_CLASS=NET_DSA_YT921X\n 15:\t\thelp\n 16:\t\t This enables support for controlling the LEDs attached to the\n 17:\t\t Motorcomm YT9215 switch chips.\n"
} |
| 7/2 | 2026/10/02 16:17 | llm | patch-evaluator |
0mModel:gemini-3.8-flash Args: null Results: null Tokens: input: 74034 output: 32 thoughts: 38 Thoughts: Okay, let's dive into this. Here's my thought process on this: **Inspecting the yt921x Driver Registration Process** Right, so I need to understand how the `yt921x` driver, or whatever its probing mechanism is, gets initialized. Time to jump right into the source code. Based on my experience, `drivers/net/dsa/motorcomm/chip.c` seems like the logical place to start looking. That's usually where you find the core driver registration logic, especially for a DSA (Distributed Switch Architecture) device like this. It's the go-to spot for understanding the initial probe sequence and how the driver ties into the kernel's network stack. Let's see what's happening in there. |
| 8/2 | 2026/10/02 16:17 | tool | grepper |
0mArgs:{
"Expression": "module_",
"PathPrefix": "drivers/net/dsa/motorcomm/"
}Results: {
"Output": "drivers/net/dsa/motorcomm/chip.c=3036=static struct mdio_driver yt921x_mdio_driver = {\n--\ndrivers/net/dsa/motorcomm/chip.c-3045-\ndrivers/net/dsa/motorcomm/chip.c:3046:mdio_module_driver(yt921x_mdio_driver);\ndrivers/net/dsa/motorcomm/chip.c-3047-\n"
} |
| 9/2 | 2026/10/02 16:17 | llm | patch-evaluator |
0mModel:gemini-3.8-flash Args: null Results: null Tokens: input: 74398 output: 42 thoughts: 43 Thoughts: Here's my summary, as if I were thinking these thoughts: **Analyzing the MDIO Driver and Chip Initialization** Okay, so I'm looking at this `mdio_module_driver(yt921x_mdio_driver)` call – that's a key line. It's obviously registering the MDIO driver for the YT921x. Time to dig deeper. I'll need to understand how the MDIO interacts with this specific chip. My first port of call will be to cross-reference that driver with the core chip logic. Specifically, I'm thinking I need to understand how the MDIO driver is used to configure and control the YT921x itself. Let me go straight to `chip.c` and specifically lines 2980-3050. That should give me a solid view of how the chip is being initialized. I'm expecting to find the MDIO configuration within that section. Hopefully, I can find the register accesses, the initialization sequences, and any potential interrupt handling related to MDIO communication. I need to understand how this driver is being called and what data it's passing to the chip. This is the starting point for really digging into this YT921x and how it is interacting with the underlying MDIO bus. |
| 10/2 | 2026/10/02 16:18 | tool | read-file |
0mArgs:{
"File": "drivers/net/dsa/motorcomm/chip.c",
"FirstLine": 2980,
"LineCount": 70
}Results: {
"Contents": "2980:\t}\n2981:\t\n2982:\tstatic int yt921x_mdio_probe(struct mdio_device *mdiodev)\n2983:\t{\n2984:\t\tstruct device *dev = \u0026mdiodev-\u003edev;\n2985:\t\tstruct yt921x_reg_mdio *mdio;\n2986:\t\tstruct yt921x_priv *priv;\n2987:\t\tstruct dsa_switch *ds;\n2988:\t\n2989:\t\tpriv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);\n2990:\t\tif (!priv)\n2991:\t\t\treturn -ENOMEM;\n2992:\t\n2993:\t\tmdio = devm_kzalloc(dev, sizeof(*mdio), GFP_KERNEL);\n2994:\t\tif (!mdio)\n2995:\t\t\treturn -ENOMEM;\n2996:\t\n2997:\t\tmdio-\u003ebus = mdiodev-\u003ebus;\n2998:\t\tmdio-\u003eaddr = mdiodev-\u003eaddr;\n2999:\t\tmdio-\u003eswitchid = 0;\n3000:\t\n3001:\t\tmutex_init(\u0026priv-\u003ereg_lock);\n3002:\t\n3003:\t\tpriv-\u003ereg_ops = \u0026yt921x_reg_ops_mdio;\n3004:\t\tpriv-\u003ereg_ctx = mdio;\n3005:\t\n3006:\t\tfor (size_t i = 0; i \u003c ARRAY_SIZE(priv-\u003eports); i++) {\n3007:\t\t\tstruct yt921x_port *pp = \u0026priv-\u003eports[i];\n3008:\t\n3009:\t\t\tpp-\u003eindex = i;\n3010:\t\t\tINIT_DELAYED_WORK(\u0026pp-\u003emib_read, yt921x_poll_mib);\n3011:\t\t}\n3012:\t\n3013:\t\tds = \u0026priv-\u003eds;\n3014:\t\tds-\u003edev = dev;\n3015:\t\tds-\u003eassisted_learning_on_cpu_port = true;\n3016:\t\tds-\u003edscp_prio_mapping_is_global = true;\n3017:\t\tds-\u003epriv = priv;\n3018:\t\tds-\u003eops = \u0026yt921x_dsa_switch_ops;\n3019:\t\tds-\u003eageing_time_min = 1 * 5000;\n3020:\t\tds-\u003eageing_time_max = U16_MAX * 5000;\n3021:\t\tds-\u003ephylink_mac_ops = \u0026yt921x_phylink_mac_ops;\n3022:\t\tds-\u003enum_lag_ids = YT921X_LAG_NUM;\n3023:\t\tds-\u003enum_ports = YT921X_PORT_NUM;\n3024:\t\n3025:\t\tmdiodev_set_drvdata(mdiodev, priv);\n3026:\t\n3027:\t\treturn dsa_register_switch(ds);\n3028:\t}\n3029:\t\n3030:\tstatic const struct of_device_id yt921x_of_match[] = {\n3031:\t\t{ .compatible = \"motorcomm,yt9215\" },\n3032:\t\t{}\n3033:\t};\n3034:\tMODULE_DEVICE_TABLE(of, yt921x_of_match);\n3035:\t\n3036:\tstatic struct mdio_driver yt921x_mdio_driver = {\n3037:\t\t.probe = yt921x_mdio_probe,\n3038:\t\t.remove = yt921x_mdio_remove,\n3039:\t\t.shutdown = yt921x_mdio_shutdown,\n3040:\t\t.mdiodrv.driver = {\n3041:\t\t\t.name = YT921X_NAME,\n3042:\t\t\t.of_match_table = yt921x_of_match,\n3043:\t\t},\n3044:\t};\n3045:\t\n3046:\tmdio_module_driver(yt921x_mdio_driver);\n3047:\t\n3048:\tMODULE_AUTHOR(\"David Yang \u003cmmyangfl@gmail.com\u003e\");\n3049:\tMODULE_DESCRIPTION(\"Driver for Motorcomm YT921x Switch\");\n"
} |
| 11/2 | 2026/10/02 16:18 | llm | patch-evaluator |
0mModel:gemini-3.8-flash Args: null Results: null Tokens: input: 75926 output: 39 thoughts: 729 Thoughts: **Fuzzing Feasibility Assessment: `motorcomm,yt9215` MDIO Driver**
Okay, first things first, what kind of beast am I looking at? Ah, an MDIO driver (`mdio_driver`) for a `motorcomm,yt9215` Ethernet switch chip. The key question is whether this thing is even *reachable* in a QEMU environment, or in a typical virtualization setup like GCE. Can I even instantiate this DSA switch within QEMU?
Alright, let's refer to the negative criteria in section 2. It's time to be methodical. The goal is to determine if I *shouldn't* fuzz this code path. The criteria list a few key scenarios: structurally unreachable hardware like PCIe switches and specific drivers that require dedicated hardware, and unreachable execution paths like driver teardown code that relies on physical unplugging.
So, is an MDIO device or a DSA switch something QEMU can handle? Can I get this `motorcomm,yt9215` to probe on an MDIO bus without the physical hardware or a device tree? That's the core question. Does syzkaller or userspace have any mechanism to create or register MDIO devices or DSA switch devices? I need to dig into the kernel source, or look at how MDIO devices are generally probed. I recall MDIO devices are attached to an MDIO bus (`struct mii_bus`). How are they typically registered? Device Tree (`of_mdiobus_register`), ACPI, board files, or a MAC driver scanning the MDIO bus, usually.
Hmm, this `yt921x_of_match` structure is interesting. It uses Open Firmware (Device Tree). *Does* this specific `motorcomm,yt9215` switch driver require a DT node? Looking at the code:
```c
static const struct of_device_id yt921x_of_match[] = {
{ .compatible = "motorcomm,yt9215" },
{}
};
```
and:
```c
static struct mdio_driver yt921x_mdio_driver = {
.probe = yt921x_mdio_probe,
.remove = yt921x_mdio_remove,
.shutdown = yt921x_mdio_shutdown,
.mdiodrv.driver = {
.name = YT921X_NAME,
.of_match_table = yt921x_of_match,
},
};
```
Yup, it certainly looks like it!
Okay, target architecture is `amd64`, so x86_64. Does QEMU even *have* a `motorcomm,yt9215` switch emulated? No, that's almost certainly a hard "no". And can userspace instantiate MDIO devices? Let me search the kernel source: is there anything via sysfs, netlink, configfs, anything at all? This seems like a dead end unless there's an ingenious way to spoof a device tree entry. This is likely structurally unreachable and should be marked as WorthFuzzing=false.
|
| 12/2 | 2026/10/02 16:18 | tool | grepper |
0mArgs:{
"Expression": "mdio_device_create|mdio_device_register",
"PathPrefix": "drivers/net/mdio"
}Results: {
"Output": "drivers/net/mdio/of_mdio.c=52=static int of_mdiobus_register_device(struct mii_bus *mdio,\n--\ndrivers/net/mdio/of_mdio.c-58-\ndrivers/net/mdio/of_mdio.c:59:\tmdiodev = mdio_device_create(mdio, addr);\ndrivers/net/mdio/of_mdio.c-60-\tif (IS_ERR(mdiodev))\n--\ndrivers/net/mdio/of_mdio.c-68-\t/* All data is now stored in the mdiodev struct; register it. */\ndrivers/net/mdio/of_mdio.c:69:\trc = mdio_device_register(mdiodev);\ndrivers/net/mdio/of_mdio.c-70-\tif (rc) {\n"
} |
| 13/2 | 2026/10/02 16:18 | llm | patch-evaluator |
0mModel:gemini-3.8-flash Args: null Results: null Tokens: input: 77621 output: 20 thoughts: 35 Thoughts: Okay, here's my take on those thoughts, tailored for an expert audience: **MDIO Device Registration: A Kernel-Wide Deep Dive** Alright, let's get down to brass tacks. I need to understand the fundamental mechanics of MDIO device registration within this kernel. My initial thought is to execute a wide-ranging search. I want a panoramic view, essentially. I'll sweep the entire kernel source tree, looking for instances of both `mdio_device_register` and `mdio_driver_register`. I'm not just after the specific call sites, mind you; I'm seeking the *context* around them. I want to see how these functions are *used* in practice, what the typical data structures passed to them look like, and the calling sequences that trigger their execution. Ultimately, I'm aiming to build a mental map of the registration process. I need to trace the journey of an MDIO device from its conceptual definition, through its instantiation, all the way to its availability to the system. Understanding this registration workflow is critical; it's the foundation for everything else that follows, be it driver binding, device probing, or ultimately, communication over the MDIO bus. My query needs to be as comprehensive as possible. I'm not afraid to dig deep in the source code; in fact, I expect to! |
| 14/2 | 2026/10/02 16:18 | tool | grepper |
0mArgs:{
"Expression": "mdio_device_register"
}Results: {
"Output": "drivers/net/dsa/dsa_loop.c=446=static int __init dsa_loop_create_switch_mdiodev(void)\n--\ndrivers/net/dsa/dsa_loop.c-473-\ndrivers/net/dsa/dsa_loop.c:474:\tret = mdio_device_register(switch_mdiodev);\ndrivers/net/dsa/dsa_loop.c-475-\tif (ret)\n--\ndrivers/net/mdio/of_mdio.c=52=static int of_mdiobus_register_device(struct mii_bus *mdio,\n--\ndrivers/net/mdio/of_mdio.c-68-\t/* All data is now stored in the mdiodev struct; register it. */\ndrivers/net/mdio/of_mdio.c:69:\trc = mdio_device_register(mdiodev);\ndrivers/net/mdio/of_mdio.c-70-\tif (rc) {\n--\ndrivers/net/pcs/pcs-xpcs-plat.c=337=static int xpcs_plat_init_dev(struct dw_xpcs_plat *pxpcs)\n--\ndrivers/net/pcs/pcs-xpcs-plat.c-356-\ndrivers/net/pcs/pcs-xpcs-plat.c:357:\tret = mdio_device_register(mdiodev);\ndrivers/net/pcs/pcs-xpcs-plat.c-358-\tif (ret) {\n--\ndrivers/net/phy/air_en8811h.c=1131=static int an8811hb_probe(struct phy_device *phydev)\n--\ndrivers/net/phy/air_en8811h.c-1155-\ndrivers/net/phy/air_en8811h.c:1156:\tret = mdio_device_register(mdiodev);\ndrivers/net/phy/air_en8811h.c-1157-\tif (ret)\n--\ndrivers/net/phy/mdio_device.c-26-/**\ndrivers/net/phy/mdio_device.c:27: * mdio_device_register_reset - Read and initialize the reset properties of\ndrivers/net/phy/mdio_device.c-28- *\t\t\t\tan mdio device\n--\ndrivers/net/phy/mdio_device.c-32- */\ndrivers/net/phy/mdio_device.c:33:static int mdio_device_register_reset(struct mdio_device *mdiodev)\ndrivers/net/phy/mdio_device.c-34-{\n--\ndrivers/net/phy/mdio_device.c=143=EXPORT_SYMBOL(mdio_device_create);\n--\ndrivers/net/phy/mdio_device.c-145-/**\ndrivers/net/phy/mdio_device.c:146: * mdio_device_register - Register the mdio device on the MDIO bus\ndrivers/net/phy/mdio_device.c-147- * @mdiodev: mdio_device structure to be added to the MDIO bus\n--\ndrivers/net/phy/mdio_device.c-150- */\ndrivers/net/phy/mdio_device.c:151:int mdio_device_register(struct mdio_device *mdiodev)\ndrivers/net/phy/mdio_device.c-152-{\n--\ndrivers/net/phy/mdio_device.c-172-}\ndrivers/net/phy/mdio_device.c:173:EXPORT_SYMBOL(mdio_device_register);\ndrivers/net/phy/mdio_device.c-174-\n--\ndrivers/net/phy/mdio_device.c-180- * This doesn't free the mdio_device itself, it merely reverses the effects\ndrivers/net/phy/mdio_device.c:181: * of mdio_device_register(). Use mdio_device_free() to free the device\ndrivers/net/phy/mdio_device.c-182- * after calling this function.\n--\ndrivers/net/phy/mdio_device.c=191=int mdiobus_register_device(struct mdio_device *mdiodev)\n--\ndrivers/net/phy/mdio_device.c-198-\tif (mdiodev-\u003eflags \u0026 MDIO_DEVICE_FLAG_PHY) {\ndrivers/net/phy/mdio_device.c:199:\t\terr = mdio_device_register_reset(mdiodev);\ndrivers/net/phy/mdio_device.c-200-\t\tif (err)\n--\ninclude/linux/mdio.h=95=struct mdio_device *mdio_device_create(struct mii_bus *bus, int addr);\ninclude/linux/mdio.h:96:int mdio_device_register(struct mdio_device *mdiodev);\ninclude/linux/mdio.h-97-void mdio_device_remove(struct mdio_device *mdiodev);\n"
} |
| 15/2 | 2026/10/02 16:18 | llm | patch-evaluator |
0mModel:gemini-3.8-flash Args: null Results: null Tokens: input: 79243 output: 31 thoughts: 470 Thoughts: **Analyzing MDIO Device Registration and Driver Matching**
Okay, so I'm looking at how `mdio_device_register` is used in this system. It seems like it's primarily used in a few specific scenarios: the DSA loopback device, the OF MDIO parsing, an internal MDIO device in `dw_xpcs_plat`, and another one within a PHY driver. I need to understand how the `motorcomm,yt9215` driver is being probed.
The key question is, can this driver even function without a Device Tree node specifying that exact compatible string? I need to check the `yt921x_of_match` structure. Ah, here it is, in `chip.c`:
```c
static const struct of_device_id yt921x_of_match[] = {
{ .compatible = "motorcomm,yt9215" },
{}
};
```
Right, so that confirms it: The driver explicitly uses the `of_match_table` for identification. It doesn't have an `id_table` or any other means of matching beyond that Device Tree compatibility string!
I need to confirm my understanding of how `mdio_driver` matching works. I'm going to quickly check in `drivers/net/phy/mdio_bus.c` to see if `mdio_bus_match` prioritizes the OF match or if there's other matching going on.
|
| 16/2 | 2026/10/02 16:18 | tool | grepper |
0mArgs:{
"Expression": "mdio_bus_match",
"PathPrefix": "drivers/net/phy"
}Results: {
"Output": "drivers/net/phy/mdio_bus_provider.c=238=const struct class mdio_bus_class = {\n--\ndrivers/net/phy/mdio_bus_provider.c-244-/**\ndrivers/net/phy/mdio_bus_provider.c:245: * mdio_bus_match - determine if given MDIO driver supports the given\ndrivers/net/phy/mdio_bus_provider.c-246- *\t\t MDIO device\n--\ndrivers/net/phy/mdio_bus_provider.c-254- */\ndrivers/net/phy/mdio_bus_provider.c:255:static int mdio_bus_match(struct device *dev, const struct device_driver *drv)\ndrivers/net/phy/mdio_bus_provider.c-256-{\n--\ndrivers/net/phy/mdio_bus_provider.c=300=const struct bus_type mdio_bus_type = {\n--\ndrivers/net/phy/mdio_bus_provider.c-302-\t.dev_groups\t= mdio_bus_device_statistics_groups,\ndrivers/net/phy/mdio_bus_provider.c:303:\t.match\t\t= mdio_bus_match,\ndrivers/net/phy/mdio_bus_provider.c-304-\t.uevent\t\t= mdio_uevent,\n"
} |
| 17/2 | 2026/10/02 16:18 | llm | patch-evaluator |
0mModel:gemini-3.8-flash Args: null Results: null Tokens: input: 80414 output: 42 thoughts: 12 Thoughts: Okay, here's my interpretation of that thought process, tailored for an expert audience, and written in the first person: **Analyzing the `mdio_bus_match` Function** Alright, let's dive into the `mdio_bus_match` function. My initial thought is to understand its purpose within the broader MDIO driver framework. I'm assuming it's part of the probing or device matching logic. I need to quickly recall how this typically works: does it check for specific IDs, capabilities, or perhaps a combination? Is it tied into the platform device enumeration, or is it triggered by a more dynamic hotplug event? I want to immediately pinpoint the context. I'll be looking for key elements that define this matching process: What data structures does it compare? Is it using a simple ID check, a more complex resource comparison, or is it utilizing properties from the device tree? Are there any relevant quirks or specific device-specific considerations encoded within the match criteria? Specifically, I'm expecting this to be the function that determines if a potential MDIO device on the bus is actually supported by a registered driver. So, I need to know the matching rules. Given my prior experience with other MDIO implementations, I anticipate some potential areas for performance bottlenecks or subtle race conditions. It’s always a good idea to consider these when looking at a match function. I'll mentally note anything unusual in the control flow, any potential for deadlocks or priority inversions, and any areas that could benefit from optimization. I want to see how clever the implementation is, and if it is well documented. |
| 18/2 | 2026/10/02 16:18 | tool | read-file |
0mArgs:{
"File": "drivers/net/phy/mdio_bus_provider.c",
"FirstLine": 250,
"LineCount": 40
}Results: {
"Contents": " 250:\t * Return: 1 if the driver supports the device, 0 otherwise\n 251:\t *\n 252:\t * Description: This may require calling the devices own match function,\n 253:\t * since different classes of MDIO devices have different match criteria.\n 254:\t */\n 255:\tstatic int mdio_bus_match(struct device *dev, const struct device_driver *drv)\n 256:\t{\n 257:\t\tconst struct mdio_driver *mdiodrv = to_mdio_driver(drv);\n 258:\t\tstruct mdio_device *mdio = to_mdio_device(dev);\n 259:\t\n 260:\t\t/* Both the driver and device must type-match */\n 261:\t\tif (!(mdiodrv-\u003emdiodrv.flags \u0026 MDIO_DEVICE_IS_PHY) !=\n 262:\t\t !(mdio-\u003eflags \u0026 MDIO_DEVICE_FLAG_PHY))\n 263:\t\t\treturn 0;\n 264:\t\n 265:\t\tif (of_driver_match_device(dev, drv))\n 266:\t\t\treturn 1;\n 267:\t\n 268:\t\tif (mdio-\u003ebus_match)\n 269:\t\t\treturn mdio-\u003ebus_match(dev, drv);\n 270:\t\n 271:\t\treturn 0;\n 272:\t}\n 273:\t\n 274:\tstatic int mdio_uevent(const struct device *dev, struct kobj_uevent_env *env)\n 275:\t{\n 276:\t\tint rc;\n 277:\t\n 278:\t\t/* Some devices have extra OF data and an OF-style MODALIAS */\n 279:\t\trc = of_device_uevent_modalias(dev, env);\n 280:\t\tif (rc != -ENODEV)\n 281:\t\t\treturn rc;\n 282:\t\n 283:\t\treturn 0;\n 284:\t}\n 285:\t\n 286:\tstatic const struct attribute *const mdio_bus_device_statistics_attrs[] = {\n 287:\t\t\u0026dev_attr_mdio_bus_device_transfers.attr.attr,\n 288:\t\t\u0026dev_attr_mdio_bus_device_errors.attr.attr,\n 289:\t\t\u0026dev_attr_mdio_bus_device_writes.attr.attr,\n"
} |
| 19/2 | 2026/10/02 16:18 | llm | patch-evaluator |
0mModel:gemini-3.8-flash Args: null Results: null Tokens: input: 81452 output: 125 thoughts: 2939 Thoughts: **Analysis of the Motorcomm YT9215 Driver Patch** Alright, let's break this down systematically. The `mdio_bus_match` function, and indeed the entire driver, hinges on either the `of_driver_match_device` or a custom `mdio->bus_match` function. We have a clear `of_match_table` pointing to the `yt921x_of_match` table. The probe function (`yt921x_mdio_probe`) then sets up the MDIO bus and assigns register operations. Critically, it then registers the DSA switch. The `yt921x_dsa_setup` function is where the hardware interaction happens, specifically through `yt921x_chip_detect`. This is where MDIO reads are performed, attempting to identify the chip. If it cannot detect the chip, the probe will fail. Now, the fatal flaw: this all relies on the *physical* presence of a Motorcomm YT9215 switch. The chip itself is queried through MDIO reads to its hardware registers. This driver is for a physical device, and a standard QEMU environment on amd64, or any virtualized environment, *does not* emulate this particular hardware. QEMU does *not* emulate Motorcomm switch ASICs. DSA (Distributed Switch Architecture) switches, in general, are physical hardware switch ASICs, like the Marvell or Realtek devices, all connected through something like MDIO. And none of these are emulated. The only DSA driver that *can* run without hardware is `dsa_loop` (which is a mock DSA switch driver specifically for testing the DSA core). This patch modifies code specifically within `drivers/net/dsa/motorcomm/`, specifically concerning TC (traffic control) offload implementation and ACL handling by moving it to `tc.c` and updating ACL logic. Now, looking at the TRIAGE PHILOSOPHY and the NEGATIVE CRITERIA: the modified code is *structurally unreachable hardware*. This is because it's a vendor-specific Ethernet switch chip requiring the physical YT9215 ASIC, connected via MDIO. Since standard QEMU (or any other common environment for fuzzing) does *not* emulate this, the code is unexecutable. There's no way this driver can load, no way the probe can happen, no way for the relevant code paths to be executed. The changes are exclusively within that driver's directory. No symbols are exported outside of that `yt921x` module. The code is completely unreachable, making fuzzing pointless. Therefore, the decision must be made: `WorthFuzzing = false`. |
| 20/2 | 2026/10/02 16:18 | tool | set-results |
0mArgs:{
"EnableConfigs": [],
"FocusSymbols": [],
"Reasoning": "The patch series refactors TC and ACL handling and updates ACL port activation logic in the Motorcomm YT9215 Ethernet switch driver (drivers/net/dsa/motorcomm/). This driver requires a physical Motorcomm YT9215 switch ASIC on an MDIO bus with matching device tree bindings, which is not emulated in standard QEMU/virtualized environments. Thus, the modified code is structurally unreachable hardware and does not warrant fuzzing.",
"WorthFuzzing": false
}Results: {
"EnableConfigs": null,
"FocusSymbols": [],
"Reasoning": "The patch series refactors TC and ACL handling and updates ACL port activation logic in the Motorcomm YT9215 Ethernet switch driver (drivers/net/dsa/motorcomm/). This driver requires a physical Motorcomm YT9215 switch ASIC on an MDIO bus with matching device tree bindings, which is not emulated in standard QEMU/virtualized environments. Thus, the modified code is structurally unreachable hardware and does not warrant fuzzing.",
"WorthFuzzing": false
} |
| 21/1 | 2026/10/02 16:18 | action | If |
0mArgs:{
"WorthFuzzing": false
}Results: null |
| Total Calls | Total Tokens | Avg Tokens | Total Duration (Seconds) | Avg Duration (Seconds) |
|---|
| Total Calls | Total Duration (Seconds) | Avg Duration (Seconds) |
|---|