======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.0.32/6119 is trying to acquire lock:
ffff88810a4ac618 (sb_internal#2){.+.+}-{0:0}, at: ocfs2_setattr+0x969/0x1b40

but task is already holding lock:
ffff8881264694e0 (&ocfs2_file_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_setattr+0x95a/0x1b40

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #4 (&ocfs2_file_ip_alloc_sem_key){++++}-{4:4}:
       lock_acquire+0x120/0x360
       down_write+0x96/0x1f0
       ocfs2_try_remove_refcount_tree+0xb6/0x320
       ocfs2_xattr_set+0x595/0x11f0
       ocfs2_set_acl+0x701/0x7b0
       ocfs2_iop_set_acl+0x1aa/0x2a0
       vfs_remove_acl+0x48c/0x700
       ovl_workdir_create+0x594/0x8b0
       ovl_get_workdir+0x32f/0x17c0
       ovl_fill_super+0x1365/0x35b0
       get_tree_nodev+0xbb/0x150
       vfs_get_tree+0x92/0x2b0
       do_new_mount+0x2a2/0x9e0
       __se_sys_mount+0x317/0x410
       do_syscall_64+0xfa/0x3b0
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #3 (&oi->ip_xattr_sem){++++}-{4:4}:
       lock_acquire+0x120/0x360
       down_read+0x46/0x2e0
       ocfs2_init_acl+0x2f9/0x720
       ocfs2_mknod+0x1321/0x2050
       ocfs2_mkdir+0x191/0x440
       vfs_mkdir+0x306/0x510
       do_mkdirat+0x247/0x590
       __x64_sys_mkdirat+0x87/0xa0
       do_syscall_64+0xfa/0x3b0
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (jbd2_handle){++++}-{0:0}:
       lock_acquire+0x120/0x360
       start_this_handle+0x1fa7/0x21c0
       jbd2__journal_start+0x2c1/0x5b0
       jbd2_journal_start+0x2a/0x40
       ocfs2_start_trans+0x376/0x6d0
       ocfs2_shutdown_local_alloc+0x200/0xa10
       ocfs2_dismount_volume+0x201/0x8d0
       generic_shutdown_super+0x135/0x2c0
       kill_block_super+0x44/0x90
       deactivate_locked_super+0xbc/0x130
       cleanup_mnt+0x425/0x4c0
       task_work_run+0x1d4/0x260
       exit_to_user_mode_loop+0xec/0x110
       do_syscall_64+0x2bd/0x3b0
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&journal->j_trans_barrier){.+.+}-{4:4}:
       lock_acquire+0x120/0x360
       down_read+0x46/0x2e0
       ocfs2_start_trans+0x36a/0x6d0
       ocfs2_shutdown_local_alloc+0x200/0xa10
       ocfs2_dismount_volume+0x201/0x8d0
       generic_shutdown_super+0x135/0x2c0
       kill_block_super+0x44/0x90
       deactivate_locked_super+0xbc/0x130
       cleanup_mnt+0x425/0x4c0
       task_work_run+0x1d4/0x260
       exit_to_user_mode_loop+0xec/0x110
       do_syscall_64+0x2bd/0x3b0
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (sb_internal#2){.+.+}-{0:0}:
       validate_chain+0xb9b/0x2140
       __lock_acquire+0xab9/0xd20
       lock_acquire+0x120/0x360
       ocfs2_start_trans+0x26b/0x6d0
       ocfs2_setattr+0x969/0x1b40
       notify_change+0xb36/0xe40
       ovl_workdir_create+0x722/0x8b0
       ovl_get_workdir+0x32f/0x17c0
       ovl_fill_super+0x1365/0x35b0
       get_tree_nodev+0xbb/0x150
       vfs_get_tree+0x92/0x2b0
       do_new_mount+0x2a2/0x9e0
       __se_sys_mount+0x317/0x410
       do_syscall_64+0xfa/0x3b0
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  sb_internal#2 --> &oi->ip_xattr_sem --> &ocfs2_file_ip_alloc_sem_key

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_file_ip_alloc_sem_key);
                               lock(&oi->ip_xattr_sem);
                               lock(&ocfs2_file_ip_alloc_sem_key);
  rlock(sb_internal#2);

 *** DEADLOCK ***

4 locks held by syz.0.32/6119:
 #0: ffff888124d3e0e0 (&type->s_umount_key#67/1){+.+.}-{4:4}, at: alloc_super+0x204/0x970
 #1: ffff88810a4ac428 (sb_writers#20){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90
 #2: ffff888126469840 (&sb->s_type->i_mutex_key#30){+.+.}-{4:4}, at: ovl_workdir_create+0x6a8/0x8b0
 #3: ffff8881264694e0 (&ocfs2_file_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_setattr+0x95a/0x1b40

stack backtrace:
CPU: 1 UID: 0 PID: 6119 Comm: syz.0.32 Not tainted syzkaller #0 PREEMPT(full) 
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.2-debian-1.16.2-1 04/01/2014
Call Trace:
 <TASK>
 dump_stack_lvl+0x189/0x250
 print_circular_bug+0x2ee/0x310
 check_noncircular+0x134/0x160
 validate_chain+0xb9b/0x2140
 __lock_acquire+0xab9/0xd20
 lock_acquire+0x120/0x360
 ocfs2_start_trans+0x26b/0x6d0
 ocfs2_setattr+0x969/0x1b40
 notify_change+0xb36/0xe40
 ovl_workdir_create+0x722/0x8b0
 ovl_get_workdir+0x32f/0x17c0
 ovl_fill_super+0x1365/0x35b0
 get_tree_nodev+0xbb/0x150
 vfs_get_tree+0x92/0x2b0
 do_new_mount+0x2a2/0x9e0
 __se_sys_mount+0x317/0x410
 do_syscall_64+0xfa/0x3b0
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7ff4b078ebe9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ff4b1635038 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007ff4b09c5fa0 RCX: 00007ff4b078ebe9
RDX: 0000200000000340 RSI: 00002000000000c0 RDI: 0000000000000000
RBP: 00007ff4b0811e19 R08: 0000200000000080 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ff4b09c6038 R14: 00007ff4b09c5fa0 R15: 00007ffee9866348
 </TASK>
overlayfs: upper fs does not support tmpfile.
overlayfs: upper fs does not support RENAME_WHITEOUT.
overlayfs: upper fs missing required features.
