======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.6.193/7431 is trying to acquire lock:
ffff8881253200f8 (&HFS_I(tree->inode)->extents_lock){+.+.}-{4:4}, at: hfs_extend_file+0xda/0x1230

but task is already holding lock:
ffff88811194c0b0 (&tree->tree_lock#2/1){+.+.}-{4:4}, at: hfs_find_init+0x184/0x200

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&tree->tree_lock#2/1){+.+.}-{4:4}:
       lock_acquire+0x120/0x360
       __mutex_lock+0x187/0x1350
       hfs_find_init+0x184/0x200
       hfs_extend_file+0x2ee/0x1230
       hfs_bmap_reserve+0x107/0x430
       hfs_cat_create+0x1b3/0x640
       hfs_mkdir+0x6c/0xe0
       vfs_mkdir+0x306/0x510
       do_mkdirat+0x247/0x590
       __x64_sys_mkdirat+0x87/0xa0
       do_syscall_64+0xfa/0x3b0
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&HFS_I(tree->inode)->extents_lock){+.+.}-{4:4}:
       validate_chain+0xb9b/0x2140
       __lock_acquire+0xab9/0xd20
       lock_acquire+0x120/0x360
       __mutex_lock+0x187/0x1350
       hfs_extend_file+0xda/0x1230
       hfs_bmap_reserve+0x107/0x430
       __hfs_ext_write_extent+0x1fa/0x470
       hfs_ext_write_extent+0x161/0x1e0
       hfs_write_inode+0x91/0x7d0
       __writeback_single_inode+0x6f1/0xff0
       writeback_single_inode+0x1f3/0x6a0
       write_inode_now+0x160/0x1d0
       hfs_file_fsync+0xa4/0x140
       generic_file_write_iter+0x319/0x550
       vfs_write+0x5c9/0xb30
       ksys_write+0x145/0x250
       do_syscall_64+0xfa/0x3b0
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&tree->tree_lock#2/1);
                               lock(&HFS_I(tree->inode)->extents_lock);
                               lock(&tree->tree_lock#2/1);
  lock(&HFS_I(tree->inode)->extents_lock);

 *** DEADLOCK ***

4 locks held by syz.6.193/7431:
 #0: ffff88810c9724f8 (&f->f_pos_lock){+.+.}-{4:4}, at: fdget_pos+0x247/0x320
 #1: ffff8881253f2428 (sb_writers#29){.+.+}-{0:0}, at: vfs_write+0x211/0xb30
 #2: ffff888125321620 (&sb->s_type->i_mutex_key#38){+.+.}-{4:4}, at: hfs_file_fsync+0x9a/0x140
 #3: ffff88811194c0b0 (&tree->tree_lock#2/1){+.+.}-{4:4}, at: hfs_find_init+0x184/0x200

stack backtrace:
CPU: 0 UID: 0 PID: 7431 Comm: syz.6.193 Not tainted syzkaller #0 PREEMPT(full) 
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.2-debian-1.16.2-1 04/01/2014
Call Trace:
 <TASK>
 dump_stack_lvl+0x189/0x250
 print_circular_bug+0x2ee/0x310
 check_noncircular+0x134/0x160
 validate_chain+0xb9b/0x2140
 __lock_acquire+0xab9/0xd20
 lock_acquire+0x120/0x360
 __mutex_lock+0x187/0x1350
 hfs_extend_file+0xda/0x1230
 hfs_bmap_reserve+0x107/0x430
 __hfs_ext_write_extent+0x1fa/0x470
 hfs_ext_write_extent+0x161/0x1e0
 hfs_write_inode+0x91/0x7d0
 __writeback_single_inode+0x6f1/0xff0
 writeback_single_inode+0x1f3/0x6a0
 write_inode_now+0x160/0x1d0
 hfs_file_fsync+0xa4/0x140
 generic_file_write_iter+0x319/0x550
 vfs_write+0x5c9/0xb30
 ksys_write+0x145/0x250
 do_syscall_64+0xfa/0x3b0
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f51d738ebe9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f51d81cf038 EFLAGS: 00000246 ORIG_RAX: 0000000000000001
RAX: ffffffffffffffda RBX: 00007f51d75c6090 RCX: 00007f51d738ebe9
RDX: 000000000000045c RSI: 0000200000002d80 RDI: 0000000000000006
RBP: 00007f51d7411e19 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f51d75c6128 R14: 00007f51d75c6090 R15: 00007ffc80693448
 </TASK>
hfs: node 4:3 still has 1 user(s)!
