AI Trajectory

null

{
  "EnableConfigs": null,
  "FocusSymbols": [],
  "Reasoning": "The patch only refactors the return type of ieee80211_sta_ps_transition() and ieee80211_sta_ps_transition_ni() from int to void. None of the callers were checking the return value, so this is a purely cosmetic/refactoring change with no functional impact.",
  "WorthFuzzing": false
}

null

{
  "PatchDiff": "commit 5fb3f317458e87a697cba4d672104a7f3c32b1aa\nAuthor: syz-cluster \u003ctriage@syzkaller.com\u003e\nDate:   Mon Aug 3 01:31:49 2026 +0000\n\n    syz-cluster: applied patch under review\n\ndiff --git a/include/net/mac80211.h b/include/net/mac80211.h\nindex 9d1fac6e80829..638b8aa5214d7 100644\n--- a/include/net/mac80211.h\n+++ b/include/net/mac80211.h\n@@ -2919,8 +2919,8 @@ struct ieee80211_txq {\n  *\tautonomously manages the PS status of connected stations. When\n  *\tthis flag is set mac80211 will not trigger PS mode for connected\n  *\tstations based on the PM bit of incoming frames.\n- *\tUse ieee80211_start_ps()/ieee8021_end_ps() to manually configure\n- *\tthe PS mode of connected stations.\n+ *\tUse ieee80211_sta_ps_transition() to manually toggle the PS mode\n+ *\tof connected stations.\n  *\n  * @IEEE80211_HW_TX_AMPDU_SETUP_IN_HW: The device handles TX A-MPDU session\n  *\tsetup strictly in HW. mac80211 should not attempt to do this in\n@@ -5499,10 +5499,8 @@ static inline void ieee80211_rx_ni(struct ieee80211_hw *hw,\n  *\n  * @sta: currently connected sta\n  * @start: start or stop PS\n- *\n- * Return: 0 on success. -EINVAL when the requested PS mode is already set.\n  */\n-int ieee80211_sta_ps_transition(struct ieee80211_sta *sta, bool start);\n+void ieee80211_sta_ps_transition(struct ieee80211_sta *sta, bool start);\n \n /**\n  * ieee80211_sta_ps_transition_ni - PS transition for connected sta\n@@ -5514,19 +5512,13 @@ int ieee80211_sta_ps_transition(struct ieee80211_sta *sta, bool start);\n  *\n  * @sta: currently connected sta\n  * @start: start or stop PS\n- *\n- * Return: Like ieee80211_sta_ps_transition().\n  */\n-static inline int ieee80211_sta_ps_transition_ni(struct ieee80211_sta *sta,\n+static inline void ieee80211_sta_ps_transition_ni(struct ieee80211_sta *sta,\n \t\t\t\t\t\t  bool start)\n {\n-\tint ret;\n-\n \tlocal_bh_disable();\n-\tret = ieee80211_sta_ps_transition(sta, start);\n+\tieee80211_sta_ps_transition(sta, start);\n \tlocal_bh_enable();\n-\n-\treturn ret;\n }\n \n /**\ndiff --git a/net/mac80211/rx.c b/net/mac80211/rx.c\nindex 5e26be8e27d8f..40ed03a775ba3 100644\n--- a/net/mac80211/rx.c\n+++ b/net/mac80211/rx.c\n@@ -1744,7 +1744,7 @@ static void sta_ps_end(struct sta_info *sta)\n \tieee80211_sta_ps_deliver_wakeup(sta);\n }\n \n-int ieee80211_sta_ps_transition(struct ieee80211_sta *pubsta, bool start)\n+void ieee80211_sta_ps_transition(struct ieee80211_sta *pubsta, bool start)\n {\n \tstruct sta_info *sta = container_of(pubsta, struct sta_info, sta);\n \tbool in_ps;\n@@ -1753,15 +1753,13 @@ int ieee80211_sta_ps_transition(struct ieee80211_sta *pubsta, bool start)\n \n \t/* Don't let the same PS state be set twice */\n \tin_ps = test_sta_flag(sta, WLAN_STA_PS_STA);\n-\tif ((start \u0026\u0026 in_ps) || (!start \u0026\u0026 !in_ps))\n-\t\treturn -EINVAL;\n+\tif (start == in_ps)\n+\t\treturn;\n \n \tif (start)\n \t\tsta_ps_start(sta);\n \telse\n \t\tsta_ps_end(sta);\n-\n-\treturn 0;\n }\n EXPORT_SYMBOL(ieee80211_sta_ps_transition);\n \n"
}

best-expensive

null

{
  "EnableConfigs": null,
  "FocusSymbols": [],
  "Reasoning": "The patch only refactors the return type of ieee80211_sta_ps_transition() and ieee80211_sta_ps_transition_ni() from int to void. None of the callers were checking the return value, so this is a purely cosmetic/refactoring change with no functional impact.",
  "WorthFuzzing": false
}

You are an expert Linux kernel maintainer.
Your job is to review a provided patch series and determine
if it makes functional changes to the kernel that should be fuzzed.

IMPORTANT: The changes have ALREADY been applied and committed as the HEAD commit in
your workspace. Do NOT rely on your internal knowledge of the kernel. You must actively
use your code access tools to examine the actual source code and confirm any assumptions.

Return WorthFuzzing=false if the patch only contains:
- Modifications to Documentation/, Kconfig files, or code comments.
- Purely decorative changes, such as logging (e.g., pr_err, printk) or tracepoints.
- Changes to numeric constants or macros that do not functionally alter execution flow.
- Code paths that are impossible to reach in virtualized environments like GCE or QEMU,
  even when utilizing software-emulated hardware (e.g., usb gadget, mac80211_hwsim).
- Code in vendor-specific PCIe switch, SmartNIC, or GPU drivers (e.g., mlxsw, pds_core, qed,
  ionic, amdgpu) that require physical PCIe hardware cards not emulated in standard QEMU.
- Driver .remove, .shutdown, or pci_unregister_driver teardown callbacks (e.g., igb_remove)
  that are executed only during PCI hot-unplug or sysfs driver unbind operations.

If it modifies reachable core kernel logic, drivers, or architectures, use your code search
tools to verify the code can be executed, then return WorthFuzzing=true.

When returning WorthFuzzing=true, you MUST ALSO:
1. Extract any specific kernel functions that should be heavily fuzzed into FocusSymbols.
   Avoid listing generic hot-path functions to prevent skewed test distributions.
   Prefer non-static, non-inlined API entrypoint functions over internal static helper functions
   (which are inlined by the compiler and do not have distinct symbol addresses).
2. Identify any specific CONFIG_ options required to properly test this new/modified feature.
   Go and look into the Kconfig files and check for ifdefs around the code, do not make assumptions.
   Also check "depends on" lines in Kconfig to include any non-standard parent subsystem configs
   needed for Kbuild to compile the code statically into vmlinux. List them in the EnableConfigs
   output array, and DO NOT add a 'CONFIG_' prefix (e.g., return "NET_IPV4" instead of "CONFIG_NET_IPV4").
Prefer calling several tools at the same time to save round-trips.


Use set-results tool to provide results of the analysis.
It must be called exactly once before the final reply.
Ignore results of this tool.

For your convenience, here is the diff of the changes:
commit 5fb3f317458e87a697cba4d672104a7f3c32b1aa
Author: syz-cluster <triage@syzkaller.com>
Date:   Mon Aug 3 01:31:49 2026 +0000

    syz-cluster: applied patch under review

diff --git a/include/net/mac80211.h b/include/net/mac80211.h
index 9d1fac6e80829..638b8aa5214d7 100644
--- a/include/net/mac80211.h
+++ b/include/net/mac80211.h
@@ -2919,8 +2919,8 @@ struct ieee80211_txq {
  *	autonomously manages the PS status of connected stations. When
  *	this flag is set mac80211 will not trigger PS mode for connected
  *	stations based on the PM bit of incoming frames.
- *	Use ieee80211_start_ps()/ieee8021_end_ps() to manually configure
- *	the PS mode of connected stations.
+ *	Use ieee80211_sta_ps_transition() to manually toggle the PS mode
+ *	of connected stations.
  *
  * @IEEE80211_HW_TX_AMPDU_SETUP_IN_HW: The device handles TX A-MPDU session
  *	setup strictly in HW. mac80211 should not attempt to do this in
@@ -5499,10 +5499,8 @@ static inline void ieee80211_rx_ni(struct ieee80211_hw *hw,
  *
  * @sta: currently connected sta
  * @start: start or stop PS
- *
- * Return: 0 on success. -EINVAL when the requested PS mode is already set.
  */
-int ieee80211_sta_ps_transition(struct ieee80211_sta *sta, bool start);
+void ieee80211_sta_ps_transition(struct ieee80211_sta *sta, bool start);
 
 /**
  * ieee80211_sta_ps_transition_ni - PS transition for connected sta
@@ -5514,19 +5512,13 @@ int ieee80211_sta_ps_transition(struct ieee80211_sta *sta, bool start);
  *
  * @sta: currently connected sta
  * @start: start or stop PS
- *
- * Return: Like ieee80211_sta_ps_transition().
  */
-static inline int ieee80211_sta_ps_transition_ni(struct ieee80211_sta *sta,
+static inline void ieee80211_sta_ps_transition_ni(struct ieee80211_sta *sta,
 						  bool start)
 {
-	int ret;
-
 	local_bh_disable();
-	ret = ieee80211_sta_ps_transition(sta, start);
+	ieee80211_sta_ps_transition(sta, start);
 	local_bh_enable();
-
-	return ret;
 }
 
 /**
diff --git a/net/mac80211/rx.c b/net/mac80211/rx.c
index 5e26be8e27d8f..40ed03a775ba3 100644
--- a/net/mac80211/rx.c
+++ b/net/mac80211/rx.c
@@ -1744,7 +1744,7 @@ static void sta_ps_end(struct sta_info *sta)
 	ieee80211_sta_ps_deliver_wakeup(sta);
 }
 
-int ieee80211_sta_ps_transition(struct ieee80211_sta *pubsta, bool start)
+void ieee80211_sta_ps_transition(struct ieee80211_sta *pubsta, bool start)
 {
 	struct sta_info *sta = container_of(pubsta, struct sta_info, sta);
 	bool in_ps;
@@ -1753,15 +1753,13 @@ int ieee80211_sta_ps_transition(struct ieee80211_sta *pubsta, bool start)
 
 	/* Don't let the same PS state be set twice */
 	in_ps = test_sta_flag(sta, WLAN_STA_PS_STA);
-	if ((start && in_ps) || (!start && !in_ps))
-		return -EINVAL;
+	if (start == in_ps)
+		return;
 
 	if (start)
 		sta_ps_start(sta);
 	else
 		sta_ps_end(sta);
-
-	return 0;
 }
 EXPORT_SYMBOL(ieee80211_sta_ps_transition);
 

gemini-3.1-pro-preview

null

null

							input: 3067
							output: 27
							thoughts: 306
						

**Analyzing a Minor mac80211 Refactoring**

Okay, so I'm looking at this patch that tweaks `ieee80211_sta_ps_transition` and `ieee80211_sta_ps_transition_ni` in `net/mac80211`. The core of the change is just shifting the return type to `void` and removing the return statement from these functions. It's functionally a very small change, basically removing a return value. My initial thought is... well, it's just a return value, not a significant behavioral change, right?

Let me double-check the logic. Before the patch, there was a check:

```c
	if ((start && in_ps) || (!start && !in_ps))
		return -EINVAL;
```

And now it's:

```c
	if (start == in_ps)
		return;
```

Right, it's equivalent. `(start && in_ps) || (!start && !in_ps)` is logically the same as `start == in_ps`. The behavior is exactly the same, but instead of returning `-EINVAL` for that case, we are now just returning `void`. So we are removing the return value, not changing the control flow of the function.

Now, the important question: is this worth fuzzing? It's a pretty minor refactoring in mac80211, which usually translates to "probably not". But, you never know, right? My next step is to see if any callers of `ieee80211_sta_ps_transition` or `ieee80211_sta_ps_transition_ni` were actually *using* the return value. Did the patch itself touch any callers? It seems not. The changes are isolated to the function's definition. That means either no callers care about the return value (and we're good), or another related patch must have modified callers.

So, let's go check the callers just to be sure. It's unlikely, but not impossible, that some other patch made the return value important and now we've broken something. We're talking mac80211, so it's probably better to double check the caller, given how intricate these functions can get.

{
  "Expression": "ieee80211_sta_ps_transition"
}

{
  "Output": "Documentation/driver-api/80211/mac80211-advanced.rst=75=support for powersaving clients\n--\nDocumentation/driver-api/80211/mac80211-advanced.rst-86-\tieee80211_frame_release_type\nDocumentation/driver-api/80211/mac80211-advanced.rst:87:\tieee80211_sta_ps_transition\nDocumentation/driver-api/80211/mac80211-advanced.rst:88:\tieee80211_sta_ps_transition_ni\nDocumentation/driver-api/80211/mac80211-advanced.rst-89-\tieee80211_sta_set_buffered\n--\ndrivers/net/wireless/intel/iwlwifi/mvm/mac80211.c=3316=void iwl_mvm_sta_pm_notif(struct iwl_mvm *mvm, struct iwl_rx_cmd_buffer *rxb)\n--\ndrivers/net/wireless/intel/iwlwifi/mvm/mac80211.c-3346-\t\t\tsta);\ndrivers/net/wireless/intel/iwlwifi/mvm/mac80211.c:3347:\t\tieee80211_sta_ps_transition(sta, sleeping);\ndrivers/net/wireless/intel/iwlwifi/mvm/mac80211.c-3348-\t}\n--\ndrivers/net/wireless/mediatek/mt76/mac80211.c=1463=mt76_check_sta(struct mt76_dev *dev, struct sk_buff *skb)\n--\ndrivers/net/wireless/mediatek/mt76/mac80211.c-1526-\ndrivers/net/wireless/mediatek/mt76/mac80211.c:1527:\tieee80211_sta_ps_transition(sta, ps);\ndrivers/net/wireless/mediatek/mt76/mac80211.c-1528-}\n--\ndrivers/net/wireless/realtek/rtw89/mac.c=6029=rtw89_mac_c2h_pwr_int_notify(struct rtw89_dev *rtwdev, struct sk_buff *skb, u32 len)\n--\ndrivers/net/wireless/realtek/rtw89/mac.c-6054-\tsta = rtwsta_to_sta(rtwsta);\ndrivers/net/wireless/realtek/rtw89/mac.c:6055:\tieee80211_sta_ps_transition(sta, ps);\ndrivers/net/wireless/realtek/rtw89/mac.c-6056-\n--\ndrivers/net/wireless/ti/wlcore/ps.c=113=void wl12xx_ps_link_start(struct wl1271 *wl, struct wl12xx_vif *wlvif,\n--\ndrivers/net/wireless/ti/wlcore/ps.c-138-\ndrivers/net/wireless/ti/wlcore/ps.c:139:\tieee80211_sta_ps_transition_ni(sta, true);\ndrivers/net/wireless/ti/wlcore/ps.c-140-\trcu_read_unlock();\n--\ndrivers/net/wireless/ti/wlcore/ps.c=149=void wl12xx_ps_link_end(struct wl1271 *wl, struct wl12xx_vif *wlvif, u8 hlid)\n--\ndrivers/net/wireless/ti/wlcore/ps.c-168-\ndrivers/net/wireless/ti/wlcore/ps.c:169:\tieee80211_sta_ps_transition_ni(sta, false);\ndrivers/net/wireless/ti/wlcore/ps.c-170-end:\n--\ninclude/net/mac80211.h=2825=struct ieee80211_txq {\n--\ninclude/net/mac80211.h-2921- *\tstations based on the PM bit of incoming frames.\ninclude/net/mac80211.h:2922: *\tUse ieee80211_sta_ps_transition() to manually toggle the PS mode\ninclude/net/mac80211.h-2923- *\tof connected stations.\n--\ninclude/net/mac80211.h=3460=void ieee80211_purge_tx_queue(struct ieee80211_hw *hw,\n--\ninclude/net/mac80211.h-3734- * powersaving clients and will ignore the PM bit in incoming frames.\ninclude/net/mac80211.h:3735: * Drivers then use ieee80211_sta_ps_transition() to inform mac80211 of\ninclude/net/mac80211.h-3736- * stations' powersave transitions. In this mode, mac80211 also doesn't\n--\ninclude/net/mac80211.h=5480=static inline void ieee80211_rx_ni(struct ieee80211_hw *hw,\n--\ninclude/net/mac80211.h-5488-/**\ninclude/net/mac80211.h:5489: * ieee80211_sta_ps_transition - PS transition for connected sta\ninclude/net/mac80211.h-5490- *\n--\ninclude/net/mac80211.h-5502- */\ninclude/net/mac80211.h:5503:void ieee80211_sta_ps_transition(struct ieee80211_sta *sta, bool start);\ninclude/net/mac80211.h-5504-\ninclude/net/mac80211.h-5505-/**\ninclude/net/mac80211.h:5506: * ieee80211_sta_ps_transition_ni - PS transition for connected sta\ninclude/net/mac80211.h-5507- *                                  (in process context)\ninclude/net/mac80211.h-5508- *\ninclude/net/mac80211.h:5509: * Like ieee80211_sta_ps_transition() but can be called in process context\ninclude/net/mac80211.h-5510- * (internally disables bottom halves). Concurrent call restriction still\n--\ninclude/net/mac80211.h-5515- */\ninclude/net/mac80211.h:5516:static inline void ieee80211_sta_ps_transition_ni(struct ieee80211_sta *sta,\ninclude/net/mac80211.h-5517-\t\t\t\t\t\t  bool start)\n--\ninclude/net/mac80211.h-5519-\tlocal_bh_disable();\ninclude/net/mac80211.h:5520:\tieee80211_sta_ps_transition(sta, start);\ninclude/net/mac80211.h-5521-\tlocal_bh_enable();\n--\ninclude/net/mac80211.h-5530- * connected station was received.\ninclude/net/mac80211.h:5531: * This must be used in conjunction with ieee80211_sta_ps_transition()\ninclude/net/mac80211.h-5532- * and possibly ieee80211_sta_uapsd_trigger(); calls to all three must\n--\ninclude/net/mac80211.h=5535=void ieee80211_sta_pspoll(struct ieee80211_sta *sta);\n--\ninclude/net/mac80211.h-5544- * from a connected station was received.\ninclude/net/mac80211.h:5545: * This must be used in conjunction with ieee80211_sta_ps_transition()\ninclude/net/mac80211.h-5546- * and possibly ieee80211_sta_pspoll(); calls to all three must be\n--\nnet/mac80211/rx.c=1724=static void sta_ps_end(struct sta_info *sta)\n--\nnet/mac80211/rx.c-1746-\nnet/mac80211/rx.c:1747:void ieee80211_sta_ps_transition(struct ieee80211_sta *pubsta, bool start)\nnet/mac80211/rx.c-1748-{\n--\nnet/mac80211/rx.c-1763-}\nnet/mac80211/rx.c:1764:EXPORT_SYMBOL(ieee80211_sta_ps_transition);\nnet/mac80211/rx.c-1765-\n--\nnet/mac80211/rx.c=4720=void ieee80211_check_fast_rx(struct sta_info *sta)\n--\nnet/mac80211/rx.c-4782-\t\t/* parallel-rx requires this, at least with calls to\nnet/mac80211/rx.c:4783:\t\t * ieee80211_sta_ps_transition()\nnet/mac80211/rx.c-4784-\t\t */\n"
}

gemini-3.1-pro-preview

null

null

							input: 6435
							output: 101
							thoughts: 677
						

**Analyzing a Minor Code Refactoring**

Okay, let's break this down. My initial assessment is that this patch is a non-event. The code changes involve these functions: `iwl_mvm_sta_pm_notif`, `mt76_check_sta`, `rtw89_mac_c2h_pwr_int_notify`, `wl12xx_ps_link_start`, and `wl12xx_ps_link_end`. The patch specifically alters `ieee80211_sta_ps_transition` and `ieee80211_sta_ps_transition_ni`, changing their return type from `int` to `void` and removing the `-EINVAL` return when the power state doesn't change.

My first thought was, "Wait, is this even worth fuzzing?" The patch seems incredibly minor, purely refactoring, and functionally inert. The old code returned an error code (`-EINVAL`) if the state didn't change, but *no* caller was actually checking the return value anyway!

To be absolutely sure, I went back and re-examined the code. The `grep` output confirms: none of the calling functions utilize the return value of `ieee80211_sta_ps_transition` or `ieee80211_sta_ps_transition_ni`. So, the entire patch boils down to a cosmetic change and documentation update. No behavior has changed.

Therefore, my final conclusion is clear: WorthFuzzing=false. This is a simple cleanup, completely safe from a functional perspective.

{
  "EnableConfigs": [],
  "FocusSymbols": [],
  "Reasoning": "The patch only refactors the return type of ieee80211_sta_ps_transition() and ieee80211_sta_ps_transition_ni() from int to void. None of the callers were checking the return value, so this is a purely cosmetic/refactoring change with no functional impact.",
  "WorthFuzzing": false
}

{
  "EnableConfigs": null,
  "FocusSymbols": [],
  "Reasoning": "The patch only refactors the return type of ieee80211_sta_ps_transition() and ieee80211_sta_ps_transition_ni() from int to void. None of the callers were checking the return value, so this is a purely cosmetic/refactoring change with no functional impact.",
  "WorthFuzzing": false
}