======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.2.443/8094 is trying to acquire lock:
ffff88803d850660 (&ocfs2_file_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_try_remove_refcount_tree+0xb6/0x320

but task is already holding lock:
ffff88803d8506f8 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_try_remove_refcount_tree+0xa4/0x320

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #4 (&oi->ip_xattr_sem){++++}-{4:4}:
       lock_acquire+0x120/0x360
       down_read+0x46/0x2e0
       ocfs2_init_acl+0x2f9/0x720
       ocfs2_mknod+0x1321/0x2050
       ocfs2_create+0x1a5/0x440
       path_openat+0x14f4/0x3830
       do_filp_open+0x1fa/0x410
       do_sys_openat2+0x121/0x1c0
       __x64_sys_openat+0x138/0x170
       do_syscall_64+0xfa/0x3b0
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #3 (jbd2_handle){++++}-{0:0}:
       lock_acquire+0x120/0x360
       jbd2_journal_lock_updates+0xaa/0x360
       __ocfs2_flush_truncate_log+0x2ba/0x10e0
       ocfs2_flush_truncate_log+0x4f/0x70
       ocfs2_sync_fs+0x116/0x310
       sync_filesystem+0x1cf/0x230
       generic_shutdown_super+0x6f/0x2c0
       kill_block_super+0x44/0x90
       deactivate_locked_super+0xbc/0x130
       cleanup_mnt+0x425/0x4c0
       task_work_run+0x1d4/0x260
       exit_to_user_mode_loop+0xec/0x110
       do_syscall_64+0x2bd/0x3b0
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (&ocfs2_sysfile_lock_key[TRUNCATE_LOG_SYSTEM_INODE]){+.+.}-{4:4}:
       lock_acquire+0x120/0x360
       down_write+0x96/0x1f0
       __ocfs2_move_extents_range+0x1364/0x3380
       ocfs2_move_extents+0x378/0x960
       ocfs2_ioctl_move_extents+0x53e/0x710
       ocfs2_ioctl+0x191/0x750
       __se_sys_ioctl+0xfc/0x170
       do_syscall_64+0xfa/0x3b0
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&ocfs2_sysfile_lock_key[EXTENT_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}:
       lock_acquire+0x120/0x360
       down_write+0x96/0x1f0
       ocfs2_reserve_suballoc_bits+0x15e/0x4640
       ocfs2_reserve_new_metadata_blocks+0x403/0x940
       ocfs2_lock_meta_allocator_move_extents+0x204/0x580
       __ocfs2_move_extents_range+0xc64/0x3380
       ocfs2_move_extents+0x378/0x960
       ocfs2_ioctl_move_extents+0x53e/0x710
       ocfs2_ioctl+0x191/0x750
       __se_sys_ioctl+0xfc/0x170
       do_syscall_64+0xfa/0x3b0
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&ocfs2_file_ip_alloc_sem_key){++++}-{4:4}:
       validate_chain+0xb9b/0x2140
       __lock_acquire+0xab9/0xd20
       lock_acquire+0x120/0x360
       down_write+0x96/0x1f0
       ocfs2_try_remove_refcount_tree+0xb6/0x320
       ocfs2_xattr_set+0x595/0x11f0
       ocfs2_set_acl+0x701/0x7b0
       ocfs2_iop_set_acl+0x1aa/0x2a0
       vfs_remove_acl+0x48c/0x700
       ovl_workdir_create+0x594/0x8b0
       ovl_get_workdir+0x32f/0x17c0
       ovl_fill_super+0x1365/0x35b0
       get_tree_nodev+0xbb/0x150
       vfs_get_tree+0x92/0x2b0
       do_new_mount+0x2a2/0x9e0
       __se_sys_mount+0x317/0x410
       do_syscall_64+0xfa/0x3b0
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &ocfs2_file_ip_alloc_sem_key --> jbd2_handle --> &oi->ip_xattr_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_xattr_sem);
                               lock(jbd2_handle);
                               lock(&oi->ip_xattr_sem);
  lock(&ocfs2_file_ip_alloc_sem_key);

 *** DEADLOCK ***

4 locks held by syz.2.443/8094:
 #0: ffff8880268340e0 (&type->s_umount_key#58/1){+.+.}-{4:4}, at: alloc_super+0x204/0x970
 #1: ffff88803c406428 (sb_writers#12){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90
 #2: ffff88803d8509c0 (&sb->s_type->i_mutex_key#20){+.+.}-{4:4}, at: vfs_remove_acl+0xf9/0x700
 #3: ffff88803d8506f8 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_try_remove_refcount_tree+0xa4/0x320

stack backtrace:
CPU: 0 UID: 0 PID: 8094 Comm: syz.2.443 Not tainted syzkaller #0 PREEMPT(full) 
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.2-debian-1.16.2-1 04/01/2014
Call Trace:
 <TASK>
 dump_stack_lvl+0x189/0x250
 print_circular_bug+0x2ee/0x310
 check_noncircular+0x134/0x160
 validate_chain+0xb9b/0x2140
 __lock_acquire+0xab9/0xd20
 lock_acquire+0x120/0x360
 down_write+0x96/0x1f0
 ocfs2_try_remove_refcount_tree+0xb6/0x320
 ocfs2_xattr_set+0x595/0x11f0
 ocfs2_set_acl+0x701/0x7b0
 ocfs2_iop_set_acl+0x1aa/0x2a0
 vfs_remove_acl+0x48c/0x700
 ovl_workdir_create+0x594/0x8b0
 ovl_get_workdir+0x32f/0x17c0
 ovl_fill_super+0x1365/0x35b0
 get_tree_nodev+0xbb/0x150
 vfs_get_tree+0x92/0x2b0
 do_new_mount+0x2a2/0x9e0
 __se_sys_mount+0x317/0x410
 do_syscall_64+0xfa/0x3b0
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7fce7c78eba9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fce7d685038 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007fce7c9d5fa0 RCX: 00007fce7c78eba9
RDX: 0000200000000080 RSI: 00002000000000c0 RDI: 0000000000000000
RBP: 00007fce7c811e19 R08: 0000200000000a00 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007fce7c9d6038 R14: 00007fce7c9d5fa0 R15: 00007ffe2d7993d8
 </TASK>
overlayfs: upper fs does not support tmpfile.
(syz.2.443,8094,0):ocfs2_check_dir_entry:325 ERROR: bad entry in directory #72: rec_len % 4 != 0 - offset=16, inode=66, rec_len=491, name_len=2
(syz.2.443,8094,0):ocfs2_prepare_dir_for_insert:4302 ERROR: status = -2
(syz.2.443,8094,0):__ocfs2_prepare_orphan_dir:2183 ERROR: status = -2
(syz.2.443,8094,0):ocfs2_prepare_orphan_dir:2227 ERROR: status = -2
(syz.2.443,8094,0):ocfs2_prepare_orphan_dir:2243 ERROR: status = -2
(syz.2.443,8094,0):ocfs2_unlink:967 ERROR: status = -2
overlayfs: cleanup of 'work/#b' failed (-2)
overlayfs: upper fs does not support RENAME_WHITEOUT.
overlayfs: upper fs missing required features.
