| Seq | Timestamp | Type | Name | Duration |
|---|---|---|---|---|
| 0/0 | 2026/08/03 06:52 | flow | patch-triage |
0mArgs:null Results: {
"EnableConfigs": null,
"FocusSymbols": [],
"Reasoning": "The patch only modifies a user-space tool (tools/mm/page_owner_sort.c) and its documentation. It does not make any functional changes to the kernel itself.",
"WorthFuzzing": false
} |
| 1/1 | 2026/08/03 06:52 | action | read-patch-diff |
0mArgs:null Results: {
"PatchDiff": "commit 5fb02190b212c2eef2b31bbf447e651783681e83\nAuthor: syz-cluster \u003ctriage@syzkaller.com\u003e\nDate: Mon Aug 3 06:52:45 2026 +0000\n\n syz-cluster: applied patch under review\n\ndiff --git a/Documentation/mm/page_owner.rst b/Documentation/mm/page_owner.rst\nindex a6bd3fe6423ad..bd027377dff6e 100644\n--- a/Documentation/mm/page_owner.rst\n+++ b/Documentation/mm/page_owner.rst\n@@ -199,6 +199,7 @@ Usage\n \t\t-p\t\tSort by pid.\n \t\t-P\t\tSort by tgid.\n \t\t-n\t\tSort by task command name.\n+\t\t-M\t\tSort by module name.\n \t\t-r\t\tSort by memory release time.\n \t\t-s\t\tSort by stack trace.\n \t\t-t\t\tSort by times (default).\n@@ -240,8 +241,10 @@ Usage\n \t\t\t\t\tgroup ID numbers appear in \u003ctgidlist\u003e.\n \t\t--name \u003ccmdlist\u003e\tSelect by task command name. This selects the blocks whose\n \t\t\t\t\ttask command name appear in \u003ccmdlist\u003e.\n+\t\t--module \u003cmodlist\u003e\tSelect by module name. This selects the blocks whose\n+\t\t\t\t\tmodule name appear in \u003cmodlist\u003e.\n \n-\t\t\u003cpidlist\u003e, \u003ctgidlist\u003e, \u003ccmdlist\u003e are single arguments in the form of a comma-separated list,\n+\t\t\u003cpidlist\u003e, \u003ctgidlist\u003e, \u003ccmdlist\u003e, \u003cmodlist\u003e are single arguments in the form of a comma-separated list,\n \t\twhich offers a way to specify individual selecting rules.\n \n \n@@ -249,6 +252,7 @@ Usage\n \t\t\t\t./page_owner_sort \u003cinput\u003e \u003coutput\u003e --pid=1\n \t\t\t\t./page_owner_sort \u003cinput\u003e \u003coutput\u003e --tgid=1,2,3\n \t\t\t\t./page_owner_sort \u003cinput\u003e \u003coutput\u003e --name name1,name2\n+\t\t\t\t./page_owner_sort \u003cinput\u003e \u003coutput\u003e --module xfs,ext4\n \n STANDARD FORMAT SPECIFIERS\n ==========================\n@@ -265,6 +269,7 @@ STANDARD FORMAT SPECIFIERS\n \tft\t\tfree_ts\t\ttimestamp of the page when it was released\n \tat\t\talloc_ts\ttimestamp of the page when it was allocated\n \tator\t\tallocator\tmemory allocator for pages\n+\tmod\t\tmodule\t\tkernel module name\n \n For --cull option:\n \n@@ -275,6 +280,7 @@ STANDARD FORMAT SPECIFIERS\n \tf\t\tfree\t\twhether the page has been released or not\n \tst\t\tstacktrace\tstack trace of the page allocation\n \tator\t\tallocator\tmemory allocator for pages\n+\tmod\t\tmodule\t\tkernel module name\n \n Filtering page_owner output\n ============================\ndiff --git a/tools/mm/page_owner_sort.c b/tools/mm/page_owner_sort.c\nindex 35d3d254941c9..c5bc3b524c0a9 100644\n--- a/tools/mm/page_owner_sort.c\n+++ b/tools/mm/page_owner_sort.c\n@@ -25,11 +25,13 @@\n #include \u003cgetopt.h\u003e\n \n #define TASK_COMM_LEN 16\n+#define MODULE_NAME_LEN 64\n \n struct block_list {\n \tchar *txt;\n \tchar *comm; // task command name\n \tchar *stacktrace;\n+\tchar *module; // kernel module name\n \t__u64 ts_nsec;\n \tint len;\n \tint num;\n@@ -41,7 +43,8 @@ struct block_list {\n enum FILTER_BIT {\n \tFILTER_PID = 1\u003c\u003c1,\n \tFILTER_TGID = 1\u003c\u003c2,\n-\tFILTER_COMM = 1\u003c\u003c3\n+\tFILTER_COMM = 1\u003c\u003c3,\n+\tFILTER_MODULE = 1\u003c\u003c4\n };\n \n enum FILTER_RESULT {\n@@ -55,7 +58,8 @@ enum CULL_BIT {\n \tCULL_TGID = 1\u003c\u003c2,\n \tCULL_COMM = 1\u003c\u003c3,\n \tCULL_STACKTRACE = 1\u003c\u003c4,\n-\tCULL_ALLOCATOR = 1\u003c\u003c5\n+\tCULL_ALLOCATOR = 1\u003c\u003c5,\n+\tCULL_MODULE = 1\u003c\u003c6\n };\n enum ALLOCATOR_BIT {\n \tALLOCATOR_CMA = 1\u003c\u003c1,\n@@ -65,7 +69,8 @@ enum ALLOCATOR_BIT {\n };\n enum ARG_TYPE {\n \tARG_TXT, ARG_COMM, ARG_STACKTRACE, ARG_ALLOC_TS, ARG_CULL_TIME,\n-\tARG_PAGE_NUM, ARG_PID, ARG_TGID, ARG_UNKNOWN, ARG_ALLOCATOR\n+\tARG_PAGE_NUM, ARG_PID, ARG_TGID, ARG_UNKNOWN, ARG_ALLOCATOR,\n+\tARG_MODULE\n };\n enum SORT_ORDER {\n \tSORT_ASC = 1,\n@@ -79,15 +84,18 @@ enum COMP_FLAG {\n \tCOMP_STACK = 1\u003c\u003c3,\n \tCOMP_NUM = 1\u003c\u003c4,\n \tCOMP_TGID = 1\u003c\u003c5,\n-\tCOMP_COMM = 1\u003c\u003c6\n+\tCOMP_COMM = 1\u003c\u003c6,\n+\tCOMP_MODULE = 1\u003c\u003c7\n };\n struct filter_condition {\n \tpid_t *pids;\n \tpid_t *tgids;\n \tchar **comms;\n+\tchar **modules;\n \tint pids_size;\n \tint tgids_size;\n \tint comms_size;\n+\tint modules_size;\n };\n struct sort_condition {\n \tint (**cmps)(const void *, const void *);\n@@ -101,6 +109,7 @@ static regex_t pid_pattern;\n static regex_t tgid_pattern;\n static regex_t comm_pattern;\n static regex_t ts_nsec_pattern;\n+static regex_t module_pattern;\n static struct block_list *list;\n static int list_size;\n static int max_size;\n@@ -184,6 +193,13 @@ static int compare_comm(const void *p1, const void *p2)\n \treturn strcmp(l1-\u003ecomm, l2-\u003ecomm);\n }\n \n+static int compare_module(const void *p1, const void *p2)\n+{\n+\tconst struct block_list *l1 = p1, *l2 = p2;\n+\n+\treturn strcmp(l1-\u003emodule, l2-\u003emodule);\n+}\n+\n static int compare_ts(const void *p1, const void *p2)\n {\n \tconst struct block_list *l1 = p1, *l2 = p2;\n@@ -207,6 +223,8 @@ static int compare_cull_condition(const void *p1, const void *p2)\n \t\treturn compare_tgid(p1, p2);\n \tif ((cull \u0026 CULL_COMM) \u0026\u0026 compare_comm(p1, p2))\n \t\treturn compare_comm(p1, p2);\n+\tif ((cull \u0026 CULL_MODULE) \u0026\u0026 compare_module(p1, p2))\n+\t\treturn compare_module(p1, p2);\n \tif ((cull \u0026 CULL_ALLOCATOR) \u0026\u0026 compare_allocator(p1, p2))\n \t\treturn compare_allocator(p1, p2);\n \treturn 0;\n@@ -411,9 +429,33 @@ static char *get_comm(char *buf)\n \treturn comm_str;\n }\n \n+static char *get_module(char *buf)\n+{\n+\tchar *module_str = malloc(MODULE_NAME_LEN);\n+\tregmatch_t pmatch[2];\n+\tint val_len;\n+\n+\tif (!module_str)\n+\t\treturn NULL;\n+\tmemset(module_str, 0, MODULE_NAME_LEN);\n+\tif (regexec(\u0026module_pattern, buf, 2, pmatch, REG_NOTBOL) != 0 || pmatch[1].rm_so == -1) {\n+\t\tstrcpy(module_str, \"vmlinux\");\n+\t\treturn module_str;\n+\t}\n+\n+\tval_len = pmatch[1].rm_eo - pmatch[1].rm_so;\n+\tif ((size_t)val_len \u003e= MODULE_NAME_LEN)\n+\t\tval_len = MODULE_NAME_LEN - 1;\n+\tmemcpy(module_str, buf + pmatch[1].rm_so, val_len);\n+\tmodule_str[val_len] = '\\0';\n+\n+\treturn module_str;\n+}\n+\n static void free_block_list(struct block_list *block)\n {\n \tfree(block-\u003ecomm);\n+\tfree(block-\u003emodule);\n \tfree(block-\u003etxt);\n }\n \n@@ -433,6 +475,8 @@ static int get_arg_type(const char *arg)\n \t\treturn ARG_ALLOC_TS;\n \telse if (!strcmp(arg, \"allocator\") || !strcmp(arg, \"ator\"))\n \t\treturn ARG_ALLOCATOR;\n+\telse if (!strcmp(arg, \"module\") || !strcmp(arg, \"mod\"))\n+\t\treturn ARG_MODULE;\n \telse {\n \t\treturn ARG_UNKNOWN;\n \t}\n@@ -483,25 +527,36 @@ static bool match_str_list(const char *str, char **list, int list_size)\n \n static enum FILTER_RESULT filter_record(char *buf)\n {\n-\tchar *comm;\n+\tchar *comm, *module;\n \n \tif ((filter \u0026 FILTER_PID) \u0026\u0026 !match_num_list(get_pid(buf), fc.pids, fc.pids_size))\n \t\treturn FILTER_SKIP;\n \tif ((filter \u0026 FILTER_TGID) \u0026\u0026\n \t\t!match_num_list(get_tgid(buf), fc.tgids, fc.tgids_size))\n \t\treturn FILTER_SKIP;\n-\tif (!(filter \u0026 FILTER_COMM))\n+\tif (!(filter \u0026 (FILTER_COMM | FILTER_MODULE)))\n \t\treturn FILTER_MATCH;\n \n-\tcomm = get_comm(buf);\n-\tif (!comm)\n-\t\treturn FILTER_ERROR;\n-\n-\tif (!match_str_list(comm, fc.comms, fc.comms_size)) {\n+\tif (filter \u0026 FILTER_COMM) {\n+\t\tcomm = get_comm(buf);\n+\t\tif (!comm)\n+\t\t\treturn FILTER_ERROR;\n+\t\tif (!match_str_list(comm, fc.comms, fc.comms_size)) {\n+\t\t\tfree(comm);\n+\t\t\treturn FILTER_SKIP;\n+\t\t}\n \t\tfree(comm);\n-\t\treturn FILTER_SKIP;\n \t}\n-\tfree(comm);\n+\tif (filter \u0026 FILTER_MODULE) {\n+\t\tmodule = get_module(buf);\n+\t\tif (!module)\n+\t\t\treturn FILTER_ERROR;\n+\t\tif (!match_str_list(module, fc.modules, fc.modules_size)) {\n+\t\t\tfree(module);\n+\t\t\treturn FILTER_SKIP;\n+\t\t}\n+\t\tfree(module);\n+\t}\n \treturn FILTER_MATCH;\n }\n \n@@ -547,6 +602,12 @@ static bool add_list(char *buf, int len, char *ext_buf)\n \t\tlist[list_size].stacktrace++;\n \tlist[list_size].ts_nsec = get_ts_nsec(buf);\n \tlist[list_size].allocator = get_allocator(buf, ext_buf);\n+\tlist[list_size].module = get_module(buf);\n+\tif (!list[list_size].module) {\n+\t\tfprintf(stderr, \"Out of memory\\n\");\n+\t\tfree_block_list(\u0026list[list_size]);\n+\t\treturn false;\n+\t}\n \tlist_size++;\n \tif (list_size % 1000 == 0) {\n \t\tprintf(\"loaded %d\\r\", list_size);\n@@ -573,6 +634,8 @@ static bool parse_cull_args(const char *arg_str)\n \t\t\tcull |= CULL_STACKTRACE;\n \t\telse if (arg_type == ARG_ALLOCATOR)\n \t\t\tcull |= CULL_ALLOCATOR;\n+\t\telse if (arg_type == ARG_MODULE)\n+\t\t\tcull |= CULL_MODULE;\n \t\telse {\n \t\t\tfree_explode(args, size);\n \t\t\treturn false;\n@@ -635,6 +698,8 @@ static bool parse_sort_args(const char *arg_str)\n \t\t\tsc.cmps[i] = compare_txt;\n \t\telse if (arg_type == ARG_ALLOCATOR)\n \t\t\tsc.cmps[i] = compare_allocator;\n+\t\telse if (arg_type == ARG_MODULE)\n+\t\t\tsc.cmps[i] = compare_module;\n \t\telse {\n \t\t\tfree_explode(args, size);\n \t\t\tsc.size = 0;\n@@ -691,7 +756,8 @@ static void usage(void)\n \t\t\"-p\\t\\t\\tSort by pid.\\n\"\n \t\t\"-P\\t\\t\\tSort by tgid.\\n\"\n \t\t\"-s\\t\\t\\tSort by the stacktrace.\\n\"\n-\t\t\"-t\\t\\t\\tSort by number of times record is seen (default).\\n\\n\"\n+\t\t\"-t\\t\\t\\tSort by number of times record is seen (default).\\n\"\n+\t\t\"-M\\t\\t\\tSort by module name.\\n\\n\"\n \t\t\"--pid \u003cpidlist\u003e\\t\\tSelect by pid. This selects the information\"\n \t\t\" of\\n\\t\\t\\tblocks whose process ID numbers appear in \u003cpidlist\u003e.\\n\"\n \t\t\"--tgid \u003ctgidlist\u003e\\tSelect by tgid. This selects the information\"\n@@ -700,11 +766,21 @@ static void usage(void)\n \t\t\"--name \u003ccmdlist\u003e\\tSelect by command name. This selects the\"\n \t\t\" information\\n\\t\\t\\tof blocks whose command name appears in\"\n \t\t\" \u003ccmdlist\u003e.\\n\"\n-\t\t\"--cull \u003crules\u003e\\t\\tCull by user-defined rules. \u003crules\u003e is a \"\n-\t\t\"single\\n\\t\\t\\targument in the form of a comma-separated list \"\n-\t\t\"with some\\n\\t\\t\\tcommon fields predefined (pid, tgid, comm, \"\n-\t\t\"stacktrace, allocator)\\n\"\n+\t\t\"--module \u003cmodlist\u003e\\tSelect by module name. This selects the information\\n\"\n+\t\t\"\\t\\t\\tof blocks whose module name appears in \u003cmodlist\u003e.\\n\"\n+\t\t\"--cull \u003crules\u003e\\t\\tCull by user-defined rules. \u003crules\u003e is a single\\n\"\n+\t\t\"\\t\\t\\targument in the form of a comma-separated list with some\\n\"\n+\t\t\"\\t\\t\\tcommon fields predefined (pid, tgid, comm, stacktrace, allocator, module)\\n\"\n \t\t\"--sort \u003corder\u003e\\t\\tSpecify sort order as: [+|-]key[,[+|-]key[,...]]\\n\"\n+\t\t\"\\t\\t\\tAvailable keys:\\n\"\n+\t\t\"\\t\\t\\t pid(p), tgid(tg), name(n), stacktrace(st),\\n\"\n+\t\t\"\\t\\t\\t txt(T), alloc_ts(at), allocator(ator), module(mod)\\n\"\n+\t\t\"\\t\\t\\tThe \\\"+\\\" is optional since default direction is\\n\"\n+\t\t\"\\t\\t\\tincreasing numerical or lexicographic order.\\n\"\n+\t\t\"\\t\\t\\tMixed use of abbreviated and complete-form is allowed.\\n\"\n+\t\t\"\\t\\t\\tExamples:\\n\"\n+\t\t\"\\t\\t\\t --sort=n,+pid,-tgid\\n\"\n+\t\t\"\\t\\t\\t --sort=mod,at\\n\"\n \t);\n }\n \n@@ -721,13 +797,14 @@ int main(int argc, char **argv)\n \t\t{ \"name\", required_argument, NULL, 3 },\n \t\t{ \"cull\", required_argument, NULL, 4 },\n \t\t{ \"sort\", required_argument, NULL, 5 },\n+\t\t{ \"module\", required_argument, NULL, 6 },\n \t\t{ \"help\", no_argument, NULL, 'h' },\n \t\t{ 0, 0, 0, 0},\n \t};\n \n \tcompare_flag = COMP_NO_FLAG;\n \n-\twhile ((opt = getopt_long(argc, argv, \"admnpstPh\", longopts, NULL)) != -1)\n+\twhile ((opt = getopt_long(argc, argv, \"admnpstPMh\", longopts, NULL)) != -1)\n \t\tswitch (opt) {\n \t\tcase 'a':\n \t\t\tcompare_flag |= COMP_ALLOC;\n@@ -753,6 +830,9 @@ int main(int argc, char **argv)\n \t\tcase 'n':\n \t\t\tcompare_flag |= COMP_COMM;\n \t\t\tbreak;\n+\t\tcase 'M':\n+\t\t\tcompare_flag |= COMP_MODULE;\n+\t\t\tbreak;\n \t\tcase 'h':\n \t\t\tusage();\n \t\t\texit(0);\n@@ -792,6 +872,10 @@ int main(int argc, char **argv)\n \t\t\t\texit(1);\n \t\t\t}\n \t\t\tbreak;\n+\t\tcase 6:\n+\t\t\tfilter = filter | FILTER_MODULE;\n+\t\t\tfc.modules = explode(',', optarg, \u0026fc.modules_size);\n+\t\t\tbreak;\n \t\tdefault:\n \t\t\tusage();\n \t\t\texit(1);\n@@ -821,6 +905,10 @@ int main(int argc, char **argv)\n \t\tset_single_cmp(compare_stacktrace, SORT_ASC);\n \t\tbreak;\n \tcase COMP_NO_FLAG:\n+\t\tif (sc.size \u003e 0)\n+\t\t\tbreak;\n+\t\tset_single_cmp(compare_num, SORT_DESC);\n+\t\tbreak;\n \tcase COMP_NUM:\n \t\tset_single_cmp(compare_num, SORT_DESC);\n \t\tbreak;\n@@ -830,6 +918,9 @@ int main(int argc, char **argv)\n \tcase COMP_COMM:\n \t\tset_single_cmp(compare_comm, SORT_ASC);\n \t\tbreak;\n+\tcase COMP_MODULE:\n+\t\tset_single_cmp(compare_module, SORT_ASC);\n+\t\tbreak;\n \tdefault:\n \t\tusage();\n \t\texit(1);\n@@ -853,6 +944,8 @@ int main(int argc, char **argv)\n \t\tgoto out_comm;\n \tif (!check_regcomp(\u0026ts_nsec_pattern, \"ts\\\\s*([0-9]*)\\\\s*ns\"))\n \t\tgoto out_ts;\n+\tif (!check_regcomp(\u0026module_pattern, \"\\\\+0x[0-9a-f]+/0x[0-9a-f]+\\\\s*\\\\[([a-zA-Z0-9_-]+)\\\\]\"))\n+\t\tgoto out_module;\n \n \tfstat(fileno(fin), \u0026st);\n \tmax_size = st.st_size / 100; /* hack ... */\n@@ -911,6 +1004,8 @@ int main(int argc, char **argv)\n \t\t\t\tfprintf(fout, \", TGID %d\", list[i].tgid);\n \t\t\tif (cull \u0026 CULL_COMM || filter \u0026 FILTER_COMM)\n \t\t\t\tfprintf(fout, \", task_comm_name: %s\", list[i].comm);\n+\t\t\tif (cull \u0026 CULL_MODULE || filter \u0026 FILTER_MODULE)\n+\t\t\t\tfprintf(fout, \", module: %s\", list[i].module);\n \t\t\tif (cull \u0026 CULL_ALLOCATOR) {\n \t\t\t\tfprintf(fout, \", \");\n \t\t\t\tprint_allocator(fout, list[i].allocator);\n@@ -931,6 +1026,8 @@ int main(int argc, char **argv)\n \t\t\tfree_block_list(\u0026list[i]);\n \t\tfree(list);\n \t}\n+out_module:\n+\tregfree(\u0026module_pattern);\n out_ts:\n \tregfree(\u0026ts_nsec_pattern);\n out_comm:\n"
} |
| 2/1 | 2026/08/03 06:52 | agent | patch-evaluator |
0mModel:best-expensive Args: null Results: {
"EnableConfigs": null,
"FocusSymbols": [],
"Reasoning": "The patch only modifies a user-space tool (tools/mm/page_owner_sort.c) and its documentation. It does not make any functional changes to the kernel itself.",
"WorthFuzzing": false
}Instruction: You are an expert Linux kernel maintainer. Your job is to review a provided patch series and determine if it makes functional changes to the kernel that should be fuzzed. IMPORTANT: The changes have ALREADY been applied and committed as the HEAD commit in your workspace. Do NOT rely on your internal knowledge of the kernel. You must actively use your code access tools to examine the actual source code and confirm any assumptions. Return WorthFuzzing=false if the patch only contains: - Modifications to Documentation/, Kconfig files, or code comments. - Purely decorative changes, such as logging (e.g., pr_err, printk) or tracepoints. - Changes to numeric constants or macros that do not functionally alter execution flow. - Code paths that are impossible to reach in virtualized environments like GCE or QEMU, even when utilizing software-emulated hardware (e.g., usb gadget, mac80211_hwsim). - Code in vendor-specific PCIe switch, SmartNIC, or GPU drivers (e.g., mlxsw, pds_core, qed, ionic, amdgpu) that require physical PCIe hardware cards not emulated in standard QEMU. - Driver .remove, .shutdown, or pci_unregister_driver teardown callbacks (e.g., igb_remove) that are executed only during PCI hot-unplug or sysfs driver unbind operations. If it modifies reachable core kernel logic, drivers, or architectures, use your code search tools to verify the code can be executed, then return WorthFuzzing=true. When returning WorthFuzzing=true, you MUST ALSO: 1. Extract any specific kernel functions that should be heavily fuzzed into FocusSymbols. Avoid listing generic hot-path functions to prevent skewed test distributions. Prefer non-static, non-inlined API entrypoint functions over internal static helper functions (which are inlined by the compiler and do not have distinct symbol addresses). 2. Identify any specific CONFIG_ options required to properly test this new/modified feature. Go and look into the Kconfig files and check for ifdefs around the code, do not make assumptions. Also check "depends on" lines in Kconfig to include any non-standard parent subsystem configs needed for Kbuild to compile the code statically into vmlinux. List them in the EnableConfigs output array, and DO NOT add a 'CONFIG_' prefix (e.g., return "NET_IPV4" instead of "CONFIG_NET_IPV4"). Prefer calling several tools at the same time to save round-trips. Use set-results tool to provide results of the analysis. It must be called exactly once before the final reply. Ignore results of this tool. Prompt: For your convenience, here is the diff of the changes:
commit 5fb02190b212c2eef2b31bbf447e651783681e83
Author: syz-cluster <triage@syzkaller.com>
Date: Mon Aug 3 06:52:45 2026 +0000
syz-cluster: applied patch under review
diff --git a/Documentation/mm/page_owner.rst b/Documentation/mm/page_owner.rst
index a6bd3fe6423ad..bd027377dff6e 100644
--- a/Documentation/mm/page_owner.rst
+++ b/Documentation/mm/page_owner.rst
@@ -199,6 +199,7 @@ Usage
-p Sort by pid.
-P Sort by tgid.
-n Sort by task command name.
+ -M Sort by module name.
-r Sort by memory release time.
-s Sort by stack trace.
-t Sort by times (default).
@@ -240,8 +241,10 @@ Usage
group ID numbers appear in <tgidlist>.
--name <cmdlist> Select by task command name. This selects the blocks whose
task command name appear in <cmdlist>.
+ --module <modlist> Select by module name. This selects the blocks whose
+ module name appear in <modlist>.
- <pidlist>, <tgidlist>, <cmdlist> are single arguments in the form of a comma-separated list,
+ <pidlist>, <tgidlist>, <cmdlist>, <modlist> are single arguments in the form of a comma-separated list,
which offers a way to specify individual selecting rules.
@@ -249,6 +252,7 @@ Usage
./page_owner_sort <input> <output> --pid=1
./page_owner_sort <input> <output> --tgid=1,2,3
./page_owner_sort <input> <output> --name name1,name2
+ ./page_owner_sort <input> <output> --module xfs,ext4
STANDARD FORMAT SPECIFIERS
==========================
@@ -265,6 +269,7 @@ STANDARD FORMAT SPECIFIERS
ft free_ts timestamp of the page when it was released
at alloc_ts timestamp of the page when it was allocated
ator allocator memory allocator for pages
+ mod module kernel module name
For --cull option:
@@ -275,6 +280,7 @@ STANDARD FORMAT SPECIFIERS
f free whether the page has been released or not
st stacktrace stack trace of the page allocation
ator allocator memory allocator for pages
+ mod module kernel module name
Filtering page_owner output
============================
diff --git a/tools/mm/page_owner_sort.c b/tools/mm/page_owner_sort.c
index 35d3d254941c9..c5bc3b524c0a9 100644
--- a/tools/mm/page_owner_sort.c
+++ b/tools/mm/page_owner_sort.c
@@ -25,11 +25,13 @@
#include <getopt.h>
#define TASK_COMM_LEN 16
+#define MODULE_NAME_LEN 64
struct block_list {
char *txt;
char *comm; // task command name
char *stacktrace;
+ char *module; // kernel module name
__u64 ts_nsec;
int len;
int num;
@@ -41,7 +43,8 @@ struct block_list {
enum FILTER_BIT {
FILTER_PID = 1<<1,
FILTER_TGID = 1<<2,
- FILTER_COMM = 1<<3
+ FILTER_COMM = 1<<3,
+ FILTER_MODULE = 1<<4
};
enum FILTER_RESULT {
@@ -55,7 +58,8 @@ enum CULL_BIT {
CULL_TGID = 1<<2,
CULL_COMM = 1<<3,
CULL_STACKTRACE = 1<<4,
- CULL_ALLOCATOR = 1<<5
+ CULL_ALLOCATOR = 1<<5,
+ CULL_MODULE = 1<<6
};
enum ALLOCATOR_BIT {
ALLOCATOR_CMA = 1<<1,
@@ -65,7 +69,8 @@ enum ALLOCATOR_BIT {
};
enum ARG_TYPE {
ARG_TXT, ARG_COMM, ARG_STACKTRACE, ARG_ALLOC_TS, ARG_CULL_TIME,
- ARG_PAGE_NUM, ARG_PID, ARG_TGID, ARG_UNKNOWN, ARG_ALLOCATOR
+ ARG_PAGE_NUM, ARG_PID, ARG_TGID, ARG_UNKNOWN, ARG_ALLOCATOR,
+ ARG_MODULE
};
enum SORT_ORDER {
SORT_ASC = 1,
@@ -79,15 +84,18 @@ enum COMP_FLAG {
COMP_STACK = 1<<3,
COMP_NUM = 1<<4,
COMP_TGID = 1<<5,
- COMP_COMM = 1<<6
+ COMP_COMM = 1<<6,
+ COMP_MODULE = 1<<7
};
struct filter_condition {
pid_t *pids;
pid_t *tgids;
char **comms;
+ char **modules;
int pids_size;
int tgids_size;
int comms_size;
+ int modules_size;
};
struct sort_condition {
int (**cmps)(const void *, const void *);
@@ -101,6 +109,7 @@ static regex_t pid_pattern;
static regex_t tgid_pattern;
static regex_t comm_pattern;
static regex_t ts_nsec_pattern;
+static regex_t module_pattern;
static struct block_list *list;
static int list_size;
static int max_size;
@@ -184,6 +193,13 @@ static int compare_comm(const void *p1, const void *p2)
return strcmp(l1->comm, l2->comm);
}
+static int compare_module(const void *p1, const void *p2)
+{
+ const struct block_list *l1 = p1, *l2 = p2;
+
+ return strcmp(l1->module, l2->module);
+}
+
static int compare_ts(const void *p1, const void *p2)
{
const struct block_list *l1 = p1, *l2 = p2;
@@ -207,6 +223,8 @@ static int compare_cull_condition(const void *p1, const void *p2)
return compare_tgid(p1, p2);
if ((cull & CULL_COMM) && compare_comm(p1, p2))
return compare_comm(p1, p2);
+ if ((cull & CULL_MODULE) && compare_module(p1, p2))
+ return compare_module(p1, p2);
if ((cull & CULL_ALLOCATOR) && compare_allocator(p1, p2))
return compare_allocator(p1, p2);
return 0;
@@ -411,9 +429,33 @@ static char *get_comm(char *buf)
return comm_str;
}
+static char *get_module(char *buf)
+{
+ char *module_str = malloc(MODULE_NAME_LEN);
+ regmatch_t pmatch[2];
+ int val_len;
+
+ if (!module_str)
+ return NULL;
+ memset(module_str, 0, MODULE_NAME_LEN);
+ if (regexec(&module_pattern, buf, 2, pmatch, REG_NOTBOL) != 0 || pmatch[1].rm_so == -1) {
+ strcpy(module_str, "vmlinux");
+ return module_str;
+ }
+
+ val_len = pmatch[1].rm_eo - pmatch[1].rm_so;
+ if ((size_t)val_len >= MODULE_NAME_LEN)
+ val_len = MODULE_NAME_LEN - 1;
+ memcpy(module_str, buf + pmatch[1].rm_so, val_len);
+ module_str[val_len] = '\0';
+
+ return module_str;
+}
+
static void free_block_list(struct block_list *block)
{
free(block->comm);
+ free(block->module);
free(block->txt);
}
@@ -433,6 +475,8 @@ static int get_arg_type(const char *arg)
return ARG_ALLOC_TS;
else if (!strcmp(arg, "allocator") || !strcmp(arg, "ator"))
return ARG_ALLOCATOR;
+ else if (!strcmp(arg, "module") || !strcmp(arg, "mod"))
+ return ARG_MODULE;
else {
return ARG_UNKNOWN;
}
@@ -483,25 +527,36 @@ static bool match_str_list(const char *str, char **list, int list_size)
static enum FILTER_RESULT filter_record(char *buf)
{
- char *comm;
+ char *comm, *module;
if ((filter & FILTER_PID) && !match_num_list(get_pid(buf), fc.pids, fc.pids_size))
return FILTER_SKIP;
if ((filter & FILTER_TGID) &&
!match_num_list(get_tgid(buf), fc.tgids, fc.tgids_size))
return FILTER_SKIP;
- if (!(filter & FILTER_COMM))
+ if (!(filter & (FILTER_COMM | FILTER_MODULE)))
return FILTER_MATCH;
- comm = get_comm(buf);
- if (!comm)
- return FILTER_ERROR;
-
- if (!match_str_list(comm, fc.comms, fc.comms_size)) {
+ if (filter & FILTER_COMM) {
+ comm = get_comm(buf);
+ if (!comm)
+ return FILTER_ERROR;
+ if (!match_str_list(comm, fc.comms, fc.comms_size)) {
+ free(comm);
+ return FILTER_SKIP;
+ }
free(comm);
- return FILTER_SKIP;
}
- free(comm);
+ if (filter & FILTER_MODULE) {
+ module = get_module(buf);
+ if (!module)
+ return FILTER_ERROR;
+ if (!match_str_list(module, fc.modules, fc.modules_size)) {
+ free(module);
+ return FILTER_SKIP;
+ }
+ free(module);
+ }
return FILTER_MATCH;
}
@@ -547,6 +602,12 @@ static bool add_list(char *buf, int len, char *ext_buf)
list[list_size].stacktrace++;
list[list_size].ts_nsec = get_ts_nsec(buf);
list[list_size].allocator = get_allocator(buf, ext_buf);
+ list[list_size].module = get_module(buf);
+ if (!list[list_size].module) {
+ fprintf(stderr, "Out of memory\n");
+ free_block_list(&list[list_size]);
+ return false;
+ }
list_size++;
if (list_size % 1000 == 0) {
printf("loaded %d\r", list_size);
@@ -573,6 +634,8 @@ static bool parse_cull_args(const char *arg_str)
cull |= CULL_STACKTRACE;
else if (arg_type == ARG_ALLOCATOR)
cull |= CULL_ALLOCATOR;
+ else if (arg_type == ARG_MODULE)
+ cull |= CULL_MODULE;
else {
free_explode(args, size);
return false;
@@ -635,6 +698,8 @@ static bool parse_sort_args(const char *arg_str)
sc.cmps[i] = compare_txt;
else if (arg_type == ARG_ALLOCATOR)
sc.cmps[i] = compare_allocator;
+ else if (arg_type == ARG_MODULE)
+ sc.cmps[i] = compare_module;
else {
free_explode(args, size);
sc.size = 0;
@@ -691,7 +756,8 @@ static void usage(void)
"-p\t\t\tSort by pid.\n"
"-P\t\t\tSort by tgid.\n"
"-s\t\t\tSort by the stacktrace.\n"
- "-t\t\t\tSort by number of times record is seen (default).\n\n"
+ "-t\t\t\tSort by number of times record is seen (default).\n"
+ "-M\t\t\tSort by module name.\n\n"
"--pid <pidlist>\t\tSelect by pid. This selects the information"
" of\n\t\t\tblocks whose process ID numbers appear in <pidlist>.\n"
"--tgid <tgidlist>\tSelect by tgid. This selects the information"
@@ -700,11 +766,21 @@ static void usage(void)
"--name <cmdlist>\tSelect by command name. This selects the"
" information\n\t\t\tof blocks whose command name appears in"
" <cmdlist>.\n"
- "--cull <rules>\t\tCull by user-defined rules. <rules> is a "
- "single\n\t\t\targument in the form of a comma-separated list "
- "with some\n\t\t\tcommon fields predefined (pid, tgid, comm, "
- "stacktrace, allocator)\n"
+ "--module <modlist>\tSelect by module name. This selects the information\n"
+ "\t\t\tof blocks whose module name appears in <modlist>.\n"
+ "--cull <rules>\t\tCull by user-defined rules. <rules> is a single\n"
+ "\t\t\targument in the form of a comma-separated list with some\n"
+ "\t\t\tcommon fields predefined (pid, tgid, comm, stacktrace, allocator, module)\n"
"--sort <order>\t\tSpecify sort order as: [+|-]key[,[+|-]key[,...]]\n"
+ "\t\t\tAvailable keys:\n"
+ "\t\t\t pid(p), tgid(tg), name(n), stacktrace(st),\n"
+ "\t\t\t txt(T), alloc_ts(at), allocator(ator), module(mod)\n"
+ "\t\t\tThe \"+\" is optional since default direction is\n"
+ "\t\t\tincreasing numerical or lexicographic order.\n"
+ "\t\t\tMixed use of abbreviated and complete-form is allowed.\n"
+ "\t\t\tExamples:\n"
+ "\t\t\t --sort=n,+pid,-tgid\n"
+ "\t\t\t --sort=mod,at\n"
);
}
@@ -721,13 +797,14 @@ int main(int argc, char **argv)
{ "name", required_argument, NULL, 3 },
{ "cull", required_argument, NULL, 4 },
{ "sort", required_argument, NULL, 5 },
+ { "module", required_argument, NULL, 6 },
{ "help", no_argument, NULL, 'h' },
{ 0, 0, 0, 0},
};
compare_flag = COMP_NO_FLAG;
- while ((opt = getopt_long(argc, argv, "admnpstPh", longopts, NULL)) != -1)
+ while ((opt = getopt_long(argc, argv, "admnpstPMh", longopts, NULL)) != -1)
switch (opt) {
case 'a':
compare_flag |= COMP_ALLOC;
@@ -753,6 +830,9 @@ int main(int argc, char **argv)
case 'n':
compare_flag |= COMP_COMM;
break;
+ case 'M':
+ compare_flag |= COMP_MODULE;
+ break;
case 'h':
usage();
exit(0);
@@ -792,6 +872,10 @@ int main(int argc, char **argv)
exit(1);
}
break;
+ case 6:
+ filter = filter | FILTER_MODULE;
+ fc.modules = explode(',', optarg, &fc.modules_size);
+ break;
default:
usage();
exit(1);
@@ -821,6 +905,10 @@ int main(int argc, char **argv)
set_single_cmp(compare_stacktrace, SORT_ASC);
break;
case COMP_NO_FLAG:
+ if (sc.size > 0)
+ break;
+ set_single_cmp(compare_num, SORT_DESC);
+ break;
case COMP_NUM:
set_single_cmp(compare_num, SORT_DESC);
break;
@@ -830,6 +918,9 @@ int main(int argc, char **argv)
case COMP_COMM:
set_single_cmp(compare_comm, SORT_ASC);
break;
+ case COMP_MODULE:
+ set_single_cmp(compare_module, SORT_ASC);
+ break;
default:
usage();
exit(1);
@@ -853,6 +944,8 @@ int main(int argc, char **argv)
goto out_comm;
if (!check_regcomp(&ts_nsec_pattern, "ts\\s*([0-9]*)\\s*ns"))
goto out_ts;
+ if (!check_regcomp(&module_pattern, "\\+0x[0-9a-f]+/0x[0-9a-f]+\\s*\\[([a-zA-Z0-9_-]+)\\]"))
+ goto out_module;
fstat(fileno(fin), &st);
max_size = st.st_size / 100; /* hack ... */
@@ -911,6 +1004,8 @@ int main(int argc, char **argv)
fprintf(fout, ", TGID %d", list[i].tgid);
if (cull & CULL_COMM || filter & FILTER_COMM)
fprintf(fout, ", task_comm_name: %s", list[i].comm);
+ if (cull & CULL_MODULE || filter & FILTER_MODULE)
+ fprintf(fout, ", module: %s", list[i].module);
if (cull & CULL_ALLOCATOR) {
fprintf(fout, ", ");
print_allocator(fout, list[i].allocator);
@@ -931,6 +1026,8 @@ int main(int argc, char **argv)
free_block_list(&list[i]);
free(list);
}
+out_module:
+ regfree(&module_pattern);
out_ts:
regfree(&ts_nsec_pattern);
out_comm:
|
| 3/2 | 2026/08/03 06:52 | llm | patch-evaluator |
0mModel:gemini-3.1-pro-preview Args: null Results: null Tokens: input: 6879 output: 69 thoughts: 333 Thoughts: **Patch Evaluation: Not Worth Fuzzing** Okay, let's assess this patch for fuzzing potential. My initial thought is that it's likely *not* worth fuzzing, but let's be thorough. The patch touches `Documentation/mm/page_owner.rst` and `tools/mm/page_owner_sort.c`. Right away, the `tools/` directory is a red flag in terms of syzkaller fuzzing targets; tools in there are generally user-space utilities and not part of the core kernel execution path we're targeting. Wait, just a sanity check. Let's make absolutely sure there aren't any sneaky kernel changes buried in there. Double-checking... Yep, the diff only shows those two files: `Documentation/mm/page_owner.rst` and `tools/mm/page_owner_sort.c`. Okay, so we're safe. User-space tools are explicitly *outside* the scope of what we want to fuzz with syzkaller. Let's confirm those file locations again: * `Documentation/mm/page_owner.rst` - Documentation, not code. * `tools/mm/page_owner_sort.c` - User-space tool. So, since both modified files are definitely *not* kernel source, we can safely mark this as `WorthFuzzing=false`. The reasoning is straightforward: this patch is confined to a user-space utility and its documentation. It doesn't introduce any functional changes to the kernel itself, so there's nothing for syzkaller to target. Now, let's put it all together concisely. `WorthFuzzing: false` `FocusSymbols: []` `EnableConfigs: []` `Reasoning: "The patch only modifies a user-space tool (tools/mm/page_owner_sort.c) and its documentation. It does not make any functional changes to the kernel itself."` |
| 4/2 | 2026/08/03 06:52 | tool | set-results |
0mArgs:{
"EnableConfigs": [],
"FocusSymbols": [],
"Reasoning": "The patch only modifies a user-space tool (tools/mm/page_owner_sort.c) and its documentation. It does not make any functional changes to the kernel itself.",
"WorthFuzzing": false
}Results: {
"EnableConfigs": null,
"FocusSymbols": [],
"Reasoning": "The patch only modifies a user-space tool (tools/mm/page_owner_sort.c) and its documentation. It does not make any functional changes to the kernel itself.",
"WorthFuzzing": false
} |
| Total Calls | Total Tokens | Avg Tokens | Total Duration (Seconds) | Avg Duration (Seconds) |
|---|
| Total Calls | Total Duration (Seconds) | Avg Duration (Seconds) |
|---|