netdevsim netdevsim4 netdevsim0: unset [1, 1] type 2 family 0 port 20000 - 0
netdevsim netdevsim4 netdevsim0: unset [1, 0] type 2 family 0 port 6081 - 0
============================================
WARNING: possible recursive locking detected
6.16.0-rc3-syzkaller-00159-g223e2288f4b8 #0 Not tainted
--------------------------------------------
syz.4.6013/24702 is trying to acquire lock:
ffff88811e780d30 (&dev_instance_lock_key#20){+.+.}-{4:4}, at: __netdev_update_features+0xcb1/0x1a20

but task is already holding lock:
ffff88811e780d30 (&dev_instance_lock_key#20){+.+.}-{4:4}, at: dev_ethtool+0x716/0x1990
and the lock comparison function returns 0:

other info that might help us debug this:
 Possible unsafe locking scenario:

       CPU0
       ----
  lock(&dev_instance_lock_key#20);
  lock(&dev_instance_lock_key#20);

 *** DEADLOCK ***

 May be due to missing lock nesting notation

2 locks held by syz.4.6013/24702:
 #0: ffffffff8f50ffc8 (rtnl_mutex){+.+.}-{4:4}, at: dev_ethtool+0x1d0/0x1990
 #1: ffff88811e780d30 (&dev_instance_lock_key#20){+.+.}-{4:4}, at: dev_ethtool+0x716/0x1990

stack backtrace:
CPU: 1 UID: 0 PID: 24702 Comm: syz.4.6013 Not tainted 6.16.0-rc3-syzkaller-00159-g223e2288f4b8 #0 PREEMPT(full) 
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.2-debian-1.16.2-1 04/01/2014
Call Trace:
 <TASK>
 dump_stack_lvl+0x189/0x250
 print_deadlock_bug+0x28b/0x2a0
 validate_chain+0x1a3f/0x2140
 __lock_acquire+0xab9/0xd20
 lock_acquire+0x120/0x360
 __mutex_lock+0x182/0xe80
 __netdev_update_features+0xcb1/0x1a20
 netdev_update_features+0x6d/0xe0
 macsec_notify+0x2f5/0x660
 notifier_call_chain+0x1b6/0x3e0
 netdev_features_change+0x85/0xc0
 dev_ethtool+0x1520/0x1990
 dev_ioctl+0x392/0x1150
 sock_do_ioctl+0x22c/0x300
 sock_ioctl+0x576/0x790
 __se_sys_ioctl+0xfc/0x170
 do_syscall_64+0xfa/0x3b0
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f72a8b8e929
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f72a9a96038 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007f72a8db6080 RCX: 00007f72a8b8e929
RDX: 0000200000000080 RSI: 0000000000008946 RDI: 00000000000000a1
RBP: 00007f72a8c10b39 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f72a8db6080 R15: 00007fffdc449358
 </TASK>
