| Seq | Timestamp | Type | Name | Duration |
|---|---|---|---|---|
| 0/0 | 2026/07/30 21:43 | flow | patch-triage |
0mArgs:null Results: {
"EnableConfigs": null,
"FocusSymbols": [],
"Reasoning": "The patch only adds KUnit tests and Python selftests for DAMON filters and probes. It does not modify any functional kernel code.",
"WorthFuzzing": false
} |
| 1/1 | 2026/07/30 21:43 | action | read-patch-diff |
0mArgs:null Results: {
"PatchDiff": "commit a6d21fb9ecb937916a90ee192f68ac7192d1ab73\nAuthor: syz-cluster \u003ctriage@syzkaller.com\u003e\nDate: Thu Jul 30 21:43:34 2026 +0000\n\n syz-cluster: applied patch under review\n\ndiff --git a/mm/damon/tests/core-kunit.h b/mm/damon/tests/core-kunit.h\nindex 4a536d41cdb2d..6577410ace3da 100644\n--- a/mm/damon/tests/core-kunit.h\n+++ b/mm/damon/tests/core-kunit.h\n@@ -1306,6 +1306,125 @@ static void damon_test_commit_target_regions(struct kunit *test)\n \t\t\t(unsigned long[][2]) {{3, 8}, {8, 10}}, 2);\n }\n \n+static void damon_test_commit_filter_for(struct kunit *test,\n+\t\tstruct damon_filter *dst, struct damon_filter *src)\n+{\n+\tdamon_commit_filter(dst, src);\n+\tKUNIT_EXPECT_EQ(test, dst-\u003etype, src-\u003etype);\n+\tKUNIT_EXPECT_EQ(test, dst-\u003ematching, src-\u003ematching);\n+\tKUNIT_EXPECT_EQ(test, dst-\u003eallow, src-\u003eallow);\n+\tswitch (src-\u003etype) {\n+\tcase DAMOS_FILTER_TYPE_MEMCG:\n+\t\tKUNIT_EXPECT_EQ(test, dst-\u003ememcg_id, src-\u003ememcg_id);\n+\t\tbreak;\n+\tdefault:\n+\t\tbreak;\n+\t}\n+}\n+\n+static void damon_test_commit_filter(struct kunit *test)\n+{\n+\tstruct damon_filter dst = {\n+\t\t.type = DAMON_FILTER_TYPE_ANON,\n+\t\t.matching = false,\n+\t\t.allow = false,\n+\t};\n+\n+\tdamon_test_commit_filter_for(test, \u0026dst,\n+\t\t\t\u0026(struct damon_filter){\n+\t\t\t.type = DAMON_FILTER_TYPE_ANON,\n+\t\t\t.matching = true,\n+\t\t\t.allow = true,\n+\t\t\t});\n+\tdamon_test_commit_filter_for(test, \u0026dst,\n+\t\t\t\u0026(struct damon_filter){\n+\t\t\t.type = DAMON_FILTER_TYPE_MEMCG,\n+\t\t\t.matching = false,\n+\t\t\t.allow = false,\n+\t\t\t.memcg_id = 123,\n+\t\t\t});\n+}\n+\n+static struct damon_ctx *damon_test_help_setup_probes(unsigned int weights[],\n+\t\tint nr_weights)\n+{\n+\tstruct damon_ctx *ctx;\n+\tstruct damon_probe *probe;\n+\tint i;\n+\n+\tctx = damon_new_ctx();\n+\tif (!ctx)\n+\t\treturn NULL;\n+\tfor (i = 0; i \u003c nr_weights; i++) {\n+\t\tprobe = damon_new_probe();\n+\t\tif (!probe) {\n+\t\t\tdamon_destroy_ctx(ctx);\n+\t\t\treturn NULL;\n+\t\t}\n+\t\tprobe-\u003eweight = weights[i];\n+\t\tdamon_add_probe(ctx, probe);\n+\t}\n+\treturn ctx;\n+}\n+\n+static void damon_test_commit_probes_for(struct kunit *test,\n+\t\tunsigned int dst_weights[], int nr_dst_probes,\n+\t\tunsigned int src_weights[], int nr_src_probes)\n+{\n+\tstruct damon_ctx *dst, *src;\n+\tint err;\n+\tstruct damon_probe *dst_probe, *src_probe;\n+\n+\tdst = damon_test_help_setup_probes(dst_weights, nr_dst_probes);\n+\tif (!dst)\n+\t\tkunit_skip(test, \"dst alloc fail\");\n+\tsrc = damon_test_help_setup_probes(src_weights, nr_src_probes);\n+\tif (!src) {\n+\t\tdamon_destroy_ctx(dst);\n+\t\tkunit_skip(test, \"src alloc fail\");\n+\t}\n+\n+\terr = damon_commit_probes(dst, src);\n+\tKUNIT_EXPECT_EQ(test, err, 0);\n+\tif (err)\n+\t\treturn;\n+\tnr_dst_probes = 0;\n+\tdamon_for_each_probe(dst_probe, dst)\n+\t\tnr_dst_probes++;\n+\tnr_src_probes = 0;\n+\tdamon_for_each_probe(src_probe, src)\n+\t\tnr_src_probes++;\n+\tKUNIT_EXPECT_EQ(test, nr_dst_probes, nr_src_probes);\n+\tnr_dst_probes = 0;\n+\tdamon_for_each_probe(dst_probe, dst) {\n+\t\tsrc_probe = damon_nth_probe(nr_dst_probes, src);\n+\t\tKUNIT_EXPECT_EQ(test, src_probe-\u003eweight, dst_probe-\u003eweight);\n+\t\tnr_dst_probes++;\n+\t}\n+\tdamon_destroy_ctx(dst);\n+\tdamon_destroy_ctx(src);\n+}\n+\n+static void damon_test_commit_probes(struct kunit *test)\n+{\n+\tdamon_test_commit_probes_for(test,\n+\t\t\t(unsigned int[]){}, 0, (unsigned int[]){}, 0);\n+\tdamon_test_commit_probes_for(test,\n+\t\t\t(unsigned int[]){}, 0, (unsigned int[]){1}, 1);\n+\tdamon_test_commit_probes_for(test,\n+\t\t\t(unsigned int[]){}, 0, (unsigned int[]){1, 2}, 2);\n+\tdamon_test_commit_probes_for(test,\n+\t\t\t(unsigned int[]){1}, 1, (unsigned int[]){2}, 1);\n+\tdamon_test_commit_probes_for(test,\n+\t\t\t(unsigned int[]){1}, 1, (unsigned int[]){2, 3}, 2);\n+\tdamon_test_commit_probes_for(test,\n+\t\t\t(unsigned int[]){2, 3}, 2, (unsigned int[]){1}, 1);\n+\tdamon_test_commit_probes_for(test,\n+\t\t\t(unsigned int[]){2, 3}, 2, (unsigned int[]){}, 0);\n+\tdamon_test_commit_probes_for(test,\n+\t\t\t(unsigned int[]){2}, 1, (unsigned int[]){}, 0);\n+}\n+\n static void damon_test_commit_ctx(struct kunit *test)\n {\n \tstruct damon_ctx *src, *dst;\n@@ -1656,6 +1775,8 @@ static struct kunit_case damon_test_cases[] = {\n \tKUNIT_CASE(damos_test_commit_pageout),\n \tKUNIT_CASE(damos_test_commit_migrate_hot),\n \tKUNIT_CASE(damon_test_commit_target_regions),\n+\tKUNIT_CASE(damon_test_commit_filter),\n+\tKUNIT_CASE(damon_test_commit_probes),\n \tKUNIT_CASE(damon_test_commit_ctx),\n \tKUNIT_CASE(damos_test_filter_out),\n \tKUNIT_CASE(damon_test_feed_loop_next_input),\ndiff --git a/tools/testing/selftests/damon/_damon_sysfs.py b/tools/testing/selftests/damon/_damon_sysfs.py\nindex e6a2265d721e8..d6afb5b2f0a4a 100644\n--- a/tools/testing/selftests/damon/_damon_sysfs.py\n+++ b/tools/testing/selftests/damon/_damon_sysfs.py\n@@ -558,6 +558,115 @@ class IntervalsGoal:\n return err\n return None\n \n+class DamonFilter:\n+ type_ = None\n+ matching = None\n+ allow = None\n+ filters = None\n+ path = None\n+ idx = None\n+\n+ def __init__(self, type_='anon', matching=False, allow=False, path=None):\n+ self.type_ = type_\n+ self.matching = matching\n+ self.allow = allow\n+ self.path = path\n+\n+ def sysfs_dir(self):\n+ return os.path.join(self.filters.sysfs_dir(), '%d' % self.idx)\n+\n+ def stage(self):\n+ err = write_file(os.path.join(self.sysfs_dir(), 'type'), self.type_)\n+ if err is not None:\n+ return err\n+ err = write_file(os.path.join(self.sysfs_dir(), 'matching'),\n+ 'Y' if self.matching else 'N')\n+ if err is not None:\n+ return err\n+ err = write_file(os.path.join(self.sysfs_dir(), 'allow'),\n+ 'Y' if self.allow else 'N')\n+ if err is not None:\n+ return err\n+ if self.type_ == 'memcg':\n+ err = write_file(os.path.join(self.sysfs_dir(), 'path'), self.path)\n+ if err is not None:\n+ return err\n+ return None\n+\n+class DamonFilters:\n+ filters = None\n+ probe = None\n+\n+ def __init__(self, filters=None):\n+ if filters is None:\n+ filters = []\n+ self.filters = filters\n+ for idx, filter in enumerate(self.filters):\n+ filter.filters = self\n+ filter.idx = idx\n+\n+ def sysfs_dir(self):\n+ return os.path.join(self.probe.sysfs_dir(), 'filters')\n+\n+ def stage(self):\n+ err = write_file(\n+ os.path.join(self.sysfs_dir(), 'nr_filters'),\n+ len(self.filters))\n+ if err is not None:\n+ return err\n+ for filter in self.filters:\n+ err = filter.stage()\n+ if err is not None:\n+ return err\n+ return None\n+\n+class DamonProbe:\n+ weight = None\n+ filters = None\n+ probes = None\n+ idx = None\n+\n+ def __init__(self, weight=0, filters=None):\n+ self.weight = weight\n+ if filters is None:\n+ filters = DamonFilters()\n+ self.filters = filters\n+ self.filters.probe = self\n+\n+ def sysfs_dir(self):\n+ return os.path.join(self.probes.sysfs_dir(), '%d' % self.idx)\n+\n+ def stage(self):\n+ err = write_file(\n+ os.path.join(self.sysfs_dir(), 'weight'), '%d' % self.weight)\n+ return self.filters.stage()\n+\n+class DamonProbes:\n+ probes = None\n+ attrs = None\n+\n+ def __init__(self, probes=None):\n+ if probes is None:\n+ probes = []\n+ self.probes = probes\n+ for idx, probe in enumerate(self.probes):\n+ probe.probes = self\n+ probe.idx = idx\n+\n+ def sysfs_dir(self):\n+ return os.path.join(self.attrs.sysfs_dir(), 'probes')\n+\n+ def stage(self):\n+ err = write_file(os.path.join(self.sysfs_dir(), 'nr_probes'),\n+ len(self.probes))\n+ if err is not None:\n+ return err\n+ for probe in self.probes:\n+ err = probe.stage()\n+ if err is not None:\n+ return err\n+ return None\n+\n class DamonAttrs:\n sample_us = None\n aggr_us = None\n@@ -565,11 +674,12 @@ class DamonAttrs:\n update_us = None\n min_nr_regions = None\n max_nr_regions = None\n+ probes = None\n context = None\n \n def __init__(self, sample_us=5000, aggr_us=100000,\n intervals_goal=IntervalsGoal(), update_us=1000000,\n- min_nr_regions=10, max_nr_regions=1000):\n+ min_nr_regions=10, max_nr_regions=1000, probes=None):\n self.sample_us = sample_us\n self.aggr_us = aggr_us\n self.intervals_goal = intervals_goal\n@@ -577,6 +687,10 @@ class DamonAttrs:\n self.update_us = update_us\n self.min_nr_regions = min_nr_regions\n self.max_nr_regions = max_nr_regions\n+ if probes is None:\n+ probes = DamonProbes()\n+ self.probes = probes\n+ self.probes.attrs = self\n \n def interval_sysfs_dir(self):\n return os.path.join(self.context.sysfs_dir(), 'monitoring_attrs',\n@@ -586,6 +700,9 @@ class DamonAttrs:\n return os.path.join(self.context.sysfs_dir(), 'monitoring_attrs',\n 'nr_regions')\n \n+ def sysfs_dir(self):\n+ return os.path.join(self.context.sysfs_dir(), 'monitoring_attrs')\n+\n def stage(self):\n err = write_file(os.path.join(self.interval_sysfs_dir(), 'sample_us'),\n self.sample_us)\n@@ -615,6 +732,10 @@ class DamonAttrs:\n if err is not None:\n return err\n \n+ err = self.probes.stage()\n+ if err is not None:\n+ return err\n+\n class DamonCtx:\n ops = None\n monitoring_attrs = None\ndiff --git a/tools/testing/selftests/damon/drgn_dump_damon_status.py b/tools/testing/selftests/damon/drgn_dump_damon_status.py\nindex 09552e91bc782..4622046fd0118 100755\n--- a/tools/testing/selftests/damon/drgn_dump_damon_status.py\n+++ b/tools/testing/selftests/damon/drgn_dump_damon_status.py\n@@ -48,6 +48,37 @@ def attrs_to_dict(attrs):\n ['max_nr_regions', int],\n ])\n \n+def filter_to_dict(damon_filter):\n+ filter_type_keyword = {\n+ 0: 'anon',\n+ 1: 'memcg',\n+ }\n+ dict_ = {\n+ 'type': filter_type_keyword[int(damon_filter.type)],\n+ 'matching': bool(damon_filter.matching),\n+ 'allow': bool(damon_filter.allow),\n+ }\n+ type_ = dict_['type']\n+ if type_ == 'memcg':\n+ dict_['memcg_id'] = int(damon_filter.memcg_id)\n+ return dict_\n+\n+def filters_to_list(filters):\n+ return [filter_to_dict(f)\n+ for f in list_for_each_entry(\n+ 'struct damon_filter', filters.address_of_(), 'list')]\n+\n+def probe_to_dict(probe):\n+ return to_dict(probe, [\n+ ['weight', int],\n+ ['filters', filters_to_list],\n+ ])\n+\n+def probes_to_list(probes):\n+ return [probe_to_dict(p)\n+ for p in list_for_each_entry(\n+ 'struct damon_probe', probes.address_of_(), 'list')]\n+\n def addr_range_to_dict(addr_range):\n return to_dict(addr_range, [\n ['start', int],\n@@ -199,6 +230,7 @@ def damon_ctx_to_dict(ctx):\n return to_dict(ctx, [\n ['ops', ops_to_dict],\n ['attrs', attrs_to_dict],\n+ ['probes', probes_to_list],\n ['adaptive_targets', targets_to_list],\n ['schemes', schemes_to_list],\n ['pause', bool],\ndiff --git a/tools/testing/selftests/damon/sysfs.py b/tools/testing/selftests/damon/sysfs.py\nindex 3ffa054b63867..852b6887a75ce 100755\n--- a/tools/testing/selftests/damon/sysfs.py\n+++ b/tools/testing/selftests/damon/sysfs.py\n@@ -178,6 +178,24 @@ def assert_monitoring_attrs_committed(attrs, dump):\n assert_true(dump['max_nr_regions'] == attrs.max_nr_regions,\n 'max_nr_regions', dump)\n \n+def assert_damon_filters_committed(filters, dump):\n+ assert_true(len(dump) == len(filters.filters), 'probe filters', dump)\n+ for idx, damon_filter in enumerate(filters.filters):\n+ filter_dump = dump[idx]\n+ assert_true(filter_dump['type'] == damon_filter.type_, 'type',\n+ filter_dump)\n+ assert_true(filter_dump['matching'] == damon_filter.matching,\n+ 'matching', filter_dump)\n+ assert_true(filter_dump['allow'] == damon_filter.allow, 'allow',\n+ filter_dump)\n+\n+def assert_probes_committed(probes, dump):\n+ assert_true(len(dump) == len(probes.probes), 'probes length', dump)\n+ for idx, probe in enumerate(probes.probes):\n+ probe_dump = dump[idx]\n+ assert_true(probe.weight == probe_dump['weight'], 'weight', probe_dump)\n+ assert_damon_filters_committed(probe.filters, probe_dump['filters'])\n+\n def assert_monitoring_target_committed(target, dump):\n # target.pid is the pid \"number\", while dump['pid'] is 'struct pid'\n # pointer, and hence cannot be compared.\n@@ -196,6 +214,7 @@ def assert_ctx_committed(ctx, dump):\n }\n assert_true(dump['ops']['id'] == ops_val[ctx.ops], 'ops_id', dump)\n assert_monitoring_attrs_committed(ctx.monitoring_attrs, dump['attrs'])\n+ assert_probes_committed(ctx.monitoring_attrs.probes, dump['probes'])\n assert_monitoring_targets_committed(ctx.targets, dump['adaptive_targets'])\n assert_schemes_committed(ctx.schemes, dump['schemes'])\n assert_true(dump['pause'] == ctx.pause, 'pause', dump)\n@@ -300,7 +319,21 @@ def main():\n intervals_goal=_damon_sysfs.IntervalsGoal(\n access_bp=400, aggrs=3, min_sample_us=5000,\n max_sample_us=10000000),\n- update_us=2000000),\n+ update_us=2000000,\n+ probes=_damon_sysfs.DamonProbes(\n+ probes=[_damon_sysfs.DamonProbe(\n+ weight=42,\n+ filters=_damon_sysfs.DamonFilters(\n+ filters=[\n+ _damon_sysfs.DamonFilter(\n+ type_='anon',\n+ matching=True,\n+ allow=True,\n+ ),\n+ ]),\n+ ),\n+ ]),\n+ ),\n schemes=[_damon_sysfs.Damos(\n action='pageout',\n access_pattern=_damon_sysfs.DamosAccessPattern(\n"
} |
| 2/1 | 2026/07/30 21:43 | agent | patch-evaluator |
0mModel:best-expensive Args: null Results: {
"EnableConfigs": null,
"FocusSymbols": [],
"Reasoning": "The patch only adds KUnit tests and Python selftests for DAMON filters and probes. It does not modify any functional kernel code.",
"WorthFuzzing": false
}Instruction: You are an expert Linux kernel maintainer. Your job is to review a provided patch series and determine if it makes functional changes to the kernel that should be fuzzed. IMPORTANT: The changes have ALREADY been applied and committed as the HEAD commit in your workspace. Do NOT rely on your internal knowledge of the kernel. You must actively use your code access tools to examine the actual source code and confirm any assumptions. Return WorthFuzzing=false if the patch only contains: - Modifications to Documentation/, Kconfig files, or code comments. - Purely decorative changes, such as logging (e.g., pr_err, printk) or tracepoints. - Changes to numeric constants or macros that do not functionally alter execution flow. - Code paths that are impossible to reach in virtualized environments like GCE or QEMU, even when utilizing software-emulated hardware (e.g., usb gadget, mac80211_hwsim). - Code in vendor-specific PCIe switch, SmartNIC, or GPU drivers (e.g., mlxsw, pds_core, qed, ionic, amdgpu) that require physical PCIe hardware cards not emulated in standard QEMU. - Driver .remove, .shutdown, or pci_unregister_driver teardown callbacks (e.g., igb_remove) that are executed only during PCI hot-unplug or sysfs driver unbind operations. If it modifies reachable core kernel logic, drivers, or architectures, use your code search tools to verify the code can be executed, then return WorthFuzzing=true. When returning WorthFuzzing=true, you MUST ALSO: 1. Extract any specific kernel functions that should be heavily fuzzed into FocusSymbols. Avoid listing generic hot-path functions to prevent skewed test distributions. Prefer non-static, non-inlined API entrypoint functions over internal static helper functions (which are inlined by the compiler and do not have distinct symbol addresses). 2. Identify any specific CONFIG_ options required to properly test this new/modified feature. Go and look into the Kconfig files and check for ifdefs around the code, do not make assumptions. Also check "depends on" lines in Kconfig to include any non-standard parent subsystem configs needed for Kbuild to compile the code statically into vmlinux. List them in the EnableConfigs output array, and DO NOT add a 'CONFIG_' prefix (e.g., return "NET_IPV4" instead of "CONFIG_NET_IPV4"). Prefer calling several tools at the same time to save round-trips. Use set-results tool to provide results of the analysis. It must be called exactly once before the final reply. Ignore results of this tool. Prompt: For your convenience, here is the diff of the changes:
commit a6d21fb9ecb937916a90ee192f68ac7192d1ab73
Author: syz-cluster <triage@syzkaller.com>
Date: Thu Jul 30 21:43:34 2026 +0000
syz-cluster: applied patch under review
diff --git a/mm/damon/tests/core-kunit.h b/mm/damon/tests/core-kunit.h
index 4a536d41cdb2d..6577410ace3da 100644
--- a/mm/damon/tests/core-kunit.h
+++ b/mm/damon/tests/core-kunit.h
@@ -1306,6 +1306,125 @@ static void damon_test_commit_target_regions(struct kunit *test)
(unsigned long[][2]) {{3, 8}, {8, 10}}, 2);
}
+static void damon_test_commit_filter_for(struct kunit *test,
+ struct damon_filter *dst, struct damon_filter *src)
+{
+ damon_commit_filter(dst, src);
+ KUNIT_EXPECT_EQ(test, dst->type, src->type);
+ KUNIT_EXPECT_EQ(test, dst->matching, src->matching);
+ KUNIT_EXPECT_EQ(test, dst->allow, src->allow);
+ switch (src->type) {
+ case DAMOS_FILTER_TYPE_MEMCG:
+ KUNIT_EXPECT_EQ(test, dst->memcg_id, src->memcg_id);
+ break;
+ default:
+ break;
+ }
+}
+
+static void damon_test_commit_filter(struct kunit *test)
+{
+ struct damon_filter dst = {
+ .type = DAMON_FILTER_TYPE_ANON,
+ .matching = false,
+ .allow = false,
+ };
+
+ damon_test_commit_filter_for(test, &dst,
+ &(struct damon_filter){
+ .type = DAMON_FILTER_TYPE_ANON,
+ .matching = true,
+ .allow = true,
+ });
+ damon_test_commit_filter_for(test, &dst,
+ &(struct damon_filter){
+ .type = DAMON_FILTER_TYPE_MEMCG,
+ .matching = false,
+ .allow = false,
+ .memcg_id = 123,
+ });
+}
+
+static struct damon_ctx *damon_test_help_setup_probes(unsigned int weights[],
+ int nr_weights)
+{
+ struct damon_ctx *ctx;
+ struct damon_probe *probe;
+ int i;
+
+ ctx = damon_new_ctx();
+ if (!ctx)
+ return NULL;
+ for (i = 0; i < nr_weights; i++) {
+ probe = damon_new_probe();
+ if (!probe) {
+ damon_destroy_ctx(ctx);
+ return NULL;
+ }
+ probe->weight = weights[i];
+ damon_add_probe(ctx, probe);
+ }
+ return ctx;
+}
+
+static void damon_test_commit_probes_for(struct kunit *test,
+ unsigned int dst_weights[], int nr_dst_probes,
+ unsigned int src_weights[], int nr_src_probes)
+{
+ struct damon_ctx *dst, *src;
+ int err;
+ struct damon_probe *dst_probe, *src_probe;
+
+ dst = damon_test_help_setup_probes(dst_weights, nr_dst_probes);
+ if (!dst)
+ kunit_skip(test, "dst alloc fail");
+ src = damon_test_help_setup_probes(src_weights, nr_src_probes);
+ if (!src) {
+ damon_destroy_ctx(dst);
+ kunit_skip(test, "src alloc fail");
+ }
+
+ err = damon_commit_probes(dst, src);
+ KUNIT_EXPECT_EQ(test, err, 0);
+ if (err)
+ return;
+ nr_dst_probes = 0;
+ damon_for_each_probe(dst_probe, dst)
+ nr_dst_probes++;
+ nr_src_probes = 0;
+ damon_for_each_probe(src_probe, src)
+ nr_src_probes++;
+ KUNIT_EXPECT_EQ(test, nr_dst_probes, nr_src_probes);
+ nr_dst_probes = 0;
+ damon_for_each_probe(dst_probe, dst) {
+ src_probe = damon_nth_probe(nr_dst_probes, src);
+ KUNIT_EXPECT_EQ(test, src_probe->weight, dst_probe->weight);
+ nr_dst_probes++;
+ }
+ damon_destroy_ctx(dst);
+ damon_destroy_ctx(src);
+}
+
+static void damon_test_commit_probes(struct kunit *test)
+{
+ damon_test_commit_probes_for(test,
+ (unsigned int[]){}, 0, (unsigned int[]){}, 0);
+ damon_test_commit_probes_for(test,
+ (unsigned int[]){}, 0, (unsigned int[]){1}, 1);
+ damon_test_commit_probes_for(test,
+ (unsigned int[]){}, 0, (unsigned int[]){1, 2}, 2);
+ damon_test_commit_probes_for(test,
+ (unsigned int[]){1}, 1, (unsigned int[]){2}, 1);
+ damon_test_commit_probes_for(test,
+ (unsigned int[]){1}, 1, (unsigned int[]){2, 3}, 2);
+ damon_test_commit_probes_for(test,
+ (unsigned int[]){2, 3}, 2, (unsigned int[]){1}, 1);
+ damon_test_commit_probes_for(test,
+ (unsigned int[]){2, 3}, 2, (unsigned int[]){}, 0);
+ damon_test_commit_probes_for(test,
+ (unsigned int[]){2}, 1, (unsigned int[]){}, 0);
+}
+
static void damon_test_commit_ctx(struct kunit *test)
{
struct damon_ctx *src, *dst;
@@ -1656,6 +1775,8 @@ static struct kunit_case damon_test_cases[] = {
KUNIT_CASE(damos_test_commit_pageout),
KUNIT_CASE(damos_test_commit_migrate_hot),
KUNIT_CASE(damon_test_commit_target_regions),
+ KUNIT_CASE(damon_test_commit_filter),
+ KUNIT_CASE(damon_test_commit_probes),
KUNIT_CASE(damon_test_commit_ctx),
KUNIT_CASE(damos_test_filter_out),
KUNIT_CASE(damon_test_feed_loop_next_input),
diff --git a/tools/testing/selftests/damon/_damon_sysfs.py b/tools/testing/selftests/damon/_damon_sysfs.py
index e6a2265d721e8..d6afb5b2f0a4a 100644
--- a/tools/testing/selftests/damon/_damon_sysfs.py
+++ b/tools/testing/selftests/damon/_damon_sysfs.py
@@ -558,6 +558,115 @@ class IntervalsGoal:
return err
return None
+class DamonFilter:
+ type_ = None
+ matching = None
+ allow = None
+ filters = None
+ path = None
+ idx = None
+
+ def __init__(self, type_='anon', matching=False, allow=False, path=None):
+ self.type_ = type_
+ self.matching = matching
+ self.allow = allow
+ self.path = path
+
+ def sysfs_dir(self):
+ return os.path.join(self.filters.sysfs_dir(), '%d' % self.idx)
+
+ def stage(self):
+ err = write_file(os.path.join(self.sysfs_dir(), 'type'), self.type_)
+ if err is not None:
+ return err
+ err = write_file(os.path.join(self.sysfs_dir(), 'matching'),
+ 'Y' if self.matching else 'N')
+ if err is not None:
+ return err
+ err = write_file(os.path.join(self.sysfs_dir(), 'allow'),
+ 'Y' if self.allow else 'N')
+ if err is not None:
+ return err
+ if self.type_ == 'memcg':
+ err = write_file(os.path.join(self.sysfs_dir(), 'path'), self.path)
+ if err is not None:
+ return err
+ return None
+
+class DamonFilters:
+ filters = None
+ probe = None
+
+ def __init__(self, filters=None):
+ if filters is None:
+ filters = []
+ self.filters = filters
+ for idx, filter in enumerate(self.filters):
+ filter.filters = self
+ filter.idx = idx
+
+ def sysfs_dir(self):
+ return os.path.join(self.probe.sysfs_dir(), 'filters')
+
+ def stage(self):
+ err = write_file(
+ os.path.join(self.sysfs_dir(), 'nr_filters'),
+ len(self.filters))
+ if err is not None:
+ return err
+ for filter in self.filters:
+ err = filter.stage()
+ if err is not None:
+ return err
+ return None
+
+class DamonProbe:
+ weight = None
+ filters = None
+ probes = None
+ idx = None
+
+ def __init__(self, weight=0, filters=None):
+ self.weight = weight
+ if filters is None:
+ filters = DamonFilters()
+ self.filters = filters
+ self.filters.probe = self
+
+ def sysfs_dir(self):
+ return os.path.join(self.probes.sysfs_dir(), '%d' % self.idx)
+
+ def stage(self):
+ err = write_file(
+ os.path.join(self.sysfs_dir(), 'weight'), '%d' % self.weight)
+ return self.filters.stage()
+
+class DamonProbes:
+ probes = None
+ attrs = None
+
+ def __init__(self, probes=None):
+ if probes is None:
+ probes = []
+ self.probes = probes
+ for idx, probe in enumerate(self.probes):
+ probe.probes = self
+ probe.idx = idx
+
+ def sysfs_dir(self):
+ return os.path.join(self.attrs.sysfs_dir(), 'probes')
+
+ def stage(self):
+ err = write_file(os.path.join(self.sysfs_dir(), 'nr_probes'),
+ len(self.probes))
+ if err is not None:
+ return err
+ for probe in self.probes:
+ err = probe.stage()
+ if err is not None:
+ return err
+ return None
+
class DamonAttrs:
sample_us = None
aggr_us = None
@@ -565,11 +674,12 @@ class DamonAttrs:
update_us = None
min_nr_regions = None
max_nr_regions = None
+ probes = None
context = None
def __init__(self, sample_us=5000, aggr_us=100000,
intervals_goal=IntervalsGoal(), update_us=1000000,
- min_nr_regions=10, max_nr_regions=1000):
+ min_nr_regions=10, max_nr_regions=1000, probes=None):
self.sample_us = sample_us
self.aggr_us = aggr_us
self.intervals_goal = intervals_goal
@@ -577,6 +687,10 @@ class DamonAttrs:
self.update_us = update_us
self.min_nr_regions = min_nr_regions
self.max_nr_regions = max_nr_regions
+ if probes is None:
+ probes = DamonProbes()
+ self.probes = probes
+ self.probes.attrs = self
def interval_sysfs_dir(self):
return os.path.join(self.context.sysfs_dir(), 'monitoring_attrs',
@@ -586,6 +700,9 @@ class DamonAttrs:
return os.path.join(self.context.sysfs_dir(), 'monitoring_attrs',
'nr_regions')
+ def sysfs_dir(self):
+ return os.path.join(self.context.sysfs_dir(), 'monitoring_attrs')
+
def stage(self):
err = write_file(os.path.join(self.interval_sysfs_dir(), 'sample_us'),
self.sample_us)
@@ -615,6 +732,10 @@ class DamonAttrs:
if err is not None:
return err
+ err = self.probes.stage()
+ if err is not None:
+ return err
+
class DamonCtx:
ops = None
monitoring_attrs = None
diff --git a/tools/testing/selftests/damon/drgn_dump_damon_status.py b/tools/testing/selftests/damon/drgn_dump_damon_status.py
index 09552e91bc782..4622046fd0118 100755
--- a/tools/testing/selftests/damon/drgn_dump_damon_status.py
+++ b/tools/testing/selftests/damon/drgn_dump_damon_status.py
@@ -48,6 +48,37 @@ def attrs_to_dict(attrs):
['max_nr_regions', int],
])
+def filter_to_dict(damon_filter):
+ filter_type_keyword = {
+ 0: 'anon',
+ 1: 'memcg',
+ }
+ dict_ = {
+ 'type': filter_type_keyword[int(damon_filter.type)],
+ 'matching': bool(damon_filter.matching),
+ 'allow': bool(damon_filter.allow),
+ }
+ type_ = dict_['type']
+ if type_ == 'memcg':
+ dict_['memcg_id'] = int(damon_filter.memcg_id)
+ return dict_
+
+def filters_to_list(filters):
+ return [filter_to_dict(f)
+ for f in list_for_each_entry(
+ 'struct damon_filter', filters.address_of_(), 'list')]
+
+def probe_to_dict(probe):
+ return to_dict(probe, [
+ ['weight', int],
+ ['filters', filters_to_list],
+ ])
+
+def probes_to_list(probes):
+ return [probe_to_dict(p)
+ for p in list_for_each_entry(
+ 'struct damon_probe', probes.address_of_(), 'list')]
+
def addr_range_to_dict(addr_range):
return to_dict(addr_range, [
['start', int],
@@ -199,6 +230,7 @@ def damon_ctx_to_dict(ctx):
return to_dict(ctx, [
['ops', ops_to_dict],
['attrs', attrs_to_dict],
+ ['probes', probes_to_list],
['adaptive_targets', targets_to_list],
['schemes', schemes_to_list],
['pause', bool],
diff --git a/tools/testing/selftests/damon/sysfs.py b/tools/testing/selftests/damon/sysfs.py
index 3ffa054b63867..852b6887a75ce 100755
--- a/tools/testing/selftests/damon/sysfs.py
+++ b/tools/testing/selftests/damon/sysfs.py
@@ -178,6 +178,24 @@ def assert_monitoring_attrs_committed(attrs, dump):
assert_true(dump['max_nr_regions'] == attrs.max_nr_regions,
'max_nr_regions', dump)
+def assert_damon_filters_committed(filters, dump):
+ assert_true(len(dump) == len(filters.filters), 'probe filters', dump)
+ for idx, damon_filter in enumerate(filters.filters):
+ filter_dump = dump[idx]
+ assert_true(filter_dump['type'] == damon_filter.type_, 'type',
+ filter_dump)
+ assert_true(filter_dump['matching'] == damon_filter.matching,
+ 'matching', filter_dump)
+ assert_true(filter_dump['allow'] == damon_filter.allow, 'allow',
+ filter_dump)
+
+def assert_probes_committed(probes, dump):
+ assert_true(len(dump) == len(probes.probes), 'probes length', dump)
+ for idx, probe in enumerate(probes.probes):
+ probe_dump = dump[idx]
+ assert_true(probe.weight == probe_dump['weight'], 'weight', probe_dump)
+ assert_damon_filters_committed(probe.filters, probe_dump['filters'])
+
def assert_monitoring_target_committed(target, dump):
# target.pid is the pid "number", while dump['pid'] is 'struct pid'
# pointer, and hence cannot be compared.
@@ -196,6 +214,7 @@ def assert_ctx_committed(ctx, dump):
}
assert_true(dump['ops']['id'] == ops_val[ctx.ops], 'ops_id', dump)
assert_monitoring_attrs_committed(ctx.monitoring_attrs, dump['attrs'])
+ assert_probes_committed(ctx.monitoring_attrs.probes, dump['probes'])
assert_monitoring_targets_committed(ctx.targets, dump['adaptive_targets'])
assert_schemes_committed(ctx.schemes, dump['schemes'])
assert_true(dump['pause'] == ctx.pause, 'pause', dump)
@@ -300,7 +319,21 @@ def main():
intervals_goal=_damon_sysfs.IntervalsGoal(
access_bp=400, aggrs=3, min_sample_us=5000,
max_sample_us=10000000),
- update_us=2000000),
+ update_us=2000000,
+ probes=_damon_sysfs.DamonProbes(
+ probes=[_damon_sysfs.DamonProbe(
+ weight=42,
+ filters=_damon_sysfs.DamonFilters(
+ filters=[
+ _damon_sysfs.DamonFilter(
+ type_='anon',
+ matching=True,
+ allow=True,
+ ),
+ ]),
+ ),
+ ]),
+ ),
schemes=[_damon_sysfs.Damos(
action='pageout',
access_pattern=_damon_sysfs.DamosAccessPattern(
|
| 3/2 | 2026/07/30 21:43 | llm | patch-evaluator |
0mModel:gemini-3.1-pro-preview Args: null Results: null Tokens: input: 6945 output: 59 thoughts: 813 Thoughts: **Patch Analysis: DAMON Test Suite Additions** Okay, so I've got this patch series in front of me, and my initial thought is: does this introduce any *functional* changes to the kernel that we need to consider for fuzzing? Let's see... it seems like it's touching `mm/damon/tests/core-kunit.h` and some files under `tools/testing/selftests/damon/`, specifically python scripts: `_damon_sysfs.py`, `drgn_dump_damon_status.py`, and `sysfs.py`. Right away, that raises a flag – if it's test code, we might be in the clear. But I need to be *absolutely* sure. Let me confirm that this is *all* the patch modifies. Double-checking... yup, that's it. Just KUnit tests and selftests. No core kernel logic, no drivers, no architecture-specific code has been touched. It's *purely* test infrastructure. Okay, I’m confirming that again... Alright, now to apply the rules. Am I missing anything, it seems like the rule states: "Return WorthFuzzing=false if the patch only contains: ... " and "If it modifies reachable core kernel logic, drivers, or architectures, use your code search tools to verify the code can be executed, then return WorthFuzzing=true." It's tempting to categorize this as "decorative changes" because, in a way, tests don't *directly* alter execution flow of the kernel, but there's no specific bullet for tests. However, tests don't modify reachable core kernel logic, drivers, or architectures. The changes are confined to the test harness. So, according to the rule set, since it only contains tests I will return `WorthFuzzing=false`. Time to call set-results. |
| 4/2 | 2026/07/30 21:43 | tool | set-results |
0mArgs:{
"EnableConfigs": [],
"FocusSymbols": [],
"Reasoning": "The patch only adds KUnit tests and Python selftests for DAMON filters and probes. It does not modify any functional kernel code.",
"WorthFuzzing": false
}Results: {
"EnableConfigs": null,
"FocusSymbols": [],
"Reasoning": "The patch only adds KUnit tests and Python selftests for DAMON filters and probes. It does not modify any functional kernel code.",
"WorthFuzzing": false
} |
| Total Calls | Total Tokens | Avg Tokens | Total Duration (Seconds) | Avg Duration (Seconds) |
|---|
| Total Calls | Total Duration (Seconds) | Avg Duration (Seconds) |
|---|