overlayfs: upper fs does not support RENAME_WHITEOUT.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.7.1356/22504 is trying to acquire lock:
ffff88801cee26c0 (&ocfs2_sysfile_lock_key[EXTENT_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_reserve_suballoc_bits+0x164/0x4600

but task is already holding lock:
ffff88801cd65df8 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_xattr_set+0x40f/0x11f0

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&oi->ip_xattr_sem){++++}-{4:4}:
       down_read+0x47/0x2e0
       ocfs2_init_acl+0x2f7/0x7a0
       ocfs2_mknod+0x12ff/0x2030
       ocfs2_create+0x195/0x420
       path_openat+0x18bb/0x3dd0
       do_filp_open+0x1fa/0x410
       do_sys_openat2+0x121/0x200
       __x64_sys_openat+0x138/0x170
       do_syscall_64+0xfa/0xf80
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (&journal->j_trans_barrier){.+.+}-{4:4}:
       down_read+0x47/0x2e0
       ocfs2_start_trans+0x36a/0x6d0
       ocfs2_mknod+0xe71/0x2030
       ocfs2_create+0x195/0x420
       path_openat+0x18bb/0x3dd0
       do_filp_open+0x1fa/0x410
       do_sys_openat2+0x121/0x200
       __x64_sys_openat+0x138/0x170
       do_syscall_64+0xfa/0xf80
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (sb_internal#4){.+.+}-{0:0}:
       ocfs2_start_trans+0x26b/0x6d0
       ocfs2_create_refcount_tree+0x339/0x1240
       ocfs2_reflink_remap_blocks+0x2ea/0x1930
       ocfs2_remap_file_range+0x4b7/0x730
       vfs_clone_file_range+0x42c/0x7a0
       do_vfs_ioctl+0xd2b/0x1430
       __se_sys_ioctl+0x82/0x170
       do_syscall_64+0xfa/0xf80
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&ocfs2_sysfile_lock_key[EXTENT_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}:
       __lock_acquire+0x15a6/0x2cf0
       lock_acquire+0x117/0x340
       down_write+0x96/0x1f0
       ocfs2_reserve_suballoc_bits+0x164/0x4600
       ocfs2_reserve_new_metadata_blocks+0x403/0x940
       ocfs2_init_xattr_set_ctxt+0x2f7/0x6e0
       ocfs2_xattr_set+0xb70/0x11f0
       __vfs_setxattr+0x43c/0x480
       __vfs_setxattr_noperm+0x12d/0x660
       vfs_setxattr+0x16b/0x2f0
       ovl_fill_super+0x4781/0x5a90
       get_tree_nodev+0xbb/0x150
       vfs_get_tree+0x92/0x2a0
       do_new_mount+0x302/0xa10
       __se_sys_mount+0x313/0x410
       do_syscall_64+0xfa/0xf80
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[EXTENT_ALLOC_SYSTEM_INODE] --> &journal->j_trans_barrier --> &oi->ip_xattr_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_xattr_sem);
                               lock(&journal->j_trans_barrier);
                               lock(&oi->ip_xattr_sem);
  lock(&ocfs2_sysfile_lock_key[EXTENT_ALLOC_SYSTEM_INODE]);

 *** DEADLOCK ***

4 locks held by syz.7.1356/22504:
 #0: ffff88811370a0e0 (&type->s_umount_key#65/1){+.+.}-{4:4}, at: alloc_super+0x28c/0xaa0
 #1: ffff8881b94c2420 (sb_writers#17){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90
 #2: ffff88801cd660c0 (&sb->s_type->i_mutex_key#30){++++}-{4:4}, at: vfs_setxattr+0x144/0x2f0
 #3: ffff88801cd65df8 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_xattr_set+0x40f/0x11f0

stack backtrace:
CPU: 0 UID: 0 PID: 22504 Comm: syz.7.1356 Not tainted syzkaller #0 PREEMPT(full) 
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.2-debian-1.16.2-1 04/01/2014
Call Trace:
 <TASK>
 dump_stack_lvl+0x189/0x250
 print_circular_bug+0x2e2/0x300
 check_noncircular+0x12e/0x150
 __lock_acquire+0x15a6/0x2cf0
 lock_acquire+0x117/0x340
 down_write+0x96/0x1f0
 ocfs2_reserve_suballoc_bits+0x164/0x4600
 ocfs2_reserve_new_metadata_blocks+0x403/0x940
 ocfs2_init_xattr_set_ctxt+0x2f7/0x6e0
 ocfs2_xattr_set+0xb70/0x11f0
 __vfs_setxattr+0x43c/0x480
 __vfs_setxattr_noperm+0x12d/0x660
 vfs_setxattr+0x16b/0x2f0
 ovl_fill_super+0x4781/0x5a90
 get_tree_nodev+0xbb/0x150
 vfs_get_tree+0x92/0x2a0
 do_new_mount+0x302/0xa10
 __se_sys_mount+0x313/0x410
 do_syscall_64+0xfa/0xf80
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7fb39638f7c9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fb3972dd038 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007fb3965e5fa0 RCX: 00007fb39638f7c9
RDX: 0000200000000b80 RSI: 0000200000000000 RDI: 0000000000000000
RBP: 00007fb3963f297f R08: 0000200000000180 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007fb3965e6038 R14: 00007fb3965e5fa0 R15: 00007ffc499a6378
 </TASK>
OCFS2: ERROR (device loop7): int ocfs2_validate_gd_self(struct super_block *, struct buffer_head *, int): Group descriptor #20 has bad signature 
On-disk corruption discovered. Please run fsck.ocfs2 once the filesystem is unmounted.
OCFS2: File system is now read-only.
(syz.7.1356,22504,0):ocfs2_search_chain:1817 ERROR: status = -30
(syz.7.1356,22504,0):ocfs2_search_chain:1940 ERROR: status = -30
(syz.7.1356,22504,0):ocfs2_claim_suballoc_bits:2010 ERROR: status = -30
(syz.7.1356,22504,0):ocfs2_claim_suballoc_bits:2063 ERROR: status = -30
(syz.7.1356,22504,0):ocfs2_claim_metadata:2088 ERROR: status = -30
(syz.7.1356,22504,0):ocfs2_claim_metadata:2101 ERROR: status = -30
(syz.7.1356,22504,0):ocfs2_create_xattr_block:2887 ERROR: status = -30
(syz.7.1356,22504,0):ocfs2_xattr_block_set:2968 ERROR: status = -30
overlayfs: failed to set xattr on upper
overlayfs: ...falling back to redirect_dir=nofollow.
overlayfs: ...falling back to index=off.
overlayfs: ...falling back to uuid=null.
overlayfs: upper fs missing required features.
(syz.7.1356,22504,0):ocfs2_check_set_options:1244 ERROR: Invalid heartbeat mount options
No source specified
