| Seq | Timestamp | Type | Name | Duration |
|---|---|---|---|---|
| 0/0 | 2026/10/15 07:44 | flow | patch-triage |
0mArgs:null Results: {
"EnableConfigs": null,
"FocusSymbols": [],
"KMSANReasoning": "",
"NeedsKMSAN": false,
"Reasoning": "The patch series adds support for the ASPEED AST2700 SoC to the Faraday FTGMAC100 Ethernet driver, updating DeviceTree bindings, Kconfig, and the driver logic for 35-bit DMA and RMII enable. The FTGMAC100 driver is an SoC platform driver for ARM/ARM64 ASPEED and Faraday architectures that probes via Device Tree. On the target amd64 architecture, this hardware is not present or emulated, making the modified code structurally unreachable.",
"WorthFuzzing": false
} |
| 1/1 | 2026/10/15 07:44 | action | read-patch-diff |
0mArgs:null Results: {
"PatchDiff": "commit 261820ad172cf1456fa1b62ac6549140231e058f\nAuthor: syz-cluster \u003ctriage@syzkaller.com\u003e\nDate: Thu Oct 15 07:44:04 2026 +0000\n\n syz-cluster: applied patch under review\n\ndiff --git a/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml b/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml\nindex d14410018bcf6..0a376b849a916 100644\n--- a/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml\n+++ b/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml\n@@ -13,12 +13,11 @@ properties:\n compatible:\n oneOf:\n - const: faraday,ftgmac100\n- - items:\n- - enum:\n- - aspeed,ast2400-mac\n- - aspeed,ast2500-mac\n- - aspeed,ast2600-mac\n- - const: faraday,ftgmac100\n+ - enum:\n+ - aspeed,ast2400-mac\n+ - aspeed,ast2500-mac\n+ - aspeed,ast2600-mac\n+ - aspeed,ast2700-mac\n \n reg:\n maxItems: 1\n@@ -30,7 +29,7 @@ properties:\n minItems: 1\n items:\n - description: MAC IP clock\n- - description: RMII RCLK gate for AST2500/2600\n+ - description: RMII RCLK gate for AST2500/2600/2700\n \n resets:\n maxItems: 1\n@@ -82,26 +81,35 @@ allOf:\n contains:\n enum:\n - aspeed,ast2600-mac\n+ - aspeed,ast2700-mac\n then:\n properties:\n resets: true\n else:\n properties:\n resets: false\n+ - if:\n+ properties:\n+ compatible:\n+ contains:\n+ const: aspeed,ast2700-mac\n+ then:\n+ required:\n+ - phy-mode\n \n unevaluatedProperties: false\n \n examples:\n - |\n ethernet@1e660000 {\n- compatible = \"aspeed,ast2500-mac\", \"faraday,ftgmac100\";\n+ compatible = \"aspeed,ast2500-mac\";\n reg = \u003c0x1e660000 0x180\u003e;\n interrupts = \u003c2\u003e;\n use-ncsi;\n };\n \n ethernet@1e680000 {\n- compatible = \"aspeed,ast2500-mac\", \"faraday,ftgmac100\";\n+ compatible = \"aspeed,ast2500-mac\";\n reg = \u003c0x1e680000 0x180\u003e;\n interrupts = \u003c2\u003e;\n \ndiff --git a/drivers/net/ethernet/faraday/Kconfig b/drivers/net/ethernet/faraday/Kconfig\nindex 474073c7f94d7..9acc2d260c1f9 100644\n--- a/drivers/net/ethernet/faraday/Kconfig\n+++ b/drivers/net/ethernet/faraday/Kconfig\n@@ -6,7 +6,7 @@\n config NET_VENDOR_FARADAY\n \tbool \"Faraday devices\"\n \tdefault y\n-\tdepends on ARM || COMPILE_TEST\n+\tdepends on ARM || ARM64 || COMPILE_TEST\n \thelp\n \t If you have a network (Ethernet) card belonging to this class, say Y.\n \n@@ -28,11 +28,10 @@ config FTMAC100\n \n config FTGMAC100\n \ttristate \"Faraday FTGMAC100 Gigabit Ethernet support\"\n-\tdepends on ARM || COMPILE_TEST\n-\tdepends on !64BIT || BROKEN\n+\tdepends on ARM || ARM64 || COMPILE_TEST\n \tselect PHYLIB\n \tselect FIXED_PHY\n-\tselect MDIO_ASPEED if MACH_ASPEED_G6\n+\tselect MDIO_ASPEED if ARCH_ASPEED\n \tselect CRC32\n \thelp\n \t This driver supports the FTGMAC100 Gigabit Ethernet controller\ndiff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c\nindex 6d2fe5c2f3903..263594de0e072 100644\n--- a/drivers/net/ethernet/faraday/ftgmac100.c\n+++ b/drivers/net/ethernet/faraday/ftgmac100.c\n@@ -8,6 +8,7 @@\n \n #define pr_fmt(fmt)\tKBUILD_MODNAME \": \" fmt\n \n+#include \u003clinux/bitfield.h\u003e\n #include \u003clinux/clk.h\u003e\n #include \u003clinux/reset.h\u003e\n #include \u003clinux/dma-mapping.h\u003e\n@@ -37,11 +38,16 @@ enum ftgmac100_mac_id {\n \tFTGMAC100_FARADAY = 1,\n \tFTGMAC100_AST2400,\n \tFTGMAC100_AST2500,\n-\tFTGMAC100_AST2600\n+\tFTGMAC100_AST2600,\n+\tFTGMAC100_AST2700\n };\n \n+#define FTGMAC100_QUIRK_RMII_ENABLE\tBIT(0)\n+#define FTGMAC100_QUIRK_DMA_35BIT\tBIT(1)\n+\n struct ftgmac100_match_data {\n \tenum ftgmac100_mac_id mac_id;\n+\tu32 quirks;\n };\n \n /* Arbitrary values, I am not sure the HW has limits */\n@@ -78,6 +84,7 @@ struct ftgmac100 {\n \tvoid __iomem *base;\n \n \tenum ftgmac100_mac_id mac_id;\n+\tu32 quirks;\n \n \t/* Rx ring */\n \tunsigned int rx_q_entries;\n@@ -298,10 +305,16 @@ static void ftgmac100_init_hw(struct ftgmac100 *priv)\n \tiowrite32(reg, priv-\u003ebase + FTGMAC100_OFFSET_ISR);\n \n \t/* Setup RX ring buffer base */\n-\tiowrite32(priv-\u003erxdes_dma, priv-\u003ebase + FTGMAC100_OFFSET_RXR_BADR);\n+\tiowrite32(lower_32_bits(priv-\u003erxdes_dma), priv-\u003ebase + FTGMAC100_OFFSET_RXR_BADR);\n+\tif (priv-\u003equirks \u0026 FTGMAC100_QUIRK_DMA_35BIT)\n+\t\tiowrite32(upper_32_bits(priv-\u003erxdes_dma),\n+\t\t\t priv-\u003ebase + FTGMAC100_OFFSET_RXR_BADDR_HIGH);\n \n \t/* Setup TX ring buffer base */\n-\tiowrite32(priv-\u003etxdes_dma, priv-\u003ebase + FTGMAC100_OFFSET_NPTXR_BADR);\n+\tiowrite32(lower_32_bits(priv-\u003etxdes_dma), priv-\u003ebase + FTGMAC100_OFFSET_NPTXR_BADR);\n+\tif (priv-\u003equirks \u0026 FTGMAC100_QUIRK_DMA_35BIT)\n+\t\tiowrite32(upper_32_bits(priv-\u003etxdes_dma),\n+\t\t\t priv-\u003ebase + FTGMAC100_OFFSET_TXR_BADDR_HIGH);\n \n \t/* Configure RX buffer size */\n \tiowrite32(FTGMAC100_RBSR_SIZE(RX_BUF_SIZE),\n@@ -354,6 +367,12 @@ static void ftgmac100_init_hw(struct ftgmac100 *priv)\n static void ftgmac100_start_hw(struct ftgmac100 *priv)\n {\n \tu32 maccr = ioread32(priv-\u003ebase + FTGMAC100_OFFSET_MACCR);\n+\t/*\n+\t * Only reached once the device is open, so a phy_device is already\n+\t * attached: a discrete PHY via \"phy-handle\", a \"fixed-link\" node, or\n+\t * NC-SI's internal fixed 100M PHY.\n+\t */\n+\tstruct phy_device *phydev = priv-\u003enetdev-\u003ephydev;\n \n \t/* Keep the original GMAC and FAST bits */\n \tmaccr \u0026= (FTGMAC100_MACCR_FAST_MODE | FTGMAC100_MACCR_GIGA_MODE);\n@@ -382,6 +401,11 @@ static void ftgmac100_start_hw(struct ftgmac100 *priv)\n \tif (priv-\u003enetdev-\u003efeatures \u0026 NETIF_F_HW_VLAN_CTAG_RX)\n \t\tmaccr |= FTGMAC100_MACCR_RM_VLAN;\n \n+\tif ((priv-\u003equirks \u0026 FTGMAC100_QUIRK_RMII_ENABLE) \u0026\u0026\n+\t phydev-\u003einterface == PHY_INTERFACE_MODE_RMII) {\n+\t\tmaccr |= FTGMAC100_MACCR_RMII_ENABLE;\n+\t}\n+\n \t/* Hit the HW */\n \tiowrite32(maccr, priv-\u003ebase + FTGMAC100_OFFSET_MACCR);\n }\n@@ -458,7 +482,10 @@ static int ftgmac100_alloc_rx_buf(struct ftgmac100 *priv, unsigned int entry,\n \tpriv-\u003erx_skbs[entry] = skb;\n \n \t/* Store DMA address into RX desc */\n-\trxdes-\u003erxdes3 = cpu_to_le32(map);\n+\tif (priv-\u003equirks \u0026 FTGMAC100_QUIRK_DMA_35BIT)\n+\t\trxdes-\u003erxdes2 = cpu_to_le32(FIELD_PREP(FTGMAC100_RXDES2_RXBUF_BADR_HI,\n+\t\t\t\t\t\t upper_32_bits(map)));\n+\trxdes-\u003erxdes3 = cpu_to_le32(lower_32_bits(map));\n \n \t/* Ensure the above is ordered vs clearing the OWN bit */\n \tdma_wmb();\n@@ -585,6 +612,9 @@ static bool ftgmac100_rx_packet(struct ftgmac100 *priv, int *processed)\n \n \t/* Tear down DMA mapping, do necessary cache management */\n \tmap = le32_to_cpu(rxdes-\u003erxdes3);\n+\tif (priv-\u003equirks \u0026 FTGMAC100_QUIRK_DMA_35BIT)\n+\t\tmap |= (u64)FIELD_GET(FTGMAC100_RXDES2_RXBUF_BADR_HI,\n+\t\t\t\t le32_to_cpu(rxdes-\u003erxdes2)) \u003c\u003c 32;\n \n #if defined(CONFIG_ARM) \u0026\u0026 !defined(CONFIG_ARM_DMA_USE_IOMMU)\n \t/* When we don't have an iommu, we can save cycles by not\n@@ -661,9 +691,14 @@ static void ftgmac100_free_tx_packet(struct ftgmac100 *priv,\n \t\t\t\t struct ftgmac100_txdes *txdes,\n \t\t\t\t u32 ctl_stat)\n {\n-\tdma_addr_t map = le32_to_cpu(txdes-\u003etxdes3);\n+\tdma_addr_t map;\n \tsize_t len;\n \n+\tmap = le32_to_cpu(txdes-\u003etxdes3);\n+\tif (priv-\u003equirks \u0026 FTGMAC100_QUIRK_DMA_35BIT)\n+\t\tmap |= (u64)FIELD_GET(FTGMAC100_TXDES2_TXBUF_BADR_HI,\n+\t\t\t\t le32_to_cpu(txdes-\u003etxdes2)) \u003c\u003c 32;\n+\n \tif (ctl_stat \u0026 FTGMAC100_TXDES0_FTS) {\n \t\tlen = skb_headlen(skb);\n \t\tdma_unmap_single(priv-\u003edev, map, len, DMA_TO_DEVICE);\n@@ -817,7 +852,10 @@ static netdev_tx_t ftgmac100_hard_start_xmit(struct sk_buff *skb,\n \tf_ctl_stat |= FTGMAC100_TXDES0_FTS;\n \tif (nfrags == 0)\n \t\tf_ctl_stat |= FTGMAC100_TXDES0_LTS;\n-\ttxdes-\u003etxdes3 = cpu_to_le32(map);\n+\tif (priv-\u003equirks \u0026 FTGMAC100_QUIRK_DMA_35BIT)\n+\t\ttxdes-\u003etxdes2 = cpu_to_le32(FIELD_PREP(FTGMAC100_TXDES2_TXBUF_BADR_HI,\n+\t\t\t\t\t\t upper_32_bits(map)));\n+\ttxdes-\u003etxdes3 = cpu_to_le32(lower_32_bits(map));\n \ttxdes-\u003etxdes1 = cpu_to_le32(csum_vlan);\n \n \t/* Next descriptor */\n@@ -845,7 +883,10 @@ static netdev_tx_t ftgmac100_hard_start_xmit(struct sk_buff *skb,\n \t\t\tctl_stat |= FTGMAC100_TXDES0_LTS;\n \t\ttxdes-\u003etxdes0 = cpu_to_le32(ctl_stat);\n \t\ttxdes-\u003etxdes1 = 0;\n-\t\ttxdes-\u003etxdes3 = cpu_to_le32(map);\n+\t\tif (priv-\u003equirks \u0026 FTGMAC100_QUIRK_DMA_35BIT)\n+\t\t\ttxdes-\u003etxdes2 = cpu_to_le32(FIELD_PREP(FTGMAC100_TXDES2_TXBUF_BADR_HI,\n+\t\t\t\t\t\t\t upper_32_bits(map)));\n+\t\ttxdes-\u003etxdes3 = cpu_to_le32(lower_32_bits(map));\n \n \t\t/* Next one */\n \t\tpointer = ftgmac100_next_tx_pointer(priv, pointer);\n@@ -920,7 +961,12 @@ static void ftgmac100_free_buffers(struct ftgmac100 *priv)\n \tfor (i = 0; i \u003c priv-\u003erx_q_entries; i++) {\n \t\tstruct ftgmac100_rxdes *rxdes = \u0026priv-\u003erxdes[i];\n \t\tstruct sk_buff *skb = priv-\u003erx_skbs[i];\n-\t\tdma_addr_t map = le32_to_cpu(rxdes-\u003erxdes3);\n+\t\tdma_addr_t map;\n+\n+\t\tmap = le32_to_cpu(rxdes-\u003erxdes3);\n+\t\tif (priv-\u003equirks \u0026 FTGMAC100_QUIRK_DMA_35BIT)\n+\t\t\tmap |= (u64)FIELD_GET(FTGMAC100_RXDES2_RXBUF_BADR_HI,\n+\t\t\t\t\t le32_to_cpu(rxdes-\u003erxdes2)) \u003c\u003c 32;\n \n \t\tif (!skb)\n \t\t\tcontinue;\n@@ -1039,7 +1085,12 @@ static void ftgmac100_init_rings(struct ftgmac100 *priv)\n \tfor (i = 0; i \u003c priv-\u003erx_q_entries; i++) {\n \t\trxdes = \u0026priv-\u003erxdes[i];\n \t\trxdes-\u003erxdes0 = 0;\n-\t\trxdes-\u003erxdes3 = cpu_to_le32(priv-\u003erx_scratch_dma);\n+\t\tif (priv-\u003equirks \u0026 FTGMAC100_QUIRK_DMA_35BIT) {\n+\t\t\tu32 hi = upper_32_bits(priv-\u003erx_scratch_dma);\n+\n+\t\t\trxdes-\u003erxdes2 = cpu_to_le32(FIELD_PREP(FTGMAC100_RXDES2_RXBUF_BADR_HI, hi));\n+\t\t}\n+\t\trxdes-\u003erxdes3 = cpu_to_le32(lower_32_bits(priv-\u003erx_scratch_dma));\n \t}\n \t/* Mark the end of the ring */\n \trxdes-\u003erxdes0 |= cpu_to_le32(priv-\u003erxdes0_edorr_mask);\n@@ -1510,8 +1561,13 @@ static int ftgmac100_mii_probe(struct net_device *netdev)\n \n \t/* Default to RGMII. It's a gigabit part after all */\n \terr = of_get_phy_mode(np, \u0026phy_intf);\n-\tif (err)\n+\tif (err) {\n+\t\tif (priv-\u003emac_id == FTGMAC100_AST2700) {\n+\t\t\tdev_err(priv-\u003edev, \"phy-mode is required for this SoC\\n\");\n+\t\t\treturn -EINVAL;\n+\t\t}\n \t\tphy_intf = PHY_INTERFACE_MODE_RGMII;\n+\t}\n \n \t/* Aspeed only supports these. I don't know about other IP\n \t * block vendors so I'm going to just let them through for\n@@ -1941,7 +1997,7 @@ static int ftgmac100_probe_dt(struct net_device *netdev,\n \n static int ftgmac100_probe(struct platform_device *pdev)\n {\n-\tconst struct ftgmac100_match_data *match_data;\n+\tconst struct ftgmac100_match_data *match_data = NULL;\n \tenum ftgmac100_mac_id mac_id;\n \tstruct resource *res;\n \tint irq;\n@@ -1986,6 +2042,7 @@ static int ftgmac100_probe(struct platform_device *pdev)\n \tpriv-\u003enetdev = netdev;\n \tpriv-\u003edev = \u0026pdev-\u003edev;\n \tpriv-\u003emac_id = mac_id;\n+\tpriv-\u003equirks = match_data ? match_data-\u003equirks : 0;\n \tINIT_WORK(\u0026priv-\u003ereset_task, ftgmac100_reset_task);\n \n \t/* map io memory */\n@@ -2017,7 +2074,8 @@ static int ftgmac100_probe(struct platform_device *pdev)\n \n \tif (priv-\u003emac_id == FTGMAC100_AST2400 ||\n \t priv-\u003emac_id == FTGMAC100_AST2500 ||\n-\t priv-\u003emac_id == FTGMAC100_AST2600) {\n+\t priv-\u003emac_id == FTGMAC100_AST2600 ||\n+\t priv-\u003emac_id == FTGMAC100_AST2700) {\n \t\tpriv-\u003erxdes0_edorr_mask = BIT(30);\n \t\tpriv-\u003etxdes0_edotr_mask = BIT(30);\n \t\tpriv-\u003eis_aspeed = true;\n@@ -2081,6 +2139,14 @@ static int ftgmac100_probe(struct platform_device *pdev)\n \t\tnetdev-\u003ehw_features \u0026= ~(NETIF_F_HW_CSUM | NETIF_F_RXCSUM);\n \tnetdev-\u003efeatures |= netdev-\u003ehw_features;\n \n+\tif (priv-\u003equirks \u0026 FTGMAC100_QUIRK_DMA_35BIT) {\n+\t\terr = dma_set_mask_and_coherent(\u0026pdev-\u003edev, DMA_BIT_MASK(35));\n+\t\tif (err) {\n+\t\t\tdev_err(\u0026pdev-\u003edev, \"35-bit DMA enable failed\\n\");\n+\t\t\tgoto err;\n+\t\t}\n+\t}\n+\n \t/* register network device */\n \terr = register_netdev(netdev);\n \tif (err) {\n@@ -2131,6 +2197,12 @@ static const struct ftgmac100_match_data ftgmac100_match_data_ast2600 = {\n \t.mac_id = FTGMAC100_AST2600\n };\n \n+static const struct ftgmac100_match_data ftgmac100_match_data_ast2700 = {\n+\t.mac_id = FTGMAC100_AST2700,\n+\t.quirks = FTGMAC100_QUIRK_RMII_ENABLE |\n+\t\t FTGMAC100_QUIRK_DMA_35BIT,\n+};\n+\n static const struct ftgmac100_match_data ftgmac100_match_data_faraday = {\n \t.mac_id = FTGMAC100_FARADAY\n };\n@@ -2142,6 +2214,8 @@ static const struct of_device_id ftgmac100_of_match[] = {\n \t .data = \u0026ftgmac100_match_data_ast2500 },\n \t{ .compatible = \"aspeed,ast2600-mac\",\n \t .data = \u0026ftgmac100_match_data_ast2600 },\n+\t{ .compatible = \"aspeed,ast2700-mac\",\n+\t .data = \u0026ftgmac100_match_data_ast2700 },\n \t{ .compatible = \"faraday,ftgmac100\",\n \t .data = \u0026ftgmac100_match_data_faraday },\n \t{ }\ndiff --git a/drivers/net/ethernet/faraday/ftgmac100.h b/drivers/net/ethernet/faraday/ftgmac100.h\nindex 4968f6f0bdbc2..0c244b1c0a351 100644\n--- a/drivers/net/ethernet/faraday/ftgmac100.h\n+++ b/drivers/net/ethernet/faraday/ftgmac100.h\n@@ -57,6 +57,9 @@\n #define FTGMAC100_OFFSET_RX_RUNT\t0xc0\n #define FTGMAC100_OFFSET_RX_CRCER_FTL\t0xc4\n #define FTGMAC100_OFFSET_RX_COL_LOST\t0xc8\n+/* reserved 0xcc - 0x178 */\n+#define FTGMAC100_OFFSET_TXR_BADDR_HIGH\t0x17c\n+#define FTGMAC100_OFFSET_RXR_BADDR_HIGH\t0x18c\n \n /*\n * Interrupt status register \u0026 interrupt enable register\n@@ -167,6 +170,7 @@\n #define FTGMAC100_MACCR_RX_BROADPKT\t(1 \u003c\u003c 17)\n #define FTGMAC100_MACCR_DISCARD_CRCERR\t(1 \u003c\u003c 18)\n #define FTGMAC100_MACCR_FAST_MODE\t(1 \u003c\u003c 19)\n+#define FTGMAC100_MACCR_RMII_ENABLE\tBIT(20)\n #define FTGMAC100_MACCR_SW_RST\t\t(1 \u003c\u003c 31)\n \n /*\n@@ -225,6 +229,7 @@ struct ftgmac100_txdes {\n #define FTGMAC100_TXDES1_TX2FIC\t\t(1 \u003c\u003c 30)\n #define FTGMAC100_TXDES1_TXIC\t\t(1 \u003c\u003c 31)\n \n+#define FTGMAC100_TXDES2_TXBUF_BADR_HI\tGENMASK(18, 16)\n /*\n * Receive descriptor, aligned to 16 bytes\n */\n@@ -271,4 +276,6 @@ struct ftgmac100_rxdes {\n #define FTGMAC100_RXDES1_UDP_CHKSUM_ERR\t(1 \u003c\u003c 26)\n #define FTGMAC100_RXDES1_IP_CHKSUM_ERR\t(1 \u003c\u003c 27)\n \n+#define FTGMAC100_RXDES2_RXBUF_BADR_HI\tGENMASK(18, 16)\n+\n #endif /* __FTGMAC100_H */\ndiff --git a/drivers/net/mdio/Kconfig b/drivers/net/mdio/Kconfig\nindex d44278f26fabe..d784782c230fe 100644\n--- a/drivers/net/mdio/Kconfig\n+++ b/drivers/net/mdio/Kconfig\n@@ -50,12 +50,16 @@ config MDIO_ASPEED\n \tdepends on OF_MDIO \u0026\u0026 HAS_IOMEM\n \thelp\n \t This module provides a driver for the independent MDIO bus\n-\t controllers found in the ASPEED AST2600 SoC. This is a driver for the\n-\t third revision of the ASPEED MDIO register interface - the first two\n-\t revisions are the \"old\" and \"new\" interfaces found in the AST2400 and\n-\t AST2500, embedded in the MAC. For legacy reasons, FTGMAC100 driver\n-\t continues to drive the embedded MDIO controller for the AST2400 and\n-\t AST2500 SoCs, so say N if AST2600 support is not required.\n+\t controllers found in the ASPEED AST2600 and AST2700 SoCs. This is a\n+\t driver for the third revision of the ASPEED MDIO register interface -\n+\t the first two revisions are the \"old\" and \"new\" interfaces found in\n+\t the AST2400 and AST2500, embedded in the MAC. For legacy reasons,\n+\t FTGMAC100 driver continues to drive the embedded MDIO controller for\n+\t the AST2400 and AST2500 SoCs. AST2700 has no dedicated MACH_ASPEED_G7\n+\t symbol and is only gated by ARCH_ASPEED, so FTGMAC100 now\n+\t unconditionally selects this driver on every ARCH_ASPEED platform,\n+\t including the older AST2400/AST2500 SoCs where it has no MDIO node to\n+\t bind to.\n \n config MDIO_BITBANG\n \ttristate \"Bitbanged MDIO buses\"\n"
} |
| 2/1 | 2026/10/15 07:44 | agent | patch-evaluator |
0mModel:core Args: null Results: {
"EnableConfigs": null,
"FocusSymbols": [],
"Reasoning": "The patch series adds support for the ASPEED AST2700 SoC to the Faraday FTGMAC100 Ethernet driver, updating DeviceTree bindings, Kconfig, and the driver logic for 35-bit DMA and RMII enable. The FTGMAC100 driver is an SoC platform driver for ARM/ARM64 ASPEED and Faraday architectures that probes via Device Tree. On the target amd64 architecture, this hardware is not present or emulated, making the modified code structurally unreachable.",
"WorthFuzzing": false
}Instruction: You are an expert Linux kernel maintainer and security engineer.
Your job is to review a provided patch series and evaluate whether it warrants fuzzing with syzkaller.
IMPORTANT: The changes have ALREADY been applied and committed as the HEAD commit in
your workspace. Do NOT rely on internal assumptions. You must actively use your code access
tools to inspect the actual source code, callers, and surrounding context.
================================================================================
1. CORE TRIAGE PHILOSOPHY
================================================================================
The goal of patch fuzzing is to discover crashes, regressions, exposed latent bugs,
and newly triggered assertions introduced by the patch series.
- REACHABILITY IS THE PRIMARY GATE:
Fuzzing can only discover bugs in code that can actually execute in standard virtualized
environments (GCE or QEMU, utilizing software-emulated devices like USB gadgets, netdev, tun/tap).
If the modified code is structurally unreachable (see Section 2), it MUST NOT be fuzzed,
regardless of whether it adds assertions or complex logic.
- DO NOT BLINDLY TRUST "NO FUNCTIONAL CHANGE" (NFCI) OR "REFACTORING" CLAIMS:
Patch authors routinely label changes as "cleanups", "refactorings", or state
"No functional change intended". Do NOT take these claims at face value.
Code refactorings that rearrange logic, introduce helper functions, or alter state management
in core subsystems frequently introduce subtle semantic shifts or uncover latent kernel bugs.
If reachable executable code is modified or refactored, it MUST be fuzzed.
- NEW OR MODIFIED ASSERTIONS IN REACHABLE CODE MUST BE FUZZED:
When a patch introduces or modifies runtime checks or assertions (e.g., WARN_ON*, VM_WARN_ON*,
BUG_ON*, lockdep_assert*) in reachable code paths, it enforces new or stricter invariants.
Even if the author believes the invariant always holds, fuzzing is essential to verify whether
an unusual sequence of operations can violate it.
================================================================================
2. WHEN TO RETURN WorthFuzzing=false (NEGATIVE CRITERIA)
================================================================================
Return WorthFuzzing=false ONLY IF all modified code falls strictly into one or more of these categories:
- Non-kernel and non-executable changes:
* Modifications to Documentation/, comments, or spelling fixes.
* User-space directories, self-tests, samples, or scripts (e.g., tools/, samples/, scripts/, usr/)
that do not affect the compiled kernel image (vmlinux) or kernel modules.
* Purely decorative logging (e.g., message strings in pr_err, printk, dev_info) or tracepoints
that do not alter control flow or data structures.
* Build system or Kconfig changes that do not alter compiled C logic.
- Structurally unreachable hardware:
* Vendor-specific PCIe switches, SmartNICs, or GPU drivers (e.g., mlxsw, pds_core, qed,
ionic, amdgpu) requiring physical ASIC/PCIe cards not emulated in standard QEMU.
- Unreachable execution paths:
* Driver teardown callbacks (.remove, .shutdown, pci_unregister_driver) executed only during
physical PCI hot-unplug or manual sysfs driver unbinding.
* Code paths exclusive to architectures other than the target architecture.
================================================================================
3. WHEN TO RETURN WorthFuzzing=true (POSITIVE CRITERIA)
================================================================================
Return WorthFuzzing=true whenever the patch touches reachable executable code, including:
- Core Subsystems:
* Any logic modifications in memory management (mm/), synchronization/locking (kernel/locking/),
BPF, scheduler, core networking, VFS, or syscall handling.
- Refactorings and Code Cleanups:
* Any restructuring of reachable data structures, helper abstractions, or algorithm flows.
- Runtime Assertions and Defensive Checks:
* Any introduction or alteration of assertions (WARN_ON*, VM_WARN_ON*, BUG_ON*, etc.) in reachable paths.
- Reachable Drivers and Protocols:
* Drivers accessible via virtual buses (virtio, USB gadget, loopback, netlink, binder, sockets, etc.).
================================================================================
4. EXTRACTING FocusSymbols (PREVENTING DILUTION)
================================================================================
When WorthFuzzing=true, you must extract specific kernel functions into FocusSymbols to guide the fuzzer:
- AVOID UBIQUITOUS LIFECYCLE HOT-PATHS:
Do NOT list generic, ubiquitous functions called by almost every program in the corpus
(including, but not limited to: general memory allocators and deallocators, page fault
and trap handlers, or core synchronization primitives; this is not an exhaustive list).
Listing ubiquitous functions causes the fuzzer to classify thousands of unrelated tests as "focused",
which severely dilutes fuzzing effort away from the actual changes.
- TARGET SPECIFIC FEATURE LOGIC AND ENTRYPOINTS:
List functions that specifically implement the logic being added or altered, or direct API entrypoints
for the subsystem feature under review.
- HANDLING STATIC INLINE FUNCTIONS IN HEADERS (.h):
Compiler-inlined static functions (such as static inlines in mm/*.h or include/linux/*.h) lack
distinct symbol addresses in vmlinux and cannot be targeted directly by symbol coverage filters.
If the changes are primarily in static inline helpers, identify non-static, feature-specific caller
functions in .c files that exercise them (avoiding ubiquitous lifecycle wrappers).
================================================================================
5. IDENTIFYING EnableConfigs
================================================================================
Identify any specific CONFIG_ options required to properly compile and reach the modified code:
- Inspect Kconfig files and #ifdef guards; do not make assumptions.
- Check "depends on" lines in Kconfig to include any non-standard parent subsystem configs needed.
- Strip any 'CONFIG_' prefix (e.g., return "NET_IPV4" instead of "CONFIG_NET_IPV4").
Prefer calling several tools at the same time to save round-trips.
Use set-results tool to provide results of the analysis.
It must be called exactly once before the final reply.
Ignore results of this tool.
Prompt: Target architecture: amd64
For your convenience, here is the diff of the changes:
commit 261820ad172cf1456fa1b62ac6549140231e058f
Author: syz-cluster <triage@syzkaller.com>
Date: Thu Oct 15 07:44:04 2026 +0000
syz-cluster: applied patch under review
diff --git a/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml b/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
index d14410018bcf6..0a376b849a916 100644
--- a/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
+++ b/Documentation/devicetree/bindings/net/faraday,ftgmac100.yaml
@@ -13,12 +13,11 @@ properties:
compatible:
oneOf:
- const: faraday,ftgmac100
- - items:
- - enum:
- - aspeed,ast2400-mac
- - aspeed,ast2500-mac
- - aspeed,ast2600-mac
- - const: faraday,ftgmac100
+ - enum:
+ - aspeed,ast2400-mac
+ - aspeed,ast2500-mac
+ - aspeed,ast2600-mac
+ - aspeed,ast2700-mac
reg:
maxItems: 1
@@ -30,7 +29,7 @@ properties:
minItems: 1
items:
- description: MAC IP clock
- - description: RMII RCLK gate for AST2500/2600
+ - description: RMII RCLK gate for AST2500/2600/2700
resets:
maxItems: 1
@@ -82,26 +81,35 @@ allOf:
contains:
enum:
- aspeed,ast2600-mac
+ - aspeed,ast2700-mac
then:
properties:
resets: true
else:
properties:
resets: false
+ - if:
+ properties:
+ compatible:
+ contains:
+ const: aspeed,ast2700-mac
+ then:
+ required:
+ - phy-mode
unevaluatedProperties: false
examples:
- |
ethernet@1e660000 {
- compatible = "aspeed,ast2500-mac", "faraday,ftgmac100";
+ compatible = "aspeed,ast2500-mac";
reg = <0x1e660000 0x180>;
interrupts = <2>;
use-ncsi;
};
ethernet@1e680000 {
- compatible = "aspeed,ast2500-mac", "faraday,ftgmac100";
+ compatible = "aspeed,ast2500-mac";
reg = <0x1e680000 0x180>;
interrupts = <2>;
diff --git a/drivers/net/ethernet/faraday/Kconfig b/drivers/net/ethernet/faraday/Kconfig
index 474073c7f94d7..9acc2d260c1f9 100644
--- a/drivers/net/ethernet/faraday/Kconfig
+++ b/drivers/net/ethernet/faraday/Kconfig
@@ -6,7 +6,7 @@
config NET_VENDOR_FARADAY
bool "Faraday devices"
default y
- depends on ARM || COMPILE_TEST
+ depends on ARM || ARM64 || COMPILE_TEST
help
If you have a network (Ethernet) card belonging to this class, say Y.
@@ -28,11 +28,10 @@ config FTMAC100
config FTGMAC100
tristate "Faraday FTGMAC100 Gigabit Ethernet support"
- depends on ARM || COMPILE_TEST
- depends on !64BIT || BROKEN
+ depends on ARM || ARM64 || COMPILE_TEST
select PHYLIB
select FIXED_PHY
- select MDIO_ASPEED if MACH_ASPEED_G6
+ select MDIO_ASPEED if ARCH_ASPEED
select CRC32
help
This driver supports the FTGMAC100 Gigabit Ethernet controller
diff --git a/drivers/net/ethernet/faraday/ftgmac100.c b/drivers/net/ethernet/faraday/ftgmac100.c
index 6d2fe5c2f3903..263594de0e072 100644
--- a/drivers/net/ethernet/faraday/ftgmac100.c
+++ b/drivers/net/ethernet/faraday/ftgmac100.c
@@ -8,6 +8,7 @@
#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+#include <linux/bitfield.h>
#include <linux/clk.h>
#include <linux/reset.h>
#include <linux/dma-mapping.h>
@@ -37,11 +38,16 @@ enum ftgmac100_mac_id {
FTGMAC100_FARADAY = 1,
FTGMAC100_AST2400,
FTGMAC100_AST2500,
- FTGMAC100_AST2600
+ FTGMAC100_AST2600,
+ FTGMAC100_AST2700
};
+#define FTGMAC100_QUIRK_RMII_ENABLE BIT(0)
+#define FTGMAC100_QUIRK_DMA_35BIT BIT(1)
+
struct ftgmac100_match_data {
enum ftgmac100_mac_id mac_id;
+ u32 quirks;
};
/* Arbitrary values, I am not sure the HW has limits */
@@ -78,6 +84,7 @@ struct ftgmac100 {
void __iomem *base;
enum ftgmac100_mac_id mac_id;
+ u32 quirks;
/* Rx ring */
unsigned int rx_q_entries;
@@ -298,10 +305,16 @@ static void ftgmac100_init_hw(struct ftgmac100 *priv)
iowrite32(reg, priv->base + FTGMAC100_OFFSET_ISR);
/* Setup RX ring buffer base */
- iowrite32(priv->rxdes_dma, priv->base + FTGMAC100_OFFSET_RXR_BADR);
+ iowrite32(lower_32_bits(priv->rxdes_dma), priv->base + FTGMAC100_OFFSET_RXR_BADR);
+ if (priv->quirks & FTGMAC100_QUIRK_DMA_35BIT)
+ iowrite32(upper_32_bits(priv->rxdes_dma),
+ priv->base + FTGMAC100_OFFSET_RXR_BADDR_HIGH);
/* Setup TX ring buffer base */
- iowrite32(priv->txdes_dma, priv->base + FTGMAC100_OFFSET_NPTXR_BADR);
+ iowrite32(lower_32_bits(priv->txdes_dma), priv->base + FTGMAC100_OFFSET_NPTXR_BADR);
+ if (priv->quirks & FTGMAC100_QUIRK_DMA_35BIT)
+ iowrite32(upper_32_bits(priv->txdes_dma),
+ priv->base + FTGMAC100_OFFSET_TXR_BADDR_HIGH);
/* Configure RX buffer size */
iowrite32(FTGMAC100_RBSR_SIZE(RX_BUF_SIZE),
@@ -354,6 +367,12 @@ static void ftgmac100_init_hw(struct ftgmac100 *priv)
static void ftgmac100_start_hw(struct ftgmac100 *priv)
{
u32 maccr = ioread32(priv->base + FTGMAC100_OFFSET_MACCR);
+ /*
+ * Only reached once the device is open, so a phy_device is already
+ * attached: a discrete PHY via "phy-handle", a "fixed-link" node, or
+ * NC-SI's internal fixed 100M PHY.
+ */
+ struct phy_device *phydev = priv->netdev->phydev;
/* Keep the original GMAC and FAST bits */
maccr &= (FTGMAC100_MACCR_FAST_MODE | FTGMAC100_MACCR_GIGA_MODE);
@@ -382,6 +401,11 @@ static void ftgmac100_start_hw(struct ftgmac100 *priv)
if (priv->netdev->features & NETIF_F_HW_VLAN_CTAG_RX)
maccr |= FTGMAC100_MACCR_RM_VLAN;
+ if ((priv->quirks & FTGMAC100_QUIRK_RMII_ENABLE) &&
+ phydev->interface == PHY_INTERFACE_MODE_RMII) {
+ maccr |= FTGMAC100_MACCR_RMII_ENABLE;
+ }
+
/* Hit the HW */
iowrite32(maccr, priv->base + FTGMAC100_OFFSET_MACCR);
}
@@ -458,7 +482,10 @@ static int ftgmac100_alloc_rx_buf(struct ftgmac100 *priv, unsigned int entry,
priv->rx_skbs[entry] = skb;
/* Store DMA address into RX desc */
- rxdes->rxdes3 = cpu_to_le32(map);
+ if (priv->quirks & FTGMAC100_QUIRK_DMA_35BIT)
+ rxdes->rxdes2 = cpu_to_le32(FIELD_PREP(FTGMAC100_RXDES2_RXBUF_BADR_HI,
+ upper_32_bits(map)));
+ rxdes->rxdes3 = cpu_to_le32(lower_32_bits(map));
/* Ensure the above is ordered vs clearing the OWN bit */
dma_wmb();
@@ -585,6 +612,9 @@ static bool ftgmac100_rx_packet(struct ftgmac100 *priv, int *processed)
/* Tear down DMA mapping, do necessary cache management */
map = le32_to_cpu(rxdes->rxdes3);
+ if (priv->quirks & FTGMAC100_QUIRK_DMA_35BIT)
+ map |= (u64)FIELD_GET(FTGMAC100_RXDES2_RXBUF_BADR_HI,
+ le32_to_cpu(rxdes->rxdes2)) << 32;
#if defined(CONFIG_ARM) && !defined(CONFIG_ARM_DMA_USE_IOMMU)
/* When we don't have an iommu, we can save cycles by not
@@ -661,9 +691,14 @@ static void ftgmac100_free_tx_packet(struct ftgmac100 *priv,
struct ftgmac100_txdes *txdes,
u32 ctl_stat)
{
- dma_addr_t map = le32_to_cpu(txdes->txdes3);
+ dma_addr_t map;
size_t len;
+ map = le32_to_cpu(txdes->txdes3);
+ if (priv->quirks & FTGMAC100_QUIRK_DMA_35BIT)
+ map |= (u64)FIELD_GET(FTGMAC100_TXDES2_TXBUF_BADR_HI,
+ le32_to_cpu(txdes->txdes2)) << 32;
+
if (ctl_stat & FTGMAC100_TXDES0_FTS) {
len = skb_headlen(skb);
dma_unmap_single(priv->dev, map, len, DMA_TO_DEVICE);
@@ -817,7 +852,10 @@ static netdev_tx_t ftgmac100_hard_start_xmit(struct sk_buff *skb,
f_ctl_stat |= FTGMAC100_TXDES0_FTS;
if (nfrags == 0)
f_ctl_stat |= FTGMAC100_TXDES0_LTS;
- txdes->txdes3 = cpu_to_le32(map);
+ if (priv->quirks & FTGMAC100_QUIRK_DMA_35BIT)
+ txdes->txdes2 = cpu_to_le32(FIELD_PREP(FTGMAC100_TXDES2_TXBUF_BADR_HI,
+ upper_32_bits(map)));
+ txdes->txdes3 = cpu_to_le32(lower_32_bits(map));
txdes->txdes1 = cpu_to_le32(csum_vlan);
/* Next descriptor */
@@ -845,7 +883,10 @@ static netdev_tx_t ftgmac100_hard_start_xmit(struct sk_buff *skb,
ctl_stat |= FTGMAC100_TXDES0_LTS;
txdes->txdes0 = cpu_to_le32(ctl_stat);
txdes->txdes1 = 0;
- txdes->txdes3 = cpu_to_le32(map);
+ if (priv->quirks & FTGMAC100_QUIRK_DMA_35BIT)
+ txdes->txdes2 = cpu_to_le32(FIELD_PREP(FTGMAC100_TXDES2_TXBUF_BADR_HI,
+ upper_32_bits(map)));
+ txdes->txdes3 = cpu_to_le32(lower_32_bits(map));
/* Next one */
pointer = ftgmac100_next_tx_pointer(priv, pointer);
@@ -920,7 +961,12 @@ static void ftgmac100_free_buffers(struct ftgmac100 *priv)
for (i = 0; i < priv->rx_q_entries; i++) {
struct ftgmac100_rxdes *rxdes = &priv->rxdes[i];
struct sk_buff *skb = priv->rx_skbs[i];
- dma_addr_t map = le32_to_cpu(rxdes->rxdes3);
+ dma_addr_t map;
+
+ map = le32_to_cpu(rxdes->rxdes3);
+ if (priv->quirks & FTGMAC100_QUIRK_DMA_35BIT)
+ map |= (u64)FIELD_GET(FTGMAC100_RXDES2_RXBUF_BADR_HI,
+ le32_to_cpu(rxdes->rxdes2)) << 32;
if (!skb)
continue;
@@ -1039,7 +1085,12 @@ static void ftgmac100_init_rings(struct ftgmac100 *priv)
for (i = 0; i < priv->rx_q_entries; i++) {
rxdes = &priv->rxdes[i];
rxdes->rxdes0 = 0;
- rxdes->rxdes3 = cpu_to_le32(priv->rx_scratch_dma);
+ if (priv->quirks & FTGMAC100_QUIRK_DMA_35BIT) {
+ u32 hi = upper_32_bits(priv->rx_scratch_dma);
+
+ rxdes->rxdes2 = cpu_to_le32(FIELD_PREP(FTGMAC100_RXDES2_RXBUF_BADR_HI, hi));
+ }
+ rxdes->rxdes3 = cpu_to_le32(lower_32_bits(priv->rx_scratch_dma));
}
/* Mark the end of the ring */
rxdes->rxdes0 |= cpu_to_le32(priv->rxdes0_edorr_mask);
@@ -1510,8 +1561,13 @@ static int ftgmac100_mii_probe(struct net_device *netdev)
/* Default to RGMII. It's a gigabit part after all */
err = of_get_phy_mode(np, &phy_intf);
- if (err)
+ if (err) {
+ if (priv->mac_id == FTGMAC100_AST2700) {
+ dev_err(priv->dev, "phy-mode is required for this SoC\n");
+ return -EINVAL;
+ }
phy_intf = PHY_INTERFACE_MODE_RGMII;
+ }
/* Aspeed only supports these. I don't know about other IP
* block vendors so I'm going to just let them through for
@@ -1941,7 +1997,7 @@ static int ftgmac100_probe_dt(struct net_device *netdev,
static int ftgmac100_probe(struct platform_device *pdev)
{
- const struct ftgmac100_match_data *match_data;
+ const struct ftgmac100_match_data *match_data = NULL;
enum ftgmac100_mac_id mac_id;
struct resource *res;
int irq;
@@ -1986,6 +2042,7 @@ static int ftgmac100_probe(struct platform_device *pdev)
priv->netdev = netdev;
priv->dev = &pdev->dev;
priv->mac_id = mac_id;
+ priv->quirks = match_data ? match_data->quirks : 0;
INIT_WORK(&priv->reset_task, ftgmac100_reset_task);
/* map io memory */
@@ -2017,7 +2074,8 @@ static int ftgmac100_probe(struct platform_device *pdev)
if (priv->mac_id == FTGMAC100_AST2400 ||
priv->mac_id == FTGMAC100_AST2500 ||
- priv->mac_id == FTGMAC100_AST2600) {
+ priv->mac_id == FTGMAC100_AST2600 ||
+ priv->mac_id == FTGMAC100_AST2700) {
priv->rxdes0_edorr_mask = BIT(30);
priv->txdes0_edotr_mask = BIT(30);
priv->is_aspeed = true;
@@ -2081,6 +2139,14 @@ static int ftgmac100_probe(struct platform_device *pdev)
netdev->hw_features &= ~(NETIF_F_HW_CSUM | NETIF_F_RXCSUM);
netdev->features |= netdev->hw_features;
+ if (priv->quirks & FTGMAC100_QUIRK_DMA_35BIT) {
+ err = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(35));
+ if (err) {
+ dev_err(&pdev->dev, "35-bit DMA enable failed\n");
+ goto err;
+ }
+ }
+
/* register network device */
err = register_netdev(netdev);
if (err) {
@@ -2131,6 +2197,12 @@ static const struct ftgmac100_match_data ftgmac100_match_data_ast2600 = {
.mac_id = FTGMAC100_AST2600
};
+static const struct ftgmac100_match_data ftgmac100_match_data_ast2700 = {
+ .mac_id = FTGMAC100_AST2700,
+ .quirks = FTGMAC100_QUIRK_RMII_ENABLE |
+ FTGMAC100_QUIRK_DMA_35BIT,
+};
+
static const struct ftgmac100_match_data ftgmac100_match_data_faraday = {
.mac_id = FTGMAC100_FARADAY
};
@@ -2142,6 +2214,8 @@ static const struct of_device_id ftgmac100_of_match[] = {
.data = &ftgmac100_match_data_ast2500 },
{ .compatible = "aspeed,ast2600-mac",
.data = &ftgmac100_match_data_ast2600 },
+ { .compatible = "aspeed,ast2700-mac",
+ .data = &ftgmac100_match_data_ast2700 },
{ .compatible = "faraday,ftgmac100",
.data = &ftgmac100_match_data_faraday },
{ }
diff --git a/drivers/net/ethernet/faraday/ftgmac100.h b/drivers/net/ethernet/faraday/ftgmac100.h
index 4968f6f0bdbc2..0c244b1c0a351 100644
--- a/drivers/net/ethernet/faraday/ftgmac100.h
+++ b/drivers/net/ethernet/faraday/ftgmac100.h
@@ -57,6 +57,9 @@
#define FTGMAC100_OFFSET_RX_RUNT 0xc0
#define FTGMAC100_OFFSET_RX_CRCER_FTL 0xc4
#define FTGMAC100_OFFSET_RX_COL_LOST 0xc8
+/* reserved 0xcc - 0x178 */
+#define FTGMAC100_OFFSET_TXR_BADDR_HIGH 0x17c
+#define FTGMAC100_OFFSET_RXR_BADDR_HIGH 0x18c
/*
* Interrupt status register & interrupt enable register
@@ -167,6 +170,7 @@
#define FTGMAC100_MACCR_RX_BROADPKT (1 << 17)
#define FTGMAC100_MACCR_DISCARD_CRCERR (1 << 18)
#define FTGMAC100_MACCR_FAST_MODE (1 << 19)
+#define FTGMAC100_MACCR_RMII_ENABLE BIT(20)
#define FTGMAC100_MACCR_SW_RST (1 << 31)
/*
@@ -225,6 +229,7 @@ struct ftgmac100_txdes {
#define FTGMAC100_TXDES1_TX2FIC (1 << 30)
#define FTGMAC100_TXDES1_TXIC (1 << 31)
+#define FTGMAC100_TXDES2_TXBUF_BADR_HI GENMASK(18, 16)
/*
* Receive descriptor, aligned to 16 bytes
*/
@@ -271,4 +276,6 @@ struct ftgmac100_rxdes {
#define FTGMAC100_RXDES1_UDP_CHKSUM_ERR (1 << 26)
#define FTGMAC100_RXDES1_IP_CHKSUM_ERR (1 << 27)
+#define FTGMAC100_RXDES2_RXBUF_BADR_HI GENMASK(18, 16)
+
#endif /* __FTGMAC100_H */
diff --git a/drivers/net/mdio/Kconfig b/drivers/net/mdio/Kconfig
index d44278f26fabe..d784782c230fe 100644
--- a/drivers/net/mdio/Kconfig
+++ b/drivers/net/mdio/Kconfig
@@ -50,12 +50,16 @@ config MDIO_ASPEED
depends on OF_MDIO && HAS_IOMEM
help
This module provides a driver for the independent MDIO bus
- controllers found in the ASPEED AST2600 SoC. This is a driver for the
- third revision of the ASPEED MDIO register interface - the first two
- revisions are the "old" and "new" interfaces found in the AST2400 and
- AST2500, embedded in the MAC. For legacy reasons, FTGMAC100 driver
- continues to drive the embedded MDIO controller for the AST2400 and
- AST2500 SoCs, so say N if AST2600 support is not required.
+ controllers found in the ASPEED AST2600 and AST2700 SoCs. This is a
+ driver for the third revision of the ASPEED MDIO register interface -
+ the first two revisions are the "old" and "new" interfaces found in
+ the AST2400 and AST2500, embedded in the MAC. For legacy reasons,
+ FTGMAC100 driver continues to drive the embedded MDIO controller for
+ the AST2400 and AST2500 SoCs. AST2700 has no dedicated MACH_ASPEED_G7
+ symbol and is only gated by ARCH_ASPEED, so FTGMAC100 now
+ unconditionally selects this driver on every ARCH_ASPEED platform,
+ including the older AST2400/AST2500 SoCs where it has no MDIO node to
+ bind to.
config MDIO_BITBANG
tristate "Bitbanged MDIO buses"
|
| 3/2 | 2026/10/15 07:44 | llm | patch-evaluator |
0mModel:gemini-3.8-flash Args: null Results: null Tokens: input: 9669 output: 63 thoughts: 157 Thoughts: **Analyzing a Faraday FTGMAC100 Driver Patch** Okay, so this patch affects a few key areas, let's break this down. First, I see it's touching the device tree bindings for a Faraday FTGMAC100 – `faraday,ftgmac100.yaml`. That's good, meaning there might be updates to how this device is described within the system's hardware configuration. I'll need to scrutinize those YAML changes closely for any schema modifications, new properties, or deprecations. Then there are modifications to the Kconfig files: `drivers/net/ethernet/faraday/Kconfig` and `drivers/net/mdio/Kconfig`. This suggests changes to the build system and likely involves enabling/disabling the driver's compilation or its dependencies. This warrants a look at what specific options are being altered and why, as this directly impacts the driver's configurability. The core of the driver itself – `ftgmac100.c` and `ftgmac100.h` – are also modified. Obviously, this is where the meat of the functionality lies. I'll need to meticulously review the code changes in `ftgmac100.c`, to discern the changes to the register access, interrupt handling, or networking interface. I need to understand what new functionality is included, or what bug fixes are present. The header file `ftgmac100.h` provides definitions, data structures, and the driver's API, so I'll be reviewing that for any changes to internal data structures or potential API modifications. The target architecture is amd64, which is helpful to understand if this patch is architecture-specific. I'll have to keep this in mind. Now, let's confirm the role of this driver. Is this a platform driver? Let's confirm by reading the contents of `ftgmac100.c` or quickly using a grep to locate the relevant kernel driver macros. I'll likely be checking for platform_driver or similar indications. This gives me a high level overview of the driver's model in the kernel, and the likely interaction of the driver with the device, and the device tree. |
| 4/2 | 2026/10/15 07:44 | tool | grepper |
0mArgs:{
"Expression": "module_platform_driver\\(ftgmac100_driver\\)|ftgmac100_driver",
"PathPrefixes": [
"drivers/net/ethernet/faraday/ftgmac100.c"
]
}Results: {
"Output": "drivers/net/ethernet/faraday/ftgmac100.c=2223=MODULE_DEVICE_TABLE(of, ftgmac100_of_match);\ndrivers/net/ethernet/faraday/ftgmac100.c-2224-\ndrivers/net/ethernet/faraday/ftgmac100.c:2225:static struct platform_driver ftgmac100_driver = {\ndrivers/net/ethernet/faraday/ftgmac100.c-2226-\t.probe\t= ftgmac100_probe,\n--\ndrivers/net/ethernet/faraday/ftgmac100.c-2232-};\ndrivers/net/ethernet/faraday/ftgmac100.c:2233:module_platform_driver(ftgmac100_driver);\ndrivers/net/ethernet/faraday/ftgmac100.c-2234-\n"
} |
| 5/2 | 2026/10/15 07:44 | llm | patch-evaluator |
0mModel:gemini-3.8-flash Args: null Results: null Tokens: input: 10617 output: 47 thoughts: 328 Thoughts: **Analyzing the FTGMAC100 Driver for QEMU on amd64** Okay, let's dissect this `ftgmac100_driver`. I need to figure out if I can even instantiate or probe this thing within QEMU on an amd64 architecture. My immediate thought is to check the `Kconfig` file in `drivers/net/ethernet/faraday/` – specifically, how the build configuration is handled. Right, I see it: `config NET_VENDOR_FARADAY` and `config FTGMAC100`. The critical dependency for `FTGMAC100` is `ARM || ARM64 || COMPILE_TEST`. Hang on a second... the target architecture is amd64, that's x86_64, not ARM or ARM64. So, can `CONFIG_FTGMAC100` *actually* be enabled on amd64 without relying on `COMPILE_TEST`? It seems highly unlikely. Even if `COMPILE_TEST` is active, does this device even *exist* on an x86_64 system? That's a huge question mark. Okay, let's step back. What bus is this device even on? Let me check the driver itself – Aha, it's a `platform_driver` – `ftgmac100_driver`. That makes things more specific. That limits the matching to things that use the platform bus. I see the device table. It uses OF (Open Firmware/Device Tree) matching: `MODULE_DEVICE_TABLE(of, ftgmac100_of_match);`. Does it have an ACPI or platform device ID table? It's time to dig into the source code, specifically lines 2200-2235 of `drivers/net/ethernet/faraday/ftgmac100.c`. Let's see what's what there. |
| 6/2 | 2026/10/15 07:44 | tool | read-file |
0mArgs:{
"File": "drivers/net/ethernet/faraday/ftgmac100.c",
"FirstLine": 2200,
"LineCount": 40
}Results: {
"Contents": "2200:\tstatic const struct ftgmac100_match_data ftgmac100_match_data_ast2700 = {\n2201:\t\t.mac_id = FTGMAC100_AST2700,\n2202:\t\t.quirks = FTGMAC100_QUIRK_RMII_ENABLE |\n2203:\t\t\t FTGMAC100_QUIRK_DMA_35BIT,\n2204:\t};\n2205:\t\n2206:\tstatic const struct ftgmac100_match_data ftgmac100_match_data_faraday = {\n2207:\t\t.mac_id = FTGMAC100_FARADAY\n2208:\t};\n2209:\t\n2210:\tstatic const struct of_device_id ftgmac100_of_match[] = {\n2211:\t\t{ .compatible = \"aspeed,ast2400-mac\",\n2212:\t\t .data = \u0026ftgmac100_match_data_ast2400},\n2213:\t\t{ .compatible = \"aspeed,ast2500-mac\",\n2214:\t\t .data = \u0026ftgmac100_match_data_ast2500 },\n2215:\t\t{ .compatible = \"aspeed,ast2600-mac\",\n2216:\t\t .data = \u0026ftgmac100_match_data_ast2600 },\n2217:\t\t{ .compatible = \"aspeed,ast2700-mac\",\n2218:\t\t .data = \u0026ftgmac100_match_data_ast2700 },\n2219:\t\t{ .compatible = \"faraday,ftgmac100\",\n2220:\t\t .data = \u0026ftgmac100_match_data_faraday },\n2221:\t\t{ }\n2222:\t};\n2223:\tMODULE_DEVICE_TABLE(of, ftgmac100_of_match);\n2224:\t\n2225:\tstatic struct platform_driver ftgmac100_driver = {\n2226:\t\t.probe\t= ftgmac100_probe,\n2227:\t\t.remove = ftgmac100_remove,\n2228:\t\t.driver\t= {\n2229:\t\t\t.name\t\t= DRV_NAME,\n2230:\t\t\t.of_match_table\t= ftgmac100_of_match,\n2231:\t\t},\n2232:\t};\n2233:\tmodule_platform_driver(ftgmac100_driver);\n2234:\t\n2235:\tMODULE_AUTHOR(\"Po-Yu Chuang \u003cratbert@faraday-tech.com\u003e\");\n2236:\tMODULE_DESCRIPTION(\"FTGMAC100 driver\");\n2237:\tMODULE_LICENSE(\"GPL\");\n"
} |
| 7/2 | 2026/10/15 07:44 | llm | patch-evaluator |
0mModel:gemini-3.8-flash Args: null Results: null Tokens: input: 12182 output: 20 thoughts: 1606 Thoughts: **My Analysis of ftgmac100's Fuzzability on amd64** Okay, so `ftgmac100_driver` relies solely on `of_match_table = ftgmac100_of_match`, there's no platform ID table for device names. The critical question is whether the OF device tree can even be loaded on amd64 for the Aspeed AST2400/AST2500/AST2600/AST2700 or Faraday FTGMAC100. I'm considering whether device tree overlays or syzkaller could instantiate these OF platform devices but my initial thought is, no, syzkaller runs in GCE or QEMU, the standard virtualized environments. According to the document in section 1 and 2, REACHABILITY IS KEY, the target has to be in standard virtualized environment. The changes has to be reachable to get fuzzed. If it is unreachable then it MUST NOT be fuzzed. It's a hard no if it's not the target architecture. Also, the code must not involve structurally unreachable hardware such as vendor-specific PCIe switches, or GPU drivers that require specific physical hardware not emulated in QEMU. The Faraday FTGMAC100 is an Ethernet MAC controller integrated into Aspeed BMC SoCs (AST2400, AST2500, AST2600, AST2700) and Faraday SoCs, which are ARM/ARM64. The Kconfig confirms this: `depends on ARM || ARM64 || COMPILE_TEST`. Specifically, AST2400/2500/2600 are 32-bit ARM SoCs and AST2700 is 64-bit ARM. This is an embedded platform device within an SoC! So, can an Aspeed MAC platform device be probed on amd64 within QEMU? No! QEMU emulates AST2400/AST2500/AST2600 machine types in `qemu-system-arm`, AST2700 in `qemu-system-aarch64`. On amd64 (`qemu-system-x86_64` / GCE x86_64), it's a standard PC. There's NO Aspeed SoC platform bus, no Device Tree on x86, and no memory-mapped registers for `ftgmac100`! Even if it could be, how could it be probed? Configfs device tree overlay on x86 won't work either. Even if I could load an OF overlay (which needs `CONFIG_OF_CONFIGFS`, which isn't usually present on x86), the platform device needs those specific physical memory resources (MMIO registers, interrupts) that *don't exist* on amd64. Touching `priv->base + ...` on amd64 without real hardware would lead to a mapping failure or immediate error. Let me look at `ftgmac100_probe`. It relies on `platform_get_resource`, `devm_ioremap_resource`, and `platform_get_irq`. Critically, it uses `of_match_node` with `ftgmac100_of_match`. It needs the OF node! Section 2 of the instructions clarifies this. We can't fuzz code if: * It's structurally unreachable hardware, like vendor-specific devices requiring physical hardware. * It is code paths exclusive to architectures other than the target architecture. And our target architecture is amd64! This is a *fundamental* architectural mismatch. The Kconfig confirms that neither ARM nor ARM64 is set on amd64; it only compiles with `COMPILE_TEST`. It's a Faraday/Aspeed ARM/ARM64 SoC platform driver, probed via Device Tree. So, I need to verify, just in case, that there is NO PCI or USB or virtual wrapper for `ftgmac100`. Let me grep the codebase for `ftgmac100`. Conclusion: `ftgmac100` is NOT fuzzeable in an amd64 QEMU/GCE environment. It's an ARM/ARM64 SoC platform device, completely unreachable on x86. |
| 8/2 | 2026/10/15 07:44 | tool | grepper |
0mArgs:{
"Expression": "ftgmac100"
}Results: {
"Output": "\nFull output is too long, showing 200 out of 785 lines.\nUse more precise expression or PathPrefixes if possible.\n\nNumber of matching lines per file (7 files in total):\nDocumentation/devicetree/bindings/net/faraday,ftgmac100.yaml:2\narch/arm/boot/dts/aspeed/aspeed-g4.dtsi:2\narch/arm/boot/dts/aspeed/aspeed-g5.dtsi:2\narch/arm/boot/dts/aspeed/aspeed-g6.dtsi:4\ndrivers/net/ethernet/faraday/Makefile:1\ndrivers/net/ethernet/faraday/ftgmac100.c:224\ndrivers/net/ethernet/faraday/ftgmac100.h:2\n\nDocumentation/devicetree/bindings/net/faraday,ftgmac100.yaml-3----\nDocumentation/devicetree/bindings/net/faraday,ftgmac100.yaml:4:$id: http://devicetree.org/schemas/net/faraday,ftgmac100.yaml#\nDocumentation/devicetree/bindings/net/faraday,ftgmac100.yaml-5-$schema: http://devicetree.org/meta-schemas/core.yaml#\n--\nDocumentation/devicetree/bindings/net/faraday,ftgmac100.yaml=12=properties:\n--\nDocumentation/devicetree/bindings/net/faraday,ftgmac100.yaml-14- oneOf:\nDocumentation/devicetree/bindings/net/faraday,ftgmac100.yaml:15: - const: faraday,ftgmac100\nDocumentation/devicetree/bindings/net/faraday,ftgmac100.yaml-16- - enum:\n--\narch/arm/boot/dts/aspeed/aspeed-g4.dtsi=131=\t\tmac0: ethernet@1e660000 {\narch/arm/boot/dts/aspeed/aspeed-g4.dtsi:132:\t\t\tcompatible = \"aspeed,ast2400-mac\", \"faraday,ftgmac100\";\narch/arm/boot/dts/aspeed/aspeed-g4.dtsi-133-\t\t\treg = \u003c0x1e660000 0x180\u003e;\n--\narch/arm/boot/dts/aspeed/aspeed-g4.dtsi=139=\t\tmac1: ethernet@1e680000 {\narch/arm/boot/dts/aspeed/aspeed-g4.dtsi:140:\t\t\tcompatible = \"aspeed,ast2400-mac\", \"faraday,ftgmac100\";\narch/arm/boot/dts/aspeed/aspeed-g4.dtsi-141-\t\t\treg = \u003c0x1e680000 0x180\u003e;\n--\narch/arm/boot/dts/aspeed/aspeed-g5.dtsi=149=\t\tmac0: ethernet@1e660000 {\narch/arm/boot/dts/aspeed/aspeed-g5.dtsi:150:\t\t\tcompatible = \"aspeed,ast2500-mac\", \"faraday,ftgmac100\";\narch/arm/boot/dts/aspeed/aspeed-g5.dtsi-151-\t\t\treg = \u003c0x1e660000 0x180\u003e;\n--\narch/arm/boot/dts/aspeed/aspeed-g5.dtsi=157=\t\tmac1: ethernet@1e680000 {\narch/arm/boot/dts/aspeed/aspeed-g5.dtsi:158:\t\t\tcompatible = \"aspeed,ast2500-mac\", \"faraday,ftgmac100\";\narch/arm/boot/dts/aspeed/aspeed-g5.dtsi-159-\t\t\treg = \u003c0x1e680000 0x180\u003e;\n--\narch/arm/boot/dts/aspeed/aspeed-g6.dtsi=242=\t\tmac0: ethernet@1e660000 {\narch/arm/boot/dts/aspeed/aspeed-g6.dtsi:243:\t\t\tcompatible = \"aspeed,ast2600-mac\", \"faraday,ftgmac100\";\narch/arm/boot/dts/aspeed/aspeed-g6.dtsi-244-\t\t\treg = \u003c0x1e660000 0x180\u003e;\n--\narch/arm/boot/dts/aspeed/aspeed-g6.dtsi=250=\t\tmac1: ethernet@1e680000 {\narch/arm/boot/dts/aspeed/aspeed-g6.dtsi:251:\t\t\tcompatible = \"aspeed,ast2600-mac\", \"faraday,ftgmac100\";\narch/arm/boot/dts/aspeed/aspeed-g6.dtsi-252-\t\t\treg = \u003c0x1e680000 0x180\u003e;\n--\narch/arm/boot/dts/aspeed/aspeed-g6.dtsi=258=\t\tmac2: ethernet@1e670000 {\narch/arm/boot/dts/aspeed/aspeed-g6.dtsi:259:\t\t\tcompatible = \"aspeed,ast2600-mac\", \"faraday,ftgmac100\";\narch/arm/boot/dts/aspeed/aspeed-g6.dtsi-260-\t\t\treg = \u003c0x1e670000 0x180\u003e;\n--\narch/arm/boot/dts/aspeed/aspeed-g6.dtsi=266=\t\tmac3: ethernet@1e690000 {\narch/arm/boot/dts/aspeed/aspeed-g6.dtsi:267:\t\t\tcompatible = \"aspeed,ast2600-mac\", \"faraday,ftgmac100\";\narch/arm/boot/dts/aspeed/aspeed-g6.dtsi-268-\t\t\treg = \u003c0x1e690000 0x180\u003e;\n--\ndrivers/net/ethernet/faraday/Makefile-5-\ndrivers/net/ethernet/faraday/Makefile:6:obj-$(CONFIG_FTGMAC100) += ftgmac100.o\ndrivers/net/ethernet/faraday/Makefile-7-obj-$(CONFIG_FTMAC100) += ftmac100.o\n--\ndrivers/net/ethernet/faraday/ftgmac100.c-32-\ndrivers/net/ethernet/faraday/ftgmac100.c:33:#include \"ftgmac100.h\"\ndrivers/net/ethernet/faraday/ftgmac100.c-34-\ndrivers/net/ethernet/faraday/ftgmac100.c:35:#define DRV_NAME\t\"ftgmac100\"\ndrivers/net/ethernet/faraday/ftgmac100.c-36-\ndrivers/net/ethernet/faraday/ftgmac100.c:37:enum ftgmac100_mac_id {\ndrivers/net/ethernet/faraday/ftgmac100.c-38-\tFTGMAC100_FARADAY = 1,\n--\ndrivers/net/ethernet/faraday/ftgmac100.c-47-\ndrivers/net/ethernet/faraday/ftgmac100.c:48:struct ftgmac100_match_data {\ndrivers/net/ethernet/faraday/ftgmac100.c:49:\tenum ftgmac100_mac_id mac_id;\ndrivers/net/ethernet/faraday/ftgmac100.c-50-\tu32 quirks;\n--\ndrivers/net/ethernet/faraday/ftgmac100.c=73=static struct fixed_phy_status ncsi_phy_status = {\n--\ndrivers/net/ethernet/faraday/ftgmac100.c-80-\ndrivers/net/ethernet/faraday/ftgmac100.c:81:struct ftgmac100 {\ndrivers/net/ethernet/faraday/ftgmac100.c-82-\t/* Registers */\n--\ndrivers/net/ethernet/faraday/ftgmac100.c-85-\ndrivers/net/ethernet/faraday/ftgmac100.c:86:\tenum ftgmac100_mac_id mac_id;\ndrivers/net/ethernet/faraday/ftgmac100.c-87-\tu32 quirks;\n--\ndrivers/net/ethernet/faraday/ftgmac100.c-90-\tunsigned int rx_q_entries;\ndrivers/net/ethernet/faraday/ftgmac100.c:91:\tstruct ftgmac100_rxdes *rxdes;\ndrivers/net/ethernet/faraday/ftgmac100.c-92-\tdma_addr_t rxdes_dma;\n--\ndrivers/net/ethernet/faraday/ftgmac100.c-98-\tunsigned int tx_q_entries;\ndrivers/net/ethernet/faraday/ftgmac100.c:99:\tstruct ftgmac100_txdes *txdes;\ndrivers/net/ethernet/faraday/ftgmac100.c-100-\tdma_addr_t txdes_dma;\n--\ndrivers/net/ethernet/faraday/ftgmac100.c-146-\ndrivers/net/ethernet/faraday/ftgmac100.c:147:static int ftgmac100_reset_mac(struct ftgmac100 *priv, u32 maccr)\ndrivers/net/ethernet/faraday/ftgmac100.c-148-{\n--\ndrivers/net/ethernet/faraday/ftgmac100.c-169-\ndrivers/net/ethernet/faraday/ftgmac100.c:170:static int ftgmac100_reset_and_config_mac(struct ftgmac100 *priv)\ndrivers/net/ethernet/faraday/ftgmac100.c-171-{\n--\ndrivers/net/ethernet/faraday/ftgmac100.c-214-\t/* The doc says reset twice with 10us interval */\ndrivers/net/ethernet/faraday/ftgmac100.c:215:\tif (ftgmac100_reset_mac(priv, maccr))\ndrivers/net/ethernet/faraday/ftgmac100.c-216-\t\treturn -EIO;\ndrivers/net/ethernet/faraday/ftgmac100.c-217-\tusleep_range(10, 1000);\ndrivers/net/ethernet/faraday/ftgmac100.c:218:\treturn ftgmac100_reset_mac(priv, maccr);\ndrivers/net/ethernet/faraday/ftgmac100.c-219-}\ndrivers/net/ethernet/faraday/ftgmac100.c-220-\ndrivers/net/ethernet/faraday/ftgmac100.c:221:static void ftgmac100_write_mac_addr(struct ftgmac100 *priv, const u8 *mac)\ndrivers/net/ethernet/faraday/ftgmac100.c-222-{\n--\ndrivers/net/ethernet/faraday/ftgmac100.c-229-\ndrivers/net/ethernet/faraday/ftgmac100.c:230:static int ftgmac100_initial_mac(struct ftgmac100 *priv)\ndrivers/net/ethernet/faraday/ftgmac100.c-231-{\n--\ndrivers/net/ethernet/faraday/ftgmac100.c-267-\ndrivers/net/ethernet/faraday/ftgmac100.c:268:static int ftgmac100_set_mac_addr(struct net_device *dev, void *p)\ndrivers/net/ethernet/faraday/ftgmac100.c-269-{\n--\ndrivers/net/ethernet/faraday/ftgmac100.c-276-\teth_commit_mac_addr_change(dev, p);\ndrivers/net/ethernet/faraday/ftgmac100.c:277:\tftgmac100_write_mac_addr(netdev_priv(dev), dev-\u003edev_addr);\ndrivers/net/ethernet/faraday/ftgmac100.c-278-\n--\ndrivers/net/ethernet/faraday/ftgmac100.c-281-\ndrivers/net/ethernet/faraday/ftgmac100.c:282:static void ftgmac100_config_pause(struct ftgmac100 *priv)\ndrivers/net/ethernet/faraday/ftgmac100.c-283-{\n--\ndrivers/net/ethernet/faraday/ftgmac100.c-298-\ndrivers/net/ethernet/faraday/ftgmac100.c:299:static void ftgmac100_init_hw(struct ftgmac100 *priv)\ndrivers/net/ethernet/faraday/ftgmac100.c-300-{\n--\ndrivers/net/ethernet/faraday/ftgmac100.c-327-\t/* Write MAC address */\ndrivers/net/ethernet/faraday/ftgmac100.c:328:\tftgmac100_write_mac_addr(priv, priv-\u003enetdev-\u003edev_addr);\ndrivers/net/ethernet/faraday/ftgmac100.c-329-\n--\ndrivers/net/ethernet/faraday/ftgmac100.c-366-\ndrivers/net/ethernet/faraday/ftgmac100.c:367:static void ftgmac100_start_hw(struct ftgmac100 *priv)\ndrivers/net/ethernet/faraday/ftgmac100.c-368-{\n--\ndrivers/net/ethernet/faraday/ftgmac100.c-412-\ndrivers/net/ethernet/faraday/ftgmac100.c:413:static void ftgmac100_stop_hw(struct ftgmac100 *priv)\ndrivers/net/ethernet/faraday/ftgmac100.c-414-{\n--\ndrivers/net/ethernet/faraday/ftgmac100.c-417-\ndrivers/net/ethernet/faraday/ftgmac100.c:418:static void ftgmac100_calc_mc_hash(struct ftgmac100 *priv)\ndrivers/net/ethernet/faraday/ftgmac100.c-419-{\n--\ndrivers/net/ethernet/faraday/ftgmac100.c-434-\ndrivers/net/ethernet/faraday/ftgmac100.c:435:static void ftgmac100_set_rx_mode(struct net_device *netdev)\ndrivers/net/ethernet/faraday/ftgmac100.c-436-{\ndrivers/net/ethernet/faraday/ftgmac100.c:437:\tstruct ftgmac100 *priv = netdev_priv(netdev);\ndrivers/net/ethernet/faraday/ftgmac100.c-438-\ndrivers/net/ethernet/faraday/ftgmac100.c-439-\t/* Setup the hash filter */\ndrivers/net/ethernet/faraday/ftgmac100.c:440:\tftgmac100_calc_mc_hash(priv);\ndrivers/net/ethernet/faraday/ftgmac100.c-441-\n--\ndrivers/net/ethernet/faraday/ftgmac100.c-450-\t/* Reconfigure MACCR */\ndrivers/net/ethernet/faraday/ftgmac100.c:451:\tftgmac100_start_hw(priv);\ndrivers/net/ethernet/faraday/ftgmac100.c-452-}\ndrivers/net/ethernet/faraday/ftgmac100.c-453-\ndrivers/net/ethernet/faraday/ftgmac100.c:454:static int ftgmac100_alloc_rx_buf(struct ftgmac100 *priv, unsigned int entry,\ndrivers/net/ethernet/faraday/ftgmac100.c:455:\t\t\t\t struct ftgmac100_rxdes *rxdes, gfp_t gfp)\ndrivers/net/ethernet/faraday/ftgmac100.c-456-{\n--\ndrivers/net/ethernet/faraday/ftgmac100.c-501-\ndrivers/net/ethernet/faraday/ftgmac100.c:502:static unsigned int ftgmac100_next_rx_pointer(struct ftgmac100 *priv,\ndrivers/net/ethernet/faraday/ftgmac100.c-503-\t\t\t\t\t unsigned int pointer)\n--\ndrivers/net/ethernet/faraday/ftgmac100.c-507-\ndrivers/net/ethernet/faraday/ftgmac100.c:508:static void ftgmac100_rx_packet_error(struct ftgmac100 *priv, u32 status)\ndrivers/net/ethernet/faraday/ftgmac100.c-509-{\n--\ndrivers/net/ethernet/faraday/ftgmac100.c-523-\ndrivers/net/ethernet/faraday/ftgmac100.c:524:static bool ftgmac100_rx_packet(struct ftgmac100 *priv, int *processed)\ndrivers/net/ethernet/faraday/ftgmac100.c-525-{\ndrivers/net/ethernet/faraday/ftgmac100.c-526-\tstruct net_device *netdev = priv-\u003enetdev;\ndrivers/net/ethernet/faraday/ftgmac100.c:527:\tstruct ftgmac100_rxdes *rxdes;\ndrivers/net/ethernet/faraday/ftgmac100.c-528-\tstruct sk_buff *skb;\n--\ndrivers/net/ethernet/faraday/ftgmac100.c-569-\t\tif (status \u0026 RXDES0_ANY_ERROR) {\ndrivers/net/ethernet/faraday/ftgmac100.c:570:\t\t\tftgmac100_rx_packet_error(priv, status);\ndrivers/net/ethernet/faraday/ftgmac100.c-571-\t\t\tgoto drop;\n--\ndrivers/net/ethernet/faraday/ftgmac100.c-579-\tif (!unlikely(skb)) {\ndrivers/net/ethernet/faraday/ftgmac100.c:580:\t\tftgmac100_alloc_rx_buf(priv, pointer, rxdes, GFP_ATOMIC);\ndrivers/net/ethernet/faraday/ftgmac100.c-581-\t\tgoto drop;\n--\ndrivers/net/ethernet/faraday/ftgmac100.c-630-\t/* Resplenish rx ring */\ndrivers/net/ethernet/faraday/ftgmac100.c:631:\tftgmac100_alloc_rx_buf(priv, pointer, rxdes, GFP_ATOMIC);\ndrivers/net/ethernet/faraday/ftgmac100.c:632:\tpriv-\u003erx_pointer = ftgmac100_next_rx_pointer(priv, pointer);\ndrivers/net/ethernet/faraday/ftgmac100.c-633-\n--\ndrivers/net/ethernet/faraday/ftgmac100.c-650-\trxdes-\u003erxdes0 = cpu_to_le32(status \u0026 priv-\u003erxdes0_edorr_mask);\ndrivers/net/ethernet/faraday/ftgmac100.c:651:\tpriv-\u003erx_pointer = ftgmac100_next_rx_pointer(priv, pointer);\ndrivers/net/ethernet/faraday/ftgmac100.c-652-\tnetdev-\u003estats.rx_dropped++;\n--\ndrivers/net/ethernet/faraday/ftgmac100.c-655-\ndrivers/net/ethernet/faraday/ftgmac100.c:656:static u32 ftgmac100_base_tx_ctlstat(struct ftgmac100 *priv,\ndrivers/net/ethernet/faraday/ftgmac100.c-657-\t\t\t\t unsigned int index)\n--\ndrivers/net/ethernet/faraday/ftgmac100.c-664-\ndrivers/net/ethernet/faraday/ftgmac100.c:665:static unsigned int ftgmac100_next_tx_pointer(struct ftgmac100 *priv,\ndrivers/net/ethernet/faraday/ftgmac100.c-666-\t\t\t\t\t unsigned int pointer)\n--\ndrivers/net/ethernet/faraday/ftgmac100.c-670-\ndrivers/net/ethernet/faraday/ftgmac100.c:671:static u32 ftgmac100_tx_buf_avail(struct ftgmac100 *priv)\ndrivers/net/ethernet/faraday/ftgmac100.c-672-{\n--\ndrivers/net/ethernet/faraday/ftgmac100.c-676-\t * worry about empty vs. full, and this simplifies the\ndrivers/net/ethernet/faraday/ftgmac100.c:677:\t * test for ftgmac100_tx_buf_cleanable() below\ndrivers/net/ethernet/faraday/ftgmac100.c-678-\t */\n--\ndrivers/net/ethernet/faraday/ftgmac100.c-682-\ndrivers/net/ethernet/faraday/ftgmac100.c:683:static bool ftgmac100_tx_buf_cleanable(struct ftgmac100 *priv)\ndrivers/net/ethernet/faraday/ftgmac100.c-684-{\n--\n\n"
} |
| 9/2 | 2026/10/15 07:44 | llm | patch-evaluator |
0mModel:gemini-3.8-flash Args: null Results: null Tokens: input: 20614 output: 138 thoughts: 820 Thoughts: **WorthFuzzing Evaluation: ftgmac100.c and Associated Files** Okay, let's break this down. My analysis indicates that `ftgmac100.c` and the related files are exclusively relevant to Faraday and ASPEED BMC SoCs. Specifically, these are ARM and ARM64-based systems (AST2400, AST2500, AST2600, AST2700), not x86_64, which is the target architecture. The code itself is a platform driver, matching based on Open Firmware / Device Tree compatible strings for these specific SoCs. This means it relies on device tree information and memory-mapped I/O that is fundamentally absent and not emulated in a standard amd64 environment. The Kconfig modifications confirm architecture-specific dependencies (ARM, ARM64, and a COMPILE_TEST). Given the criteria in Section 2, this clearly falls under "Structurally unreachable hardware" and "Code paths exclusive to architectures other than the target architecture." The driver's operation is inextricably linked to the physical presence of this specific hardware, or at least a highly accurate emulation of it, and this is not achievable on the target architecture. Therefore, `WorthFuzzing` must be set to `false`. There are no other considerations that would make fuzzing this code worthwhile on the amd64 architecture. The code simply won't execute, and thus cannot be fuzzed in a meaningful way. I'm confident in setting: * `WorthFuzzing: false` * `EnableConfigs: []` * `FocusSymbols: []` * `Reasoning: Concise explanation of why it is not worth fuzzing on amd64.` This assessment aligns perfectly with the guidelines, and all aspects have been carefully considered and verified. |
| 10/2 | 2026/10/15 07:45 | tool | set-results |
0mArgs:{
"EnableConfigs": [],
"FocusSymbols": [],
"Reasoning": "The patch series adds support for the ASPEED AST2700 SoC to the Faraday FTGMAC100 Ethernet driver, updating DeviceTree bindings, Kconfig, and the driver logic for 35-bit DMA and RMII enable. The FTGMAC100 driver is an SoC platform driver for ARM/ARM64 ASPEED and Faraday architectures that probes via Device Tree. On the target amd64 architecture, this hardware is not present or emulated, making the modified code structurally unreachable.",
"WorthFuzzing": false
}Results: {
"EnableConfigs": null,
"FocusSymbols": [],
"Reasoning": "The patch series adds support for the ASPEED AST2700 SoC to the Faraday FTGMAC100 Ethernet driver, updating DeviceTree bindings, Kconfig, and the driver logic for 35-bit DMA and RMII enable. The FTGMAC100 driver is an SoC platform driver for ARM/ARM64 ASPEED and Faraday architectures that probes via Device Tree. On the target amd64 architecture, this hardware is not present or emulated, making the modified code structurally unreachable.",
"WorthFuzzing": false
} |
| 11/1 | 2026/10/15 07:45 | action | If |
0mArgs:{
"WorthFuzzing": false
}Results: null |
| Total Calls | Total Tokens | Avg Tokens | Total Duration (Seconds) | Avg Duration (Seconds) |
|---|
| Total Calls | Total Duration (Seconds) | Avg Duration (Seconds) |
|---|