| Seq | Timestamp | Type | Name | Duration |
|---|---|---|---|---|
| 0/0 | 2026/10/24 07:10 | flow | patch-triage |
2mArgs:null Results: {
"EnableConfigs": null,
"FocusSymbols": [],
"KMSANReasoning": "",
"NeedsKMSAN": false,
"Reasoning": "The patch modifies documentation and the vfio_ap driver in drivers/s390/crypto/, implementing live guest migration support for s390 AP devices. These files and configs (CONFIG_VFIO_AP, CONFIG_S390) are exclusive to the s390 architecture and cannot be compiled or executed on the target architecture (amd64). Consequently, all modified executable paths are structurally unreachable on amd64.",
"WorthFuzzing": false
} |
| 1/1 | 2026/10/24 07:10 | action | read-patch-diff |
0mArgs:null Results: {
"PatchDiff": "commit d3532194b313f1184bbcee2279afd0ce7dcbbbd9\nAuthor: syz-cluster \u003ctriage@syzkaller.com\u003e\nDate: Sat Oct 24 07:10:26 2026 +0000\n\n syz-cluster: applied patch under review\n\ndiff --git a/Documentation/arch/s390/vfio-ap.rst b/Documentation/arch/s390/vfio-ap.rst\nindex ac0c07f76ddd7..f5d9e32875035 100644\n--- a/Documentation/arch/s390/vfio-ap.rst\n+++ b/Documentation/arch/s390/vfio-ap.rst\n@@ -1012,7 +1012,7 @@ guest_matrix dyn ap_config\n \n the following features are advertised:\n \n----------------+---------------------------------------------------------------+\n++--------------+---------------------------------------------------------------+\n | Flag | Description |\n +==============+===============================================================+\n | guest_matrix | guest_matrix attribute exists. It reports the matrix of |\n@@ -1021,105 +1021,548 @@ the following features are advertised:\n +--------------+---------------------------------------------------------------+\n | dyn | Indicates hot plug/unplug of AP adapters, domains and control |\n | | domains for a guest to which the mdev is attached. |\n-+------------+-----------------------------------------------------------------+\n++--------------+---------------------------------------------------------------+\n | ap_config | ap_config interface for one-shot modifications to mdev config |\n +--------------+---------------------------------------------------------------+\n+| migration | Indicates that live guest migration is supported for guests |\n+| | to which crypto devices are passed through |\n++--------------+---------------------------------------------------------------+\n \n-Limitations\n-===========\n-Live guest migration is not supported for guests using AP devices without\n-intervention by a system administrator. Before a KVM guest can be migrated,\n-the vfio_ap mediated device must be removed. Unfortunately, it can not be\n-removed manually (i.e., echo 1 \u003e /sys/devices/vfio_ap/matrix/$UUID/remove) while\n-the mdev is in use by a KVM guest. If the guest is being emulated by QEMU,\n-its mdev can be hot unplugged from the guest in one of two ways:\n-\n-1. If the KVM guest was started with libvirt, you can hot unplug the mdev via\n- the following commands:\n-\n- virsh detach-device \u003cguestname\u003e \u003cpath-to-device-xml\u003e\n-\n- For example, to hot unplug mdev 62177883-f1bb-47f0-914d-32a22e3a8804 from\n- the guest named 'my-guest':\n-\n- virsh detach-device my-guest ~/config/my-guest-hostdev.xml\n-\n- The contents of my-guest-hostdev.xml:\n-\n-.. code-block:: xml\n-\n- \u003chostdev mode='subsystem' type='mdev' managed='no' model='vfio-ap'\u003e\n- \u003csource\u003e\n- \u003caddress uuid='62177883-f1bb-47f0-914d-32a22e3a8804'/\u003e\n- \u003c/source\u003e\n- \u003c/hostdev\u003e\n-\n-\n- virsh qemu-monitor-command \u003cguest-name\u003e --hmp \"device-del \u003cdevice-id\u003e\"\n-\n- For example, to hot unplug the vfio_ap mediated device identified on the\n- qemu command line with 'id=hostdev0' from the guest named 'my-guest':\n-\n-.. code-block:: sh\n-\n- virsh qemu-monitor-command my-guest --hmp \"device_del hostdev0\"\n-\n-2. A vfio_ap mediated device can be hot unplugged by attaching the qemu monitor\n- to the guest and using the following qemu monitor command:\n-\n- (QEMU) device-del id=\u003cdevice-id\u003e\n-\n- For example, to hot unplug the vfio_ap mediated device that was specified\n- on the qemu command line with 'id=hostdev0' when the guest was started:\n-\n- (QEMU) device-del id=hostdev0\n-\n-After live migration of the KVM guest completes, an AP configuration can be\n-restored to the KVM guest by hot plugging a vfio_ap mediated device on the target\n-system into the guest in one of two ways:\n-\n-1. If the KVM guest was started with libvirt, you can hot plug a matrix mediated\n- device into the guest via the following virsh commands:\n-\n- virsh attach-device \u003cguestname\u003e \u003cpath-to-device-xml\u003e\n-\n- For example, to hot plug mdev 62177883-f1bb-47f0-914d-32a22e3a8804 into\n- the guest named 'my-guest':\n-\n- virsh attach-device my-guest ~/config/my-guest-hostdev.xml\n-\n- The contents of my-guest-hostdev.xml:\n-\n-.. code-block:: xml\n-\n- \u003chostdev mode='subsystem' type='mdev' managed='no' model='vfio-ap'\u003e\n- \u003csource\u003e\n- \u003caddress uuid='62177883-f1bb-47f0-914d-32a22e3a8804'/\u003e\n- \u003c/source\u003e\n- \u003c/hostdev\u003e\n-\n-\n- virsh qemu-monitor-command \u003cguest-name\u003e --hmp \\\n- \"device_add vfio-ap,sysfsdev=\u003cpath-to-mdev\u003e,id=\u003cdevice-id\u003e\"\n-\n- For example, to hot plug the vfio_ap mediated device\n- 62177883-f1bb-47f0-914d-32a22e3a8804 into the guest named 'my-guest' with\n- device-id hostdev0:\n-\n- virsh qemu-monitor-command my-guest --hmp \\\n- \"device_add vfio-ap,\\\n- sysfsdev=/sys/devices/vfio_ap/matrix/62177883-f1bb-47f0-914d-32a22e3a8804,\\\n- id=hostdev0\"\n-\n-2. A vfio_ap mediated device can be hot plugged by attaching the qemu monitor\n- to the guest and using the following qemu monitor command:\n-\n- (qemu) device_add \"vfio-ap,sysfsdev=\u003cpath-to-mdev\u003e,id=\u003cdevice-id\u003e\"\n-\n- For example, to plug the vfio_ap mediated device\n- 62177883-f1bb-47f0-914d-32a22e3a8804 into the guest with the device-id\n- hostdev0:\n+Live Guest Migration\n+====================\n+The VFIO AP mediated device is not used to provide userspace with direct\n+access to device memory as is the case with other devices that use the VFIO\n+framework for device pass-through. Instead, it manages AP\n+configuration metadata identifying the adapters, domains, and control\n+domains to which a guest will be granted access. These AP resources are\n+configured by assigning them to a vfio-ap mediated device via its sysfs\n+assignment interfaces. When the guest is started, the vfio_ap device driver\n+sets the guest's AP configuration from the metadata stored with the mediated\n+device. The AP devices are not accessed directly through the vfio_ap driver,\n+so the driver does not migrate the state of the AP devices themselves.\n+Instead, it migrates the AP configuration metadata. The vfio_ap device\n+driver on the destination host will then ensure that the AP configuration\n+metadata migrated from the source host is compatible with the AP\n+configuration available on the destination host and if\n+so, will set the destination guest's AP configuration accordingly.\n \n- (QEMU) device-add \"vfio-ap,\\\n- sysfsdev=/sys/devices/vfio_ap/matrix/62177883-f1bb-47f0-914d-32a22e3a8804,\\\n- id=hostdev0\"\n+To be considered compatible, the AP configuration for the destination host must\n+meet these requirements:\n+\n+* Each AP adapter, domain and control domain number assigned to the source\n+ guest's AP configuration must be in the destination host's AP\n+ configuration. This can be verified as follows:\n+\n+ * On the source host, display the AP configuration of the source guest\n+ with the following two commands:\n+\n+ .. code-block:: bash\n+\n+ cat /sys/devices/vfio_ap/matrix/$UUID/guest_matrix\n+ cat /sys/devices/vfio_ap/matrix/$UUID/control_domains\n+\n+ .. note::\n+ Replace ``$UUID`` with the actual UUID of your mediated device.\n+\n+ The ``guest_matrix`` lists the APQNs of the queue devices assigned\n+ to the mediated device; for example:\n+\n+ .. code-block:: bash\n+\n+ 00.0033\n+ 00.003a\n+\n+ The ``control_domains`` lists the domain numbers of the control\n+ domains; for example:\n+\n+ .. code-block:: bash\n+\n+ 0033\n+ 003a\n+\n+ * Display the AP configuration of the destination host with the following\n+ two commands:\n+\n+ .. code-block:: bash\n+\n+ lszcrypt -V\n+ cat /sys/bus/ap/ap_control_domain_mask\n+\n+ .. note::\n+ The ``lszcrypt -V`` command lists the AP cards (adapters) and queue\n+ devices on the host system; for example:\n+\n+ .. code-block:: bash\n+\n+ =========== ===== ============ ==========\n+ CARD.DOMAIN TYPE MODE DRIVER\n+ =========== ===== ============ ==========\n+ 00 CEX5C CCA-Coproc cex4card\n+ 00.0033 CEX5C CCA-Coproc vfio_ap\n+ 00.003a CEX5C CCA-Coproc vfio_ap\n+ =========== ===== ============ ==========\n+\n+ Each bit in the ap_control_domain_mask corresponds to\n+ domain numbers 0-255. If a bit is set to one, then\n+ the control domain is available on the destination host. For\n+ example:\n+\n+ .. code-block:: bash\n+\n+ 0x0000000000001020000000000000000000000000000000000000000000000000\n+\n+ This mask indicates that AP control domains 51 (0x33) and 58 (0x3a) are\n+ in the AP configuration of the host system.\n+\n+ * Verify the configurations:\n+\n+ * Each APQN in the guest's sysfs ``guest_matrix`` file must match an\n+ APQN returned from the ``lszcrypt -V`` command on the destination host. It\n+ is important to note the driver to which the queue is bound which\n+ is displayed in the ``driver`` column. Queues not bound to the vfio_ap\n+ driver are not available to the destination guest. Even if the APQNs are\n+ available to the driver, that does not guarantee they can be used by the\n+ guest being migrated; for example, migration will fail if any of these APQNs\n+ are assigned to a mediated device other than the one being migrated.\n+\n+ * Each domain number from the source guest's sysfs\n+ ``control_domains`` attribute must correspond to a bit set to one in\n+ the destination host's ``ap_control_domain_mask``.\n+\n+\n+* Each APQN assigned to the source guest and destination guest must\n+ reference a queue device with compatible hardware capabilities:\n+\n+ +--------------+---------------------------------------------------------------+\n+ | Hardware | Description |\n+ | Capabilities | |\n+ +==============+===============================================================+\n+ | [1] | * AP special command facility (APSC) |\n+ | Facilities | * AP 4096-bit ME PKU commands facility (AP4KM) |\n+ | | * AP 4096-bit CRT PKU commands (AP4KC) |\n+ +--------------+---------------------------------------------------------------+\n+ | [1] Mode | * CCA-mode |\n+ | | * Accelerator-mode |\n+ | | * XCP-mode (EP11) |\n+ +--------------+---------------------------------------------------------------+\n+ | [1] AP | APXA installed |\n+ | extended | |\n+ | addressing | |\n+ +--------------+---------------------------------------------------------------+\n+ | [1] Command | Command filtering available |\n+ | filtering | |\n+ +--------------+---------------------------------------------------------------+\n+ | [2] | * Full native card function |\n+ | Functional | * Only stateless functions |\n+ | capabilities | |\n+ +--------------+---------------------------------------------------------------+\n+ | [3] AP type | * 10 (0x0a): CEX4 |\n+ | | * 11 (0x0b): CEX5 |\n+ | | * 12 (0x0c) CEX6 |\n+ | | * 13 (0x0d) CEX7 |\n+ | | * 14 (0x0e) CEX8 |\n+ +--------------+---------------------------------------------------------------+\n+\n+ +-----------------------------------------------------------------------------+\n+ | Table Keys |\n+ +=============================================================================+\n+ | |\n+ | [1] The hardware capability must be the same for both the source |\n+ | and destination queue device. |\n+ | |\n+ | [2] The source and destination queues must either both have |\n+ | full native card function or both have stateless functions. |\n+ | If the functional capabilities don't match, then the source |\n+ | queue can have stateless capabilities since full native card |\n+ | function can handle stateless functions; otherwise, migration |\n+ | will fail. |\n+ | |\n+ | [3] The AP type on the source and destination guests can |\n+ | differ if the queue passed through to the target guest is a |\n+ | newer model (backwards compatible) |\n+ +-----------------------------------------------------------------------------+\n+\n+ * To verify the hardware capabilities are compatible:\n+\n+ * On both the source and destination hosts, display the hardware capabilities\n+ for each AP adapter in the AP configuration for that host:\n+\n+ .. code-block:: bash\n+\n+ cat /sys/bus/ap/devices/card$APID/ap_functions\n+\n+ .. note::\n+ The ``$APID`` is the two-character adapter number in hexadecimal format;\n+ for example, ``card02`` or ``card1f``. The ``/sys/bus/ap/devices`` directory\n+ also lists the APQNs of the queue devices installed in the respective\n+ host system with the first two characters being the APID; for example:\n+ ``02.0004`` or ``00.0033`` .\n+\n+ * Verify the hardware capabilities for each AP adapter device on the source\n+ and destination host are compatible. The ``ap_functions`` attribute is a\n+ bitmask. The bits in the mask read from left to right starting with bit 0.\n+ Each bit that is set to one indicates the corresponding hardware capability\n+ is installed:\n+\n+ * Bits 0-2 are the facilities bits. Each bit value must match for the AP\n+ devices on the source and destination systems. The values indicate the\n+ following:\n+\n+ * bit-0: APSC is installed\n+ * bit-1: AP4KM is installed\n+ * bit-2: AP4KC is installed\n+\n+ * Bits 3-5 specify the adapter Modes. Only one of these bits will be set to\n+ one and must be the same for both the source and destination adapter\n+ devices:\n+\n+ * bit-3: CCA-mode\n+ * bit-4: Accelerator-mode\n+ * bit-5: XCP-mode (EP11)\n+\n+ * Bit 6 specifies whether APXA is installed and must be the same for both\n+ the source and destination adapter devices.\n+\n+ * Bit 7 specifies whether command filtering is installed\n+ and must be the same for both the source and destination adapter devices.\n+\n+ * Bits 8-15 are the classification bits. There are only two relevant\n+ bits and only one of them will be set to one. For the source and destination\n+ adapter devices to be considered compatible:\n+\n+ * Bit 8 may be set to 1 on both hosts (full native card function)\n+ * Bit 9 may be set to 1 on both hosts (only stateless functions available)\n+ * Bit 9 may be set to 1 on the source host and bit 8 may be set to 1 on\n+ the destination host\n+\n+ * Bits 16-17 are the binding state bits which must be 00\n+\n+ * To verify the AP types are compatible:\n+\n+ * On both the source and destination hosts, display the hardware type\n+ for each AP adapter in the AP configuration for that host to ensure the\n+ source and destination adapter types are the same, or the source type is\n+ less than the destination type::\n+\n+ cat /sys/bus/ap/devices/card$APID/hwtype\n+\n+ .. note::\n+ The ``$APID`` is the two-character adapter number in hexadecimal format;\n+ for example, ``card02`` or ``card1f``.\n+\n+Setting up for live guest migration on the destination host\n+-----------------------------------------------------------\n+To set up a host as the destination for live guest migration, do the\n+following:\n+\n+1. Create a mediated device\n+~~~~~~~~~~~~~~~~~~~~~~~~~~~\n+Create a mediated device with the same name (UUID) as the mediated device\n+used to supply the AP configuration to the source guest. For example, if\n+the mediated device on the source guest is named\n+62177883-f1bb-47f0-914d-32a22e3a8804:\n+\n+.. code-block:: bash\n+\n+ echo 62177883-f1bb-47f0-914d-32a22e3a8804 \u003e \\\n+ /sys/devices/vfio_ap/matrix/mdev_supported_types/vfio_ap-passthrough/create\n+\n+2. Reserve adapters and domains for the vfio_ap device driver's use\n+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n+Reserve the same adapters and domains passed through to the source guest\n+for the vfio_ap device driver on the destination host by clearing the\n+adapter numbers from the ``/sys/bus/ap/apmask`` and/or the domain numbers\n+from the ``/sys/bus/ap/aqmask`` files.\n+\n+For example, suppose adapters 0, 20 (0x14) and 22 (0x16) as well as\n+domains 51 (0x33) and 58 (0x3a) are passed through to the source guest. To\n+ensure they can be passed through to the destination guest, they must be\n+made available to the vfio_ap device driver on the destination host. To\n+make them available, do one or both of the following on the destination host:\n+\n+.. code-block:: bash\n+\n+ echo -0,-0x14,-22 \u003e /sys/bus/ap/apmask\n+ echo -0,-0x33,-0x3a \u003e /sys/bus/ap/aqmask\n+\n+.. note::\n+\n+ * It is not necessary to reserve both the adapters and domains.\n+ Reserving an adapter implicitly allows the vfio_ap driver to assign\n+ each of the domains available on the system along with the reserved\n+ adapters to a guest's AP configuration and vice versa.\n+\n+ * The Cartesian product of the adapters and domains reserved for the\n+ vfio_ap device driver identifies the APQNs of the AP queue devices to be\n+ bound to the vfio_ap device driver. If an APQN does not reference a\n+ queue device installed in the system at the time of live guest migration,\n+ the migration will fail.\n+\n+ * To verify that the queue devices are reserved for the vfio_ap\n+ device driver, issue the ``lszcrypt -V`` command and you should\n+ see ``vfio_ap`` in the ``DRIVER`` column of the output.\n+\n+3. Assign adapters, domains and control domains to the destination mediated device\n+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n+Assign the same adapters, domains and control domains to the destination\n+mediated device as are assigned to the source guest's mediated device. For\n+example, using the same adapters, domains and control domains from the\n+previous step:\n+\n+.. code-block:: bash\n+\n+ echo 0x0 \u003e /sys/devices/vfio_ap/matrix/62177883-f1bb-47f0-914d-32a22e3a8804/assign_adapter\n+ echo 0x14 \u003e /sys/devices/vfio_ap/matrix/62177883-f1bb-47f0-914d-32a22e3a8804/assign_adapter\n+ echo 0x16 \u003e /sys/devices/vfio_ap/matrix/62177883-f1bb-47f0-914d-32a22e3a8804/assign_adapter\n+ echo 0x33 \u003e /sys/devices/vfio_ap/matrix/62177883-f1bb-47f0-914d-32a22e3a8804/assign_domain\n+ echo 0x3a \u003e /sys/devices/vfio_ap/matrix/62177883-f1bb-47f0-914d-32a22e3a8804/assign_domain\n+\n+.. note::\n+\n+ * The destination mediated device must be configured with at least the\n+ adapters, domains and control domains that are actively in use by the\n+ source guest (i.e., present in the source mdev's AP configuration\n+ shadow). Migration will fail if any APQN or control domain from the\n+ source guest's AP configuration is not present in the destination\n+ mdev's AP configuration shadow.\n+\n+ * The destination mediated device may be configured with a superset of\n+ the source guest's active AP configuration. Any additionally assigned\n+ resources that are available on the destination host will be accessible\n+ to the guest after migration completes.\n+\n+Live guest migration failures due to AP configuration errors\n+------------------------------------------------------------\n+This section describes the errors that may occur during live guest migration\n+when the AP configuration of the source guest and destination host are not\n+compatible and where to look for problem determination.\n+\n+The destination host is missing the mediated device\n+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n+\n+This error occurs when a mediated device with the same name (UUID) as the\n+mediated device being migrated has not been created on the destination host.\n+\n+**Source host**\n+\n++--------------+----------------------------------------------------------------+\n+| Log | Message |\n++==============+================================================================+\n+| Console log: | error: device not found: mediated device '$UUID' not |\n+| | found |\n++--------------+----------------------------------------------------------------+\n+| QEMU log: | initiating migration |\n+| | qemu-system-s390x: Sibling indicated error 1 |\n++--------------+----------------------------------------------------------------+\n+\n+.. note::\n+ $UUID is the UUID of the mediated device being migrated from the source host.\n+\n+\n+One or more queues are not bound to the vfio_ap driver on the destination host\n+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n+The queue devices passed through to the source guest are not installed in the\n+destination host or are not bound to its vfio_ap device driver.\n+\n+**Source host**\n+\n++--------------+----------------------------------------------------------------+\n+| Log | Message |\n++==============+================================================================+\n+| Console log: | error: operation failed: migration failed. Message from the |\n+| | source host: operation failed: job 'migration out' failed: |\n+| | Sibling indicated error 1. Message from the destination host: |\n+| | operation failed: job 'migration in' failed: load of migration |\n+| | failed: No such device: Failed to load vmstate version_id: 1, |\n+| | ret: -19 |\n++--------------+----------------------------------------------------------------+\n+\n+**Destination host**\n+\n++--------------+----------------------------------------------------------------+\n+| Kernel log: | vfio_ap_mdev $UUID: Queue $APID.$APQI not available to |\n+| | vfio_ap driver on target host |\n++--------------+----------------------------------------------------------------+\n+| QEMU log: | shutting down, reason=failed |\n+| | qemu-system-s390x: terminating on signal $SIGNAL_NUM from |\n+| | pid $PID $DAEMON |\n++--------------+----------------------------------------------------------------+\n+\n+\n+One or more control domains are not available on the destination host\n+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n+The control domains passed through to the source guest are not installed on the\n+destination host.\n+\n+**Source host**\n+\n++--------------+----------------------------------------------------------------+\n+| Log | Message |\n++==============+================================================================+\n+| Console log: | error: operation failed: migration failed. Message from the |\n+| | source host: operation failed: job 'migration out' failed: |\n+| | Sibling indicated error 1. Message from the destination host: |\n+| | operation failed: job 'migration in' failed: load of migration |\n+| | failed: No such device: Failed to load vmstate version_id: 1, |\n+| | ret: -19 |\n++--------------+----------------------------------------------------------------+\n+\n+**Destination host**\n+\n++--------------+----------------------------------------------------------------+\n+| Kernel log: | vfio_ap_mdev $UUID: Control domain $DOMAIN_NUM not available |\n+| | on the destination host |\n++--------------+----------------------------------------------------------------+\n+| QEMU log: | shutting down, reason=failed |\n+| | qemu-system-s390x: terminating on signal $SIGNAL_NUM from |\n+| | pid $PID $DAEMON |\n++--------------+----------------------------------------------------------------+\n+\n+\n+.. note::\n+ * $UUID is the UUID of the mediated device being migrated from the source host.\n+ * $APID.$APQI is adapter number and queue index (domain number) comprising the\n+ $APQN (for example, 00.0033) of the queue device that is not available.\n+ * $SIGNAL_NUM is the signal number that caused the QEMU process to terminate.\n+ * $PID is the process ID of the QEMU process on the destination host.\n+ * $DAEMON is the name of the QEMU daemon process.\n+ * This message will be logged for each queue for which this error is detected.\n+\n+Failure to get hardware information for a queue device on destination host\n+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n+The vfio_ap device driver on the destination host will execute an AP instruction\n+to get the hardware information for a queue device to perform queue compatibility\n+checks. The instruction can fail for a number of reasons in which case the\n+migration will be terminated.\n+\n+**Source host**\n+\n++--------------+----------------------------------------------------------------+\n+| Log | Message |\n++==============+================================================================+\n+| Console log: | error: operation failed: migration failed. Message from the |\n+| | source host: operation failed: job 'migration out' failed: |\n+| | Sibling indicated error 1. Message from the destination host: |\n+| | operation failed: job 'migration in' failed: load of migration |\n+| | failed: failed to get hardware information for queue device |\n+| | $APQN |\n++--------------+----------------------------------------------------------------+\n+\n+**Destination host**\n+\n++--------------+----------------------------------------------------------------+\n+| Log | Message |\n++==============+================================================================+\n+| Console log: | vfio_ap_mdev $UUID: Failed to get hwinfo for queue $APQN: |\n+| | TAPQ rc=$RESPONSE-CODE |\n++--------------+----------------------------------------------------------------+\n+| QEMU log: | shutting down, reason=failed |\n+| | qemu-system-s390x: terminating on signal $SIGNAL-ID from pid |\n+| | $PID $DAEMON |\n++--------------+----------------------------------------------------------------+\n+\n+.. note::\n+ * $UUID is the UUID of the mediated device being migrated from the source host.\n+ * $APQN (for example, 00.0033) of the queue device that is not compatible.\n+ * $RESPONSE_CODE is the response code from the AP instruction.\n+ * $SIGNAL_NUM is the signal number of the signal that caused the QEMU process\n+ to terminate.\n+ * $PID is the process ID of the QEMU process on the destination host.\n+ * $DAEMON is the name of the QEMU daemon process.\n+ * This message will be logged for each queue for which this error is detected.\n+\n+The AP configurations of the source guest and destination host not compatible\n+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n+The functional capabilities or facilities available on one or more of the queues\n+passed through to the source guest are not compatible with the queue device with\n+the same APQN on the destination system (see the Hardware Capabilities table above)\n+\n+**Source host**\n+\n++--------------+----------------------------------------------------------------+\n+| Log | Message |\n++==============+================================================================+\n+| Console log: | error: operation failed: migration failed. Message from the |\n+| | source host: operation failed: job 'migration out' failed: |\n+| | Sibling indicated error 1. Message from the destination host: |\n+| | operation failed: job 'migration in' failed: load of migration |\n+| | failed: Invalid argument: Failed to load vmstate |\n+| | version_id: 1, ret: -22 |\n++--------------+----------------------------------------------------------------+\n+| Kernel log: | N/A |\n++--------------+----------------------------------------------------------------+\n+| QEMU log: | *initiating migration* |\n+| | |\n+| | *qemu-system-s390x: Sibling indicated error 1* |\n++--------------+----------------------------------------------------------------+\n+\n+**Destination host**\n+\n++--------------+----------------------------------------------------------------+\n+| Log | Message |\n++==============+================================================================+\n+| Console log: | N/A |\n++--------------+----------------------------------------------------------------+\n+| Kernel log: | *vfio_ap_mdev $UUID: Migration failed: Source and target |\n+| | queue ($APQN) not compatible* |\n+| | |\n+| | The message above will be followed by one or more messages |\n+| | enumerating the incompatible features; for example: |\n+| | |\n+| | ``vfio_ap_mdev $UUID: APSC facility installed in source queue |\n+| | $APQN`` |\n+| | ``vfio_ap_mdev $UUID: APSC facility not installed in target |\n+| | queue $APQN`` |\n+| | |\n+| | ``vfio_ap_mdev $UUID: AP type of source queue $APQN ($APTYPE1) |\n+| | not compatible with target ($APTYPE2)`` ... |\n++--------------+----------------------------------------------------------------+\n+| QEMU log: | *initiating migration* |\n+| | |\n+| | *qemu-system-s390x: error while loading state section id ...* |\n+| | |\n+| | *shutting down, reason=failed* |\n+| | |\n+| | *terminating on signal $SIGNAL-ID from pid $PID $DAEMON* |\n++--------------+----------------------------------------------------------------+\n+\n+.. note::\n+ * $UUID is the UUID of the mediated device being migrated from the source host.\n+ * $APQN (for example, 00.0033) of the queue device that is incompatible.\n+ * $APTYPE1 is the type of the source queue device.\n+ * $APTYPE2 is the type of the target queue device.\n+ * $SIGNAL-ID is the signal number of the signal that caused the QEMU process\n+ to terminate.\n+ * $PROCESS-ID is the process ID of the QEMU process on the source host.\n+ * $PID is the process ID of the QEMU process on the destination host.\n+ * $DAEMON is the name of the QEMU daemon process.\n+ * Each follow-on message logging the incompatibility will be logged for each\n+ error detected for the specified queue device.\n+\n+AP Configuration Management\n+---------------------------\n+The AP configurations of the source guest and destination host must be kept\n+in synchronization or live guest migration will likely fail due to potential\n+incompatibilities introduced by such changes. In particular, changing adapter\n+or domain reservations via the sysfs ``apmask`` or ``aqmask`` attributes on\n+either the source or destination host without coordinating such changes between\n+the two hosts -especially while a migration is taking place - can result in\n+migration failures.\n+\n+Configuration stability is an orchestration-layer or system administrator\n+responsibility, which is consistent with other VFIO device types. The vfio_ap\n+device driver will validate source and destination configurations and provide\n+clear diagnostics when incompatibilities are detected, enabling orchestration\n+tools to implement appropriate policies; for example, blocking migration when\n+such changes are to be made.\n+\n+Master Key administration\n+--------------------------\n+It is imperative that s390 Common Cryptographic Architecture (CCA) master key\n+administration be performed on both the source and destination AP\n+devices to synchronize the key values prior to allowing live guest\n+migration. If the master keys do not match, then crypto applications that\n+rely on secure keys wrapped by a CCA master key will fail when the guest on\n+which they are running is migrated to the destination host. Again, this is\n+an orchestration-layer or system administrator responsibility and migration must\n+be blocked while master key administration is being performed.\ndiff --git a/drivers/s390/crypto/Makefile b/drivers/s390/crypto/Makefile\nindex e83c6603c8587..20f29184825a7 100644\n--- a/drivers/s390/crypto/Makefile\n+++ b/drivers/s390/crypto/Makefile\n@@ -34,5 +34,5 @@ pkey-uv-objs := pkey_uv.o\n obj-$(CONFIG_PKEY_UV) += pkey-uv.o\n \n # adjunct processor matrix\n-vfio_ap-objs := vfio_ap_drv.o vfio_ap_ops.o\n+vfio_ap-objs := vfio_ap_drv.o vfio_ap_ops.o vfio_ap_migration.o\n obj-$(CONFIG_VFIO_AP) += vfio_ap.o\ndiff --git a/drivers/s390/crypto/vfio_ap_drv.c b/drivers/s390/crypto/vfio_ap_drv.c\nindex 8e69ed286bb9c..c63a050a23569 100644\n--- a/drivers/s390/crypto/vfio_ap_drv.c\n+++ b/drivers/s390/crypto/vfio_ap_drv.c\n@@ -26,9 +26,21 @@ MODULE_LICENSE(\"GPL v2\");\n struct ap_matrix_dev *matrix_dev;\n debug_info_t *vfio_ap_dbf_info;\n \n+#define VFIO_AP_BASE_FEATURES\t\"guest_matrix hotplug ap_config\"\n+#define VFIO_AP_SE_EXCLUDED_FEATURES \"migration\"\n+\n static ssize_t features_show(struct device *dev, struct device_attribute *attr, char *buf)\n {\n-\treturn sysfs_emit(buf, \"guest_matrix hotplug ap_config\\n\");\n+\t/*\n+\t * SE guests do not support live guest migration; emit only the base\n+\t * feature set for them.\n+\t */\n+\tif (ap_is_se_guest())\n+\t\treturn sysfs_emit(buf, \"%s\\n\", VFIO_AP_BASE_FEATURES);\n+\n+\t/* Non-SE: base features plus those not available on SE guests */\n+\treturn sysfs_emit(buf, \"%s %s\\n\", VFIO_AP_BASE_FEATURES,\n+\t\t\t VFIO_AP_SE_EXCLUDED_FEATURES);\n }\n static DEVICE_ATTR_RO(features);\n \ndiff --git a/drivers/s390/crypto/vfio_ap_migration.c b/drivers/s390/crypto/vfio_ap_migration.c\nnew file mode 100644\nindex 0000000000000..ac135872da2fa\n--- /dev/null\n+++ b/drivers/s390/crypto/vfio_ap_migration.c\n@@ -0,0 +1,1419 @@\n+// SPDX-License-Identifier: GPL-2.0\n+/*\n+ * Drives vfio_ap mdev migration.\n+ *\n+ * Copyright IBM Corp. 2025\n+ */\n+#include \u003clinux/anon_inodes.h\u003e\n+#include \u003clinux/file.h\u003e\n+#include \u003clinux/slab.h\u003e\n+#include \"vfio_ap_private.h\"\n+\n+/* Magic number and version for the vfio_ap_config migration blob */\n+#define VFIO_AP_MIG_MAGIC\t\t\t0x76666170U /* \"vfap\" */\n+#define VFIO_AP_MIG_VERSION\t\t\t1U\n+\n+/*\n+ * Masks the fields of the queue information returned from the PQAP(TAPQ)\n+ * command. In order to migrate a guest, it's AP configuration must be\n+ * compatible with AP configuration assigned to the target guest's mdev.\n+ * This mask is used to verify that the queue information for each source and\n+ * target queue is compatible.\n+ *\n+ * The following bits must match for the source device and the corresponding\n+ * destination device:\n+ * -------------------------------------------------------------------------\n+ * S bit 0: APSC facility installed\n+ * M bit 1: APQKM facility installed\n+ * C bit 2: AP4KC facility installed\n+ * Mode bits 3-5:\n+ * D bit 3: CCA-mode facility\n+ * A bit 4: accelerator-mode facility\n+ * X bit 5: XCP-mode facility\n+ * N bit 6: APXA facility installed\n+ * SL bit 7: SLCF facility installed\n+ *\n+ * Either bit 8 or bit 9 will be set. If bit 8 is set for the source device,\n+ * then it must also be set for the corresponding destination device:\n+ * -------------------------------------------------------------------------\n+ * Classification (functional capabilities) bits 8-15\n+ * bit 8: Native card function\n+ * bit 9: Only stateless functions\n+ *\n+ * The BS bits must be set to 0 for both the source and corresponding\n+ * destination device:\n+ * -------------------------------------------------------------------------\n+ * BS bits 16-17:\n+ *\n+ * The AP type of the source device must be less than or equal to that of\n+ * the corresponding destination device:\n+ * -------------------------------------------------------------------------\n+ * AP Type bits 32-39:\n+ */\n+#define QINFO_DATA_MASK\t\t0xffffc000ff000000\n+\n+/*\n+ * Masks the bit that indicates whether full native card function is available\n+ * from the 8 bits specifying the functional capabilities of a queue\n+ */\n+#define CLASSIFICATION_NATIVE_FCN_MASK\t\t0x80\n+\n+/* The maximum number of queues that can be installed in an s390 system */\n+#define MAX_AP_QUEUES\t\t\t\t(AP_DEVICES * AP_DOMAINS)\n+\n+/* The maximum size of a vfio_ap_config blob, used to pre-allocate the receive\n+ * buffer on the destination host during the RESUMING phase of migration.\n+ */\n+#define VFIO_AP_CONFIG_MAX_SIZE \\\n+\t(sizeof(struct vfio_ap_config) + \\\n+\t MAX_AP_QUEUES * sizeof(struct vfio_ap_queue_info))\n+\n+/**\n+ * struct vfio_ap_migration_file\n+ *\n+ * This object is used for chunk processing of multiple reads and writes of\n+ * AP configuration information.\n+ *\n+ * @filp:\tfile stream used to read or write AP configuration data\n+ * @ap_config:\tobject used to store AP configuration data between read or write\n+ *\t\tcalls\n+ * @config_sz:\tthe size (in bytes) of @ap_config\n+ */\n+struct vfio_ap_migration_file {\n+\tstruct file\t\t*filp;\n+\tstruct vfio_ap_config\t*ap_config;\n+\tunsigned long\t\tconfig_sz;\n+};\n+\n+/**\n+ * struct vfio_ap_migration_data:\n+ *\n+ * Manages the migration state for the VFIO device that maintains the AP\n+ * configuration of the guest being migrated.\n+ *\n+ * @mig_state:\t\t\tthe current migration state\n+ * @resuming_mig_data_complete:\tindicates whether a complete, valid AP\n+ *\t\t\t\tconfiguration blob was received (true) or not (false)\n+ *\t\t\t\tduring the RESUMING phase. This must be checked\n+ *\t\t\t\ton RESUMING-\u003eSTOP to enforce the vfio.h\n+ *\t\t\t\trequirement that SET_STATE must fail if the data\n+ *\t\t\t\tis incomplete or invalid.\n+ * @resuming_mig_file:\t\tthe object used to restore the state of the\n+ *\t\t\t\tvfio-ap device on the destination host.\n+ * @stop_copy_mig_file:\t\tthe object used to store the AP configuration of\n+ *\t\t\t\tthe source guest for transfer to the destination\n+ *\t\t\t\thost.\n+ */\n+struct vfio_ap_migration_data {\n+\tenum vfio_device_mig_state\tmig_state;\n+\tbool\t\t\t\tresuming_mig_data_complete;\n+\tstruct vfio_ap_migration_file\tresuming_mig_file;\n+\tstruct vfio_ap_migration_file\tstop_copy_mig_file;\n+};\n+\n+/**\n+ * struct vfio_ap_queue_info - the information for an AP queue\n+ *\n+ * @data: contains the queue information returned in GR2 from the PQAP(TAPQ)\n+ *\t command\n+ * @apqn: the APQN of the queue\n+ * @reserved: padding to ensure consistent structure size across platforms\n+ */\n+struct vfio_ap_queue_info {\n+\tu64 data;\n+\tu16 apqn;\n+\tu8 reserved[6];\n+};\n+\n+/**\n+ * struct vfio_ap_config:\n+ *\n+ * Stores the state of a guest's AP configuration.\n+ *\n+ * VFIO device migration state transition from STOP to STOP_COPY:\n+ * -------------------------------------------------------------\n+ * When the migration state transitions from STOP to STOP_COPY, the vfio_ap device\n+ * driver will open a file stream in read-only mode and return the fd to userspace.\n+ * This fd is used during the STOP_COPY phase to read the current state of the\n+ * vfio-ap device on the source host. In response, the driver will store the\n+ * source guest's AP configuration data in a vfio_ap_config object and copy it to\n+ * userspace.\n+ *\n+ * VFIO device migration state transition from STOP to RESUMING:\n+ * ------------------------------------------------------------\n+ * When the VFIO migration state transitions from STOP to RESUMING,\n+ * the vfio_ap device driver will open a file stream in write-only mode and\n+ * return the fd to userspace. This fd is used during the RESUMING phase to\n+ * write the source guest's vfio_ap_config data that was read in during the\n+ * STOP_COPY phase to the vfio_ap device driver on the destination host. In\n+ * response, the device driver will copy the data sent from userspace to a\n+ * vfio_ap_config instance which is then used to update the destination guest's\n+ * AP configuration.\n+ *\n+ * Since the source and destination hosts may be running different versions of\n+ * the linux kernel, the vfio_ap_config object provides two fields (@magic and\n+ * @version) which must be set by the source device driver and verified by the\n+ * destination device driver to ensure the migration ABI of the source and\n+ * destination hosts are compatible.\n+ *\n+ * Note: Since a guest's AP configuration could be comprised of a large number of\n+ *\t AP queue devices, a vfio_ap_config object should be allocated using\n+ *\t kvzalloc.\n+ *\n+ * @magic:\tidentifies this as a valid vfio_ap_config migration blob;\n+ *\t\tmust equal VFIO_AP_MIG_MAGIC\n+ * @version:\tlayout version; must equal VFIO_AP_MIG_VERSION\n+ * @num_queues:\tthe number of queues passed through to the guest\n+ * @reserved:\tpadding to ensure proper alignment of @adm\n+ * @adm:\tbitmap specifying the control domains in the AP configuration\n+ * @qinfo:\tan array of vfio_ap_queue_info objects, each specifying the\n+ *\t\tqueue information for a queue passed through to the guest\n+ */\n+struct vfio_ap_config {\n+\tu32\t\t\t\tmagic;\n+\tu32\t\t\t\tversion;\n+\tu32\t\t\t\tnum_queues;\n+\tu8\t\t\t\treserved[4];\n+\tu64\t\t\t\tadm[DIV_ROUND_UP(AP_DOMAINS, 64)];\n+\tstruct vfio_ap_queue_info\tqinfo[] __counted_by(num_queues);\n+};\n+\n+static void\n+vfio_ap_release_stop_copy_file(struct vfio_ap_migration_data *mig_data)\n+{\n+\tkvfree(mig_data-\u003estop_copy_mig_file.ap_config);\n+\tmig_data-\u003estop_copy_mig_file.ap_config = NULL;\n+\tmig_data-\u003estop_copy_mig_file.config_sz = 0;\n+\tmig_data-\u003estop_copy_mig_file.filp = NULL;\n+}\n+\n+static void vfio_ap_release_resuming_file(struct vfio_ap_migration_data *mig_data)\n+{\n+\tkvfree(mig_data-\u003eresuming_mig_file.ap_config);\n+\tmig_data-\u003eresuming_mig_file.ap_config = NULL;\n+\tmig_data-\u003eresuming_mig_file.config_sz = 0;\n+\tmig_data-\u003eresuming_mig_file.filp = NULL;\n+\tmig_data-\u003eresuming_mig_data_complete = false;\n+}\n+\n+static void vfio_ap_release_mig_files(struct ap_matrix_mdev *matrix_mdev);\n+\n+static int vfio_ap_release_mig_file(struct inode *file_inode, struct file *filp)\n+{\n+\tstruct ap_matrix_mdev *matrix_mdev = filp-\u003eprivate_data;\n+\n+\t/*\n+\t * The VFIO device lifetime is tied to migration FD lifetime (see\n+\t * vfio_ap_open_file_stream() function) to guarantee that the\n+\t * matrix_mdev remains valid for every read/write operation. Let's drop\n+\t * it here since the migration FD is being released.\n+\t */\n+\tvfio_device_put_registration(\u0026matrix_mdev-\u003evdev);\n+\treturn 0;\n+}\n+\n+static const struct vfio_migration_ops vfio_ap_migration_ops;\n+\n+/**\n+ * vfio_ap_setup_vfio_device_migration:\n+ *\n+ * Enable\n+ * Plug the object containing the function pointers to the migration callbacks\n+ * used to facilitate migration of a vfio-ap device.\n+ *\n+ *\n+ * @matrix_mdev: pointer to object containing the mdev state\n+ */\n+void vfio_ap_setup_vfio_device_migration(struct ap_matrix_mdev *matrix_mdev)\n+{\n+\t/*\n+\t * Live guest migration is not supported for SE guests, so there is no\n+\t * need to initialize the migration capabilities.\n+\t */\n+\tif (ap_is_se_guest())\n+\t\treturn;\n+\n+\tmatrix_mdev-\u003evdev.migration_flags = VFIO_MIGRATION_STOP_COPY;\n+\tmatrix_mdev-\u003evdev.mig_ops = \u0026vfio_ap_migration_ops;\n+}\n+\n+/**\n+ * validate_stop_copy_read_parms: Validate the input parameters to the\n+ * vfio_ap_stop_copy_read function\n+ *\n+ * @filp: Pointer to the file stream used to read the vfio-ap device state\n+ * @len: The length of the data to be read\n+ *\n+ * Verify the following:\n+ * - @filp private data is an ap_matrix_mdev instance\n+ * - @filp is the instance opened when state transitioned from STOP to STOP_COPY\n+ * - @filp-\u003ef_pos + @len does not cause integer overflow\n+ *\n+ * Returns: 0 if the parameters pass validation; otherwise returns an error\n+ */\n+static int validate_stop_copy_read_parms(struct file *filp, size_t len)\n+{\n+\tstruct vfio_ap_migration_data *mig_data;\n+\tstruct ap_matrix_mdev *matrix_mdev;\n+\tloff_t total_len;\n+\n+\tlockdep_assert_held(\u0026matrix_dev-\u003emdevs_lock);\n+\n+\tif (check_add_overflow((loff_t)len, filp-\u003ef_pos, \u0026total_len))\n+\t\treturn -EIO;\n+\n+\t/*\n+\t * matrix_mdev is guaranteed live here: vfio_ap_open_file_stream() took\n+\t * a vfio_device registration reference that is held until\n+\t * vfio_ap_release_mig_file() runs, so the embedding matrix_mdev cannot\n+\t * be freed while this file descriptor is open.\n+\t */\n+\tmatrix_mdev = filp-\u003eprivate_data;\n+\n+\tif (!matrix_mdev-\u003emig_data)\n+\t\treturn -ENODEV;\n+\n+\tmig_data = matrix_mdev-\u003emig_data;\n+\n+\tif (mig_data-\u003estop_copy_mig_file.filp != filp)\n+\t\treturn -EINVAL;\n+\n+\treturn 0;\n+}\n+\n+static size_t vfio_ap_config_size(struct ap_matrix_mdev *matrix_mdev,\n+\t\t\t\t unsigned int *num_queues)\n+{\n+\tsize_t qinfo_size;\n+\n+\tlockdep_assert_held(\u0026matrix_dev-\u003emdevs_lock);\n+\n+\t*num_queues = vfio_ap_mdev_get_num_queues(\u0026matrix_mdev-\u003eshadow_apcb);\n+\tqinfo_size = *num_queues * sizeof(struct vfio_ap_queue_info);\n+\n+\treturn qinfo_size + sizeof(struct vfio_ap_config);\n+}\n+\n+static int get_hardware_info_for_queue(const char *mdev_name,\n+\t\t\t\t struct ap_tapq_hwinfo *hwinfo,\n+\t\t\t\t unsigned long apqn)\n+{\n+\tstruct ap_queue_status status;\n+\n+\tstatus = ap_test_queue(apqn, 1, hwinfo);\n+\n+\tswitch (status.response_code) {\n+\tcase AP_RESPONSE_NORMAL:\n+\tcase AP_RESPONSE_RESET_IN_PROGRESS:\n+\tcase AP_RESPONSE_DECONFIGURED:\n+\tcase AP_RESPONSE_CHECKSTOPPED:\n+\tcase AP_RESPONSE_BUSY:\n+\t\t/* For all these RCs the tapq info should be available */\n+\t\tbreak;\n+\tdefault:\n+\t\tpr_err_ratelimited(\"vfio_ap_mdev %s: Failed to get hwinfo for queue %02lx.%04lx: TAPQ rc=%d\\n\",\n+\t\t\t\t mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn),\n+\t\t\t\t status.response_code);\n+\t\treturn -EIO;\n+\t}\n+\n+\t/* There should be at least one of the mode bits set */\n+\tif (!hwinfo-\u003evalue) {\n+\t\tpr_err_ratelimited(\"vfio_ap_mdev %s: Empty hwinfo for queue %02lx.%04lx: TAPQ rc=%d\\n\",\n+\t\t\t\t mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn),\n+\t\t\t\t status.response_code);\n+\t\treturn -EIO;\n+\t}\n+\n+\treturn 0;\n+}\n+\n+/**\n+ * vfio_ap_store_queue_info:\n+ *\n+ * Stores the hardware information returned from the PQAP(TAPQ) command for each\n+ * queue device identified in the 'qinfo' field of the a vfio_ap_config\n+ * object. The APQNs in the 'qinfo' field must already have been snapshotted\n+ * prior to calling this function.\n+ *\n+ * @mdev_name:\tThe name (UUID) of the mediated device to use in log messages\n+ * @ap_config:\tA reference to the vfio_ap_config instance in which to store\n+ *\t\tthe queue information. It is expected that each APQN identifying\n+ *\t\ta queue device for which hardware information is to be retrieved\n+ *\t\tshall be snapshotted prior to calling this function.\n+ *\n+ * Returns:\tZero (0) if the hardware information is retrieved for each queue\n+ *\t\tdevice in the AP configuration; otherwise, returns an error.\n+ */\n+static int vfio_ap_store_queue_info(const char *mdev_name,\n+\t\t\t\t struct vfio_ap_config *ap_config)\n+{\n+\tstruct ap_tapq_hwinfo source_hwinfo;\n+\tunsigned long num_queues;\n+\tint ret;\n+\n+\tfor (num_queues = 0; num_queues \u003c ap_config-\u003enum_queues; num_queues++) {\n+\t\tret = get_hardware_info_for_queue(mdev_name, \u0026source_hwinfo,\n+\t\t\t\t\t\t ap_config-\u003eqinfo[num_queues].apqn);\n+\t\tif (ret)\n+\t\t\treturn ret;\n+\n+\t\tap_config-\u003eqinfo[num_queues].data = source_hwinfo.value;\n+\t}\n+\n+\treturn 0;\n+}\n+\n+static int vfio_ap_get_config(struct ap_matrix_mdev *matrix_mdev)\n+{\n+\tstruct vfio_ap_config *ap_configuration;\n+\tunsigned long *apm, *aqm, apid, apqi;\n+\tunsigned int num_queues;\n+\tconst char *mdev_name;\n+\tsize_t ap_config_size;\n+\tint ret, qindex;\n+\n+\tlockdep_assert_held(\u0026matrix_dev-\u003emdevs_lock);\n+\n+\tap_config_size = vfio_ap_config_size(matrix_mdev, \u0026num_queues);\n+\n+\tap_configuration = kvzalloc(ap_config_size, GFP_KERNEL_ACCOUNT);\n+\tif (!ap_configuration)\n+\t\treturn -ENOMEM;\n+\n+\tap_configuration-\u003emagic = VFIO_AP_MIG_MAGIC;\n+\tap_configuration-\u003eversion = VFIO_AP_MIG_VERSION;\n+\n+\t/*\n+\t * num_queues must be set before writing qinfo[] elements; the\n+\t * __counted_by(num_queues) annotation on qinfo[] causes the compiler to\n+\t * insert bounds checks that evaluate against ap_configuration-\u003enum_queues.\n+\t * Writing through qinfo[i] with num_queues still 0 would trap.\n+\t */\n+\tap_configuration-\u003enum_queues = num_queues;\n+\n+\tapm = matrix_mdev-\u003eshadow_apcb.apm;\n+\taqm = matrix_mdev-\u003eshadow_apcb.aqm;\n+\tqindex = 0;\n+\tfor_each_set_bit_inv(apid, apm, AP_DEVICES) {\n+\t\tfor_each_set_bit_inv(apqi, aqm, AP_DOMAINS) {\n+\t\t\tap_configuration-\u003eqinfo[qindex].apqn =\n+\t\t\t\tAP_MKQID(apid, apqi);\n+\t\t\tqindex += 1;\n+\t\t}\n+\t}\n+\tmemcpy(ap_configuration-\u003eadm, matrix_mdev-\u003eshadow_apcb.adm,\n+\t sizeof(ap_configuration-\u003eadm));\n+\tmdev_name = dev_name(matrix_mdev-\u003evdev.dev);\n+\n+\tret = vfio_ap_store_queue_info(mdev_name, ap_configuration);\n+\tif (ret) {\n+\t\tkvfree(ap_configuration);\n+\t\treturn ret;\n+\t}\n+\n+\tmatrix_mdev-\u003emig_data-\u003estop_copy_mig_file.ap_config = ap_configuration;\n+\tmatrix_mdev-\u003emig_data-\u003estop_copy_mig_file.config_sz = ap_config_size;\n+\n+\treturn 0;\n+}\n+\n+static ssize_t vfio_ap_stop_copy_read(struct file *filp, char __user *buf,\n+\t\t\t\t size_t len, loff_t *pos)\n+{\n+\tstruct vfio_ap_migration_file *mig_file;\n+\tstruct ap_matrix_mdev *matrix_mdev;\n+\tvoid *bounce;\n+\tssize_t ret;\n+\n+\t/*\n+\t * This file was opened with stream_open(), so pos should be NULL for\n+\t * sequential read() calls; a non-NULL pointer will be passed only\n+\t * for positional pread() calls in which case we return an error\n+\t * indicating broken pipe/illegal seek on a non-seekable file\n+\t */\n+\tif (pos)\n+\t\treturn -ESPIPE;\n+\n+\tmutex_lock(\u0026matrix_dev-\u003emdevs_lock);\n+\tpos = \u0026filp-\u003ef_pos;\n+\n+\tret = validate_stop_copy_read_parms(filp, len);\n+\tif (ret) {\n+\t\tmutex_unlock(\u0026matrix_dev-\u003emdevs_lock);\n+\t\treturn ret;\n+\t}\n+\n+\tmatrix_mdev = filp-\u003eprivate_data;\n+\tmig_file = \u0026matrix_mdev-\u003emig_data-\u003estop_copy_mig_file;\n+\n+\t/*\n+\t * The data to be returned to the caller - i.e., the source guest's\n+\t * AP configuration data - is generated on the first read() call. The\n+\t * result is cached in mig_file-\u003eap_config for subsequent read() calls.\n+\t */\n+\tif (!mig_file-\u003eap_config) {\n+\t\tret = vfio_ap_get_config(matrix_mdev);\n+\t\tif (ret) {\n+\t\t\tmutex_unlock(\u0026matrix_dev-\u003emdevs_lock);\n+\t\t\treturn ret;\n+\t\t}\n+\t}\n+\n+\t/* Return EOF if all of the AP configuration data has been read */\n+\tif (*pos \u003e= mig_file-\u003econfig_sz) {\n+\t\tmutex_unlock(\u0026matrix_dev-\u003emdevs_lock);\n+\t\treturn 0;\n+\t}\n+\n+\t/*\n+\t * Don't read past the end of the AP configuration data. Limit len to\n+\t * the number of bytes remaining.\n+\t */\n+\tlen = min_t(size_t, mig_file-\u003econfig_sz - *pos, len);\n+\tif (len == 0) {\n+\t\tmutex_unlock(\u0026matrix_dev-\u003emdevs_lock);\n+\t\treturn 0;\n+\t}\n+\n+\t/*\n+\t * Copy into a bounce buffer under mdevs_lock and advance *pos, then\n+\t * perform copy_to_user() outside the lock. This avoids stalling\n+\t * all host mdev operations if userspace passes a buffer that faults.\n+\t */\n+\tbounce = kmalloc(len, GFP_KERNEL);\n+\tif (!bounce) {\n+\t\tmutex_unlock(\u0026matrix_dev-\u003emdevs_lock);\n+\t\treturn -ENOMEM;\n+\t}\n+\n+\tmemcpy(bounce, (char *)mig_file-\u003eap_config + *pos, len);\n+\t*pos += len;\n+\tmutex_unlock(\u0026matrix_dev-\u003emdevs_lock);\n+\n+\tif (copy_to_user(buf, bounce, len)) {\n+\t\tkfree(bounce);\n+\t\treturn -EFAULT;\n+\t}\n+\n+\tkfree(bounce);\n+\treturn len;\n+}\n+\n+static const struct file_operations vfio_ap_stop_copy_fops = {\n+\t.owner = THIS_MODULE,\n+\t.read = vfio_ap_stop_copy_read,\n+\t.release = vfio_ap_release_mig_file,\n+};\n+\n+static struct file *vfio_ap_open_file_stream(struct ap_matrix_mdev *matrix_mdev,\n+\t\t\t\t\t const struct file_operations *fops,\n+\t\t\t\t\t int flags)\n+{\n+\tstruct file *filp;\n+\n+\tlockdep_assert_held(\u0026matrix_dev-\u003emdevs_lock);\n+\n+\t/*\n+\t * Pin the vfio_device registration so that matrix_mdev cannot be freed\n+\t * while the migration FD is still open. The matching put is in\n+\t * vfio_ap_release_mig_file().\n+\t */\n+\tif (!vfio_device_try_get_registration(\u0026matrix_mdev-\u003evdev))\n+\t\treturn ERR_PTR(-ENODEV);\n+\n+\tfilp = anon_inode_getfile(\"vfio_ap_mig_file\", fops, matrix_mdev, flags);\n+\tif (IS_ERR(filp)) {\n+\t\tvfio_device_put_registration(\u0026matrix_mdev-\u003evdev);\n+\t\treturn filp;\n+\t}\n+\n+\tstream_open(filp-\u003ef_inode, filp);\n+\n+\treturn filp;\n+}\n+\n+static int validate_resuming_write_parms(struct file *filp, size_t len)\n+{\n+\tstruct vfio_ap_migration_data *mig_data;\n+\tstruct ap_matrix_mdev *matrix_mdev;\n+\tloff_t total_len;\n+\n+\tlockdep_assert_held(\u0026matrix_dev-\u003emdevs_lock);\n+\n+\tif (!len || filp-\u003ef_pos \u003c 0)\n+\t\treturn -EINVAL;\n+\n+\tif (check_add_overflow((loff_t)len, filp-\u003ef_pos, \u0026total_len))\n+\t\treturn -ERANGE;\n+\n+\tmatrix_mdev = filp-\u003eprivate_data;\n+\tif (!matrix_mdev || !matrix_mdev-\u003emig_data)\n+\t\treturn -ENODEV;\n+\n+\tmig_data = matrix_mdev-\u003emig_data;\n+\n+\tif (filp != mig_data-\u003eresuming_mig_file.filp)\n+\t\treturn -ENXIO;\n+\n+\t/* Reject writes that would overflow the pre-allocated buffer */\n+\tif (filp-\u003ef_pos + len \u003e VFIO_AP_CONFIG_MAX_SIZE)\n+\t\treturn -EIO;\n+\n+\treturn 0;\n+}\n+\n+static void report_facilities_compatibility(const char *mdev_name,\n+\t\t\t\t\t unsigned long apqn,\n+\t\t\t\t\t struct ap_tapq_hwinfo *src_hwinfo,\n+\t\t\t\t\t struct ap_tapq_hwinfo *target_hwinfo)\n+{\n+\tif (src_hwinfo-\u003eapsc != target_hwinfo-\u003eapsc) {\n+\t\tif (src_hwinfo-\u003eapsc) {\n+\t\t\tpr_err_ratelimited(\"vfio_ap_mdev %s: APSC facility installed in source queue %02lx.%04lx\\n\",\n+\t\t\t\t\t mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));\n+\n+\t\t\tpr_err_ratelimited(\"vfio_ap_mdev %s: APSC facility not installed in target queue %02lx.%04lx\\n\",\n+\t\t\t\t\t mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));\n+\t\t} else {\n+\t\t\tpr_err_ratelimited(\"vfio_ap_mdev %s: APSC facility not installed in source queue %02lx.%04lx\\n\",\n+\t\t\t\t\t mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));\n+\n+\t\t\tpr_err_ratelimited(\"vfio_ap_mdev %s: APSC facility installed in target queue %02lx.%04lx\\n\",\n+\t\t\t\t\t mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));\n+\t\t}\n+\t}\n+\n+\tif (src_hwinfo-\u003emex4k != target_hwinfo-\u003emex4k) {\n+\t\tif (src_hwinfo-\u003emex4k) {\n+\t\t\tpr_err_ratelimited(\"vfio_ap_mdev %s: mex4k facility installed in source queue %02lx.%04lx\\n\",\n+\t\t\t\t\t mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));\n+\n+\t\t\tpr_err_ratelimited(\"vfio_ap_mdev %s: mex4k facility not installed in target queue %02lx.%04lx\\n\",\n+\t\t\t\t\t mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));\n+\t\t} else {\n+\t\t\tpr_err_ratelimited(\"vfio_ap_mdev %s: mex4k facility not installed in source queue %02lx.%04lx\\n\",\n+\t\t\t\t\t mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));\n+\n+\t\t\tpr_err_ratelimited(\"vfio_ap_mdev %s: mex4k facility installed in target queue %02lx.%04lx\\n\",\n+\t\t\t\t\t mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));\n+\t\t}\n+\t}\n+\n+\tif (src_hwinfo-\u003ecrt4k != target_hwinfo-\u003ecrt4k) {\n+\t\tif (src_hwinfo-\u003ecrt4k) {\n+\t\t\tpr_err_ratelimited(\"vfio_ap_mdev %s: crt4k facility installed in source queue %02lx.%04lx\\n\",\n+\t\t\t\t\t mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));\n+\n+\t\t\tpr_err_ratelimited(\"vfio_ap_mdev %s: crt4k facility not installed in target queue %02lx.%04lx\\n\",\n+\t\t\t\t\t mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));\n+\t\t} else {\n+\t\t\tpr_err_ratelimited(\"vfio_ap_mdev %s: crt4k facility not installed in source queue %02lx.%04lx\\n\",\n+\t\t\t\t\t mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));\n+\n+\t\t\tpr_err_ratelimited(\"vfio_ap_mdev %s: crt4k facility installed in target queue %02lx.%04lx\\n\",\n+\t\t\t\t\t mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));\n+\t\t}\n+\t}\n+}\n+\n+static void report_mode_compatibility(const char *mdev_name,\n+\t\t\t\t unsigned long apqn,\n+\t\t\t\t struct ap_tapq_hwinfo *src_hwinfo,\n+\t\t\t\t struct ap_tapq_hwinfo *target_hwinfo)\n+{\n+\tif (src_hwinfo-\u003ecca != target_hwinfo-\u003ecca) {\n+\t\tif (src_hwinfo-\u003ecca) {\n+\t\t\tpr_err_ratelimited(\"vfio_ap_mdev %s: Coprocessor-mode facility installed in source queue %02lx.%04lx\\n\",\n+\t\t\t\t\t mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));\n+\n+\t\t\tpr_err_ratelimited(\"vfio_ap_mdev %s: Coprocessor-mode facility not installed in target queue %02lx.%04lx\\n\",\n+\t\t\t\t\t mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));\n+\t\t} else {\n+\t\t\tpr_err_ratelimited(\"vfio_ap_mdev %s: Coprocessor-mode facility not installed in source queue %02lx.%04lx\\n\",\n+\t\t\t\t\t mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));\n+\n+\t\t\tpr_err_ratelimited(\"vfio_ap_mdev %s: Coprocessor-mode facility installed in target queue %02lx.%04lx\\n\",\n+\t\t\t\t\t mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));\n+\t\t}\n+\t}\n+\n+\tif (src_hwinfo-\u003eaccel != target_hwinfo-\u003eaccel) {\n+\t\tif (src_hwinfo-\u003eaccel) {\n+\t\t\tpr_err_ratelimited(\"vfio_ap_mdev %s: Accelerator-mode facility installed in source queue %02lx.%04lx\\n\",\n+\t\t\t\t\t mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));\n+\n+\t\t\tpr_err_ratelimited(\"vfio_ap_mdev %s: Accelerator-mode facility not installed in target queue %02lx.%04lx\\n\",\n+\t\t\t\t\t mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));\n+\t\t} else {\n+\t\t\tpr_err_ratelimited(\"vfio_ap_mdev %s: Accelerator-mode facility not installed in source queue %02lx.%04lx\\n\",\n+\t\t\t\t\t mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));\n+\n+\t\t\tpr_err_ratelimited(\"vfio_ap_mdev %s: Accelerator-mode facility installed in target queue %02lx.%04lx\\n\",\n+\t\t\t\t\t mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));\n+\t\t}\n+\t}\n+\n+\tif (src_hwinfo-\u003eep11 != target_hwinfo-\u003eep11) {\n+\t\tif (src_hwinfo-\u003eep11) {\n+\t\t\tpr_err_ratelimited(\"vfio_ap_mdev %s: XCP-mode facility installed in source queue %02lx.%04lx\\n\",\n+\t\t\t\t\t mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));\n+\n+\t\t\tpr_err_ratelimited(\"vfio_ap_mdev %s: XCP-mode facility not installed in target queue %02lx.%04lx\\n\",\n+\t\t\t\t\t mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));\n+\t\t} else {\n+\t\t\tpr_err_ratelimited(\"vfio_ap_mdev %s: XCP-mode facility not installed in source queue %02lx.%04lx\\n\",\n+\t\t\t\t\t mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));\n+\n+\t\t\tpr_err_ratelimited(\"vfio_ap_mdev %s: XCP-mode facility installed in target queue %02lx.%04lx\\n\",\n+\t\t\t\t\t mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));\n+\t\t}\n+\t}\n+}\n+\n+static void report_apxa_compatibility(const char *mdev_name,\n+\t\t\t\t unsigned long apqn,\n+\t\t\t\t struct ap_tapq_hwinfo *src_hwinfo,\n+\t\t\t\t struct ap_tapq_hwinfo *target_hwinfo)\n+{\n+\tif (src_hwinfo-\u003eapxa != target_hwinfo-\u003eapxa) {\n+\t\tif (src_hwinfo-\u003eapxa) {\n+\t\t\tpr_err_ratelimited(\"vfio_ap_mdev %s: AP-extended-addressing (APXA) facility installed in source queue %02lx.%04lx\\n\",\n+\t\t\t\t\t mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));\n+\n+\t\t\tpr_err_ratelimited(\"vfio_ap_mdev %s: AP-extended-addressing (APXA) facility not installed in target queue %02lx.%04lx\\n\",\n+\t\t\t\t\t mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));\n+\t\t} else {\n+\t\t\tpr_err_ratelimited(\"vfio_ap_mdev %s: AP-extended-addressing (APXA) facility not installed in source queue %02lx.%04lx\\n\",\n+\t\t\t\t\t mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));\n+\n+\t\t\tpr_err_ratelimited(\"vfio_ap_mdev %s: AP-extended-addressing (APXA) facility installed in target queue %02lx.%04lx\\n\",\n+\t\t\t\t\t mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));\n+\t\t}\n+\t}\n+}\n+\n+static void report_slcf_compatibility(const char *mdev_name,\n+\t\t\t\t unsigned long apqn,\n+\t\t\t\t struct ap_tapq_hwinfo *src_hwinfo,\n+\t\t\t\t struct ap_tapq_hwinfo *target_hwinfo)\n+{\n+\tif (src_hwinfo-\u003eslcf != target_hwinfo-\u003eslcf) {\n+\t\tif (src_hwinfo-\u003eslcf) {\n+\t\t\tpr_err_ratelimited(\"vfio_ap_mdev %s: Stateless-command-filtering (SLCF) available in source queue %02lx.%04lx\\n\",\n+\t\t\t\t\t mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));\n+\n+\t\t\tpr_err_ratelimited(\"vfio_ap_mdev %s: Stateless-command-filtering (SLCF) not available in target queue %02lx.%04lx\\n\",\n+\t\t\t\t\t mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));\n+\t\t} else {\n+\t\t\tpr_err_ratelimited(\"vfio_ap_mdev %s: Stateless-command-filtering (SLCF) not available in source queue %02lx.%04lx\\n\",\n+\t\t\t\t\t mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));\n+\n+\t\t\tpr_err_ratelimited(\"vfio_ap_mdev %s: Stateless-command-filtering (SLCF) available in target queue %02lx.%04lx\\n\",\n+\t\t\t\t\t mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));\n+\t\t}\n+\t}\n+}\n+\n+static void report_bs_compatibility(const char *mdev_name,\n+\t\t\t\t unsigned long apqn,\n+\t\t\t\t struct ap_tapq_hwinfo *src_hwinfo,\n+\t\t\t\t struct ap_tapq_hwinfo *target_hwinfo)\n+{\n+\t/*\n+\t * The BS field on both the source and destination must be 0, so if one\n+\t * of them is not, then report an error.\n+\t */\n+\tif (src_hwinfo-\u003ebs || target_hwinfo-\u003ebs) {\n+\t\tpr_err_ratelimited(\"vfio_ap_mdev %s: Bind/associate state for source (%01x) and target (%01x) queue %02lx.%04lx must be 0\\n\",\n+\t\t\t\t mdev_name, src_hwinfo-\u003ebs, target_hwinfo-\u003ebs,\n+\t\t\t\t AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));\n+\t}\n+}\n+\n+static void report_aptype_compatibility(const char *mdev_name,\n+\t\t\t\t\tunsigned long apqn,\n+\t\t\t\t\tstruct ap_tapq_hwinfo *src_hwinfo,\n+\t\t\t\t\tstruct ap_tapq_hwinfo *target_hwinfo)\n+{\n+\tif (src_hwinfo-\u003eat \u003e target_hwinfo-\u003eat) {\n+\t\tpr_err_ratelimited(\"vfio_ap_mdev %s: AP type of source queue %02lx.%04lx (%02x) not compatible with target (%02x)\\n\",\n+\t\t\t\t mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn),\n+\t\t\t\t src_hwinfo-\u003eat, target_hwinfo-\u003eat);\n+\t}\n+}\n+\n+static bool classes_compatible(struct ap_tapq_hwinfo *src_hwinfo,\n+\t\t\t struct ap_tapq_hwinfo *target_hwinfo)\n+{\n+\tunsigned long src_native, target_native;\n+\n+\tsrc_native = src_hwinfo-\u003eclass \u0026 CLASSIFICATION_NATIVE_FCN_MASK;\n+\ttarget_native = target_hwinfo-\u003eclass \u0026 CLASSIFICATION_NATIVE_FCN_MASK;\n+\n+\t/*\n+\t * If the source queue has full native card function and the\n+\t * target queue has only stateless functions available, then\n+\t * there may be instructions that will not execute on the\n+\t * target queue. This shall be reported as an error.\n+\t *\n+\t * If the source queue has only stateless card functions and the\n+\t * target queue has full native card function available, then\n+\t * we are okay because the target queue can run all stateless card\n+\t * functions.\n+\t */\n+\treturn (src_native != target_native) ? !src_native : true;\n+}\n+\n+static void report_class_compatibility(const char *mdev_name,\n+\t\t\t\t unsigned long apqn,\n+\t\t\t\t struct ap_tapq_hwinfo *src_hwinfo,\n+\t\t\t\t struct ap_tapq_hwinfo *target_hwinfo)\n+{\n+\tif (!classes_compatible(src_hwinfo, target_hwinfo)) {\n+\t\tpr_err_ratelimited(\"vfio_ap_mdev %s: Full native card function available on source queue %02lx.%04lx\\n\",\n+\t\t\t\t mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));\n+\n+\t\tpr_err_ratelimited(\"vfio_ap_mdev %s: Only stateless functions available on target queue %02lx.%04lx\\n\",\n+\t\t\t\t mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));\n+\t}\n+}\n+\n+/*\n+ * Log a device error reporting that migration failed due to queue\n+ * incompatibilities followed by a device error for each incompatible feature.\n+ */\n+static void report_qinfo_incompatibilities(const char *mdev_name,\n+\t\t\t\t\t unsigned long apqn,\n+\t\t\t\t\t struct ap_tapq_hwinfo *src_hwinfo,\n+\t\t\t\t\t struct ap_tapq_hwinfo *target_hwinfo)\n+{\n+\tpr_err_ratelimited(\"vfio_ap_mdev %s: Migration failed: Source and target queue (%02lx.%04lx) not compatible\\n\",\n+\t\t\t mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));\n+\n+\treport_facilities_compatibility(mdev_name, apqn, src_hwinfo, target_hwinfo);\n+\treport_mode_compatibility(mdev_name, apqn, src_hwinfo, target_hwinfo);\n+\treport_apxa_compatibility(mdev_name, apqn, src_hwinfo, target_hwinfo);\n+\treport_slcf_compatibility(mdev_name, apqn, src_hwinfo, target_hwinfo);\n+\treport_aptype_compatibility(mdev_name, apqn, src_hwinfo, target_hwinfo);\n+\treport_bs_compatibility(mdev_name, apqn, src_hwinfo, target_hwinfo);\n+\treport_class_compatibility(mdev_name, apqn, src_hwinfo, target_hwinfo);\n+}\n+\n+/**\n+ * queue_hardware_info_is_compatible:\n+ *\n+ * Verify whether the hardware information for a source queue is compatible with\n+ * the hardware info for the corresponding queue on this system.\n+ *\n+ * In order to be compatible, the hardware information for each queue must\n+ * meet the following requirements:\n+ *\n+ * 1. The hardware facilities bits much match\n+ * 2. The AP type of the source queue must be the same as or older than that\n+ * of the target queue (target is backwards compatible)\n+ * 3. The classification bits must indicate:\n+ * - Both queues have full native card function or both have stateless\n+ * functions available\n+ * - If the classification bits don't match, then the only acceptable\n+ * configuration is stateless functions for the source queue and\n+ * full native function for the target queue\n+ * 4. The BS bits for both queues must be 0 (Queue usable for all messages\n+ * supported by the adapter)\n+ *\n+ * @mdev_name:\tThe mdev name to use in error messages\n+ * @apqn:\tThe APQN for the queues\n+ * @src_hwinfo: The hardware info for the source queue\n+ * @target_hwinfo: The hardware info for the corresponding queue on this system\n+ *\n+ * Returns: true if the hardware info for the two queues is compatible;\n+ * otherwise, returns false.\n+ */\n+static bool queue_hardware_info_is_compatible(const char *mdev_name,\n+\t\t\t\t\t unsigned long apqn,\n+\t\t\t\t\t struct ap_tapq_hwinfo *src_hwinfo,\n+\t\t\t\t\t struct ap_tapq_hwinfo *target_hwinfo)\n+{\n+\tunsigned long src_bits, target_bits;\n+\n+\tsrc_bits = src_hwinfo-\u003evalue \u0026 QINFO_DATA_MASK;\n+\ttarget_bits = target_hwinfo-\u003evalue \u0026 QINFO_DATA_MASK;\n+\n+\t/* If all bits match the queues are compatible */\n+\tif (src_bits == target_bits \u0026\u0026\n+\t (src_hwinfo-\u003ebs == 0 \u0026\u0026 target_hwinfo-\u003ebs == 0))\n+\t\treturn true;\n+\n+\tif (src_hwinfo-\u003eapsc == target_hwinfo-\u003eapsc \u0026\u0026\n+\t src_hwinfo-\u003emex4k == target_hwinfo-\u003emex4k \u0026\u0026\n+\t src_hwinfo-\u003ecrt4k == target_hwinfo-\u003ecrt4k \u0026\u0026\n+\t src_hwinfo-\u003ecca == target_hwinfo-\u003ecca \u0026\u0026\n+\t src_hwinfo-\u003eaccel == target_hwinfo-\u003eaccel \u0026\u0026\n+\t src_hwinfo-\u003eep11 == target_hwinfo-\u003eep11 \u0026\u0026\n+\t src_hwinfo-\u003eslcf == target_hwinfo-\u003eslcf \u0026\u0026\n+\t src_hwinfo-\u003eapxa == target_hwinfo-\u003eapxa \u0026\u0026\n+\t src_hwinfo-\u003eat \u003c= target_hwinfo-\u003eat \u0026\u0026\n+\t classes_compatible(src_hwinfo, target_hwinfo) \u0026\u0026\n+\t (src_hwinfo-\u003ebs == 0 \u0026\u0026 target_hwinfo-\u003ebs == 0))\n+\t\treturn true;\n+\n+\treport_qinfo_incompatibilities(mdev_name, apqn, src_hwinfo, target_hwinfo);\n+\n+\treturn false;\n+}\n+\n+/**\n+ * verify_ap_configs_are_compatible:\n+ *\n+ * Verifies that the queues in the source guest's AP configuration are\n+ * compatible with the corresponding queues on this system.\n+ *\n+ * @mdev_name:\t The mdev name to use in error messages\n+ * @source_config: The object specifying the source guest's AP configuration\n+ *\n+ * Returns: an error indicating either a failure to retrieve a queue's\n+ *\t\t\thardware information or one or more source queues are not\n+ *\t\t\tcompatible with the corresponding queue on this system; otherwise,\n+ *\t\t\treturns zero to indicate compatibility.\n+ */\n+static int verify_ap_configs_are_compatible(const char *mdev_name,\n+\t\t\t\t\t struct vfio_ap_config *source_config)\n+{\n+\tstruct ap_tapq_hwinfo src_hwinfo, dest_hwinfo;\n+\tunsigned long apqn;\n+\tint ret = 0, rc;\n+\n+\tfor (int i = 0; i \u003c source_config-\u003enum_queues; i++) {\n+\t\tapqn = source_config-\u003eqinfo[i].apqn;\n+\n+\t\t/*\n+\t\t * If we can't get the hardware info for a particular queue, then let's\n+\t\t * capture the function return code and continue so we can log all\n+\t\t * errors to aid in debugging of migration.\n+\t\t */\n+\t\trc = get_hardware_info_for_queue(mdev_name, \u0026dest_hwinfo, apqn);\n+\t\tif (rc) {\n+\t\t\tret = rc;\n+\t\t\tcontinue;\n+\t\t}\n+\n+\t\tsrc_hwinfo.value = source_config-\u003eqinfo[i].data;\n+\n+\t\tif (!queue_hardware_info_is_compatible(mdev_name, apqn,\n+\t\t\t\t\t\t \u0026src_hwinfo,\n+\t\t\t\t\t\t \u0026dest_hwinfo))\n+\t\t\tret = -EINVAL;\n+\t}\n+\n+\treturn ret;\n+}\n+\n+/**\n+ * ap_config_is_subset_of_shadow_apcb:\n+ *\n+ * Verify that each APQN and control domain in the source guest's AP\n+ * configuration is present in the destination mdev's shadow_apcb. The\n+ * destination mdev must be pre-configured by the administrator with at least\n+ * the adapters, domains and control domains the source guest is actively\n+ * using. Since shadow_apcb is derived from the administrator's assignment\n+ * filtered to only installed and vfio_ap-bound queues, any APQN or control\n+ * domain present in shadow_apcb is guaranteed to be available.\n+ *\n+ * All missing APQNs and control domains are logged before returning so the\n+ * administrator sees all problems at once rather than one per retry.\n+ *\n+ * @mdev_name: The mdev name to use in error messages\n+ * @matrix_mdev: The destination mdev whose shadow_apcb to check against\n+ * @source_config: The source guest's AP configuration\n+ *\n+ * Returns: true if every APQN and control domain in @source_config is present\n+ * in @matrix_mdev-\u003eshadow_apcb; otherwise returns false.\n+ */\n+static bool ap_config_is_subset_of_shadow_apcb(const char *mdev_name,\n+\t\t\t\t\t struct ap_matrix_mdev *matrix_mdev,\n+\t\t\t\t\t struct vfio_ap_config *source_config)\n+{\n+\tunsigned long apid, apqi, apqn, domain_num;\n+\tbool ret = true;\n+\n+\tfor (int i = 0; i \u003c source_config-\u003enum_queues; i++) {\n+\t\tapqn = source_config-\u003eqinfo[i].apqn;\n+\t\tapid = AP_QID_CARD(apqn);\n+\t\tapqi = AP_QID_QUEUE(apqn);\n+\n+\t\tif (!test_bit_inv(apid, matrix_mdev-\u003eshadow_apcb.apm) ||\n+\t\t !test_bit_inv(apqi, matrix_mdev-\u003eshadow_apcb.aqm)) {\n+\t\t\tpr_err_ratelimited(\"vfio_ap_mdev %s: Queue %02lx.%04lx not in destination mdev's AP configuration\\n\",\n+\t\t\t\t\t mdev_name, apid, apqi);\n+\t\t\tret = false;\n+\t\t}\n+\t}\n+\n+\tfor_each_set_bit_inv(domain_num, (unsigned long *)source_config-\u003eadm,\n+\t\t\t AP_DOMAINS) {\n+\t\tif (!test_bit_inv(domain_num, matrix_mdev-\u003eshadow_apcb.adm)) {\n+\t\t\tpr_err_ratelimited(\"vfio_ap_mdev %s: Control domain %04lx not in destination mdev's AP configuration\\n\",\n+\t\t\t\t\t mdev_name, domain_num);\n+\t\t\tret = false;\n+\t\t}\n+\t}\n+\n+\treturn ret;\n+}\n+\n+static int do_post_copy_validation(struct ap_matrix_mdev *matrix_mdev,\n+\t\t\t\t struct vfio_ap_config *source_config)\n+{\n+\tconst char *mdev_name = dev_name(matrix_mdev-\u003evdev.dev);\n+\n+\tlockdep_assert_held(\u0026ap_attr_mutex);\n+\tassert_has_update_locks_for_mdev(matrix_mdev);\n+\n+\tif (source_config-\u003emagic != VFIO_AP_MIG_MAGIC ||\n+\t source_config-\u003eversion != VFIO_AP_MIG_VERSION)\n+\t\treturn -EINVAL;\n+\n+\tif (!ap_config_is_subset_of_shadow_apcb(mdev_name, matrix_mdev,\n+\t\t\t\t\t\tsource_config))\n+\t\treturn -EINVAL;\n+\n+\treturn verify_ap_configs_are_compatible(mdev_name, source_config);\n+}\n+\n+static ssize_t vfio_ap_resuming_write(struct file *filp, const char __user *buf,\n+\t\t\t\t size_t len, loff_t *pos)\n+{\n+\tstruct ap_matrix_mdev *matrix_mdev;\n+\tstruct vfio_ap_config *ap_config;\n+\tssize_t ret;\n+\tvoid *kbuf;\n+\n+\t/*\n+\t * This file was opened with stream_open(), so pos should be NULL for\n+\t * sequential write() calls; a non-NULL pointer will be passed only\n+\t * for positional pwrite() calls in which case we return an error\n+\t * indicating broken pipe/illegal seek on a non-seekable file.\n+\t */\n+\tif (pos)\n+\t\treturn -ESPIPE;\n+\n+\t/*\n+\t * Reject absurd lengths before allocating the bounce buffer below.\n+\t * This only caps the allocation: a write can never be larger than\n+\t * the receive buffer. The authoritative check against the space\n+\t * remaining is made by validate_resuming_write_parms() under the\n+\t * locks.\n+\t */\n+\tif (len \u003e VFIO_AP_CONFIG_MAX_SIZE)\n+\t\treturn -EIO;\n+\n+\t/*\n+\t * Copy the user data into a kernel buffer before taking any locks.\n+\t * copy_from_user() can fault and block for an unbounded time, which\n+\t * must not happen while holding ap_attr_mutex, guests_lock, kvm-\u003elock\n+\t * or mdevs_lock.\n+\t */\n+\tkbuf = vmemdup_user(buf, len);\n+\tif (IS_ERR(kbuf))\n+\t\treturn PTR_ERR(kbuf);\n+\n+\t/*\n+\t * Hold ap_attr_mutex for the full duration of the write, just as\n+\t * (un)assign_adapter_store() and (un)assign_domain_store() do. This\n+\t * prevents the AP bus apmask/aqmask attributes from being changed\n+\t * while the guest's AP configuration is being updated.\n+\t *\n+\t * get_update_locks_for_mdev() then acquires guests_lock, kvm-\u003elock,\n+\t * and mdevs_lock in the correct order. This serialises\n+\t * the entire operation against concurrent AP attribute writers\n+\t * while the guest's AP configuration is being changed.\n+\t *\n+\t * Holding these locks for the full duration of a potentially chunked\n+\t * write could in theory affect performance, but this is acceptable for\n+\t * several reasons: migration is an infrequent operation; real-world\n+\t * guest AP configurations are small (each CEX8 card has 2 adapters and\n+\t * up to 16 domains, and the 85 cards in a system are shared across all\n+\t * LPARs and guests); and only a memcpy() and some integer checks are\n+\t * done for each chunk while the locks are held.\n+\t */\n+\tmatrix_mdev = filp-\u003eprivate_data;\n+\tmutex_lock(\u0026ap_attr_mutex);\n+\tget_update_locks_for_mdev(matrix_mdev);\n+\tpos = \u0026filp-\u003ef_pos;\n+\n+\tret = validate_resuming_write_parms(filp, len);\n+\tif (ret)\n+\t\tgoto out_unlock;\n+\n+\tap_config = matrix_mdev-\u003emig_data-\u003eresuming_mig_file.ap_config;\n+\n+\tmemcpy((char *)ap_config + *pos, kbuf, len);\n+\t*pos += len;\n+\n+\t/*\n+\t * Check whether we have received all the data. We know the total\n+\t * expected size once num_queues has arrived, i.e. once *pos is past\n+\t * the fixed header. Until then keep accumulating.\n+\t */\n+\tif (*pos \u003e= offsetofend(struct vfio_ap_config, num_queues)) {\n+\t\tsize_t expected_sz;\n+\n+\t\tif (ap_config-\u003enum_queues \u003e MAX_AP_QUEUES) {\n+\t\t\tret = -EINVAL;\n+\t\t\tgoto out_unlock;\n+\t\t}\n+\n+\t\texpected_sz = sizeof(struct vfio_ap_config) +\n+\t\t\t ap_config-\u003enum_queues *\n+\t\t\t sizeof(struct vfio_ap_queue_info);\n+\n+\t\tif (*pos \u003e (loff_t)expected_sz) {\n+\t\t\tret = -EINVAL;\n+\t\t\tgoto out_unlock;\n+\t\t}\n+\n+\t\tif (*pos == (loff_t)expected_sz) {\n+\t\t\tret = do_post_copy_validation(matrix_mdev, ap_config);\n+\t\t\tmatrix_mdev-\u003emig_data-\u003eresuming_mig_data_complete = !ret;\n+\t\t}\n+\t}\n+\n+out_unlock:\n+\trelease_update_locks_for_mdev(matrix_mdev);\n+\tmutex_unlock(\u0026ap_attr_mutex);\n+\tkvfree(kbuf);\n+\treturn ret ? ret : (ssize_t)len;\n+}\n+\n+static const struct file_operations vfio_ap_resume_fops = {\n+\t.owner = THIS_MODULE,\n+\t.write = vfio_ap_resuming_write,\n+\t.release = vfio_ap_release_mig_file,\n+};\n+\n+static struct file *vfio_ap_resuming_init(struct ap_matrix_mdev *matrix_mdev)\n+{\n+\tstruct vfio_ap_config *ap_config;\n+\tstruct file *filp;\n+\n+\tlockdep_assert_held(\u0026matrix_dev-\u003emdevs_lock);\n+\n+\t/*\n+\t * Pre-allocate the maximum possible receive buffer so that\n+\t * vfio_ap_resuming_write() can copy directly into it without needing\n+\t * to know num_queues up front. kvzalloc falls back to vmalloc for\n+\t * large allocations rather than failing a high-order kmalloc.\n+\t */\n+\tap_config = kvzalloc(VFIO_AP_CONFIG_MAX_SIZE, GFP_KERNEL_ACCOUNT);\n+\tif (!ap_config)\n+\t\treturn ERR_PTR(-ENOMEM);\n+\n+\tfilp = vfio_ap_open_file_stream(matrix_mdev, \u0026vfio_ap_resume_fops, O_WRONLY);\n+\tif (IS_ERR(filp)) {\n+\t\tkvfree(ap_config);\n+\t\treturn filp;\n+\t}\n+\n+\tmatrix_mdev-\u003emig_data-\u003eresuming_mig_file.ap_config = ap_config;\n+\tmatrix_mdev-\u003emig_data-\u003eresuming_mig_file.config_sz = VFIO_AP_CONFIG_MAX_SIZE;\n+\n+\treturn filp;\n+}\n+\n+static struct file *\n+vfio_ap_transition_to_state(struct ap_matrix_mdev *matrix_mdev,\n+\t\t\t enum vfio_device_mig_state new_state)\n+{\n+\tstruct vfio_ap_migration_data *mig_data;\n+\tenum vfio_device_mig_state cur_state;\n+\n+\tlockdep_assert_held(\u0026matrix_dev-\u003emdevs_lock);\n+\tmig_data = matrix_mdev-\u003emig_data;\n+\tcur_state = mig_data-\u003emig_state;\n+\tdev_dbg(matrix_mdev-\u003evdev.dev, \"%s: %d -\u003e %d\\n\", __func__, cur_state,\n+\t\tnew_state);\n+\n+\t/*\n+\t * Begins the process of saving the vfio device state by creating and\n+\t * returning a streaming data_fd to be used to read out the internal\n+\t * state of the vfio-ap device on the source host.\n+\t */\n+\tif (cur_state == VFIO_DEVICE_STATE_STOP \u0026\u0026\n+\t new_state == VFIO_DEVICE_STATE_STOP_COPY) {\n+\t\tstruct file *filp = vfio_ap_open_file_stream(matrix_mdev,\n+\t\t\t\t\t\t\t \u0026vfio_ap_stop_copy_fops,\n+\t\t\t\t\t\t\t O_RDONLY);\n+\t\tif (IS_ERR(filp))\n+\t\t\treturn ERR_CAST(filp);\n+\n+\t\tmig_data-\u003estop_copy_mig_file.filp = filp;\n+\n+\t\treturn filp;\n+\t}\n+\n+\t/*\n+\t * Begins the process of restoring the vfio device state by creating and\n+\t * returning a streaming data_fd to be used to read in the internal\n+\t * state of the vfio-ap device on the destination host.\n+\t */\n+\tif (cur_state == VFIO_DEVICE_STATE_STOP \u0026\u0026\n+\t new_state == VFIO_DEVICE_STATE_RESUMING) {\n+\t\tstruct file *filp = vfio_ap_resuming_init(matrix_mdev);\n+\n+\t\tif (IS_ERR(filp))\n+\t\t\treturn ERR_CAST(filp);\n+\n+\t\tmig_data-\u003eresuming_mig_file.filp = filp;\n+\t\treturn filp;\n+\t}\n+\n+\t/*\n+\t * Terminates the data transfer session of the vfio-ap device state\n+\t * to the destination guest.\n+\t */\n+\tif (cur_state == VFIO_DEVICE_STATE_RESUMING \u0026\u0026\n+\t new_state == VFIO_DEVICE_STATE_STOP) {\n+\t\tif (!mig_data-\u003eresuming_mig_data_complete)\n+\t\t\treturn ERR_PTR(-EINVAL);\n+\n+\t\t/* Set resuming_mig_data_complete to false for clean reuse */\n+\t\tmatrix_mdev-\u003emig_data-\u003eresuming_mig_data_complete = false;\n+\t\tvfio_ap_release_resuming_file(matrix_mdev-\u003emig_data);\n+\t\treturn NULL;\n+\t}\n+\n+\t/*\n+\t * Terminates the transfer session of the vfio-ap device state from\n+\t * the source guest.\n+\t */\n+\tif (cur_state == VFIO_DEVICE_STATE_STOP_COPY \u0026\u0026\n+\t new_state == VFIO_DEVICE_STATE_STOP) {\n+\t\tvfio_ap_release_stop_copy_file(matrix_mdev-\u003emig_data);\n+\t\treturn NULL;\n+\t}\n+\n+\t/*\n+\t * These states indicate migration has either not been initiated or\n+\t * has completed and the vfio-ap device is operating normally. Since the\n+\t * vfio-ap device does not virtualize a DMA device, there is no internal\n+\t * device state to incorporate into the vfio-ap device on the target.\n+\t */\n+\tif (cur_state == VFIO_DEVICE_STATE_STOP \u0026\u0026\n+\t new_state == VFIO_DEVICE_STATE_RUNNING) {\n+\t\tvfio_ap_release_mig_files(matrix_mdev);\n+\t\treturn NULL;\n+\t}\n+\n+\tif (cur_state == VFIO_DEVICE_STATE_RUNNING \u0026\u0026\n+\t new_state == VFIO_DEVICE_STATE_STOP) {\n+\t\treturn NULL;\n+\t}\n+\n+\t/* vfio_mig_get_next_state() does not use arcs other than the above */\n+\tWARN_ON(true);\n+\n+\treturn ERR_PTR(-EINVAL);\n+}\n+\n+static struct file *vfio_ap_set_state(struct vfio_device *vdev,\n+\t\t\t\t enum vfio_device_mig_state new_state)\n+{\n+\tint ret;\n+\tstruct file *filp = NULL;\n+\tstruct ap_matrix_mdev *matrix_mdev;\n+\tenum vfio_device_mig_state next_state;\n+\tstruct vfio_ap_migration_data *mig_data;\n+\n+\tmutex_lock(\u0026matrix_dev-\u003emdevs_lock);\n+\n+\tmatrix_mdev = container_of(vdev, struct ap_matrix_mdev, vdev);\n+\tmig_data = matrix_mdev-\u003emig_data;\n+\n+\t/*\n+\t * The mig_data pointer is set in the vfio_ap_init_migration_data\n+\t * function which is called when the vfio-ap device fd is opened.\n+\t * Since the implicit pre-open state is RUNNING, a request to set\n+\t * RUNNING is a no-op. Any other state transition is invalid before\n+\t * open_device.\n+\t */\n+\tif (!mig_data) {\n+\t\tmutex_unlock(\u0026matrix_dev-\u003emdevs_lock);\n+\t\tif (new_state == VFIO_DEVICE_STATE_RUNNING)\n+\t\t\treturn NULL;\n+\t\treturn ERR_PTR(-ENODEV);\n+\t}\n+\n+\tdev_dbg(vdev-\u003edev, \"%s -\u003e %d\\n\", __func__, new_state);\n+\n+\twhile (mig_data-\u003emig_state != new_state) {\n+\t\tret = vfio_mig_get_next_state(vdev, mig_data-\u003emig_state,\n+\t\t\t\t\t new_state, \u0026next_state);\n+\t\tif (ret) {\n+\t\t\tfilp = ERR_PTR(ret);\n+\t\t\tbreak;\n+\t\t}\n+\n+\t\tfilp = vfio_ap_transition_to_state(matrix_mdev, next_state);\n+\t\tif (IS_ERR(filp))\n+\t\t\tbreak;\n+\n+\t\tmig_data-\u003emig_state = next_state;\n+\n+\t\tif (WARN_ON(filp \u0026\u0026 new_state != next_state)) {\n+\t\t\tfput(filp);\n+\t\t\tfilp = ERR_PTR(-EINVAL);\n+\t\t\tbreak;\n+\t\t}\n+\t}\n+\n+\tif (mig_data-\u003emig_state == VFIO_DEVICE_STATE_ERROR)\n+\t\tfilp = ERR_PTR(-EIO);\n+\n+\tmutex_unlock(\u0026matrix_dev-\u003emdevs_lock);\n+\n+\treturn filp;\n+}\n+\n+static int vfio_ap_get_state(struct vfio_device *vdev,\n+\t\t\t enum vfio_device_mig_state *current_state)\n+{\n+\tstruct ap_matrix_mdev *matrix_mdev;\n+\tstruct vfio_ap_migration_data *mig_data;\n+\n+\tmutex_lock(\u0026matrix_dev-\u003emdevs_lock);\n+\n+\tmatrix_mdev = container_of(vdev, struct ap_matrix_mdev, vdev);\n+\tmig_data = matrix_mdev-\u003emig_data;\n+\n+\t/*\n+\t * The mig_data pointer is set in the vfio_ap_init_migration_data\n+\t * function which is called when the vfio-ap device fd is opened.\n+\t * If mig_data is NULL, report RUNNING as the implicit pre-open state\n+\t * so userspace doesn't need to perform any state transition before the\n+\t * device becomes active.\n+\t */\n+\t*current_state = (mig_data) ? mig_data-\u003emig_state :\n+\t\t\t\t VFIO_DEVICE_STATE_RUNNING;\n+\n+\tmutex_unlock(\u0026matrix_dev-\u003emdevs_lock);\n+\n+\treturn 0;\n+}\n+\n+static int vfio_ap_get_data_size(struct vfio_device *vdev,\n+\t\t\t\t unsigned long *stop_copy_length)\n+{\n+\tstruct ap_matrix_mdev *matrix_mdev;\n+\tint num_queues;\n+\n+\tmutex_lock(\u0026matrix_dev-\u003emdevs_lock);\n+\tmatrix_mdev = container_of(vdev, struct ap_matrix_mdev, vdev);\n+\t*stop_copy_length = vfio_ap_config_size(matrix_mdev, \u0026num_queues);\n+\tmutex_unlock(\u0026matrix_dev-\u003emdevs_lock);\n+\n+\treturn 0;\n+}\n+\n+static const struct vfio_migration_ops vfio_ap_migration_ops = {\n+\t.migration_set_state = vfio_ap_set_state,\n+\t.migration_get_state = vfio_ap_get_state,\n+\t.migration_get_data_size = vfio_ap_get_data_size,\n+};\n+\n+/**\n+ * vfio_ap_init_migration_data - initialize migration data and functions\n+ *\n+ * @matrix_mdev: pointer to object containing the mdev state\n+ *\n+ * Return: zero if initialization is successful; otherwise, returns a error.\n+ */\n+int vfio_ap_init_migration_data(struct ap_matrix_mdev *matrix_mdev)\n+{\n+\tstruct vfio_ap_migration_data *mig_data;\n+\n+\tlockdep_assert_held(\u0026matrix_dev-\u003emdevs_lock);\n+\n+\t/*\n+\t * Live guest migration is not supported for SE guests, so there is no\n+\t * need to initialize the migration data.\n+\t */\n+\tif (ap_is_se_guest())\n+\t\treturn 0;\n+\n+\tmig_data = kzalloc_obj(struct vfio_ap_migration_data, GFP_KERNEL);\n+\tif (!mig_data)\n+\t\treturn -ENOMEM;\n+\n+\tmig_data-\u003emig_state = VFIO_DEVICE_STATE_RUNNING;\n+\tmig_data-\u003eresuming_mig_data_complete = false;\n+\tmatrix_mdev-\u003emig_data = mig_data;\n+\n+\treturn 0;\n+}\n+\n+/**\n+ * vfio_ap_release_mig_files:\n+ *\n+ * Free the ap_config buffers for any open migration FDs. Although a\n+ * migration FD may still be held open by userspace, it is safe to free\n+ * mig_data here because:\n+ *\n+ * 1. matrix_mdev remains valid for the lifetime of any open migration\n+ * FD via the vfio_device registration reference taken in\n+ * vfio_ap_open_file_stream() and dropped in\n+ * vfio_ap_release_mig_file().\n+ *\n+ * 2. mig_data is only accessed by the migration file ops\n+ * (vfio_ap_stop_copy_read, vfio_ap_resuming_write) under\n+ * mdevs_lock. Once mig_data is set to NULL by the caller, those\n+ * paths will see NULL and return -ENODEV before dereferencing it.\n+ *\n+ * @matrix_mdev: The object used to maintain the state for a mediated device\n+ */\n+static void vfio_ap_release_mig_files(struct ap_matrix_mdev *matrix_mdev)\n+{\n+\tstruct vfio_ap_migration_data *mig_data;\n+\n+\tlockdep_assert_held(\u0026matrix_dev-\u003emdevs_lock);\n+\n+\tmig_data = matrix_mdev-\u003emig_data;\n+\tvfio_ap_release_stop_copy_file(mig_data);\n+\tvfio_ap_release_resuming_file(mig_data);\n+}\n+\n+/**\n+ * vfio_ap_release_migration_data: reclaim private migration data\n+ *\n+ * @mdev: pointer to the object containing the state of the mdev\n+ */\n+void vfio_ap_release_migration_data(struct ap_matrix_mdev *matrix_mdev)\n+{\n+\tlockdep_assert_held(\u0026matrix_dev-\u003emdevs_lock);\n+\n+\tif (!matrix_mdev-\u003emig_data)\n+\t\treturn;\n+\n+\tvfio_ap_release_mig_files(matrix_mdev);\n+\tkfree(matrix_mdev-\u003emig_data);\n+\tmatrix_mdev-\u003emig_data = NULL;\n+}\n+\n+/**\n+ * vfio_ap_reset_migration_state - Reset the vfio-ap migration state\n+ *\n+ * @matrix_mdev: pointer to the object maintaining the vfio-ap device state\n+ *\n+ * Called during VFIO_DEVICE_RESET to clean up any active migration\n+ * state and reset the device to RUNNING state as required by the VFIO\n+ * migration specification.\n+ */\n+void vfio_ap_reset_migration_state(struct ap_matrix_mdev *matrix_mdev)\n+{\n+\tlockdep_assert_held(\u0026matrix_dev-\u003emdevs_lock);\n+\n+\tif (!matrix_mdev-\u003emig_data)\n+\t\treturn;\n+\n+\tvfio_ap_release_mig_files(matrix_mdev);\n+\tmatrix_mdev-\u003emig_data-\u003emig_state = VFIO_DEVICE_STATE_RUNNING;\n+}\ndiff --git a/drivers/s390/crypto/vfio_ap_ops.c b/drivers/s390/crypto/vfio_ap_ops.c\nindex 4db878c18f41c..e049c4141a53b 100644\n--- a/drivers/s390/crypto/vfio_ap_ops.c\n+++ b/drivers/s390/crypto/vfio_ap_ops.c\n@@ -88,53 +88,6 @@ static inline void release_update_locks_for_kvm(struct kvm *kvm)\n \tmutex_unlock(\u0026matrix_dev-\u003eguests_lock);\n }\n \n-/**\n- * get_update_locks_for_mdev: Acquire the locks required to dynamically update a\n- *\t\t\t KVM guest's APCB in the proper order.\n- *\n- * @matrix_mdev: a pointer to a struct ap_matrix_mdev object containing the AP\n- *\t\t configuration data to use to update a KVM guest's APCB.\n- *\n- * The proper locking order is:\n- * 1. matrix_dev-\u003eguests_lock: required to use the KVM pointer to update a KVM\n- *\t\t\t guest's APCB.\n- * 2. matrix_mdev-\u003ekvm-\u003elock: required to update a guest's APCB\n- * 3. matrix_dev-\u003emdevs_lock: required to access data stored in a matrix_mdev\n- *\n- * Note: If @matrix_mdev is NULL or is not attached to a KVM guest, the KVM\n- *\t lock will not be taken.\n- */\n-static inline void get_update_locks_for_mdev(struct ap_matrix_mdev *matrix_mdev)\n-{\n-\tmutex_lock(\u0026matrix_dev-\u003eguests_lock);\n-\tif (matrix_mdev \u0026\u0026 matrix_mdev-\u003ekvm)\n-\t\tmutex_lock(\u0026matrix_mdev-\u003ekvm-\u003elock);\n-\tmutex_lock(\u0026matrix_dev-\u003emdevs_lock);\n-}\n-\n-/**\n- * release_update_locks_for_mdev: Release the locks used to dynamically update a\n- *\t\t\t\t KVM guest's APCB in the proper order.\n- *\n- * @matrix_mdev: a pointer to a struct ap_matrix_mdev object containing the AP\n- *\t\t configuration data to use to update a KVM guest's APCB.\n- *\n- * The proper unlocking order is:\n- * 1. matrix_dev-\u003emdevs_lock\n- * 2. matrix_mdev-\u003ekvm-\u003elock\n- * 3. matrix_dev-\u003eguests_lock\n- *\n- * Note: If @matrix_mdev is NULL or is not attached to a KVM guest, the KVM\n- *\t lock will not be released.\n- */\n-static inline void release_update_locks_for_mdev(struct ap_matrix_mdev *matrix_mdev)\n-{\n-\tmutex_unlock(\u0026matrix_dev-\u003emdevs_lock);\n-\tif (matrix_mdev \u0026\u0026 matrix_mdev-\u003ekvm)\n-\t\tmutex_unlock(\u0026matrix_mdev-\u003ekvm-\u003elock);\n-\tmutex_unlock(\u0026matrix_dev-\u003eguests_lock);\n-}\n-\n /**\n * get_update_locks_by_apqn: Find the mdev to which an APQN is assigned and\n *\t\t\t acquire the locks required to update the APCB of\n@@ -649,8 +602,7 @@ static int handle_pqap(struct kvm_vcpu *vcpu)\n \treturn 0;\n }\n \n-static void vfio_ap_matrix_init(struct ap_config_info *info,\n-\t\t\t\tstruct ap_matrix *matrix)\n+void vfio_ap_matrix_init(struct ap_config_info *info, struct ap_matrix *matrix)\n {\n \tmatrix-\u003eapm_max = info-\u003eapxa ? info-\u003ena : 63;\n \tmatrix-\u003eaqm_max = info-\u003eapxa ? info-\u003end : 15;\n@@ -794,6 +746,16 @@ static int vfio_ap_mdev_init_dev(struct vfio_device *vdev)\n \treturn 0;\n }\n \n+static void vfio_ap_mdev_release_dev(struct vfio_device *vdev)\n+{\n+\tstruct ap_matrix_mdev *matrix_mdev;\n+\n+\tmutex_lock(\u0026matrix_dev-\u003emdevs_lock);\n+\tmatrix_mdev = container_of(vdev, struct ap_matrix_mdev, vdev);\n+\tvfio_ap_release_migration_data(matrix_mdev);\n+\tmutex_unlock(\u0026matrix_dev-\u003emdevs_lock);\n+}\n+\n static int vfio_ap_mdev_probe(struct mdev_device *mdev)\n {\n \tstruct ap_matrix_mdev *matrix_mdev;\n@@ -801,9 +763,19 @@ static int vfio_ap_mdev_probe(struct mdev_device *mdev)\n \n \tmatrix_mdev = vfio_alloc_device(ap_matrix_mdev, vdev, \u0026mdev-\u003edev,\n \t\t\t\t\t\u0026vfio_ap_matrix_dev_ops);\n+\n \tif (IS_ERR(matrix_mdev))\n \t\treturn PTR_ERR(matrix_mdev);\n \n+\t/*\n+\t * Setting up for vfio device migration must be done before calling\n+\t * vfio_register_emulated_iommu_dev; otherwise, the VFIO core\n+\t * will see mig_ops as NULL during the registration. This could\n+\t * prevent the VFIO core from properly setting up migration\n+\t * infrastructure like debugfs entries.\n+\t */\n+\tvfio_ap_setup_vfio_device_migration(matrix_mdev);\n+\n \tret = vfio_register_emulated_iommu_dev(\u0026matrix_mdev-\u003evdev);\n \tif (ret)\n \t\tgoto err_put_vdev;\n@@ -2059,19 +2031,39 @@ static int vfio_ap_mdev_reset_qlist(struct list_head *qlist)\n \n static int vfio_ap_mdev_open_device(struct vfio_device *vdev)\n {\n-\tstruct ap_matrix_mdev *matrix_mdev =\n-\t\tcontainer_of(vdev, struct ap_matrix_mdev, vdev);\n+\tstruct ap_matrix_mdev *matrix_mdev;\n+\tint ret;\n \n \tif (!vdev-\u003ekvm)\n \t\treturn -EINVAL;\n \n-\treturn vfio_ap_mdev_set_kvm(matrix_mdev, vdev-\u003ekvm);\n+\tmutex_lock(\u0026matrix_dev-\u003emdevs_lock);\n+\tmatrix_mdev = container_of(vdev, struct ap_matrix_mdev, vdev);\n+\tret = vfio_ap_init_migration_data(matrix_mdev);\n+\tmutex_unlock(\u0026matrix_dev-\u003emdevs_lock);\n+\n+\tif (ret)\n+\t\treturn ret;\n+\n+\tret = vfio_ap_mdev_set_kvm(matrix_mdev, vdev-\u003ekvm);\n+\tif (ret) {\n+\t\t/* Clean up migration data on failure */\n+\t\tmutex_lock(\u0026matrix_dev-\u003emdevs_lock);\n+\t\tvfio_ap_release_migration_data(matrix_mdev);\n+\t\tmutex_unlock(\u0026matrix_dev-\u003emdevs_lock);\n+\t}\n+\n+\treturn ret;\n }\n \n static void vfio_ap_mdev_close_device(struct vfio_device *vdev)\n {\n-\tstruct ap_matrix_mdev *matrix_mdev =\n-\t\tcontainer_of(vdev, struct ap_matrix_mdev, vdev);\n+\tstruct ap_matrix_mdev *matrix_mdev;\n+\n+\tmutex_lock(\u0026matrix_dev-\u003emdevs_lock);\n+\tmatrix_mdev = container_of(vdev, struct ap_matrix_mdev, vdev);\n+\tvfio_ap_release_migration_data(matrix_mdev);\n+\tmutex_unlock(\u0026matrix_dev-\u003emdevs_lock);\n \n \tvfio_ap_mdev_unset_kvm(matrix_mdev);\n }\n@@ -2105,6 +2097,14 @@ static void vfio_ap_mdev_request(struct vfio_device *vdev, unsigned int count)\n \trelease_update_locks_for_mdev(matrix_mdev);\n }\n \n+unsigned int vfio_ap_mdev_get_num_queues(struct ap_matrix *ap_matrix)\n+{\n+\tlockdep_assert_held(\u0026matrix_dev-\u003emdevs_lock);\n+\n+\treturn bitmap_weight(ap_matrix-\u003eapm, AP_DEVICES) *\n+\t bitmap_weight(ap_matrix-\u003eaqm, AP_DOMAINS);\n+}\n+\n static int vfio_ap_mdev_get_device_info(unsigned long arg)\n {\n \tunsigned long minsz;\n@@ -2282,6 +2282,17 @@ static ssize_t vfio_ap_mdev_ioctl(struct vfio_device *vdev,\n \t\tbreak;\n \tcase VFIO_DEVICE_RESET:\n \t\tret = vfio_ap_mdev_reset_queues(matrix_mdev);\n+\t\t/*\n+\t\t * Reset the migration state unconditionally, regardless of\n+\t\t * whether the hardware queue reset succeeded. The migration\n+\t\t * state tracks the AP configuration transfer lifecycle and is\n+\t\t * independent of the hardware queue reset outcome. The VFIO\n+\t\t * migration spec designates VFIO_DEVICE_RESET as the mechanism\n+\t\t * to return device_state to RUNNING (e.g. to recover from\n+\t\t * ERROR), so the migration state must be cleaned up even when\n+\t\t * one or more queues fail to reset.\n+\t\t */\n+\t\tvfio_ap_reset_migration_state(matrix_mdev);\n \t\tbreak;\n \tcase VFIO_DEVICE_GET_IRQ_INFO:\n \t\tret = vfio_ap_get_irq_info(arg);\n@@ -2389,6 +2400,7 @@ static const struct attribute_group vfio_queue_attr_group = {\n \n static const struct vfio_device_ops vfio_ap_matrix_dev_ops = {\n \t.init = vfio_ap_mdev_init_dev,\n+\t.release = vfio_ap_mdev_release_dev,\n \t.open_device = vfio_ap_mdev_open_device,\n \t.close_device = vfio_ap_mdev_close_device,\n \t.ioctl = vfio_ap_mdev_ioctl,\ndiff --git a/drivers/s390/crypto/vfio_ap_private.h b/drivers/s390/crypto/vfio_ap_private.h\nindex 9bff666b0b35d..d44188f122213 100644\n--- a/drivers/s390/crypto/vfio_ap_private.h\n+++ b/drivers/s390/crypto/vfio_ap_private.h\n@@ -91,6 +91,9 @@ struct ap_queue_table {\n \tDECLARE_HASHTABLE(queues, 8);\n };\n \n+/* Forward declaration for migration data structure */\n+struct vfio_ap_migration_data;\n+\n /**\n * struct ap_matrix_mdev - Contains the data associated with a matrix mediated\n *\t\t\t device.\n@@ -110,6 +113,7 @@ struct ap_queue_table {\n * @aqm_add:\tbitmap of APQIs added to the host's AP configuration\n * @adm_add:\tbitmap of control domain numbers added to the host's AP\n *\t\tconfiguration\n+ * @mig_data: vfio device migration data\n */\n struct ap_matrix_mdev {\n \tstruct vfio_device vdev;\n@@ -125,6 +129,7 @@ struct ap_matrix_mdev {\n \tDECLARE_BITMAP(apm_add, AP_DEVICES);\n \tDECLARE_BITMAP(aqm_add, AP_DOMAINS);\n \tDECLARE_BITMAP(adm_add, AP_DOMAINS);\n+\tstruct vfio_ap_migration_data *mig_data;\n };\n \n /**\n@@ -152,6 +157,8 @@ struct vfio_ap_queue {\n \tstruct work_struct reset_work;\n };\n \n+unsigned int vfio_ap_mdev_get_num_queues(struct ap_matrix *ap_matrix);\n+\n int vfio_ap_mdev_register(void);\n void vfio_ap_mdev_unregister(void);\n \n@@ -165,4 +172,67 @@ void vfio_ap_on_cfg_changed(struct ap_config_info *new_config_info,\n void vfio_ap_on_scan_complete(struct ap_config_info *new_config_info,\n \t\t\t struct ap_config_info *old_config_info);\n \n+int vfio_ap_init_migration_data(struct ap_matrix_mdev *matrix_mdev);\n+void vfio_ap_setup_vfio_device_migration(struct ap_matrix_mdev *matrix_mdev);\n+void vfio_ap_release_migration_data(struct ap_matrix_mdev *matrix_mdev);\n+void vfio_ap_reset_migration_state(struct ap_matrix_mdev *matrix_mdev);\n+\n+/**\n+ * get_update_locks_for_mdev: Acquire the locks required to dynamically update a\n+ *\t\t\t KVM guest's APCB in the proper order.\n+ *\n+ * @matrix_mdev: a pointer to a struct ap_matrix_mdev object containing the AP\n+ *\t\t configuration data to use to update a KVM guest's APCB.\n+ *\n+ * The proper locking order is:\n+ * 1. matrix_dev-\u003eguests_lock: required to use the KVM pointer to update a KVM\n+ *\t\t\t guest's APCB.\n+ * 2. matrix_mdev-\u003ekvm-\u003elock: required to update a guest's APCB\n+ * 3. matrix_dev-\u003emdevs_lock: required to access data stored in a matrix_mdev\n+ *\n+ * Note: If @matrix_mdev is NULL or is not attached to a KVM guest, the KVM\n+ *\t lock will not be taken.\n+ */\n+static inline void get_update_locks_for_mdev(struct ap_matrix_mdev *matrix_mdev)\n+{\n+\tmutex_lock(\u0026matrix_dev-\u003eguests_lock);\n+\tif (matrix_mdev \u0026\u0026 matrix_mdev-\u003ekvm)\n+\t\tmutex_lock(\u0026matrix_mdev-\u003ekvm-\u003elock);\n+\tmutex_lock(\u0026matrix_dev-\u003emdevs_lock);\n+}\n+\n+/**\n+ * release_update_locks_for_mdev: Release the locks used to dynamically update a\n+ *\t\t\t\t KVM guest's APCB in the proper order.\n+ *\n+ * @matrix_mdev: a pointer to a struct ap_matrix_mdev object containing the AP\n+ *\t\t configuration data to use to update a KVM guest's APCB.\n+ *\n+ * The proper unlocking order is:\n+ * 1. matrix_dev-\u003emdevs_lock\n+ * 2. matrix_mdev-\u003ekvm-\u003elock\n+ * 3. matrix_dev-\u003eguests_lock\n+ *\n+ * Note: If @matrix_mdev is NULL or is not attached to a KVM guest, the KVM\n+ *\t lock will not be released.\n+ */\n+static inline void release_update_locks_for_mdev(struct ap_matrix_mdev *matrix_mdev)\n+{\n+\tmutex_unlock(\u0026matrix_dev-\u003emdevs_lock);\n+\tif (matrix_mdev \u0026\u0026 matrix_mdev-\u003ekvm)\n+\t\tmutex_unlock(\u0026matrix_mdev-\u003ekvm-\u003elock);\n+\tmutex_unlock(\u0026matrix_dev-\u003eguests_lock);\n+}\n+\n+static inline void\n+assert_has_update_locks_for_mdev(struct ap_matrix_mdev *matrix_mdev)\n+{\n+\tlockdep_assert_held(\u0026matrix_dev-\u003eguests_lock);\n+\tif (matrix_mdev \u0026\u0026 matrix_mdev-\u003ekvm)\n+\t\tlockdep_assert_held(\u0026matrix_mdev-\u003ekvm-\u003elock);\n+\tlockdep_assert_held(\u0026matrix_dev-\u003emdevs_lock);\n+}\n+\n+void vfio_ap_matrix_init(struct ap_config_info *info, struct ap_matrix *matrix);\n+\n #endif /* _VFIO_AP_PRIVATE_H_ */\n"
} |
| 2/1 | 2026/10/24 07:10 | agent | patch-evaluator |
2mModel:core Args: null Results: {
"EnableConfigs": null,
"FocusSymbols": [],
"Reasoning": "The patch modifies documentation and the vfio_ap driver in drivers/s390/crypto/, implementing live guest migration support for s390 AP devices. These files and configs (CONFIG_VFIO_AP, CONFIG_S390) are exclusive to the s390 architecture and cannot be compiled or executed on the target architecture (amd64). Consequently, all modified executable paths are structurally unreachable on amd64.",
"WorthFuzzing": false
}Instruction: You are an expert Linux kernel maintainer and security engineer.
Your job is to review a provided patch series and evaluate whether it warrants fuzzing with syzkaller.
IMPORTANT: The changes have ALREADY been applied and committed as the HEAD commit in
your workspace. Do NOT rely on internal assumptions. You must actively use your code access
tools to inspect the actual source code, callers, and surrounding context.
================================================================================
1. CORE TRIAGE PHILOSOPHY
================================================================================
The goal of patch fuzzing is to discover crashes, regressions, exposed latent bugs,
and newly triggered assertions introduced by the patch series.
- REACHABILITY IS THE PRIMARY GATE:
Fuzzing can only discover bugs in code that can actually execute in standard virtualized
environments (GCE or QEMU, utilizing software-emulated devices like USB gadgets, netdev, tun/tap).
If the modified code is structurally unreachable (see Section 2), it MUST NOT be fuzzed,
regardless of whether it adds assertions or complex logic.
- DO NOT BLINDLY TRUST "NO FUNCTIONAL CHANGE" (NFCI) OR "REFACTORING" CLAIMS:
Patch authors routinely label changes as "cleanups", "refactorings", or state
"No functional change intended". Do NOT take these claims at face value.
Code refactorings that rearrange logic, introduce helper functions, or alter state management
in core subsystems frequently introduce subtle semantic shifts or uncover latent kernel bugs.
If reachable executable code is modified or refactored, it MUST be fuzzed.
- NEW OR MODIFIED ASSERTIONS IN REACHABLE CODE MUST BE FUZZED:
When a patch introduces or modifies runtime checks or assertions (e.g., WARN_ON*, VM_WARN_ON*,
BUG_ON*, lockdep_assert*) in reachable code paths, it enforces new or stricter invariants.
Even if the author believes the invariant always holds, fuzzing is essential to verify whether
an unusual sequence of operations can violate it.
================================================================================
2. WHEN TO RETURN WorthFuzzing=false (NEGATIVE CRITERIA)
================================================================================
Return WorthFuzzing=false ONLY IF all modified code falls strictly into one or more of these categories:
- Non-kernel and non-executable changes:
* Modifications to Documentation/, comments, or spelling fixes.
* User-space directories, self-tests, samples, or scripts (e.g., tools/, samples/, scripts/, usr/)
that do not affect the compiled kernel image (vmlinux) or kernel modules.
* Purely decorative logging (e.g., message strings in pr_err, printk, dev_info) or tracepoints
that do not alter control flow or data structures.
* Build system or Kconfig changes that do not alter compiled C logic.
- Structurally unreachable hardware:
* Vendor-specific PCIe switches, SmartNICs, or GPU drivers (e.g., mlxsw, pds_core, qed,
ionic, amdgpu) requiring physical ASIC/PCIe cards not emulated in standard QEMU.
- Unreachable execution paths:
* Driver teardown callbacks (.remove, .shutdown, pci_unregister_driver) executed only during
physical PCI hot-unplug or manual sysfs driver unbinding.
* Code paths exclusive to architectures other than the target architecture.
================================================================================
3. WHEN TO RETURN WorthFuzzing=true (POSITIVE CRITERIA)
================================================================================
Return WorthFuzzing=true whenever the patch touches reachable executable code, including:
- Core Subsystems:
* Any logic modifications in memory management (mm/), synchronization/locking (kernel/locking/),
BPF, scheduler, core networking, VFS, or syscall handling.
- Refactorings and Code Cleanups:
* Any restructuring of reachable data structures, helper abstractions, or algorithm flows.
- Runtime Assertions and Defensive Checks:
* Any introduction or alteration of assertions (WARN_ON*, VM_WARN_ON*, BUG_ON*, etc.) in reachable paths.
- Reachable Drivers and Protocols:
* Drivers accessible via virtual buses (virtio, USB gadget, loopback, netlink, binder, sockets, etc.).
================================================================================
4. EXTRACTING FocusSymbols (PREVENTING DILUTION)
================================================================================
When WorthFuzzing=true, you must extract specific kernel functions into FocusSymbols to guide the fuzzer:
- AVOID UBIQUITOUS LIFECYCLE HOT-PATHS:
Do NOT list generic, ubiquitous functions called by almost every program in the corpus
(including, but not limited to: general memory allocators and deallocators, page fault
and trap handlers, or core synchronization primitives; this is not an exhaustive list).
Listing ubiquitous functions causes the fuzzer to classify thousands of unrelated tests as "focused",
which severely dilutes fuzzing effort away from the actual changes.
- TARGET SPECIFIC FEATURE LOGIC AND ENTRYPOINTS:
List functions that specifically implement the logic being added or altered, or direct API entrypoints
for the subsystem feature under review.
- HANDLING STATIC INLINE FUNCTIONS IN HEADERS (.h):
Compiler-inlined static functions (such as static inlines in mm/*.h or include/linux/*.h) lack
distinct symbol addresses in vmlinux and cannot be targeted directly by symbol coverage filters.
If the changes are primarily in static inline helpers, identify non-static, feature-specific caller
functions in .c files that exercise them (avoiding ubiquitous lifecycle wrappers).
================================================================================
5. IDENTIFYING EnableConfigs
================================================================================
Identify any specific CONFIG_ options required to properly compile and reach the modified code:
- Inspect Kconfig files and #ifdef guards; do not make assumptions.
- Check "depends on" lines in Kconfig to include any non-standard parent subsystem configs needed.
- Strip any 'CONFIG_' prefix (e.g., return "NET_IPV4" instead of "CONFIG_NET_IPV4").
Prefer calling several tools at the same time to save round-trips.
Use set-results tool to provide results of the analysis.
It must be called exactly once before the final reply.
Ignore results of this tool.
Prompt: Target architecture: amd64
For your convenience, here is the diff of the changes:
commit d3532194b313f1184bbcee2279afd0ce7dcbbbd9
Author: syz-cluster <triage@syzkaller.com>
Date: Sat Oct 24 07:10:26 2026 +0000
syz-cluster: applied patch under review
diff --git a/Documentation/arch/s390/vfio-ap.rst b/Documentation/arch/s390/vfio-ap.rst
index ac0c07f76ddd7..f5d9e32875035 100644
--- a/Documentation/arch/s390/vfio-ap.rst
+++ b/Documentation/arch/s390/vfio-ap.rst
@@ -1012,7 +1012,7 @@ guest_matrix dyn ap_config
the following features are advertised:
----------------+---------------------------------------------------------------+
++--------------+---------------------------------------------------------------+
| Flag | Description |
+==============+===============================================================+
| guest_matrix | guest_matrix attribute exists. It reports the matrix of |
@@ -1021,105 +1021,548 @@ the following features are advertised:
+--------------+---------------------------------------------------------------+
| dyn | Indicates hot plug/unplug of AP adapters, domains and control |
| | domains for a guest to which the mdev is attached. |
-+------------+-----------------------------------------------------------------+
++--------------+---------------------------------------------------------------+
| ap_config | ap_config interface for one-shot modifications to mdev config |
+--------------+---------------------------------------------------------------+
+| migration | Indicates that live guest migration is supported for guests |
+| | to which crypto devices are passed through |
++--------------+---------------------------------------------------------------+
-Limitations
-===========
-Live guest migration is not supported for guests using AP devices without
-intervention by a system administrator. Before a KVM guest can be migrated,
-the vfio_ap mediated device must be removed. Unfortunately, it can not be
-removed manually (i.e., echo 1 > /sys/devices/vfio_ap/matrix/$UUID/remove) while
-the mdev is in use by a KVM guest. If the guest is being emulated by QEMU,
-its mdev can be hot unplugged from the guest in one of two ways:
-
-1. If the KVM guest was started with libvirt, you can hot unplug the mdev via
- the following commands:
-
- virsh detach-device <guestname> <path-to-device-xml>
-
- For example, to hot unplug mdev 62177883-f1bb-47f0-914d-32a22e3a8804 from
- the guest named 'my-guest':
-
- virsh detach-device my-guest ~/config/my-guest-hostdev.xml
-
- The contents of my-guest-hostdev.xml:
-
-.. code-block:: xml
-
- <hostdev mode='subsystem' type='mdev' managed='no' model='vfio-ap'>
- <source>
- <address uuid='62177883-f1bb-47f0-914d-32a22e3a8804'/>
- </source>
- </hostdev>
-
-
- virsh qemu-monitor-command <guest-name> --hmp "device-del <device-id>"
-
- For example, to hot unplug the vfio_ap mediated device identified on the
- qemu command line with 'id=hostdev0' from the guest named 'my-guest':
-
-.. code-block:: sh
-
- virsh qemu-monitor-command my-guest --hmp "device_del hostdev0"
-
-2. A vfio_ap mediated device can be hot unplugged by attaching the qemu monitor
- to the guest and using the following qemu monitor command:
-
- (QEMU) device-del id=<device-id>
-
- For example, to hot unplug the vfio_ap mediated device that was specified
- on the qemu command line with 'id=hostdev0' when the guest was started:
-
- (QEMU) device-del id=hostdev0
-
-After live migration of the KVM guest completes, an AP configuration can be
-restored to the KVM guest by hot plugging a vfio_ap mediated device on the target
-system into the guest in one of two ways:
-
-1. If the KVM guest was started with libvirt, you can hot plug a matrix mediated
- device into the guest via the following virsh commands:
-
- virsh attach-device <guestname> <path-to-device-xml>
-
- For example, to hot plug mdev 62177883-f1bb-47f0-914d-32a22e3a8804 into
- the guest named 'my-guest':
-
- virsh attach-device my-guest ~/config/my-guest-hostdev.xml
-
- The contents of my-guest-hostdev.xml:
-
-.. code-block:: xml
-
- <hostdev mode='subsystem' type='mdev' managed='no' model='vfio-ap'>
- <source>
- <address uuid='62177883-f1bb-47f0-914d-32a22e3a8804'/>
- </source>
- </hostdev>
-
-
- virsh qemu-monitor-command <guest-name> --hmp \
- "device_add vfio-ap,sysfsdev=<path-to-mdev>,id=<device-id>"
-
- For example, to hot plug the vfio_ap mediated device
- 62177883-f1bb-47f0-914d-32a22e3a8804 into the guest named 'my-guest' with
- device-id hostdev0:
-
- virsh qemu-monitor-command my-guest --hmp \
- "device_add vfio-ap,\
- sysfsdev=/sys/devices/vfio_ap/matrix/62177883-f1bb-47f0-914d-32a22e3a8804,\
- id=hostdev0"
-
-2. A vfio_ap mediated device can be hot plugged by attaching the qemu monitor
- to the guest and using the following qemu monitor command:
-
- (qemu) device_add "vfio-ap,sysfsdev=<path-to-mdev>,id=<device-id>"
-
- For example, to plug the vfio_ap mediated device
- 62177883-f1bb-47f0-914d-32a22e3a8804 into the guest with the device-id
- hostdev0:
+Live Guest Migration
+====================
+The VFIO AP mediated device is not used to provide userspace with direct
+access to device memory as is the case with other devices that use the VFIO
+framework for device pass-through. Instead, it manages AP
+configuration metadata identifying the adapters, domains, and control
+domains to which a guest will be granted access. These AP resources are
+configured by assigning them to a vfio-ap mediated device via its sysfs
+assignment interfaces. When the guest is started, the vfio_ap device driver
+sets the guest's AP configuration from the metadata stored with the mediated
+device. The AP devices are not accessed directly through the vfio_ap driver,
+so the driver does not migrate the state of the AP devices themselves.
+Instead, it migrates the AP configuration metadata. The vfio_ap device
+driver on the destination host will then ensure that the AP configuration
+metadata migrated from the source host is compatible with the AP
+configuration available on the destination host and if
+so, will set the destination guest's AP configuration accordingly.
- (QEMU) device-add "vfio-ap,\
- sysfsdev=/sys/devices/vfio_ap/matrix/62177883-f1bb-47f0-914d-32a22e3a8804,\
- id=hostdev0"
+To be considered compatible, the AP configuration for the destination host must
+meet these requirements:
+
+* Each AP adapter, domain and control domain number assigned to the source
+ guest's AP configuration must be in the destination host's AP
+ configuration. This can be verified as follows:
+
+ * On the source host, display the AP configuration of the source guest
+ with the following two commands:
+
+ .. code-block:: bash
+
+ cat /sys/devices/vfio_ap/matrix/$UUID/guest_matrix
+ cat /sys/devices/vfio_ap/matrix/$UUID/control_domains
+
+ .. note::
+ Replace ``$UUID`` with the actual UUID of your mediated device.
+
+ The ``guest_matrix`` lists the APQNs of the queue devices assigned
+ to the mediated device; for example:
+
+ .. code-block:: bash
+
+ 00.0033
+ 00.003a
+
+ The ``control_domains`` lists the domain numbers of the control
+ domains; for example:
+
+ .. code-block:: bash
+
+ 0033
+ 003a
+
+ * Display the AP configuration of the destination host with the following
+ two commands:
+
+ .. code-block:: bash
+
+ lszcrypt -V
+ cat /sys/bus/ap/ap_control_domain_mask
+
+ .. note::
+ The ``lszcrypt -V`` command lists the AP cards (adapters) and queue
+ devices on the host system; for example:
+
+ .. code-block:: bash
+
+ =========== ===== ============ ==========
+ CARD.DOMAIN TYPE MODE DRIVER
+ =========== ===== ============ ==========
+ 00 CEX5C CCA-Coproc cex4card
+ 00.0033 CEX5C CCA-Coproc vfio_ap
+ 00.003a CEX5C CCA-Coproc vfio_ap
+ =========== ===== ============ ==========
+
+ Each bit in the ap_control_domain_mask corresponds to
+ domain numbers 0-255. If a bit is set to one, then
+ the control domain is available on the destination host. For
+ example:
+
+ .. code-block:: bash
+
+ 0x0000000000001020000000000000000000000000000000000000000000000000
+
+ This mask indicates that AP control domains 51 (0x33) and 58 (0x3a) are
+ in the AP configuration of the host system.
+
+ * Verify the configurations:
+
+ * Each APQN in the guest's sysfs ``guest_matrix`` file must match an
+ APQN returned from the ``lszcrypt -V`` command on the destination host. It
+ is important to note the driver to which the queue is bound which
+ is displayed in the ``driver`` column. Queues not bound to the vfio_ap
+ driver are not available to the destination guest. Even if the APQNs are
+ available to the driver, that does not guarantee they can be used by the
+ guest being migrated; for example, migration will fail if any of these APQNs
+ are assigned to a mediated device other than the one being migrated.
+
+ * Each domain number from the source guest's sysfs
+ ``control_domains`` attribute must correspond to a bit set to one in
+ the destination host's ``ap_control_domain_mask``.
+
+
+* Each APQN assigned to the source guest and destination guest must
+ reference a queue device with compatible hardware capabilities:
+
+ +--------------+---------------------------------------------------------------+
+ | Hardware | Description |
+ | Capabilities | |
+ +==============+===============================================================+
+ | [1] | * AP special command facility (APSC) |
+ | Facilities | * AP 4096-bit ME PKU commands facility (AP4KM) |
+ | | * AP 4096-bit CRT PKU commands (AP4KC) |
+ +--------------+---------------------------------------------------------------+
+ | [1] Mode | * CCA-mode |
+ | | * Accelerator-mode |
+ | | * XCP-mode (EP11) |
+ +--------------+---------------------------------------------------------------+
+ | [1] AP | APXA installed |
+ | extended | |
+ | addressing | |
+ +--------------+---------------------------------------------------------------+
+ | [1] Command | Command filtering available |
+ | filtering | |
+ +--------------+---------------------------------------------------------------+
+ | [2] | * Full native card function |
+ | Functional | * Only stateless functions |
+ | capabilities | |
+ +--------------+---------------------------------------------------------------+
+ | [3] AP type | * 10 (0x0a): CEX4 |
+ | | * 11 (0x0b): CEX5 |
+ | | * 12 (0x0c) CEX6 |
+ | | * 13 (0x0d) CEX7 |
+ | | * 14 (0x0e) CEX8 |
+ +--------------+---------------------------------------------------------------+
+
+ +-----------------------------------------------------------------------------+
+ | Table Keys |
+ +=============================================================================+
+ | |
+ | [1] The hardware capability must be the same for both the source |
+ | and destination queue device. |
+ | |
+ | [2] The source and destination queues must either both have |
+ | full native card function or both have stateless functions. |
+ | If the functional capabilities don't match, then the source |
+ | queue can have stateless capabilities since full native card |
+ | function can handle stateless functions; otherwise, migration |
+ | will fail. |
+ | |
+ | [3] The AP type on the source and destination guests can |
+ | differ if the queue passed through to the target guest is a |
+ | newer model (backwards compatible) |
+ +-----------------------------------------------------------------------------+
+
+ * To verify the hardware capabilities are compatible:
+
+ * On both the source and destination hosts, display the hardware capabilities
+ for each AP adapter in the AP configuration for that host:
+
+ .. code-block:: bash
+
+ cat /sys/bus/ap/devices/card$APID/ap_functions
+
+ .. note::
+ The ``$APID`` is the two-character adapter number in hexadecimal format;
+ for example, ``card02`` or ``card1f``. The ``/sys/bus/ap/devices`` directory
+ also lists the APQNs of the queue devices installed in the respective
+ host system with the first two characters being the APID; for example:
+ ``02.0004`` or ``00.0033`` .
+
+ * Verify the hardware capabilities for each AP adapter device on the source
+ and destination host are compatible. The ``ap_functions`` attribute is a
+ bitmask. The bits in the mask read from left to right starting with bit 0.
+ Each bit that is set to one indicates the corresponding hardware capability
+ is installed:
+
+ * Bits 0-2 are the facilities bits. Each bit value must match for the AP
+ devices on the source and destination systems. The values indicate the
+ following:
+
+ * bit-0: APSC is installed
+ * bit-1: AP4KM is installed
+ * bit-2: AP4KC is installed
+
+ * Bits 3-5 specify the adapter Modes. Only one of these bits will be set to
+ one and must be the same for both the source and destination adapter
+ devices:
+
+ * bit-3: CCA-mode
+ * bit-4: Accelerator-mode
+ * bit-5: XCP-mode (EP11)
+
+ * Bit 6 specifies whether APXA is installed and must be the same for both
+ the source and destination adapter devices.
+
+ * Bit 7 specifies whether command filtering is installed
+ and must be the same for both the source and destination adapter devices.
+
+ * Bits 8-15 are the classification bits. There are only two relevant
+ bits and only one of them will be set to one. For the source and destination
+ adapter devices to be considered compatible:
+
+ * Bit 8 may be set to 1 on both hosts (full native card function)
+ * Bit 9 may be set to 1 on both hosts (only stateless functions available)
+ * Bit 9 may be set to 1 on the source host and bit 8 may be set to 1 on
+ the destination host
+
+ * Bits 16-17 are the binding state bits which must be 00
+
+ * To verify the AP types are compatible:
+
+ * On both the source and destination hosts, display the hardware type
+ for each AP adapter in the AP configuration for that host to ensure the
+ source and destination adapter types are the same, or the source type is
+ less than the destination type::
+
+ cat /sys/bus/ap/devices/card$APID/hwtype
+
+ .. note::
+ The ``$APID`` is the two-character adapter number in hexadecimal format;
+ for example, ``card02`` or ``card1f``.
+
+Setting up for live guest migration on the destination host
+-----------------------------------------------------------
+To set up a host as the destination for live guest migration, do the
+following:
+
+1. Create a mediated device
+~~~~~~~~~~~~~~~~~~~~~~~~~~~
+Create a mediated device with the same name (UUID) as the mediated device
+used to supply the AP configuration to the source guest. For example, if
+the mediated device on the source guest is named
+62177883-f1bb-47f0-914d-32a22e3a8804:
+
+.. code-block:: bash
+
+ echo 62177883-f1bb-47f0-914d-32a22e3a8804 > \
+ /sys/devices/vfio_ap/matrix/mdev_supported_types/vfio_ap-passthrough/create
+
+2. Reserve adapters and domains for the vfio_ap device driver's use
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+Reserve the same adapters and domains passed through to the source guest
+for the vfio_ap device driver on the destination host by clearing the
+adapter numbers from the ``/sys/bus/ap/apmask`` and/or the domain numbers
+from the ``/sys/bus/ap/aqmask`` files.
+
+For example, suppose adapters 0, 20 (0x14) and 22 (0x16) as well as
+domains 51 (0x33) and 58 (0x3a) are passed through to the source guest. To
+ensure they can be passed through to the destination guest, they must be
+made available to the vfio_ap device driver on the destination host. To
+make them available, do one or both of the following on the destination host:
+
+.. code-block:: bash
+
+ echo -0,-0x14,-22 > /sys/bus/ap/apmask
+ echo -0,-0x33,-0x3a > /sys/bus/ap/aqmask
+
+.. note::
+
+ * It is not necessary to reserve both the adapters and domains.
+ Reserving an adapter implicitly allows the vfio_ap driver to assign
+ each of the domains available on the system along with the reserved
+ adapters to a guest's AP configuration and vice versa.
+
+ * The Cartesian product of the adapters and domains reserved for the
+ vfio_ap device driver identifies the APQNs of the AP queue devices to be
+ bound to the vfio_ap device driver. If an APQN does not reference a
+ queue device installed in the system at the time of live guest migration,
+ the migration will fail.
+
+ * To verify that the queue devices are reserved for the vfio_ap
+ device driver, issue the ``lszcrypt -V`` command and you should
+ see ``vfio_ap`` in the ``DRIVER`` column of the output.
+
+3. Assign adapters, domains and control domains to the destination mediated device
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+Assign the same adapters, domains and control domains to the destination
+mediated device as are assigned to the source guest's mediated device. For
+example, using the same adapters, domains and control domains from the
+previous step:
+
+.. code-block:: bash
+
+ echo 0x0 > /sys/devices/vfio_ap/matrix/62177883-f1bb-47f0-914d-32a22e3a8804/assign_adapter
+ echo 0x14 > /sys/devices/vfio_ap/matrix/62177883-f1bb-47f0-914d-32a22e3a8804/assign_adapter
+ echo 0x16 > /sys/devices/vfio_ap/matrix/62177883-f1bb-47f0-914d-32a22e3a8804/assign_adapter
+ echo 0x33 > /sys/devices/vfio_ap/matrix/62177883-f1bb-47f0-914d-32a22e3a8804/assign_domain
+ echo 0x3a > /sys/devices/vfio_ap/matrix/62177883-f1bb-47f0-914d-32a22e3a8804/assign_domain
+
+.. note::
+
+ * The destination mediated device must be configured with at least the
+ adapters, domains and control domains that are actively in use by the
+ source guest (i.e., present in the source mdev's AP configuration
+ shadow). Migration will fail if any APQN or control domain from the
+ source guest's AP configuration is not present in the destination
+ mdev's AP configuration shadow.
+
+ * The destination mediated device may be configured with a superset of
+ the source guest's active AP configuration. Any additionally assigned
+ resources that are available on the destination host will be accessible
+ to the guest after migration completes.
+
+Live guest migration failures due to AP configuration errors
+------------------------------------------------------------
+This section describes the errors that may occur during live guest migration
+when the AP configuration of the source guest and destination host are not
+compatible and where to look for problem determination.
+
+The destination host is missing the mediated device
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+This error occurs when a mediated device with the same name (UUID) as the
+mediated device being migrated has not been created on the destination host.
+
+**Source host**
+
++--------------+----------------------------------------------------------------+
+| Log | Message |
++==============+================================================================+
+| Console log: | error: device not found: mediated device '$UUID' not |
+| | found |
++--------------+----------------------------------------------------------------+
+| QEMU log: | initiating migration |
+| | qemu-system-s390x: Sibling indicated error 1 |
++--------------+----------------------------------------------------------------+
+
+.. note::
+ $UUID is the UUID of the mediated device being migrated from the source host.
+
+
+One or more queues are not bound to the vfio_ap driver on the destination host
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+The queue devices passed through to the source guest are not installed in the
+destination host or are not bound to its vfio_ap device driver.
+
+**Source host**
+
++--------------+----------------------------------------------------------------+
+| Log | Message |
++==============+================================================================+
+| Console log: | error: operation failed: migration failed. Message from the |
+| | source host: operation failed: job 'migration out' failed: |
+| | Sibling indicated error 1. Message from the destination host: |
+| | operation failed: job 'migration in' failed: load of migration |
+| | failed: No such device: Failed to load vmstate version_id: 1, |
+| | ret: -19 |
++--------------+----------------------------------------------------------------+
+
+**Destination host**
+
++--------------+----------------------------------------------------------------+
+| Kernel log: | vfio_ap_mdev $UUID: Queue $APID.$APQI not available to |
+| | vfio_ap driver on target host |
++--------------+----------------------------------------------------------------+
+| QEMU log: | shutting down, reason=failed |
+| | qemu-system-s390x: terminating on signal $SIGNAL_NUM from |
+| | pid $PID $DAEMON |
++--------------+----------------------------------------------------------------+
+
+
+One or more control domains are not available on the destination host
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+The control domains passed through to the source guest are not installed on the
+destination host.
+
+**Source host**
+
++--------------+----------------------------------------------------------------+
+| Log | Message |
++==============+================================================================+
+| Console log: | error: operation failed: migration failed. Message from the |
+| | source host: operation failed: job 'migration out' failed: |
+| | Sibling indicated error 1. Message from the destination host: |
+| | operation failed: job 'migration in' failed: load of migration |
+| | failed: No such device: Failed to load vmstate version_id: 1, |
+| | ret: -19 |
++--------------+----------------------------------------------------------------+
+
+**Destination host**
+
++--------------+----------------------------------------------------------------+
+| Kernel log: | vfio_ap_mdev $UUID: Control domain $DOMAIN_NUM not available |
+| | on the destination host |
++--------------+----------------------------------------------------------------+
+| QEMU log: | shutting down, reason=failed |
+| | qemu-system-s390x: terminating on signal $SIGNAL_NUM from |
+| | pid $PID $DAEMON |
++--------------+----------------------------------------------------------------+
+
+
+.. note::
+ * $UUID is the UUID of the mediated device being migrated from the source host.
+ * $APID.$APQI is adapter number and queue index (domain number) comprising the
+ $APQN (for example, 00.0033) of the queue device that is not available.
+ * $SIGNAL_NUM is the signal number that caused the QEMU process to terminate.
+ * $PID is the process ID of the QEMU process on the destination host.
+ * $DAEMON is the name of the QEMU daemon process.
+ * This message will be logged for each queue for which this error is detected.
+
+Failure to get hardware information for a queue device on destination host
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+The vfio_ap device driver on the destination host will execute an AP instruction
+to get the hardware information for a queue device to perform queue compatibility
+checks. The instruction can fail for a number of reasons in which case the
+migration will be terminated.
+
+**Source host**
+
++--------------+----------------------------------------------------------------+
+| Log | Message |
++==============+================================================================+
+| Console log: | error: operation failed: migration failed. Message from the |
+| | source host: operation failed: job 'migration out' failed: |
+| | Sibling indicated error 1. Message from the destination host: |
+| | operation failed: job 'migration in' failed: load of migration |
+| | failed: failed to get hardware information for queue device |
+| | $APQN |
++--------------+----------------------------------------------------------------+
+
+**Destination host**
+
++--------------+----------------------------------------------------------------+
+| Log | Message |
++==============+================================================================+
+| Console log: | vfio_ap_mdev $UUID: Failed to get hwinfo for queue $APQN: |
+| | TAPQ rc=$RESPONSE-CODE |
++--------------+----------------------------------------------------------------+
+| QEMU log: | shutting down, reason=failed |
+| | qemu-system-s390x: terminating on signal $SIGNAL-ID from pid |
+| | $PID $DAEMON |
++--------------+----------------------------------------------------------------+
+
+.. note::
+ * $UUID is the UUID of the mediated device being migrated from the source host.
+ * $APQN (for example, 00.0033) of the queue device that is not compatible.
+ * $RESPONSE_CODE is the response code from the AP instruction.
+ * $SIGNAL_NUM is the signal number of the signal that caused the QEMU process
+ to terminate.
+ * $PID is the process ID of the QEMU process on the destination host.
+ * $DAEMON is the name of the QEMU daemon process.
+ * This message will be logged for each queue for which this error is detected.
+
+The AP configurations of the source guest and destination host not compatible
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+The functional capabilities or facilities available on one or more of the queues
+passed through to the source guest are not compatible with the queue device with
+the same APQN on the destination system (see the Hardware Capabilities table above)
+
+**Source host**
+
++--------------+----------------------------------------------------------------+
+| Log | Message |
++==============+================================================================+
+| Console log: | error: operation failed: migration failed. Message from the |
+| | source host: operation failed: job 'migration out' failed: |
+| | Sibling indicated error 1. Message from the destination host: |
+| | operation failed: job 'migration in' failed: load of migration |
+| | failed: Invalid argument: Failed to load vmstate |
+| | version_id: 1, ret: -22 |
++--------------+----------------------------------------------------------------+
+| Kernel log: | N/A |
++--------------+----------------------------------------------------------------+
+| QEMU log: | *initiating migration* |
+| | |
+| | *qemu-system-s390x: Sibling indicated error 1* |
++--------------+----------------------------------------------------------------+
+
+**Destination host**
+
++--------------+----------------------------------------------------------------+
+| Log | Message |
++==============+================================================================+
+| Console log: | N/A |
++--------------+----------------------------------------------------------------+
+| Kernel log: | *vfio_ap_mdev $UUID: Migration failed: Source and target |
+| | queue ($APQN) not compatible* |
+| | |
+| | The message above will be followed by one or more messages |
+| | enumerating the incompatible features; for example: |
+| | |
+| | ``vfio_ap_mdev $UUID: APSC facility installed in source queue |
+| | $APQN`` |
+| | ``vfio_ap_mdev $UUID: APSC facility not installed in target |
+| | queue $APQN`` |
+| | |
+| | ``vfio_ap_mdev $UUID: AP type of source queue $APQN ($APTYPE1) |
+| | not compatible with target ($APTYPE2)`` ... |
++--------------+----------------------------------------------------------------+
+| QEMU log: | *initiating migration* |
+| | |
+| | *qemu-system-s390x: error while loading state section id ...* |
+| | |
+| | *shutting down, reason=failed* |
+| | |
+| | *terminating on signal $SIGNAL-ID from pid $PID $DAEMON* |
++--------------+----------------------------------------------------------------+
+
+.. note::
+ * $UUID is the UUID of the mediated device being migrated from the source host.
+ * $APQN (for example, 00.0033) of the queue device that is incompatible.
+ * $APTYPE1 is the type of the source queue device.
+ * $APTYPE2 is the type of the target queue device.
+ * $SIGNAL-ID is the signal number of the signal that caused the QEMU process
+ to terminate.
+ * $PROCESS-ID is the process ID of the QEMU process on the source host.
+ * $PID is the process ID of the QEMU process on the destination host.
+ * $DAEMON is the name of the QEMU daemon process.
+ * Each follow-on message logging the incompatibility will be logged for each
+ error detected for the specified queue device.
+
+AP Configuration Management
+---------------------------
+The AP configurations of the source guest and destination host must be kept
+in synchronization or live guest migration will likely fail due to potential
+incompatibilities introduced by such changes. In particular, changing adapter
+or domain reservations via the sysfs ``apmask`` or ``aqmask`` attributes on
+either the source or destination host without coordinating such changes between
+the two hosts -especially while a migration is taking place - can result in
+migration failures.
+
+Configuration stability is an orchestration-layer or system administrator
+responsibility, which is consistent with other VFIO device types. The vfio_ap
+device driver will validate source and destination configurations and provide
+clear diagnostics when incompatibilities are detected, enabling orchestration
+tools to implement appropriate policies; for example, blocking migration when
+such changes are to be made.
+
+Master Key administration
+--------------------------
+It is imperative that s390 Common Cryptographic Architecture (CCA) master key
+administration be performed on both the source and destination AP
+devices to synchronize the key values prior to allowing live guest
+migration. If the master keys do not match, then crypto applications that
+rely on secure keys wrapped by a CCA master key will fail when the guest on
+which they are running is migrated to the destination host. Again, this is
+an orchestration-layer or system administrator responsibility and migration must
+be blocked while master key administration is being performed.
diff --git a/drivers/s390/crypto/Makefile b/drivers/s390/crypto/Makefile
index e83c6603c8587..20f29184825a7 100644
--- a/drivers/s390/crypto/Makefile
+++ b/drivers/s390/crypto/Makefile
@@ -34,5 +34,5 @@ pkey-uv-objs := pkey_uv.o
obj-$(CONFIG_PKEY_UV) += pkey-uv.o
# adjunct processor matrix
-vfio_ap-objs := vfio_ap_drv.o vfio_ap_ops.o
+vfio_ap-objs := vfio_ap_drv.o vfio_ap_ops.o vfio_ap_migration.o
obj-$(CONFIG_VFIO_AP) += vfio_ap.o
diff --git a/drivers/s390/crypto/vfio_ap_drv.c b/drivers/s390/crypto/vfio_ap_drv.c
index 8e69ed286bb9c..c63a050a23569 100644
--- a/drivers/s390/crypto/vfio_ap_drv.c
+++ b/drivers/s390/crypto/vfio_ap_drv.c
@@ -26,9 +26,21 @@ MODULE_LICENSE("GPL v2");
struct ap_matrix_dev *matrix_dev;
debug_info_t *vfio_ap_dbf_info;
+#define VFIO_AP_BASE_FEATURES "guest_matrix hotplug ap_config"
+#define VFIO_AP_SE_EXCLUDED_FEATURES "migration"
+
static ssize_t features_show(struct device *dev, struct device_attribute *attr, char *buf)
{
- return sysfs_emit(buf, "guest_matrix hotplug ap_config\n");
+ /*
+ * SE guests do not support live guest migration; emit only the base
+ * feature set for them.
+ */
+ if (ap_is_se_guest())
+ return sysfs_emit(buf, "%s\n", VFIO_AP_BASE_FEATURES);
+
+ /* Non-SE: base features plus those not available on SE guests */
+ return sysfs_emit(buf, "%s %s\n", VFIO_AP_BASE_FEATURES,
+ VFIO_AP_SE_EXCLUDED_FEATURES);
}
static DEVICE_ATTR_RO(features);
diff --git a/drivers/s390/crypto/vfio_ap_migration.c b/drivers/s390/crypto/vfio_ap_migration.c
new file mode 100644
index 0000000000000..ac135872da2fa
--- /dev/null
+++ b/drivers/s390/crypto/vfio_ap_migration.c
@@ -0,0 +1,1419 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Drives vfio_ap mdev migration.
+ *
+ * Copyright IBM Corp. 2025
+ */
+#include <linux/anon_inodes.h>
+#include <linux/file.h>
+#include <linux/slab.h>
+#include "vfio_ap_private.h"
+
+/* Magic number and version for the vfio_ap_config migration blob */
+#define VFIO_AP_MIG_MAGIC 0x76666170U /* "vfap" */
+#define VFIO_AP_MIG_VERSION 1U
+
+/*
+ * Masks the fields of the queue information returned from the PQAP(TAPQ)
+ * command. In order to migrate a guest, it's AP configuration must be
+ * compatible with AP configuration assigned to the target guest's mdev.
+ * This mask is used to verify that the queue information for each source and
+ * target queue is compatible.
+ *
+ * The following bits must match for the source device and the corresponding
+ * destination device:
+ * -------------------------------------------------------------------------
+ * S bit 0: APSC facility installed
+ * M bit 1: APQKM facility installed
+ * C bit 2: AP4KC facility installed
+ * Mode bits 3-5:
+ * D bit 3: CCA-mode facility
+ * A bit 4: accelerator-mode facility
+ * X bit 5: XCP-mode facility
+ * N bit 6: APXA facility installed
+ * SL bit 7: SLCF facility installed
+ *
+ * Either bit 8 or bit 9 will be set. If bit 8 is set for the source device,
+ * then it must also be set for the corresponding destination device:
+ * -------------------------------------------------------------------------
+ * Classification (functional capabilities) bits 8-15
+ * bit 8: Native card function
+ * bit 9: Only stateless functions
+ *
+ * The BS bits must be set to 0 for both the source and corresponding
+ * destination device:
+ * -------------------------------------------------------------------------
+ * BS bits 16-17:
+ *
+ * The AP type of the source device must be less than or equal to that of
+ * the corresponding destination device:
+ * -------------------------------------------------------------------------
+ * AP Type bits 32-39:
+ */
+#define QINFO_DATA_MASK 0xffffc000ff000000
+
+/*
+ * Masks the bit that indicates whether full native card function is available
+ * from the 8 bits specifying the functional capabilities of a queue
+ */
+#define CLASSIFICATION_NATIVE_FCN_MASK 0x80
+
+/* The maximum number of queues that can be installed in an s390 system */
+#define MAX_AP_QUEUES (AP_DEVICES * AP_DOMAINS)
+
+/* The maximum size of a vfio_ap_config blob, used to pre-allocate the receive
+ * buffer on the destination host during the RESUMING phase of migration.
+ */
+#define VFIO_AP_CONFIG_MAX_SIZE \
+ (sizeof(struct vfio_ap_config) + \
+ MAX_AP_QUEUES * sizeof(struct vfio_ap_queue_info))
+
+/**
+ * struct vfio_ap_migration_file
+ *
+ * This object is used for chunk processing of multiple reads and writes of
+ * AP configuration information.
+ *
+ * @filp: file stream used to read or write AP configuration data
+ * @ap_config: object used to store AP configuration data between read or write
+ * calls
+ * @config_sz: the size (in bytes) of @ap_config
+ */
+struct vfio_ap_migration_file {
+ struct file *filp;
+ struct vfio_ap_config *ap_config;
+ unsigned long config_sz;
+};
+
+/**
+ * struct vfio_ap_migration_data:
+ *
+ * Manages the migration state for the VFIO device that maintains the AP
+ * configuration of the guest being migrated.
+ *
+ * @mig_state: the current migration state
+ * @resuming_mig_data_complete: indicates whether a complete, valid AP
+ * configuration blob was received (true) or not (false)
+ * during the RESUMING phase. This must be checked
+ * on RESUMING->STOP to enforce the vfio.h
+ * requirement that SET_STATE must fail if the data
+ * is incomplete or invalid.
+ * @resuming_mig_file: the object used to restore the state of the
+ * vfio-ap device on the destination host.
+ * @stop_copy_mig_file: the object used to store the AP configuration of
+ * the source guest for transfer to the destination
+ * host.
+ */
+struct vfio_ap_migration_data {
+ enum vfio_device_mig_state mig_state;
+ bool resuming_mig_data_complete;
+ struct vfio_ap_migration_file resuming_mig_file;
+ struct vfio_ap_migration_file stop_copy_mig_file;
+};
+
+/**
+ * struct vfio_ap_queue_info - the information for an AP queue
+ *
+ * @data: contains the queue information returned in GR2 from the PQAP(TAPQ)
+ * command
+ * @apqn: the APQN of the queue
+ * @reserved: padding to ensure consistent structure size across platforms
+ */
+struct vfio_ap_queue_info {
+ u64 data;
+ u16 apqn;
+ u8 reserved[6];
+};
+
+/**
+ * struct vfio_ap_config:
+ *
+ * Stores the state of a guest's AP configuration.
+ *
+ * VFIO device migration state transition from STOP to STOP_COPY:
+ * -------------------------------------------------------------
+ * When the migration state transitions from STOP to STOP_COPY, the vfio_ap device
+ * driver will open a file stream in read-only mode and return the fd to userspace.
+ * This fd is used during the STOP_COPY phase to read the current state of the
+ * vfio-ap device on the source host. In response, the driver will store the
+ * source guest's AP configuration data in a vfio_ap_config object and copy it to
+ * userspace.
+ *
+ * VFIO device migration state transition from STOP to RESUMING:
+ * ------------------------------------------------------------
+ * When the VFIO migration state transitions from STOP to RESUMING,
+ * the vfio_ap device driver will open a file stream in write-only mode and
+ * return the fd to userspace. This fd is used during the RESUMING phase to
+ * write the source guest's vfio_ap_config data that was read in during the
+ * STOP_COPY phase to the vfio_ap device driver on the destination host. In
+ * response, the device driver will copy the data sent from userspace to a
+ * vfio_ap_config instance which is then used to update the destination guest's
+ * AP configuration.
+ *
+ * Since the source and destination hosts may be running different versions of
+ * the linux kernel, the vfio_ap_config object provides two fields (@magic and
+ * @version) which must be set by the source device driver and verified by the
+ * destination device driver to ensure the migration ABI of the source and
+ * destination hosts are compatible.
+ *
+ * Note: Since a guest's AP configuration could be comprised of a large number of
+ * AP queue devices, a vfio_ap_config object should be allocated using
+ * kvzalloc.
+ *
+ * @magic: identifies this as a valid vfio_ap_config migration blob;
+ * must equal VFIO_AP_MIG_MAGIC
+ * @version: layout version; must equal VFIO_AP_MIG_VERSION
+ * @num_queues: the number of queues passed through to the guest
+ * @reserved: padding to ensure proper alignment of @adm
+ * @adm: bitmap specifying the control domains in the AP configuration
+ * @qinfo: an array of vfio_ap_queue_info objects, each specifying the
+ * queue information for a queue passed through to the guest
+ */
+struct vfio_ap_config {
+ u32 magic;
+ u32 version;
+ u32 num_queues;
+ u8 reserved[4];
+ u64 adm[DIV_ROUND_UP(AP_DOMAINS, 64)];
+ struct vfio_ap_queue_info qinfo[] __counted_by(num_queues);
+};
+
+static void
+vfio_ap_release_stop_copy_file(struct vfio_ap_migration_data *mig_data)
+{
+ kvfree(mig_data->stop_copy_mig_file.ap_config);
+ mig_data->stop_copy_mig_file.ap_config = NULL;
+ mig_data->stop_copy_mig_file.config_sz = 0;
+ mig_data->stop_copy_mig_file.filp = NULL;
+}
+
+static void vfio_ap_release_resuming_file(struct vfio_ap_migration_data *mig_data)
+{
+ kvfree(mig_data->resuming_mig_file.ap_config);
+ mig_data->resuming_mig_file.ap_config = NULL;
+ mig_data->resuming_mig_file.config_sz = 0;
+ mig_data->resuming_mig_file.filp = NULL;
+ mig_data->resuming_mig_data_complete = false;
+}
+
+static void vfio_ap_release_mig_files(struct ap_matrix_mdev *matrix_mdev);
+
+static int vfio_ap_release_mig_file(struct inode *file_inode, struct file *filp)
+{
+ struct ap_matrix_mdev *matrix_mdev = filp->private_data;
+
+ /*
+ * The VFIO device lifetime is tied to migration FD lifetime (see
+ * vfio_ap_open_file_stream() function) to guarantee that the
+ * matrix_mdev remains valid for every read/write operation. Let's drop
+ * it here since the migration FD is being released.
+ */
+ vfio_device_put_registration(&matrix_mdev->vdev);
+ return 0;
+}
+
+static const struct vfio_migration_ops vfio_ap_migration_ops;
+
+/**
+ * vfio_ap_setup_vfio_device_migration:
+ *
+ * Enable
+ * Plug the object containing the function pointers to the migration callbacks
+ * used to facilitate migration of a vfio-ap device.
+ *
+ *
+ * @matrix_mdev: pointer to object containing the mdev state
+ */
+void vfio_ap_setup_vfio_device_migration(struct ap_matrix_mdev *matrix_mdev)
+{
+ /*
+ * Live guest migration is not supported for SE guests, so there is no
+ * need to initialize the migration capabilities.
+ */
+ if (ap_is_se_guest())
+ return;
+
+ matrix_mdev->vdev.migration_flags = VFIO_MIGRATION_STOP_COPY;
+ matrix_mdev->vdev.mig_ops = &vfio_ap_migration_ops;
+}
+
+/**
+ * validate_stop_copy_read_parms: Validate the input parameters to the
+ * vfio_ap_stop_copy_read function
+ *
+ * @filp: Pointer to the file stream used to read the vfio-ap device state
+ * @len: The length of the data to be read
+ *
+ * Verify the following:
+ * - @filp private data is an ap_matrix_mdev instance
+ * - @filp is the instance opened when state transitioned from STOP to STOP_COPY
+ * - @filp->f_pos + @len does not cause integer overflow
+ *
+ * Returns: 0 if the parameters pass validation; otherwise returns an error
+ */
+static int validate_stop_copy_read_parms(struct file *filp, size_t len)
+{
+ struct vfio_ap_migration_data *mig_data;
+ struct ap_matrix_mdev *matrix_mdev;
+ loff_t total_len;
+
+ lockdep_assert_held(&matrix_dev->mdevs_lock);
+
+ if (check_add_overflow((loff_t)len, filp->f_pos, &total_len))
+ return -EIO;
+
+ /*
+ * matrix_mdev is guaranteed live here: vfio_ap_open_file_stream() took
+ * a vfio_device registration reference that is held until
+ * vfio_ap_release_mig_file() runs, so the embedding matrix_mdev cannot
+ * be freed while this file descriptor is open.
+ */
+ matrix_mdev = filp->private_data;
+
+ if (!matrix_mdev->mig_data)
+ return -ENODEV;
+
+ mig_data = matrix_mdev->mig_data;
+
+ if (mig_data->stop_copy_mig_file.filp != filp)
+ return -EINVAL;
+
+ return 0;
+}
+
+static size_t vfio_ap_config_size(struct ap_matrix_mdev *matrix_mdev,
+ unsigned int *num_queues)
+{
+ size_t qinfo_size;
+
+ lockdep_assert_held(&matrix_dev->mdevs_lock);
+
+ *num_queues = vfio_ap_mdev_get_num_queues(&matrix_mdev->shadow_apcb);
+ qinfo_size = *num_queues * sizeof(struct vfio_ap_queue_info);
+
+ return qinfo_size + sizeof(struct vfio_ap_config);
+}
+
+static int get_hardware_info_for_queue(const char *mdev_name,
+ struct ap_tapq_hwinfo *hwinfo,
+ unsigned long apqn)
+{
+ struct ap_queue_status status;
+
+ status = ap_test_queue(apqn, 1, hwinfo);
+
+ switch (status.response_code) {
+ case AP_RESPONSE_NORMAL:
+ case AP_RESPONSE_RESET_IN_PROGRESS:
+ case AP_RESPONSE_DECONFIGURED:
+ case AP_RESPONSE_CHECKSTOPPED:
+ case AP_RESPONSE_BUSY:
+ /* For all these RCs the tapq info should be available */
+ break;
+ default:
+ pr_err_ratelimited("vfio_ap_mdev %s: Failed to get hwinfo for queue %02lx.%04lx: TAPQ rc=%d\n",
+ mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn),
+ status.response_code);
+ return -EIO;
+ }
+
+ /* There should be at least one of the mode bits set */
+ if (!hwinfo->value) {
+ pr_err_ratelimited("vfio_ap_mdev %s: Empty hwinfo for queue %02lx.%04lx: TAPQ rc=%d\n",
+ mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn),
+ status.response_code);
+ return -EIO;
+ }
+
+ return 0;
+}
+
+/**
+ * vfio_ap_store_queue_info:
+ *
+ * Stores the hardware information returned from the PQAP(TAPQ) command for each
+ * queue device identified in the 'qinfo' field of the a vfio_ap_config
+ * object. The APQNs in the 'qinfo' field must already have been snapshotted
+ * prior to calling this function.
+ *
+ * @mdev_name: The name (UUID) of the mediated device to use in log messages
+ * @ap_config: A reference to the vfio_ap_config instance in which to store
+ * the queue information. It is expected that each APQN identifying
+ * a queue device for which hardware information is to be retrieved
+ * shall be snapshotted prior to calling this function.
+ *
+ * Returns: Zero (0) if the hardware information is retrieved for each queue
+ * device in the AP configuration; otherwise, returns an error.
+ */
+static int vfio_ap_store_queue_info(const char *mdev_name,
+ struct vfio_ap_config *ap_config)
+{
+ struct ap_tapq_hwinfo source_hwinfo;
+ unsigned long num_queues;
+ int ret;
+
+ for (num_queues = 0; num_queues < ap_config->num_queues; num_queues++) {
+ ret = get_hardware_info_for_queue(mdev_name, &source_hwinfo,
+ ap_config->qinfo[num_queues].apqn);
+ if (ret)
+ return ret;
+
+ ap_config->qinfo[num_queues].data = source_hwinfo.value;
+ }
+
+ return 0;
+}
+
+static int vfio_ap_get_config(struct ap_matrix_mdev *matrix_mdev)
+{
+ struct vfio_ap_config *ap_configuration;
+ unsigned long *apm, *aqm, apid, apqi;
+ unsigned int num_queues;
+ const char *mdev_name;
+ size_t ap_config_size;
+ int ret, qindex;
+
+ lockdep_assert_held(&matrix_dev->mdevs_lock);
+
+ ap_config_size = vfio_ap_config_size(matrix_mdev, &num_queues);
+
+ ap_configuration = kvzalloc(ap_config_size, GFP_KERNEL_ACCOUNT);
+ if (!ap_configuration)
+ return -ENOMEM;
+
+ ap_configuration->magic = VFIO_AP_MIG_MAGIC;
+ ap_configuration->version = VFIO_AP_MIG_VERSION;
+
+ /*
+ * num_queues must be set before writing qinfo[] elements; the
+ * __counted_by(num_queues) annotation on qinfo[] causes the compiler to
+ * insert bounds checks that evaluate against ap_configuration->num_queues.
+ * Writing through qinfo[i] with num_queues still 0 would trap.
+ */
+ ap_configuration->num_queues = num_queues;
+
+ apm = matrix_mdev->shadow_apcb.apm;
+ aqm = matrix_mdev->shadow_apcb.aqm;
+ qindex = 0;
+ for_each_set_bit_inv(apid, apm, AP_DEVICES) {
+ for_each_set_bit_inv(apqi, aqm, AP_DOMAINS) {
+ ap_configuration->qinfo[qindex].apqn =
+ AP_MKQID(apid, apqi);
+ qindex += 1;
+ }
+ }
+ memcpy(ap_configuration->adm, matrix_mdev->shadow_apcb.adm,
+ sizeof(ap_configuration->adm));
+ mdev_name = dev_name(matrix_mdev->vdev.dev);
+
+ ret = vfio_ap_store_queue_info(mdev_name, ap_configuration);
+ if (ret) {
+ kvfree(ap_configuration);
+ return ret;
+ }
+
+ matrix_mdev->mig_data->stop_copy_mig_file.ap_config = ap_configuration;
+ matrix_mdev->mig_data->stop_copy_mig_file.config_sz = ap_config_size;
+
+ return 0;
+}
+
+static ssize_t vfio_ap_stop_copy_read(struct file *filp, char __user *buf,
+ size_t len, loff_t *pos)
+{
+ struct vfio_ap_migration_file *mig_file;
+ struct ap_matrix_mdev *matrix_mdev;
+ void *bounce;
+ ssize_t ret;
+
+ /*
+ * This file was opened with stream_open(), so pos should be NULL for
+ * sequential read() calls; a non-NULL pointer will be passed only
+ * for positional pread() calls in which case we return an error
+ * indicating broken pipe/illegal seek on a non-seekable file
+ */
+ if (pos)
+ return -ESPIPE;
+
+ mutex_lock(&matrix_dev->mdevs_lock);
+ pos = &filp->f_pos;
+
+ ret = validate_stop_copy_read_parms(filp, len);
+ if (ret) {
+ mutex_unlock(&matrix_dev->mdevs_lock);
+ return ret;
+ }
+
+ matrix_mdev = filp->private_data;
+ mig_file = &matrix_mdev->mig_data->stop_copy_mig_file;
+
+ /*
+ * The data to be returned to the caller - i.e., the source guest's
+ * AP configuration data - is generated on the first read() call. The
+ * result is cached in mig_file->ap_config for subsequent read() calls.
+ */
+ if (!mig_file->ap_config) {
+ ret = vfio_ap_get_config(matrix_mdev);
+ if (ret) {
+ mutex_unlock(&matrix_dev->mdevs_lock);
+ return ret;
+ }
+ }
+
+ /* Return EOF if all of the AP configuration data has been read */
+ if (*pos >= mig_file->config_sz) {
+ mutex_unlock(&matrix_dev->mdevs_lock);
+ return 0;
+ }
+
+ /*
+ * Don't read past the end of the AP configuration data. Limit len to
+ * the number of bytes remaining.
+ */
+ len = min_t(size_t, mig_file->config_sz - *pos, len);
+ if (len == 0) {
+ mutex_unlock(&matrix_dev->mdevs_lock);
+ return 0;
+ }
+
+ /*
+ * Copy into a bounce buffer under mdevs_lock and advance *pos, then
+ * perform copy_to_user() outside the lock. This avoids stalling
+ * all host mdev operations if userspace passes a buffer that faults.
+ */
+ bounce = kmalloc(len, GFP_KERNEL);
+ if (!bounce) {
+ mutex_unlock(&matrix_dev->mdevs_lock);
+ return -ENOMEM;
+ }
+
+ memcpy(bounce, (char *)mig_file->ap_config + *pos, len);
+ *pos += len;
+ mutex_unlock(&matrix_dev->mdevs_lock);
+
+ if (copy_to_user(buf, bounce, len)) {
+ kfree(bounce);
+ return -EFAULT;
+ }
+
+ kfree(bounce);
+ return len;
+}
+
+static const struct file_operations vfio_ap_stop_copy_fops = {
+ .owner = THIS_MODULE,
+ .read = vfio_ap_stop_copy_read,
+ .release = vfio_ap_release_mig_file,
+};
+
+static struct file *vfio_ap_open_file_stream(struct ap_matrix_mdev *matrix_mdev,
+ const struct file_operations *fops,
+ int flags)
+{
+ struct file *filp;
+
+ lockdep_assert_held(&matrix_dev->mdevs_lock);
+
+ /*
+ * Pin the vfio_device registration so that matrix_mdev cannot be freed
+ * while the migration FD is still open. The matching put is in
+ * vfio_ap_release_mig_file().
+ */
+ if (!vfio_device_try_get_registration(&matrix_mdev->vdev))
+ return ERR_PTR(-ENODEV);
+
+ filp = anon_inode_getfile("vfio_ap_mig_file", fops, matrix_mdev, flags);
+ if (IS_ERR(filp)) {
+ vfio_device_put_registration(&matrix_mdev->vdev);
+ return filp;
+ }
+
+ stream_open(filp->f_inode, filp);
+
+ return filp;
+}
+
+static int validate_resuming_write_parms(struct file *filp, size_t len)
+{
+ struct vfio_ap_migration_data *mig_data;
+ struct ap_matrix_mdev *matrix_mdev;
+ loff_t total_len;
+
+ lockdep_assert_held(&matrix_dev->mdevs_lock);
+
+ if (!len || filp->f_pos < 0)
+ return -EINVAL;
+
+ if (check_add_overflow((loff_t)len, filp->f_pos, &total_len))
+ return -ERANGE;
+
+ matrix_mdev = filp->private_data;
+ if (!matrix_mdev || !matrix_mdev->mig_data)
+ return -ENODEV;
+
+ mig_data = matrix_mdev->mig_data;
+
+ if (filp != mig_data->resuming_mig_file.filp)
+ return -ENXIO;
+
+ /* Reject writes that would overflow the pre-allocated buffer */
+ if (filp->f_pos + len > VFIO_AP_CONFIG_MAX_SIZE)
+ return -EIO;
+
+ return 0;
+}
+
+static void report_facilities_compatibility(const char *mdev_name,
+ unsigned long apqn,
+ struct ap_tapq_hwinfo *src_hwinfo,
+ struct ap_tapq_hwinfo *target_hwinfo)
+{
+ if (src_hwinfo->apsc != target_hwinfo->apsc) {
+ if (src_hwinfo->apsc) {
+ pr_err_ratelimited("vfio_ap_mdev %s: APSC facility installed in source queue %02lx.%04lx\n",
+ mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));
+
+ pr_err_ratelimited("vfio_ap_mdev %s: APSC facility not installed in target queue %02lx.%04lx\n",
+ mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));
+ } else {
+ pr_err_ratelimited("vfio_ap_mdev %s: APSC facility not installed in source queue %02lx.%04lx\n",
+ mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));
+
+ pr_err_ratelimited("vfio_ap_mdev %s: APSC facility installed in target queue %02lx.%04lx\n",
+ mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));
+ }
+ }
+
+ if (src_hwinfo->mex4k != target_hwinfo->mex4k) {
+ if (src_hwinfo->mex4k) {
+ pr_err_ratelimited("vfio_ap_mdev %s: mex4k facility installed in source queue %02lx.%04lx\n",
+ mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));
+
+ pr_err_ratelimited("vfio_ap_mdev %s: mex4k facility not installed in target queue %02lx.%04lx\n",
+ mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));
+ } else {
+ pr_err_ratelimited("vfio_ap_mdev %s: mex4k facility not installed in source queue %02lx.%04lx\n",
+ mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));
+
+ pr_err_ratelimited("vfio_ap_mdev %s: mex4k facility installed in target queue %02lx.%04lx\n",
+ mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));
+ }
+ }
+
+ if (src_hwinfo->crt4k != target_hwinfo->crt4k) {
+ if (src_hwinfo->crt4k) {
+ pr_err_ratelimited("vfio_ap_mdev %s: crt4k facility installed in source queue %02lx.%04lx\n",
+ mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));
+
+ pr_err_ratelimited("vfio_ap_mdev %s: crt4k facility not installed in target queue %02lx.%04lx\n",
+ mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));
+ } else {
+ pr_err_ratelimited("vfio_ap_mdev %s: crt4k facility not installed in source queue %02lx.%04lx\n",
+ mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));
+
+ pr_err_ratelimited("vfio_ap_mdev %s: crt4k facility installed in target queue %02lx.%04lx\n",
+ mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));
+ }
+ }
+}
+
+static void report_mode_compatibility(const char *mdev_name,
+ unsigned long apqn,
+ struct ap_tapq_hwinfo *src_hwinfo,
+ struct ap_tapq_hwinfo *target_hwinfo)
+{
+ if (src_hwinfo->cca != target_hwinfo->cca) {
+ if (src_hwinfo->cca) {
+ pr_err_ratelimited("vfio_ap_mdev %s: Coprocessor-mode facility installed in source queue %02lx.%04lx\n",
+ mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));
+
+ pr_err_ratelimited("vfio_ap_mdev %s: Coprocessor-mode facility not installed in target queue %02lx.%04lx\n",
+ mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));
+ } else {
+ pr_err_ratelimited("vfio_ap_mdev %s: Coprocessor-mode facility not installed in source queue %02lx.%04lx\n",
+ mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));
+
+ pr_err_ratelimited("vfio_ap_mdev %s: Coprocessor-mode facility installed in target queue %02lx.%04lx\n",
+ mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));
+ }
+ }
+
+ if (src_hwinfo->accel != target_hwinfo->accel) {
+ if (src_hwinfo->accel) {
+ pr_err_ratelimited("vfio_ap_mdev %s: Accelerator-mode facility installed in source queue %02lx.%04lx\n",
+ mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));
+
+ pr_err_ratelimited("vfio_ap_mdev %s: Accelerator-mode facility not installed in target queue %02lx.%04lx\n",
+ mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));
+ } else {
+ pr_err_ratelimited("vfio_ap_mdev %s: Accelerator-mode facility not installed in source queue %02lx.%04lx\n",
+ mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));
+
+ pr_err_ratelimited("vfio_ap_mdev %s: Accelerator-mode facility installed in target queue %02lx.%04lx\n",
+ mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));
+ }
+ }
+
+ if (src_hwinfo->ep11 != target_hwinfo->ep11) {
+ if (src_hwinfo->ep11) {
+ pr_err_ratelimited("vfio_ap_mdev %s: XCP-mode facility installed in source queue %02lx.%04lx\n",
+ mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));
+
+ pr_err_ratelimited("vfio_ap_mdev %s: XCP-mode facility not installed in target queue %02lx.%04lx\n",
+ mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));
+ } else {
+ pr_err_ratelimited("vfio_ap_mdev %s: XCP-mode facility not installed in source queue %02lx.%04lx\n",
+ mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));
+
+ pr_err_ratelimited("vfio_ap_mdev %s: XCP-mode facility installed in target queue %02lx.%04lx\n",
+ mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));
+ }
+ }
+}
+
+static void report_apxa_compatibility(const char *mdev_name,
+ unsigned long apqn,
+ struct ap_tapq_hwinfo *src_hwinfo,
+ struct ap_tapq_hwinfo *target_hwinfo)
+{
+ if (src_hwinfo->apxa != target_hwinfo->apxa) {
+ if (src_hwinfo->apxa) {
+ pr_err_ratelimited("vfio_ap_mdev %s: AP-extended-addressing (APXA) facility installed in source queue %02lx.%04lx\n",
+ mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));
+
+ pr_err_ratelimited("vfio_ap_mdev %s: AP-extended-addressing (APXA) facility not installed in target queue %02lx.%04lx\n",
+ mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));
+ } else {
+ pr_err_ratelimited("vfio_ap_mdev %s: AP-extended-addressing (APXA) facility not installed in source queue %02lx.%04lx\n",
+ mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));
+
+ pr_err_ratelimited("vfio_ap_mdev %s: AP-extended-addressing (APXA) facility installed in target queue %02lx.%04lx\n",
+ mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));
+ }
+ }
+}
+
+static void report_slcf_compatibility(const char *mdev_name,
+ unsigned long apqn,
+ struct ap_tapq_hwinfo *src_hwinfo,
+ struct ap_tapq_hwinfo *target_hwinfo)
+{
+ if (src_hwinfo->slcf != target_hwinfo->slcf) {
+ if (src_hwinfo->slcf) {
+ pr_err_ratelimited("vfio_ap_mdev %s: Stateless-command-filtering (SLCF) available in source queue %02lx.%04lx\n",
+ mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));
+
+ pr_err_ratelimited("vfio_ap_mdev %s: Stateless-command-filtering (SLCF) not available in target queue %02lx.%04lx\n",
+ mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));
+ } else {
+ pr_err_ratelimited("vfio_ap_mdev %s: Stateless-command-filtering (SLCF) not available in source queue %02lx.%04lx\n",
+ mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));
+
+ pr_err_ratelimited("vfio_ap_mdev %s: Stateless-command-filtering (SLCF) available in target queue %02lx.%04lx\n",
+ mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));
+ }
+ }
+}
+
+static void report_bs_compatibility(const char *mdev_name,
+ unsigned long apqn,
+ struct ap_tapq_hwinfo *src_hwinfo,
+ struct ap_tapq_hwinfo *target_hwinfo)
+{
+ /*
+ * The BS field on both the source and destination must be 0, so if one
+ * of them is not, then report an error.
+ */
+ if (src_hwinfo->bs || target_hwinfo->bs) {
+ pr_err_ratelimited("vfio_ap_mdev %s: Bind/associate state for source (%01x) and target (%01x) queue %02lx.%04lx must be 0\n",
+ mdev_name, src_hwinfo->bs, target_hwinfo->bs,
+ AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));
+ }
+}
+
+static void report_aptype_compatibility(const char *mdev_name,
+ unsigned long apqn,
+ struct ap_tapq_hwinfo *src_hwinfo,
+ struct ap_tapq_hwinfo *target_hwinfo)
+{
+ if (src_hwinfo->at > target_hwinfo->at) {
+ pr_err_ratelimited("vfio_ap_mdev %s: AP type of source queue %02lx.%04lx (%02x) not compatible with target (%02x)\n",
+ mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn),
+ src_hwinfo->at, target_hwinfo->at);
+ }
+}
+
+static bool classes_compatible(struct ap_tapq_hwinfo *src_hwinfo,
+ struct ap_tapq_hwinfo *target_hwinfo)
+{
+ unsigned long src_native, target_native;
+
+ src_native = src_hwinfo->class & CLASSIFICATION_NATIVE_FCN_MASK;
+ target_native = target_hwinfo->class & CLASSIFICATION_NATIVE_FCN_MASK;
+
+ /*
+ * If the source queue has full native card function and the
+ * target queue has only stateless functions available, then
+ * there may be instructions that will not execute on the
+ * target queue. This shall be reported as an error.
+ *
+ * If the source queue has only stateless card functions and the
+ * target queue has full native card function available, then
+ * we are okay because the target queue can run all stateless card
+ * functions.
+ */
+ return (src_native != target_native) ? !src_native : true;
+}
+
+static void report_class_compatibility(const char *mdev_name,
+ unsigned long apqn,
+ struct ap_tapq_hwinfo *src_hwinfo,
+ struct ap_tapq_hwinfo *target_hwinfo)
+{
+ if (!classes_compatible(src_hwinfo, target_hwinfo)) {
+ pr_err_ratelimited("vfio_ap_mdev %s: Full native card function available on source queue %02lx.%04lx\n",
+ mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));
+
+ pr_err_ratelimited("vfio_ap_mdev %s: Only stateless functions available on target queue %02lx.%04lx\n",
+ mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));
+ }
+}
+
+/*
+ * Log a device error reporting that migration failed due to queue
+ * incompatibilities followed by a device error for each incompatible feature.
+ */
+static void report_qinfo_incompatibilities(const char *mdev_name,
+ unsigned long apqn,
+ struct ap_tapq_hwinfo *src_hwinfo,
+ struct ap_tapq_hwinfo *target_hwinfo)
+{
+ pr_err_ratelimited("vfio_ap_mdev %s: Migration failed: Source and target queue (%02lx.%04lx) not compatible\n",
+ mdev_name, AP_QID_CARD(apqn), AP_QID_QUEUE(apqn));
+
+ report_facilities_compatibility(mdev_name, apqn, src_hwinfo, target_hwinfo);
+ report_mode_compatibility(mdev_name, apqn, src_hwinfo, target_hwinfo);
+ report_apxa_compatibility(mdev_name, apqn, src_hwinfo, target_hwinfo);
+ report_slcf_compatibility(mdev_name, apqn, src_hwinfo, target_hwinfo);
+ report_aptype_compatibility(mdev_name, apqn, src_hwinfo, target_hwinfo);
+ report_bs_compatibility(mdev_name, apqn, src_hwinfo, target_hwinfo);
+ report_class_compatibility(mdev_name, apqn, src_hwinfo, target_hwinfo);
+}
+
+/**
+ * queue_hardware_info_is_compatible:
+ *
+ * Verify whether the hardware information for a source queue is compatible with
+ * the hardware info for the corresponding queue on this system.
+ *
+ * In order to be compatible, the hardware information for each queue must
+ * meet the following requirements:
+ *
+ * 1. The hardware facilities bits much match
+ * 2. The AP type of the source queue must be the same as or older than that
+ * of the target queue (target is backwards compatible)
+ * 3. The classification bits must indicate:
+ * - Both queues have full native card function or both have stateless
+ * functions available
+ * - If the classification bits don't match, then the only acceptable
+ * configuration is stateless functions for the source queue and
+ * full native function for the target queue
+ * 4. The BS bits for both queues must be 0 (Queue usable for all messages
+ * supported by the adapter)
+ *
+ * @mdev_name: The mdev name to use in error messages
+ * @apqn: The APQN for the queues
+ * @src_hwinfo: The hardware info for the source queue
+ * @target_hwinfo: The hardware info for the corresponding queue on this system
+ *
+ * Returns: true if the hardware info for the two queues is compatible;
+ * otherwise, returns false.
+ */
+static bool queue_hardware_info_is_compatible(const char *mdev_name,
+ unsigned long apqn,
+ struct ap_tapq_hwinfo *src_hwinfo,
+ struct ap_tapq_hwinfo *target_hwinfo)
+{
+ unsigned long src_bits, target_bits;
+
+ src_bits = src_hwinfo->value & QINFO_DATA_MASK;
+ target_bits = target_hwinfo->value & QINFO_DATA_MASK;
+
+ /* If all bits match the queues are compatible */
+ if (src_bits == target_bits &&
+ (src_hwinfo->bs == 0 && target_hwinfo->bs == 0))
+ return true;
+
+ if (src_hwinfo->apsc == target_hwinfo->apsc &&
+ src_hwinfo->mex4k == target_hwinfo->mex4k &&
+ src_hwinfo->crt4k == target_hwinfo->crt4k &&
+ src_hwinfo->cca == target_hwinfo->cca &&
+ src_hwinfo->accel == target_hwinfo->accel &&
+ src_hwinfo->ep11 == target_hwinfo->ep11 &&
+ src_hwinfo->slcf == target_hwinfo->slcf &&
+ src_hwinfo->apxa == target_hwinfo->apxa &&
+ src_hwinfo->at <= target_hwinfo->at &&
+ classes_compatible(src_hwinfo, target_hwinfo) &&
+ (src_hwinfo->bs == 0 && target_hwinfo->bs == 0))
+ return true;
+
+ report_qinfo_incompatibilities(mdev_name, apqn, src_hwinfo, target_hwinfo);
+
+ return false;
+}
+
+/**
+ * verify_ap_configs_are_compatible:
+ *
+ * Verifies that the queues in the source guest's AP configuration are
+ * compatible with the corresponding queues on this system.
+ *
+ * @mdev_name: The mdev name to use in error messages
+ * @source_config: The object specifying the source guest's AP configuration
+ *
+ * Returns: an error indicating either a failure to retrieve a queue's
+ * hardware information or one or more source queues are not
+ * compatible with the corresponding queue on this system; otherwise,
+ * returns zero to indicate compatibility.
+ */
+static int verify_ap_configs_are_compatible(const char *mdev_name,
+ struct vfio_ap_config *source_config)
+{
+ struct ap_tapq_hwinfo src_hwinfo, dest_hwinfo;
+ unsigned long apqn;
+ int ret = 0, rc;
+
+ for (int i = 0; i < source_config->num_queues; i++) {
+ apqn = source_config->qinfo[i].apqn;
+
+ /*
+ * If we can't get the hardware info for a particular queue, then let's
+ * capture the function return code and continue so we can log all
+ * errors to aid in debugging of migration.
+ */
+ rc = get_hardware_info_for_queue(mdev_name, &dest_hwinfo, apqn);
+ if (rc) {
+ ret = rc;
+ continue;
+ }
+
+ src_hwinfo.value = source_config->qinfo[i].data;
+
+ if (!queue_hardware_info_is_compatible(mdev_name, apqn,
+ &src_hwinfo,
+ &dest_hwinfo))
+ ret = -EINVAL;
+ }
+
+ return ret;
+}
+
+/**
+ * ap_config_is_subset_of_shadow_apcb:
+ *
+ * Verify that each APQN and control domain in the source guest's AP
+ * configuration is present in the destination mdev's shadow_apcb. The
+ * destination mdev must be pre-configured by the administrator with at least
+ * the adapters, domains and control domains the source guest is actively
+ * using. Since shadow_apcb is derived from the administrator's assignment
+ * filtered to only installed and vfio_ap-bound queues, any APQN or control
+ * domain present in shadow_apcb is guaranteed to be available.
+ *
+ * All missing APQNs and control domains are logged before returning so the
+ * administrator sees all problems at once rather than one per retry.
+ *
+ * @mdev_name: The mdev name to use in error messages
+ * @matrix_mdev: The destination mdev whose shadow_apcb to check against
+ * @source_config: The source guest's AP configuration
+ *
+ * Returns: true if every APQN and control domain in @source_config is present
+ * in @matrix_mdev->shadow_apcb; otherwise returns false.
+ */
+static bool ap_config_is_subset_of_shadow_apcb(const char *mdev_name,
+ struct ap_matrix_mdev *matrix_mdev,
+ struct vfio_ap_config *source_config)
+{
+ unsigned long apid, apqi, apqn, domain_num;
+ bool ret = true;
+
+ for (int i = 0; i < source_config->num_queues; i++) {
+ apqn = source_config->qinfo[i].apqn;
+ apid = AP_QID_CARD(apqn);
+ apqi = AP_QID_QUEUE(apqn);
+
+ if (!test_bit_inv(apid, matrix_mdev->shadow_apcb.apm) ||
+ !test_bit_inv(apqi, matrix_mdev->shadow_apcb.aqm)) {
+ pr_err_ratelimited("vfio_ap_mdev %s: Queue %02lx.%04lx not in destination mdev's AP configuration\n",
+ mdev_name, apid, apqi);
+ ret = false;
+ }
+ }
+
+ for_each_set_bit_inv(domain_num, (unsigned long *)source_config->adm,
+ AP_DOMAINS) {
+ if (!test_bit_inv(domain_num, matrix_mdev->shadow_apcb.adm)) {
+ pr_err_ratelimited("vfio_ap_mdev %s: Control domain %04lx not in destination mdev's AP configuration\n",
+ mdev_name, domain_num);
+ ret = false;
+ }
+ }
+
+ return ret;
+}
+
+static int do_post_copy_validation(struct ap_matrix_mdev *matrix_mdev,
+ struct vfio_ap_config *source_config)
+{
+ const char *mdev_name = dev_name(matrix_mdev->vdev.dev);
+
+ lockdep_assert_held(&ap_attr_mutex);
+ assert_has_update_locks_for_mdev(matrix_mdev);
+
+ if (source_config->magic != VFIO_AP_MIG_MAGIC ||
+ source_config->version != VFIO_AP_MIG_VERSION)
+ return -EINVAL;
+
+ if (!ap_config_is_subset_of_shadow_apcb(mdev_name, matrix_mdev,
+ source_config))
+ return -EINVAL;
+
+ return verify_ap_configs_are_compatible(mdev_name, source_config);
+}
+
+static ssize_t vfio_ap_resuming_write(struct file *filp, const char __user *buf,
+ size_t len, loff_t *pos)
+{
+ struct ap_matrix_mdev *matrix_mdev;
+ struct vfio_ap_config *ap_config;
+ ssize_t ret;
+ void *kbuf;
+
+ /*
+ * This file was opened with stream_open(), so pos should be NULL for
+ * sequential write() calls; a non-NULL pointer will be passed only
+ * for positional pwrite() calls in which case we return an error
+ * indicating broken pipe/illegal seek on a non-seekable file.
+ */
+ if (pos)
+ return -ESPIPE;
+
+ /*
+ * Reject absurd lengths before allocating the bounce buffer below.
+ * This only caps the allocation: a write can never be larger than
+ * the receive buffer. The authoritative check against the space
+ * remaining is made by validate_resuming_write_parms() under the
+ * locks.
+ */
+ if (len > VFIO_AP_CONFIG_MAX_SIZE)
+ return -EIO;
+
+ /*
+ * Copy the user data into a kernel buffer before taking any locks.
+ * copy_from_user() can fault and block for an unbounded time, which
+ * must not happen while holding ap_attr_mutex, guests_lock, kvm->lock
+ * or mdevs_lock.
+ */
+ kbuf = vmemdup_user(buf, len);
+ if (IS_ERR(kbuf))
+ return PTR_ERR(kbuf);
+
+ /*
+ * Hold ap_attr_mutex for the full duration of the write, just as
+ * (un)assign_adapter_store() and (un)assign_domain_store() do. This
+ * prevents the AP bus apmask/aqmask attributes from being changed
+ * while the guest's AP configuration is being updated.
+ *
+ * get_update_locks_for_mdev() then acquires guests_lock, kvm->lock,
+ * and mdevs_lock in the correct order. This serialises
+ * the entire operation against concurrent AP attribute writers
+ * while the guest's AP configuration is being changed.
+ *
+ * Holding these locks for the full duration of a potentially chunked
+ * write could in theory affect performance, but this is acceptable for
+ * several reasons: migration is an infrequent operation; real-world
+ * guest AP configurations are small (each CEX8 card has 2 adapters and
+ * up to 16 domains, and the 85 cards in a system are shared across all
+ * LPARs and guests); and only a memcpy() and some integer checks are
+ * done for each chunk while the locks are held.
+ */
+ matrix_mdev = filp->private_data;
+ mutex_lock(&ap_attr_mutex);
+ get_update_locks_for_mdev(matrix_mdev);
+ pos = &filp->f_pos;
+
+ ret = validate_resuming_write_parms(filp, len);
+ if (ret)
+ goto out_unlock;
+
+ ap_config = matrix_mdev->mig_data->resuming_mig_file.ap_config;
+
+ memcpy((char *)ap_config + *pos, kbuf, len);
+ *pos += len;
+
+ /*
+ * Check whether we have received all the data. We know the total
+ * expected size once num_queues has arrived, i.e. once *pos is past
+ * the fixed header. Until then keep accumulating.
+ */
+ if (*pos >= offsetofend(struct vfio_ap_config, num_queues)) {
+ size_t expected_sz;
+
+ if (ap_config->num_queues > MAX_AP_QUEUES) {
+ ret = -EINVAL;
+ goto out_unlock;
+ }
+
+ expected_sz = sizeof(struct vfio_ap_config) +
+ ap_config->num_queues *
+ sizeof(struct vfio_ap_queue_info);
+
+ if (*pos > (loff_t)expected_sz) {
+ ret = -EINVAL;
+ goto out_unlock;
+ }
+
+ if (*pos == (loff_t)expected_sz) {
+ ret = do_post_copy_validation(matrix_mdev, ap_config);
+ matrix_mdev->mig_data->resuming_mig_data_complete = !ret;
+ }
+ }
+
+out_unlock:
+ release_update_locks_for_mdev(matrix_mdev);
+ mutex_unlock(&ap_attr_mutex);
+ kvfree(kbuf);
+ return ret ? ret : (ssize_t)len;
+}
+
+static const struct file_operations vfio_ap_resume_fops = {
+ .owner = THIS_MODULE,
+ .write = vfio_ap_resuming_write,
+ .release = vfio_ap_release_mig_file,
+};
+
+static struct file *vfio_ap_resuming_init(struct ap_matrix_mdev *matrix_mdev)
+{
+ struct vfio_ap_config *ap_config;
+ struct file *filp;
+
+ lockdep_assert_held(&matrix_dev->mdevs_lock);
+
+ /*
+ * Pre-allocate the maximum possible receive buffer so that
+ * vfio_ap_resuming_write() can copy directly into it without needing
+ * to know num_queues up front. kvzalloc falls back to vmalloc for
+ * large allocations rather than failing a high-order kmalloc.
+ */
+ ap_config = kvzalloc(VFIO_AP_CONFIG_MAX_SIZE, GFP_KERNEL_ACCOUNT);
+ if (!ap_config)
+ return ERR_PTR(-ENOMEM);
+
+ filp = vfio_ap_open_file_stream(matrix_mdev, &vfio_ap_resume_fops, O_WRONLY);
+ if (IS_ERR(filp)) {
+ kvfree(ap_config);
+ return filp;
+ }
+
+ matrix_mdev->mig_data->resuming_mig_file.ap_config = ap_config;
+ matrix_mdev->mig_data->resuming_mig_file.config_sz = VFIO_AP_CONFIG_MAX_SIZE;
+
+ return filp;
+}
+
+static struct file *
+vfio_ap_transition_to_state(struct ap_matrix_mdev *matrix_mdev,
+ enum vfio_device_mig_state new_state)
+{
+ struct vfio_ap_migration_data *mig_data;
+ enum vfio_device_mig_state cur_state;
+
+ lockdep_assert_held(&matrix_dev->mdevs_lock);
+ mig_data = matrix_mdev->mig_data;
+ cur_state = mig_data->mig_state;
+ dev_dbg(matrix_mdev->vdev.dev, "%s: %d -> %d\n", __func__, cur_state,
+ new_state);
+
+ /*
+ * Begins the process of saving the vfio device state by creating and
+ * returning a streaming data_fd to be used to read out the internal
+ * state of the vfio-ap device on the source host.
+ */
+ if (cur_state == VFIO_DEVICE_STATE_STOP &&
+ new_state == VFIO_DEVICE_STATE_STOP_COPY) {
+ struct file *filp = vfio_ap_open_file_stream(matrix_mdev,
+ &vfio_ap_stop_copy_fops,
+ O_RDONLY);
+ if (IS_ERR(filp))
+ return ERR_CAST(filp);
+
+ mig_data->stop_copy_mig_file.filp = filp;
+
+ return filp;
+ }
+
+ /*
+ * Begins the process of restoring the vfio device state by creating and
+ * returning a streaming data_fd to be used to read in the internal
+ * state of the vfio-ap device on the destination host.
+ */
+ if (cur_state == VFIO_DEVICE_STATE_STOP &&
+ new_state == VFIO_DEVICE_STATE_RESUMING) {
+ struct file *filp = vfio_ap_resuming_init(matrix_mdev);
+
+ if (IS_ERR(filp))
+ return ERR_CAST(filp);
+
+ mig_data->resuming_mig_file.filp = filp;
+ return filp;
+ }
+
+ /*
+ * Terminates the data transfer session of the vfio-ap device state
+ * to the destination guest.
+ */
+ if (cur_state == VFIO_DEVICE_STATE_RESUMING &&
+ new_state == VFIO_DEVICE_STATE_STOP) {
+ if (!mig_data->resuming_mig_data_complete)
+ return ERR_PTR(-EINVAL);
+
+ /* Set resuming_mig_data_complete to false for clean reuse */
+ matrix_mdev->mig_data->resuming_mig_data_complete = false;
+ vfio_ap_release_resuming_file(matrix_mdev->mig_data);
+ return NULL;
+ }
+
+ /*
+ * Terminates the transfer session of the vfio-ap device state from
+ * the source guest.
+ */
+ if (cur_state == VFIO_DEVICE_STATE_STOP_COPY &&
+ new_state == VFIO_DEVICE_STATE_STOP) {
+ vfio_ap_release_stop_copy_file(matrix_mdev->mig_data);
+ return NULL;
+ }
+
+ /*
+ * These states indicate migration has either not been initiated or
+ * has completed and the vfio-ap device is operating normally. Since the
+ * vfio-ap device does not virtualize a DMA device, there is no internal
+ * device state to incorporate into the vfio-ap device on the target.
+ */
+ if (cur_state == VFIO_DEVICE_STATE_STOP &&
+ new_state == VFIO_DEVICE_STATE_RUNNING) {
+ vfio_ap_release_mig_files(matrix_mdev);
+ return NULL;
+ }
+
+ if (cur_state == VFIO_DEVICE_STATE_RUNNING &&
+ new_state == VFIO_DEVICE_STATE_STOP) {
+ return NULL;
+ }
+
+ /* vfio_mig_get_next_state() does not use arcs other than the above */
+ WARN_ON(true);
+
+ return ERR_PTR(-EINVAL);
+}
+
+static struct file *vfio_ap_set_state(struct vfio_device *vdev,
+ enum vfio_device_mig_state new_state)
+{
+ int ret;
+ struct file *filp = NULL;
+ struct ap_matrix_mdev *matrix_mdev;
+ enum vfio_device_mig_state next_state;
+ struct vfio_ap_migration_data *mig_data;
+
+ mutex_lock(&matrix_dev->mdevs_lock);
+
+ matrix_mdev = container_of(vdev, struct ap_matrix_mdev, vdev);
+ mig_data = matrix_mdev->mig_data;
+
+ /*
+ * The mig_data pointer is set in the vfio_ap_init_migration_data
+ * function which is called when the vfio-ap device fd is opened.
+ * Since the implicit pre-open state is RUNNING, a request to set
+ * RUNNING is a no-op. Any other state transition is invalid before
+ * open_device.
+ */
+ if (!mig_data) {
+ mutex_unlock(&matrix_dev->mdevs_lock);
+ if (new_state == VFIO_DEVICE_STATE_RUNNING)
+ return NULL;
+ return ERR_PTR(-ENODEV);
+ }
+
+ dev_dbg(vdev->dev, "%s -> %d\n", __func__, new_state);
+
+ while (mig_data->mig_state != new_state) {
+ ret = vfio_mig_get_next_state(vdev, mig_data->mig_state,
+ new_state, &next_state);
+ if (ret) {
+ filp = ERR_PTR(ret);
+ break;
+ }
+
+ filp = vfio_ap_transition_to_state(matrix_mdev, next_state);
+ if (IS_ERR(filp))
+ break;
+
+ mig_data->mig_state = next_state;
+
+ if (WARN_ON(filp && new_state != next_state)) {
+ fput(filp);
+ filp = ERR_PTR(-EINVAL);
+ break;
+ }
+ }
+
+ if (mig_data->mig_state == VFIO_DEVICE_STATE_ERROR)
+ filp = ERR_PTR(-EIO);
+
+ mutex_unlock(&matrix_dev->mdevs_lock);
+
+ return filp;
+}
+
+static int vfio_ap_get_state(struct vfio_device *vdev,
+ enum vfio_device_mig_state *current_state)
+{
+ struct ap_matrix_mdev *matrix_mdev;
+ struct vfio_ap_migration_data *mig_data;
+
+ mutex_lock(&matrix_dev->mdevs_lock);
+
+ matrix_mdev = container_of(vdev, struct ap_matrix_mdev, vdev);
+ mig_data = matrix_mdev->mig_data;
+
+ /*
+ * The mig_data pointer is set in the vfio_ap_init_migration_data
+ * function which is called when the vfio-ap device fd is opened.
+ * If mig_data is NULL, report RUNNING as the implicit pre-open state
+ * so userspace doesn't need to perform any state transition before the
+ * device becomes active.
+ */
+ *current_state = (mig_data) ? mig_data->mig_state :
+ VFIO_DEVICE_STATE_RUNNING;
+
+ mutex_unlock(&matrix_dev->mdevs_lock);
+
+ return 0;
+}
+
+static int vfio_ap_get_data_size(struct vfio_device *vdev,
+ unsigned long *stop_copy_length)
+{
+ struct ap_matrix_mdev *matrix_mdev;
+ int num_queues;
+
+ mutex_lock(&matrix_dev->mdevs_lock);
+ matrix_mdev = container_of(vdev, struct ap_matrix_mdev, vdev);
+ *stop_copy_length = vfio_ap_config_size(matrix_mdev, &num_queues);
+ mutex_unlock(&matrix_dev->mdevs_lock);
+
+ return 0;
+}
+
+static const struct vfio_migration_ops vfio_ap_migration_ops = {
+ .migration_set_state = vfio_ap_set_state,
+ .migration_get_state = vfio_ap_get_state,
+ .migration_get_data_size = vfio_ap_get_data_size,
+};
+
+/**
+ * vfio_ap_init_migration_data - initialize migration data and functions
+ *
+ * @matrix_mdev: pointer to object containing the mdev state
+ *
+ * Return: zero if initialization is successful; otherwise, returns a error.
+ */
+int vfio_ap_init_migration_data(struct ap_matrix_mdev *matrix_mdev)
+{
+ struct vfio_ap_migration_data *mig_data;
+
+ lockdep_assert_held(&matrix_dev->mdevs_lock);
+
+ /*
+ * Live guest migration is not supported for SE guests, so there is no
+ * need to initialize the migration data.
+ */
+ if (ap_is_se_guest())
+ return 0;
+
+ mig_data = kzalloc_obj(struct vfio_ap_migration_data, GFP_KERNEL);
+ if (!mig_data)
+ return -ENOMEM;
+
+ mig_data->mig_state = VFIO_DEVICE_STATE_RUNNING;
+ mig_data->resuming_mig_data_complete = false;
+ matrix_mdev->mig_data = mig_data;
+
+ return 0;
+}
+
+/**
+ * vfio_ap_release_mig_files:
+ *
+ * Free the ap_config buffers for any open migration FDs. Although a
+ * migration FD may still be held open by userspace, it is safe to free
+ * mig_data here because:
+ *
+ * 1. matrix_mdev remains valid for the lifetime of any open migration
+ * FD via the vfio_device registration reference taken in
+ * vfio_ap_open_file_stream() and dropped in
+ * vfio_ap_release_mig_file().
+ *
+ * 2. mig_data is only accessed by the migration file ops
+ * (vfio_ap_stop_copy_read, vfio_ap_resuming_write) under
+ * mdevs_lock. Once mig_data is set to NULL by the caller, those
+ * paths will see NULL and return -ENODEV before dereferencing it.
+ *
+ * @matrix_mdev: The object used to maintain the state for a mediated device
+ */
+static void vfio_ap_release_mig_files(struct ap_matrix_mdev *matrix_mdev)
+{
+ struct vfio_ap_migration_data *mig_data;
+
+ lockdep_assert_held(&matrix_dev->mdevs_lock);
+
+ mig_data = matrix_mdev->mig_data;
+ vfio_ap_release_stop_copy_file(mig_data);
+ vfio_ap_release_resuming_file(mig_data);
+}
+
+/**
+ * vfio_ap_release_migration_data: reclaim private migration data
+ *
+ * @mdev: pointer to the object containing the state of the mdev
+ */
+void vfio_ap_release_migration_data(struct ap_matrix_mdev *matrix_mdev)
+{
+ lockdep_assert_held(&matrix_dev->mdevs_lock);
+
+ if (!matrix_mdev->mig_data)
+ return;
+
+ vfio_ap_release_mig_files(matrix_mdev);
+ kfree(matrix_mdev->mig_data);
+ matrix_mdev->mig_data = NULL;
+}
+
+/**
+ * vfio_ap_reset_migration_state - Reset the vfio-ap migration state
+ *
+ * @matrix_mdev: pointer to the object maintaining the vfio-ap device state
+ *
+ * Called during VFIO_DEVICE_RESET to clean up any active migration
+ * state and reset the device to RUNNING state as required by the VFIO
+ * migration specification.
+ */
+void vfio_ap_reset_migration_state(struct ap_matrix_mdev *matrix_mdev)
+{
+ lockdep_assert_held(&matrix_dev->mdevs_lock);
+
+ if (!matrix_mdev->mig_data)
+ return;
+
+ vfio_ap_release_mig_files(matrix_mdev);
+ matrix_mdev->mig_data->mig_state = VFIO_DEVICE_STATE_RUNNING;
+}
diff --git a/drivers/s390/crypto/vfio_ap_ops.c b/drivers/s390/crypto/vfio_ap_ops.c
index 4db878c18f41c..e049c4141a53b 100644
--- a/drivers/s390/crypto/vfio_ap_ops.c
+++ b/drivers/s390/crypto/vfio_ap_ops.c
@@ -88,53 +88,6 @@ static inline void release_update_locks_for_kvm(struct kvm *kvm)
mutex_unlock(&matrix_dev->guests_lock);
}
-/**
- * get_update_locks_for_mdev: Acquire the locks required to dynamically update a
- * KVM guest's APCB in the proper order.
- *
- * @matrix_mdev: a pointer to a struct ap_matrix_mdev object containing the AP
- * configuration data to use to update a KVM guest's APCB.
- *
- * The proper locking order is:
- * 1. matrix_dev->guests_lock: required to use the KVM pointer to update a KVM
- * guest's APCB.
- * 2. matrix_mdev->kvm->lock: required to update a guest's APCB
- * 3. matrix_dev->mdevs_lock: required to access data stored in a matrix_mdev
- *
- * Note: If @matrix_mdev is NULL or is not attached to a KVM guest, the KVM
- * lock will not be taken.
- */
-static inline void get_update_locks_for_mdev(struct ap_matrix_mdev *matrix_mdev)
-{
- mutex_lock(&matrix_dev->guests_lock);
- if (matrix_mdev && matrix_mdev->kvm)
- mutex_lock(&matrix_mdev->kvm->lock);
- mutex_lock(&matrix_dev->mdevs_lock);
-}
-
-/**
- * release_update_locks_for_mdev: Release the locks used to dynamically update a
- * KVM guest's APCB in the proper order.
- *
- * @matrix_mdev: a pointer to a struct ap_matrix_mdev object containing the AP
- * configuration data to use to update a KVM guest's APCB.
- *
- * The proper unlocking order is:
- * 1. matrix_dev->mdevs_lock
- * 2. matrix_mdev->kvm->lock
- * 3. matrix_dev->guests_lock
- *
- * Note: If @matrix_mdev is NULL or is not attached to a KVM guest, the KVM
- * lock will not be released.
- */
-static inline void release_update_locks_for_mdev(struct ap_matrix_mdev *matrix_mdev)
-{
- mutex_unlock(&matrix_dev->mdevs_lock);
- if (matrix_mdev && matrix_mdev->kvm)
- mutex_unlock(&matrix_mdev->kvm->lock);
- mutex_unlock(&matrix_dev->guests_lock);
-}
-
/**
* get_update_locks_by_apqn: Find the mdev to which an APQN is assigned and
* acquire the locks required to update the APCB of
@@ -649,8 +602,7 @@ static int handle_pqap(struct kvm_vcpu *vcpu)
return 0;
}
-static void vfio_ap_matrix_init(struct ap_config_info *info,
- struct ap_matrix *matrix)
+void vfio_ap_matrix_init(struct ap_config_info *info, struct ap_matrix *matrix)
{
matrix->apm_max = info->apxa ? info->na : 63;
matrix->aqm_max = info->apxa ? info->nd : 15;
@@ -794,6 +746,16 @@ static int vfio_ap_mdev_init_dev(struct vfio_device *vdev)
return 0;
}
+static void vfio_ap_mdev_release_dev(struct vfio_device *vdev)
+{
+ struct ap_matrix_mdev *matrix_mdev;
+
+ mutex_lock(&matrix_dev->mdevs_lock);
+ matrix_mdev = container_of(vdev, struct ap_matrix_mdev, vdev);
+ vfio_ap_release_migration_data(matrix_mdev);
+ mutex_unlock(&matrix_dev->mdevs_lock);
+}
+
static int vfio_ap_mdev_probe(struct mdev_device *mdev)
{
struct ap_matrix_mdev *matrix_mdev;
@@ -801,9 +763,19 @@ static int vfio_ap_mdev_probe(struct mdev_device *mdev)
matrix_mdev = vfio_alloc_device(ap_matrix_mdev, vdev, &mdev->dev,
&vfio_ap_matrix_dev_ops);
+
if (IS_ERR(matrix_mdev))
return PTR_ERR(matrix_mdev);
+ /*
+ * Setting up for vfio device migration must be done before calling
+ * vfio_register_emulated_iommu_dev; otherwise, the VFIO core
+ * will see mig_ops as NULL during the registration. This could
+ * prevent the VFIO core from properly setting up migration
+ * infrastructure like debugfs entries.
+ */
+ vfio_ap_setup_vfio_device_migration(matrix_mdev);
+
ret = vfio_register_emulated_iommu_dev(&matrix_mdev->vdev);
if (ret)
goto err_put_vdev;
@@ -2059,19 +2031,39 @@ static int vfio_ap_mdev_reset_qlist(struct list_head *qlist)
static int vfio_ap_mdev_open_device(struct vfio_device *vdev)
{
- struct ap_matrix_mdev *matrix_mdev =
- container_of(vdev, struct ap_matrix_mdev, vdev);
+ struct ap_matrix_mdev *matrix_mdev;
+ int ret;
if (!vdev->kvm)
return -EINVAL;
- return vfio_ap_mdev_set_kvm(matrix_mdev, vdev->kvm);
+ mutex_lock(&matrix_dev->mdevs_lock);
+ matrix_mdev = container_of(vdev, struct ap_matrix_mdev, vdev);
+ ret = vfio_ap_init_migration_data(matrix_mdev);
+ mutex_unlock(&matrix_dev->mdevs_lock);
+
+ if (ret)
+ return ret;
+
+ ret = vfio_ap_mdev_set_kvm(matrix_mdev, vdev->kvm);
+ if (ret) {
+ /* Clean up migration data on failure */
+ mutex_lock(&matrix_dev->mdevs_lock);
+ vfio_ap_release_migration_data(matrix_mdev);
+ mutex_unlock(&matrix_dev->mdevs_lock);
+ }
+
+ return ret;
}
static void vfio_ap_mdev_close_device(struct vfio_device *vdev)
{
- struct ap_matrix_mdev *matrix_mdev =
- container_of(vdev, struct ap_matrix_mdev, vdev);
+ struct ap_matrix_mdev *matrix_mdev;
+
+ mutex_lock(&matrix_dev->mdevs_lock);
+ matrix_mdev = container_of(vdev, struct ap_matrix_mdev, vdev);
+ vfio_ap_release_migration_data(matrix_mdev);
+ mutex_unlock(&matrix_dev->mdevs_lock);
vfio_ap_mdev_unset_kvm(matrix_mdev);
}
@@ -2105,6 +2097,14 @@ static void vfio_ap_mdev_request(struct vfio_device *vdev, unsigned int count)
release_update_locks_for_mdev(matrix_mdev);
}
+unsigned int vfio_ap_mdev_get_num_queues(struct ap_matrix *ap_matrix)
+{
+ lockdep_assert_held(&matrix_dev->mdevs_lock);
+
+ return bitmap_weight(ap_matrix->apm, AP_DEVICES) *
+ bitmap_weight(ap_matrix->aqm, AP_DOMAINS);
+}
+
static int vfio_ap_mdev_get_device_info(unsigned long arg)
{
unsigned long minsz;
@@ -2282,6 +2282,17 @@ static ssize_t vfio_ap_mdev_ioctl(struct vfio_device *vdev,
break;
case VFIO_DEVICE_RESET:
ret = vfio_ap_mdev_reset_queues(matrix_mdev);
+ /*
+ * Reset the migration state unconditionally, regardless of
+ * whether the hardware queue reset succeeded. The migration
+ * state tracks the AP configuration transfer lifecycle and is
+ * independent of the hardware queue reset outcome. The VFIO
+ * migration spec designates VFIO_DEVICE_RESET as the mechanism
+ * to return device_state to RUNNING (e.g. to recover from
+ * ERROR), so the migration state must be cleaned up even when
+ * one or more queues fail to reset.
+ */
+ vfio_ap_reset_migration_state(matrix_mdev);
break;
case VFIO_DEVICE_GET_IRQ_INFO:
ret = vfio_ap_get_irq_info(arg);
@@ -2389,6 +2400,7 @@ static const struct attribute_group vfio_queue_attr_group = {
static const struct vfio_device_ops vfio_ap_matrix_dev_ops = {
.init = vfio_ap_mdev_init_dev,
+ .release = vfio_ap_mdev_release_dev,
.open_device = vfio_ap_mdev_open_device,
.close_device = vfio_ap_mdev_close_device,
.ioctl = vfio_ap_mdev_ioctl,
diff --git a/drivers/s390/crypto/vfio_ap_private.h b/drivers/s390/crypto/vfio_ap_private.h
index 9bff666b0b35d..d44188f122213 100644
--- a/drivers/s390/crypto/vfio_ap_private.h
+++ b/drivers/s390/crypto/vfio_ap_private.h
@@ -91,6 +91,9 @@ struct ap_queue_table {
DECLARE_HASHTABLE(queues, 8);
};
+/* Forward declaration for migration data structure */
+struct vfio_ap_migration_data;
+
/**
* struct ap_matrix_mdev - Contains the data associated with a matrix mediated
* device.
@@ -110,6 +113,7 @@ struct ap_queue_table {
* @aqm_add: bitmap of APQIs added to the host's AP configuration
* @adm_add: bitmap of control domain numbers added to the host's AP
* configuration
+ * @mig_data: vfio device migration data
*/
struct ap_matrix_mdev {
struct vfio_device vdev;
@@ -125,6 +129,7 @@ struct ap_matrix_mdev {
DECLARE_BITMAP(apm_add, AP_DEVICES);
DECLARE_BITMAP(aqm_add, AP_DOMAINS);
DECLARE_BITMAP(adm_add, AP_DOMAINS);
+ struct vfio_ap_migration_data *mig_data;
};
/**
@@ -152,6 +157,8 @@ struct vfio_ap_queue {
struct work_struct reset_work;
};
+unsigned int vfio_ap_mdev_get_num_queues(struct ap_matrix *ap_matrix);
+
int vfio_ap_mdev_register(void);
void vfio_ap_mdev_unregister(void);
@@ -165,4 +172,67 @@ void vfio_ap_on_cfg_changed(struct ap_config_info *new_config_info,
void vfio_ap_on_scan_complete(struct ap_config_info *new_config_info,
struct ap_config_info *old_config_info);
+int vfio_ap_init_migration_data(struct ap_matrix_mdev *matrix_mdev);
+void vfio_ap_setup_vfio_device_migration(struct ap_matrix_mdev *matrix_mdev);
+void vfio_ap_release_migration_data(struct ap_matrix_mdev *matrix_mdev);
+void vfio_ap_reset_migration_state(struct ap_matrix_mdev *matrix_mdev);
+
+/**
+ * get_update_locks_for_mdev: Acquire the locks required to dynamically update a
+ * KVM guest's APCB in the proper order.
+ *
+ * @matrix_mdev: a pointer to a struct ap_matrix_mdev object containing the AP
+ * configuration data to use to update a KVM guest's APCB.
+ *
+ * The proper locking order is:
+ * 1. matrix_dev->guests_lock: required to use the KVM pointer to update a KVM
+ * guest's APCB.
+ * 2. matrix_mdev->kvm->lock: required to update a guest's APCB
+ * 3. matrix_dev->mdevs_lock: required to access data stored in a matrix_mdev
+ *
+ * Note: If @matrix_mdev is NULL or is not attached to a KVM guest, the KVM
+ * lock will not be taken.
+ */
+static inline void get_update_locks_for_mdev(struct ap_matrix_mdev *matrix_mdev)
+{
+ mutex_lock(&matrix_dev->guests_lock);
+ if (matrix_mdev && matrix_mdev->kvm)
+ mutex_lock(&matrix_mdev->kvm->lock);
+ mutex_lock(&matrix_dev->mdevs_lock);
+}
+
+/**
+ * release_update_locks_for_mdev: Release the locks used to dynamically update a
+ * KVM guest's APCB in the proper order.
+ *
+ * @matrix_mdev: a pointer to a struct ap_matrix_mdev object containing the AP
+ * configuration data to use to update a KVM guest's APCB.
+ *
+ * The proper unlocking order is:
+ * 1. matrix_dev->mdevs_lock
+ * 2. matrix_mdev->kvm->lock
+ * 3. matrix_dev->guests_lock
+ *
+ * Note: If @matrix_mdev is NULL or is not attached to a KVM guest, the KVM
+ * lock will not be released.
+ */
+static inline void release_update_locks_for_mdev(struct ap_matrix_mdev *matrix_mdev)
+{
+ mutex_unlock(&matrix_dev->mdevs_lock);
+ if (matrix_mdev && matrix_mdev->kvm)
+ mutex_unlock(&matrix_mdev->kvm->lock);
+ mutex_unlock(&matrix_dev->guests_lock);
+}
+
+static inline void
+assert_has_update_locks_for_mdev(struct ap_matrix_mdev *matrix_mdev)
+{
+ lockdep_assert_held(&matrix_dev->guests_lock);
+ if (matrix_mdev && matrix_mdev->kvm)
+ lockdep_assert_held(&matrix_mdev->kvm->lock);
+ lockdep_assert_held(&matrix_dev->mdevs_lock);
+}
+
+void vfio_ap_matrix_init(struct ap_config_info *info, struct ap_matrix *matrix);
+
#endif /* _VFIO_AP_PRIVATE_H_ */
|
| 3/2 | 2026/10/24 07:10 | llm | patch-evaluator |
0mModel:gemini-3.8-flash Args: null Results: null Tokens: input: 34508 output: 19 thoughts: 358 Thoughts: **Evaluating the Patch's Suitability for Syzkaller Fuzzing** Okay, so I've got this patch to review. The goal is to figure out if it's worth fuzzing with syzkaller. First, let's see what the patch actually *does*. The target architecture is amd64, that's what's assumed. But, what architecture does *this* patch touch? Alright, let's look at the modified files... hmm, I see files in `Documentation/arch/s390/` and `drivers/s390/crypto/`. Hold on a minute... the path `drivers/s390` is throwing a red flag. Is that architecture-specific to s390? The target is amd64, so if this code is specific to s390, then it's a no-go for syzkaller. Let me refresh the rules in my mind. The criteria for *not* fuzzing, what we call *negative criteria*, says that it's a no if "all modified code falls strictly into one or more of these categories... - Code paths exclusive to architectures other than the target architecture". Bingo. So, I need to confirm whether this code is s390-specific. Okay, I need to check the Kconfig, probably `drivers/s390/crypto/Kconfig`, for a `CONFIG_VFIO_AP` or something similar, to see if it's conditionally compiled. I'll need to run `grepper` or just inspect the Kconfig file directly to verify this. Then, I can make a call. |
| 4/2 | 2026/10/24 07:10 | tool | grepper |
0mArgs:{
"Expression": "config VFIO_AP"
}Results: {
"Output": "arch/s390/Kconfig=835=config VFIO_CCW\n--\narch/s390/Kconfig-845-\narch/s390/Kconfig:846:config VFIO_AP\narch/s390/Kconfig-847-\tdef_tristate n\n"
} |
| 5/2 | 2026/10/24 07:10 | llm | patch-evaluator |
0mModel:gemini-3.8-flash Args: null Results: null Tokens: input: 35326 output: 37 thoughts: 51 Thoughts: Here's my summary, as though I'm thinking through this: **Investigating a VFIO Configuration Option on s390** Okay, so I see that `CONFIG_VFIO_AP` is defined within the `arch/s390/Kconfig` file. That's good to know; it tells me where to look for the configuration option's definition and any associated dependencies. My next step is to examine the contents of `arch/s390/Kconfig` to understand this particular setting more thoroughly. I'll need to use `read-file` around line 846, or thereabouts, to zero in on the relevant section and gather details about its purpose, default value (if any), and any dependencies on other Kconfig options. This should give me a good handle on what `CONFIG_VFIO_AP` actually *does* and its place within the s390 architecture's configuration space. |
| 6/2 | 2026/10/24 07:10 | tool | read-file |
0mArgs:{
"File": "arch/s390/Kconfig",
"FirstLine": 840,
"LineCount": 25
}Results: {
"Contents": " 840:\t\thelp\n 841:\t\t This driver allows usage of I/O subchannels via VFIO-CCW.\n 842:\t\n 843:\t\t To compile this driver as a module, choose M here: the\n 844:\t\t module will be called vfio_ccw.\n 845:\t\n 846:\tconfig VFIO_AP\n 847:\t\tdef_tristate n\n 848:\t\tprompt \"VFIO support for AP devices\"\n 849:\t\tdepends on KVM\n 850:\t\tdepends on VFIO\n 851:\t\tdepends on AP\n 852:\t\tselect VFIO_MDEV\n 853:\t\thelp\n 854:\t\t This driver grants access to Adjunct Processor (AP) devices\n 855:\t\t via the VFIO mediated device interface.\n 856:\t\n 857:\t\t To compile this driver as a module, choose M here: the module\n 858:\t\t will be called vfio_ap.\n 859:\t\n 860:\tendmenu\n 861:\t\n 862:\tconfig CCW\n 863:\t\tdef_bool y\n 864:\t\n"
} |
| 7/2 | 2026/10/24 07:10 | llm | patch-evaluator |
0mModel:gemini-3.8-flash Args: null Results: null Tokens: input: 35942 output: 20 thoughts: 79 Thoughts: Okay, here's my thought process as I delve into this: **Investigating `CONFIG_VFIO_AP` Compatibility** Right, so I need to figure out if `CONFIG_VFIO_AP` can be compiled or enabled on amd64 (or x86_64, whichever we're calling it). My immediate question is whether this option is even *relevant* to that architecture. I remember seeing something about the `arch/s390/Kconfig` file, but that's obviously specific to S390. The core of the issue is whether the underlying driver, likely in `drivers/s390`, is compiled for the amd64 architecture. That seems like the logical next step. I should check `drivers/Makefile` now to see. |
| 8/2 | 2026/10/24 07:10 | tool | grepper |
0mArgs:{
"Expression": "drivers/s390"
}Results: {
"Output": "Documentation/admin-guide/kernel-parameters.txt=98=Kernel parameters\n--\nDocumentation/admin-guide/kernel-parameters.txt-1141-\tdasd=\t\t[HW,NET]\nDocumentation/admin-guide/kernel-parameters.txt:1142:\t\t\tSee header of drivers/s390/block/dasd_devmap.c.\nDocumentation/admin-guide/kernel-parameters.txt-1143-\n--\nDocumentation/arch/s390/vfio-ap-locking.rst=8=will be used to denote instances of the structures herein described:\n--\nDocumentation/arch/s390/vfio-ap-locking.rst-15-\nDocumentation/arch/s390/vfio-ap-locking.rst:16:The Matrix Devices Lock (drivers/s390/crypto/vfio_ap_private.h)\nDocumentation/arch/s390/vfio-ap-locking.rst-17----------------------------------------------------------------\n--\nDocumentation/arch/s390/vfio-ap-locking.rst=52=been attached to the KVM guest.\nDocumentation/arch/s390/vfio-ap-locking.rst-53-\nDocumentation/arch/s390/vfio-ap-locking.rst:54:The Guests Lock (drivers/s390/crypto/vfio_ap_private.h)\nDocumentation/arch/s390/vfio-ap-locking.rst-55------------------------------------------------------------\n--\nDocumentation/driver-api/s390-drivers.rst=79=strange side effects may happen.\n--\nDocumentation/driver-api/s390-drivers.rst-83-\nDocumentation/driver-api/s390-drivers.rst:84:.. kernel-doc:: drivers/s390/cio/device.c\nDocumentation/driver-api/s390-drivers.rst-85- :export:\nDocumentation/driver-api/s390-drivers.rst-86-\nDocumentation/driver-api/s390-drivers.rst:87:.. kernel-doc:: drivers/s390/cio/device_ops.c\nDocumentation/driver-api/s390-drivers.rst-88- :export:\n--\nDocumentation/driver-api/s390-drivers.rst=95=attached device.\n--\nDocumentation/driver-api/s390-drivers.rst-99-\nDocumentation/driver-api/s390-drivers.rst:100:.. kernel-doc:: drivers/s390/cio/cmf.c\nDocumentation/driver-api/s390-drivers.rst-101- :export:\n--\nDocumentation/driver-api/s390-drivers.rst=112=ccw group devices\n--\nDocumentation/driver-api/s390-drivers.rst-117-\nDocumentation/driver-api/s390-drivers.rst:118:.. kernel-doc:: drivers/s390/cio/ccwgroup.c\nDocumentation/driver-api/s390-drivers.rst-119- :export:\n--\nDocumentation/driver-api/s390-drivers.rst=132=interrupts and interrupt vectors.\nDocumentation/driver-api/s390-drivers.rst-133-\nDocumentation/driver-api/s390-drivers.rst:134:.. kernel-doc:: drivers/s390/cio/airq.c\nDocumentation/driver-api/s390-drivers.rst-135- :export:\n--\nDocumentation/filesystems/porting.rst=271=Use bdev_read_only(bdev) instead of is_read_only(kdev). The latter\nDocumentation/filesystems/porting.rst:272:is still alive, but only because of the mess in drivers/s390/block/dasd.c.\nDocumentation/filesystems/porting.rst-273-As soon as it gets fixed is_read_only() will die.\n--\nDocumentation/userspace-api/ioctl/ioctl-number.rst=73=Code Seq# Include File Comments\n--\nDocumentation/userspace-api/ioctl/ioctl-number.rst-110-'2' 01-04 linux/i2o.h\nDocumentation/userspace-api/ioctl/ioctl-number.rst:111:'3' 00-0F drivers/s390/char/raw3270.h conflict!\nDocumentation/userspace-api/ioctl/ioctl-number.rst-112-'3' 00-1F linux/suspend_ioctls.h, conflict!\n--\nDocumentation/userspace-api/ioctl/ioctl-number.rst-314- \u003cmailto:oe@port.de\u003e\nDocumentation/userspace-api/ioctl/ioctl-number.rst:315:'z' 10-4F drivers/s390/crypto/zcrypt_api.h conflict!\nDocumentation/userspace-api/ioctl/ioctl-number.rst-316-'|' 00-7F linux/media.h\n--\nDocumentation/userspace-api/ioctl/ioctl-number.rst-398-0xCF 02 fs/smb/client/cifs_ioctl.h\nDocumentation/userspace-api/ioctl/ioctl-number.rst:399:0xDD 00-3F ZFCP device driver see drivers/s390/scsi/\nDocumentation/userspace-api/ioctl/ioctl-number.rst-400- \u003cmailto:aherrman@de.ibm.com\u003e\n--\nMAINTAINERS=14383=F:\tarch/s390/mm/gmap_helpers.c\nMAINTAINERS:14384:F:\tdrivers/s390/char/uvdevice.c\nMAINTAINERS:14385:F:\ttools/testing/selftests/drivers/s390x/uvdevice/\nMAINTAINERS-14386-F:\ttools/testing/selftests/kvm/*/s390/\n--\nMAINTAINERS=18901=F:\tdrivers/ptp/\nMAINTAINERS:18902:F:\tdrivers/s390/net/\nMAINTAINERS-18903-F:\tinclude/dt-bindings/net/\n--\nMAINTAINERS=24076=F:\tdrivers/cpuidle/cpuidle-s390.c\nMAINTAINERS:24077:F:\tdrivers/s390/\nMAINTAINERS-24078-F:\tdrivers/watchdog/diag288_wdt.c\n--\nMAINTAINERS=24084=S:\tSupported\nMAINTAINERS:24085:F:\tdrivers/s390/cio/\nMAINTAINERS-24086-\n--\nMAINTAINERS=24102=F:\tblock/partitions/ibm.c\nMAINTAINERS:24103:F:\tdrivers/s390/block/dasd*\nMAINTAINERS-24104-F:\tinclude/linux/dasd_mod.h\n--\nMAINTAINERS=24127=S:\tSupported\nMAINTAINERS:24128:F:\tdrivers/s390/net/*iucv*\nMAINTAINERS-24129-F:\tinclude/net/iucv/\n--\nMAINTAINERS=24146=S:\tSupported\nMAINTAINERS:24147:F:\tdrivers/s390/net/\nMAINTAINERS-24148-\n--\nMAINTAINERS=24167=S:\tSupported\nMAINTAINERS:24168:F:\tdrivers/s390/block/scm*\nMAINTAINERS:24169:F:\tdrivers/s390/cio/scm.c\nMAINTAINERS-24170-\n--\nMAINTAINERS=24179=F:\tDocumentation/arch/s390/vfio-ap*\nMAINTAINERS:24180:F:\tdrivers/s390/crypto/vfio_ap*\nMAINTAINERS-24181-\n--\nMAINTAINERS=24190=F:\tDocumentation/arch/s390/vfio-ccw.rst\nMAINTAINERS:24191:F:\tdrivers/s390/cio/vfio_ccw*\nMAINTAINERS-24192-F:\tinclude/uapi/linux/vfio_ccw.h\n--\nMAINTAINERS=24215=F:\tarch/s390/include/uapi/asm/zcrypt.h\nMAINTAINERS:24216:F:\tdrivers/s390/crypto/\nMAINTAINERS-24217-\n--\nMAINTAINERS=24221=S:\tSupported\nMAINTAINERS:24222:F:\tdrivers/s390/scsi/zfcp_*\nMAINTAINERS-24223-\n--\nMAINTAINERS=28910=F:\tarch/s390/include/uapi/asm/virtio-ccw.h\nMAINTAINERS:28911:F:\tdrivers/s390/virtio/\nMAINTAINERS-28912-\n--\narch/s390/boot/Makefile=24=KBUILD_CFLAGS += $(call cc-option, -Wno-default-const-init-unsafe)\narch/s390/boot/Makefile-25-\narch/s390/boot/Makefile:26:CFLAGS_sclp_early_core.o += -I$(srctree)/drivers/s390/char\narch/s390/boot/Makefile-27-\n--\narch/s390/boot/sclp_early_core.c-2-#include \"boot.h\"\narch/s390/boot/sclp_early_core.c:3:#include \"../../../drivers/s390/char/sclp_early_core.c\"\narch/s390/boot/sclp_early_core.c-4-\n--\narch/s390/include/asm/cio.h=374=struct gen_pool *cio_gp_dma_create(struct device *dma_dev, int nr_pages);\narch/s390/include/asm/cio.h-375-\narch/s390/include/asm/cio.h:376:/* Function from drivers/s390/cio/chsc.c */\narch/s390/include/asm/cio.h-377-int chsc_sstpc(void *page, unsigned int op, u16 ctrl, long *clock_delta);\n--\narch/s390/mm/cmm.c=31=MODULE_PARM_DESC(sender,\n--\narch/s390/mm/cmm.c-33-\narch/s390/mm/cmm.c:34:#include \"../../../drivers/s390/net/smsgiucv.h\"\narch/s390/mm/cmm.c-35-\n--\ndrivers/block/Kconfig=267=config SUNVDC\n--\ndrivers/block/Kconfig-273-\ndrivers/block/Kconfig:274:source \"drivers/s390/block/Kconfig\"\ndrivers/block/Kconfig-275-\n--\ndrivers/char/Kconfig=345=config TELCLOCK\n--\ndrivers/char/Kconfig-357-\ndrivers/char/Kconfig:358:source \"drivers/s390/char/Kconfig\"\ndrivers/char/Kconfig-359-\n--\ndrivers/net/Kconfig=530=source \"drivers/net/slip/Kconfig\"\ndrivers/net/Kconfig-531-\ndrivers/net/Kconfig:532:source \"drivers/s390/net/Kconfig\"\ndrivers/net/Kconfig-533-\n--\ndrivers/s390/block/dasd_diag.c-3- * Author(s)......: Holger Smolinski \u003cHolger.Smolinski@de.ibm.com\u003e\ndrivers/s390/block/dasd_diag.c:4: * Based on.......: linux/drivers/s390/block/mdisk.c\ndrivers/s390/block/dasd_diag.c-5- * ...............: by Hartmunt Penner \u003chpenner@de.ibm.com\u003e\n--\ndrivers/s390/block/dasd_diag.h-3- * Author(s)......: Holger Smolinski \u003cHolger.Smolinski@de.ibm.com\u003e\ndrivers/s390/block/dasd_diag.h:4: * Based on.......: linux/drivers/s390/block/mdisk.h\ndrivers/s390/block/dasd_diag.h-5- * ...............: by Hartmunt Penner \u003chpenner@de.ibm.com\u003e\n--\ninclude/net/iucv/iucv.h-2-/*\ninclude/net/iucv/iucv.h:3: * drivers/s390/net/iucv.h\ninclude/net/iucv/iucv.h-4- * IUCV base support.\n--\ntools/testing/selftests/Makefile=23=TARGETS += drivers/ntsync\ntools/testing/selftests/Makefile:24:TARGETS += drivers/s390x/uvdevice\ntools/testing/selftests/Makefile-25-TARGETS += drivers/net\n"
} |
| 9/2 | 2026/10/24 07:10 | llm | patch-evaluator |
1mModel:gemini-3.8-flash Args: null Results: null Tokens: input: 39664 output: 22 thoughts: 23 Thoughts: Here's a summary of my thought process, tailored for an expert like you: **Investigating s390 Crypto Driver Dependencies** Okay, so I need to understand the build dependencies and configuration options surrounding the `drivers/s390/crypto` directory. My immediate strategy is to pinpoint where this directory is included within the kernel's build system. Specifically, I need to check the `Makefile` and `Kconfig` files that influence its compilation and configuration. This will give me a clear picture of: * **Build-time inclusion:** Which higher-level `Makefiles` reference this directory and, therefore, integrate its components. Understanding the build path is crucial for making targeted changes or analyzing the impact of modifications. * **Configuration options:** What configuration flags (`CONFIG_` options in `Kconfig`) determine whether the crypto driver is built or included as a module. I need to know the relevant `CONFIG` options that control the inclusion of crypto components. These details influence whether I need to make changes to `Kconfig` files, and also help to understand the design tradeoffs made by the kernel developers. Knowing the include statements in `Makefile` and `Kconfig` is key to forming a complete picture of the crypto driver's context within the build process and configuration system. This is where I'll begin. |
| 10/2 | 2026/10/24 07:11 | tool | grepper |
0mArgs:{
"Expression": "drivers/s390/crypto"
}Results: {
"Output": "Documentation/arch/s390/vfio-ap-locking.rst=8=will be used to denote instances of the structures herein described:\n--\nDocumentation/arch/s390/vfio-ap-locking.rst-15-\nDocumentation/arch/s390/vfio-ap-locking.rst:16:The Matrix Devices Lock (drivers/s390/crypto/vfio_ap_private.h)\nDocumentation/arch/s390/vfio-ap-locking.rst-17----------------------------------------------------------------\n--\nDocumentation/arch/s390/vfio-ap-locking.rst=52=been attached to the KVM guest.\nDocumentation/arch/s390/vfio-ap-locking.rst-53-\nDocumentation/arch/s390/vfio-ap-locking.rst:54:The Guests Lock (drivers/s390/crypto/vfio_ap_private.h)\nDocumentation/arch/s390/vfio-ap-locking.rst-55------------------------------------------------------------\n--\nDocumentation/userspace-api/ioctl/ioctl-number.rst=73=Code Seq# Include File Comments\n--\nDocumentation/userspace-api/ioctl/ioctl-number.rst-314- \u003cmailto:oe@port.de\u003e\nDocumentation/userspace-api/ioctl/ioctl-number.rst:315:'z' 10-4F drivers/s390/crypto/zcrypt_api.h conflict!\nDocumentation/userspace-api/ioctl/ioctl-number.rst-316-'|' 00-7F linux/media.h\n--\nMAINTAINERS=24179=F:\tDocumentation/arch/s390/vfio-ap*\nMAINTAINERS:24180:F:\tdrivers/s390/crypto/vfio_ap*\nMAINTAINERS-24181-\n--\nMAINTAINERS=24215=F:\tarch/s390/include/uapi/asm/zcrypt.h\nMAINTAINERS:24216:F:\tdrivers/s390/crypto/\nMAINTAINERS-24217-\n"
} |
| 11/2 | 2026/10/24 07:11 | llm | patch-evaluator |
0mModel:gemini-3.8-flash Args: null Results: null Tokens: input: 40539 output: 28 thoughts: 26 Thoughts: Here's my thought process, as if I were reviewing those files: **Initial Assessment: S390 Driver Configuration** Okay, so I need to get a handle on how this S390 architecture's drivers are set up. Let's start with the classic: I'll dive into `drivers/s390/Makefile` first. That should give me a high-level view of what's compiled and linked, and how the overall driver build process is structured for this specific architecture. I'm expecting to see things like object file definitions, dependency rules, and maybe even some conditional compilation based on kernel configuration options. Then, to round things out, I need to look at `drivers/s390/Kconfig`. That's where all the interesting configuration options are defined. I'll be looking for the `CONFIG_` options that control which drivers are enabled, any dependencies between them, and potentially even some default settings. This is where the core logic of what gets built based on the user's choices lives. Seeing these two in tandem will give me the whole picture. |
| 12/2 | 2026/10/24 07:12 | tool | grepper |
0mArgs:{
"Expression": "crypto",
"PathPrefixes": [
"drivers/s390"
]
}Results: {
"Output": "\nFull output is too long, showing 200 out of 380 lines.\nUse more precise expression or PathPrefixes if possible.\n\nNumber of matching lines per file (20 files in total):\ndrivers/s390/Makefile:1\ndrivers/s390/char/sclp_ap.c:1\ndrivers/s390/char/uvdevice.c:3\ndrivers/s390/crypto/Makefile:1\ndrivers/s390/crypto/ap_bus.c:4\ndrivers/s390/crypto/ap_bus.h:2\ndrivers/s390/crypto/ap_queue.c:2\ndrivers/s390/crypto/pkey_pckmo.c:1\ndrivers/s390/crypto/vfio_ap_ops.c:14\ndrivers/s390/crypto/vfio_ap_private.h:1\ndrivers/s390/crypto/zcrypt_api.c:1\ndrivers/s390/crypto/zcrypt_api.h:5\ndrivers/s390/crypto/zcrypt_card.c:7\ndrivers/s390/crypto/zcrypt_ccamisc.c:9\ndrivers/s390/crypto/zcrypt_ccamisc.h:2\ndrivers/s390/crypto/zcrypt_cex4.c:1\ndrivers/s390/crypto/zcrypt_ep11misc.c:4\ndrivers/s390/crypto/zcrypt_msgtype50.c:7\ndrivers/s390/crypto/zcrypt_msgtype6.c:10\ndrivers/s390/crypto/zcrypt_queue.c:7\n\ndrivers/s390/Makefile-5-\ndrivers/s390/Makefile:6:obj-y += cio/ block/ char/ crypto/ net/ scsi/ virtio/\n--\ndrivers/s390/char/sclp_ap.c-2-/*\ndrivers/s390/char/sclp_ap.c:3: * s390 crypto adapter related sclp functions.\ndrivers/s390/char/sclp_ap.c-4- *\n--\ndrivers/s390/char/uvdevice.c=131=static int get_uvio_attest(struct uvio_ioctl_cb *uv_ioctl, struct uvio_attest *uvio_attest)\n--\ndrivers/s390/char/uvdevice.c-167- *\ndrivers/s390/char/uvdevice.c:168: * The Attestation Request Control Block (ARCB) is a cryptographically verified\ndrivers/s390/char/uvdevice.c-169- * and secured request to UV and User Data is some plaintext data which is\n--\ndrivers/s390/char/uvdevice.c-171- *\ndrivers/s390/char/uvdevice.c:172: * Measurement is a cryptographic measurement of the callers properties,\ndrivers/s390/char/uvdevice.c-173- * optional data configured by the ARCB and the user data. If specified by the\n--\ndrivers/s390/char/uvdevice.c=185=static int uvio_attestation(struct uvio_ioctl_cb *uv_ioctl)\n--\ndrivers/s390/char/uvdevice.c-256- * The argument has to point to an Add Secret Request Control Block\ndrivers/s390/char/uvdevice.c:257: * which is an encrypted and cryptographically verified request that\ndrivers/s390/char/uvdevice.c-258- * inserts a protected guest's secrets into the Ultravisor for later\n--\ndrivers/s390/crypto/Makefile-2-#\ndrivers/s390/crypto/Makefile:3:# S/390 crypto devices\ndrivers/s390/crypto/Makefile-4-#\n--\ndrivers/s390/crypto/ap_bus.c-37-#include \u003casm/facility.h\u003e\ndrivers/s390/crypto/ap_bus.c:38:#include \u003clinux/crypto.h\u003e\ndrivers/s390/crypto/ap_bus.c-39-#include \u003clinux/device-id/ap.h\u003e\n--\ndrivers/s390/crypto/ap_bus.c=114=debug_info_t *ap_dbf_info;\n--\ndrivers/s390/crypto/ap_bus.c-118- * layer. The pkey layer may be triggered via the in-kernel interface from\ndrivers/s390/crypto/ap_bus.c:119: * a protected key crypto algorithm (namely PAES) to convert a secure key\ndrivers/s390/crypto/ap_bus.c-120- * into a protected key. This happens in a workqueue context, so sleeping\n--\ndrivers/s390/crypto/ap_bus.c=1136=bool ap_bus_force_rescan(void)\n--\ndrivers/s390/crypto/ap_bus.c-1148-\t * There is one unlikely but nevertheless valid scenario where the\ndrivers/s390/crypto/ap_bus.c:1149:\t * thread holding the mutex may try to send some crypto load but\ndrivers/s390/crypto/ap_bus.c-1150-\t * all cards are offline so a rescan is triggered which causes\n--\ndrivers/s390/crypto/ap_bus.c=2595=static int __init ap_module_init(void)\n--\ndrivers/s390/crypto/ap_bus.c-2628-\t !test_bit_inv(ap_domain_index, ap_perms.aqm))) {\ndrivers/s390/crypto/ap_bus.c:2629:\t\tpr_warn(\"%d is not a valid cryptographic domain\\n\",\ndrivers/s390/crypto/ap_bus.c-2630-\t\t\tap_domain_index);\n--\ndrivers/s390/crypto/ap_bus.h=135=struct ap_driver {\n--\ndrivers/s390/crypto/ap_bus.h-142-\t * Called at the start of the ap bus scan function when\ndrivers/s390/crypto/ap_bus.h:143:\t * the crypto config information (qci) has changed.\ndrivers/s390/crypto/ap_bus.h-144-\t * This callback is not invoked if there is no AP\n--\ndrivers/s390/crypto/ap_bus.h-150-\t * Called at the end of the ap bus scan function when\ndrivers/s390/crypto/ap_bus.h:151:\t * the crypto config information (qci) has changed.\ndrivers/s390/crypto/ap_bus.h-152-\t * This callback is not invoked if there is no AP\n--\ndrivers/s390/crypto/ap_queue.c=1288=EXPORT_SYMBOL(ap_queue_usable);\n--\ndrivers/s390/crypto/ap_queue.c-1290-/**\ndrivers/s390/crypto/ap_queue.c:1291: * ap_cancel_message(): Cancel a crypto request.\ndrivers/s390/crypto/ap_queue.c-1292- * @aq: The AP device that has the message queued\n--\ndrivers/s390/crypto/ap_queue.c-1294- *\ndrivers/s390/crypto/ap_queue.c:1295: * Cancel a crypto request. This is done by removing the request\ndrivers/s390/crypto/ap_queue.c-1296- * from the device pending or request queue. Note that the\n--\ndrivers/s390/crypto/pkey_pckmo.c-13-#include \u003casm/cpacf.h\u003e\ndrivers/s390/crypto/pkey_pckmo.c:14:#include \u003ccrypto/aes.h\u003e\ndrivers/s390/crypto/pkey_pckmo.c-15-#include \u003clinux/random.h\u003e\n--\ndrivers/s390/crypto/vfio_ap_ops.c=39=static void vfio_ap_mdev_reset_queue(struct vfio_ap_queue *q);\n--\ndrivers/s390/crypto/vfio_ap_ops.c-50- * 2. kvm-\u003elock:\t required to update a guest's APCB\ndrivers/s390/crypto/vfio_ap_ops.c:51: * 3. kvm-\u003earch.crypto.pqap_hook_rwsem: required to update pqap_hook and\ndrivers/s390/crypto/vfio_ap_ops.c-52- *\t\t\t\t\tserialize against PQAP intercepts\n--\ndrivers/s390/crypto/vfio_ap_ops.c=57=static inline void get_update_locks_for_kvm(struct kvm *kvm)\n--\ndrivers/s390/crypto/vfio_ap_ops.c-61-\t\tmutex_lock(\u0026kvm-\u003elock);\ndrivers/s390/crypto/vfio_ap_ops.c:62:\t\tdown_write(\u0026kvm-\u003earch.crypto.pqap_hook_rwsem);\ndrivers/s390/crypto/vfio_ap_ops.c-63-\t}\n--\ndrivers/s390/crypto/vfio_ap_ops.c-74- * 1. matrix_dev-\u003emdevs_lock\ndrivers/s390/crypto/vfio_ap_ops.c:75: * 2. kvm-\u003earch.crypto.pqap_hook_rwsem\ndrivers/s390/crypto/vfio_ap_ops.c-76- * 3. kvm-\u003elock\n--\ndrivers/s390/crypto/vfio_ap_ops.c=81=static inline void release_update_locks_for_kvm(struct kvm *kvm)\n--\ndrivers/s390/crypto/vfio_ap_ops.c-84-\tif (kvm) {\ndrivers/s390/crypto/vfio_ap_ops.c:85:\t\tup_write(\u0026kvm-\u003earch.crypto.pqap_hook_rwsem);\ndrivers/s390/crypto/vfio_ap_ops.c-86-\t\tmutex_unlock(\u0026kvm-\u003elock);\n--\ndrivers/s390/crypto/vfio_ap_ops.c=541=static int handle_pqap(struct kvm_vcpu *vcpu)\n--\ndrivers/s390/crypto/vfio_ap_ops.c-562-\ndrivers/s390/crypto/vfio_ap_ops.c:563:\tif (!vcpu-\u003ekvm-\u003earch.crypto.pqap_hook) {\ndrivers/s390/crypto/vfio_ap_ops.c-564-\t\tVFIO_AP_DBF_WARN(\"%s: PQAP(AQIC) hook not registered with the vfio_ap driver: apqn=0x%04x\\n\",\n--\ndrivers/s390/crypto/vfio_ap_ops.c-569-\ndrivers/s390/crypto/vfio_ap_ops.c:570:\tmatrix_mdev = container_of(vcpu-\u003ekvm-\u003earch.crypto.pqap_hook,\ndrivers/s390/crypto/vfio_ap_ops.c-571-\t\t\t\t struct ap_matrix_mdev, pqap_hook);\n--\ndrivers/s390/crypto/vfio_ap_ops.c=618=static void vfio_ap_mdev_update_guest_apcb(struct ap_matrix_mdev *matrix_mdev)\n--\ndrivers/s390/crypto/vfio_ap_ops.c-620-\tif (matrix_mdev-\u003ekvm) {\ndrivers/s390/crypto/vfio_ap_ops.c:621:\t\tkvm_arch_crypto_set_masks(matrix_mdev-\u003ekvm,\ndrivers/s390/crypto/vfio_ap_ops.c-622-\t\t\t\t\t matrix_mdev-\u003eshadow_apcb.apm,\n--\ndrivers/s390/crypto/vfio_ap_ops.c=1805=static int vfio_ap_mdev_set_kvm(struct ap_matrix_mdev *matrix_mdev,\n--\ndrivers/s390/crypto/vfio_ap_ops.c-1807-{\ndrivers/s390/crypto/vfio_ap_ops.c:1808:\tif (kvm-\u003earch.crypto.crycbd) {\ndrivers/s390/crypto/vfio_ap_ops.c-1809-\t\tget_update_locks_for_kvm(kvm);\ndrivers/s390/crypto/vfio_ap_ops.c:1810:\t\tif (kvm-\u003earch.crypto.pqap_hook) {\ndrivers/s390/crypto/vfio_ap_ops.c-1811-\t\t\trelease_update_locks_for_kvm(kvm);\n--\ndrivers/s390/crypto/vfio_ap_ops.c-1813-\t\t}\ndrivers/s390/crypto/vfio_ap_ops.c:1814:\t\tkvm-\u003earch.crypto.pqap_hook = \u0026matrix_mdev-\u003epqap_hook;\ndrivers/s390/crypto/vfio_ap_ops.c-1815-\n--\ndrivers/s390/crypto/vfio_ap_ops.c=1856=static void vfio_ap_mdev_unset_kvm(struct ap_matrix_mdev *matrix_mdev)\n--\ndrivers/s390/crypto/vfio_ap_ops.c-1859-\ndrivers/s390/crypto/vfio_ap_ops.c:1860:\tif (kvm \u0026\u0026 kvm-\u003earch.crypto.crycbd) {\ndrivers/s390/crypto/vfio_ap_ops.c-1861-\t\tget_update_locks_for_kvm(kvm);\ndrivers/s390/crypto/vfio_ap_ops.c:1862:\t\tkvm-\u003earch.crypto.pqap_hook = NULL;\ndrivers/s390/crypto/vfio_ap_ops.c-1863-\ndrivers/s390/crypto/vfio_ap_ops.c:1864:\t\tkvm_arch_crypto_clear_masks(kvm);\ndrivers/s390/crypto/vfio_ap_ops.c-1865-\t\tvfio_ap_mdev_reset_queues(matrix_mdev);\n--\ndrivers/s390/crypto/vfio_ap_ops.c=2071=static void vfio_ap_mdev_request(struct vfio_device *vdev, unsigned int count)\n--\ndrivers/s390/crypto/vfio_ap_ops.c-2080-\tif (matrix_mdev-\u003ekvm) {\ndrivers/s390/crypto/vfio_ap_ops.c:2081:\t\tkvm_arch_crypto_clear_masks(matrix_mdev-\u003ekvm);\ndrivers/s390/crypto/vfio_ap_ops.c-2082-\t\tsignal_guest_ap_cfg_changed(matrix_mdev);\n--\ndrivers/s390/crypto/vfio_ap_private.h=118=struct ap_matrix_mdev {\n--\ndrivers/s390/crypto/vfio_ap_private.h-123-\tstruct kvm *kvm;\ndrivers/s390/crypto/vfio_ap_private.h:124:\tcrypto_hook pqap_hook;\ndrivers/s390/crypto/vfio_ap_private.h-125-\tstruct mdev_device *mdev;\n--\ndrivers/s390/crypto/zcrypt_api.c=1810=void zcrypt_rng_device_remove(void)\n--\ndrivers/s390/crypto/zcrypt_api.c-1824- * an asynchronous job. This function waits until these initial jobs\ndrivers/s390/crypto/zcrypt_api.c:1825: * are done and so the zcrypt api should be ready to serve crypto\ndrivers/s390/crypto/zcrypt_api.c-1826- * requests - if there are resources available. The function uses an\n--\ndrivers/s390/crypto/zcrypt_api.h-34-/**\ndrivers/s390/crypto/zcrypt_api.h:35: * Large random numbers are pulled in 4096 byte chunks from the crypto cards\ndrivers/s390/crypto/zcrypt_api.h-36- * and stored in a page. Be careful when increasing this buffer due to size\n--\ndrivers/s390/crypto/zcrypt_api.h-52- */\ndrivers/s390/crypto/zcrypt_api.h:53:enum crypto_ops {\ndrivers/s390/crypto/zcrypt_api.h-54-\tMEX_1K,\n--\ndrivers/s390/crypto/zcrypt_api.h=103=struct zcrypt_card {\n--\ndrivers/s390/crypto/zcrypt_api.h-113-\tint max_exp_bit_length;\ndrivers/s390/crypto/zcrypt_api.h:114:\tconst int *speed_rating;\t/* Speed idx of crypto ops. */\ndrivers/s390/crypto/zcrypt_api.h:115:\tatomic_t load;\t\t\t/* Utilization of the crypto device */\ndrivers/s390/crypto/zcrypt_api.h-116-\tint request_count;\t\t/* # current requests. */\n--\ndrivers/s390/crypto/zcrypt_api.h=119=struct zcrypt_queue {\n--\ndrivers/s390/crypto/zcrypt_api.h-126-\tstruct ap_message reply;\t/* Per-device reply structure. */\ndrivers/s390/crypto/zcrypt_api.h:127:\tatomic_t load;\t\t\t/* Utilization of the crypto device */\ndrivers/s390/crypto/zcrypt_api.h-128-\tint request_count;\t\t/* # current requests. */\n--\ndrivers/s390/crypto/zcrypt_card.c-35-/*\ndrivers/s390/crypto/zcrypt_card.c:36: * Device attributes common for all crypto card devices.\ndrivers/s390/crypto/zcrypt_card.c-37- */\n--\ndrivers/s390/crypto/zcrypt_card.c=174=EXPORT_SYMBOL(zcrypt_card_put);\n--\ndrivers/s390/crypto/zcrypt_card.c-176-/**\ndrivers/s390/crypto/zcrypt_card.c:177: * zcrypt_card_register() - Register a crypto card device.\ndrivers/s390/crypto/zcrypt_card.c:178: * @zc: Pointer to a crypto card device\ndrivers/s390/crypto/zcrypt_card.c-179- *\ndrivers/s390/crypto/zcrypt_card.c:180: * Register a crypto card device. Returns 0 if successful.\ndrivers/s390/crypto/zcrypt_card.c-181- */\n--\ndrivers/s390/crypto/zcrypt_card.c=205=EXPORT_SYMBOL(zcrypt_card_register);\n--\ndrivers/s390/crypto/zcrypt_card.c-207-/**\ndrivers/s390/crypto/zcrypt_card.c:208: * zcrypt_card_unregister(): Unregister a crypto card device.\ndrivers/s390/crypto/zcrypt_card.c:209: * @zc: Pointer to crypto card device\ndrivers/s390/crypto/zcrypt_card.c-210- *\ndrivers/s390/crypto/zcrypt_card.c:211: * Unregister a crypto card device.\ndrivers/s390/crypto/zcrypt_card.c-212- */\n--\ndrivers/s390/crypto/zcrypt_ccamisc.c=1599=EXPORT_SYMBOL(cca_ecc2protkey);\n--\ndrivers/s390/crypto/zcrypt_ccamisc.c-1601-/*\ndrivers/s390/crypto/zcrypt_ccamisc.c:1602: * query cryptographic facility from CCA adapter\ndrivers/s390/crypto/zcrypt_ccamisc.c-1603- */\ndrivers/s390/crypto/zcrypt_ccamisc.c:1604:int cca_query_crypto_facility(u16 cardnr, u16 domain,\n\n"
} |
| 13/2 | 2026/10/24 07:12 | llm | patch-evaluator |
0mModel:gemini-3.8-flash Args: null Results: null Tokens: input: 46075 output: 28 thoughts: 8 Thoughts: Okay, here's my take on those thoughts, tailored for an expert audience: **Diving into the `drivers/Makefile`** Right, let's get down to brass tacks. My initial thought process is always a methodical one. We've got a build system, likely a GNU Make-based one, and the `drivers/Makefile` is where a significant chunk of the device driver compilation and linking logic will reside. Knowing the project's structure, I want to immediately assess what's in there. I'm looking for a few key things: * **Dependency Management:** How are dependencies handled? Are they using automatic dependency generation (e.g., `gcc -MMD`)? Hand-rolled dependency rules? This dictates how robust and maintainable the build process will be, especially as the number of drivers grows. * **Driver Specific Rules:** Are there per-driver rules, or a more generalized approach? A generalized approach, using pattern rules is more sustainable for maintaining the codebase. * **Compilation Flags:** What compiler flags are being used? Are there any glaring omissions (e.g., `-Wall`, `-Wextra`, sanitizers)? Are they using a good level of optimization, or are there obvious performance bottlenecks? * **Linking Process:** How are the drivers linked? Is it monolithic, or modular? Are there static libraries involved? What about the kernel object (.ko) module creation? This affects load times and overall system structure. * **Target Architectures/Platforms:** How are different architectures and platforms handled? Is it a mess of `#ifdef`s, or are there cleaner abstractions? Any cross-compilation specific variables? * **Module Installation:** Are there specific rules for installing the drivers? Where are they copied to? What's the target file system structure? I'm mentally preparing for a deep dive; I'm expecting to see macro definitions, variable assignments, and rule definitions. It's time to get a good sense of the project's build automation for the driver subsystem. Let's see if this `Makefile` follows best practices, and can handle changes without causing too much headache down the road. |
| 14/2 | 2026/10/24 07:12 | tool | grepper |
0mArgs:{
"Expression": "s390",
"PathPrefixes": [
"drivers/Makefile"
]
}Results: {
"Output": "drivers/Makefile=199=obj-$(CONFIG_DIBS)\t\t+= dibs/\ndrivers/Makefile:200:obj-$(CONFIG_S390)\t\t+= s390/\n"
} |
| 15/2 | 2026/10/24 07:12 | llm | patch-evaluator |
0mModel:gemini-3.8-flash Args: null Results: null Tokens: input: 46627 output: 46 thoughts: 683 Thoughts: **WorthFuzzing=false Assessment** Okay, let's break this down. My initial observation is that the `drivers/Makefile` includes `s390/` only when `CONFIG_S390` is defined. That's a strong indicator. Now, I need to confirm that `CONFIG_S390` is, as expected, solely an s390 architecture configuration. A quick check in `arch/s390/Kconfig` confirms it; `CONFIG_S390` *is* the architecture configuration for s390. This means, on my target architecture, amd64 (x86_64), `CONFIG_S390` is *never* set. Now, let's apply the negative criteria from Section 2. We're looking for unreachable execution paths. This patch modifies: `Documentation/arch/s390/vfio-ap.rst`, and a bunch of files under `drivers/s390/crypto/Makefile`, `vfio_ap_drv.c`, `vfio_ap_migration.c`, `vfio_ap_ops.c` and `vfio_ap_private.h`. Everything in `drivers/s390/crypto/` is clearly contingent on `CONFIG_S390` via `obj-$(CONFIG_S390)`. A full review of the patch using `git show --stat` confirms that there are no other files touched; it's *all* documentation or code guarded by `CONFIG_S390` within the s390 architecture. Given that `CONFIG_S390` is exclusive to the s390 architecture and, on the amd64 architecture, this code is *never* compiled. In other words, these code paths are *unreachable* on the target. Just to be absolutely sure, I'll quickly check `arch/x86/Kconfig` for any references to `CONFIG_S390` or `drivers/s390`. No dice. Therefore, this falls squarely under the "unreachable execution paths" negative criterion, and `WorthFuzzing=false` is the correct decision. This code is functionally inert on my target system. |
| 16/2 | 2026/10/24 07:12 | tool | grepper |
0mError:no matches Args: {
"Expression": "drivers/s390|CONFIG_S390|CONFIG_VFIO_AP",
"PathPrefixes": [
"arch/x86"
]
}Results: {
"error": "no matches"
} |
| 17/2 | 2026/10/24 07:12 | llm | patch-evaluator |
0mModel:gemini-3.8-flash Args: null Results: null Tokens: input: 47859 output: 122 thoughts: 215 Thoughts: **Analysis of Code Changes and Fuzzing Relevance** Okay, so there's absolutely no need to overthink this. The situation is pretty clear-cut. All the changes are completely confined to the s390 architecture, specifically around the VFIO AP driver migration support within `drivers/s390/crypto/`. This is exclusive to s390; it hinges on `CONFIG_S390` and `CONFIG_VFIO_AP`, configurations that, as an expert, I know are not relevant to the amd64 target. The relevant section in the documentation (Section 2) states that we can deem the changes not worthy of fuzzing (`WorthFuzzing=false`) if *all* modified code falls under specific categories, and one of those is: "Code paths exclusive to architectures other than the target architecture." Therefore, because the target is amd64 and the modified code is *only* on s390, the execution paths in question are, by definition, unreachable in the target environment. No fuzzing is warranted here: `WorthFuzzing = false`. Consequently, `FocusSymbols` and `EnableConfigs` are empty (`[]`). I will set the results to reflect this. The reasoning is clear: the changes are purely s390-specific, and the target is amd64, meaning the new code cannot be executed. |
| 18/2 | 2026/10/24 07:12 | tool | set-results |
0mArgs:{
"EnableConfigs": [],
"FocusSymbols": [],
"Reasoning": "The patch modifies documentation and the vfio_ap driver in drivers/s390/crypto/, implementing live guest migration support for s390 AP devices. These files and configs (CONFIG_VFIO_AP, CONFIG_S390) are exclusive to the s390 architecture and cannot be compiled or executed on the target architecture (amd64). Consequently, all modified executable paths are structurally unreachable on amd64.",
"WorthFuzzing": false
}Results: {
"EnableConfigs": null,
"FocusSymbols": [],
"Reasoning": "The patch modifies documentation and the vfio_ap driver in drivers/s390/crypto/, implementing live guest migration support for s390 AP devices. These files and configs (CONFIG_VFIO_AP, CONFIG_S390) are exclusive to the s390 architecture and cannot be compiled or executed on the target architecture (amd64). Consequently, all modified executable paths are structurally unreachable on amd64.",
"WorthFuzzing": false
} |
| 19/1 | 2026/10/24 07:12 | action | If |
0mArgs:{
"WorthFuzzing": false
}Results: null |
| Total Calls | Total Tokens | Avg Tokens | Total Duration (Seconds) | Avg Duration (Seconds) |
|---|
| Total Calls | Total Duration (Seconds) | Avg Duration (Seconds) |
|---|