| Seq | Timestamp | Type | Name | Duration |
|---|---|---|---|---|
| 0/0 | 2026/09/05 13:20 | flow | patch-triage |
0mArgs:null Results: {
"EnableConfigs": null,
"FocusSymbols": [],
"KMSANReasoning": "",
"NeedsKMSAN": false,
"Reasoning": "The patch only modifies user-space selftests in tools/testing/selftests/net/lib/csum.c and does not alter the compiled kernel image (vmlinux) or kernel modules.",
"WorthFuzzing": false
} |
| 1/1 | 2026/09/05 13:20 | action | read-patch-diff |
0mArgs:null Results: {
"PatchDiff": "commit 9b75a37ccc07febdde57f8a9c5ad7337f43bdb1d\nAuthor: syz-cluster \u003ctriage@syzkaller.com\u003e\nDate: Sat Sep 5 13:20:49 2026 +0000\n\n syz-cluster: applied patch under review\n\ndiff --git a/tools/testing/selftests/net/lib/csum.c b/tools/testing/selftests/net/lib/csum.c\nindex e28884ce3ab39..5c8f9d175dd32 100644\n--- a/tools/testing/selftests/net/lib/csum.c\n+++ b/tools/testing/selftests/net/lib/csum.c\n@@ -2,8 +2,7 @@\n \n /* Test hardware checksum offload: Rx + Tx, IPv4 + IPv6, TCP + UDP.\n *\n- * The test runs on two machines to exercise the NIC. For this reason it\n- * is not integrated in kselftests.\n+ * The test runs on two machines to exercise the NIC.\n *\n * CMD=$((./csum -[46] -[tu] -S $SADDR -D $DADDR -[RT] -r 1 $EXTRA_ARGS))\n *\n@@ -571,15 +570,38 @@ static int recv_prepare_packet(void)\n static int recv_udp(int fd)\n {\n \tstatic char buf[MAX_PAYLOAD_LEN];\n+\tstruct sockaddr_storage addr;\n+\tsocklen_t addrlen;\n \tint ret, count = 0;\n \n \twhile (1) {\n-\t\tret = recv(fd, buf, sizeof(buf), MSG_DONTWAIT);\n+\t\taddrlen = sizeof(addr);\n+\t\tret = recvfrom(fd, buf, sizeof(buf), MSG_DONTWAIT,\n+\t\t\t (struct sockaddr *)\u0026addr, \u0026addrlen);\n \t\tif (ret == -1 \u0026\u0026 errno == EAGAIN)\n \t\t\tbreak;\n \t\tif (ret == -1)\n \t\t\terror(1, errno, \"recv r\");\n \n+\t\tif (cfg_family == PF_INET) {\n+\t\t\tstruct sockaddr_in *sin = (void *)\u0026addr;\n+\n+\t\t\tif (sin-\u003esin_addr.s_addr != cfg_saddr4.sin_addr.s_addr)\n+\t\t\t\tcontinue;\n+\t\t\tif (!cfg_zero_sum \u0026\u0026\n+\t\t\t sin-\u003esin_port != htons(cfg_port_src))\n+\t\t\t\tcontinue;\n+\t\t} else {\n+\t\t\tstruct sockaddr_in6 *sin6 = (void *)\u0026addr;\n+\n+\t\t\tif (memcmp(\u0026sin6-\u003esin6_addr, \u0026cfg_saddr6.sin6_addr,\n+\t\t\t\t sizeof(sin6-\u003esin6_addr)))\n+\t\t\t\tcontinue;\n+\t\t\tif (!cfg_zero_sum \u0026\u0026\n+\t\t\t sin6-\u003esin6_port != htons(cfg_port_src))\n+\t\t\t\tcontinue;\n+\t\t}\n+\n \t\tfprintf(stderr, \"rx: udp: len=%u\\n\", ret);\n \t\tcount++;\n \t}\n@@ -620,6 +642,9 @@ static int recv_verify_packet_tcp(void *th, int len)\n \tif (len \u003c sizeof(*tcph) || tcph-\u003edest != htons(cfg_port_dst))\n \t\treturn -1;\n \n+\tif (tcph-\u003esource != htons(cfg_port_src))\n+\t\treturn -1;\n+\n \treturn recv_verify_csum(th, len, ntohs(tcph-\u003esource), tcph-\u003echeck);\n }\n \n@@ -647,6 +672,9 @@ static int recv_verify_packet_udp(void *th, int len)\n \t\treturn recv_verify_packet_udp_encap(udph + 1,\n \t\t\t\t\t\t len - sizeof(*udph));\n \n+\tif (!cfg_zero_sum \u0026\u0026 udph-\u003esource != htons(cfg_port_src))\n+\t\treturn -1;\n+\n \treturn recv_verify_csum(th, len, ntohs(udph-\u003esource), udph-\u003echeck);\n }\n \n@@ -659,6 +687,9 @@ static int recv_verify_packet_ipv4(void *nh, int len)\n \tif (len \u003c sizeof(*iph) || iph-\u003eprotocol != proto)\n \t\treturn -1;\n \n+\tif (iph-\u003esaddr != cfg_saddr4.sin_addr.s_addr)\n+\t\treturn -1;\n+\n \tip_len = ntohs(iph-\u003etot_len);\n \tif (ip_len \u003e len || ip_len \u003c sizeof(*iph))\n \t\treturn -1;\n@@ -680,6 +711,9 @@ static int recv_verify_packet_ipv6(void *nh, int len)\n \tif (len \u003c sizeof(*ip6h) || ip6h-\u003enexthdr != proto)\n \t\treturn -1;\n \n+\tif (memcmp(\u0026ip6h-\u003esaddr, \u0026cfg_saddr6.sin6_addr, sizeof(ip6h-\u003esaddr)))\n+\t\treturn -1;\n+\n \tpayload_len = ntohs(ip6h-\u003epayload_len);\n \tif (payload_len \u003e len - sizeof(*ip6h))\n \t\treturn -1;\n@@ -940,6 +974,9 @@ static void do_tx(void)\n \t\t\tcfg_payload_len = rand() % MAX_PAYLOAD_LEN;\n \t\t\tbuf = build_packet(_buf, sizeof(_buf), \u0026len);\n \t\t}\n+\n+\t\t/* avoid bursting */\n+\t\tusleep(20);\n \t}\n \n \tif (close(fd))\n"
} |
| 2/1 | 2026/09/05 13:20 | agent | patch-evaluator |
0mModel:core Args: null Results: {
"EnableConfigs": null,
"FocusSymbols": [],
"Reasoning": "The patch only modifies user-space selftests in tools/testing/selftests/net/lib/csum.c and does not alter the compiled kernel image (vmlinux) or kernel modules.",
"WorthFuzzing": false
}Instruction: You are an expert Linux kernel maintainer and security engineer.
Your job is to review a provided patch series and evaluate whether it warrants fuzzing with syzkaller.
IMPORTANT: The changes have ALREADY been applied and committed as the HEAD commit in
your workspace. Do NOT rely on internal assumptions. You must actively use your code access
tools to inspect the actual source code, callers, and surrounding context.
================================================================================
1. CORE TRIAGE PHILOSOPHY
================================================================================
The goal of patch fuzzing is to discover crashes, regressions, exposed latent bugs,
and newly triggered assertions introduced by the patch series.
- REACHABILITY IS THE PRIMARY GATE:
Fuzzing can only discover bugs in code that can actually execute in standard virtualized
environments (GCE or QEMU, utilizing software-emulated devices like USB gadgets, netdev, tun/tap).
If the modified code is structurally unreachable (see Section 2), it MUST NOT be fuzzed,
regardless of whether it adds assertions or complex logic.
- DO NOT BLINDLY TRUST "NO FUNCTIONAL CHANGE" (NFCI) OR "REFACTORING" CLAIMS:
Patch authors routinely label changes as "cleanups", "refactorings", or state
"No functional change intended". Do NOT take these claims at face value.
Code refactorings that rearrange logic, introduce helper functions, or alter state management
in core subsystems frequently introduce subtle semantic shifts or uncover latent kernel bugs.
If reachable executable code is modified or refactored, it MUST be fuzzed.
- NEW OR MODIFIED ASSERTIONS IN REACHABLE CODE MUST BE FUZZED:
When a patch introduces or modifies runtime checks or assertions (e.g., WARN_ON*, VM_WARN_ON*,
BUG_ON*, lockdep_assert*) in reachable code paths, it enforces new or stricter invariants.
Even if the author believes the invariant always holds, fuzzing is essential to verify whether
an unusual sequence of operations can violate it.
================================================================================
2. WHEN TO RETURN WorthFuzzing=false (NEGATIVE CRITERIA)
================================================================================
Return WorthFuzzing=false ONLY IF all modified code falls strictly into one or more of these categories:
- Non-kernel and non-executable changes:
* Modifications to Documentation/, comments, or spelling fixes.
* User-space directories, self-tests, samples, or scripts (e.g., tools/, samples/, scripts/, usr/)
that do not affect the compiled kernel image (vmlinux) or kernel modules.
* Purely decorative logging (e.g., message strings in pr_err, printk, dev_info) or tracepoints
that do not alter control flow or data structures.
* Build system or Kconfig changes that do not alter compiled C logic.
- Structurally unreachable hardware:
* Vendor-specific PCIe switches, SmartNICs, or GPU drivers (e.g., mlxsw, pds_core, qed,
ionic, amdgpu) requiring physical ASIC/PCIe cards not emulated in standard QEMU.
- Unreachable execution paths:
* Driver teardown callbacks (.remove, .shutdown, pci_unregister_driver) executed only during
physical PCI hot-unplug or manual sysfs driver unbinding.
* Code paths exclusive to architectures other than the target architecture.
================================================================================
3. WHEN TO RETURN WorthFuzzing=true (POSITIVE CRITERIA)
================================================================================
Return WorthFuzzing=true whenever the patch touches reachable executable code, including:
- Core Subsystems:
* Any logic modifications in memory management (mm/), synchronization/locking (kernel/locking/),
BPF, scheduler, core networking, VFS, or syscall handling.
- Refactorings and Code Cleanups:
* Any restructuring of reachable data structures, helper abstractions, or algorithm flows.
- Runtime Assertions and Defensive Checks:
* Any introduction or alteration of assertions (WARN_ON*, VM_WARN_ON*, BUG_ON*, etc.) in reachable paths.
- Reachable Drivers and Protocols:
* Drivers accessible via virtual buses (virtio, USB gadget, loopback, netlink, binder, sockets, etc.).
================================================================================
4. EXTRACTING FocusSymbols (PREVENTING DILUTION)
================================================================================
When WorthFuzzing=true, you must extract specific kernel functions into FocusSymbols to guide the fuzzer:
- AVOID UBIQUITOUS LIFECYCLE HOT-PATHS:
Do NOT list generic, ubiquitous functions called by almost every program in the corpus
(including, but not limited to: general memory allocators and deallocators, page fault
and trap handlers, or core synchronization primitives; this is not an exhaustive list).
Listing ubiquitous functions causes the fuzzer to classify thousands of unrelated tests as "focused",
which severely dilutes fuzzing effort away from the actual changes.
- TARGET SPECIFIC FEATURE LOGIC AND ENTRYPOINTS:
List functions that specifically implement the logic being added or altered, or direct API entrypoints
for the subsystem feature under review.
- HANDLING STATIC INLINE FUNCTIONS IN HEADERS (.h):
Compiler-inlined static functions (such as static inlines in mm/*.h or include/linux/*.h) lack
distinct symbol addresses in vmlinux and cannot be targeted directly by symbol coverage filters.
If the changes are primarily in static inline helpers, identify non-static, feature-specific caller
functions in .c files that exercise them (avoiding ubiquitous lifecycle wrappers).
================================================================================
5. IDENTIFYING EnableConfigs
================================================================================
Identify any specific CONFIG_ options required to properly compile and reach the modified code:
- Inspect Kconfig files and #ifdef guards; do not make assumptions.
- Check "depends on" lines in Kconfig to include any non-standard parent subsystem configs needed.
- Strip any 'CONFIG_' prefix (e.g., return "NET_IPV4" instead of "CONFIG_NET_IPV4").
Prefer calling several tools at the same time to save round-trips.
Use set-results tool to provide results of the analysis.
It must be called exactly once before the final reply.
Ignore results of this tool.
Prompt: Target architecture: amd64
For your convenience, here is the diff of the changes:
commit 9b75a37ccc07febdde57f8a9c5ad7337f43bdb1d
Author: syz-cluster <triage@syzkaller.com>
Date: Sat Sep 5 13:20:49 2026 +0000
syz-cluster: applied patch under review
diff --git a/tools/testing/selftests/net/lib/csum.c b/tools/testing/selftests/net/lib/csum.c
index e28884ce3ab39..5c8f9d175dd32 100644
--- a/tools/testing/selftests/net/lib/csum.c
+++ b/tools/testing/selftests/net/lib/csum.c
@@ -2,8 +2,7 @@
/* Test hardware checksum offload: Rx + Tx, IPv4 + IPv6, TCP + UDP.
*
- * The test runs on two machines to exercise the NIC. For this reason it
- * is not integrated in kselftests.
+ * The test runs on two machines to exercise the NIC.
*
* CMD=$((./csum -[46] -[tu] -S $SADDR -D $DADDR -[RT] -r 1 $EXTRA_ARGS))
*
@@ -571,15 +570,38 @@ static int recv_prepare_packet(void)
static int recv_udp(int fd)
{
static char buf[MAX_PAYLOAD_LEN];
+ struct sockaddr_storage addr;
+ socklen_t addrlen;
int ret, count = 0;
while (1) {
- ret = recv(fd, buf, sizeof(buf), MSG_DONTWAIT);
+ addrlen = sizeof(addr);
+ ret = recvfrom(fd, buf, sizeof(buf), MSG_DONTWAIT,
+ (struct sockaddr *)&addr, &addrlen);
if (ret == -1 && errno == EAGAIN)
break;
if (ret == -1)
error(1, errno, "recv r");
+ if (cfg_family == PF_INET) {
+ struct sockaddr_in *sin = (void *)&addr;
+
+ if (sin->sin_addr.s_addr != cfg_saddr4.sin_addr.s_addr)
+ continue;
+ if (!cfg_zero_sum &&
+ sin->sin_port != htons(cfg_port_src))
+ continue;
+ } else {
+ struct sockaddr_in6 *sin6 = (void *)&addr;
+
+ if (memcmp(&sin6->sin6_addr, &cfg_saddr6.sin6_addr,
+ sizeof(sin6->sin6_addr)))
+ continue;
+ if (!cfg_zero_sum &&
+ sin6->sin6_port != htons(cfg_port_src))
+ continue;
+ }
+
fprintf(stderr, "rx: udp: len=%u\n", ret);
count++;
}
@@ -620,6 +642,9 @@ static int recv_verify_packet_tcp(void *th, int len)
if (len < sizeof(*tcph) || tcph->dest != htons(cfg_port_dst))
return -1;
+ if (tcph->source != htons(cfg_port_src))
+ return -1;
+
return recv_verify_csum(th, len, ntohs(tcph->source), tcph->check);
}
@@ -647,6 +672,9 @@ static int recv_verify_packet_udp(void *th, int len)
return recv_verify_packet_udp_encap(udph + 1,
len - sizeof(*udph));
+ if (!cfg_zero_sum && udph->source != htons(cfg_port_src))
+ return -1;
+
return recv_verify_csum(th, len, ntohs(udph->source), udph->check);
}
@@ -659,6 +687,9 @@ static int recv_verify_packet_ipv4(void *nh, int len)
if (len < sizeof(*iph) || iph->protocol != proto)
return -1;
+ if (iph->saddr != cfg_saddr4.sin_addr.s_addr)
+ return -1;
+
ip_len = ntohs(iph->tot_len);
if (ip_len > len || ip_len < sizeof(*iph))
return -1;
@@ -680,6 +711,9 @@ static int recv_verify_packet_ipv6(void *nh, int len)
if (len < sizeof(*ip6h) || ip6h->nexthdr != proto)
return -1;
+ if (memcmp(&ip6h->saddr, &cfg_saddr6.sin6_addr, sizeof(ip6h->saddr)))
+ return -1;
+
payload_len = ntohs(ip6h->payload_len);
if (payload_len > len - sizeof(*ip6h))
return -1;
@@ -940,6 +974,9 @@ static void do_tx(void)
cfg_payload_len = rand() % MAX_PAYLOAD_LEN;
buf = build_packet(_buf, sizeof(_buf), &len);
}
+
+ /* avoid bursting */
+ usleep(20);
}
if (close(fd))
|
| 3/2 | 2026/09/05 13:20 | llm | patch-evaluator |
0mModel:gemini-3.7-flash Args: null Results: null Tokens: input: 3987 output: 75 thoughts: 306 Thoughts: **WorthFuzzing Analysis - Tools/Testing/Selftests Modification** Okay, let's break this down. The diff only touches `tools/testing/selftests/net/lib/csum.c`. Now, I need to apply the negative criteria for `WorthFuzzing`. According to the documentation, I should return `false` *only if* the modified code falls into one of these categories: non-kernel and non-executable changes, or user-space directories like tools/, samples/, scripts/ that *don't* impact the compiled kernel image. `tools/testing/selftests/net/lib/csum.c` is unequivocally under `tools/testing/selftests/`, which means it's clearly user-space self-test code. And self-tests in general do *not* affect the vmlinux image or kernel modules. Just to be absolutely certain, I'm quickly confirming that this is the *only* file modified in the entire commit. Yes, the diff is only showing changes to that one file. Therefore, `WorthFuzzing` has to be `false` here. No need to worry about `FocusSymbols` or `EnableConfigs`. The reasoning is straightforward: this patch is solely focused on user-space selftests located within `tools/testing/selftests/net/lib/csum.c`, and these changes don't touch the kernel image itself. Time to call `set-results` with these findings. |
| 4/2 | 2026/09/05 13:20 | tool | set-results |
0mArgs:{
"EnableConfigs": [],
"FocusSymbols": [],
"Reasoning": "The patch only modifies user-space selftests in tools/testing/selftests/net/lib/csum.c and does not alter the compiled kernel image (vmlinux) or kernel modules.",
"WorthFuzzing": false
}Results: {
"EnableConfigs": null,
"FocusSymbols": [],
"Reasoning": "The patch only modifies user-space selftests in tools/testing/selftests/net/lib/csum.c and does not alter the compiled kernel image (vmlinux) or kernel modules.",
"WorthFuzzing": false
} |
| 5/1 | 2026/09/05 13:20 | action | If |
0mArgs:{
"WorthFuzzing": false
}Results: null |
| Total Calls | Total Tokens | Avg Tokens | Total Duration (Seconds) | Avg Duration (Seconds) |
|---|
| Total Calls | Total Duration (Seconds) | Avg Duration (Seconds) |
|---|