======================================================
WARNING: possible circular locking dependency detected
6.16.0-syzkaller-11895-gcca7a0aae895-dirty #0 Not tainted
------------------------------------------------------
syz.2.152/6660 is trying to acquire lock:
ffff88803e01a6c0 (&ocfs2_sysfile_lock_key[EXTENT_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_reserve_suballoc_bits+0x15e/0x4640

but task is already holding lock:
ffff88803e01b278 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_xattr_set+0x40f/0x11f0

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #5 (&oi->ip_xattr_sem){++++}-{4:4}:
       lock_acquire+0x120/0x360
       down_read+0x46/0x2e0
       ocfs2_init_acl+0x2f9/0x720
       ocfs2_mknod+0x1321/0x2050
       ocfs2_create+0x1a5/0x440
       path_openat+0x14f4/0x3830
       do_filp_open+0x1fa/0x410
       do_sys_openat2+0x121/0x1c0
       __x64_sys_openat+0x138/0x170
       do_syscall_64+0xfa/0x3b0
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #4 (jbd2_handle){++++}-{0:0}:
       lock_acquire+0x120/0x360
       start_this_handle+0x1fa7/0x21c0
       jbd2__journal_start+0x2c1/0x5b0
       jbd2_journal_start+0x2a/0x40
       ocfs2_start_trans+0x376/0x6d0
       ocfs2_mknod+0xe93/0x2050
       ocfs2_create+0x1a5/0x440
       path_openat+0x14f4/0x3830
       do_filp_open+0x1fa/0x410
       do_sys_openat2+0x121/0x1c0
       __x64_sys_openat+0x138/0x170
       do_syscall_64+0xfa/0x3b0
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #3 (&journal->j_trans_barrier){.+.+}-{4:4}:
       lock_acquire+0x120/0x360
       down_read+0x46/0x2e0
       ocfs2_start_trans+0x36a/0x6d0
       ocfs2_mknod+0xe93/0x2050
       ocfs2_create+0x1a5/0x440
       path_openat+0x14f4/0x3830
       do_filp_open+0x1fa/0x410
       do_sys_openat2+0x121/0x1c0
       __x64_sys_openat+0x138/0x170
       do_syscall_64+0xfa/0x3b0
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (sb_internal#5){.+.+}-{0:0}:
       lock_acquire+0x120/0x360
       ocfs2_start_trans+0x26b/0x6d0
       ocfs2_mknod+0xe93/0x2050
       ocfs2_create+0x1a5/0x440
       path_openat+0x14f4/0x3830
       do_filp_open+0x1fa/0x410
       do_sys_openat2+0x121/0x1c0
       __x64_sys_openat+0x138/0x170
       do_syscall_64+0xfa/0x3b0
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&ocfs2_sysfile_lock_key[LOCAL_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}:
       lock_acquire+0x120/0x360
       down_write+0x96/0x1f0
       ocfs2_reserve_local_alloc_bits+0x125/0x24e0
       ocfs2_reserve_clusters_with_limit+0x1be/0xba0
       ocfs2_mknod+0xe32/0x2050
       ocfs2_create+0x1a5/0x440
       path_openat+0x14f4/0x3830
       do_filp_open+0x1fa/0x410
       do_sys_openat2+0x121/0x1c0
       __x64_sys_openat+0x138/0x170
       do_syscall_64+0xfa/0x3b0
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&ocfs2_sysfile_lock_key[EXTENT_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}:
       validate_chain+0xb9b/0x2140
       __lock_acquire+0xab9/0xd20
       lock_acquire+0x120/0x360
       down_write+0x96/0x1f0
       ocfs2_reserve_suballoc_bits+0x15e/0x4640
       ocfs2_reserve_new_metadata_blocks+0x403/0x940
       ocfs2_init_xattr_set_ctxt+0x307/0x700
       ocfs2_xattr_set+0xb70/0x11f0
       ocfs2_set_acl+0x701/0x7b0
       ocfs2_iop_set_acl+0x1aa/0x2a0
       vfs_set_acl+0x887/0xb00
       do_set_acl+0xf6/0x190
       filename_setxattr+0x2e0/0x600
       path_setxattrat+0x364/0x3a0
       __x64_sys_setxattr+0xbc/0xe0
       do_syscall_64+0xfa/0x3b0
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[EXTENT_ALLOC_SYSTEM_INODE] --> jbd2_handle --> &oi->ip_xattr_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_xattr_sem);
                               lock(jbd2_handle);
                               lock(&oi->ip_xattr_sem);
  lock(&ocfs2_sysfile_lock_key[EXTENT_ALLOC_SYSTEM_INODE]);

 *** DEADLOCK ***

3 locks held by syz.2.152/6660:
 #0: ffff888113dd4428 (sb_writers#20){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90
 #1: ffff88803e01b540 (&type->i_mutex_dir_key#14){++++}-{4:4}, at: vfs_set_acl+0x3cd/0xb00
 #2: ffff88803e01b278 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_xattr_set+0x40f/0x11f0

stack backtrace:
CPU: 0 UID: 0 PID: 6660 Comm: syz.2.152 Not tainted 6.16.0-syzkaller-11895-gcca7a0aae895-dirty #0 PREEMPT(full) 
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.2-debian-1.16.2-1 04/01/2014
Call Trace:
 <TASK>
 dump_stack_lvl+0x189/0x250
 print_circular_bug+0x2ee/0x310
 check_noncircular+0x134/0x160
 validate_chain+0xb9b/0x2140
 __lock_acquire+0xab9/0xd20
 lock_acquire+0x120/0x360
 down_write+0x96/0x1f0
 ocfs2_reserve_suballoc_bits+0x15e/0x4640
 ocfs2_reserve_new_metadata_blocks+0x403/0x940
 ocfs2_init_xattr_set_ctxt+0x307/0x700
 ocfs2_xattr_set+0xb70/0x11f0
 ocfs2_set_acl+0x701/0x7b0
 ocfs2_iop_set_acl+0x1aa/0x2a0
 vfs_set_acl+0x887/0xb00
 do_set_acl+0xf6/0x190
 filename_setxattr+0x2e0/0x600
 path_setxattrat+0x364/0x3a0
 __x64_sys_setxattr+0xbc/0xe0
 do_syscall_64+0xfa/0x3b0
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7ff6c358ebe9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ff6c4319038 EFLAGS: 00000246 ORIG_RAX: 00000000000000bc
RAX: ffffffffffffffda RBX: 00007ff6c37b5fa0 RCX: 00007ff6c358ebe9
RDX: 0000200000002b40 RSI: 0000200000002a40 RDI: 0000200000002a00
RBP: 00007ff6c3611e19 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000024 R11: 0000000000000246 R12: 0000000000000000
R13: 00007ff6c37b6038 R14: 00007ff6c37b5fa0 R15: 00007ffe54672e08
 </TASK>
