======================================================
WARNING: possible circular locking dependency detected
6.16.0-rc6-syzkaller-00128-g81e0db8e8398-dirty #0 Not tainted
------------------------------------------------------
syz.1.438/7368 is trying to acquire lock:
ffff88810ba10e00 (team->team_lock_key){+.+.}-{4:4}, at: team_device_event+0x544/0xa20

but task is already holding lock:
ffff88810ff94d30 (&dev_instance_lock_key#3){+.+.}-{4:4}, at: dev_change_flags+0x113/0x260

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&dev_instance_lock_key#3){+.+.}-{4:4}:
       lock_acquire+0x120/0x360
       __mutex_lock+0x182/0xe80
       dev_set_mtu+0x10e/0x260
       team_add_slave+0x8b8/0x2840
       do_set_master+0x533/0x6d0
       do_setlink+0xcf0/0x41c0
       rtnl_newlink+0x160b/0x1c70
       rtnetlink_rcv_msg+0x7cf/0xb70
       netlink_rcv_skb+0x208/0x470
       netlink_unicast+0x75c/0x8e0
       netlink_sendmsg+0x805/0xb30
       __sock_sendmsg+0x21c/0x270
       ____sys_sendmsg+0x505/0x830
       ___sys_sendmsg+0x21f/0x2a0
       __x64_sys_sendmsg+0x19b/0x260
       do_syscall_64+0xfa/0x3b0
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (team->team_lock_key){+.+.}-{4:4}:
       validate_chain+0xb9b/0x2140
       __lock_acquire+0xab9/0xd20
       lock_acquire+0x120/0x360
       __mutex_lock+0x182/0xe80
       team_device_event+0x544/0xa20
       notifier_call_chain+0x1b6/0x3e0
       __dev_notify_flags+0x21b/0x2e0
       netif_change_flags+0xe8/0x1a0
       dev_change_flags+0x130/0x260
       devinet_ioctl+0xbb4/0x1b50
       inet_ioctl+0x3c0/0x4c0
       sock_do_ioctl+0xdc/0x300
       sock_ioctl+0x576/0x790
       __se_sys_ioctl+0xfc/0x170
       do_syscall_64+0xfa/0x3b0
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&dev_instance_lock_key#3);
                               lock(team->team_lock_key);
                               lock(&dev_instance_lock_key#3);
  lock(team->team_lock_key);

 *** DEADLOCK ***

2 locks held by syz.1.438/7368:
 #0: ffffffff8f51bc48 (rtnl_mutex){+.+.}-{4:4}, at: devinet_ioctl+0x323/0x1b50
 #1: ffff88810ff94d30 (&dev_instance_lock_key#3){+.+.}-{4:4}, at: dev_change_flags+0x113/0x260

stack backtrace:
CPU: 1 UID: 0 PID: 7368 Comm: syz.1.438 Not tainted 6.16.0-rc6-syzkaller-00128-g81e0db8e8398-dirty #0 PREEMPT(full) 
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.2-debian-1.16.2-1 04/01/2014
Call Trace:
 <TASK>
 dump_stack_lvl+0x189/0x250
 print_circular_bug+0x2ee/0x310
 check_noncircular+0x134/0x160
 validate_chain+0xb9b/0x2140
 __lock_acquire+0xab9/0xd20
 lock_acquire+0x120/0x360
 __mutex_lock+0x182/0xe80
 team_device_event+0x544/0xa20
 notifier_call_chain+0x1b6/0x3e0
 __dev_notify_flags+0x21b/0x2e0
 netif_change_flags+0xe8/0x1a0
 dev_change_flags+0x130/0x260
 devinet_ioctl+0xbb4/0x1b50
 inet_ioctl+0x3c0/0x4c0
 sock_do_ioctl+0xdc/0x300
 sock_ioctl+0x576/0x790
 __se_sys_ioctl+0xfc/0x170
 do_syscall_64+0xfa/0x3b0
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f09f258e9a9
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f09f33c9038 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 00007f09f27b5fa0 RCX: 00007f09f258e9a9
RDX: 0000200000000180 RSI: 0000000000008914 RDI: 0000000000000004
RBP: 00007f09f2610d69 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f09f27b5fa0 R15: 00007ffc2f4d4bf8
 </TASK>
