ocfs2: Slot 0 on device (7,0) was already allocated to this node!
ocfs2: Mounting device (7,0) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.0.260/7033 is trying to acquire lock:
ffff88810351d240 (&ocfs2_sysfile_lock_key[LOCAL_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_reserve_local_alloc_bits+0x125/0x24e0

but task is already holding lock:
ffff8881130a14e0 (&ocfs2_file_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_extend_dir+0x650/0x4870

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #5 (&ocfs2_file_ip_alloc_sem_key){++++}-{4:4}:
       lock_acquire+0x120/0x360
       down_write+0x96/0x1f0
       ocfs2_try_remove_refcount_tree+0xb6/0x320
       ocfs2_xattr_set+0x595/0x11f0
       ocfs2_set_acl+0x701/0x7b0
       ocfs2_iop_set_acl+0x1aa/0x2a0
       vfs_set_acl+0x887/0xb00
       filename_setxattr+0x2e0/0x600
       path_setxattrat+0x364/0x3a0
       __x64_sys_setxattr+0xbc/0xe0
       do_syscall_64+0xfa/0x3b0
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #4 (&oi->ip_xattr_sem){++++}-{4:4}:
       lock_acquire+0x120/0x360
       down_read+0x46/0x2e0
       ocfs2_init_acl+0x2f9/0x720
       ocfs2_mknod+0x1321/0x2050
       ocfs2_create+0x1a5/0x440
       path_openat+0x14f4/0x3830
       do_filp_open+0x1fa/0x410
       do_sys_openat2+0x121/0x1c0
       __x64_sys_openat+0x138/0x170
       do_syscall_64+0xfa/0x3b0
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #3 (jbd2_handle){++++}-{0:0}:
       lock_acquire+0x120/0x360
       start_this_handle+0x1fa7/0x21c0
       jbd2__journal_start+0x2c1/0x5b0
       jbd2_journal_start+0x2a/0x40
       ocfs2_start_trans+0x376/0x6d0
       ocfs2_mknod+0xe93/0x2050
       ocfs2_create+0x1a5/0x440
       path_openat+0x14f4/0x3830
       do_filp_open+0x1fa/0x410
       do_sys_openat2+0x121/0x1c0
       __x64_sys_creat+0x8f/0xc0
       do_syscall_64+0xfa/0x3b0
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (&journal->j_trans_barrier){.+.+}-{4:4}:
       lock_acquire+0x120/0x360
       down_read+0x46/0x2e0
       ocfs2_start_trans+0x36a/0x6d0
       ocfs2_mknod+0xe93/0x2050
       ocfs2_create+0x1a5/0x440
       path_openat+0x14f4/0x3830
       do_filp_open+0x1fa/0x410
       do_sys_openat2+0x121/0x1c0
       __x64_sys_creat+0x8f/0xc0
       do_syscall_64+0xfa/0x3b0
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (sb_internal#4){.+.+}-{0:0}:
       lock_acquire+0x120/0x360
       ocfs2_start_trans+0x26b/0x6d0
       ocfs2_mknod+0xe93/0x2050
       ocfs2_create+0x1a5/0x440
       path_openat+0x14f4/0x3830
       do_filp_open+0x1fa/0x410
       do_sys_openat2+0x121/0x1c0
       __x64_sys_openat+0x138/0x170
       do_syscall_64+0xfa/0x3b0
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&ocfs2_sysfile_lock_key[LOCAL_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}:
       validate_chain+0xb9b/0x2140
       __lock_acquire+0xab9/0xd20
       lock_acquire+0x120/0x360
       down_write+0x96/0x1f0
       ocfs2_reserve_local_alloc_bits+0x125/0x24e0
       ocfs2_reserve_clusters_with_limit+0x1be/0xba0
       ocfs2_extend_dir+0x701/0x4870
       ocfs2_prepare_dir_for_insert+0x2fe8/0x5450
       ocfs2_rename+0x190a/0x3940
       vfs_rename+0xbda/0xf00
       do_renameat2+0x6ce/0xa80
       __x64_sys_rename+0x82/0x90
       do_syscall_64+0xfa/0x3b0
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[LOCAL_ALLOC_SYSTEM_INODE] --> &oi->ip_xattr_sem --> &ocfs2_file_ip_alloc_sem_key

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&ocfs2_file_ip_alloc_sem_key);
                               lock(&oi->ip_xattr_sem);
                               lock(&ocfs2_file_ip_alloc_sem_key);
  lock(&ocfs2_sysfile_lock_key[LOCAL_ALLOC_SYSTEM_INODE]);

 *** DEADLOCK ***

4 locks held by syz.0.260/7033:
 #0: ffff888106788428 (sb_writers#18){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90
 #1: ffff8881130a1840 (&type->i_mutex_dir_key#12/1){+.+.}-{4:4}, at: do_renameat2+0x3b9/0xa80
 #2: ffff88810351a6c0 (&sb->s_type->i_mutex_key#27/4){+.+.}-{4:4}, at: vfs_rename+0x6d8/0xf00
 #3: ffff8881130a14e0 (&ocfs2_file_ip_alloc_sem_key){++++}-{4:4}, at: ocfs2_extend_dir+0x650/0x4870

stack backtrace:
CPU: 1 UID: 0 PID: 7033 Comm: syz.0.260 Not tainted syzkaller #0 PREEMPT(full) 
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.2-debian-1.16.2-1 04/01/2014
Call Trace:
 <TASK>
 dump_stack_lvl+0x189/0x250
 print_circular_bug+0x2ee/0x310
 check_noncircular+0x134/0x160
 validate_chain+0xb9b/0x2140
 __lock_acquire+0xab9/0xd20
 lock_acquire+0x120/0x360
 down_write+0x96/0x1f0
 ocfs2_reserve_local_alloc_bits+0x125/0x24e0
 ocfs2_reserve_clusters_with_limit+0x1be/0xba0
 ocfs2_extend_dir+0x701/0x4870
 ocfs2_prepare_dir_for_insert+0x2fe8/0x5450
 ocfs2_rename+0x190a/0x3940
 vfs_rename+0xbda/0xf00
 do_renameat2+0x6ce/0xa80
 __x64_sys_rename+0x82/0x90
 do_syscall_64+0xfa/0x3b0
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f758ab8ec29
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f758ba62038 EFLAGS: 00000246 ORIG_RAX: 0000000000000052
RAX: ffffffffffffffda RBX: 00007f758add5fa0 RCX: 00007f758ab8ec29
RDX: 0000000000000000 RSI: 0000200000001cc0 RDI: 0000200000000200
RBP: 00007f758ac11e41 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f758add6038 R14: 00007f758add5fa0 R15: 00007ffdba6a9e68
 </TASK>
