WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.3.532/9960 is trying to acquire lock:
ffff8881a76417a0
 (&ocfs2_sysfile_lock_key[EXTENT_ALLOC_SYSTEM_INODE]
){+.+.}-{4:4}, at: ocfs2_reserve_suballoc_bits+0x16d/0x4840

but task is already holding lock:
ffff8881a763e8e8 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_xattr_set+0x475/0x13e0

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&oi->ip_xattr_sem){++++}-{4:4}:
       down_read+0x47/0x2e0
       ocfs2_init_acl+0x2fd/0x7e0
       ocfs2_mknod+0x1679/0x2260
       ocfs2_create+0x195/0x460
       vfs_create+0x2d1/0x460
       filename_mknodat+0x3e8/0x660
       __se_sys_mknodat+0x3b/0x150
       do_syscall_64+0x15f/0xf80
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2
 (
&journal->j_trans_barrier
){.+.+}-{4:4}:
       down_read+0x47/0x2e0
       ocfs2_start_trans+0x3ab/0x700
       ocfs2_shutdown_local_alloc+0x1f5/0xa40
       ocfs2_dismount_volume+0x1ec/0x8d0
       generic_shutdown_super+0x13d/0x2d0
       kill_block_super+0x44/0x90
       deactivate_locked_super+0xbc/0x130
       cleanup_mnt+0x437/0x4d0
       task_work_run+0x1d9/0x270
       exit_to_user_mode_loop+0xf3/0x4d0
       do_syscall_64+0x33e/0xf80
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (sb_internal#5){.+.+}-{0:0}:
       ocfs2_start_trans+0x2ac/0x700
       ocfs2_create_refcount_tree+0x355/0x1320
       ocfs2_reflink_remap_blocks+0x2fe/0x1a30
       ocfs2_remap_file_range+0x451/0x6f0
       vfs_copy_file_range+0xd80/0x1370
       __se_sys_copy_file_range+0x2fb/0x480
       do_syscall_64+0x15f/0xf80
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&ocfs2_sysfile_lock_key[EXTENT_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}:
       __lock_acquire+0x15a5/0x2cf0
       lock_acquire+0x106/0x350
       down_write+0x96/0x200
       ocfs2_reserve_suballoc_bits+0x16d/0x4840
       ocfs2_reserve_new_metadata_blocks+0x415/0x9a0
       ocfs2_init_xattr_set_ctxt+0x2f5/0x760
       ocfs2_xattr_set+0xc42/0x13e0
       __vfs_setxattr+0x43c/0x480
       __vfs_setxattr_noperm+0x12d/0x660
       vfs_setxattr+0x163/0x360
       ovl_fill_super+0x4b5e/0x5e20
       get_tree_nodev+0xbb/0x150
       vfs_get_tree+0x92/0x2a0
       do_new_mount+0x341/0xd30
       __se_sys_mount+0x31d/0x420
       do_syscall_64+0x15f/0xf80
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &ocfs2_sysfile_lock_key[EXTENT_ALLOC_SYSTEM_INODE] --> &journal->j_trans_barrier --> &oi->ip_xattr_sem

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&oi->ip_xattr_sem);
                               lock(&journal->j_trans_barrier);
                               lock(&oi->ip_xattr_sem);
  lock(&ocfs2_sysfile_lock_key[EXTENT_ALLOC_SYSTEM_INODE]);

 *** DEADLOCK ***

4 locks held by syz.3.532/9960:
 #0: ffff888102fe60d8 (&type->s_umount_key#62/1){+.+.}-{4:4}, at: alloc_super+0x28c/0xab0
 #1: ffff8881b4a54410 (sb_writers#30){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90
 #2: ffff8881a763eba0 (&sb->s_type->i_mutex_key#41){++++}-{4:4}, at: vfs_setxattr+0x13e/0x360
 #3: ffff8881a763e8e8 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_xattr_set+0x475/0x13e0

stack backtrace:
CPU: 1 UID: 0 PID: 9960 Comm: syz.3.532 Not tainted syzkaller #0 PREEMPT(full) 
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.2-debian-1.16.2-1 04/01/2014
Call Trace:
 <TASK>
 dump_stack_lvl+0xe8/0x150
 print_circular_bug+0x2e1/0x300
 check_noncircular+0x12e/0x150
 __lock_acquire+0x15a5/0x2cf0
 lock_acquire+0x106/0x350
 down_write+0x96/0x200
 ocfs2_reserve_suballoc_bits+0x16d/0x4840
 ocfs2_reserve_new_metadata_blocks+0x415/0x9a0
 ocfs2_init_xattr_set_ctxt+0x2f5/0x760
 ocfs2_xattr_set+0xc42/0x13e0
 __vfs_setxattr+0x43c/0x480
 __vfs_setxattr_noperm+0x12d/0x660
 vfs_setxattr+0x163/0x360
 ovl_fill_super+0x4b5e/0x5e20
 get_tree_nodev+0xbb/0x150
 vfs_get_tree+0x92/0x2a0
 do_new_mount+0x341/0xd30
 __se_sys_mount+0x31d/0x420
 do_syscall_64+0x15f/0xf80
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f8795f9cdd9
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f8796dbc028 EFLAGS: 00000246 ORIG_RAX: 00000000000000a5
RAX: ffffffffffffffda RBX: 00007f8796216090 RCX: 00007f8795f9cdd9
RDX: 0000200000000080 RSI: 00002000000000c0 RDI: 0000000000000000
RBP: 00007f8796032d69 R08: 0000200000000280 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f8796216128 R14: 00007f8796216090 R15: 00007ffd7a3294d8
 </TASK>
overlayfs: upper fs missing required features.
