======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.0.11630/16459 is trying to acquire lock:
ffff8881bd0ceed0 (&net->xdp.lock){+.+.}-{4:4}, at: xsk_notifier+0x89/0x230

but task is already holding lock:
ffff88816b3f48c0 (&port->pnodes_lock){+.+.}-{4:4}, at: ipvlan_device_event+0x468/0xe60

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #3 (&port->pnodes_lock){+.+.}-{4:4}:
       __mutex_lock+0x19d/0x1550
       ipvlan_device_event+0x468/0xe60
       notifier_call_chain+0x1a5/0x3d0
       netdev_compute_master_upper_features+0x944/0xb30
       bond_netdev_event+0x7a3/0xf80
       notifier_call_chain+0x1a5/0x3d0
       __netdev_update_features+0xde7/0x1ef0
       __netdev_update_features+0xd78/0x1ef0
       netdev_update_features+0x6f/0x100
       register_vlan_dev+0x679/0x850
       vlan_newlink+0x4b2/0x610
       rtnl_newlink_create+0x305/0x7b0
       rtnl_newlink+0x166d/0x1c30
       rtnetlink_rcv_msg+0x802/0xc00
       netlink_rcv_skb+0x226/0x4a0
       netlink_unicast+0x7bb/0x940
       netlink_sendmsg+0x813/0xb40
       sock_sendmsg_nosec+0x13a/0x180
       ____sys_sendmsg+0x54e/0x850
       ___sys_sendmsg+0x2a5/0x360
       __x64_sys_sendmsg+0x1b1/0x290
       do_syscall_64+0x174/0x580
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (&dev_instance_lock_key#23){+.+.}-{4:4}:
       __mutex_lock+0x19d/0x1550
       xsk_bind+0x331/0x1290
       __sys_bind+0x2e3/0x410
       __x64_sys_bind+0x7a/0x90
       do_syscall_64+0x174/0x580
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&xs->mutex){+.+.}-{4:4}:
       __mutex_lock+0x19d/0x1550
       xsk_notifier+0xcd/0x230
       notifier_call_chain+0x1a5/0x3d0
       unregister_netdevice_many_notify+0x17de/0x2150
       unregister_netdevice_queue+0x2f5/0x340
       __tun_detach+0x1018/0x1880
       tun_chr_close+0x10a/0x1c0
       __fput+0x418/0xa50
       task_work_run+0x1d9/0x270
       exit_to_user_mode_loop+0x1fa/0x730
       do_syscall_64+0x353/0x580
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&net->xdp.lock){+.+.}-{4:4}:
       __lock_acquire+0x1520/0x2cf0
       lock_acquire+0x106/0x350
       __mutex_lock+0x19d/0x1550
       xsk_notifier+0x89/0x230
       notifier_call_chain+0x1a5/0x3d0
       unregister_netdevice_many_notify+0x17de/0x2150
       ipvlan_device_event+0xdd4/0xe60
       notifier_call_chain+0x1a5/0x3d0
       unregister_netdevice_many_notify+0x17de/0x2150
       rtnl_dellink+0x5be/0x810
       rtnetlink_rcv_msg+0x802/0xc00
       netlink_rcv_skb+0x226/0x4a0
       netlink_unicast+0x7bb/0x940
       netlink_sendmsg+0x813/0xb40
       sock_sendmsg_nosec+0x13a/0x180
       ____sys_sendmsg+0x54e/0x850
       ___sys_sendmsg+0x2a5/0x360
       __x64_sys_sendmsg+0x1b1/0x290
       do_syscall_64+0x174/0x580
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &net->xdp.lock --> &dev_instance_lock_key#23 --> &port->pnodes_lock

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&port->pnodes_lock);
                               lock(&dev_instance_lock_key#23);
                               lock(&port->pnodes_lock);
  lock(&net->xdp.lock);

 *** DEADLOCK ***

2 locks held by syz.0.11630/16459:
 #0: ffffffff8fded5c0 (rtnl_mutex){+.+.}-{4:4}, at: rtnl_dellink+0x41b/0x810
 #1: ffff88816b3f48c0 (&port->pnodes_lock){+.+.}-{4:4}, at: ipvlan_device_event+0x468/0xe60

stack backtrace:
CPU: 0 UID: 0 PID: 16459 Comm: syz.0.11630 Not tainted syzkaller #0 PREEMPT(full) 
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.2-debian-1.16.2-1 04/01/2014
Call Trace:
 <TASK>
 dump_stack_lvl+0xe8/0x150
 print_circular_bug+0x2e1/0x300
 check_noncircular+0x12e/0x150
 __lock_acquire+0x1520/0x2cf0
 lock_acquire+0x106/0x350
 __mutex_lock+0x19d/0x1550
 xsk_notifier+0x89/0x230
 notifier_call_chain+0x1a5/0x3d0
 unregister_netdevice_many_notify+0x17de/0x2150
 ipvlan_device_event+0xdd4/0xe60
 notifier_call_chain+0x1a5/0x3d0
 unregister_netdevice_many_notify+0x17de/0x2150
 rtnl_dellink+0x5be/0x810
 rtnetlink_rcv_msg+0x802/0xc00
 netlink_rcv_skb+0x226/0x4a0
 netlink_unicast+0x7bb/0x940
 netlink_sendmsg+0x813/0xb40
 sock_sendmsg_nosec+0x13a/0x180
 ____sys_sendmsg+0x54e/0x850
 ___sys_sendmsg+0x2a5/0x360
 __x64_sys_sendmsg+0x1b1/0x290
 do_syscall_64+0x174/0x580
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f83c8d9ce59
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f83c9be1028 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00007f83c9015fa0 RCX: 00007f83c8d9ce59
RDX: 0000000004000000 RSI: 0000200000000200 RDI: 0000000000000003
RBP: 00007f83c8e32e6f R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f83c9016038 R14: 00007f83c9015fa0 R15: 00007ffdcf441408
 </TASK>
