======================================================
WARNING: possible circular locking dependency detected
syzkaller #0 Not tainted
------------------------------------------------------
syz.2.2688/16322 is trying to acquire lock:
ffff88816e3608c0 (&port->pnodes_lock){+.+.}-{4:4}, at: ipvlan_device_event+0x468/0xe60

but task is already holding lock:
ffff8881bc078e70 (&dev_instance_lock_key#17){+.+.}-{4:4}, at: xdp_features_set_redirect_target+0x34/0x2b0

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&dev_instance_lock_key#17){+.+.}-{4:4}:
       __mutex_lock+0x19d/0x1550
       ipvlan_uninit+0x147/0x290
       unregister_netdevice_many_notify+0x1ad2/0x2150
       ipvlan_device_event+0xdd4/0xe60
       notifier_call_chain+0x1a5/0x3d0
       unregister_netdevice_many_notify+0x17de/0x2150
       rtnl_dellink+0x5be/0x810
       rtnetlink_rcv_msg+0x802/0xc00
       netlink_rcv_skb+0x226/0x4a0
       netlink_unicast+0x7bb/0x940
       netlink_sendmsg+0x813/0xb40
       sock_sendmsg_nosec+0x13a/0x180
       ____sys_sendmsg+0x54e/0x850
       ___sys_sendmsg+0x2a5/0x360
       __x64_sys_sendmsg+0x1b1/0x290
       do_syscall_64+0x174/0x580
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&port->pnodes_lock){+.+.}-{4:4}:
       __lock_acquire+0x1520/0x2cf0
       lock_acquire+0x106/0x350
       __mutex_lock+0x19d/0x1550
       ipvlan_device_event+0x468/0xe60
       notifier_call_chain+0x1a5/0x3d0
       call_netdevice_notifiers+0x90/0xd0
       xdp_features_set_redirect_target+0x1af/0x2b0
       veth_xdp+0x5e0/0x720
       dev_xdp_install+0x39f/0x610
       dev_xdp_attach+0xbdb/0x1050
       dev_change_xdp_fd+0x180/0x200
       do_setlink+0x3b0b/0x4670
       rtnl_newlink+0x146f/0x1c30
       rtnetlink_rcv_msg+0x802/0xc00
       netlink_rcv_skb+0x226/0x4a0
       netlink_unicast+0x7bb/0x940
       netlink_sendmsg+0x813/0xb40
       sock_sendmsg_nosec+0x13a/0x180
       ____sys_sendmsg+0x54e/0x850
       ___sys_sendmsg+0x2a5/0x360
       __x64_sys_sendmsg+0x1b1/0x290
       do_syscall_64+0x174/0x580
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&dev_instance_lock_key#17);
                               lock(&port->pnodes_lock);
                               lock(&dev_instance_lock_key#17);
  lock(&port->pnodes_lock);

 *** DEADLOCK ***

2 locks held by syz.2.2688/16322:
 #0: ffffffff8fded5c0 (rtnl_mutex){+.+.}-{4:4}, at: rtnl_newlink+0xc10/0x1c30
 #1: ffff8881bc078e70 (&dev_instance_lock_key#17){+.+.}-{4:4}, at: xdp_features_set_redirect_target+0x34/0x2b0

stack backtrace:
CPU: 1 UID: 0 PID: 16322 Comm: syz.2.2688 Not tainted syzkaller #0 PREEMPT(full) 
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.2-debian-1.16.2-1 04/01/2014
Call Trace:
 <TASK>
 dump_stack_lvl+0xe8/0x150
 print_circular_bug+0x2e1/0x300
 check_noncircular+0x12e/0x150
 __lock_acquire+0x1520/0x2cf0
 lock_acquire+0x106/0x350
 __mutex_lock+0x19d/0x1550
 ipvlan_device_event+0x468/0xe60
 notifier_call_chain+0x1a5/0x3d0
 call_netdevice_notifiers+0x90/0xd0
 xdp_features_set_redirect_target+0x1af/0x2b0
 veth_xdp+0x5e0/0x720
 dev_xdp_install+0x39f/0x610
 dev_xdp_attach+0xbdb/0x1050
 dev_change_xdp_fd+0x180/0x200
 do_setlink+0x3b0b/0x4670
 rtnl_newlink+0x146f/0x1c30
 rtnetlink_rcv_msg+0x802/0xc00
 netlink_rcv_skb+0x226/0x4a0
 netlink_unicast+0x7bb/0x940
 netlink_sendmsg+0x813/0xb40
 sock_sendmsg_nosec+0x13a/0x180
 ____sys_sendmsg+0x54e/0x850
 ___sys_sendmsg+0x2a5/0x360
 __x64_sys_sendmsg+0x1b1/0x290
 do_syscall_64+0x174/0x580
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f2772f9ce59
Code: ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 e8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f2773e45028 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00007f2773215fa0 RCX: 00007f2772f9ce59
RDX: 0000000000000000 RSI: 0000200000000140 RDI: 0000000000000005
RBP: 00007f2773032e6f R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 00007f2773216038 R14: 00007f2773215fa0 R15: 00007ffd52d68898
 </TASK>
A link change request failed with some changes committed already. Interface macvlan2 may have been left with an inconsistent configuration, please check.
