team_slave_0: entered allmulticast mode
team_slave_1: entered allmulticast mode
dummy0: entered allmulticast mode
======================================================
WARNING: possible circular locking dependency detected
6.16.0-rc3-syzkaller-00159-g223e2288f4b8-dirty #0 Not tainted
------------------------------------------------------
syz.2.581/7846 is trying to acquire lock:
ffff888026b1ce00 (team->team_lock_key){+.+.}-{4:4}, at: team_device_event+0x182/0xa20

but task is already holding lock:
ffff888024046d30 (&dev_instance_lock_key#3){+.+.}-{4:4}, at: do_setlink+0x388/0x41c0

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #1 (&dev_instance_lock_key#3){+.+.}-{4:4}:
       lock_acquire+0x120/0x360
       __mutex_lock+0x182/0xe80
       dev_set_mtu+0x10e/0x260
       team_add_slave+0x8b8/0x2840
       do_set_master+0x533/0x6d0
       do_setlink+0xcf0/0x41c0
       rtnl_newlink+0x160b/0x1c70
       rtnetlink_rcv_msg+0x7cf/0xb70
       netlink_rcv_skb+0x208/0x470
       netlink_unicast+0x75b/0x8d0
       netlink_sendmsg+0x805/0xb30
       __sock_sendmsg+0x21c/0x270
       ____sys_sendmsg+0x505/0x830
       ___sys_sendmsg+0x21f/0x2a0
       __x64_sys_sendmsg+0x19b/0x260
       do_syscall_64+0xfa/0x3b0
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (team->team_lock_key){+.+.}-{4:4}:
       validate_chain+0xb9b/0x2140
       __lock_acquire+0xab9/0xd20
       lock_acquire+0x120/0x360
       __mutex_lock+0x182/0xe80
       team_device_event+0x182/0xa20
       notifier_call_chain+0x1b6/0x3e0
       __dev_notify_flags+0x18d/0x2e0
       netif_change_flags+0xe8/0x1a0
       do_setlink+0xc55/0x41c0
       rtnl_newlink+0x149f/0x1c70
       rtnetlink_rcv_msg+0x7cf/0xb70
       netlink_rcv_skb+0x208/0x470
       netlink_unicast+0x75b/0x8d0
       netlink_sendmsg+0x805/0xb30
       __sock_sendmsg+0x21c/0x270
       ____sys_sendmsg+0x505/0x830
       ___sys_sendmsg+0x21f/0x2a0
       __x64_sys_sendmsg+0x19b/0x260
       do_syscall_64+0xfa/0x3b0
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  lock(&dev_instance_lock_key#3);
                               lock(team->team_lock_key);
                               lock(&dev_instance_lock_key#3);
  lock(team->team_lock_key);

 *** DEADLOCK ***

2 locks held by syz.2.581/7846:
 #0: ffffffff8f50ffc8 (rtnl_mutex){+.+.}-{4:4}, at: rtnl_newlink+0x8db/0x1c70
 #1: ffff888024046d30 (&dev_instance_lock_key#3){+.+.}-{4:4}, at: do_setlink+0x388/0x41c0

stack backtrace:
CPU: 1 UID: 0 PID: 7846 Comm: syz.2.581 Not tainted 6.16.0-rc3-syzkaller-00159-g223e2288f4b8-dirty #0 PREEMPT(full) 
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.2-debian-1.16.2-1 04/01/2014
Call Trace:
 <TASK>
 dump_stack_lvl+0x189/0x250
 print_circular_bug+0x2ee/0x310
 check_noncircular+0x134/0x160
 validate_chain+0xb9b/0x2140
 __lock_acquire+0xab9/0xd20
 lock_acquire+0x120/0x360
 __mutex_lock+0x182/0xe80
 team_device_event+0x182/0xa20
 notifier_call_chain+0x1b6/0x3e0
 __dev_notify_flags+0x18d/0x2e0
 netif_change_flags+0xe8/0x1a0
 do_setlink+0xc55/0x41c0
 rtnl_newlink+0x149f/0x1c70
 rtnetlink_rcv_msg+0x7cf/0xb70
 netlink_rcv_skb+0x208/0x470
 netlink_unicast+0x75b/0x8d0
 netlink_sendmsg+0x805/0xb30
 __sock_sendmsg+0x21c/0x270
 ____sys_sendmsg+0x505/0x830
 ___sys_sendmsg+0x21f/0x2a0
 __x64_sys_sendmsg+0x19b/0x260
 do_syscall_64+0xfa/0x3b0
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f455818e929
Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007f4558fc0038 EFLAGS: 00000246 ORIG_RAX: 000000000000002e
RAX: ffffffffffffffda RBX: 00007f45583b5fa0 RCX: 00007f455818e929
RDX: 0000000000000000 RSI: 0000200000000140 RDI: 0000000000000006
RBP: 00007f4558210b39 R08: 0000000000000000 R09: 0000000000000000
R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000
R13: 0000000000000000 R14: 00007f45583b5fa0 R15: 00007fffed0ba988
 </TASK>
nlmon0: entered allmulticast mode
caif0: entered allmulticast mode
batadv0: entered allmulticast mode
vxcan0: entered allmulticast mode
vxcan1: entered allmulticast mode
veth0: entered allmulticast mode
veth1: entered allmulticast mode
wg0: entered allmulticast mode
wg1: entered allmulticast mode
wg2: entered allmulticast mode
veth0_to_bridge: entered allmulticast mode
veth1_to_bridge: entered allmulticast mode
veth0_to_bond: entered allmulticast mode
bond_slave_0: entered allmulticast mode
veth1_to_bond: entered allmulticast mode
bond_slave_1: entered allmulticast mode
veth0_to_team: entered allmulticast mode
veth1_to_team: entered allmulticast mode
veth0_to_batadv: entered allmulticast mode
batadv_slave_0: entered allmulticast mode
veth1_to_batadv: entered allmulticast mode
batadv_slave_1: left promiscuous mode
batadv_slave_1: entered allmulticast mode
xfrm0: entered allmulticast mode
veth0_to_hsr: entered allmulticast mode
hsr_slave_0: entered allmulticast mode
veth1_to_hsr: entered allmulticast mode
hsr_slave_1: entered allmulticast mode
hsr0: entered allmulticast mode
veth1_virt_wifi: entered allmulticast mode
veth0_virt_wifi: entered allmulticast mode
net veth1_virt_wifi virt_wifi0: entered allmulticast mode
veth1_vlan: entered allmulticast mode
veth0_vlan: entered allmulticast mode
vlan0: entered allmulticast mode
vlan1: entered allmulticast mode
macvlan0: entered allmulticast mode
macvlan1: entered allmulticast mode
ipvlan0: entered allmulticast mode
ipvlan1: entered allmulticast mode
veth1_macvtap: entered allmulticast mode
veth0_macvtap: entered allmulticast mode
macvtap0: entered allmulticast mode
macsec0: left promiscuous mode
macsec0: entered allmulticast mode
geneve0: entered allmulticast mode
geneve1: entered allmulticast mode
mac80211_hwsim hwsim4 wlan0: entered allmulticast mode
mac80211_hwsim hwsim6 wlan1: entered allmulticast mode
gre1: entered allmulticast mode
vxlan0: entered allmulticast mode
macsec1: left promiscuous mode
macvlan2: entered allmulticast mode
sit1: entered allmulticast mode
;: entered allmulticast mode
mac80211_hwsim hwsim4 syzkaller0: entered allmulticast mode
macvlan0.3: entered allmulticast mode
sit2: left promiscuous mode
ipvlan2: entered allmulticast mode
bridge1: entered allmulticast mode
macvlan1.2: entered allmulticast mode
bridge2: entered allmulticast mode
erspan1: entered allmulticast mode
bond0: entered allmulticast mode
netdevsim netdevsim2 eth0: entered allmulticast mode
netdevsim netdevsim2 eth1: entered allmulticast mode
netdevsim netdevsim2 eth2: entered allmulticast mode
netdevsim netdevsim2 eth3: entered allmulticast mode
syztnl0: entered allmulticast mode
bond1: left promiscuous mode
bond2: entered allmulticast mode
tun0: entered allmulticast mode
ip6tnl1: entered allmulticast mode
gre2: entered allmulticast mode
vlan2: left promiscuous mode
team0: left promiscuous mode
team_slave_0: left promiscuous mode
team_slave_1: left promiscuous mode
dummy0: left promiscuous mode
vlan2: entered allmulticast mode
bridge3: entered allmulticast mode
