| Seq | Timestamp | Type | Name | Duration |
|---|---|---|---|---|
| 0/0 | 2026/09/09 13:04 | flow | patch-triage |
0mArgs:null Results: {
"EnableConfigs": null,
"FocusSymbols": [],
"KMSANReasoning": "",
"NeedsKMSAN": false,
"Reasoning": "The patch only modifies user-space selftests (tools/testing/selftests/net/openvswitch/), which does not affect the compiled kernel image (vmlinux) or kernel modules.",
"WorthFuzzing": false
} |
| 1/1 | 2026/09/09 13:04 | action | read-patch-diff |
0mArgs:null Results: {
"PatchDiff": "commit 979e1578a949da58f62b54f76015145630e35e8b\nAuthor: syz-cluster \u003ctriage@syzkaller.com\u003e\nDate: Wed Sep 9 13:04:44 2026 +0000\n\n syz-cluster: applied patch under review\n\ndiff --git a/tools/testing/selftests/net/openvswitch/config b/tools/testing/selftests/net/openvswitch/config\nindex a825e0b5c88e5..fa90475dc388d 100644\n--- a/tools/testing/selftests/net/openvswitch/config\n+++ b/tools/testing/selftests/net/openvswitch/config\n@@ -7,6 +7,7 @@ CONFIG_NET_IPGRE=m\n CONFIG_NET_IPGRE_DEMUX=m\n CONFIG_NF_CONNTRACK=m\n CONFIG_NF_CONNTRACK_OVS=y\n+CONFIG_NF_CT_PROTO_SCTP=y\n CONFIG_OPENVSWITCH=m\n CONFIG_PSAMPLE=m\n CONFIG_VETH=y\ndiff --git a/tools/testing/selftests/net/openvswitch/openvswitch.sh b/tools/testing/selftests/net/openvswitch/openvswitch.sh\nindex a31f7fb6882dc..138a705fc359e 100755\n--- a/tools/testing/selftests/net/openvswitch/openvswitch.sh\n+++ b/tools/testing/selftests/net/openvswitch/openvswitch.sh\n@@ -34,6 +34,8 @@ tests=\"\n \ttrunc\t\t\t\t\ttrunc: output truncation\n \ticmpv6\t\t\t\t\ticmpv6: ICMPv6 echo type match\n \tsctp_connect_v4\t\t\t\tsctp: SCTP flow key matching\n+\tsctp_connect_v6\t\t\tsctp6: SCTP flow key matching over IPv6\n+\tsctp_nat_connect_v4\t\tsctpnat4: SCTP NAT with port translation\n \tpsample\t\t\t\t\tpsample: Sampling packets with psample\"\n \n info() {\n@@ -700,6 +702,113 @@ test_sctp_connect_v4() {\n \treturn 0\n }\n \n+# sctp_connect_v6 test\n+# - sctp(dst=4443) matches client-to-server INIT\n+# - sctp(src=4443) matches server-to-client INIT-ACK\n+# - icmpv6 NS/NA flows forward neighbour discovery\n+# - remove flows and verify connection fails, reinstall and recover\n+test_sctp_connect_v6() {\n+\tlocal t=\"test_sctp_connect_v6\"\n+\tlocal v6=\"eth_type(0x86dd),ipv6(proto=132)\"\n+\tlocal payload=\"SCTP6_DATA_OK\"\n+\tlocal rxfile=\"${ovs_base}/${t}/sctp-rx.txt\"\n+\n+\tmodprobe -q sctp 2\u003e/dev/null || return \"$ksft_skip\"\n+\tsocat -V 2\u003e\u00261 | grep -q \"define WITH_SCTP\" || return \"$ksft_skip\"\n+\t[ -e /proc/sys/net/ipv6 ] || return \"$ksft_skip\"\n+\n+\tsbx_add \"$t\" || return $?\n+\tovs_add_dp \"$t\" sctp6 || return 1\n+\n+\tinfo \"create namespaces\"\n+\tfor ns in client server; do\n+\t\tovs_add_netns_and_veths \"$t\" \"sctp6\" \"$ns\" \\\n+\t\t \"${ns:0:1}0\" \"${ns:0:1}1\" || return 1\n+\tdone\n+\n+\tip netns exec client ip addr add fd00::1/64 dev c1 nodad\n+\tip netns exec client ip link set c1 up\n+\tip netns exec server ip addr add fd00::2/64 dev s1 nodad\n+\tip netns exec server ip link set s1 up\n+\n+\t# NS/NA forwarding\n+\tovs_add_flow \"$t\" sctp6 \\\n+\t 'in_port(1),eth(),eth_type(0x86dd),ipv6(proto=58),icmpv6()' \\\n+\t '2' || return 1\n+\tovs_add_flow \"$t\" sctp6 \\\n+\t 'in_port(2),eth(),eth_type(0x86dd),ipv6(proto=58),icmpv6()' \\\n+\t '1' || return 1\n+\n+\t# SCTP port matching: dst for request, src for reply\n+\tovs_add_flow \"$t\" sctp6 \\\n+\t \"in_port(1),eth(),$v6,sctp(dst=4443)\" \\\n+\t '2' || return 1\n+\tovs_add_flow \"$t\" sctp6 \\\n+\t \"in_port(2),eth(),$v6,sctp(src=4443)\" \\\n+\t '1' || return 1\n+\n+\t# A keyless ipv6(proto=132) install must be refused (EINVAL):\n+\t# match_validate() requires the sctp() key. Pin the reject side\n+\t# of that rule; the keyed installs above cover the accept side.\n+\t# Verify the refusal is EINVAL (missing key), not a parse error.\n+\terr=$(ovs_sbx \"$t\" python3 $ovs_base/ovs-dpctl.py add-flow sctp6 \\\n+\t \"in_port(1),eth(),$v6\" '2' 2\u003e\u00261 \u003e/dev/null) \\\n+\t \u0026\u0026 { info \"keyless SCTP flow should be refused\"\n+\t return 1; }\n+\techo \"$err\" | grep -q \"(22,\" || {\n+\t\tinfo \"keyless SCTP flow refused for wrong reason: $err\"\n+\t\treturn 1\n+\t}\n+\n+\tovs_netns_spawn_daemon \"$t\" \"server\" \\\n+\t socat -u -t 1 SCTP6-LISTEN:4443,fork \\\n+\t OPEN:\"$rxfile\",creat,append\n+\tovs_wait sctp_eps_has server 4443 || return 1\n+\n+\tinfo \"verify SCTP association with port-keyed flows\"\n+\tovs_sbx \"$t\" ip netns exec client \\\n+\t timeout 3 socat -u STDIN \"SCTP6-CONNECT:[fd00::2]:4443\" \u003c/dev/null \\\n+\t || return 1\n+\n+\tinfo \"verify SCTP DATA chunk crosses the datapath\"\n+\tovs_sbx \"$t\" ip netns exec client \\\n+\t timeout 3 socat -u STDIN \"SCTP6-CONNECT:[fd00::2]:4443\" \\\n+\t \u003c\u003c\u003c \"$payload\" || return 1\n+\tovs_wait grep -q \"$payload\" \"$rxfile\" \\\n+\t || { info \"server did not receive SCTP DATA payload\"\n+\t return 1; }\n+\n+\tovs_del_flows \"$t\" sctp6\n+\n+\tinfo \"verify connection fails without flows\"\n+\tovs_add_flow \"$t\" sctp6 \\\n+\t 'in_port(1),eth(),eth_type(0x86dd),ipv6(proto=58),icmpv6()' \\\n+\t '2' || return 1\n+\tovs_add_flow \"$t\" sctp6 \\\n+\t 'in_port(2),eth(),eth_type(0x86dd),ipv6(proto=58),icmpv6()' \\\n+\t '1' || return 1\n+\n+\tovs_sbx \"$t\" ip netns exec client \\\n+\t timeout 3 socat -u STDIN \"SCTP6-CONNECT:[fd00::2]:4443\" \u003c/dev/null \\\n+\t \u003e/dev/null 2\u003e\u00261 \\\n+\t \u0026\u0026 { info \"connection should fail without flows\"\n+\t return 1; }\n+\n+\tinfo \"reinstall flows and verify recovery\"\n+\tovs_add_flow \"$t\" sctp6 \\\n+\t \"in_port(1),eth(),$v6,sctp(dst=4443)\" \\\n+\t '2' || return 1\n+\tovs_add_flow \"$t\" sctp6 \\\n+\t \"in_port(2),eth(),$v6,sctp(src=4443)\" \\\n+\t '1' || return 1\n+\n+\tovs_sbx \"$t\" ip netns exec client \\\n+\t timeout 3 socat -u STDIN \"SCTP6-CONNECT:[fd00::2]:4443\" \u003c/dev/null \\\n+\t || return 1\n+\n+\treturn 0\n+}\n+\n # psample test\n # - use psample to observe packets\n test_psample() {\n@@ -1091,6 +1200,98 @@ test_nat_connect_v4 () {\n \treturn 0\n }\n \n+# sctp_nat_connect_v4 test\n+# - SCTP association crosses a ct(commit,nat(dst=ip:port)) DNAT\n+# - post-recirc flows match the translated address and port, so the\n+# SCTP branch of the post-NAT flow key update is load-bearing\n+test_sctp_nat_connect_v4 () {\n+\tlocal t=\"test_sctp_nat_connect_v4\"\n+\tlocal payload=\"SCTP_NAT_DATA_OK\"\n+\tlocal rxfile=\"${ovs_base}/${t}/sctp-rx.txt\"\n+\n+\tmodprobe -q sctp 2\u003e/dev/null || return \"$ksft_skip\"\n+\tsocat -V 2\u003e\u00261 | grep -q \"define WITH_SCTP\" || return \"$ksft_skip\"\n+\t# SCTP conntrack is compiled into nf_conntrack.ko, so check that\n+\t# loading it actually exposed the SCTP conntrack sysctls.\n+\tmodprobe -q nf_conntrack 2\u003e/dev/null || return \"$ksft_skip\"\n+\t[ -e /proc/sys/net/netfilter/nf_conntrack_sctp_timeout_established ] \\\n+\t || { info \"no SCTP conntrack support - skipping\"\n+\t return \"$ksft_skip\"; }\n+\n+\tsbx_add \"test_sctp_nat_connect_v4\" || return $?\n+\n+\tovs_add_dp \"test_sctp_nat_connect_v4\" sctpnat4 || return 1\n+\tinfo \"create namespaces\"\n+\tfor ns in client server; do\n+\t\tovs_add_netns_and_veths \"test_sctp_nat_connect_v4\" \"sctpnat4\" \\\n+\t\t \"$ns\" \"${ns:0:1}0\" \"${ns:0:1}1\" || return 1\n+\tdone\n+\n+\tip netns exec client ip addr add 172.31.110.10/24 dev c1\n+\tip netns exec client ip link set c1 up\n+\tip netns exec server ip addr add 172.31.110.20/24 dev s1\n+\tip netns exec server ip link set s1 up\n+\n+\tip netns exec client ip route add default via 172.31.110.20\n+\n+\t# Check if the ct and nat actions can be configured.\n+\tovs_add_flow \"test_sctp_nat_connect_v4\" sctpnat4 \\\n+\t\t'in_port(1),eth(),eth_type(0x0800),ipv4()' \\\n+\t\t'ct(commit,nat(dst=172.31.110.20:5555)),recirc(0x1)' \\\n+\t\t\u0026\u003e /dev/null\n+\tif [ $? == 1 ]; then\n+\t\tinfo \"no support for ct/nat actions - skipping\"\n+\t\tovs_exit_sig\n+\t\treturn $ksft_skip\n+\tfi\n+\n+\tovs_del_flows \"test_sctp_nat_connect_v4\" sctpnat4\n+\n+\tovs_add_flow \"test_sctp_nat_connect_v4\" sctpnat4 \\\n+\t\t'in_port(1),eth(),eth_type(0x0806),arp()' '2' || return 1\n+\tovs_add_flow \"test_sctp_nat_connect_v4\" sctpnat4 \\\n+\t\t'in_port(2),eth(),eth_type(0x0806),arp()' '1' || return 1\n+\tovs_add_flow \"test_sctp_nat_connect_v4\" sctpnat4 \\\n+\t\t\"ct_state(-trk),in_port(1),eth(),eth_type(0x0800),\"\\\n+\"ipv4(dst=192.168.0.20)\" \\\n+\t\t\"ct(commit,nat(dst=172.31.110.20:5555)),recirc(0x1)\" || return 1\n+\tovs_add_flow \"test_sctp_nat_connect_v4\" sctpnat4 \\\n+\t\t\"ct_state(-trk),in_port(2),eth(),eth_type(0x0800),ipv4()\" \\\n+\t\t\"ct(commit,nat),recirc(0x2)\" || return 1\n+\n+\tovs_add_flow \"test_sctp_nat_connect_v4\" sctpnat4 \\\n+\t\t\"recirc_id(0x1),ct_state(+trk-inv),in_port(1),eth(),\"\\\n+\"eth_type(0x0800),ipv4(dst=172.31.110.20,proto=132),\"\\\n+\"sctp(dst=5555)\" \\\n+\t\t\"2\" || return 1\n+\tovs_add_flow \"test_sctp_nat_connect_v4\" sctpnat4 \\\n+\t\t\"recirc_id(0x2),ct_state(+trk-inv),in_port(2),eth(),\"\\\n+\"eth_type(0x0800),ipv4(src=192.168.0.20,proto=132),\"\\\n+\"sctp(src=4443)\" \\\n+\t\t\"1\" || return 1\n+\n+\tovs_netns_spawn_daemon \"test_sctp_nat_connect_v4\" \"server\" \\\n+\t\tsocat -u -t 1 SCTP4-LISTEN:5555,fork \\\n+\t\tOPEN:\"$rxfile\",creat,append\n+\tovs_wait sctp_eps_has server 5555 || return 1\n+\n+\tinfo \"verify SCTP association across NAT\"\n+\tovs_sbx \"test_sctp_nat_connect_v4\" ip netns exec client \\\n+\t timeout 3 socat -u STDIN \"SCTP4-CONNECT:192.168.0.20:4443\" \\\n+\t \u003c/dev/null || return 1\n+\n+\tinfo \"verify SCTP DATA chunk crosses NAT\"\n+\tovs_sbx \"test_sctp_nat_connect_v4\" ip netns exec client \\\n+\t timeout 3 socat -u STDIN \"SCTP4-CONNECT:192.168.0.20:4443\" \\\n+\t \u003c\u003c\u003c \"$payload\" || return 1\n+\tovs_wait grep -q \"$payload\" \"$rxfile\" \\\n+\t || { info \"server did not receive SCTP DATA payload\"\n+\t return 1; }\n+\n+\tinfo \"done...\"\n+\treturn 0\n+}\n+\n # nat_related_v4 test\n # - client-\u003eserver ip packets go via SNAT\n # - client solicits ICMP destination unreachable packet from server\n"
} |
| 2/1 | 2026/09/09 13:04 | agent | patch-evaluator |
0mModel:core Args: null Results: {
"EnableConfigs": null,
"FocusSymbols": [],
"Reasoning": "The patch only modifies user-space selftests (tools/testing/selftests/net/openvswitch/), which does not affect the compiled kernel image (vmlinux) or kernel modules.",
"WorthFuzzing": false
}Instruction: You are an expert Linux kernel maintainer and security engineer.
Your job is to review a provided patch series and evaluate whether it warrants fuzzing with syzkaller.
IMPORTANT: The changes have ALREADY been applied and committed as the HEAD commit in
your workspace. Do NOT rely on internal assumptions. You must actively use your code access
tools to inspect the actual source code, callers, and surrounding context.
================================================================================
1. CORE TRIAGE PHILOSOPHY
================================================================================
The goal of patch fuzzing is to discover crashes, regressions, exposed latent bugs,
and newly triggered assertions introduced by the patch series.
- REACHABILITY IS THE PRIMARY GATE:
Fuzzing can only discover bugs in code that can actually execute in standard virtualized
environments (GCE or QEMU, utilizing software-emulated devices like USB gadgets, netdev, tun/tap).
If the modified code is structurally unreachable (see Section 2), it MUST NOT be fuzzed,
regardless of whether it adds assertions or complex logic.
- DO NOT BLINDLY TRUST "NO FUNCTIONAL CHANGE" (NFCI) OR "REFACTORING" CLAIMS:
Patch authors routinely label changes as "cleanups", "refactorings", or state
"No functional change intended". Do NOT take these claims at face value.
Code refactorings that rearrange logic, introduce helper functions, or alter state management
in core subsystems frequently introduce subtle semantic shifts or uncover latent kernel bugs.
If reachable executable code is modified or refactored, it MUST be fuzzed.
- NEW OR MODIFIED ASSERTIONS IN REACHABLE CODE MUST BE FUZZED:
When a patch introduces or modifies runtime checks or assertions (e.g., WARN_ON*, VM_WARN_ON*,
BUG_ON*, lockdep_assert*) in reachable code paths, it enforces new or stricter invariants.
Even if the author believes the invariant always holds, fuzzing is essential to verify whether
an unusual sequence of operations can violate it.
================================================================================
2. WHEN TO RETURN WorthFuzzing=false (NEGATIVE CRITERIA)
================================================================================
Return WorthFuzzing=false ONLY IF all modified code falls strictly into one or more of these categories:
- Non-kernel and non-executable changes:
* Modifications to Documentation/, comments, or spelling fixes.
* User-space directories, self-tests, samples, or scripts (e.g., tools/, samples/, scripts/, usr/)
that do not affect the compiled kernel image (vmlinux) or kernel modules.
* Purely decorative logging (e.g., message strings in pr_err, printk, dev_info) or tracepoints
that do not alter control flow or data structures.
* Build system or Kconfig changes that do not alter compiled C logic.
- Structurally unreachable hardware:
* Vendor-specific PCIe switches, SmartNICs, or GPU drivers (e.g., mlxsw, pds_core, qed,
ionic, amdgpu) requiring physical ASIC/PCIe cards not emulated in standard QEMU.
- Unreachable execution paths:
* Driver teardown callbacks (.remove, .shutdown, pci_unregister_driver) executed only during
physical PCI hot-unplug or manual sysfs driver unbinding.
* Code paths exclusive to architectures other than the target architecture.
================================================================================
3. WHEN TO RETURN WorthFuzzing=true (POSITIVE CRITERIA)
================================================================================
Return WorthFuzzing=true whenever the patch touches reachable executable code, including:
- Core Subsystems:
* Any logic modifications in memory management (mm/), synchronization/locking (kernel/locking/),
BPF, scheduler, core networking, VFS, or syscall handling.
- Refactorings and Code Cleanups:
* Any restructuring of reachable data structures, helper abstractions, or algorithm flows.
- Runtime Assertions and Defensive Checks:
* Any introduction or alteration of assertions (WARN_ON*, VM_WARN_ON*, BUG_ON*, etc.) in reachable paths.
- Reachable Drivers and Protocols:
* Drivers accessible via virtual buses (virtio, USB gadget, loopback, netlink, binder, sockets, etc.).
================================================================================
4. EXTRACTING FocusSymbols (PREVENTING DILUTION)
================================================================================
When WorthFuzzing=true, you must extract specific kernel functions into FocusSymbols to guide the fuzzer:
- AVOID UBIQUITOUS LIFECYCLE HOT-PATHS:
Do NOT list generic, ubiquitous functions called by almost every program in the corpus
(including, but not limited to: general memory allocators and deallocators, page fault
and trap handlers, or core synchronization primitives; this is not an exhaustive list).
Listing ubiquitous functions causes the fuzzer to classify thousands of unrelated tests as "focused",
which severely dilutes fuzzing effort away from the actual changes.
- TARGET SPECIFIC FEATURE LOGIC AND ENTRYPOINTS:
List functions that specifically implement the logic being added or altered, or direct API entrypoints
for the subsystem feature under review.
- HANDLING STATIC INLINE FUNCTIONS IN HEADERS (.h):
Compiler-inlined static functions (such as static inlines in mm/*.h or include/linux/*.h) lack
distinct symbol addresses in vmlinux and cannot be targeted directly by symbol coverage filters.
If the changes are primarily in static inline helpers, identify non-static, feature-specific caller
functions in .c files that exercise them (avoiding ubiquitous lifecycle wrappers).
================================================================================
5. IDENTIFYING EnableConfigs
================================================================================
Identify any specific CONFIG_ options required to properly compile and reach the modified code:
- Inspect Kconfig files and #ifdef guards; do not make assumptions.
- Check "depends on" lines in Kconfig to include any non-standard parent subsystem configs needed.
- Strip any 'CONFIG_' prefix (e.g., return "NET_IPV4" instead of "CONFIG_NET_IPV4").
Prefer calling several tools at the same time to save round-trips.
Use set-results tool to provide results of the analysis.
It must be called exactly once before the final reply.
Ignore results of this tool.
Prompt: Target architecture: amd64
For your convenience, here is the diff of the changes:
commit 979e1578a949da58f62b54f76015145630e35e8b
Author: syz-cluster <triage@syzkaller.com>
Date: Wed Sep 9 13:04:44 2026 +0000
syz-cluster: applied patch under review
diff --git a/tools/testing/selftests/net/openvswitch/config b/tools/testing/selftests/net/openvswitch/config
index a825e0b5c88e5..fa90475dc388d 100644
--- a/tools/testing/selftests/net/openvswitch/config
+++ b/tools/testing/selftests/net/openvswitch/config
@@ -7,6 +7,7 @@ CONFIG_NET_IPGRE=m
CONFIG_NET_IPGRE_DEMUX=m
CONFIG_NF_CONNTRACK=m
CONFIG_NF_CONNTRACK_OVS=y
+CONFIG_NF_CT_PROTO_SCTP=y
CONFIG_OPENVSWITCH=m
CONFIG_PSAMPLE=m
CONFIG_VETH=y
diff --git a/tools/testing/selftests/net/openvswitch/openvswitch.sh b/tools/testing/selftests/net/openvswitch/openvswitch.sh
index a31f7fb6882dc..138a705fc359e 100755
--- a/tools/testing/selftests/net/openvswitch/openvswitch.sh
+++ b/tools/testing/selftests/net/openvswitch/openvswitch.sh
@@ -34,6 +34,8 @@ tests="
trunc trunc: output truncation
icmpv6 icmpv6: ICMPv6 echo type match
sctp_connect_v4 sctp: SCTP flow key matching
+ sctp_connect_v6 sctp6: SCTP flow key matching over IPv6
+ sctp_nat_connect_v4 sctpnat4: SCTP NAT with port translation
psample psample: Sampling packets with psample"
info() {
@@ -700,6 +702,113 @@ test_sctp_connect_v4() {
return 0
}
+# sctp_connect_v6 test
+# - sctp(dst=4443) matches client-to-server INIT
+# - sctp(src=4443) matches server-to-client INIT-ACK
+# - icmpv6 NS/NA flows forward neighbour discovery
+# - remove flows and verify connection fails, reinstall and recover
+test_sctp_connect_v6() {
+ local t="test_sctp_connect_v6"
+ local v6="eth_type(0x86dd),ipv6(proto=132)"
+ local payload="SCTP6_DATA_OK"
+ local rxfile="${ovs_base}/${t}/sctp-rx.txt"
+
+ modprobe -q sctp 2>/dev/null || return "$ksft_skip"
+ socat -V 2>&1 | grep -q "define WITH_SCTP" || return "$ksft_skip"
+ [ -e /proc/sys/net/ipv6 ] || return "$ksft_skip"
+
+ sbx_add "$t" || return $?
+ ovs_add_dp "$t" sctp6 || return 1
+
+ info "create namespaces"
+ for ns in client server; do
+ ovs_add_netns_and_veths "$t" "sctp6" "$ns" \
+ "${ns:0:1}0" "${ns:0:1}1" || return 1
+ done
+
+ ip netns exec client ip addr add fd00::1/64 dev c1 nodad
+ ip netns exec client ip link set c1 up
+ ip netns exec server ip addr add fd00::2/64 dev s1 nodad
+ ip netns exec server ip link set s1 up
+
+ # NS/NA forwarding
+ ovs_add_flow "$t" sctp6 \
+ 'in_port(1),eth(),eth_type(0x86dd),ipv6(proto=58),icmpv6()' \
+ '2' || return 1
+ ovs_add_flow "$t" sctp6 \
+ 'in_port(2),eth(),eth_type(0x86dd),ipv6(proto=58),icmpv6()' \
+ '1' || return 1
+
+ # SCTP port matching: dst for request, src for reply
+ ovs_add_flow "$t" sctp6 \
+ "in_port(1),eth(),$v6,sctp(dst=4443)" \
+ '2' || return 1
+ ovs_add_flow "$t" sctp6 \
+ "in_port(2),eth(),$v6,sctp(src=4443)" \
+ '1' || return 1
+
+ # A keyless ipv6(proto=132) install must be refused (EINVAL):
+ # match_validate() requires the sctp() key. Pin the reject side
+ # of that rule; the keyed installs above cover the accept side.
+ # Verify the refusal is EINVAL (missing key), not a parse error.
+ err=$(ovs_sbx "$t" python3 $ovs_base/ovs-dpctl.py add-flow sctp6 \
+ "in_port(1),eth(),$v6" '2' 2>&1 >/dev/null) \
+ && { info "keyless SCTP flow should be refused"
+ return 1; }
+ echo "$err" | grep -q "(22," || {
+ info "keyless SCTP flow refused for wrong reason: $err"
+ return 1
+ }
+
+ ovs_netns_spawn_daemon "$t" "server" \
+ socat -u -t 1 SCTP6-LISTEN:4443,fork \
+ OPEN:"$rxfile",creat,append
+ ovs_wait sctp_eps_has server 4443 || return 1
+
+ info "verify SCTP association with port-keyed flows"
+ ovs_sbx "$t" ip netns exec client \
+ timeout 3 socat -u STDIN "SCTP6-CONNECT:[fd00::2]:4443" </dev/null \
+ || return 1
+
+ info "verify SCTP DATA chunk crosses the datapath"
+ ovs_sbx "$t" ip netns exec client \
+ timeout 3 socat -u STDIN "SCTP6-CONNECT:[fd00::2]:4443" \
+ <<< "$payload" || return 1
+ ovs_wait grep -q "$payload" "$rxfile" \
+ || { info "server did not receive SCTP DATA payload"
+ return 1; }
+
+ ovs_del_flows "$t" sctp6
+
+ info "verify connection fails without flows"
+ ovs_add_flow "$t" sctp6 \
+ 'in_port(1),eth(),eth_type(0x86dd),ipv6(proto=58),icmpv6()' \
+ '2' || return 1
+ ovs_add_flow "$t" sctp6 \
+ 'in_port(2),eth(),eth_type(0x86dd),ipv6(proto=58),icmpv6()' \
+ '1' || return 1
+
+ ovs_sbx "$t" ip netns exec client \
+ timeout 3 socat -u STDIN "SCTP6-CONNECT:[fd00::2]:4443" </dev/null \
+ >/dev/null 2>&1 \
+ && { info "connection should fail without flows"
+ return 1; }
+
+ info "reinstall flows and verify recovery"
+ ovs_add_flow "$t" sctp6 \
+ "in_port(1),eth(),$v6,sctp(dst=4443)" \
+ '2' || return 1
+ ovs_add_flow "$t" sctp6 \
+ "in_port(2),eth(),$v6,sctp(src=4443)" \
+ '1' || return 1
+
+ ovs_sbx "$t" ip netns exec client \
+ timeout 3 socat -u STDIN "SCTP6-CONNECT:[fd00::2]:4443" </dev/null \
+ || return 1
+
+ return 0
+}
+
# psample test
# - use psample to observe packets
test_psample() {
@@ -1091,6 +1200,98 @@ test_nat_connect_v4 () {
return 0
}
+# sctp_nat_connect_v4 test
+# - SCTP association crosses a ct(commit,nat(dst=ip:port)) DNAT
+# - post-recirc flows match the translated address and port, so the
+# SCTP branch of the post-NAT flow key update is load-bearing
+test_sctp_nat_connect_v4 () {
+ local t="test_sctp_nat_connect_v4"
+ local payload="SCTP_NAT_DATA_OK"
+ local rxfile="${ovs_base}/${t}/sctp-rx.txt"
+
+ modprobe -q sctp 2>/dev/null || return "$ksft_skip"
+ socat -V 2>&1 | grep -q "define WITH_SCTP" || return "$ksft_skip"
+ # SCTP conntrack is compiled into nf_conntrack.ko, so check that
+ # loading it actually exposed the SCTP conntrack sysctls.
+ modprobe -q nf_conntrack 2>/dev/null || return "$ksft_skip"
+ [ -e /proc/sys/net/netfilter/nf_conntrack_sctp_timeout_established ] \
+ || { info "no SCTP conntrack support - skipping"
+ return "$ksft_skip"; }
+
+ sbx_add "test_sctp_nat_connect_v4" || return $?
+
+ ovs_add_dp "test_sctp_nat_connect_v4" sctpnat4 || return 1
+ info "create namespaces"
+ for ns in client server; do
+ ovs_add_netns_and_veths "test_sctp_nat_connect_v4" "sctpnat4" \
+ "$ns" "${ns:0:1}0" "${ns:0:1}1" || return 1
+ done
+
+ ip netns exec client ip addr add 172.31.110.10/24 dev c1
+ ip netns exec client ip link set c1 up
+ ip netns exec server ip addr add 172.31.110.20/24 dev s1
+ ip netns exec server ip link set s1 up
+
+ ip netns exec client ip route add default via 172.31.110.20
+
+ # Check if the ct and nat actions can be configured.
+ ovs_add_flow "test_sctp_nat_connect_v4" sctpnat4 \
+ 'in_port(1),eth(),eth_type(0x0800),ipv4()' \
+ 'ct(commit,nat(dst=172.31.110.20:5555)),recirc(0x1)' \
+ &> /dev/null
+ if [ $? == 1 ]; then
+ info "no support for ct/nat actions - skipping"
+ ovs_exit_sig
+ return $ksft_skip
+ fi
+
+ ovs_del_flows "test_sctp_nat_connect_v4" sctpnat4
+
+ ovs_add_flow "test_sctp_nat_connect_v4" sctpnat4 \
+ 'in_port(1),eth(),eth_type(0x0806),arp()' '2' || return 1
+ ovs_add_flow "test_sctp_nat_connect_v4" sctpnat4 \
+ 'in_port(2),eth(),eth_type(0x0806),arp()' '1' || return 1
+ ovs_add_flow "test_sctp_nat_connect_v4" sctpnat4 \
+ "ct_state(-trk),in_port(1),eth(),eth_type(0x0800),"\
+"ipv4(dst=192.168.0.20)" \
+ "ct(commit,nat(dst=172.31.110.20:5555)),recirc(0x1)" || return 1
+ ovs_add_flow "test_sctp_nat_connect_v4" sctpnat4 \
+ "ct_state(-trk),in_port(2),eth(),eth_type(0x0800),ipv4()" \
+ "ct(commit,nat),recirc(0x2)" || return 1
+
+ ovs_add_flow "test_sctp_nat_connect_v4" sctpnat4 \
+ "recirc_id(0x1),ct_state(+trk-inv),in_port(1),eth(),"\
+"eth_type(0x0800),ipv4(dst=172.31.110.20,proto=132),"\
+"sctp(dst=5555)" \
+ "2" || return 1
+ ovs_add_flow "test_sctp_nat_connect_v4" sctpnat4 \
+ "recirc_id(0x2),ct_state(+trk-inv),in_port(2),eth(),"\
+"eth_type(0x0800),ipv4(src=192.168.0.20,proto=132),"\
+"sctp(src=4443)" \
+ "1" || return 1
+
+ ovs_netns_spawn_daemon "test_sctp_nat_connect_v4" "server" \
+ socat -u -t 1 SCTP4-LISTEN:5555,fork \
+ OPEN:"$rxfile",creat,append
+ ovs_wait sctp_eps_has server 5555 || return 1
+
+ info "verify SCTP association across NAT"
+ ovs_sbx "test_sctp_nat_connect_v4" ip netns exec client \
+ timeout 3 socat -u STDIN "SCTP4-CONNECT:192.168.0.20:4443" \
+ </dev/null || return 1
+
+ info "verify SCTP DATA chunk crosses NAT"
+ ovs_sbx "test_sctp_nat_connect_v4" ip netns exec client \
+ timeout 3 socat -u STDIN "SCTP4-CONNECT:192.168.0.20:4443" \
+ <<< "$payload" || return 1
+ ovs_wait grep -q "$payload" "$rxfile" \
+ || { info "server did not receive SCTP DATA payload"
+ return 1; }
+
+ info "done..."
+ return 0
+}
+
# nat_related_v4 test
# - client->server ip packets go via SNAT
# - client solicits ICMP destination unreachable packet from server
|
| 3/2 | 2026/09/09 13:04 | llm | patch-evaluator |
0mModel:gemini-3.7-flash Args: null Results: null Tokens: input: 6658 output: 73 thoughts: 635 Thoughts: **Analyzing the Patch for Fuzzing Eligibility** Okay, let's break this down. First, I need to understand the scope of this patch. It looks like we have a diff touching two files: `tools/testing/selftests/net/openvswitch/config` and `tools/testing/selftests/net/openvswitch/openvswitch.sh`. The file paths immediately point towards self-tests within a user-space environment, specifically related to Open vSwitch. I need to triage this based on whether it affects the kernel itself. I'm consulting the "WHEN TO RETURN WorthFuzzing=false" criteria. Specifically, the rules state that changes to user-space directories, like `tools/`, `samples/`, or `scripts/`, are not worth fuzzing if they *don't* affect the kernel image (vmlinux) or kernel modules. I've verified that the diff, as presented, only includes modifications within the `tools/testing/selftests/net/openvswitch/` directory. No other files are touched, and I can confirm this either through a quick `git log -1` check, or, in this case, by virtue of the provided prompt. Essentially, this means that this patch is entirely contained within user-space test code. It does not alter any core kernel components or their compiled images, based on the diff. So I'm confident in the assessment. Therefore, my conclusions are straightforward: `WorthFuzzing` should be `false`. The `FocusSymbols` and `EnableConfigs` lists will be empty (or null), as this change has no impact on relevant kernel symbols or configuration options. The reasoning is clear: the changes are confined to selftests scripts and config files in a user-space testing directory, thereby not affecting the kernel's compilation or modules. Time to call `set-results`. |
| 4/2 | 2026/09/09 13:04 | tool | set-results |
0mArgs:{
"EnableConfigs": [],
"FocusSymbols": [],
"Reasoning": "The patch only modifies user-space selftests (tools/testing/selftests/net/openvswitch/), which does not affect the compiled kernel image (vmlinux) or kernel modules.",
"WorthFuzzing": false
}Results: {
"EnableConfigs": null,
"FocusSymbols": [],
"Reasoning": "The patch only modifies user-space selftests (tools/testing/selftests/net/openvswitch/), which does not affect the compiled kernel image (vmlinux) or kernel modules.",
"WorthFuzzing": false
} |
| 5/1 | 2026/09/09 13:04 | action | If |
0mArgs:{
"WorthFuzzing": false
}Results: null |
| Total Calls | Total Tokens | Avg Tokens | Total Duration (Seconds) | Avg Duration (Seconds) |
|---|
| Total Calls | Total Duration (Seconds) | Avg Duration (Seconds) |
|---|