| Seq | Timestamp | Type | Name | Duration |
|---|---|---|---|---|
| 0/0 | 2026/10/13 18:44 | flow | patch-triage |
0mArgs:null Results: {
"EnableConfigs": null,
"FocusSymbols": [],
"KMSANReasoning": "",
"NeedsKMSAN": false,
"Reasoning": "The patch only modifies files under arch/s390/ and selftests under tools/testing/selftests/kvm/s390/, which are exclusive to the s390 architecture and userspace. They are not compiled or reachable on the target architecture (amd64).",
"WorthFuzzing": false
} |
| 1/1 | 2026/10/13 18:44 | action | read-patch-diff |
0mArgs:null Results: {
"PatchDiff": "commit 42eb5e74a25003645f8de927c6252a46a8bec05b\nAuthor: syz-cluster \u003ctriage@syzkaller.com\u003e\nDate: Tue Oct 13 18:44:47 2026 +0000\n\n syz-cluster: applied patch under review\n\ndiff --git a/arch/s390/kvm/gmap/dat.c b/arch/s390/kvm/gmap/dat.c\nindex ff80d02c9f564..1bc6d2ec5b083 100644\n--- a/arch/s390/kvm/gmap/dat.c\n+++ b/arch/s390/kvm/gmap/dat.c\n@@ -1084,6 +1084,7 @@ int dat_set_prefix_notif_bit(union asce asce, gfn_t gfn)\n * * %1 if the page state has been altered and the page is to be added to the CBRL\n * * %0 if the page state has been altered, but the page is not to be added to the CBRL\n * * %-1 if the page state has not been altered and the page is not to be added to the CBRL\n+ * * %-PGM_ADDRESSING if the guest page-table walk failed\n */\n int dat_perform_essa(union asce asce, gfn_t gfn, int orc, union essa_state *state, bool *dirty)\n {\n@@ -1092,7 +1093,9 @@ int dat_perform_essa(union asce asce, gfn_t gfn, int orc, union essa_state *stat\n \tunion pte *ptep;\n \tint res = 0;\n \n-\tif (dat_entry_walk(NULL, gfn, asce, 0, TABLE_TYPE_PAGE_TABLE, \u0026crstep, \u0026ptep)) {\n+\tif (dat_entry_walk(NULL, gfn, asce, DAT_WALK_ANY, TABLE_TYPE_PAGE_TABLE, \u0026crstep, \u0026ptep))\n+\t\treturn -PGM_ADDRESSING;\n+\tif (!ptep) {\n \t\t*state = (union essa_state) { .exception = 1 };\n \t\treturn -1;\n \t}\ndiff --git a/arch/s390/kvm/s390/priv.c b/arch/s390/kvm/s390/priv.c\nindex b3cb2c2c3aa71..2abd1bdfdf322 100644\n--- a/arch/s390/kvm/s390/priv.c\n+++ b/arch/s390/kvm/s390/priv.c\n@@ -1168,8 +1168,10 @@ static inline int __do_essa(struct kvm_vcpu *vcpu, const int orc)\n \tentries = (vcpu-\u003earch.sie_block-\u003ecbrlo \u0026 ~PAGE_MASK) \u003e\u003e 3;\n \n \tnappended = dat_perform_essa(vcpu-\u003earch.gmap-\u003easce, gfn, orc, \u0026state, \u0026dirtied);\n+\tif (nappended == -PGM_ADDRESSING)\n+\t\treturn kvm_s390_inject_program_int(vcpu, -PGM_ADDRESSING);\n \tvcpu-\u003erun-\u003es.regs.gprs[r1] = state.val;\n-\tif (nappended \u003c 0)\n+\tif (nappended == -1)\n \t\treturn 0;\n \t/*\n \t * It is possible that all the normal 511 slots were full, in which case\ndiff --git a/tools/testing/selftests/kvm/s390/cmma_test.c b/tools/testing/selftests/kvm/s390/cmma_test.c\nindex 15d81b2ed7ad3..2b351b4fc894f 100644\n--- a/tools/testing/selftests/kvm/s390/cmma_test.c\n+++ b/tools/testing/selftests/kvm/s390/cmma_test.c\n@@ -8,6 +8,7 @@\n * Nico Boehr \u003cnrb@linux.ibm.com\u003e\n */\n #include \u003cfcntl.h\u003e\n+#include \u003csignal.h\u003e\n #include \u003cstdio.h\u003e\n #include \u003cstdlib.h\u003e\n #include \u003cstring.h\u003e\n@@ -18,6 +19,12 @@\n #include \"kselftest.h\"\n #include \"ucall_common.h\"\n #include \"processor.h\"\n+#include \"sie.h\"\n+\n+#define PGM_ADDRESSING\t\t0x05\n+#define VCPU_RUN_TIMEOUT_S\t2\n+#define UNMAPPED_GFN\t\t0xffff000UL\n+#define __LC_PGM_NEW_PSW\t0x1d0\n \n #define MAIN_PAGE_COUNT 512\n \n@@ -651,6 +658,77 @@ static void test_get_skip_holes(void)\n \tassert_no_pages_cmma_dirty(vm);\n }\n \n+static void pgm_handler_c(void)\n+{\n+\tGUEST_SYNC(PGM_ADDRESSING);\n+\tfor (;;)\n+\t\t;\n+}\n+\n+static void guest_essa_unmapped(void)\n+{\n+\tunsigned long addr = UNMAPPED_GFN \u003c\u003c PAGE_SHIFT;\n+\n+\tasm volatile(\n+\t\t\"\tlg 2,%[addr]\\n\"\n+\t\t/* ESSA r1,r2,orc=1 */\n+\t\t\"\t.insn rrf,0xb9ab0000,1,2,1,0\\n\"\n+\t\t\"0:\tj 0b\\n\"\n+\t\t:\n+\t\t: [addr] \"Q\"(addr)\n+\t\t: \"r1\", \"r2\", \"cc\", \"memory\"\n+\t);\n+}\n+\n+static void handle_alarm(int sig __maybe_unused)\n+{\n+\tksft_test_result_fail(\n+\t\t\"ESSA migration mode: vcpu_run timed out - PGM_ADDRESSING was not injected\\n\");\n+\tksft_finished();\n+}\n+\n+static void test_essa_migration_pgm(void)\n+{\n+\tstruct kvm_vcpu *vcpu;\n+\tstruct kvm_vm *vm;\n+\tstruct ucall uc;\n+\tchar *lowcore;\n+\tu64 pgm_psw[2] = {};\n+\n+\tvm = __vm_create(VM_SHAPE_DEFAULT, 1, 0);\n+\n+\tenable_cmma(vm);\n+\n+\tvcpu = vm_vcpu_add(vm, 0, guest_essa_unmapped);\n+\n+\tlowcore = addr_gpa2hva(vm, 0);\n+\tpgm_psw[0] = vcpu-\u003erun-\u003epsw_mask;\n+\tpgm_psw[1] = (u64)pgm_handler_c;\n+\tmemcpy(lowcore + __LC_PGM_NEW_PSW, pgm_psw, 16);\n+\n+\t/* Migration mode requires dirty tracking on all memslots. */\n+\tvm_mem_region_set_flags(vm, 0, KVM_MEM_LOG_DIRTY_PAGES);\n+\tenable_migration_mode(vm);\n+\n+\tsignal(SIGALRM, handle_alarm);\n+\talarm(VCPU_RUN_TIMEOUT_S);\n+\n+\tvcpu_run(vcpu);\n+\n+\talarm(0);\n+\n+\tTEST_ASSERT_EQ(vcpu-\u003erun-\u003eexit_reason, KVM_EXIT_S390_SIEIC);\n+\tTEST_ASSERT_EQ(vcpu-\u003erun-\u003es390_sieic.icptcode, ICPT_INST);\n+\tTEST_ASSERT_EQ(vcpu-\u003erun-\u003es390_sieic.ipa \u0026 0xff00, 0x8300); /* DIAG */\n+\tTEST_ASSERT_EQ(vcpu-\u003erun-\u003es390_sieic.ipb \u003e\u003e 16, 0x501);\n+\n+\tget_ucall(vcpu, \u0026uc);\n+\tTEST_ASSERT_EQ(uc.cmd, UCALL_SYNC);\n+\tTEST_ASSERT_EQ(uc.args[1], PGM_ADDRESSING);\n+\n+\tkvm_vm_free(vm);\n+}\n+\n struct testdef {\n \tconst char *name;\n \tvoid (*test)(void);\n@@ -659,6 +737,7 @@ struct testdef {\n \t{ \"GET_CMMA_BITS: basic calls\", test_get_cmma_basic },\n \t{ \"GET_CMMA_BITS: all pages are dirty initially\", test_get_initial_dirty },\n \t{ \"GET_CMMA_BITS: holes are skipped\", test_get_skip_holes },\n+\t{ \"ESSA migration mode: PGM_ADDRESSING injected on unmapped GFN\", test_essa_migration_pgm },\n };\n \n /**\n"
} |
| 2/1 | 2026/10/13 18:44 | agent | patch-evaluator |
0mModel:core Args: null Results: {
"EnableConfigs": null,
"FocusSymbols": [],
"Reasoning": "The patch only modifies files under arch/s390/ and selftests under tools/testing/selftests/kvm/s390/, which are exclusive to the s390 architecture and userspace. They are not compiled or reachable on the target architecture (amd64).",
"WorthFuzzing": false
}Instruction: You are an expert Linux kernel maintainer and security engineer.
Your job is to review a provided patch series and evaluate whether it warrants fuzzing with syzkaller.
IMPORTANT: The changes have ALREADY been applied and committed as the HEAD commit in
your workspace. Do NOT rely on internal assumptions. You must actively use your code access
tools to inspect the actual source code, callers, and surrounding context.
================================================================================
1. CORE TRIAGE PHILOSOPHY
================================================================================
The goal of patch fuzzing is to discover crashes, regressions, exposed latent bugs,
and newly triggered assertions introduced by the patch series.
- REACHABILITY IS THE PRIMARY GATE:
Fuzzing can only discover bugs in code that can actually execute in standard virtualized
environments (GCE or QEMU, utilizing software-emulated devices like USB gadgets, netdev, tun/tap).
If the modified code is structurally unreachable (see Section 2), it MUST NOT be fuzzed,
regardless of whether it adds assertions or complex logic.
- DO NOT BLINDLY TRUST "NO FUNCTIONAL CHANGE" (NFCI) OR "REFACTORING" CLAIMS:
Patch authors routinely label changes as "cleanups", "refactorings", or state
"No functional change intended". Do NOT take these claims at face value.
Code refactorings that rearrange logic, introduce helper functions, or alter state management
in core subsystems frequently introduce subtle semantic shifts or uncover latent kernel bugs.
If reachable executable code is modified or refactored, it MUST be fuzzed.
- NEW OR MODIFIED ASSERTIONS IN REACHABLE CODE MUST BE FUZZED:
When a patch introduces or modifies runtime checks or assertions (e.g., WARN_ON*, VM_WARN_ON*,
BUG_ON*, lockdep_assert*) in reachable code paths, it enforces new or stricter invariants.
Even if the author believes the invariant always holds, fuzzing is essential to verify whether
an unusual sequence of operations can violate it.
================================================================================
2. WHEN TO RETURN WorthFuzzing=false (NEGATIVE CRITERIA)
================================================================================
Return WorthFuzzing=false ONLY IF all modified code falls strictly into one or more of these categories:
- Non-kernel and non-executable changes:
* Modifications to Documentation/, comments, or spelling fixes.
* User-space directories, self-tests, samples, or scripts (e.g., tools/, samples/, scripts/, usr/)
that do not affect the compiled kernel image (vmlinux) or kernel modules.
* Purely decorative logging (e.g., message strings in pr_err, printk, dev_info) or tracepoints
that do not alter control flow or data structures.
* Build system or Kconfig changes that do not alter compiled C logic.
- Structurally unreachable hardware:
* Vendor-specific PCIe switches, SmartNICs, or GPU drivers (e.g., mlxsw, pds_core, qed,
ionic, amdgpu) requiring physical ASIC/PCIe cards not emulated in standard QEMU.
- Unreachable execution paths:
* Driver teardown callbacks (.remove, .shutdown, pci_unregister_driver) executed only during
physical PCI hot-unplug or manual sysfs driver unbinding.
* Code paths exclusive to architectures other than the target architecture.
================================================================================
3. WHEN TO RETURN WorthFuzzing=true (POSITIVE CRITERIA)
================================================================================
Return WorthFuzzing=true whenever the patch touches reachable executable code, including:
- Core Subsystems:
* Any logic modifications in memory management (mm/), synchronization/locking (kernel/locking/),
BPF, scheduler, core networking, VFS, or syscall handling.
- Refactorings and Code Cleanups:
* Any restructuring of reachable data structures, helper abstractions, or algorithm flows.
- Runtime Assertions and Defensive Checks:
* Any introduction or alteration of assertions (WARN_ON*, VM_WARN_ON*, BUG_ON*, etc.) in reachable paths.
- Reachable Drivers and Protocols:
* Drivers accessible via virtual buses (virtio, USB gadget, loopback, netlink, binder, sockets, etc.).
================================================================================
4. EXTRACTING FocusSymbols (PREVENTING DILUTION)
================================================================================
When WorthFuzzing=true, you must extract specific kernel functions into FocusSymbols to guide the fuzzer:
- AVOID UBIQUITOUS LIFECYCLE HOT-PATHS:
Do NOT list generic, ubiquitous functions called by almost every program in the corpus
(including, but not limited to: general memory allocators and deallocators, page fault
and trap handlers, or core synchronization primitives; this is not an exhaustive list).
Listing ubiquitous functions causes the fuzzer to classify thousands of unrelated tests as "focused",
which severely dilutes fuzzing effort away from the actual changes.
- TARGET SPECIFIC FEATURE LOGIC AND ENTRYPOINTS:
List functions that specifically implement the logic being added or altered, or direct API entrypoints
for the subsystem feature under review.
- HANDLING STATIC INLINE FUNCTIONS IN HEADERS (.h):
Compiler-inlined static functions (such as static inlines in mm/*.h or include/linux/*.h) lack
distinct symbol addresses in vmlinux and cannot be targeted directly by symbol coverage filters.
If the changes are primarily in static inline helpers, identify non-static, feature-specific caller
functions in .c files that exercise them (avoiding ubiquitous lifecycle wrappers).
================================================================================
5. IDENTIFYING EnableConfigs
================================================================================
Identify any specific CONFIG_ options required to properly compile and reach the modified code:
- Inspect Kconfig files and #ifdef guards; do not make assumptions.
- Check "depends on" lines in Kconfig to include any non-standard parent subsystem configs needed.
- Strip any 'CONFIG_' prefix (e.g., return "NET_IPV4" instead of "CONFIG_NET_IPV4").
Prefer calling several tools at the same time to save round-trips.
Use set-results tool to provide results of the analysis.
It must be called exactly once before the final reply.
Ignore results of this tool.
Prompt: Target architecture: amd64
For your convenience, here is the diff of the changes:
commit 42eb5e74a25003645f8de927c6252a46a8bec05b
Author: syz-cluster <triage@syzkaller.com>
Date: Tue Oct 13 18:44:47 2026 +0000
syz-cluster: applied patch under review
diff --git a/arch/s390/kvm/gmap/dat.c b/arch/s390/kvm/gmap/dat.c
index ff80d02c9f564..1bc6d2ec5b083 100644
--- a/arch/s390/kvm/gmap/dat.c
+++ b/arch/s390/kvm/gmap/dat.c
@@ -1084,6 +1084,7 @@ int dat_set_prefix_notif_bit(union asce asce, gfn_t gfn)
* * %1 if the page state has been altered and the page is to be added to the CBRL
* * %0 if the page state has been altered, but the page is not to be added to the CBRL
* * %-1 if the page state has not been altered and the page is not to be added to the CBRL
+ * * %-PGM_ADDRESSING if the guest page-table walk failed
*/
int dat_perform_essa(union asce asce, gfn_t gfn, int orc, union essa_state *state, bool *dirty)
{
@@ -1092,7 +1093,9 @@ int dat_perform_essa(union asce asce, gfn_t gfn, int orc, union essa_state *stat
union pte *ptep;
int res = 0;
- if (dat_entry_walk(NULL, gfn, asce, 0, TABLE_TYPE_PAGE_TABLE, &crstep, &ptep)) {
+ if (dat_entry_walk(NULL, gfn, asce, DAT_WALK_ANY, TABLE_TYPE_PAGE_TABLE, &crstep, &ptep))
+ return -PGM_ADDRESSING;
+ if (!ptep) {
*state = (union essa_state) { .exception = 1 };
return -1;
}
diff --git a/arch/s390/kvm/s390/priv.c b/arch/s390/kvm/s390/priv.c
index b3cb2c2c3aa71..2abd1bdfdf322 100644
--- a/arch/s390/kvm/s390/priv.c
+++ b/arch/s390/kvm/s390/priv.c
@@ -1168,8 +1168,10 @@ static inline int __do_essa(struct kvm_vcpu *vcpu, const int orc)
entries = (vcpu->arch.sie_block->cbrlo & ~PAGE_MASK) >> 3;
nappended = dat_perform_essa(vcpu->arch.gmap->asce, gfn, orc, &state, &dirtied);
+ if (nappended == -PGM_ADDRESSING)
+ return kvm_s390_inject_program_int(vcpu, -PGM_ADDRESSING);
vcpu->run->s.regs.gprs[r1] = state.val;
- if (nappended < 0)
+ if (nappended == -1)
return 0;
/*
* It is possible that all the normal 511 slots were full, in which case
diff --git a/tools/testing/selftests/kvm/s390/cmma_test.c b/tools/testing/selftests/kvm/s390/cmma_test.c
index 15d81b2ed7ad3..2b351b4fc894f 100644
--- a/tools/testing/selftests/kvm/s390/cmma_test.c
+++ b/tools/testing/selftests/kvm/s390/cmma_test.c
@@ -8,6 +8,7 @@
* Nico Boehr <nrb@linux.ibm.com>
*/
#include <fcntl.h>
+#include <signal.h>
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
@@ -18,6 +19,12 @@
#include "kselftest.h"
#include "ucall_common.h"
#include "processor.h"
+#include "sie.h"
+
+#define PGM_ADDRESSING 0x05
+#define VCPU_RUN_TIMEOUT_S 2
+#define UNMAPPED_GFN 0xffff000UL
+#define __LC_PGM_NEW_PSW 0x1d0
#define MAIN_PAGE_COUNT 512
@@ -651,6 +658,77 @@ static void test_get_skip_holes(void)
assert_no_pages_cmma_dirty(vm);
}
+static void pgm_handler_c(void)
+{
+ GUEST_SYNC(PGM_ADDRESSING);
+ for (;;)
+ ;
+}
+
+static void guest_essa_unmapped(void)
+{
+ unsigned long addr = UNMAPPED_GFN << PAGE_SHIFT;
+
+ asm volatile(
+ " lg 2,%[addr]\n"
+ /* ESSA r1,r2,orc=1 */
+ " .insn rrf,0xb9ab0000,1,2,1,0\n"
+ "0: j 0b\n"
+ :
+ : [addr] "Q"(addr)
+ : "r1", "r2", "cc", "memory"
+ );
+}
+
+static void handle_alarm(int sig __maybe_unused)
+{
+ ksft_test_result_fail(
+ "ESSA migration mode: vcpu_run timed out - PGM_ADDRESSING was not injected\n");
+ ksft_finished();
+}
+
+static void test_essa_migration_pgm(void)
+{
+ struct kvm_vcpu *vcpu;
+ struct kvm_vm *vm;
+ struct ucall uc;
+ char *lowcore;
+ u64 pgm_psw[2] = {};
+
+ vm = __vm_create(VM_SHAPE_DEFAULT, 1, 0);
+
+ enable_cmma(vm);
+
+ vcpu = vm_vcpu_add(vm, 0, guest_essa_unmapped);
+
+ lowcore = addr_gpa2hva(vm, 0);
+ pgm_psw[0] = vcpu->run->psw_mask;
+ pgm_psw[1] = (u64)pgm_handler_c;
+ memcpy(lowcore + __LC_PGM_NEW_PSW, pgm_psw, 16);
+
+ /* Migration mode requires dirty tracking on all memslots. */
+ vm_mem_region_set_flags(vm, 0, KVM_MEM_LOG_DIRTY_PAGES);
+ enable_migration_mode(vm);
+
+ signal(SIGALRM, handle_alarm);
+ alarm(VCPU_RUN_TIMEOUT_S);
+
+ vcpu_run(vcpu);
+
+ alarm(0);
+
+ TEST_ASSERT_EQ(vcpu->run->exit_reason, KVM_EXIT_S390_SIEIC);
+ TEST_ASSERT_EQ(vcpu->run->s390_sieic.icptcode, ICPT_INST);
+ TEST_ASSERT_EQ(vcpu->run->s390_sieic.ipa & 0xff00, 0x8300); /* DIAG */
+ TEST_ASSERT_EQ(vcpu->run->s390_sieic.ipb >> 16, 0x501);
+
+ get_ucall(vcpu, &uc);
+ TEST_ASSERT_EQ(uc.cmd, UCALL_SYNC);
+ TEST_ASSERT_EQ(uc.args[1], PGM_ADDRESSING);
+
+ kvm_vm_free(vm);
+}
+
struct testdef {
const char *name;
void (*test)(void);
@@ -659,6 +737,7 @@ struct testdef {
{ "GET_CMMA_BITS: basic calls", test_get_cmma_basic },
{ "GET_CMMA_BITS: all pages are dirty initially", test_get_initial_dirty },
{ "GET_CMMA_BITS: holes are skipped", test_get_skip_holes },
+ { "ESSA migration mode: PGM_ADDRESSING injected on unmapped GFN", test_essa_migration_pgm },
};
/**
|
| 3/2 | 2026/10/13 18:44 | llm | patch-evaluator |
0mModel:gemini-3.8-flash Args: null Results: null Tokens: input: 5006 output: 94 thoughts: 931 Thoughts: **Patch Analysis: WorthFuzzing Evaluation** Alright, let's break this down. First thing's first: the target architecture is amd64. Then I see the files touched: `arch/s390/kvm/gmap/dat.c`, `arch/s390/kvm/s390/priv.c`, and `tools/testing/selftests/kvm/s390/cmma_test.c`. Immediately, my spidey-sense tingles – s390 code on an amd64 target? Let's see what the instructions say. Section 2 is key here. It clearly lays out *negative* criteria, conditions under which we *don't* fuzz. I'm focusing on "Code paths exclusive to architectures other than the target architecture". Bingo! All the kernel code touched is specific to `arch/s390/`, right? And the last file is user-space selftests. Now, I'm doing a mental cross-check – is there *any* chance this s390 code could somehow bleed over and affect amd64 or any generic kernel code? No, absolutely not. The `arch/s390/` directory is not even compiled on amd64. It is strictly architecture-specific. The `tools/testing/selftests/` are user-space self-tests and are also irrelevant for fuzzing the kernel image itself. Okay, let's be thorough. The other negative criteria, non-kernel modifications, are also met: the selftests. So, I'm confident. The reasoning is clear: the patch modifies code exclusively in `arch/s390/` and userspace selftests (`tools/testing/selftests/kvm/s390/`), which are not compiled or executable on the target architecture (amd64). Therefore, `WorthFuzzing` is `false`. There are no specific symbols or configurations to track. I'm ready to call `set-results`. |
| 4/2 | 2026/10/13 18:45 | tool | set-results |
0mArgs:{
"EnableConfigs": [],
"FocusSymbols": [],
"Reasoning": "The patch only modifies files under arch/s390/ and selftests under tools/testing/selftests/kvm/s390/, which are exclusive to the s390 architecture and userspace. They are not compiled or reachable on the target architecture (amd64).",
"WorthFuzzing": false
}Results: {
"EnableConfigs": null,
"FocusSymbols": [],
"Reasoning": "The patch only modifies files under arch/s390/ and selftests under tools/testing/selftests/kvm/s390/, which are exclusive to the s390 architecture and userspace. They are not compiled or reachable on the target architecture (amd64).",
"WorthFuzzing": false
} |
| 5/1 | 2026/10/13 18:45 | action | If |
0mArgs:{
"WorthFuzzing": false
}Results: null |
| Total Calls | Total Tokens | Avg Tokens | Total Duration (Seconds) | Avg Duration (Seconds) |
|---|
| Total Calls | Total Duration (Seconds) | Avg Duration (Seconds) |
|---|