| Seq | Timestamp | Type | Name | Duration |
|---|---|---|---|---|
| 0/0 | 2026/07/10 02:07 | flow | patch-triage |
0mArgs:null Results: {
"EnableConfigs": [
"MACVLAN"
],
"FocusSymbols": [
"macvlan_common_newlink",
"macvlan_changelink",
"macvlan_uninit",
"macvlan_port_destroy",
"macvlan_fdb_add",
"macvlan_fdb_del",
"macvlan_port_release_mac"
],
"Reasoning": "The patch modifies the logic for creating and managing MACVLAN devices, specifically allowing combinations of PASSTHRU and SOURCE modes on the same port. This introduces new state transitions and initialization/teardown logic that should be fuzzed via rtnetlink.",
"WorthFuzzing": true
} |
| 1/1 | 2026/07/10 02:07 | action | read-patch-diff |
0mArgs:null Results: {
"PatchDiff": "commit d42fee848482d4556659cebdf027c52d0506db84\nAuthor: syz-cluster \u003ctriage@syzkaller.com\u003e\nDate: Fri Jul 10 02:07:13 2026 +0000\n\n syz-cluster: applied patch under review\n\ndiff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c\nindex 9a4bc99dbf53b5..2505f5f2e9d30c 100644\n--- a/drivers/net/macvlan.c\n+++ b/drivers/net/macvlan.c\n@@ -83,6 +83,11 @@ static inline void macvlan_set_passthru(struct macvlan_port *port)\n \tport-\u003eflags |= MACVLAN_F_PASSTHRU;\n }\n \n+static inline void macvlan_clear_passthru(struct macvlan_port *port)\n+{\n+\tport-\u003eflags \u0026= ~MACVLAN_F_PASSTHRU;\n+}\n+\n static inline bool macvlan_addr_change(const struct macvlan_port *port)\n {\n \treturn port-\u003eflags \u0026 MACVLAN_F_ADDRCHANGE;\n@@ -637,7 +642,7 @@ static int macvlan_open(struct net_device *dev)\n \tstruct net_device *lowerdev = vlan-\u003elowerdev;\n \tint err;\n \n-\tif (macvlan_passthru(vlan-\u003eport)) {\n+\tif (vlan-\u003emode == MACVLAN_MODE_PASSTHRU) {\n \t\tif (!(vlan-\u003eflags \u0026 MACVLAN_FLAG_NOPROMISC)) {\n \t\t\terr = dev_set_promiscuity(lowerdev, 1);\n \t\t\tif (err \u003c 0)\n@@ -712,7 +717,7 @@ static int macvlan_stop(struct net_device *dev)\n \tdev_uc_unsync(lowerdev, dev);\n \tdev_mc_unsync(lowerdev, dev);\n \n-\tif (macvlan_passthru(vlan-\u003eport)) {\n+\tif (vlan-\u003emode == MACVLAN_MODE_PASSTHRU) {\n \t\tif (!(vlan-\u003eflags \u0026 MACVLAN_FLAG_NOPROMISC))\n \t\t\tdev_set_promiscuity(lowerdev, -1);\n \t\tgoto hash_del;\n@@ -792,6 +797,23 @@ static int macvlan_set_mac_address(struct net_device *dev, void *p)\n \treturn macvlan_sync_address(dev, addr-\u003e__data);\n }\n \n+static void macvlan_port_release_mac(struct net_device *dev)\n+{\n+\tstruct macvlan_port *port = macvlan_port_get_rtnl(dev);\n+\n+\t/* If the lower device address has been changed by passthru\n+\t * macvlan, put it back.\n+\t */\n+\tif (macvlan_passthru(port) \u0026\u0026\n+\t !ether_addr_equal(port-\u003edev-\u003edev_addr, port-\u003eperm_addr)) {\n+\t\tstruct sockaddr_storage ss;\n+\n+\t\tss.ss_family = port-\u003edev-\u003etype;\n+\t\tmemcpy(\u0026ss.__data, port-\u003eperm_addr, port-\u003edev-\u003eaddr_len);\n+\t\tdev_set_mac_address(port-\u003edev, \u0026ss, NULL);\n+\t}\n+}\n+\n static void macvlan_change_rx_flags(struct net_device *dev, int change)\n {\n \tstruct macvlan_dev *vlan = netdev_priv(dev);\n@@ -977,8 +999,18 @@ static void macvlan_uninit(struct net_device *dev)\n \n \tmacvlan_flush_sources(port, vlan);\n \tport-\u003ecount -= 1;\n-\tif (!port-\u003ecount)\n-\t\tmacvlan_port_destroy(port-\u003edev);\n+\tif (port-\u003ecount) {\n+\t\t/* In case of remaining source interfaces undo\n+\t\t * passthru-specific properties.\n+\t\t */\n+\t\tif (vlan-\u003emode == MACVLAN_MODE_PASSTHRU) {\n+\t\t\tmacvlan_port_release_mac(dev);\n+\t\t\tmacvlan_clear_passthru(vlan-\u003eport);\n+\t\t}\n+\t\treturn;\n+\t}\n+\n+\tmacvlan_port_destroy(port-\u003edev);\n }\n \n static void macvlan_dev_get_stats64(struct net_device *dev,\n@@ -1052,7 +1084,7 @@ static int macvlan_fdb_add(struct ndmsg *ndm, struct nlattr *tb[],\n \t/* Support unicast filter only on passthru devices.\n \t * Multicast filter should be allowed on all devices.\n \t */\n-\tif (!macvlan_passthru(vlan-\u003eport) \u0026\u0026 is_unicast_ether_addr(addr))\n+\tif (vlan-\u003emode != MACVLAN_MODE_PASSTHRU \u0026\u0026 is_unicast_ether_addr(addr))\n \t\treturn -EOPNOTSUPP;\n \n \tif (flags \u0026 NLM_F_REPLACE)\n@@ -1077,7 +1109,7 @@ static int macvlan_fdb_del(struct ndmsg *ndm, struct nlattr *tb[],\n \t/* Support unicast filter only on passthru devices.\n \t * Multicast filter should be allowed on all devices.\n \t */\n-\tif (!macvlan_passthru(vlan-\u003eport) \u0026\u0026 is_unicast_ether_addr(addr))\n+\tif (vlan-\u003emode != MACVLAN_MODE_PASSTHRU \u0026\u0026 is_unicast_ether_addr(addr))\n \t\treturn -EOPNOTSUPP;\n \n \tif (is_unicast_ether_addr(addr))\n@@ -1308,17 +1340,7 @@ static void macvlan_port_destroy(struct net_device *dev)\n \t\tkfree_skb(skb);\n \t}\n \n-\t/* If the lower device address has been changed by passthru\n-\t * macvlan, put it back.\n-\t */\n-\tif (macvlan_passthru(port) \u0026\u0026\n-\t !ether_addr_equal(port-\u003edev-\u003edev_addr, port-\u003eperm_addr)) {\n-\t\tstruct sockaddr_storage ss;\n-\n-\t\tss.ss_family = port-\u003edev-\u003etype;\n-\t\tmemcpy(\u0026ss.__data, port-\u003eperm_addr, port-\u003edev-\u003eaddr_len);\n-\t\tdev_set_mac_address(port-\u003edev, \u0026ss, NULL);\n-\t}\n+\tmacvlan_port_release_mac(dev);\n \n \tkfree(port);\n }\n@@ -1506,15 +1528,6 @@ int macvlan_common_newlink(struct net_device *dev,\n \t}\n \tport = macvlan_port_get_rtnl(lowerdev);\n \n-\t/* Only 1 macvlan device can be created in passthru mode */\n-\tif (macvlan_passthru(port)) {\n-\t\t/* The macvlan port must be not created this time,\n-\t\t * still goto destroy_macvlan_port for readability.\n-\t\t */\n-\t\terr = -EINVAL;\n-\t\tgoto destroy_macvlan_port;\n-\t}\n-\n \tvlan-\u003elowerdev = lowerdev;\n \tvlan-\u003edev = dev;\n \tvlan-\u003eport = port;\n@@ -1527,10 +1540,30 @@ int macvlan_common_newlink(struct net_device *dev,\n \tif (data \u0026\u0026 data[IFLA_MACVLAN_FLAGS])\n \t\tvlan-\u003eflags = nla_get_u16(data[IFLA_MACVLAN_FLAGS]);\n \n+\t/* Only 1 macvlan device can be created in passthru mode. There may be\n+\t * additional source mode devices but nothing else at the moment.\n+\t *\n+\t * First check if adding a source mode device to an existing passthru vlan.\n+\t */\n+\tif (macvlan_passthru(port) \u0026\u0026 vlan-\u003emode != MACVLAN_MODE_SOURCE) {\n+\t\t/* The macvlan port must be not created this time,\n+\t\t * still goto destroy_macvlan_port for readability.\n+\t\t */\n+\t\terr = -EINVAL;\n+\t\tgoto destroy_macvlan_port;\n+\t}\n+\n+\t/* Now check if adding a passthru device to an existing set of source mode\n+\t * devices.\n+\t */\n \tif (vlan-\u003emode == MACVLAN_MODE_PASSTHRU) {\n-\t\tif (port-\u003ecount) {\n-\t\t\terr = -EINVAL;\n-\t\t\tgoto destroy_macvlan_port;\n+\t\tstruct macvlan_dev *p;\n+\n+\t\tlist_for_each_entry(p, \u0026port-\u003evlans, list) {\n+\t\t\tif (p-\u003emode != MACVLAN_MODE_SOURCE) {\n+\t\t\t\terr = -EINVAL;\n+\t\t\t\tgoto destroy_macvlan_port;\n+\t\t\t}\n \t\t}\n \t\tmacvlan_set_passthru(port);\n \t\teth_hw_addr_inherit(dev, lowerdev);\n@@ -1564,7 +1597,11 @@ int macvlan_common_newlink(struct net_device *dev,\n \tif (err)\n \t\tgoto unregister_netdev;\n \n-\tlist_add_tail_rcu(\u0026vlan-\u003elist, \u0026port-\u003evlans);\n+\t/* macvlan_handle_frame expects the (one and only) passthru device first. */\n+\tif (vlan-\u003emode == MACVLAN_MODE_PASSTHRU)\n+\t\tlist_add_rcu(\u0026vlan-\u003elist, \u0026port-\u003evlans);\n+\telse\n+\t\tlist_add_tail_rcu(\u0026vlan-\u003elist, \u0026port-\u003evlans);\n \tupdate_port_bc_queue_len(vlan-\u003eport);\n \tnetif_stacked_transfer_operstate(lowerdev, dev);\n \tlinkwatch_fire_event(dev);\n@@ -1627,9 +1664,11 @@ static int macvlan_changelink(struct net_device *dev,\n \tif (data \u0026\u0026 data[IFLA_MACVLAN_MODE]) {\n \t\tset_mode = true;\n \t\tmode = nla_get_u32(data[IFLA_MACVLAN_MODE]);\n-\t\t/* Passthrough mode can't be set or cleared dynamically */\n-\t\tif ((mode == MACVLAN_MODE_PASSTHRU) !=\n-\t\t (vlan-\u003emode == MACVLAN_MODE_PASSTHRU))\n+\t\t/* Passthrough mode can't be set or cleared dynamically,\n+\t\t * regardless of existing source interfaces. Furthermore, source\n+\t\t * interfaces can't switch modes within a passhtrough port.\n+\t\t */\n+\t\tif (macvlan_passthru(vlan-\u003eport) \u0026\u0026 mode != vlan-\u003emode)\n \t\t\treturn -EINVAL;\n \t\tif (vlan-\u003emode == MACVLAN_MODE_SOURCE \u0026\u0026\n \t\t vlan-\u003emode != mode)\n@@ -1639,7 +1678,7 @@ static int macvlan_changelink(struct net_device *dev,\n \tif (data \u0026\u0026 data[IFLA_MACVLAN_FLAGS]) {\n \t\t__u16 flags = nla_get_u16(data[IFLA_MACVLAN_FLAGS]);\n \t\tbool promisc = (flags ^ vlan-\u003eflags) \u0026 MACVLAN_FLAG_NOPROMISC;\n-\t\tif (macvlan_passthru(vlan-\u003eport) \u0026\u0026 promisc) {\n+\t\tif (vlan-\u003emode == MACVLAN_MODE_PASSTHRU \u0026\u0026 promisc) {\n \t\t\tint err;\n \n \t\t\tif (flags \u0026 MACVLAN_FLAG_NOPROMISC)\n"
} |
| 2/1 | 2026/07/10 02:07 | agent | patch-evaluator |
0mModel:gemini-3.1-pro-preview Args: null Results: {
"EnableConfigs": [
"MACVLAN"
],
"FocusSymbols": [
"macvlan_common_newlink",
"macvlan_changelink",
"macvlan_uninit",
"macvlan_port_destroy",
"macvlan_fdb_add",
"macvlan_fdb_del",
"macvlan_port_release_mac"
],
"Reasoning": "The patch modifies the logic for creating and managing MACVLAN devices, specifically allowing combinations of PASSTHRU and SOURCE modes on the same port. This introduces new state transitions and initialization/teardown logic that should be fuzzed via rtnetlink.",
"WorthFuzzing": true
}Instruction: You are an expert Linux kernel maintainer. Your job is to review a provided patch series and determine if it makes functional changes to the kernel that should be fuzzed. IMPORTANT: The changes have ALREADY been applied and committed as the HEAD commit in your workspace. Do NOT rely on your internal knowledge of the kernel. You must actively use your code access tools to examine the actual source code and confirm any assumptions. Return WorthFuzzing=false if the patch only contains: - Modifications to Documentation/, Kconfig files, or code comments. - Purely decorative changes, such as logging (e.g., pr_err, printk) or tracepoints. - Changes to numeric constants or macros that do not functionally alter execution flow. - Code paths that are impossible to reach in virtualized environments like GCE or QEMU, even when utilizing software-emulated hardware (e.g., usb gadget, mac80211_hwsim). If it modifies reachable core kernel logic, drivers, or architectures, use your code search tools to verify the code can be executed, then return WorthFuzzing=true. When returning WorthFuzzing=true, you MUST ALSO: 1. Extract any specific kernel functions that should be heavily fuzzed into FocusSymbols. Avoid listing generic hot-path functions to prevent skewed test distributions. 2. Identify any specific CONFIG_ options required to properly test this new/modified feature. Go and look into the Kconfig files and check for ifdefs around the code, do not make assumptions. Do not list too generic configs (we already have them enabled). Only list those that specifically cover the modified code. List them in the EnableConfigs output array, and DO NOT add a 'CONFIG_' prefix (e.g., return "NET_IPV4" instead of "CONFIG_NET_IPV4"). Prefer calling several tools at the same time to save round-trips. Use set-results tool to provide results of the analysis. It must be called exactly once before the final reply. Ignore results of this tool. Prompt: For your convenience, here is the diff of the changes:
commit d42fee848482d4556659cebdf027c52d0506db84
Author: syz-cluster <triage@syzkaller.com>
Date: Fri Jul 10 02:07:13 2026 +0000
syz-cluster: applied patch under review
diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c
index 9a4bc99dbf53b5..2505f5f2e9d30c 100644
--- a/drivers/net/macvlan.c
+++ b/drivers/net/macvlan.c
@@ -83,6 +83,11 @@ static inline void macvlan_set_passthru(struct macvlan_port *port)
port->flags |= MACVLAN_F_PASSTHRU;
}
+static inline void macvlan_clear_passthru(struct macvlan_port *port)
+{
+ port->flags &= ~MACVLAN_F_PASSTHRU;
+}
+
static inline bool macvlan_addr_change(const struct macvlan_port *port)
{
return port->flags & MACVLAN_F_ADDRCHANGE;
@@ -637,7 +642,7 @@ static int macvlan_open(struct net_device *dev)
struct net_device *lowerdev = vlan->lowerdev;
int err;
- if (macvlan_passthru(vlan->port)) {
+ if (vlan->mode == MACVLAN_MODE_PASSTHRU) {
if (!(vlan->flags & MACVLAN_FLAG_NOPROMISC)) {
err = dev_set_promiscuity(lowerdev, 1);
if (err < 0)
@@ -712,7 +717,7 @@ static int macvlan_stop(struct net_device *dev)
dev_uc_unsync(lowerdev, dev);
dev_mc_unsync(lowerdev, dev);
- if (macvlan_passthru(vlan->port)) {
+ if (vlan->mode == MACVLAN_MODE_PASSTHRU) {
if (!(vlan->flags & MACVLAN_FLAG_NOPROMISC))
dev_set_promiscuity(lowerdev, -1);
goto hash_del;
@@ -792,6 +797,23 @@ static int macvlan_set_mac_address(struct net_device *dev, void *p)
return macvlan_sync_address(dev, addr->__data);
}
+static void macvlan_port_release_mac(struct net_device *dev)
+{
+ struct macvlan_port *port = macvlan_port_get_rtnl(dev);
+
+ /* If the lower device address has been changed by passthru
+ * macvlan, put it back.
+ */
+ if (macvlan_passthru(port) &&
+ !ether_addr_equal(port->dev->dev_addr, port->perm_addr)) {
+ struct sockaddr_storage ss;
+
+ ss.ss_family = port->dev->type;
+ memcpy(&ss.__data, port->perm_addr, port->dev->addr_len);
+ dev_set_mac_address(port->dev, &ss, NULL);
+ }
+}
+
static void macvlan_change_rx_flags(struct net_device *dev, int change)
{
struct macvlan_dev *vlan = netdev_priv(dev);
@@ -977,8 +999,18 @@ static void macvlan_uninit(struct net_device *dev)
macvlan_flush_sources(port, vlan);
port->count -= 1;
- if (!port->count)
- macvlan_port_destroy(port->dev);
+ if (port->count) {
+ /* In case of remaining source interfaces undo
+ * passthru-specific properties.
+ */
+ if (vlan->mode == MACVLAN_MODE_PASSTHRU) {
+ macvlan_port_release_mac(dev);
+ macvlan_clear_passthru(vlan->port);
+ }
+ return;
+ }
+
+ macvlan_port_destroy(port->dev);
}
static void macvlan_dev_get_stats64(struct net_device *dev,
@@ -1052,7 +1084,7 @@ static int macvlan_fdb_add(struct ndmsg *ndm, struct nlattr *tb[],
/* Support unicast filter only on passthru devices.
* Multicast filter should be allowed on all devices.
*/
- if (!macvlan_passthru(vlan->port) && is_unicast_ether_addr(addr))
+ if (vlan->mode != MACVLAN_MODE_PASSTHRU && is_unicast_ether_addr(addr))
return -EOPNOTSUPP;
if (flags & NLM_F_REPLACE)
@@ -1077,7 +1109,7 @@ static int macvlan_fdb_del(struct ndmsg *ndm, struct nlattr *tb[],
/* Support unicast filter only on passthru devices.
* Multicast filter should be allowed on all devices.
*/
- if (!macvlan_passthru(vlan->port) && is_unicast_ether_addr(addr))
+ if (vlan->mode != MACVLAN_MODE_PASSTHRU && is_unicast_ether_addr(addr))
return -EOPNOTSUPP;
if (is_unicast_ether_addr(addr))
@@ -1308,17 +1340,7 @@ static void macvlan_port_destroy(struct net_device *dev)
kfree_skb(skb);
}
- /* If the lower device address has been changed by passthru
- * macvlan, put it back.
- */
- if (macvlan_passthru(port) &&
- !ether_addr_equal(port->dev->dev_addr, port->perm_addr)) {
- struct sockaddr_storage ss;
-
- ss.ss_family = port->dev->type;
- memcpy(&ss.__data, port->perm_addr, port->dev->addr_len);
- dev_set_mac_address(port->dev, &ss, NULL);
- }
+ macvlan_port_release_mac(dev);
kfree(port);
}
@@ -1506,15 +1528,6 @@ int macvlan_common_newlink(struct net_device *dev,
}
port = macvlan_port_get_rtnl(lowerdev);
- /* Only 1 macvlan device can be created in passthru mode */
- if (macvlan_passthru(port)) {
- /* The macvlan port must be not created this time,
- * still goto destroy_macvlan_port for readability.
- */
- err = -EINVAL;
- goto destroy_macvlan_port;
- }
-
vlan->lowerdev = lowerdev;
vlan->dev = dev;
vlan->port = port;
@@ -1527,10 +1540,30 @@ int macvlan_common_newlink(struct net_device *dev,
if (data && data[IFLA_MACVLAN_FLAGS])
vlan->flags = nla_get_u16(data[IFLA_MACVLAN_FLAGS]);
+ /* Only 1 macvlan device can be created in passthru mode. There may be
+ * additional source mode devices but nothing else at the moment.
+ *
+ * First check if adding a source mode device to an existing passthru vlan.
+ */
+ if (macvlan_passthru(port) && vlan->mode != MACVLAN_MODE_SOURCE) {
+ /* The macvlan port must be not created this time,
+ * still goto destroy_macvlan_port for readability.
+ */
+ err = -EINVAL;
+ goto destroy_macvlan_port;
+ }
+
+ /* Now check if adding a passthru device to an existing set of source mode
+ * devices.
+ */
if (vlan->mode == MACVLAN_MODE_PASSTHRU) {
- if (port->count) {
- err = -EINVAL;
- goto destroy_macvlan_port;
+ struct macvlan_dev *p;
+
+ list_for_each_entry(p, &port->vlans, list) {
+ if (p->mode != MACVLAN_MODE_SOURCE) {
+ err = -EINVAL;
+ goto destroy_macvlan_port;
+ }
}
macvlan_set_passthru(port);
eth_hw_addr_inherit(dev, lowerdev);
@@ -1564,7 +1597,11 @@ int macvlan_common_newlink(struct net_device *dev,
if (err)
goto unregister_netdev;
- list_add_tail_rcu(&vlan->list, &port->vlans);
+ /* macvlan_handle_frame expects the (one and only) passthru device first. */
+ if (vlan->mode == MACVLAN_MODE_PASSTHRU)
+ list_add_rcu(&vlan->list, &port->vlans);
+ else
+ list_add_tail_rcu(&vlan->list, &port->vlans);
update_port_bc_queue_len(vlan->port);
netif_stacked_transfer_operstate(lowerdev, dev);
linkwatch_fire_event(dev);
@@ -1627,9 +1664,11 @@ static int macvlan_changelink(struct net_device *dev,
if (data && data[IFLA_MACVLAN_MODE]) {
set_mode = true;
mode = nla_get_u32(data[IFLA_MACVLAN_MODE]);
- /* Passthrough mode can't be set or cleared dynamically */
- if ((mode == MACVLAN_MODE_PASSTHRU) !=
- (vlan->mode == MACVLAN_MODE_PASSTHRU))
+ /* Passthrough mode can't be set or cleared dynamically,
+ * regardless of existing source interfaces. Furthermore, source
+ * interfaces can't switch modes within a passhtrough port.
+ */
+ if (macvlan_passthru(vlan->port) && mode != vlan->mode)
return -EINVAL;
if (vlan->mode == MACVLAN_MODE_SOURCE &&
vlan->mode != mode)
@@ -1639,7 +1678,7 @@ static int macvlan_changelink(struct net_device *dev,
if (data && data[IFLA_MACVLAN_FLAGS]) {
__u16 flags = nla_get_u16(data[IFLA_MACVLAN_FLAGS]);
bool promisc = (flags ^ vlan->flags) & MACVLAN_FLAG_NOPROMISC;
- if (macvlan_passthru(vlan->port) && promisc) {
+ if (vlan->mode == MACVLAN_MODE_PASSTHRU && promisc) {
int err;
if (flags & MACVLAN_FLAG_NOPROMISC)
|
| 3/2 | 2026/07/10 02:07 | llm | patch-evaluator |
0mModel:gemini-3.1-pro-preview Args: null Results: null Tokens: input: 4538 output: 28 thoughts: 188 Thoughts: Here's my analysis of the situation: **MACVLAN Patch Deep Dive** Okay, so I'm looking at this patch for `drivers/net/macvlan.c`. It's clearly touching the core functionality of MACVLAN, and specifically seems to be relaxing some restrictions around how `MACVLAN_MODE_PASSTHRU` and `MACVLAN_MODE_SOURCE` devices can interact. This catches my attention because tight control over these modes is usually crucial for network security and isolation. The ability to mix and match them, i.e., adding a source mode device to a passthru VLAN or the other way around, is something that needs careful consideration as it could have some pretty significant security implications if implemented poorly. The patch touches a broad set of key functions within the macvlan code: `macvlan_uninit`, `macvlan_port_destroy`, `macvlan_common_newlink`, `macvlan_changelink`, `macvlan_open`, `macvlan_stop`, and even the FDB management functions `macvlan_fdb_add` and `macvlan_fdb_del`. The extent of this modification suggests that the behavior changes are fundamental and likely involve a significant rework of the underlying logic, rather than a simple feature addition. Before I delve into the code itself, I'll quickly verify that MACVLAN is even enabled in the current kernel configuration. I'll use `grepper` to search for `CONFIG_MACVLAN` to confirm it's actually relevant to the system. This check is routine for me, but it's a good sanity check to ensure I'm not wasting time on code that's not even compiled in. |
| 4/2 | 2026/07/10 02:07 | tool | grepper |
0mArgs:{
"Expression": "config MACVLAN",
"PathPrefix": "drivers/net/"
}Results: {
"Output": "drivers/net/Kconfig=163=source \"drivers/net/team/Kconfig\"\ndrivers/net/Kconfig-164-\ndrivers/net/Kconfig:165:config MACVLAN\ndrivers/net/Kconfig-166-\ttristate \"MAC-VLAN support\"\n"
} |
| 5/2 | 2026/07/10 02:07 | llm | patch-evaluator |
0mModel:gemini-3.1-pro-preview Args: null Results: null Tokens: input: 5211 output: 161 thoughts: 624 Thoughts: **MACVLAN Fuzzing Target Identification** Okay, so I'm looking at a patch related to MACVLAN configuration. The config is definitely `MACVLAN`, and from what I can tell, this code is functional, altering how MACVLAN devices are established and managed, specifically the handling of PASSTHRU and SOURCE modes. It's accessible via netlink (rtnetlink), which gives me a good entry point. My first thought is to dig into the modified functions and identify the most critical areas for fuzzing. I've pinpointed the following functions as the focus points: `macvlan_set_passthru`, `macvlan_clear_passthru`, `macvlan_open`, `macvlan_stop`, `macvlan_port_release_mac` (new), `macvlan_uninit`, `macvlan_fdb_add`, `macvlan_fdb_del`, `macvlan_port_destroy`, `macvlan_common_newlink`, and `macvlan_changelink`. Narrowing it down, the most promising targets for fuzzing are: `macvlan_common_newlink`, `macvlan_changelink`, `macvlan_uninit`, `macvlan_port_release_mac`, `macvlan_fdb_add`, `macvlan_fdb_del`, and `macvlan_port_destroy`. I had to confirm `macvlan_port_release_mac` was static. And it is, but it's called by `macvlan_uninit` and `macvlan_port_destroy`, so it's still relevant. I've also confirmed that the only config needed is `MACVLAN`, which depends on `NET`. This patch introduces new state transitions and modifications to the initialization and teardown logic. It's prime territory for fuzzing via rtnetlink, so I'm deeming it "WorthFuzzing". My final focus symbols are: `macvlan_common_newlink`, `macvlan_changelink`, `macvlan_uninit`, `macvlan_port_destroy`, `macvlan_fdb_add`, `macvlan_fdb_del`, and `macvlan_port_release_mac`. With `MACVLAN` enabled. This should be a good starting point. |
| 6/2 | 2026/07/10 02:07 | tool | set-results |
0mArgs:{
"EnableConfigs": [
"MACVLAN"
],
"FocusSymbols": [
"macvlan_common_newlink",
"macvlan_changelink",
"macvlan_uninit",
"macvlan_port_destroy",
"macvlan_fdb_add",
"macvlan_fdb_del",
"macvlan_port_release_mac"
],
"Reasoning": "The patch modifies the logic for creating and managing MACVLAN devices, specifically allowing combinations of PASSTHRU and SOURCE modes on the same port. This introduces new state transitions and initialization/teardown logic that should be fuzzed via rtnetlink.",
"WorthFuzzing": true
}Results: {
"EnableConfigs": [
"MACVLAN"
],
"FocusSymbols": [
"macvlan_common_newlink",
"macvlan_changelink",
"macvlan_uninit",
"macvlan_port_destroy",
"macvlan_fdb_add",
"macvlan_fdb_del",
"macvlan_port_release_mac"
],
"Reasoning": "The patch modifies the logic for creating and managing MACVLAN devices, specifically allowing combinations of PASSTHRU and SOURCE modes on the same port. This introduces new state transitions and initialization/teardown logic that should be fuzzed via rtnetlink.",
"WorthFuzzing": true
} |
| Total Calls | Total Tokens | Avg Tokens | Total Duration (Seconds) | Avg Duration (Seconds) |
|---|
| Total Calls | Total Duration (Seconds) | Avg Duration (Seconds) |
|---|