| Seq | Timestamp | Type | Name | Duration |
|---|---|---|---|---|
| 0/0 | 2026/09/30 01:09 | flow | patch-triage |
0mArgs:null Results: {
"EnableConfigs": null,
"FocusSymbols": [],
"KMSANReasoning": "",
"NeedsKMSAN": false,
"Reasoning": "The patch exclusively modifies the STMMAC (Synopsys DesignWare Ethernet MAC) driver and internal selftests in drivers/net/ethernet/stmicro/stmmac/. This driver requires dedicated physical hardware (specific embedded SoCs or vendor PCI NICs such as Intel Elkhart Lake or Motorcomm YT6801) not emulated in standard QEMU or GCE virtualized environments on amd64. Therefore, the modified code is structurally unreachable for fuzzing.",
"WorthFuzzing": false
} |
| 1/1 | 2026/09/30 01:09 | action | read-patch-diff |
0mArgs:null Results: {
"PatchDiff": "commit ac3eae2579fb40c35497017d8bd28b500a211211\nAuthor: syz-cluster \u003ctriage@syzkaller.com\u003e\nDate: Wed Sep 30 01:09:56 2026 +0000\n\n syz-cluster: applied patch under review\n\ndiff --git a/drivers/net/ethernet/stmicro/stmmac/hwif.h b/drivers/net/ethernet/stmicro/stmmac/hwif.h\nindex 857f7562c6c6d..5e2654c91b417 100644\n--- a/drivers/net/ethernet/stmicro/stmmac/hwif.h\n+++ b/drivers/net/ethernet/stmicro/stmmac/hwif.h\n@@ -633,7 +633,7 @@ struct stmmac_est_ops {\n struct stmmac_vlan_ops {\n \t/* VLAN */\n \tvoid (*update_vlan_hash)(struct mac_device_info *hw, u32 hash,\n-\t\t\t\t u16 perfect_match, bool is_double);\n+\t\t\t\t bool is_svlan);\n \tvoid (*enable_vlan)(struct mac_device_info *hw, u32 type);\n \tvoid (*rx_hw_vlan)(struct mac_device_info *hw, struct dma_desc *rx_desc,\n \t\t\t struct sk_buff *skb);\ndiff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac.h b/drivers/net/ethernet/stmicro/stmmac/stmmac.h\nindex 7582fca637419..d2d387f45c107 100644\n--- a/drivers/net/ethernet/stmicro/stmmac/stmmac.h\n+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac.h\n@@ -344,7 +344,7 @@ struct stmmac_priv {\n \tvoid __iomem *ptpaddr;\n \tvoid __iomem *estaddr;\n \tunsigned long active_vlans[BITS_TO_LONGS(VLAN_N_VID)];\n-\tunsigned int num_double_vlans;\n+\tunsigned int num_svlans;\n \tint sfty_irq;\n \tstruct stmmac_msi *msi;\n \ndiff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c\nindex 3f34d491c9592..5af245fd9ba04 100644\n--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c\n+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c\n@@ -6211,6 +6211,13 @@ static netdev_features_t stmmac_fix_features(struct net_device *dev,\n \tif (priv-\u003eplat-\u003ebugged_jumbo \u0026\u0026 (dev-\u003emtu \u003e ETH_DATA_LEN))\n \t\tfeatures \u0026= ~NETIF_F_CSUM_MASK;\n \n+\tif (priv-\u003eplat-\u003ecore_type == DWMAC_CORE_XGMAC) {\n+\t\tif (features \u0026 NETIF_F_HW_VLAN_CTAG_RX)\n+\t\t\tfeatures |= NETIF_F_HW_VLAN_STAG_RX;\n+\t\telse\n+\t\t\tfeatures \u0026= ~NETIF_F_HW_VLAN_STAG_RX;\n+\t}\n+\n \treturn features;\n }\n \n@@ -6835,32 +6842,21 @@ static u32 stmmac_vid_crc32_le(__le16 vid_le)\n \treturn crc;\n }\n \n-static int stmmac_vlan_update(struct stmmac_priv *priv, bool is_double)\n+static int stmmac_vlan_update(struct stmmac_priv *priv, bool is_svlan)\n {\n \tu32 crc, hash = 0;\n-\tu16 pmatch = 0;\n-\tint count = 0;\n \tu16 vid = 0;\n \n \tfor_each_set_bit(vid, priv-\u003eactive_vlans, VLAN_N_VID) {\n \t\t__le16 vid_le = cpu_to_le16(vid);\n \t\tcrc = bitrev32(~stmmac_vid_crc32_le(vid_le)) \u003e\u003e 28;\n \t\thash |= (1 \u003c\u003c crc);\n-\t\tcount++;\n-\t}\n-\n-\tif (!priv-\u003edma_cap.vlhash) {\n-\t\tif (count \u003e 2) /* VID = 0 always passes filter */\n-\t\t\treturn -EOPNOTSUPP;\n-\n-\t\tpmatch = vid;\n-\t\thash = 0;\n \t}\n \n \tif (!netif_running(priv-\u003edev))\n \t\treturn 0;\n \n-\treturn stmmac_update_vlan_hash(priv, priv-\u003ehw, hash, pmatch, is_double);\n+\treturn stmmac_update_vlan_hash(priv, priv-\u003ehw, hash, is_svlan);\n }\n \n /* FIXME: This may need RXC to be running, but it may be called with BH\n@@ -6869,8 +6865,8 @@ static int stmmac_vlan_update(struct stmmac_priv *priv, bool is_double)\n static int stmmac_vlan_rx_add_vid(struct net_device *ndev, __be16 proto, u16 vid)\n {\n \tstruct stmmac_priv *priv = netdev_priv(ndev);\n-\tunsigned int num_double_vlans;\n-\tbool is_double = false;\n+\tunsigned int num_svlans;\n+\tbool is_svlan = false;\n \tint ret;\n \n \tret = pm_runtime_resume_and_get(priv-\u003edevice);\n@@ -6878,11 +6874,11 @@ static int stmmac_vlan_rx_add_vid(struct net_device *ndev, __be16 proto, u16 vid\n \t\treturn ret;\n \n \tif (be16_to_cpu(proto) == ETH_P_8021AD)\n-\t\tis_double = true;\n+\t\tis_svlan = true;\n \n \tset_bit(vid, priv-\u003eactive_vlans);\n-\tnum_double_vlans = priv-\u003enum_double_vlans + is_double;\n-\tret = stmmac_vlan_update(priv, num_double_vlans);\n+\tnum_svlans = priv-\u003enum_svlans + is_svlan;\n+\tret = stmmac_vlan_update(priv, num_svlans);\n \tif (ret) {\n \t\tclear_bit(vid, priv-\u003eactive_vlans);\n \t\tgoto err_pm_put;\n@@ -6892,12 +6888,12 @@ static int stmmac_vlan_rx_add_vid(struct net_device *ndev, __be16 proto, u16 vid\n \t\tret = stmmac_add_hw_vlan_rx_fltr(priv, ndev, priv-\u003ehw, proto, vid);\n \t\tif (ret) {\n \t\t\tclear_bit(vid, priv-\u003eactive_vlans);\n-\t\t\tstmmac_vlan_update(priv, priv-\u003enum_double_vlans);\n+\t\t\tstmmac_vlan_update(priv, priv-\u003enum_svlans);\n \t\t\tgoto err_pm_put;\n \t\t}\n \t}\n \n-\tpriv-\u003enum_double_vlans = num_double_vlans;\n+\tpriv-\u003enum_svlans = num_svlans;\n \n err_pm_put:\n \tpm_runtime_put(priv-\u003edevice);\n@@ -6911,8 +6907,8 @@ static int stmmac_vlan_rx_add_vid(struct net_device *ndev, __be16 proto, u16 vid\n static int stmmac_vlan_rx_kill_vid(struct net_device *ndev, __be16 proto, u16 vid)\n {\n \tstruct stmmac_priv *priv = netdev_priv(ndev);\n-\tunsigned int num_double_vlans;\n-\tbool is_double = false;\n+\tunsigned int num_svlans;\n+\tbool is_svlan = false;\n \tint ret;\n \n \tret = pm_runtime_resume_and_get(priv-\u003edevice);\n@@ -6920,11 +6916,11 @@ static int stmmac_vlan_rx_kill_vid(struct net_device *ndev, __be16 proto, u16 vi\n \t\treturn ret;\n \n \tif (be16_to_cpu(proto) == ETH_P_8021AD)\n-\t\tis_double = true;\n+\t\tis_svlan = true;\n \n \tclear_bit(vid, priv-\u003eactive_vlans);\n-\tnum_double_vlans = priv-\u003enum_double_vlans - is_double;\n-\tret = stmmac_vlan_update(priv, num_double_vlans);\n+\tnum_svlans = priv-\u003enum_svlans - is_svlan;\n+\tret = stmmac_vlan_update(priv, num_svlans);\n \tif (ret) {\n \t\tset_bit(vid, priv-\u003eactive_vlans);\n \t\tgoto del_vlan_error;\n@@ -6934,12 +6930,12 @@ static int stmmac_vlan_rx_kill_vid(struct net_device *ndev, __be16 proto, u16 vi\n \t\tret = stmmac_del_hw_vlan_rx_fltr(priv, ndev, priv-\u003ehw, proto, vid);\n \t\tif (ret) {\n \t\t\tset_bit(vid, priv-\u003eactive_vlans);\n-\t\t\tstmmac_vlan_update(priv, priv-\u003enum_double_vlans);\n+\t\t\tstmmac_vlan_update(priv, priv-\u003enum_svlans);\n \t\t\tgoto del_vlan_error;\n \t\t}\n \t}\n \n-\tpriv-\u003enum_double_vlans = num_double_vlans;\n+\tpriv-\u003enum_svlans = num_svlans;\n \n del_vlan_error:\n \tpm_runtime_put(priv-\u003edevice);\n@@ -6955,7 +6951,7 @@ static void stmmac_vlan_restore(struct stmmac_priv *priv)\n \tif (priv-\u003ehw-\u003enum_vlan)\n \t\tstmmac_restore_hw_vlan_rx_fltr(priv, priv-\u003edev, priv-\u003ehw);\n \n-\tstmmac_vlan_update(priv, priv-\u003enum_double_vlans);\n+\tstmmac_vlan_update(priv, priv-\u003enum_svlans);\n }\n \n static int stmmac_bpf(struct net_device *dev, struct netdev_bpf *bpf)\n@@ -7994,14 +7990,18 @@ static int __stmmac_dvr_probe(struct device *device,\n \tndev-\u003ewatchdog_timeo = msecs_to_jiffies(watchdog);\n #ifdef STMMAC_VLAN_TAG_USED\n \t/* Both mac100 and gmac support receive VLAN tag detection */\n-\tndev-\u003efeatures |= NETIF_F_HW_VLAN_CTAG_RX | NETIF_F_HW_VLAN_STAG_RX;\n+\tndev-\u003efeatures |= NETIF_F_HW_VLAN_CTAG_RX;\n+\tif (priv-\u003eplat-\u003ecore_type == DWMAC_CORE_XGMAC)\n+\t\tndev-\u003efeatures |= NETIF_F_HW_VLAN_STAG_RX;\n+\n \tif (dwmac_is_xmac(priv-\u003eplat-\u003ecore_type)) {\n \t\tndev-\u003ehw_features |= NETIF_F_HW_VLAN_CTAG_RX;\n \t\tpriv-\u003ehw-\u003ehw_vlan_en = true;\n \t}\n \tif (priv-\u003edma_cap.vlhash) {\n \t\tndev-\u003efeatures |= NETIF_F_HW_VLAN_CTAG_FILTER;\n-\t\tndev-\u003efeatures |= NETIF_F_HW_VLAN_STAG_FILTER;\n+\t\tif (priv-\u003eplat-\u003ecore_type == DWMAC_CORE_XGMAC)\n+\t\t\tndev-\u003efeatures |= NETIF_F_HW_VLAN_STAG_FILTER;\n \t}\n \tif (priv-\u003edma_cap.vlins)\n \t\tndev-\u003efeatures |= NETIF_F_HW_VLAN_CTAG_TX;\ndiff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c\nindex c25dc9f89270c..c485217ba880c 100644\n--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c\n+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c\n@@ -243,7 +243,7 @@ struct stmmac_test_priv {\n \tint (*func)(struct sk_buff *skb, struct net_device *ndev,\n \t\t struct packet_type *pt, struct net_device *orig_ndev);\n \tbool capture_all;\n-\tint double_vlan;\n+\tint svlan;\n \tint vlan_id;\n \tint ok;\n };\n@@ -285,7 +285,7 @@ static int stmmac_test_loopback_validate(struct sk_buff *skb,\n \t}\n \n \tihdr = ip_hdr(skb);\n-\tif (tpriv-\u003edouble_vlan)\n+\tif (tpriv-\u003esvlan)\n \t\tihdr = (struct iphdr *)(skb_network_header(skb) + 4);\n \n \tif (tpriv-\u003epacket-\u003etcp) {\n@@ -936,7 +936,7 @@ static int stmmac_test_vlan_validate(struct sk_buff *skb,\n \tstruct iphdr *ihdr;\n \tu16 proto;\n \n-\tproto = tpriv-\u003edouble_vlan ? ETH_P_8021AD : ETH_P_8021Q;\n+\tproto = tpriv-\u003esvlan ? ETH_P_8021AD : ETH_P_8021Q;\n \n \tskb = skb_unshare(skb, GFP_ATOMIC);\n \tif (!skb)\n@@ -963,7 +963,7 @@ static int stmmac_test_vlan_validate(struct sk_buff *skb,\n \t}\n \n \tihdr = ip_hdr(skb);\n-\tif (tpriv-\u003edouble_vlan)\n+\tif (tpriv-\u003esvlan)\n \t\tihdr = (struct iphdr *)(skb_network_header(skb) + 4);\n \tif (ihdr-\u003eprotocol != IPPROTO_UDP)\n \t\tgoto out;\n@@ -1080,7 +1080,7 @@ static int stmmac_test_vlanfilt_perfect(struct stmmac_priv *priv)\n \treturn ret;\n }\n \n-static int __stmmac_test_dvlanfilt(struct stmmac_priv *priv)\n+static int __stmmac_test_svlanfilt(struct stmmac_priv *priv)\n {\n \tstruct stmmac_packet_attrs attr = { };\n \tstruct stmmac_test_priv *tpriv;\n@@ -1092,7 +1092,7 @@ static int __stmmac_test_dvlanfilt(struct stmmac_priv *priv)\n \t\treturn -ENOMEM;\n \n \ttpriv-\u003eok = false;\n-\ttpriv-\u003edouble_vlan = true;\n+\ttpriv-\u003esvlan = true;\n \tinit_completion(\u0026tpriv-\u003ecomp);\n \n \ttpriv-\u003ept.type = htons(ETH_P_8021Q);\n@@ -1155,15 +1155,15 @@ static int __stmmac_test_dvlanfilt(struct stmmac_priv *priv)\n \treturn ret;\n }\n \n-static int stmmac_test_dvlanfilt(struct stmmac_priv *priv)\n+static int stmmac_test_svlanfilt(struct stmmac_priv *priv)\n {\n \tif (!priv-\u003edma_cap.vlhash)\n \t\treturn -EOPNOTSUPP;\n \n-\treturn __stmmac_test_dvlanfilt(priv);\n+\treturn __stmmac_test_svlanfilt(priv);\n }\n \n-static int stmmac_test_dvlanfilt_perfect(struct stmmac_priv *priv)\n+static int stmmac_test_svlanfilt_perfect(struct stmmac_priv *priv)\n {\n \tint ret, prev_cap = priv-\u003edma_cap.vlhash;\n \n@@ -1171,7 +1171,7 @@ static int stmmac_test_dvlanfilt_perfect(struct stmmac_priv *priv)\n \t\treturn -EOPNOTSUPP;\n \n \tpriv-\u003edma_cap.vlhash = 0;\n-\tret = __stmmac_test_dvlanfilt(priv);\n+\tret = __stmmac_test_svlanfilt(priv);\n \tpriv-\u003edma_cap.vlhash = prev_cap;\n \n \treturn ret;\n@@ -1372,7 +1372,7 @@ static int stmmac_test_vlanoff_common(struct stmmac_priv *priv, bool svlan)\n \tproto = svlan ? ETH_P_8021AD : ETH_P_8021Q;\n \n \ttpriv-\u003eok = false;\n-\ttpriv-\u003edouble_vlan = svlan;\n+\ttpriv-\u003esvlan = svlan;\n \tinit_completion(\u0026tpriv-\u003ecomp);\n \n \ttpriv-\u003ept.type = svlan ? htons(ETH_P_8021Q) : htons(ETH_P_IP);\n@@ -1960,11 +1960,11 @@ static const struct stmmac_test {\n \t\t.name = \"VLAN Filtering (perf) \",\n \t\t.fn = stmmac_test_vlanfilt_perfect,\n \t}, {\n-\t\t.name = \"Double VLAN Filter \",\n-\t\t.fn = stmmac_test_dvlanfilt,\n+\t\t.name = \"SVLAN Filtering \",\n+\t\t.fn = stmmac_test_svlanfilt,\n \t}, {\n-\t\t.name = \"Double VLAN Filter (perf) \",\n-\t\t.fn = stmmac_test_dvlanfilt_perfect,\n+\t\t.name = \"SVLAN Filtering (perf) \",\n+\t\t.fn = stmmac_test_svlanfilt_perfect,\n \t}, {\n \t\t.name = \"Flexible RX Parser \",\n \t\t.fn = stmmac_test_rxp,\ndiff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_vlan.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_vlan.c\nindex e24efe3bfedbe..fb9aad748cb34 100644\n--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_vlan.c\n+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_vlan.c\n@@ -162,7 +162,7 @@ static void vlan_restore_hw_rx_fltr(struct net_device *dev,\n }\n \n static void vlan_update_hash(struct mac_device_info *hw, u32 hash,\n-\t\t\t u16 perfect_match, bool is_double)\n+\t\t\t bool is_svlan)\n {\n \tvoid __iomem *ioaddr = hw-\u003epcsr;\n \tu32 value;\n@@ -173,34 +173,17 @@ static void vlan_update_hash(struct mac_device_info *hw, u32 hash,\n \n \tif (hash) {\n \t\tvalue |= VLAN_VTHM | VLAN_ETV;\n-\t\tif (is_double) {\n-\t\t\tvalue |= VLAN_EDVLP;\n+\t\tif (is_svlan) {\n \t\t\tvalue |= VLAN_ESVL;\n \t\t\tvalue |= VLAN_DOVLTC;\n \t\t} else {\n-\t\t\tvalue \u0026= ~VLAN_EDVLP;\n \t\t\tvalue \u0026= ~VLAN_ESVL;\n \t\t\tvalue \u0026= ~VLAN_DOVLTC;\n \t\t}\n \n \t\twritel(value, ioaddr + VLAN_TAG);\n-\t} else if (perfect_match) {\n-\t\tu32 value = VLAN_ETV;\n-\n-\t\tif (is_double) {\n-\t\t\tvalue |= VLAN_EDVLP;\n-\t\t\tvalue |= VLAN_ESVL;\n-\t\t\tvalue |= VLAN_DOVLTC;\n-\t\t} else {\n-\t\t\tvalue \u0026= ~VLAN_EDVLP;\n-\t\t\tvalue \u0026= ~VLAN_ESVL;\n-\t\t\tvalue \u0026= ~VLAN_DOVLTC;\n-\t\t}\n-\n-\t\twritel(value | perfect_match, ioaddr + VLAN_TAG);\n \t} else {\n-\t\tvalue \u0026= ~(VLAN_VTHM | VLAN_ETV);\n-\t\tvalue \u0026= ~(VLAN_EDVLP | VLAN_ESVL);\n+\t\tvalue \u0026= ~(VLAN_VTHM | VLAN_ETV | VLAN_ESVL);\n \t\tvalue \u0026= ~VLAN_DOVLTC;\n \t\tvalue \u0026= ~VLAN_VID;\n \n@@ -236,6 +219,7 @@ static void vlan_set_hw_mode(struct mac_device_info *hw)\n \tvoid __iomem *ioaddr = hw-\u003epcsr;\n \tu32 value = readl(ioaddr + VLAN_TAG);\n \n+\tvalue |= VLAN_EDVLP;\n \tvalue \u0026= ~VLAN_TAG_CTRL_EVLS_MASK;\n \n \tif (hw-\u003ehw_vlan_en)\n@@ -251,7 +235,7 @@ static void vlan_set_hw_mode(struct mac_device_info *hw)\n }\n \n static void dwxgmac2_update_vlan_hash(struct mac_device_info *hw, u32 hash,\n-\t\t\t\t u16 perfect_match, bool is_double)\n+\t\t\t\t bool is_svlan)\n {\n \tvoid __iomem *ioaddr = hw-\u003epcsr;\n \n@@ -267,41 +251,16 @@ static void dwxgmac2_update_vlan_hash(struct mac_device_info *hw, u32 hash,\n \t\tvalue = readl(ioaddr + VLAN_TAG);\n \n \t\tvalue |= VLAN_VTHM | VLAN_ETV;\n-\t\tif (is_double) {\n-\t\t\tvalue |= VLAN_EDVLP;\n+\t\tif (is_svlan) {\n \t\t\tvalue |= VLAN_ESVL;\n \t\t\tvalue |= VLAN_DOVLTC;\n \t\t} else {\n-\t\t\tvalue \u0026= ~VLAN_EDVLP;\n \t\t\tvalue \u0026= ~VLAN_ESVL;\n \t\t\tvalue \u0026= ~VLAN_DOVLTC;\n \t\t}\n \n \t\tvalue \u0026= ~VLAN_VID;\n \t\twritel(value, ioaddr + VLAN_TAG);\n-\t} else if (perfect_match) {\n-\t\tu32 value = readl(ioaddr + XGMAC_PACKET_FILTER);\n-\n-\t\tvalue |= XGMAC_FILTER_VTFE;\n-\n-\t\twritel(value, ioaddr + XGMAC_PACKET_FILTER);\n-\n-\t\tvalue = readl(ioaddr + VLAN_TAG);\n-\n-\t\tvalue \u0026= ~VLAN_VTHM;\n-\t\tvalue |= VLAN_ETV;\n-\t\tif (is_double) {\n-\t\t\tvalue |= VLAN_EDVLP;\n-\t\t\tvalue |= VLAN_ESVL;\n-\t\t\tvalue |= VLAN_DOVLTC;\n-\t\t} else {\n-\t\t\tvalue \u0026= ~VLAN_EDVLP;\n-\t\t\tvalue \u0026= ~VLAN_ESVL;\n-\t\t\tvalue \u0026= ~VLAN_DOVLTC;\n-\t\t}\n-\n-\t\tvalue \u0026= ~VLAN_VID;\n-\t\twritel(value | perfect_match, ioaddr + VLAN_TAG);\n \t} else {\n \t\tu32 value = readl(ioaddr + XGMAC_PACKET_FILTER);\n \n@@ -311,8 +270,7 @@ static void dwxgmac2_update_vlan_hash(struct mac_device_info *hw, u32 hash,\n \n \t\tvalue = readl(ioaddr + VLAN_TAG);\n \n-\t\tvalue \u0026= ~(VLAN_VTHM | VLAN_ETV);\n-\t\tvalue \u0026= ~(VLAN_EDVLP | VLAN_ESVL);\n+\t\tvalue \u0026= ~(VLAN_VTHM | VLAN_ETV | VLAN_ESVL);\n \t\tvalue \u0026= ~VLAN_DOVLTC;\n \t\tvalue \u0026= ~VLAN_VID;\n \n@@ -320,6 +278,14 @@ static void dwxgmac2_update_vlan_hash(struct mac_device_info *hw, u32 hash,\n \t}\n }\n \n+static void dwxlgmac2_set_hw_vlan_mode(struct mac_device_info *hw)\n+{\n+\tvoid __iomem *ioaddr = hw-\u003epcsr;\n+\tu32 value = readl(ioaddr + VLAN_TAG);\n+\n+\twritel(value | VLAN_EDVLP, ioaddr + VLAN_TAG);\n+}\n+\n const struct stmmac_vlan_ops dwmac_vlan_ops = {\n \t.update_vlan_hash = vlan_update_hash,\n \t.enable_vlan = vlan_enable,\n@@ -333,6 +299,7 @@ const struct stmmac_vlan_ops dwmac_vlan_ops = {\n const struct stmmac_vlan_ops dwxlgmac2_vlan_ops = {\n \t.update_vlan_hash = dwxgmac2_update_vlan_hash,\n \t.enable_vlan = vlan_enable,\n+\t.set_hw_vlan_mode = dwxlgmac2_set_hw_vlan_mode,\n };\n \n const struct stmmac_vlan_ops dwxgmac210_vlan_ops = {\n"
} |
| 2/1 | 2026/09/30 01:09 | agent | patch-evaluator |
0mModel:core Args: null Results: {
"EnableConfigs": null,
"FocusSymbols": [],
"Reasoning": "The patch exclusively modifies the STMMAC (Synopsys DesignWare Ethernet MAC) driver and internal selftests in drivers/net/ethernet/stmicro/stmmac/. This driver requires dedicated physical hardware (specific embedded SoCs or vendor PCI NICs such as Intel Elkhart Lake or Motorcomm YT6801) not emulated in standard QEMU or GCE virtualized environments on amd64. Therefore, the modified code is structurally unreachable for fuzzing.",
"WorthFuzzing": false
}Instruction: You are an expert Linux kernel maintainer and security engineer.
Your job is to review a provided patch series and evaluate whether it warrants fuzzing with syzkaller.
IMPORTANT: The changes have ALREADY been applied and committed as the HEAD commit in
your workspace. Do NOT rely on internal assumptions. You must actively use your code access
tools to inspect the actual source code, callers, and surrounding context.
================================================================================
1. CORE TRIAGE PHILOSOPHY
================================================================================
The goal of patch fuzzing is to discover crashes, regressions, exposed latent bugs,
and newly triggered assertions introduced by the patch series.
- REACHABILITY IS THE PRIMARY GATE:
Fuzzing can only discover bugs in code that can actually execute in standard virtualized
environments (GCE or QEMU, utilizing software-emulated devices like USB gadgets, netdev, tun/tap).
If the modified code is structurally unreachable (see Section 2), it MUST NOT be fuzzed,
regardless of whether it adds assertions or complex logic.
- DO NOT BLINDLY TRUST "NO FUNCTIONAL CHANGE" (NFCI) OR "REFACTORING" CLAIMS:
Patch authors routinely label changes as "cleanups", "refactorings", or state
"No functional change intended". Do NOT take these claims at face value.
Code refactorings that rearrange logic, introduce helper functions, or alter state management
in core subsystems frequently introduce subtle semantic shifts or uncover latent kernel bugs.
If reachable executable code is modified or refactored, it MUST be fuzzed.
- NEW OR MODIFIED ASSERTIONS IN REACHABLE CODE MUST BE FUZZED:
When a patch introduces or modifies runtime checks or assertions (e.g., WARN_ON*, VM_WARN_ON*,
BUG_ON*, lockdep_assert*) in reachable code paths, it enforces new or stricter invariants.
Even if the author believes the invariant always holds, fuzzing is essential to verify whether
an unusual sequence of operations can violate it.
================================================================================
2. WHEN TO RETURN WorthFuzzing=false (NEGATIVE CRITERIA)
================================================================================
Return WorthFuzzing=false ONLY IF all modified code falls strictly into one or more of these categories:
- Non-kernel and non-executable changes:
* Modifications to Documentation/, comments, or spelling fixes.
* User-space directories, self-tests, samples, or scripts (e.g., tools/, samples/, scripts/, usr/)
that do not affect the compiled kernel image (vmlinux) or kernel modules.
* Purely decorative logging (e.g., message strings in pr_err, printk, dev_info) or tracepoints
that do not alter control flow or data structures.
* Build system or Kconfig changes that do not alter compiled C logic.
- Structurally unreachable hardware:
* Vendor-specific PCIe switches, SmartNICs, or GPU drivers (e.g., mlxsw, pds_core, qed,
ionic, amdgpu) requiring physical ASIC/PCIe cards not emulated in standard QEMU.
- Unreachable execution paths:
* Driver teardown callbacks (.remove, .shutdown, pci_unregister_driver) executed only during
physical PCI hot-unplug or manual sysfs driver unbinding.
* Code paths exclusive to architectures other than the target architecture.
================================================================================
3. WHEN TO RETURN WorthFuzzing=true (POSITIVE CRITERIA)
================================================================================
Return WorthFuzzing=true whenever the patch touches reachable executable code, including:
- Core Subsystems:
* Any logic modifications in memory management (mm/), synchronization/locking (kernel/locking/),
BPF, scheduler, core networking, VFS, or syscall handling.
- Refactorings and Code Cleanups:
* Any restructuring of reachable data structures, helper abstractions, or algorithm flows.
- Runtime Assertions and Defensive Checks:
* Any introduction or alteration of assertions (WARN_ON*, VM_WARN_ON*, BUG_ON*, etc.) in reachable paths.
- Reachable Drivers and Protocols:
* Drivers accessible via virtual buses (virtio, USB gadget, loopback, netlink, binder, sockets, etc.).
================================================================================
4. EXTRACTING FocusSymbols (PREVENTING DILUTION)
================================================================================
When WorthFuzzing=true, you must extract specific kernel functions into FocusSymbols to guide the fuzzer:
- AVOID UBIQUITOUS LIFECYCLE HOT-PATHS:
Do NOT list generic, ubiquitous functions called by almost every program in the corpus
(including, but not limited to: general memory allocators and deallocators, page fault
and trap handlers, or core synchronization primitives; this is not an exhaustive list).
Listing ubiquitous functions causes the fuzzer to classify thousands of unrelated tests as "focused",
which severely dilutes fuzzing effort away from the actual changes.
- TARGET SPECIFIC FEATURE LOGIC AND ENTRYPOINTS:
List functions that specifically implement the logic being added or altered, or direct API entrypoints
for the subsystem feature under review.
- HANDLING STATIC INLINE FUNCTIONS IN HEADERS (.h):
Compiler-inlined static functions (such as static inlines in mm/*.h or include/linux/*.h) lack
distinct symbol addresses in vmlinux and cannot be targeted directly by symbol coverage filters.
If the changes are primarily in static inline helpers, identify non-static, feature-specific caller
functions in .c files that exercise them (avoiding ubiquitous lifecycle wrappers).
================================================================================
5. IDENTIFYING EnableConfigs
================================================================================
Identify any specific CONFIG_ options required to properly compile and reach the modified code:
- Inspect Kconfig files and #ifdef guards; do not make assumptions.
- Check "depends on" lines in Kconfig to include any non-standard parent subsystem configs needed.
- Strip any 'CONFIG_' prefix (e.g., return "NET_IPV4" instead of "CONFIG_NET_IPV4").
Prefer calling several tools at the same time to save round-trips.
Use set-results tool to provide results of the analysis.
It must be called exactly once before the final reply.
Ignore results of this tool.
Prompt: Target architecture: amd64
For your convenience, here is the diff of the changes:
commit ac3eae2579fb40c35497017d8bd28b500a211211
Author: syz-cluster <triage@syzkaller.com>
Date: Wed Sep 30 01:09:56 2026 +0000
syz-cluster: applied patch under review
diff --git a/drivers/net/ethernet/stmicro/stmmac/hwif.h b/drivers/net/ethernet/stmicro/stmmac/hwif.h
index 857f7562c6c6d..5e2654c91b417 100644
--- a/drivers/net/ethernet/stmicro/stmmac/hwif.h
+++ b/drivers/net/ethernet/stmicro/stmmac/hwif.h
@@ -633,7 +633,7 @@ struct stmmac_est_ops {
struct stmmac_vlan_ops {
/* VLAN */
void (*update_vlan_hash)(struct mac_device_info *hw, u32 hash,
- u16 perfect_match, bool is_double);
+ bool is_svlan);
void (*enable_vlan)(struct mac_device_info *hw, u32 type);
void (*rx_hw_vlan)(struct mac_device_info *hw, struct dma_desc *rx_desc,
struct sk_buff *skb);
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac.h b/drivers/net/ethernet/stmicro/stmmac/stmmac.h
index 7582fca637419..d2d387f45c107 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac.h
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac.h
@@ -344,7 +344,7 @@ struct stmmac_priv {
void __iomem *ptpaddr;
void __iomem *estaddr;
unsigned long active_vlans[BITS_TO_LONGS(VLAN_N_VID)];
- unsigned int num_double_vlans;
+ unsigned int num_svlans;
int sfty_irq;
struct stmmac_msi *msi;
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
index 3f34d491c9592..5af245fd9ba04 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c
@@ -6211,6 +6211,13 @@ static netdev_features_t stmmac_fix_features(struct net_device *dev,
if (priv->plat->bugged_jumbo && (dev->mtu > ETH_DATA_LEN))
features &= ~NETIF_F_CSUM_MASK;
+ if (priv->plat->core_type == DWMAC_CORE_XGMAC) {
+ if (features & NETIF_F_HW_VLAN_CTAG_RX)
+ features |= NETIF_F_HW_VLAN_STAG_RX;
+ else
+ features &= ~NETIF_F_HW_VLAN_STAG_RX;
+ }
+
return features;
}
@@ -6835,32 +6842,21 @@ static u32 stmmac_vid_crc32_le(__le16 vid_le)
return crc;
}
-static int stmmac_vlan_update(struct stmmac_priv *priv, bool is_double)
+static int stmmac_vlan_update(struct stmmac_priv *priv, bool is_svlan)
{
u32 crc, hash = 0;
- u16 pmatch = 0;
- int count = 0;
u16 vid = 0;
for_each_set_bit(vid, priv->active_vlans, VLAN_N_VID) {
__le16 vid_le = cpu_to_le16(vid);
crc = bitrev32(~stmmac_vid_crc32_le(vid_le)) >> 28;
hash |= (1 << crc);
- count++;
- }
-
- if (!priv->dma_cap.vlhash) {
- if (count > 2) /* VID = 0 always passes filter */
- return -EOPNOTSUPP;
-
- pmatch = vid;
- hash = 0;
}
if (!netif_running(priv->dev))
return 0;
- return stmmac_update_vlan_hash(priv, priv->hw, hash, pmatch, is_double);
+ return stmmac_update_vlan_hash(priv, priv->hw, hash, is_svlan);
}
/* FIXME: This may need RXC to be running, but it may be called with BH
@@ -6869,8 +6865,8 @@ static int stmmac_vlan_update(struct stmmac_priv *priv, bool is_double)
static int stmmac_vlan_rx_add_vid(struct net_device *ndev, __be16 proto, u16 vid)
{
struct stmmac_priv *priv = netdev_priv(ndev);
- unsigned int num_double_vlans;
- bool is_double = false;
+ unsigned int num_svlans;
+ bool is_svlan = false;
int ret;
ret = pm_runtime_resume_and_get(priv->device);
@@ -6878,11 +6874,11 @@ static int stmmac_vlan_rx_add_vid(struct net_device *ndev, __be16 proto, u16 vid
return ret;
if (be16_to_cpu(proto) == ETH_P_8021AD)
- is_double = true;
+ is_svlan = true;
set_bit(vid, priv->active_vlans);
- num_double_vlans = priv->num_double_vlans + is_double;
- ret = stmmac_vlan_update(priv, num_double_vlans);
+ num_svlans = priv->num_svlans + is_svlan;
+ ret = stmmac_vlan_update(priv, num_svlans);
if (ret) {
clear_bit(vid, priv->active_vlans);
goto err_pm_put;
@@ -6892,12 +6888,12 @@ static int stmmac_vlan_rx_add_vid(struct net_device *ndev, __be16 proto, u16 vid
ret = stmmac_add_hw_vlan_rx_fltr(priv, ndev, priv->hw, proto, vid);
if (ret) {
clear_bit(vid, priv->active_vlans);
- stmmac_vlan_update(priv, priv->num_double_vlans);
+ stmmac_vlan_update(priv, priv->num_svlans);
goto err_pm_put;
}
}
- priv->num_double_vlans = num_double_vlans;
+ priv->num_svlans = num_svlans;
err_pm_put:
pm_runtime_put(priv->device);
@@ -6911,8 +6907,8 @@ static int stmmac_vlan_rx_add_vid(struct net_device *ndev, __be16 proto, u16 vid
static int stmmac_vlan_rx_kill_vid(struct net_device *ndev, __be16 proto, u16 vid)
{
struct stmmac_priv *priv = netdev_priv(ndev);
- unsigned int num_double_vlans;
- bool is_double = false;
+ unsigned int num_svlans;
+ bool is_svlan = false;
int ret;
ret = pm_runtime_resume_and_get(priv->device);
@@ -6920,11 +6916,11 @@ static int stmmac_vlan_rx_kill_vid(struct net_device *ndev, __be16 proto, u16 vi
return ret;
if (be16_to_cpu(proto) == ETH_P_8021AD)
- is_double = true;
+ is_svlan = true;
clear_bit(vid, priv->active_vlans);
- num_double_vlans = priv->num_double_vlans - is_double;
- ret = stmmac_vlan_update(priv, num_double_vlans);
+ num_svlans = priv->num_svlans - is_svlan;
+ ret = stmmac_vlan_update(priv, num_svlans);
if (ret) {
set_bit(vid, priv->active_vlans);
goto del_vlan_error;
@@ -6934,12 +6930,12 @@ static int stmmac_vlan_rx_kill_vid(struct net_device *ndev, __be16 proto, u16 vi
ret = stmmac_del_hw_vlan_rx_fltr(priv, ndev, priv->hw, proto, vid);
if (ret) {
set_bit(vid, priv->active_vlans);
- stmmac_vlan_update(priv, priv->num_double_vlans);
+ stmmac_vlan_update(priv, priv->num_svlans);
goto del_vlan_error;
}
}
- priv->num_double_vlans = num_double_vlans;
+ priv->num_svlans = num_svlans;
del_vlan_error:
pm_runtime_put(priv->device);
@@ -6955,7 +6951,7 @@ static void stmmac_vlan_restore(struct stmmac_priv *priv)
if (priv->hw->num_vlan)
stmmac_restore_hw_vlan_rx_fltr(priv, priv->dev, priv->hw);
- stmmac_vlan_update(priv, priv->num_double_vlans);
+ stmmac_vlan_update(priv, priv->num_svlans);
}
static int stmmac_bpf(struct net_device *dev, struct netdev_bpf *bpf)
@@ -7994,14 +7990,18 @@ static int __stmmac_dvr_probe(struct device *device,
ndev->watchdog_timeo = msecs_to_jiffies(watchdog);
#ifdef STMMAC_VLAN_TAG_USED
/* Both mac100 and gmac support receive VLAN tag detection */
- ndev->features |= NETIF_F_HW_VLAN_CTAG_RX | NETIF_F_HW_VLAN_STAG_RX;
+ ndev->features |= NETIF_F_HW_VLAN_CTAG_RX;
+ if (priv->plat->core_type == DWMAC_CORE_XGMAC)
+ ndev->features |= NETIF_F_HW_VLAN_STAG_RX;
+
if (dwmac_is_xmac(priv->plat->core_type)) {
ndev->hw_features |= NETIF_F_HW_VLAN_CTAG_RX;
priv->hw->hw_vlan_en = true;
}
if (priv->dma_cap.vlhash) {
ndev->features |= NETIF_F_HW_VLAN_CTAG_FILTER;
- ndev->features |= NETIF_F_HW_VLAN_STAG_FILTER;
+ if (priv->plat->core_type == DWMAC_CORE_XGMAC)
+ ndev->features |= NETIF_F_HW_VLAN_STAG_FILTER;
}
if (priv->dma_cap.vlins)
ndev->features |= NETIF_F_HW_VLAN_CTAG_TX;
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c
index c25dc9f89270c..c485217ba880c 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c
@@ -243,7 +243,7 @@ struct stmmac_test_priv {
int (*func)(struct sk_buff *skb, struct net_device *ndev,
struct packet_type *pt, struct net_device *orig_ndev);
bool capture_all;
- int double_vlan;
+ int svlan;
int vlan_id;
int ok;
};
@@ -285,7 +285,7 @@ static int stmmac_test_loopback_validate(struct sk_buff *skb,
}
ihdr = ip_hdr(skb);
- if (tpriv->double_vlan)
+ if (tpriv->svlan)
ihdr = (struct iphdr *)(skb_network_header(skb) + 4);
if (tpriv->packet->tcp) {
@@ -936,7 +936,7 @@ static int stmmac_test_vlan_validate(struct sk_buff *skb,
struct iphdr *ihdr;
u16 proto;
- proto = tpriv->double_vlan ? ETH_P_8021AD : ETH_P_8021Q;
+ proto = tpriv->svlan ? ETH_P_8021AD : ETH_P_8021Q;
skb = skb_unshare(skb, GFP_ATOMIC);
if (!skb)
@@ -963,7 +963,7 @@ static int stmmac_test_vlan_validate(struct sk_buff *skb,
}
ihdr = ip_hdr(skb);
- if (tpriv->double_vlan)
+ if (tpriv->svlan)
ihdr = (struct iphdr *)(skb_network_header(skb) + 4);
if (ihdr->protocol != IPPROTO_UDP)
goto out;
@@ -1080,7 +1080,7 @@ static int stmmac_test_vlanfilt_perfect(struct stmmac_priv *priv)
return ret;
}
-static int __stmmac_test_dvlanfilt(struct stmmac_priv *priv)
+static int __stmmac_test_svlanfilt(struct stmmac_priv *priv)
{
struct stmmac_packet_attrs attr = { };
struct stmmac_test_priv *tpriv;
@@ -1092,7 +1092,7 @@ static int __stmmac_test_dvlanfilt(struct stmmac_priv *priv)
return -ENOMEM;
tpriv->ok = false;
- tpriv->double_vlan = true;
+ tpriv->svlan = true;
init_completion(&tpriv->comp);
tpriv->pt.type = htons(ETH_P_8021Q);
@@ -1155,15 +1155,15 @@ static int __stmmac_test_dvlanfilt(struct stmmac_priv *priv)
return ret;
}
-static int stmmac_test_dvlanfilt(struct stmmac_priv *priv)
+static int stmmac_test_svlanfilt(struct stmmac_priv *priv)
{
if (!priv->dma_cap.vlhash)
return -EOPNOTSUPP;
- return __stmmac_test_dvlanfilt(priv);
+ return __stmmac_test_svlanfilt(priv);
}
-static int stmmac_test_dvlanfilt_perfect(struct stmmac_priv *priv)
+static int stmmac_test_svlanfilt_perfect(struct stmmac_priv *priv)
{
int ret, prev_cap = priv->dma_cap.vlhash;
@@ -1171,7 +1171,7 @@ static int stmmac_test_dvlanfilt_perfect(struct stmmac_priv *priv)
return -EOPNOTSUPP;
priv->dma_cap.vlhash = 0;
- ret = __stmmac_test_dvlanfilt(priv);
+ ret = __stmmac_test_svlanfilt(priv);
priv->dma_cap.vlhash = prev_cap;
return ret;
@@ -1372,7 +1372,7 @@ static int stmmac_test_vlanoff_common(struct stmmac_priv *priv, bool svlan)
proto = svlan ? ETH_P_8021AD : ETH_P_8021Q;
tpriv->ok = false;
- tpriv->double_vlan = svlan;
+ tpriv->svlan = svlan;
init_completion(&tpriv->comp);
tpriv->pt.type = svlan ? htons(ETH_P_8021Q) : htons(ETH_P_IP);
@@ -1960,11 +1960,11 @@ static const struct stmmac_test {
.name = "VLAN Filtering (perf) ",
.fn = stmmac_test_vlanfilt_perfect,
}, {
- .name = "Double VLAN Filter ",
- .fn = stmmac_test_dvlanfilt,
+ .name = "SVLAN Filtering ",
+ .fn = stmmac_test_svlanfilt,
}, {
- .name = "Double VLAN Filter (perf) ",
- .fn = stmmac_test_dvlanfilt_perfect,
+ .name = "SVLAN Filtering (perf) ",
+ .fn = stmmac_test_svlanfilt_perfect,
}, {
.name = "Flexible RX Parser ",
.fn = stmmac_test_rxp,
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_vlan.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_vlan.c
index e24efe3bfedbe..fb9aad748cb34 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_vlan.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_vlan.c
@@ -162,7 +162,7 @@ static void vlan_restore_hw_rx_fltr(struct net_device *dev,
}
static void vlan_update_hash(struct mac_device_info *hw, u32 hash,
- u16 perfect_match, bool is_double)
+ bool is_svlan)
{
void __iomem *ioaddr = hw->pcsr;
u32 value;
@@ -173,34 +173,17 @@ static void vlan_update_hash(struct mac_device_info *hw, u32 hash,
if (hash) {
value |= VLAN_VTHM | VLAN_ETV;
- if (is_double) {
- value |= VLAN_EDVLP;
+ if (is_svlan) {
value |= VLAN_ESVL;
value |= VLAN_DOVLTC;
} else {
- value &= ~VLAN_EDVLP;
value &= ~VLAN_ESVL;
value &= ~VLAN_DOVLTC;
}
writel(value, ioaddr + VLAN_TAG);
- } else if (perfect_match) {
- u32 value = VLAN_ETV;
-
- if (is_double) {
- value |= VLAN_EDVLP;
- value |= VLAN_ESVL;
- value |= VLAN_DOVLTC;
- } else {
- value &= ~VLAN_EDVLP;
- value &= ~VLAN_ESVL;
- value &= ~VLAN_DOVLTC;
- }
-
- writel(value | perfect_match, ioaddr + VLAN_TAG);
} else {
- value &= ~(VLAN_VTHM | VLAN_ETV);
- value &= ~(VLAN_EDVLP | VLAN_ESVL);
+ value &= ~(VLAN_VTHM | VLAN_ETV | VLAN_ESVL);
value &= ~VLAN_DOVLTC;
value &= ~VLAN_VID;
@@ -236,6 +219,7 @@ static void vlan_set_hw_mode(struct mac_device_info *hw)
void __iomem *ioaddr = hw->pcsr;
u32 value = readl(ioaddr + VLAN_TAG);
+ value |= VLAN_EDVLP;
value &= ~VLAN_TAG_CTRL_EVLS_MASK;
if (hw->hw_vlan_en)
@@ -251,7 +235,7 @@ static void vlan_set_hw_mode(struct mac_device_info *hw)
}
static void dwxgmac2_update_vlan_hash(struct mac_device_info *hw, u32 hash,
- u16 perfect_match, bool is_double)
+ bool is_svlan)
{
void __iomem *ioaddr = hw->pcsr;
@@ -267,41 +251,16 @@ static void dwxgmac2_update_vlan_hash(struct mac_device_info *hw, u32 hash,
value = readl(ioaddr + VLAN_TAG);
value |= VLAN_VTHM | VLAN_ETV;
- if (is_double) {
- value |= VLAN_EDVLP;
+ if (is_svlan) {
value |= VLAN_ESVL;
value |= VLAN_DOVLTC;
} else {
- value &= ~VLAN_EDVLP;
value &= ~VLAN_ESVL;
value &= ~VLAN_DOVLTC;
}
value &= ~VLAN_VID;
writel(value, ioaddr + VLAN_TAG);
- } else if (perfect_match) {
- u32 value = readl(ioaddr + XGMAC_PACKET_FILTER);
-
- value |= XGMAC_FILTER_VTFE;
-
- writel(value, ioaddr + XGMAC_PACKET_FILTER);
-
- value = readl(ioaddr + VLAN_TAG);
-
- value &= ~VLAN_VTHM;
- value |= VLAN_ETV;
- if (is_double) {
- value |= VLAN_EDVLP;
- value |= VLAN_ESVL;
- value |= VLAN_DOVLTC;
- } else {
- value &= ~VLAN_EDVLP;
- value &= ~VLAN_ESVL;
- value &= ~VLAN_DOVLTC;
- }
-
- value &= ~VLAN_VID;
- writel(value | perfect_match, ioaddr + VLAN_TAG);
} else {
u32 value = readl(ioaddr + XGMAC_PACKET_FILTER);
@@ -311,8 +270,7 @@ static void dwxgmac2_update_vlan_hash(struct mac_device_info *hw, u32 hash,
value = readl(ioaddr + VLAN_TAG);
- value &= ~(VLAN_VTHM | VLAN_ETV);
- value &= ~(VLAN_EDVLP | VLAN_ESVL);
+ value &= ~(VLAN_VTHM | VLAN_ETV | VLAN_ESVL);
value &= ~VLAN_DOVLTC;
value &= ~VLAN_VID;
@@ -320,6 +278,14 @@ static void dwxgmac2_update_vlan_hash(struct mac_device_info *hw, u32 hash,
}
}
+static void dwxlgmac2_set_hw_vlan_mode(struct mac_device_info *hw)
+{
+ void __iomem *ioaddr = hw->pcsr;
+ u32 value = readl(ioaddr + VLAN_TAG);
+
+ writel(value | VLAN_EDVLP, ioaddr + VLAN_TAG);
+}
+
const struct stmmac_vlan_ops dwmac_vlan_ops = {
.update_vlan_hash = vlan_update_hash,
.enable_vlan = vlan_enable,
@@ -333,6 +299,7 @@ const struct stmmac_vlan_ops dwmac_vlan_ops = {
const struct stmmac_vlan_ops dwxlgmac2_vlan_ops = {
.update_vlan_hash = dwxgmac2_update_vlan_hash,
.enable_vlan = vlan_enable,
+ .set_hw_vlan_mode = dwxlgmac2_set_hw_vlan_mode,
};
const struct stmmac_vlan_ops dwxgmac210_vlan_ops = {
|
| 3/2 | 2026/09/30 01:09 | llm | patch-evaluator |
0mModel:gemini-3.8-flash Args: null Results: null Tokens: input: 9323 output: 40 thoughts: 252 Thoughts: **Analyzing the Stmmac Patch** Okay, let's dive into this patch. I see the diff touches `hwif.h`, `stmmac.h`, `stmmac_main.c`, `stmmac_selftests.c`, and `stmmac_vlan.c`. Right away, that tells me we're dealing with the `stmmac` driver, which from memory is the STMicroelectronics/Synopsys DesignWare Ethernet MAC. Now, before I get too deep, I need to understand the environment implications. My immediate thought is, "Is this driver typically emulated in QEMU, or is it more often found on specific vendor hardware?" I need to quickly establish if we're dealing with something that can be easily reproduced in a virtualized environment for testing and debugging, or if it's tied to a particular PCIe or SoC configuration. Is it something that is *structurally* unreachable without specific hardware? Hmm, better to be sure. I'll quickly check if `stmmac` is readily available in standard QEMU or virt environments. Let me do a quick grep or a Kconfig lookup to verify its typical support matrix. I need to know how easily I can reproduce this! |
| 4/2 | 2026/09/30 01:10 | tool | grepper |
0mArgs:{
"Expression": "config STMMAC_ETH",
"PathPrefix": "drivers/net/ethernet/stmicro/stmmac/"
}Results: {
"Output": "drivers/net/ethernet/stmicro/stmmac/Kconfig-1-# SPDX-License-Identifier: GPL-2.0-only\ndrivers/net/ethernet/stmicro/stmmac/Kconfig:2:config STMMAC_ETH\ndrivers/net/ethernet/stmicro/stmmac/Kconfig-3-\ttristate \"STMicroelectronics Multi-Gigabit Ethernet driver\"\n"
} |
| 5/2 | 2026/09/30 01:10 | llm | patch-evaluator |
0mModel:gemini-3.8-flash Args: null Results: null Tokens: input: 9984 output: 42 thoughts: 22 Thoughts: Here's a summary of my thought process, as requested: **Navigating the Kernel's Network Driver Landscape** Okay, so I need to understand something related to Ethernet drivers in the Linux kernel. Where would the most logical place to start be? Hmm, based on prior experience, the configuration files often hold critical information about how drivers are built and what features are enabled. I've often found myself delving into `Kconfig` files to understand dependencies and options. Specifically, for STM's Ethernet MAC, I immediately think of the `drivers/net/ethernet/stmicro/stmmac/` directory. Therefore, my first port of call, I believe, is to check the `Kconfig` file in that location, namely `drivers/net/ethernet/stmicro/stmmac/Kconfig`. That's where I expect to gain a solid starting point for getting up to speed. |
| 6/2 | 2026/09/30 01:10 | tool | read-file |
0mArgs:{
"File": "drivers/net/ethernet/stmicro/stmmac/Kconfig",
"FirstLine": 1,
"LineCount": 80
}Results: {
"Contents": " 1:\t# SPDX-License-Identifier: GPL-2.0-only\n 2:\tconfig STMMAC_ETH\n 3:\t\ttristate \"STMicroelectronics Multi-Gigabit Ethernet driver\"\n 4:\t\tdepends on HAS_IOMEM \u0026\u0026 HAS_DMA\n 5:\t\tdepends on PTP_1588_CLOCK_OPTIONAL\n 6:\t\tdepends on ETHTOOL_NETLINK\n 7:\t\tselect MII\n 8:\t\tselect PCS_XPCS\n 9:\t\tselect PAGE_POOL\n 10:\t\tselect PHYLINK\n 11:\t\tselect CRC32\n 12:\t\tselect RESET_CONTROLLER\n 13:\t\tselect NET_DEVLINK\n 14:\t\thelp\n 15:\t\t This is the driver for the Ethernet IPs built around a\n 16:\t\t Synopsys IP Core.\n 17:\t\n 18:\tif STMMAC_ETH\n 19:\t\n 20:\tconfig STMMAC_SELFTESTS\n 21:\t\tbool \"Support for STMMAC Selftests\"\n 22:\t\tdepends on INET\n 23:\t\tdefault n\n 24:\t\thelp\n 25:\t\t This adds support for STMMAC Selftests using ethtool. Enable this\n 26:\t\t feature if you are facing problems with your HW and submit the test\n 27:\t\t results to the netdev Mailing List.\n 28:\t\n 29:\tconfig STMMAC_PLATFORM\n 30:\t\ttristate \"STMMAC Platform bus support\"\n 31:\t\tselect MFD_SYSCON\n 32:\t\tdefault y\n 33:\t\thelp\n 34:\t\t This selects the platform specific bus support for the stmmac driver.\n 35:\t\t This is the driver used on several SoCs:\n 36:\t\t STi, Allwinner, Amlogic Meson, Altera SOCFPGA.\n 37:\t\n 38:\t\t If you have a controller with this interface, say Y or M here.\n 39:\t\n 40:\t\t If unsure, say N.\n 41:\t\n 42:\tif STMMAC_PLATFORM\n 43:\t\n 44:\tconfig DWMAC_DWC_QOS_ETH\n 45:\t\ttristate \"Support for snps,dwc-qos-ethernet.txt DT binding.\"\n 46:\t\tselect CRC32\n 47:\t\tselect MII\n 48:\t\tdepends on OF \u0026\u0026 HAS_DMA\n 49:\t\thelp\n 50:\t\t Support for chips using the snps,dwc-qos-ethernet.txt DT binding.\n 51:\t\n 52:\tconfig DWMAC_GENERIC\n 53:\t\ttristate \"Generic driver for DWMAC\"\n 54:\t\tdefault STMMAC_PLATFORM\n 55:\t\thelp\n 56:\t\t Generic DWMAC driver for platforms that don't require any\n 57:\t\t platform specific code to function or is using platform\n 58:\t\t data for setup.\n 59:\t\n 60:\tconfig DWMAC_ANARION\n 61:\t\ttristate \"Adaptrum Anarion GMAC support\"\n 62:\t\tdefault ARC\n 63:\t\tdepends on OF \u0026\u0026 (ARC || COMPILE_TEST)\n 64:\t\thelp\n 65:\t\t Support for Adaptrum Anarion GMAC Ethernet controller.\n 66:\t\n 67:\t\t This selects the Anarion SoC glue layer support for the stmmac driver.\n 68:\t\n 69:\tconfig DWMAC_EIC7700\n 70:\t\ttristate \"Support for Eswin eic7700 ethernet driver\"\n 71:\t\tdepends on OF \u0026\u0026 HAS_DMA \u0026\u0026 ARCH_ESWIN || COMPILE_TEST\n 72:\t\thelp\n 73:\t\t This driver supports the Eswin EIC7700 Ethernet controller,\n 74:\t\t which integrates Synopsys DesignWare QoS features. It enables\n 75:\t\t high-speed networking with DMA acceleration and is optimized\n 76:\t\t for embedded systems.\n 77:\t\n 78:\tconfig DWMAC_INGENIC\n 79:\t\ttristate \"Ingenic MAC support\"\n 80:\t\tdefault MACH_INGENIC\n"
} |
| 7/2 | 2026/09/30 01:10 | llm | patch-evaluator |
0mModel:gemini-3.8-flash Args: null Results: null Tokens: input: 11324 output: 44 thoughts: 37 Thoughts: Here's my thought process, as if I were considering this myself: **Investigating STMMAC Driver Binding in Kconfig** Okay, so I need to understand the hardware binding for the STMMAC Ethernet driver. I'm currently looking at `drivers/net/ethernet/stmicro/stmmac/Kconfig`. Time to delve deeper into its configuration options. I'm specifically wondering: what buses is this driver capable of attaching to? My initial hunch is that it's probably flexible. It likely supports both PCI and platform buses, given the breadth of STMicroelectronics' SoCs. But I really should make sure, so I will analyze the configuration options. |
| 8/2 | 2026/09/30 01:10 | tool | read-file |
0mArgs:{
"File": "drivers/net/ethernet/stmicro/stmmac/Kconfig",
"FirstLine": 81,
"LineCount": 100
}Results: {
"Contents": " 81:\t\tdepends on OF \u0026\u0026 HAS_IOMEM \u0026\u0026 (MACH_INGENIC || COMPILE_TEST)\n 82:\t\tselect MFD_SYSCON\n 83:\t\thelp\n 84:\t\t Support for ethernet controller on Ingenic SoCs.\n 85:\t\n 86:\t\t This selects Ingenic SoCs glue layer support for the stmmac\n 87:\t\t device driver. This driver is used on for the Ingenic SoCs\n 88:\t\t MAC ethernet controller.\n 89:\t\n 90:\tconfig DWMAC_IPQ806X\n 91:\t\ttristate \"QCA IPQ806x DWMAC support\"\n 92:\t\tdefault ARCH_QCOM\n 93:\t\tdepends on OF \u0026\u0026 (ARCH_QCOM || COMPILE_TEST)\n 94:\t\tselect MFD_SYSCON\n 95:\t\thelp\n 96:\t\t Support for QCA IPQ806X DWMAC Ethernet.\n 97:\t\n 98:\t\t This selects the IPQ806x SoC glue layer support for the stmmac\n 99:\t\t device driver. This driver does not use any of the hardware\n 100:\t\t acceleration features available on this SoC. Network devices\n 101:\t\t will behave like standard non-accelerated ethernet interfaces.\n 102:\t\n 103:\t\t Select the QCOM_SOCINFO config flag to enable specific dwmac\n 104:\t\t fixup based on the ipq806x SoC revision.\n 105:\t\n 106:\tconfig DWMAC_LPC18XX\n 107:\t\ttristate \"NXP LPC18xx/43xx DWMAC support\"\n 108:\t\tdefault ARCH_LPC18XX\n 109:\t\tdepends on OF \u0026\u0026 (ARCH_LPC18XX || COMPILE_TEST)\n 110:\t\tselect MFD_SYSCON\n 111:\t\thelp\n 112:\t\t Support for NXP LPC18xx/43xx DWMAC Ethernet.\n 113:\t\n 114:\tconfig DWMAC_MEDIATEK\n 115:\t\ttristate \"MediaTek MT27xx GMAC support\"\n 116:\t\tdepends on OF \u0026\u0026 (ARCH_MEDIATEK || COMPILE_TEST)\n 117:\t\thelp\n 118:\t\t Support for MediaTek GMAC Ethernet controller.\n 119:\t\n 120:\t\t This selects the MT2712 SoC support for the stmmac driver.\n 121:\t\n 122:\tconfig DWMAC_MESON\n 123:\t\ttristate \"Amlogic Meson dwmac support\"\n 124:\t\tdefault ARCH_MESON\n 125:\t\tdepends on OF \u0026\u0026 COMMON_CLK \u0026\u0026 (ARCH_MESON || COMPILE_TEST)\n 126:\t\thelp\n 127:\t\t Support for Ethernet controller on Amlogic Meson SoCs.\n 128:\t\n 129:\t\t This selects the Amlogic Meson SoC glue layer support for\n 130:\t\t the stmmac device driver. This driver is used for Meson6,\n 131:\t\t Meson8, Meson8b and GXBB SoCs.\n 132:\t\n 133:\tconfig DWMAC_NUVOTON\n 134:\t\ttristate \"Nuvoton MA35 dwmac support\"\n 135:\t\tdefault ARCH_MA35\n 136:\t\tdepends on OF \u0026\u0026 (ARCH_MA35 || COMPILE_TEST)\n 137:\t\tselect MFD_SYSCON\n 138:\t\thelp\n 139:\t\t Support for Ethernet controller on Nuvoton MA35 series SoC.\n 140:\t\n 141:\t\t This selects the Nuvoton MA35 series SoC glue layer support\n 142:\t\t for the stmmac device driver. The nuvoton-dwmac driver is\n 143:\t\t used for MA35 series SoCs.\n 144:\t\n 145:\tconfig DWMAC_QCOM_ETHQOS\n 146:\t\ttristate \"Qualcomm ETHQOS support\"\n 147:\t\tdefault ARCH_QCOM\n 148:\t\tdepends on OF \u0026\u0026 (ARCH_QCOM || COMPILE_TEST)\n 149:\t\thelp\n 150:\t\t Support for the Qualcomm ETHQOS core.\n 151:\t\n 152:\t\t This selects the Qualcomm ETHQOS glue layer support for the\n 153:\t\t stmmac device driver.\n 154:\t\n 155:\tconfig DWMAC_RENESAS_GBETH\n 156:\t\ttristate \"Renesas RZ/V2H(P) GBETH and RZ/T2H, RZ/N2H GMAC support\"\n 157:\t\tdefault ARCH_RENESAS\n 158:\t\tdepends on OF \u0026\u0026 (ARCH_RENESAS || COMPILE_TEST)\n 159:\t\tselect PCS_RZN1_MIIC\n 160:\t\thelp\n 161:\t\t Support for Gigabit Ethernet Interface (GBETH)/ Ethernet MAC (GMAC)\n 162:\t\t on Renesas SoCs.\n 163:\t\n 164:\t\t This selects Renesas SoC glue layer support for the stmmac device\n 165:\t\t driver. This driver is used for the RZ/V2H(P) family, RZ/T2H and\n 166:\t\t RZ/N2H SoCs.\n 167:\t\n 168:\tconfig DWMAC_ROCKCHIP\n 169:\t\ttristate \"Rockchip dwmac support\"\n 170:\t\tdefault ARCH_ROCKCHIP\n 171:\t\tdepends on OF \u0026\u0026 (ARCH_ROCKCHIP || COMPILE_TEST)\n 172:\t\tselect MFD_SYSCON\n 173:\t\thelp\n 174:\t\t Support for Ethernet controller on Rockchip RK3288 SoC.\n 175:\t\n 176:\t\t This selects the Rockchip RK3288 SoC glue layer support for\n 177:\t\t the stmmac device driver.\n 178:\t\n 179:\tconfig DWMAC_RZN1\n 180:\t\ttristate \"Renesas RZ/N1 dwmac support\"\n"
} |
| 9/2 | 2026/09/30 01:10 | llm | patch-evaluator |
0mModel:gemini-3.8-flash Args: null Results: null Tokens: input: 13172 output: 45 thoughts: 13 Thoughts: Okay, here's my take on those thoughts, tailored for an expert audience: **Diving into Kconfig: PCI Support** Alright, let's drill down. When I see something like "PCI support," my mind immediately jumps to `Kconfig`. This usually means the system architecture is modular, and I need to figure out the specific configuration options related to PCI devices. I'm thinking, this isn't just a generic statement; there's a particular configuration point somewhere, probably nested within a broader PCI subsystem definition. Now the fun begins: navigating the Kconfig structure to pinpoint the exact variable controlling this "support," understanding its dependencies, and anticipating how different settings will impact the overall system behavior. I'm expecting to find conditional logic tied to hardware platform or other subsystems, which I need to analyze carefully to get a complete picture. Let's get to it! |
| 10/2 | 2026/09/30 01:10 | tool | read-file |
0mArgs:{
"File": "drivers/net/ethernet/stmicro/stmmac/Kconfig",
"FirstLine": 181,
"LineCount": 100
}Results: {
"Contents": " 181:\t\tdefault ARCH_RZN1\n 182:\t\tdepends on OF \u0026\u0026 (ARCH_RZN1 || COMPILE_TEST)\n 183:\t\tselect PCS_RZN1_MIIC\n 184:\t\thelp\n 185:\t\t Support for Ethernet controller on Renesas RZ/N1 SoC family.\n 186:\t\n 187:\t\t This selects the Renesas RZ/N1 SoC glue layer support for\n 188:\t\t the stmmac device driver. This support can make use of a custom MII\n 189:\t\t converter PCS device.\n 190:\t\n 191:\tconfig DWMAC_S32\n 192:\t\ttristate \"NXP S32G/S32R GMAC support\"\n 193:\t\tdefault ARCH_S32\n 194:\t\tdepends on OF \u0026\u0026 (ARCH_S32 || COMPILE_TEST)\n 195:\t\thelp\n 196:\t\t Support for ethernet controller on NXP S32CC SOCs.\n 197:\t\n 198:\t\t This selects NXP SoC glue layer support for the stmmac\n 199:\t\t device driver. This driver is used for the S32CC series\n 200:\t\t SOCs GMAC ethernet controller, ie. S32G2xx, S32G3xx and\n 201:\t\t S32R45.\n 202:\t\n 203:\tconfig DWMAC_SOCFPGA\n 204:\t\ttristate \"SOCFPGA dwmac support\"\n 205:\t\tdefault ARCH_INTEL_SOCFPGA\n 206:\t\tdepends on OF \u0026\u0026 (ARCH_INTEL_SOCFPGA || COMPILE_TEST)\n 207:\t\tselect MFD_SYSCON\n 208:\t\tselect MDIO_REGMAP\n 209:\t\tselect REGMAP_MMIO\n 210:\t\tselect PCS_LYNX\n 211:\t\thelp\n 212:\t\t Support for ethernet controller on Altera SOCFPGA\n 213:\t\n 214:\t\t This selects the Altera SOCFPGA SoC glue layer support\n 215:\t\t for the stmmac device driver. This driver is used for\n 216:\t\t arria5 and cyclone5 FPGA SoCs.\n 217:\t\n 218:\tconfig DWMAC_SOPHGO\n 219:\t\ttristate \"Sophgo dwmac support\"\n 220:\t\tdepends on OF \u0026\u0026 (ARCH_SOPHGO || COMPILE_TEST)\n 221:\t\tdefault m if ARCH_SOPHGO\n 222:\t\thelp\n 223:\t\t Support for ethernet controllers on Sophgo RISC-V SoCs\n 224:\t\n 225:\t\t This selects the Sophgo SoC specific glue layer support\n 226:\t\t for the stmmac device driver. This driver is used for the\n 227:\t\t ethernet controllers on various Sophgo SoCs.\n 228:\t\n 229:\tconfig DWMAC_SPACEMIT\n 230:\t\ttristate \"Spacemit dwmac support\"\n 231:\t\tdepends on OF \u0026\u0026 (ARCH_SPACEMIT || COMPILE_TEST)\n 232:\t\tselect MFD_SYSCON\n 233:\t\tdefault m if ARCH_SPACEMIT\n 234:\t\thelp\n 235:\t\t Support for ethernet controllers on Spacemit RISC-V SoCs\n 236:\t\n 237:\t\t This selects the Spacemit platform specific glue layer support\n 238:\t\t for the stmmac device driver. This driver is used for the\n 239:\t\t Spacemit K3 ethernet controllers.\n 240:\t\n 241:\tconfig DWMAC_STARFIVE\n 242:\t\ttristate \"StarFive dwmac support\"\n 243:\t\tdepends on OF \u0026\u0026 (ARCH_STARFIVE || COMPILE_TEST)\n 244:\t\tselect MFD_SYSCON\n 245:\t\tdefault m if ARCH_STARFIVE\n 246:\t\thelp\n 247:\t\t Support for ethernet controllers on StarFive RISC-V SoCs\n 248:\t\n 249:\t\t This selects the StarFive platform specific glue layer support\n 250:\t\t for the stmmac device driver. This driver is used for the\n 251:\t\t StarFive JH7100 and JH7110 ethernet controllers.\n 252:\t\n 253:\tconfig DWMAC_STI\n 254:\t\ttristate \"STi GMAC support\"\n 255:\t\tdefault ARCH_STI\n 256:\t\tdepends on OF \u0026\u0026 (ARCH_STI || COMPILE_TEST)\n 257:\t\tselect MFD_SYSCON\n 258:\t\thelp\n 259:\t\t Support for ethernet controller on STi SOCs.\n 260:\t\n 261:\t\t This selects STi SoC glue layer support for the stmmac\n 262:\t\t device driver. This driver is used on for the STi series\n 263:\t\t SOCs GMAC ethernet controller.\n 264:\t\n 265:\tconfig DWMAC_STM32\n 266:\t\ttristate \"STM32 DWMAC support\"\n 267:\t\tdefault ARCH_STM32\n 268:\t\tdepends on OF \u0026\u0026 HAS_IOMEM \u0026\u0026 (ARCH_STM32 || COMPILE_TEST)\n 269:\t\tselect MFD_SYSCON\n 270:\t\thelp\n 271:\t\t Support for ethernet controller on STM32 SOCs.\n 272:\t\n 273:\t\t This selects STM32 SoC glue layer support for the stmmac\n 274:\t\t device driver. This driver is used on for the STM32 series\n 275:\t\t SOCs GMAC ethernet controller.\n 276:\t\n 277:\tconfig DWMAC_SUNXI\n 278:\t\ttristate \"Allwinner GMAC support\"\n 279:\t\tdefault ARCH_SUNXI\n 280:\t\tdepends on OF \u0026\u0026 (ARCH_SUNXI || COMPILE_TEST)\n"
} |
| 11/2 | 2026/09/30 01:10 | llm | patch-evaluator |
0mModel:gemini-3.8-flash Args: null Results: null Tokens: input: 14992 output: 44 thoughts: 14 Thoughts: Here's a summary of my thought process, as requested: **Diving into Kconfig: Line 281 and Beyond** Okay, time to get to the heart of the matter. I need to understand this section of the Kconfig file better. My focus is now on starting from line 281 onwards. This suggests a specific area or configuration option that I need to dissect. What exactly is being defined or influenced in this region? Is it a dependency, a feature, a default value? I have to analyze the code from this specific point in the Kconfig file to understand its function and contribution to the overall system build. The goal here is to develop a deep understanding of the configurations. |
| 12/2 | 2026/09/30 01:10 | tool | read-file |
0mArgs:{
"File": "drivers/net/ethernet/stmicro/stmmac/Kconfig",
"FirstLine": 281,
"LineCount": 80
}Results: {
"Contents": " 281:\t\thelp\n 282:\t\t Support for Allwinner A20/A31 GMAC ethernet controllers.\n 283:\t\n 284:\t\t This selects Allwinner SoC glue layer support for the\n 285:\t\t stmmac device driver. This driver is used for A20/A31\n 286:\t\t GMAC ethernet controller.\n 287:\t\n 288:\tconfig DWMAC_SUN8I\n 289:\t\ttristate \"Allwinner sun8i GMAC support\"\n 290:\t\tdefault ARCH_SUNXI\n 291:\t\tdepends on OF \u0026\u0026 (ARCH_SUNXI || COMPILE_TEST)\n 292:\t\tselect MDIO_BUS_MUX\n 293:\t\thelp\n 294:\t\t Support for Allwinner H3 A83T A64 EMAC ethernet controllers.\n 295:\t\n 296:\t\t This selects Allwinner SoC glue layer support for the\n 297:\t\t stmmac device driver. This driver is used for H3/A83T/A64\n 298:\t\t EMAC ethernet controller.\n 299:\t\n 300:\tconfig DWMAC_SUN55I\n 301:\t\ttristate \"Allwinner sun55i GMAC200 support\"\n 302:\t\tdefault ARCH_SUNXI\n 303:\t\tdepends on OF \u0026\u0026 (ARCH_SUNXI || COMPILE_TEST)\n 304:\t\tselect MDIO_BUS_MUX\n 305:\t\thelp\n 306:\t\t Support for Allwinner A523/T527 GMAC200 ethernet controllers.\n 307:\t\n 308:\t\t This selects Allwinner SoC glue layer support for the\n 309:\t\t stmmac device driver. This driver is used for A523/T527\n 310:\t\t GMAC200 ethernet controller.\n 311:\t\n 312:\tconfig DWMAC_THEAD\n 313:\t\ttristate \"T-HEAD dwmac support\"\n 314:\t\tdepends on OF \u0026\u0026 (ARCH_THEAD || COMPILE_TEST)\n 315:\t\thelp\n 316:\t\t Support for ethernet controllers on T-HEAD RISC-V SoCs\n 317:\t\n 318:\t\t This selects the T-HEAD platform specific glue layer support for\n 319:\t\t the stmmac device driver. This driver is used for T-HEAD TH1520\n 320:\t\t ethernet controller.\n 321:\t\n 322:\tconfig DWMAC_IMX8\n 323:\t\ttristate \"NXP IMX8 DWMAC support\"\n 324:\t\tdefault ARCH_MXC\n 325:\t\tdepends on OF \u0026\u0026 (ARCH_MXC || COMPILE_TEST)\n 326:\t\tselect MFD_SYSCON\n 327:\t\thelp\n 328:\t\t Support for ethernet controller on NXP i.MX8 SOCs.\n 329:\t\n 330:\t\t This selects NXP SoC glue layer support for the stmmac\n 331:\t\t device driver. This driver is used for i.MX8 series like\n 332:\t\t iMX8MP/iMX8DXL GMAC ethernet controller.\n 333:\t\n 334:\tconfig DWMAC_INTEL_PLAT\n 335:\t\ttristate \"Intel dwmac support\"\n 336:\t\tdepends on OF \u0026\u0026 COMMON_CLK\n 337:\t\thelp\n 338:\t\t Support for ethernet controllers on Intel SoCs\n 339:\t\n 340:\t\t This selects the Intel platform specific glue layer support for\n 341:\t\t the stmmac device driver. This driver is used for the Intel Keem Bay\n 342:\t\t SoC.\n 343:\t\n 344:\tconfig DWMAC_LOONGSON1\n 345:\t\ttristate \"Loongson1 GMAC support\"\n 346:\t\tdefault MACH_LOONGSON32\n 347:\t\tdepends on OF \u0026\u0026 (MACH_LOONGSON32 || COMPILE_TEST)\n 348:\t\thelp\n 349:\t\t Support for ethernet controller on Loongson1 SoC.\n 350:\t\n 351:\t\t This selects Loongson1 SoC glue layer support for the stmmac\n 352:\t\t device driver. This driver is used for Loongson1-based boards\n 353:\t\t like Loongson LS1B/LS1C.\n 354:\t\n 355:\tconfig DWMAC_TEGRA\n 356:\t\ttristate \"NVIDIA Tegra MGBE support\"\n 357:\t\tdepends on ARCH_TEGRA || COMPILE_TEST\n 358:\t\thelp\n 359:\t\t This selects the Multi-GigaBit Ethernet (MGBE) Controller that is\n 360:\t\t found on the NVIDIA Tegra SoC devices. This driver provides the glue\n"
} |
| 13/2 | 2026/09/30 01:10 | llm | patch-evaluator |
0mModel:gemini-3.8-flash Args: null Results: null Tokens: input: 16484 output: 44 thoughts: 11 Thoughts: Okay, here's the summary, assuming I'm an expert in the field and the "text below" refers to a longer piece of writing, likely technical in nature, where I'm at a specific point (line 361+): **Navigating the Technical Depth** Right, let's keep moving. Line 361... Yes, I remember. This section dives deeper into [mention the specific topic, e.g., the algorithm's complexity analysis, the specific hardware architecture, the specific statistical model]. Given my expertise, I'm already anticipating the nuances here. I'm focusing particularly on [mention specific areas of interest, e.g., the potential edge cases, the implications for scalability, the assumptions being made]. I want to ensure I understand how this theoretical construct translates into practical application. I'll be looking for [mention specific technical terms or concepts, e.g., the impact of the regularization term, the convergence rate under these conditions, how the cache coherency issues are addressed]. Ultimately, I need to verify that their approach aligns with my established understanding of [mention a related area or concept]. Let's see if the authors' assumptions and justifications are sound enough to continue. |
| 14/2 | 2026/09/30 01:10 | tool | read-file |
0mArgs:{
"File": "drivers/net/ethernet/stmicro/stmmac/Kconfig",
"FirstLine": 361,
"LineCount": 80
}Results: {
"Contents": " 361:\t\t layer on top of the stmmac driver required for these NVIDIA Tegra SoC\n 362:\t\t devices.\n 363:\t\n 364:\tconfig DWMAC_VISCONTI\n 365:\t\ttristate \"Toshiba Visconti DWMAC support\"\n 366:\t\tdefault ARCH_VISCONTI\n 367:\t\tdepends on OF \u0026\u0026 COMMON_CLK \u0026\u0026 (ARCH_VISCONTI || COMPILE_TEST)\n 368:\t\thelp\n 369:\t\t Support for ethernet controller on Visconti SoCs.\n 370:\t\n 371:\tendif # STMMAC_PLATFORM\n 372:\t\n 373:\tconfig STMMAC_LIBPCI\n 374:\t\ttristate\n 375:\t\thelp\n 376:\t\t This option enables the PCI bus helpers for the stmmac driver.\n 377:\t\n 378:\tconfig DWMAC_INTEL\n 379:\t\ttristate \"Intel GMAC support\"\n 380:\t\tdefault X86\n 381:\t\tdepends on X86 \u0026\u0026 PCI\n 382:\t\tdepends on COMMON_CLK\n 383:\t\tdepends on ACPI\n 384:\t\thelp\n 385:\t\t This selects the Intel platform specific bus support for the\n 386:\t\t stmmac driver. This driver is used for Intel Quark/EHL/TGL.\n 387:\t\n 388:\tconfig DWMAC_LOONGSON\n 389:\t\ttristate \"Loongson PCI DWMAC support\"\n 390:\t\tdefault MACH_LOONGSON64\n 391:\t\tdepends on (MACH_LOONGSON64 || COMPILE_TEST) \u0026\u0026 PCI\n 392:\t\tdepends on COMMON_CLK\n 393:\t\tselect STMMAC_LIBPCI\n 394:\t\thelp\n 395:\t\t This selects the LOONGSON PCI bus support for the stmmac driver,\n 396:\t\t Support for ethernet controller on Loongson-2K1000 SoC and LS7A1000 bridge.\n 397:\t\n 398:\tconfig DWMAC_MOTORCOMM\n 399:\t\ttristate \"Motorcomm PCI DWMAC support\"\n 400:\t\tdepends on PCI\n 401:\t\tselect MOTORCOMM_PHY\n 402:\t\tselect STMMAC_LIBPCI\n 403:\t\thelp\n 404:\t\t This enables glue driver for Motorcomm DWMAC-based PCI Ethernet\n 405:\t\t controllers. Currently only YT6801 is supported.\n 406:\t\n 407:\tconfig STMMAC_PCI\n 408:\t\ttristate \"STMMAC PCI bus support\"\n 409:\t\tdepends on PCI\n 410:\t\tdepends on COMMON_CLK\n 411:\t\tselect STMMAC_LIBPCI\n 412:\t\thelp\n 413:\t\t This selects the platform specific bus support for the stmmac driver.\n 414:\t\t This driver was tested on XLINX XC2V3000 FF1152AMT0221\n 415:\t\t D1215994A VIRTEX FPGA board and SNPS QoS IPK Prototyping Kit.\n 416:\t\n 417:\t\t If you have a controller with this interface, say Y or M here.\n 418:\t\n 419:\t\t If unsure, say N.\n 420:\tendif # STMMAC_ETH\n"
} |
| 15/2 | 2026/09/30 01:10 | llm | patch-evaluator |
0mModel:gemini-3.8-flash Args: null Results: null Tokens: input: 17703 output: 42 thoughts: 532 Thoughts: **My Assessment of STMMAC Emulation in QEMU for Fuzzing** Okay, let's break this down. I'm looking at these device options: `STMMAC_ETH`, `DWMAC_INTEL`, `STMMAC_PCI`, and others. The core question is: can QEMU *actually* emulate any of these? Specifically, does QEMU have a proper STMMAC or DWMAC emulation, or is it strictly hardware-dependent? I need to know this for the fuzzing setup. My first thought is, does QEMU even *have* STMMAC? I know it has emulated network devices like e1000, rtl8139, virtio-net, and so on. But *specifically* STMMAC or DesignWare? I have to confirm. And, since the target architecture is amd64, are any of the ARM-specific STMMAC emulations irrelevant for this? Then I saw the key excerpt: the fuzzing principle clearly states that "structurally unreachable hardware" – things like vendor-specific PCIe cards not emulated in standard QEMU – are out. This means that if STMMAC is *only* available via specific hardware that isn't emulated in QEMU, then fuzzing is a no-go. So, I need to check. Can I probe `STMMAC_PCI`, `DWMAC_INTEL`, or any platform devices in QEMU given the target architecture? Can these devices be instantiated or are they reliant on physical hardware? To answer this, I'm going to look at the PCI IDs supported by `dwmac-intel.c` and `stmmac_pci.c` to see if there is any reasonable chance of compatibility. |
| 16/2 | 2026/09/30 01:10 | tool | grepper |
0mArgs:{
"Expression": "MODULE_DEVICE_TABLE\\(pci",
"PathPrefix": "drivers/net/ethernet/stmicro/stmmac/"
}Results: {
"Output": "drivers/net/ethernet/stmicro/stmmac/dwmac-intel.c=1395=static const struct pci_device_id intel_eth_pci_id_table[] = {\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-intel.c-1414-};\ndrivers/net/ethernet/stmicro/stmmac/dwmac-intel.c:1415:MODULE_DEVICE_TABLE(pci, intel_eth_pci_id_table);\ndrivers/net/ethernet/stmicro/stmmac/dwmac-intel.c-1416-\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c=596=static const struct pci_device_id loongson_dwmac_id_table[] = {\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c-601-};\ndrivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c:602:MODULE_DEVICE_TABLE(pci, loongson_dwmac_id_table);\ndrivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c-603-\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-motorcomm.c=367=static const struct pci_device_id dwmac_motorcomm_pci_id_table[] = {\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-motorcomm.c-370-};\ndrivers/net/ethernet/stmicro/stmmac/dwmac-motorcomm.c:371:MODULE_DEVICE_TABLE(pci, dwmac_motorcomm_pci_id_table);\ndrivers/net/ethernet/stmicro/stmmac/dwmac-motorcomm.c-372-\n--\ndrivers/net/ethernet/stmicro/stmmac/stmmac_pci.c=203=static const struct pci_device_id stmmac_id_table[] = {\n--\ndrivers/net/ethernet/stmicro/stmmac/stmmac_pci.c-209-\ndrivers/net/ethernet/stmicro/stmmac/stmmac_pci.c:210:MODULE_DEVICE_TABLE(pci, stmmac_id_table);\ndrivers/net/ethernet/stmicro/stmmac/stmmac_pci.c-211-\n"
} |
| 17/2 | 2026/09/30 01:10 | llm | patch-evaluator |
0mModel:gemini-3.8-flash Args: null Results: null Tokens: input: 19294 output: 50 thoughts: 23 Thoughts: Here's my take on those thoughts: **Analyzing Relevant Ethernet Driver Implementations** Okay, so I need to get a handle on the DMA issues we're seeing. To really understand what's going on, I need to look at specific implementations. Let's start with `stmmac_pci.c` and `dwmac-intel.c`. These are good starting points because they represent different architectures and vendors, but are known to be well-maintained and commonly used. Seeing how they handle DMA transactions, descriptor management, interrupt handling, and power management is going to give me a good baseline for comparison and will likely reveal some interesting implementation choices. I'll focus on the data paths and the interaction with the PCI layer in particular. Hopefully, comparing these two will give me insights into where the problem is manifesting in our code. |
| 18/2 | 2026/09/30 01:10 | tool | read-file |
0mArgs:{
"File": "drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c",
"FirstLine": 200,
"LineCount": 20
}Results: {
"Contents": " 200:\t#define PCI_DEVICE_ID_STMMAC_STMMAC\t\t0x1108\n 201:\t#define PCI_DEVICE_ID_SYNOPSYS_GMAC5_ID\t\t0x7102\n 202:\t\n 203:\tstatic const struct pci_device_id stmmac_id_table[] = {\n 204:\t\t{ PCI_DEVICE_DATA(STMMAC, STMMAC, \u0026stmmac_pci_info) },\n 205:\t\t{ PCI_DEVICE_DATA(STMICRO, MAC, \u0026stmmac_pci_info) },\n 206:\t\t{ PCI_DEVICE_DATA(SYNOPSYS, GMAC5_ID, \u0026snps_gmac5_pci_info) },\n 207:\t\t{}\n 208:\t};\n 209:\t\n 210:\tMODULE_DEVICE_TABLE(pci, stmmac_id_table);\n 211:\t\n 212:\tstatic struct pci_driver stmmac_pci_driver = {\n 213:\t\t.name = STMMAC_RESOURCE_NAME,\n 214:\t\t.id_table = stmmac_id_table,\n 215:\t\t.probe = stmmac_pci_probe,\n 216:\t\t.remove = stmmac_pci_remove,\n 217:\t\t.driver = {\n 218:\t\t\t.pm = \u0026stmmac_simple_pm_ops,\n 219:\t\t},\n"
} |
| 19/2 | 2026/09/30 01:10 | llm | patch-evaluator |
0mModel:gemini-3.8-flash Args: null Results: null Tokens: input: 19948 output: 39 thoughts: 1064 Thoughts: **Analyzing the Reachability of STMMAC for Fuzzing** Okay, let's break this down. My primary concern here is whether `stmmac` – specifically the STMicroelectronics/Synopsys DesignWare MAC Ethernet controller – is even reachable within the constraints outlined, especially for amd64 in a standard QEMU or GCE environment. The text's introduction explicitly states that fuzzing should only target code that can execute in these environments. First, QEMU and GCE *do not* emulate `stmmac` or other relevant hardware. They provide alternatives like VirtIO-net, e1000, etc., but nothing that directly corresponds to Synopsys DesignWare GMAC. I know this. Could `stmmac` be instantiated in some unusual way, like through a platform device from userspace or even syzkaller? I need to rule out these possibilities. My initial thought is to check `stmmac_platform.c` and how platform devices generally work, to see if there's any pathway. Can userspace instantiate a platform device without DT/ACPI? Probably not without some kind of supporting mechanism; maybe configfs or something similar. But I recall that configfs support is specific to individual drivers. It's not a generic way to instantiate devices. And mock netdevs, like dummy or veth, are a non-starter; they operate at a different level entirely. Okay, selftests! Perhaps `stmmac` has built-in selftests, and by running them, I can somehow trigger code execution. Let's see... `drivers/net/ethernet/stmicro/stmmac/stmmac_selftests.c`... Ah, yes. The self-test mechanism is triggered via an ethtool selftest on an active stmmac netdev. But a device has to be *probed* before that. This means the stmmac device must be initialized somehow. Now I need to re-read the reachability criteria. The critical part is "Structurally unreachable hardware." This includes "Vendor-specific PCIe switches, SmartNICs..." That makes it very clear that devices requiring physical ASICs or PCIe cards *not* emulated in standard QEMU or GCE are off-limits. Could `stmmac` be probed on amd64 in any way, shape, or form? I need to think systematically. What about how syzkaller handles PCI drivers or Ethernet drivers? Does syzkaller even *emulate* physical PCI cards? No, syzkaller also runs within standard QEMU or GCE VMs. This means the same limitations apply. I know the standard ethernet devices available in standard QEMU/GCE on amd64: VirtIO-net, e1000, and similar. Can stmmac be probed in that configuration? The answer is a clear NO. Does QEMU have an `stmmac` or `dwmac` device model? Let's refresh my memory of QEMU's hardware models. I see some *other* MACs for *ARM* boards – `allwinner-emac`, `cadence_gem`, and similar, but not `dwmac`. But even if it did exist in ARM, the text specifies the *target architecture*: amd64. `stmmac`, for amd64, is found in `drivers/net/ethernet/stmicro/stmmac`. On amd64, I know that DWMAC is associated with Intel Quark, Elkhart Lake, or Tiger Lake SoCs, or Loongson PCI, or FPGA kits. None of these are present or emulated in standard QEMU (q35 or pc) or GCE VMs. So the crucial question is this: can stmmac be probed without any associated hardware? Is there some virtual or software-based or mock probing mechanism? That's what I must check. That's the key to this. |
| 20/2 | 2026/09/30 01:10 | tool | grepper |
0mArgs:{
"Expression": "module_platform_driver",
"PathPrefix": "drivers/net/ethernet/stmicro/stmmac/"
}Results: {
"Output": "drivers/net/ethernet/stmicro/stmmac/dwmac-anarion.c=125=static struct platform_driver anarion_dwmac_driver = {\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-anarion.c-132-};\ndrivers/net/ethernet/stmicro/stmmac/dwmac-anarion.c:133:module_platform_driver(anarion_dwmac_driver);\ndrivers/net/ethernet/stmicro/stmmac/dwmac-anarion.c-134-\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c=361=static struct platform_driver dwc_eth_dwmac_driver = {\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c-369-};\ndrivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c:370:module_platform_driver(dwc_eth_dwmac_driver);\ndrivers/net/ethernet/stmicro/stmmac/dwmac-dwc-qos-eth.c-371-\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-eic7700.c=362=static struct platform_driver eic7700_dwmac_driver = {\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-eic7700.c-369-};\ndrivers/net/ethernet/stmicro/stmmac/dwmac-eic7700.c:370:module_platform_driver(eic7700_dwmac_driver);\ndrivers/net/ethernet/stmicro/stmmac/dwmac-eic7700.c-371-\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-generic.c=69=static struct platform_driver dwmac_generic_driver = {\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-generic.c-76-};\ndrivers/net/ethernet/stmicro/stmmac/dwmac-generic.c:77:module_platform_driver(dwmac_generic_driver);\ndrivers/net/ethernet/stmicro/stmmac/dwmac-generic.c-78-\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-imx.c=392=static struct platform_driver imx_dwmac_driver = {\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-imx.c-400-};\ndrivers/net/ethernet/stmicro/stmmac/dwmac-imx.c:401:module_platform_driver(imx_dwmac_driver);\ndrivers/net/ethernet/stmicro/stmmac/dwmac-imx.c-402-\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-ingenic.c=272=static struct platform_driver ingenic_mac_driver = {\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-ingenic.c-279-};\ndrivers/net/ethernet/stmicro/stmmac/dwmac-ingenic.c:280:module_platform_driver(ingenic_mac_driver);\ndrivers/net/ethernet/stmicro/stmmac/dwmac-ingenic.c-281-\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-intel-plat.c=139=static struct platform_driver intel_eth_plat_driver = {\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-intel-plat.c-147-};\ndrivers/net/ethernet/stmicro/stmmac/dwmac-intel-plat.c:148:module_platform_driver(intel_eth_plat_driver);\ndrivers/net/ethernet/stmicro/stmmac/dwmac-intel-plat.c-149-\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c=497=static struct platform_driver ipq806x_gmac_dwmac_driver = {\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c-505-};\ndrivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c:506:module_platform_driver(ipq806x_gmac_dwmac_driver);\ndrivers/net/ethernet/stmicro/stmmac/dwmac-ipq806x.c-507-\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-loongson1.c=229=static struct platform_driver ls1x_dwmac_driver = {\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-loongson1.c-235-};\ndrivers/net/ethernet/stmicro/stmmac/dwmac-loongson1.c:236:module_platform_driver(ls1x_dwmac_driver);\ndrivers/net/ethernet/stmicro/stmmac/dwmac-loongson1.c-237-\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-lpc18xx.c=77=static struct platform_driver lpc18xx_dwmac_driver = {\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-lpc18xx.c-85-};\ndrivers/net/ethernet/stmicro/stmmac/dwmac-lpc18xx.c:86:module_platform_driver(lpc18xx_dwmac_driver);\ndrivers/net/ethernet/stmicro/stmmac/dwmac-lpc18xx.c-87-\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c=672=static struct platform_driver mediatek_dwmac_driver = {\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c-680-};\ndrivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c:681:module_platform_driver(mediatek_dwmac_driver);\ndrivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c-682-\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-meson.c=82=static struct platform_driver meson6_dwmac_driver = {\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-meson.c-90-};\ndrivers/net/ethernet/stmicro/stmmac/dwmac-meson.c:91:module_platform_driver(meson6_dwmac_driver);\ndrivers/net/ethernet/stmicro/stmmac/dwmac-meson.c-92-\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c=507=static struct platform_driver meson8b_dwmac_driver = {\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c-515-};\ndrivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c:516:module_platform_driver(meson8b_dwmac_driver);\ndrivers/net/ethernet/stmicro/stmmac/dwmac-meson8b.c-517-\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-nuvoton.c=124=static struct platform_driver nvt_dwmac_driver = {\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-nuvoton.c-132-};\ndrivers/net/ethernet/stmicro/stmmac/dwmac-nuvoton.c:133:module_platform_driver(nvt_dwmac_driver);\ndrivers/net/ethernet/stmicro/stmmac/dwmac-nuvoton.c-134-\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c=809=static struct platform_driver qcom_ethqos_driver = {\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c-816-};\ndrivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c:817:module_platform_driver(qcom_ethqos_driver);\ndrivers/net/ethernet/stmicro/stmmac/dwmac-qcom-ethqos.c-818-\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-renesas-gbeth.c=224=static struct platform_driver renesas_gbeth_driver = {\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-renesas-gbeth.c-231-};\ndrivers/net/ethernet/stmicro/stmmac/dwmac-renesas-gbeth.c:232:module_platform_driver(renesas_gbeth_driver);\ndrivers/net/ethernet/stmicro/stmmac/dwmac-renesas-gbeth.c-233-\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-rk.c=1640=static struct platform_driver rk_gmac_dwmac_driver = {\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-rk.c-1647-};\ndrivers/net/ethernet/stmicro/stmmac/dwmac-rk.c:1648:module_platform_driver(rk_gmac_dwmac_driver);\ndrivers/net/ethernet/stmicro/stmmac/dwmac-rk.c-1649-\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-rzn1.c=81=static struct platform_driver rzn1_dwmac_driver = {\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-rzn1.c-88-};\ndrivers/net/ethernet/stmicro/stmmac/dwmac-rzn1.c:89:module_platform_driver(rzn1_dwmac_driver);\ndrivers/net/ethernet/stmicro/stmmac/dwmac-rzn1.c-90-\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-s32.c=222=static struct platform_driver s32_dwmac_driver = {\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-s32.c-230-};\ndrivers/net/ethernet/stmicro/stmmac/dwmac-s32.c:231:module_platform_driver(s32_dwmac_driver);\ndrivers/net/ethernet/stmicro/stmmac/dwmac-s32.c-232-\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c=681=static struct platform_driver socfpga_dwmac_driver = {\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c-688-};\ndrivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c:689:module_platform_driver(socfpga_dwmac_driver);\ndrivers/net/ethernet/stmicro/stmmac/dwmac-socfpga.c-690-\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-sophgo.c=79=static struct platform_driver sophgo_dwmac_driver = {\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-sophgo.c-87-};\ndrivers/net/ethernet/stmicro/stmmac/dwmac-sophgo.c:88:module_platform_driver(sophgo_dwmac_driver);\ndrivers/net/ethernet/stmicro/stmmac/dwmac-sophgo.c-89-\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-spacemit.c=216=static struct platform_driver spacemit_dwmac_driver = {\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-spacemit.c-224-};\ndrivers/net/ethernet/stmicro/stmmac/dwmac-spacemit.c:225:module_platform_driver(spacemit_dwmac_driver);\ndrivers/net/ethernet/stmicro/stmmac/dwmac-spacemit.c-226-\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c=167=static struct platform_driver starfive_dwmac_driver = {\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c-175-};\ndrivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c:176:module_platform_driver(starfive_dwmac_driver);\ndrivers/net/ethernet/stmicro/stmmac/dwmac-starfive.c-177-\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-sti.c=302=static struct platform_driver sti_dwmac_driver = {\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-sti.c-309-};\ndrivers/net/ethernet/stmicro/stmmac/dwmac-sti.c:310:module_platform_driver(sti_dwmac_driver);\ndrivers/net/ethernet/stmicro/stmmac/dwmac-sti.c-311-\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c=671=static struct platform_driver stm32_dwmac_driver = {\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c-679-};\ndrivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c:680:module_platform_driver(stm32_dwmac_driver);\ndrivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c-681-\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-sun55i.c=147=static struct platform_driver sun55i_gmac200_driver = {\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-sun55i.c-154-};\ndrivers/net/ethernet/stmicro/stmmac/dwmac-sun55i.c:155:module_platform_driver(sun55i_gmac200_driver);\ndrivers/net/ethernet/stmicro/stmmac/dwmac-sun55i.c-156-\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c=1285=static struct platform_driver sun8i_dwmac_driver = {\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c-1294-};\ndrivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c:1295:module_platform_driver(sun8i_dwmac_driver);\ndrivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c-1296-\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-sunxi.c=156=static struct platform_driver sun7i_dwmac_driver = {\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-sunxi.c-163-};\ndrivers/net/ethernet/stmicro/stmmac/dwmac-sunxi.c:164:module_platform_driver(sun7i_dwmac_driver);\ndrivers/net/ethernet/stmicro/stmmac/dwmac-sunxi.c-165-\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-tegra.c=405=static struct platform_driver tegra_mgbe_driver = {\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-tegra.c-413-};\ndrivers/net/ethernet/stmicro/stmmac/dwmac-tegra.c:414:module_platform_driver(tegra_mgbe_driver);\ndrivers/net/ethernet/stmicro/stmmac/dwmac-tegra.c-415-\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-thead.c=273=static struct platform_driver thead_dwmac_driver = {\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-thead.c-280-};\ndrivers/net/ethernet/stmicro/stmmac/dwmac-thead.c:281:module_platform_driver(thead_dwmac_driver);\ndrivers/net/ethernet/stmicro/stmmac/dwmac-thead.c-282-\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c=261=static struct platform_driver visconti_eth_dwmac_driver = {\n--\ndrivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c-268-};\ndrivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c:269:module_platform_driver(visconti_eth_dwmac_driver);\ndrivers/net/ethernet/stmicro/stmmac/dwmac-visconti.c-270-\n"
} |
| 21/2 | 2026/09/30 01:10 | llm | patch-evaluator |
0mModel:gemini-3.8-flash Args: null Results: null Tokens: input: 26448 output: 131 thoughts: 1285 Thoughts: **STMMAC Analysis: Unreachable Hardware for Fuzzing** Okay, let's break this down. First, I'm looking at a bunch of platform drivers – Allwinner, Rockchip, Qualcomm, the usual suspects. Then, PCI drivers: Intel's GMAC, Loongson's, Motorcomm's, and STMMAC. Immediately, I'm thinking, none of these are realistically emulated by your typical QEMU or Google Compute Engine VM setup. Now, let's verify against the criteria. "Structurally unreachable hardware" – that's what we're looking for. The document explicitly calls out vendor-specific PCIe switches, SmartNICs, GPU drivers – the stuff that *needs* specific hardware. Is STMMAC in that category? Absolutely. STMMAC, as I understand it, is the Synopsys DesignWare MAC Ethernet controller driver. It's designed for embedded SoCs, but there are specific implementations for Intel, Loongson, and Motorcomm PCI chips. The key here: does a standard virtualized environment *have* STMMAC hardware? No. QEMU doesn't emulate it. No virtual device support, either – no virtio, no loopback, no netlink. This is a *hardware* MAC driver. It's dealing with direct MMIO register access (`writel`, `readl`, etc.), DMA descriptors, and MDIO. See that `vlan_update_hash` function? It's writing directly to `hw->pcsr`, which is a hardware memory-mapped register. So, standard QEMU on amd64 – *no* STMMAC. No emulated hardware. Not through syzkaller's image mount or USB. Not through netdevsim (that's for testing, not real STMMAC use). Next, let's look at the patch itself. What files are touched? Only STMMAC-specific files: `hwif.h`, `stmmac.h`, `stmmac_main.c`, `stmmac_selftests.c`, `stmmac_vlan.c`. These are all *within* the `drivers/net/ethernet/stmicro/stmmac/` directory. Nothing core networking is involved. This is purely the STMMAC driver itself. Therefore, since STMMAC is *exclusively* for physical hardware – SoCs or specialized PCI Ethernet devices – and is not emulated in standard QEMU or GCE environments, it's structurally unreachable. That's the triage philosophy, right? If the code's unreachable in a standard virtual environment, we're not fuzzing it. This is a textbook example of "structurally unreachable hardware". So: * **WorthFuzzing: false** * **EnableConfigs: \[ ]** * **FocusSymbols: \[ ]** * **Reasoning: Concise explanation that the patch exclusively modifies the STMMAC (Synopsys DesignWare Ethernet MAC) driver and its selftests. STMMAC requires physical hardware (specific SoCs or vendor PCI NICs) that is not emulated in standard QEMU or GCE virtual environments on amd64, making the modified code structurally unreachable for fuzzing.** Right, let's confirm the tool call. And call it. |
| 22/2 | 2026/09/30 01:10 | tool | set-results |
0mArgs:{
"EnableConfigs": [],
"FocusSymbols": [],
"Reasoning": "The patch exclusively modifies the STMMAC (Synopsys DesignWare Ethernet MAC) driver and internal selftests in drivers/net/ethernet/stmicro/stmmac/. This driver requires dedicated physical hardware (specific embedded SoCs or vendor PCI NICs such as Intel Elkhart Lake or Motorcomm YT6801) not emulated in standard QEMU or GCE virtualized environments on amd64. Therefore, the modified code is structurally unreachable for fuzzing.",
"WorthFuzzing": false
}Results: {
"EnableConfigs": null,
"FocusSymbols": [],
"Reasoning": "The patch exclusively modifies the STMMAC (Synopsys DesignWare Ethernet MAC) driver and internal selftests in drivers/net/ethernet/stmicro/stmmac/. This driver requires dedicated physical hardware (specific embedded SoCs or vendor PCI NICs such as Intel Elkhart Lake or Motorcomm YT6801) not emulated in standard QEMU or GCE virtualized environments on amd64. Therefore, the modified code is structurally unreachable for fuzzing.",
"WorthFuzzing": false
} |
| 23/1 | 2026/09/30 01:10 | action | If |
0mArgs:{
"WorthFuzzing": false
}Results: null |
| Total Calls | Total Tokens | Avg Tokens | Total Duration (Seconds) | Avg Duration (Seconds) |
|---|
| Total Calls | Total Duration (Seconds) | Avg Duration (Seconds) |
|---|