ocfs2: Slot 0 on device (7,0) was already allocated to this node!
ocfs2: Mounting device (7,0) on (node local, slot 0) with ordered data mode.
======================================================
WARNING: possible circular locking dependency detected
6.16.0-syzkaller-11895-gcca7a0aae895-dirty #0 Not tainted
------------------------------------------------------
syz.0.6418/23308 is trying to acquire lock:
ffff88802c651578 (&oi->ip_xattr_sem){++++}-{4:4}, at: ocfs2_init_acl+0x2f9/0x720

but task is already holding lock:
ffff88810c23c950 (jbd2_handle){++++}-{0:0}, at: start_this_handle+0x1f87/0x21c0

which lock already depends on the new lock.


the existing dependency chain (in reverse order) is:

-> #4 (jbd2_handle){++++}-{0:0}:
       lock_acquire+0x120/0x360
       start_this_handle+0x1fa7/0x21c0
       jbd2__journal_start+0x2c1/0x5b0
       jbd2_journal_start+0x2a/0x40
       ocfs2_start_trans+0x376/0x6d0
       ocfs2_modify_bh+0xe8/0x470
       ocfs2_local_read_info+0x1465/0x17e0
       dquot_load_quota_sb+0x791/0xbd0
       dquot_load_quota_inode+0x2e1/0x5d0
       ocfs2_enable_quotas+0x1c6/0x450
       ocfs2_fill_super+0x50fe/0x63c0
       get_tree_bdev_flags+0x40e/0x4d0
       vfs_get_tree+0x92/0x2b0
       do_new_mount+0x2a2/0x9e0
       __se_sys_mount+0x317/0x410
       do_syscall_64+0xfa/0x3b0
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #3 (&journal->j_trans_barrier){.+.+}-{4:4}:
       lock_acquire+0x120/0x360
       down_read+0x46/0x2e0
       ocfs2_start_trans+0x36a/0x6d0
       ocfs2_modify_bh+0xe8/0x470
       ocfs2_local_read_info+0x1465/0x17e0
       dquot_load_quota_sb+0x791/0xbd0
       dquot_load_quota_inode+0x2e1/0x5d0
       ocfs2_enable_quotas+0x1c6/0x450
       ocfs2_fill_super+0x50fe/0x63c0
       get_tree_bdev_flags+0x40e/0x4d0
       vfs_get_tree+0x92/0x2b0
       do_new_mount+0x2a2/0x9e0
       __se_sys_mount+0x317/0x410
       do_syscall_64+0xfa/0x3b0
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #2 (sb_internal#2){.+.+}-{0:0}:
       reacquire_held_locks+0x127/0x1d0
       lock_release+0x1b4/0x3e0
       up_write+0x2d/0x420
       ocfs2_free_alloc_context+0x97/0x1a0
       ocfs2_write_begin_nolock+0x4296/0x4340
       ocfs2_write_begin+0x1bb/0x310
       generic_perform_write+0x2c5/0x900
       ocfs2_file_write_iter+0x157a/0x1d10
       do_iter_readv_writev+0x56e/0x7f0
       vfs_writev+0x31a/0x960
       __se_sys_pwritev2+0x179/0x290
       do_syscall_64+0xfa/0x3b0
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #1 (&ocfs2_file_ip_alloc_sem_key){++++}-{4:4}:
       lock_acquire+0x120/0x360
       down_write+0x96/0x1f0
       ocfs2_try_remove_refcount_tree+0xb6/0x320
       ocfs2_xattr_set+0x595/0x11f0
       ocfs2_set_acl+0x701/0x7b0
       ocfs2_iop_set_acl+0x1aa/0x2a0
       vfs_set_acl+0x887/0xb00
       filename_setxattr+0x2e0/0x600
       path_setxattrat+0x364/0x3a0
       __x64_sys_setxattr+0xbc/0xe0
       do_syscall_64+0xfa/0x3b0
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&oi->ip_xattr_sem){++++}-{4:4}:
       validate_chain+0xb9b/0x2140
       __lock_acquire+0xab9/0xd20
       lock_acquire+0x120/0x360
       down_read+0x46/0x2e0
       ocfs2_init_acl+0x2f9/0x720
       ocfs2_mknod+0x1321/0x2050
       ocfs2_mkdir+0x191/0x440
       vfs_mkdir+0x306/0x510
       do_mkdirat+0x247/0x590
       __x64_sys_mkdirat+0x87/0xa0
       do_syscall_64+0xfa/0x3b0
       entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
  &oi->ip_xattr_sem --> &journal->j_trans_barrier --> jbd2_handle

 Possible unsafe locking scenario:

       CPU0                    CPU1
       ----                    ----
  rlock(jbd2_handle);
                               lock(&journal->j_trans_barrier);
                               lock(jbd2_handle);
  rlock(&oi->ip_xattr_sem);

 *** DEADLOCK ***

8 locks held by syz.0.6418/23308:
 #0: ffff888118f48428 (sb_writers#29){.+.+}-{0:0}, at: mnt_want_write+0x41/0x90
 #1: ffff88802c651840 (&type->i_mutex_dir_key#20/1){+.+.}-{4:4}, at: filename_create+0x1f8/0x3c0
 #2: ffff88803dcda6c0 (&ocfs2_sysfile_lock_key[INODE_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_reserve_suballoc_bits+0x15e/0x4640
 #3: ffff88802c6560c0 (&ocfs2_sysfile_lock_key[EXTENT_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_reserve_suballoc_bits+0x15e/0x4640
 #4: ffff88803dcdc3c0 (&ocfs2_sysfile_lock_key[LOCAL_ALLOC_SYSTEM_INODE]){+.+.}-{4:4}, at: ocfs2_reserve_local_alloc_bits+0x125/0x24e0
 #5: ffff888118f48618 (sb_internal#2){.+.+}-{0:0}, at: ocfs2_mknod+0xe93/0x2050
 #6: ffff888108a158e8 (&journal->j_trans_barrier){.+.+}-{4:4}, at: ocfs2_start_trans+0x36a/0x6d0
 #7: ffff88810c23c950 (jbd2_handle){++++}-{0:0}, at: start_this_handle+0x1f87/0x21c0

stack backtrace:
CPU: 1 UID: 0 PID: 23308 Comm: syz.0.6418 Not tainted 6.16.0-syzkaller-11895-gcca7a0aae895-dirty #0 PREEMPT(full) 
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.2-debian-1.16.2-1 04/01/2014
Call Trace:
 <TASK>
 dump_stack_lvl+0x189/0x250
 print_circular_bug+0x2ee/0x310
 check_noncircular+0x134/0x160
 validate_chain+0xb9b/0x2140
 __lock_acquire+0xab9/0xd20
 lock_acquire+0x120/0x360
 down_read+0x46/0x2e0
 ocfs2_init_acl+0x2f9/0x720
 ocfs2_mknod+0x1321/0x2050
 ocfs2_mkdir+0x191/0x440
 vfs_mkdir+0x306/0x510
 do_mkdirat+0x247/0x590
 __x64_sys_mkdirat+0x87/0xa0
 do_syscall_64+0xfa/0x3b0
 entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7fceaf18d457
Code: 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 83 c8 ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 44 00 00 b8 02 01 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007fceb00bce68 EFLAGS: 00000246 ORIG_RAX: 0000000000000102
RAX: ffffffffffffffda RBX: 00007fceb00bcef0 RCX: 00007fceaf18d457
RDX: 00000000000001ff RSI: 0000200000002200 RDI: 00000000ffffff9c
RBP: 0000200000000f40 R08: 0000200000000000 R09: 0000000000000000
R10: 0000200000000f40 R11: 0000000000000246 R12: 0000200000002200
R13: 00007fceb00bceb0 R14: 0000000000000000 R15: 0000200000002100
 </TASK>
