| Seq | Timestamp | Type | Name | Duration |
|---|---|---|---|---|
| 0/0 | 2026/07/01 06:49 | flow | patch-triage |
0mArgs:null Results: {
"EnableConfigs": [
"GVE"
],
"FocusSymbols": [
"gve_rx_starvation_timer",
"gve_rx_stop_ring_dqo",
"gve_rx_free_ring_dqo",
"gve_rx_alloc_ring_dqo"
],
"Reasoning": "The patch adds a starvation timer to the RX ring in the GVE driver (Google Virtual Ethernet). This introduces new timer logic and modifies the setup/teardown paths of the RX ring. Since GVE is the primary network interface on GCE (where syzkaller runs), this code is reachable and should be fuzzed.",
"WorthFuzzing": true
} |
| 1/1 | 2026/07/01 06:49 | action | read-patch-diff |
0mArgs:null Results: {
"PatchDiff": "commit afe4c7e432ca8b9da9893ab95b059716fa97370f\nAuthor: syz-cluster \u003ctriage@syzkaller.com\u003e\nDate: Wed Jul 1 06:49:24 2026 +0000\n\n syz-cluster: applied patch under review\n\ndiff --git a/drivers/net/ethernet/google/gve/gve.h b/drivers/net/ethernet/google/gve/gve.h\nindex 1d66d3834f7e6c..3b2f98642e0022 100644\n--- a/drivers/net/ethernet/google/gve/gve.h\n+++ b/drivers/net/ethernet/google/gve/gve.h\n@@ -13,6 +13,7 @@\n #include \u003clinux/netdevice.h\u003e\n #include \u003clinux/net_tstamp.h\u003e\n #include \u003clinux/pci.h\u003e\n+#include \u003clinux/timer.h\u003e\n #include \u003clinux/ptp_clock_kernel.h\u003e\n #include \u003clinux/u64_stats_sync.h\u003e\n #include \u003cnet/page_pool/helpers.h\u003e\n@@ -41,6 +42,7 @@\n \n /* Interval to schedule a stats report update, 20000ms. */\n #define GVE_STATS_REPORT_TIMER_PERIOD\t20000\n+#define GVE_RX_NAPI_RESCHED_MS 20 /* msecs */\n \n /* Numbers of NIC tx/rx stats in stats report. */\n #define NIC_TX_STATS_REPORT_NUM\t0\n@@ -318,6 +320,7 @@ struct gve_rx_ring {\n \tu64 rx_copied_pkt; /* free-running total number of copied packets */\n \tu64 rx_skb_alloc_fail; /* free-running count of skb alloc fails */\n \tu64 rx_buf_alloc_fail; /* free-running count of buffer alloc fails */\n+\tu64 rx_critical_low_bufs; /* count of critical low buffer events */\n \tu64 rx_desc_err_dropped_pkt; /* free-running count of packets dropped by descriptor error */\n \t/* free-running count of unsplit packets due to header buffer overflow or hdr_len is 0 */\n \tu64 rx_hsplit_unsplit_pkt;\n@@ -334,6 +337,7 @@ struct gve_rx_ring {\n \tstruct gve_queue_resources *q_resources; /* head and tail pointer idx */\n \tdma_addr_t q_resources_bus; /* dma address for the queue resources */\n \tstruct u64_stats_sync statss; /* sync stats for 32bit archs */\n+\tstruct timer_list starvation_timer; /* for queue starvation recovery */\n \n \tstruct gve_rx_ctx ctx; /* Info for packet currently being processed in this ring. */\n \ndiff --git a/drivers/net/ethernet/google/gve/gve_ethtool.c b/drivers/net/ethernet/google/gve/gve_ethtool.c\nindex 8199738ba979ee..53fc63313da3a3 100644\n--- a/drivers/net/ethernet/google/gve/gve_ethtool.c\n+++ b/drivers/net/ethernet/google/gve/gve_ethtool.c\n@@ -46,6 +46,7 @@ static const char gve_gstrings_main_stats[][ETH_GSTRING_LEN] = {\n \t\"rx_hsplit_unsplit_pkt\",\n \t\"interface_up_cnt\", \"interface_down_cnt\", \"reset_cnt\",\n \t\"page_alloc_fail\", \"dma_mapping_error\", \"stats_report_trigger_cnt\",\n+\t\"rx_critical_low_bufs\",\n };\n \n static const char gve_gstrings_rx_stats[][ETH_GSTRING_LEN] = {\n@@ -58,6 +59,7 @@ static const char gve_gstrings_rx_stats[][ETH_GSTRING_LEN] = {\n \t\"rx_xdp_aborted[%u]\", \"rx_xdp_drop[%u]\", \"rx_xdp_pass[%u]\",\n \t\"rx_xdp_tx[%u]\", \"rx_xdp_redirect[%u]\",\n \t\"rx_xdp_tx_errors[%u]\", \"rx_xdp_redirect_errors[%u]\", \"rx_xdp_alloc_fails[%u]\",\n+\t\"rx_critical_low_bufs[%u]\",\n };\n \n static const char gve_gstrings_tx_stats[][ETH_GSTRING_LEN] = {\n@@ -151,12 +153,14 @@ gve_get_ethtool_stats(struct net_device *netdev,\n {\n \tu64 tmp_rx_pkts, tmp_rx_hsplit_pkt, tmp_rx_bytes, tmp_rx_hsplit_bytes,\n \t\ttmp_rx_skb_alloc_fail, tmp_rx_buf_alloc_fail,\n+\t\ttmp_rx_critical_low_bufs,\n \t\ttmp_rx_desc_err_dropped_pkt, tmp_rx_hsplit_unsplit_pkt,\n \t\ttmp_tx_pkts, tmp_tx_bytes,\n \t\ttmp_xdp_tx_errors, tmp_xdp_redirect_errors;\n \tu64 rx_buf_alloc_fail, rx_desc_err_dropped_pkt, rx_hsplit_unsplit_pkt,\n \t\trx_pkts, rx_hsplit_pkt, rx_skb_alloc_fail, rx_bytes, tx_pkts, tx_bytes,\n-\t\ttx_dropped, xdp_tx_errors, xdp_redirect_errors;\n+\t\trx_critical_low_bufs, tx_dropped, xdp_tx_errors,\n+\t\txdp_redirect_errors;\n \tint rx_base_stats_idx, max_rx_stats_idx, max_tx_stats_idx;\n \tint stats_idx, stats_region_len, nic_stats_len;\n \tstruct stats *report_stats;\n@@ -197,6 +201,7 @@ gve_get_ethtool_stats(struct net_device *netdev,\n \n \tfor (rx_pkts = 0, rx_bytes = 0, rx_hsplit_pkt = 0,\n \t rx_skb_alloc_fail = 0, rx_buf_alloc_fail = 0,\n+\t rx_critical_low_bufs = 0,\n \t rx_desc_err_dropped_pkt = 0, rx_hsplit_unsplit_pkt = 0,\n \t xdp_tx_errors = 0, xdp_redirect_errors = 0,\n \t ring = 0;\n@@ -212,6 +217,8 @@ gve_get_ethtool_stats(struct net_device *netdev,\n \t\t\t\ttmp_rx_bytes = rx-\u003erbytes;\n \t\t\t\ttmp_rx_skb_alloc_fail = rx-\u003erx_skb_alloc_fail;\n \t\t\t\ttmp_rx_buf_alloc_fail = rx-\u003erx_buf_alloc_fail;\n+\t\t\t\ttmp_rx_critical_low_bufs =\n+\t\t\t\t\trx-\u003erx_critical_low_bufs;\n \t\t\t\ttmp_rx_desc_err_dropped_pkt =\n \t\t\t\t\trx-\u003erx_desc_err_dropped_pkt;\n \t\t\t\ttmp_rx_hsplit_unsplit_pkt =\n@@ -226,6 +233,7 @@ gve_get_ethtool_stats(struct net_device *netdev,\n \t\t\trx_bytes += tmp_rx_bytes;\n \t\t\trx_skb_alloc_fail += tmp_rx_skb_alloc_fail;\n \t\t\trx_buf_alloc_fail += tmp_rx_buf_alloc_fail;\n+\t\t\trx_critical_low_bufs += tmp_rx_critical_low_bufs;\n \t\t\trx_desc_err_dropped_pkt += tmp_rx_desc_err_dropped_pkt;\n \t\t\trx_hsplit_unsplit_pkt += tmp_rx_hsplit_unsplit_pkt;\n \t\t\txdp_tx_errors += tmp_xdp_tx_errors;\n@@ -269,6 +277,7 @@ gve_get_ethtool_stats(struct net_device *netdev,\n \tdata[i++] = priv-\u003epage_alloc_fail;\n \tdata[i++] = priv-\u003edma_mapping_error;\n \tdata[i++] = priv-\u003estats_report_trigger_cnt;\n+\tdata[i++] = rx_critical_low_bufs;\n \ti = GVE_MAIN_STATS_LEN;\n \n \trx_base_stats_idx = 0;\n@@ -333,6 +342,8 @@ gve_get_ethtool_stats(struct net_device *netdev,\n \t\t\t\ttmp_rx_hsplit_bytes = rx-\u003erx_hsplit_bytes;\n \t\t\t\ttmp_rx_skb_alloc_fail = rx-\u003erx_skb_alloc_fail;\n \t\t\t\ttmp_rx_buf_alloc_fail = rx-\u003erx_buf_alloc_fail;\n+\t\t\t\ttmp_rx_critical_low_bufs =\n+\t\t\t\t\trx-\u003erx_critical_low_bufs;\n \t\t\t\ttmp_rx_desc_err_dropped_pkt =\n \t\t\t\t\trx-\u003erx_desc_err_dropped_pkt;\n \t\t\t\ttmp_xdp_tx_errors = rx-\u003exdp_tx_errors;\n@@ -377,6 +388,7 @@ gve_get_ethtool_stats(struct net_device *netdev,\n \t\t\t} while (u64_stats_fetch_retry(\u0026priv-\u003erx[ring].statss,\n \t\t\t\t\t\t start));\n \t\t\ti += GVE_XDP_ACTIONS + 3; /* XDP rx counters */\n+\t\t\tdata[i++] = tmp_rx_critical_low_bufs;\n \t\t}\n \t} else {\n \t\ti += priv-\u003erx_cfg.num_queues * NUM_GVE_RX_CNTS;\ndiff --git a/drivers/net/ethernet/google/gve/gve_rx_dqo.c b/drivers/net/ethernet/google/gve/gve_rx_dqo.c\nindex 02cba280d81a86..303db4fa677b31 100644\n--- a/drivers/net/ethernet/google/gve/gve_rx_dqo.c\n+++ b/drivers/net/ethernet/google/gve/gve_rx_dqo.c\n@@ -18,6 +18,16 @@\n #include \u003cnet/tcp.h\u003e\n #include \u003cnet/xdp_sock_drv.h\u003e\n \n+static void gve_rx_starvation_timer(struct timer_list *t)\n+{\n+\tstruct gve_rx_ring *rx = timer_container_of(rx, t, starvation_timer);\n+\tstruct gve_priv *priv = rx-\u003egve;\n+\tstruct gve_notify_block *block;\n+\n+\tblock = \u0026priv-\u003entfy_blocks[rx-\u003entfy_id];\n+\tnapi_schedule(\u0026block-\u003enapi);\n+}\n+\n static void gve_rx_free_hdr_bufs(struct gve_priv *priv, struct gve_rx_ring *rx)\n {\n \tstruct device *hdev = \u0026priv-\u003epdev-\u003edev;\n@@ -120,6 +130,7 @@ void gve_rx_stop_ring_dqo(struct gve_priv *priv, int idx)\n \n \tif (rx-\u003edqo.page_pool)\n \t\tpage_pool_disable_direct_recycling(rx-\u003edqo.page_pool);\n+\ttimer_delete_sync(\u0026rx-\u003estarvation_timer);\n \tgve_remove_napi(priv, ntfy_idx);\n \tgve_rx_remove_from_block(priv, idx);\n \tgve_rx_reset_ring_dqo(priv, idx);\n@@ -136,6 +147,8 @@ void gve_rx_free_ring_dqo(struct gve_priv *priv, struct gve_rx_ring *rx,\n \tu32 qpl_id;\n \tint i;\n \n+\ttimer_shutdown_sync(\u0026rx-\u003estarvation_timer);\n+\n \tcompletion_queue_slots = rx-\u003edqo.complq.mask + 1;\n \tbuffer_queue_slots = rx-\u003edqo.bufq.mask + 1;\n \n@@ -232,6 +245,7 @@ int gve_rx_alloc_ring_dqo(struct gve_priv *priv,\n \trx-\u003egve = priv;\n \trx-\u003eq_num = idx;\n \trx-\u003epacket_buffer_size = cfg-\u003epacket_buffer_size;\n+\ttimer_setup(\u0026rx-\u003estarvation_timer, gve_rx_starvation_timer, 0);\n \n \tif (cfg-\u003exdp) {\n \t\trx-\u003epacket_buffer_truesize = GVE_XDP_RX_BUFFER_SIZE_DQO;\n@@ -365,6 +379,7 @@ void gve_rx_post_buffers_dqo(struct gve_rx_ring *rx)\n \tstruct gve_rx_compl_queue_dqo *complq = \u0026rx-\u003edqo.complq;\n \tstruct gve_rx_buf_queue_dqo *bufq = \u0026rx-\u003edqo.bufq;\n \tstruct gve_priv *priv = rx-\u003egve;\n+\tu32 num_bufs_avail_to_hw;\n \tu32 num_avail_slots;\n \tu32 num_full_slots;\n \tu32 num_posted = 0;\n@@ -400,6 +415,23 @@ void gve_rx_post_buffers_dqo(struct gve_rx_ring *rx)\n \t}\n \n \trx-\u003efill_cnt += num_posted;\n+\n+\t/* If the queue has fewer than GVE_RX_BUF_THRESH_DQO descriptors\n+\t * visible to the hardware, and no doorbell was written, the hardware\n+\t * is in danger of starving and cannot trigger interrupts. Start the\n+\t * timer to periodically reschedule NAPI and recover from starvation.\n+\t */\n+\tnum_bufs_avail_to_hw =\n+\t\t((bufq-\u003etail \u0026 ~(GVE_RX_BUF_THRESH_DQO - 1)) -\n+\t\t bufq-\u003ehead) \u0026 bufq-\u003emask;\n+\n+\tif (num_bufs_avail_to_hw \u003c GVE_RX_BUF_THRESH_DQO) {\n+\t\tu64_stats_update_begin(\u0026rx-\u003estatss);\n+\t\trx-\u003erx_critical_low_bufs++;\n+\t\tu64_stats_update_end(\u0026rx-\u003estatss);\n+\t\tmod_timer(\u0026rx-\u003estarvation_timer,\n+\t\t\t jiffies + msecs_to_jiffies(GVE_RX_NAPI_RESCHED_MS));\n+\t}\n }\n \n static void gve_rx_skb_csum(struct sk_buff *skb,\n"
} |
| 2/1 | 2026/07/01 06:49 | agent | patch-evaluator |
0mModel:gemini-3.1-pro-preview Args: null Results: {
"EnableConfigs": [
"GVE"
],
"FocusSymbols": [
"gve_rx_starvation_timer",
"gve_rx_stop_ring_dqo",
"gve_rx_free_ring_dqo",
"gve_rx_alloc_ring_dqo"
],
"Reasoning": "The patch adds a starvation timer to the RX ring in the GVE driver (Google Virtual Ethernet). This introduces new timer logic and modifies the setup/teardown paths of the RX ring. Since GVE is the primary network interface on GCE (where syzkaller runs), this code is reachable and should be fuzzed.",
"WorthFuzzing": true
}Instruction: You are an expert Linux kernel maintainer. Your job is to review a provided patch series and determine if it makes functional changes to the kernel that should be fuzzed. IMPORTANT: The changes have ALREADY been applied and committed as the HEAD commit in your workspace. Do NOT rely on your internal knowledge of the kernel. You must actively use your code access tools to examine the actual source code and confirm any assumptions. Return WorthFuzzing=false if the patch only contains: - Modifications to Documentation/, Kconfig files, or code comments. - Purely decorative changes, such as logging (e.g., pr_err, printk) or tracepoints. - Changes to numeric constants or macros that do not functionally alter execution flow. - Code paths that are impossible to reach in virtualized environments like GCE or QEMU, even when utilizing software-emulated hardware (e.g., usb gadget, mac80211_hwsim). If it modifies reachable core kernel logic, drivers, or architectures, use your code search tools to verify the code can be executed, then return WorthFuzzing=true. When returning WorthFuzzing=true, you MUST ALSO: 1. Extract any specific kernel functions that should be heavily fuzzed into FocusSymbols. Avoid listing generic hot-path functions to prevent skewed test distributions. 2. Identify any specific CONFIG_ options required to properly test this new/modified feature. Go and look into the Kconfig files and check for ifdefs around the code, do not make assumptions. Do not list too generic configs (we already have them enabled). Only list those that specifically cover the modified code. List them in the EnableConfigs output array, and DO NOT add a 'CONFIG_' prefix (e.g., return "NET_IPV4" instead of "CONFIG_NET_IPV4"). Prefer calling several tools at the same time to save round-trips. Use set-results tool to provide results of the analysis. It must be called exactly once before the final reply. Ignore results of this tool. Prompt: For your convenience, here is the diff of the changes:
commit afe4c7e432ca8b9da9893ab95b059716fa97370f
Author: syz-cluster <triage@syzkaller.com>
Date: Wed Jul 1 06:49:24 2026 +0000
syz-cluster: applied patch under review
diff --git a/drivers/net/ethernet/google/gve/gve.h b/drivers/net/ethernet/google/gve/gve.h
index 1d66d3834f7e6c..3b2f98642e0022 100644
--- a/drivers/net/ethernet/google/gve/gve.h
+++ b/drivers/net/ethernet/google/gve/gve.h
@@ -13,6 +13,7 @@
#include <linux/netdevice.h>
#include <linux/net_tstamp.h>
#include <linux/pci.h>
+#include <linux/timer.h>
#include <linux/ptp_clock_kernel.h>
#include <linux/u64_stats_sync.h>
#include <net/page_pool/helpers.h>
@@ -41,6 +42,7 @@
/* Interval to schedule a stats report update, 20000ms. */
#define GVE_STATS_REPORT_TIMER_PERIOD 20000
+#define GVE_RX_NAPI_RESCHED_MS 20 /* msecs */
/* Numbers of NIC tx/rx stats in stats report. */
#define NIC_TX_STATS_REPORT_NUM 0
@@ -318,6 +320,7 @@ struct gve_rx_ring {
u64 rx_copied_pkt; /* free-running total number of copied packets */
u64 rx_skb_alloc_fail; /* free-running count of skb alloc fails */
u64 rx_buf_alloc_fail; /* free-running count of buffer alloc fails */
+ u64 rx_critical_low_bufs; /* count of critical low buffer events */
u64 rx_desc_err_dropped_pkt; /* free-running count of packets dropped by descriptor error */
/* free-running count of unsplit packets due to header buffer overflow or hdr_len is 0 */
u64 rx_hsplit_unsplit_pkt;
@@ -334,6 +337,7 @@ struct gve_rx_ring {
struct gve_queue_resources *q_resources; /* head and tail pointer idx */
dma_addr_t q_resources_bus; /* dma address for the queue resources */
struct u64_stats_sync statss; /* sync stats for 32bit archs */
+ struct timer_list starvation_timer; /* for queue starvation recovery */
struct gve_rx_ctx ctx; /* Info for packet currently being processed in this ring. */
diff --git a/drivers/net/ethernet/google/gve/gve_ethtool.c b/drivers/net/ethernet/google/gve/gve_ethtool.c
index 8199738ba979ee..53fc63313da3a3 100644
--- a/drivers/net/ethernet/google/gve/gve_ethtool.c
+++ b/drivers/net/ethernet/google/gve/gve_ethtool.c
@@ -46,6 +46,7 @@ static const char gve_gstrings_main_stats[][ETH_GSTRING_LEN] = {
"rx_hsplit_unsplit_pkt",
"interface_up_cnt", "interface_down_cnt", "reset_cnt",
"page_alloc_fail", "dma_mapping_error", "stats_report_trigger_cnt",
+ "rx_critical_low_bufs",
};
static const char gve_gstrings_rx_stats[][ETH_GSTRING_LEN] = {
@@ -58,6 +59,7 @@ static const char gve_gstrings_rx_stats[][ETH_GSTRING_LEN] = {
"rx_xdp_aborted[%u]", "rx_xdp_drop[%u]", "rx_xdp_pass[%u]",
"rx_xdp_tx[%u]", "rx_xdp_redirect[%u]",
"rx_xdp_tx_errors[%u]", "rx_xdp_redirect_errors[%u]", "rx_xdp_alloc_fails[%u]",
+ "rx_critical_low_bufs[%u]",
};
static const char gve_gstrings_tx_stats[][ETH_GSTRING_LEN] = {
@@ -151,12 +153,14 @@ gve_get_ethtool_stats(struct net_device *netdev,
{
u64 tmp_rx_pkts, tmp_rx_hsplit_pkt, tmp_rx_bytes, tmp_rx_hsplit_bytes,
tmp_rx_skb_alloc_fail, tmp_rx_buf_alloc_fail,
+ tmp_rx_critical_low_bufs,
tmp_rx_desc_err_dropped_pkt, tmp_rx_hsplit_unsplit_pkt,
tmp_tx_pkts, tmp_tx_bytes,
tmp_xdp_tx_errors, tmp_xdp_redirect_errors;
u64 rx_buf_alloc_fail, rx_desc_err_dropped_pkt, rx_hsplit_unsplit_pkt,
rx_pkts, rx_hsplit_pkt, rx_skb_alloc_fail, rx_bytes, tx_pkts, tx_bytes,
- tx_dropped, xdp_tx_errors, xdp_redirect_errors;
+ rx_critical_low_bufs, tx_dropped, xdp_tx_errors,
+ xdp_redirect_errors;
int rx_base_stats_idx, max_rx_stats_idx, max_tx_stats_idx;
int stats_idx, stats_region_len, nic_stats_len;
struct stats *report_stats;
@@ -197,6 +201,7 @@ gve_get_ethtool_stats(struct net_device *netdev,
for (rx_pkts = 0, rx_bytes = 0, rx_hsplit_pkt = 0,
rx_skb_alloc_fail = 0, rx_buf_alloc_fail = 0,
+ rx_critical_low_bufs = 0,
rx_desc_err_dropped_pkt = 0, rx_hsplit_unsplit_pkt = 0,
xdp_tx_errors = 0, xdp_redirect_errors = 0,
ring = 0;
@@ -212,6 +217,8 @@ gve_get_ethtool_stats(struct net_device *netdev,
tmp_rx_bytes = rx->rbytes;
tmp_rx_skb_alloc_fail = rx->rx_skb_alloc_fail;
tmp_rx_buf_alloc_fail = rx->rx_buf_alloc_fail;
+ tmp_rx_critical_low_bufs =
+ rx->rx_critical_low_bufs;
tmp_rx_desc_err_dropped_pkt =
rx->rx_desc_err_dropped_pkt;
tmp_rx_hsplit_unsplit_pkt =
@@ -226,6 +233,7 @@ gve_get_ethtool_stats(struct net_device *netdev,
rx_bytes += tmp_rx_bytes;
rx_skb_alloc_fail += tmp_rx_skb_alloc_fail;
rx_buf_alloc_fail += tmp_rx_buf_alloc_fail;
+ rx_critical_low_bufs += tmp_rx_critical_low_bufs;
rx_desc_err_dropped_pkt += tmp_rx_desc_err_dropped_pkt;
rx_hsplit_unsplit_pkt += tmp_rx_hsplit_unsplit_pkt;
xdp_tx_errors += tmp_xdp_tx_errors;
@@ -269,6 +277,7 @@ gve_get_ethtool_stats(struct net_device *netdev,
data[i++] = priv->page_alloc_fail;
data[i++] = priv->dma_mapping_error;
data[i++] = priv->stats_report_trigger_cnt;
+ data[i++] = rx_critical_low_bufs;
i = GVE_MAIN_STATS_LEN;
rx_base_stats_idx = 0;
@@ -333,6 +342,8 @@ gve_get_ethtool_stats(struct net_device *netdev,
tmp_rx_hsplit_bytes = rx->rx_hsplit_bytes;
tmp_rx_skb_alloc_fail = rx->rx_skb_alloc_fail;
tmp_rx_buf_alloc_fail = rx->rx_buf_alloc_fail;
+ tmp_rx_critical_low_bufs =
+ rx->rx_critical_low_bufs;
tmp_rx_desc_err_dropped_pkt =
rx->rx_desc_err_dropped_pkt;
tmp_xdp_tx_errors = rx->xdp_tx_errors;
@@ -377,6 +388,7 @@ gve_get_ethtool_stats(struct net_device *netdev,
} while (u64_stats_fetch_retry(&priv->rx[ring].statss,
start));
i += GVE_XDP_ACTIONS + 3; /* XDP rx counters */
+ data[i++] = tmp_rx_critical_low_bufs;
}
} else {
i += priv->rx_cfg.num_queues * NUM_GVE_RX_CNTS;
diff --git a/drivers/net/ethernet/google/gve/gve_rx_dqo.c b/drivers/net/ethernet/google/gve/gve_rx_dqo.c
index 02cba280d81a86..303db4fa677b31 100644
--- a/drivers/net/ethernet/google/gve/gve_rx_dqo.c
+++ b/drivers/net/ethernet/google/gve/gve_rx_dqo.c
@@ -18,6 +18,16 @@
#include <net/tcp.h>
#include <net/xdp_sock_drv.h>
+static void gve_rx_starvation_timer(struct timer_list *t)
+{
+ struct gve_rx_ring *rx = timer_container_of(rx, t, starvation_timer);
+ struct gve_priv *priv = rx->gve;
+ struct gve_notify_block *block;
+
+ block = &priv->ntfy_blocks[rx->ntfy_id];
+ napi_schedule(&block->napi);
+}
+
static void gve_rx_free_hdr_bufs(struct gve_priv *priv, struct gve_rx_ring *rx)
{
struct device *hdev = &priv->pdev->dev;
@@ -120,6 +130,7 @@ void gve_rx_stop_ring_dqo(struct gve_priv *priv, int idx)
if (rx->dqo.page_pool)
page_pool_disable_direct_recycling(rx->dqo.page_pool);
+ timer_delete_sync(&rx->starvation_timer);
gve_remove_napi(priv, ntfy_idx);
gve_rx_remove_from_block(priv, idx);
gve_rx_reset_ring_dqo(priv, idx);
@@ -136,6 +147,8 @@ void gve_rx_free_ring_dqo(struct gve_priv *priv, struct gve_rx_ring *rx,
u32 qpl_id;
int i;
+ timer_shutdown_sync(&rx->starvation_timer);
+
completion_queue_slots = rx->dqo.complq.mask + 1;
buffer_queue_slots = rx->dqo.bufq.mask + 1;
@@ -232,6 +245,7 @@ int gve_rx_alloc_ring_dqo(struct gve_priv *priv,
rx->gve = priv;
rx->q_num = idx;
rx->packet_buffer_size = cfg->packet_buffer_size;
+ timer_setup(&rx->starvation_timer, gve_rx_starvation_timer, 0);
if (cfg->xdp) {
rx->packet_buffer_truesize = GVE_XDP_RX_BUFFER_SIZE_DQO;
@@ -365,6 +379,7 @@ void gve_rx_post_buffers_dqo(struct gve_rx_ring *rx)
struct gve_rx_compl_queue_dqo *complq = &rx->dqo.complq;
struct gve_rx_buf_queue_dqo *bufq = &rx->dqo.bufq;
struct gve_priv *priv = rx->gve;
+ u32 num_bufs_avail_to_hw;
u32 num_avail_slots;
u32 num_full_slots;
u32 num_posted = 0;
@@ -400,6 +415,23 @@ void gve_rx_post_buffers_dqo(struct gve_rx_ring *rx)
}
rx->fill_cnt += num_posted;
+
+ /* If the queue has fewer than GVE_RX_BUF_THRESH_DQO descriptors
+ * visible to the hardware, and no doorbell was written, the hardware
+ * is in danger of starving and cannot trigger interrupts. Start the
+ * timer to periodically reschedule NAPI and recover from starvation.
+ */
+ num_bufs_avail_to_hw =
+ ((bufq->tail & ~(GVE_RX_BUF_THRESH_DQO - 1)) -
+ bufq->head) & bufq->mask;
+
+ if (num_bufs_avail_to_hw < GVE_RX_BUF_THRESH_DQO) {
+ u64_stats_update_begin(&rx->statss);
+ rx->rx_critical_low_bufs++;
+ u64_stats_update_end(&rx->statss);
+ mod_timer(&rx->starvation_timer,
+ jiffies + msecs_to_jiffies(GVE_RX_NAPI_RESCHED_MS));
+ }
}
static void gve_rx_skb_csum(struct sk_buff *skb,
|
| 3/2 | 2026/07/01 06:49 | llm | patch-evaluator |
0mModel:gemini-3.1-pro-preview Args: null Results: null Tokens: input: 5315 output: 32 thoughts: 114 Thoughts: **Analyzing the GVE Driver Patch** Okay, so we have a new patch targeting the `gve` driver, specifically addressing the RX ring in DQO (Direct Queue Offload) mode. This looks like a solid functional change. The core of the patch is adding a starvation timer. Essentially, it's a mechanism to kickstart NAPI rescheduling when the driver's buffers are critically low. That should help address potential RX starvation issues. Now, before I dive deeper into the code, I need to understand the configuration landscape. I want to check the compile-time options for the `gve` driver. I'll need to figure out which configurations might influence or be influenced by this change. Let's use `grepper` to quickly scan `drivers/net/ethernet/google/Kconfig` and see what the options are. I expect to find some options related to DQO and RX buffer management in there. Knowing the Kconfig options will really help me determine the impact and integration with existing settings. |
| 4/2 | 2026/07/01 06:49 | tool | grepper |
0mArgs:{
"Expression": "config GVE",
"PathPrefix": "drivers/net/ethernet/google/"
}Results: {
"Output": "drivers/net/ethernet/google/Kconfig=16=if NET_VENDOR_GOOGLE\ndrivers/net/ethernet/google/Kconfig-17-\ndrivers/net/ethernet/google/Kconfig:18:config GVE\ndrivers/net/ethernet/google/Kconfig-19-\ttristate \"Google Virtual NIC (gVNIC) support\"\n"
} |
| 5/2 | 2026/07/01 06:49 | llm | patch-evaluator |
0mModel:gemini-3.1-pro-preview Args: null Results: null Tokens: input: 5774 output: 41 thoughts: 515 Thoughts: **GVE Patch Assessment** Okay, so the config is `GVE`. Let's see what's changed. The patch introduces a new function, `gve_rx_starvation_timer`, along with a few others related to the receive path: `gve_rx_stop_ring_dqo`, `gve_rx_free_ring_dqo`, and `gve_rx_alloc_ring_dqo`, and `gve_rx_post_buffers_dqo`. I need to figure out if this is fuzzable. `gve_rx_post_buffers_dqo` is probably a hot path since it's used to post buffers, likely in the NAPI poll loop, so it's worth a look. `gve_rx_starvation_timer` is just a timer callback, so it's not a performance bottleneck. The other three look like control path functions. This patch is adding a timer to address queue starvation. Hmm, worth fuzzing? Let's see... it's a network driver for Google Virtual Ethernet. It's virtual, but it's a PCI device, which opens things up a bit. Can syzkaller get to this? Syzkaller doesn't have a GVE emulator, but it can fuzz the control path (ethtool, netlink, etc.), maybe even the PCI side if that's supported. Wait, hold on... the instructions say to return `WorthFuzzing=false` if it's *impossible* to reach in virtualized environments like GCE or QEMU, even with software emulation. But GVE is Google Virtual NIC, used in Google Cloud (GCE). Wait a second, and the documentation says that syzkaller runs in GCE! This is the primary network interface in syzkaller's GCE instances! So it *is* reachable and actively used in GCE, and that's the primary environment syzkaller runs in. If I fuzz it, it might break the network connection, but syzkaller usually uses a serial console for GCE, or maybe it doesn't matter, we just need to know if it's reachable. Definitely reachable in GCE. Alright, now let's dig into `gve_rx_starvation_timer`. |
| 6/2 | 2026/07/01 06:49 | tool | grepper |
0mArgs:{
"Expression": "gve_rx_starvation_timer",
"PathPrefix": "drivers/net/ethernet/google/gve/"
}Results: {
"Output": "drivers/net/ethernet/google/gve/gve_rx_dqo.c-20-\ndrivers/net/ethernet/google/gve/gve_rx_dqo.c:21:static void gve_rx_starvation_timer(struct timer_list *t)\ndrivers/net/ethernet/google/gve/gve_rx_dqo.c-22-{\n--\ndrivers/net/ethernet/google/gve/gve_rx_dqo.c=229=int gve_rx_alloc_ring_dqo(struct gve_priv *priv,\n--\ndrivers/net/ethernet/google/gve/gve_rx_dqo.c-247-\trx-\u003epacket_buffer_size = cfg-\u003epacket_buffer_size;\ndrivers/net/ethernet/google/gve/gve_rx_dqo.c:248:\ttimer_setup(\u0026rx-\u003estarvation_timer, gve_rx_starvation_timer, 0);\ndrivers/net/ethernet/google/gve/gve_rx_dqo.c-249-\n"
} |
| 7/2 | 2026/07/01 06:49 | llm | patch-evaluator |
0mModel:gemini-3.1-pro-preview Args: null Results: null Tokens: input: 7106 output: 32 thoughts: 247 Thoughts: **Focusing on RX Ring Management** Okay, so I need to zero in on these functions: `gve_rx_starvation_timer`, `gve_rx_stop_ring_dqo`, `gve_rx_free_ring_dqo`, and `gve_rx_alloc_ring_dqo`. Wait a minute, I need to keep in mind that `gve_rx_post_buffers_dqo` is probably on the hot path. Let's make sure that's not involved here. Ah yes, `gve_rx_starvation_timer` is the timer callback. The other three are clearly setup/teardown related. Alright, let's verify if `gve_rx_starvation_timer` is static – yes, it is. Given that, I'm confident I should include `gve_rx_starvation_timer`, along with `gve_rx_stop_ring_dqo`, `gve_rx_free_ring_dqo`, and `gve_rx_alloc_ring_dqo`. I'll double-check that `GVE` is the only config to keep this straightforward. |
| 8/2 | 2026/07/01 06:49 | tool | grepper |
0mArgs:{
"Expression": "config GVE",
"PathPrefix": "drivers/net/ethernet/google/"
}Results: {
"Output": "drivers/net/ethernet/google/Kconfig=16=if NET_VENDOR_GOOGLE\ndrivers/net/ethernet/google/Kconfig-17-\ndrivers/net/ethernet/google/Kconfig:18:config GVE\ndrivers/net/ethernet/google/Kconfig-19-\ttristate \"Google Virtual NIC (gVNIC) support\"\n"
} |
| 9/2 | 2026/07/01 06:49 | llm | patch-evaluator |
0mModel:gemini-3.1-pro-preview Args: null Results: null Tokens: input: 7742 output: 43 thoughts: 59 Thoughts: Okay, here's my interpretation of those thoughts, tailored for an expert audience, presented in the first person: **Navigating the Configuration and Allocation Logic** Right, so `GVE` is definitely the key configuration item here. That's a given. But hang on... I need to double-check something regarding `gve_rx_alloc_ring_dqo`. It's used when we're allocating rings for the DQO format, isn't it? My immediate question is whether DQO is the *default* behavior, or if it requires a specific configuration flag or setting. I need to understand that dependency to fully grasp how allocation is handled and what might trigger the use of that function. I'll need to dig into the documentation and codebase to see if DQO is enabled implicitly, or if it is a configurable option. |
| 10/2 | 2026/07/01 06:49 | tool | grepper |
0mArgs:{
"Expression": "gve_rx_alloc_ring_dqo",
"PathPrefix": "drivers/net/ethernet/google/gve/"
}Results: {
"Output": "drivers/net/ethernet/google/gve/gve_dqo.h=49=void gve_tx_stop_ring_dqo(struct gve_priv *priv, int idx);\ndrivers/net/ethernet/google/gve/gve_dqo.h:50:int gve_rx_alloc_ring_dqo(struct gve_priv *priv,\ndrivers/net/ethernet/google/gve/gve_dqo.h-51-\t\t\t struct gve_rx_alloc_rings_cfg *cfg,\n--\ndrivers/net/ethernet/google/gve/gve_main.c=2662=static int gve_rx_queue_mem_alloc(struct net_device *dev,\n--\ndrivers/net/ethernet/google/gve/gve_main.c-2679-\telse\ndrivers/net/ethernet/google/gve/gve_main.c:2680:\t\terr = gve_rx_alloc_ring_dqo(priv, \u0026cfg, gve_per_q_mem, idx);\ndrivers/net/ethernet/google/gve/gve_main.c-2681-\n--\ndrivers/net/ethernet/google/gve/gve_rx_dqo.c=221=void gve_rx_start_ring_dqo(struct gve_priv *priv, int idx)\n--\ndrivers/net/ethernet/google/gve/gve_rx_dqo.c-228-\ndrivers/net/ethernet/google/gve/gve_rx_dqo.c:229:int gve_rx_alloc_ring_dqo(struct gve_priv *priv,\ndrivers/net/ethernet/google/gve/gve_rx_dqo.c-230-\t\t\t struct gve_rx_alloc_rings_cfg *cfg,\n--\ndrivers/net/ethernet/google/gve/gve_rx_dqo.c=330=int gve_rx_alloc_rings_dqo(struct gve_priv *priv,\n--\ndrivers/net/ethernet/google/gve/gve_rx_dqo.c-341-\tfor (i = 0; i \u003c cfg-\u003eqcfg_rx-\u003enum_queues; i++) {\ndrivers/net/ethernet/google/gve/gve_rx_dqo.c:342:\t\terr = gve_rx_alloc_ring_dqo(priv, cfg, \u0026rx[i], i);\ndrivers/net/ethernet/google/gve/gve_rx_dqo.c-343-\t\tif (err) {\n"
} |
| 11/2 | 2026/07/01 06:49 | llm | patch-evaluator |
0mModel:gemini-3.1-pro-preview Args: null Results: null Tokens: input: 8687 output: 156 thoughts: 220 Thoughts: **Fuzzing Strategy for GVE RX Ring Starvation** Okay, let's break this down. My analysis points directly to the `gve_rx_queue_mem_alloc` or `gve_rx_alloc_rings_dqo` functions. The connection to DQO format and an active device makes this code path highly probable. Considering GVE's role as *the* network interface for Google Compute Engine (GCE), where syzkaller is actively deployed, I'm confident that these functions are actively hit during normal operation. This makes them a prime target. Therefore, I'm marking `WorthFuzzing` as `true`. I'll want to home in on some key symbols, including `gve_rx_starvation_timer`, which is crucial given the patch's focus on the new timer logic, as well as `gve_rx_stop_ring_dqo`, `gve_rx_free_ring_dqo`, and `gve_rx_alloc_ring_dqo` which will be essential in testing the related code path modifications to the RX ring. Of course, the `GVE` configuration must be enabled. The reasoning is clear: the patch specifically introduces a starvation timer for the RX ring within the GVE driver. This means new timer-related logic and changes to the RX ring's setup and teardown phases are present. Since syzkaller runs in GCE, and GVE is the primary network interface, this newly added code is absolutely reachable and demands thorough fuzzing. |
| 12/2 | 2026/07/01 06:49 | tool | set-results |
0mArgs:{
"EnableConfigs": [
"GVE"
],
"FocusSymbols": [
"gve_rx_starvation_timer",
"gve_rx_stop_ring_dqo",
"gve_rx_free_ring_dqo",
"gve_rx_alloc_ring_dqo"
],
"Reasoning": "The patch adds a starvation timer to the RX ring in the GVE driver (Google Virtual Ethernet). This introduces new timer logic and modifies the setup/teardown paths of the RX ring. Since GVE is the primary network interface on GCE (where syzkaller runs), this code is reachable and should be fuzzed.",
"WorthFuzzing": true
}Results: {
"EnableConfigs": [
"GVE"
],
"FocusSymbols": [
"gve_rx_starvation_timer",
"gve_rx_stop_ring_dqo",
"gve_rx_free_ring_dqo",
"gve_rx_alloc_ring_dqo"
],
"Reasoning": "The patch adds a starvation timer to the RX ring in the GVE driver (Google Virtual Ethernet). This introduces new timer logic and modifies the setup/teardown paths of the RX ring. Since GVE is the primary network interface on GCE (where syzkaller runs), this code is reachable and should be fuzzed.",
"WorthFuzzing": true
} |
| Total Calls | Total Tokens | Avg Tokens | Total Duration (Seconds) | Avg Duration (Seconds) |
|---|
| Total Calls | Total Duration (Seconds) | Avg Duration (Seconds) |
|---|