| Seq | Timestamp | Type | Name | Duration |
|---|---|---|---|---|
| 0/0 | 2026/08/16 06:45 | flow | patch-triage |
0mArgs:null Results: {
"EnableConfigs": null,
"FocusSymbols": [],
"KMSANReasoning": "",
"NeedsKMSAN": false,
"Reasoning": "The patch modifies the SDIO interface of the Broadcom brcmfmac wireless driver. This code requires physical Broadcom SDIO Wi-Fi hardware to be present and cannot be reached in standard virtualized environments like QEMU or GCE.",
"WorthFuzzing": false
} |
| 1/1 | 2026/08/16 06:45 | action | read-patch-diff |
0mArgs:null Results: {
"PatchDiff": "commit f7759f3e43796997bbf5a078c1f56f1f08762338\nAuthor: syz-cluster \u003ctriage@syzkaller.com\u003e\nDate: Sun Aug 16 06:45:03 2026 +0000\n\n syz-cluster: applied patch under review\n\ndiff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c\nindex 381801af3ac98..3850535bfdb02 100644\n--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c\n+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c\n@@ -770,6 +770,28 @@ brcmf_sdio_kso_control(struct brcmf_sdio *bus, bool on)\n \tif (try_cnt \u003e MAX_KSO_ATTEMPTS)\n \t\tbrcmf_err(\"max tries: rd_val=0x%x err=%d\\n\", rd_val, err);\n \n+\t/* A wake attempt that gives up (whether by exhausting the KSO\n+\t * retries or by bailing out on consecutive access errors) with the\n+\t * sleep CSR reading back all-ones means the device has dropped off\n+\t * the bus entirely, e.g. it lost state across a system suspend\n+\t * despite keep-power-in-suspend (observed on CYW43455/BCM4345C0 on\n+\t * rk3566). No in-band recovery is possible: the interface is gone\n+\t * and a module reload fails to re-probe (-ETIMEDOUT on every\n+\t * function). The bus reset worker already performs the only known\n+\t * remedy (mmc_hw_reset -\u003e pwrseq WL_REG_ON power cycle), but its\n+\t * sole SDIO trigger is the firmware-halt mailbox interrupt, which\n+\t * a chip that is off the bus can never deliver. Schedule it from\n+\t * here instead.\n+\t */\n+\tif (on \u0026\u0026 err \u0026\u0026 rd_val == 0xff) {\n+\t\tstruct brcmf_pub *drvr = bus-\u003esdiodev-\u003ebus_if-\u003edrvr;\n+\n+\t\tif (drvr \u0026\u0026 drvr-\u003ebus_reset.func) {\n+\t\t\tbrcmf_err(\"device unresponsive after wake, scheduling bus reset\\n\");\n+\t\t\tschedule_work(\u0026drvr-\u003ebus_reset);\n+\t\t}\n+\t}\n+\n \tif (on)\n \t\tsdio_retune_release(bus-\u003esdiodev-\u003efunc1);\n \n"
} |
| 2/1 | 2026/08/16 06:45 | agent | patch-evaluator |
0mModel:best-expensive Args: null Results: {
"EnableConfigs": null,
"FocusSymbols": [],
"Reasoning": "The patch modifies the SDIO interface of the Broadcom brcmfmac wireless driver. This code requires physical Broadcom SDIO Wi-Fi hardware to be present and cannot be reached in standard virtualized environments like QEMU or GCE.",
"WorthFuzzing": false
}Instruction: You are an expert Linux kernel maintainer. Your job is to review a provided patch series and determine if it makes functional changes to the kernel that should be fuzzed. IMPORTANT: The changes have ALREADY been applied and committed as the HEAD commit in your workspace. Do NOT rely on your internal knowledge of the kernel. You must actively use your code access tools to examine the actual source code and confirm any assumptions. Return WorthFuzzing=false if the patch only contains: - Modifications to Documentation/, Kconfig files, or code comments. - Purely decorative changes, such as logging (e.g., pr_err, printk) or tracepoints. - Changes to numeric constants or macros that do not functionally alter execution flow. - Code paths that are impossible to reach in virtualized environments like GCE or QEMU, even when utilizing software-emulated hardware (e.g., usb gadget, mac80211_hwsim). - Code in vendor-specific PCIe switch, SmartNIC, or GPU drivers (e.g., mlxsw, pds_core, qed, ionic, amdgpu) that require physical PCIe hardware cards not emulated in standard QEMU. - Driver .remove, .shutdown, or pci_unregister_driver teardown callbacks (e.g., igb_remove) that are executed only during PCI hot-unplug or sysfs driver unbind operations. If it modifies reachable core kernel logic, drivers, or architectures, use your code search tools to verify the code can be executed, then return WorthFuzzing=true. When returning WorthFuzzing=true, you MUST ALSO: 1. Extract any specific kernel functions that should be heavily fuzzed into FocusSymbols. Avoid listing generic hot-path functions to prevent skewed test distributions. Prefer non-static, non-inlined API entrypoint functions over internal static helper functions (which are inlined by the compiler and do not have distinct symbol addresses). 2. Identify any specific CONFIG_ options required to properly test this new/modified feature. Go and look into the Kconfig files and check for ifdefs around the code, do not make assumptions. Also check "depends on" lines in Kconfig to include any non-standard parent subsystem configs needed for Kbuild to compile the code statically into vmlinux. List them in the EnableConfigs output array, and DO NOT add a 'CONFIG_' prefix (e.g., return "NET_IPV4" instead of "CONFIG_NET_IPV4"). Prefer calling several tools at the same time to save round-trips. Use set-results tool to provide results of the analysis. It must be called exactly once before the final reply. Ignore results of this tool. Prompt: For your convenience, here is the diff of the changes:
commit f7759f3e43796997bbf5a078c1f56f1f08762338
Author: syz-cluster <triage@syzkaller.com>
Date: Sun Aug 16 06:45:03 2026 +0000
syz-cluster: applied patch under review
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
index 381801af3ac98..3850535bfdb02 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
@@ -770,6 +770,28 @@ brcmf_sdio_kso_control(struct brcmf_sdio *bus, bool on)
if (try_cnt > MAX_KSO_ATTEMPTS)
brcmf_err("max tries: rd_val=0x%x err=%d\n", rd_val, err);
+ /* A wake attempt that gives up (whether by exhausting the KSO
+ * retries or by bailing out on consecutive access errors) with the
+ * sleep CSR reading back all-ones means the device has dropped off
+ * the bus entirely, e.g. it lost state across a system suspend
+ * despite keep-power-in-suspend (observed on CYW43455/BCM4345C0 on
+ * rk3566). No in-band recovery is possible: the interface is gone
+ * and a module reload fails to re-probe (-ETIMEDOUT on every
+ * function). The bus reset worker already performs the only known
+ * remedy (mmc_hw_reset -> pwrseq WL_REG_ON power cycle), but its
+ * sole SDIO trigger is the firmware-halt mailbox interrupt, which
+ * a chip that is off the bus can never deliver. Schedule it from
+ * here instead.
+ */
+ if (on && err && rd_val == 0xff) {
+ struct brcmf_pub *drvr = bus->sdiodev->bus_if->drvr;
+
+ if (drvr && drvr->bus_reset.func) {
+ brcmf_err("device unresponsive after wake, scheduling bus reset\n");
+ schedule_work(&drvr->bus_reset);
+ }
+ }
+
if (on)
sdio_retune_release(bus->sdiodev->func1);
|
| 3/2 | 2026/08/16 06:45 | llm | patch-evaluator |
0mModel:gemini-3.1-pro-preview Args: null Results: null Tokens: input: 2401 output: 81 thoughts: 624 Thoughts: **My Assessment of the Patch's Reachability** Okay, so I'm looking at this patch for `drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c`. It's adding a bus reset check in `brcmf_sdio_kso_control` when a Broadcom SDIO device seems unresponsive after waking up. My initial thought is, can this code even be triggered in a virtualized environment? I need to figure out if it's worth the fuzzing effort. First, I recall that `brcmfmac` is specifically for Broadcom 802.11 wireless LAN cards, and `sdio.c` targets SDIO-based chips. The usual QEMU setup I'm familiar with doesn't emulate these SDIO Broadcom chips directly. Standard QEMU doesn't have a built-in SDIO emulator, and I don't see any other software emulation for SDIO or this specific brcmfmac part. It's a hardware driver, plain and simple. I double-checked to see if Syzkaller's setup includes an SDIO emulator. Nope, it's focused on USB (dummy_hcd/raw-gadget), PCI (sometimes, but not usually specific Wi-Fi cards), and the like. So, generally speaking, these SDIO hardware drivers are just not reachable. Looking closer at the code, `brcmf_sdio_kso_control` is called from `brcmf_sdio_bus_sleep`. That's a huge clue: it definitely requires an SDIO bus and a Broadcom Wi-Fi chip physically connected to it. Therefore, it's not going to trigger in environments like Google Compute Engine or QEMU without some very specific hardware configuration that I can't easily emulate. My conclusion is **WorthFuzzing=false** because the device isn't reachable with standard tools. I verified the driver's dependencies, as well. It depends on `CONFIG_BRCMFMAC_SDIO`. I considered whether I could potentially trigger this through something like `mac80211_hwsim`, but that's a separate software simulator. Or perhaps via USB? No, because this is specifically the SDIO-related code. So, still unreachable. Therefore, again, **WorthFuzzing=false**. My reasoning is that this patch modifies the SDIO interface of the Broadcom brcmfmac wireless driver, and this code requires physical Broadcom SDIO Wi-Fi hardware to be present. I can't trigger it in standard virtualized environments like QEMU or GCE. Alright, time to set the results and move on. |
| 4/2 | 2026/08/16 06:45 | tool | set-results |
0mArgs:{
"EnableConfigs": [],
"FocusSymbols": [],
"Reasoning": "The patch modifies the SDIO interface of the Broadcom brcmfmac wireless driver. This code requires physical Broadcom SDIO Wi-Fi hardware to be present and cannot be reached in standard virtualized environments like QEMU or GCE.",
"WorthFuzzing": false
}Results: {
"EnableConfigs": null,
"FocusSymbols": [],
"Reasoning": "The patch modifies the SDIO interface of the Broadcom brcmfmac wireless driver. This code requires physical Broadcom SDIO Wi-Fi hardware to be present and cannot be reached in standard virtualized environments like QEMU or GCE.",
"WorthFuzzing": false
} |
| 5/1 | 2026/08/16 06:45 | action | If |
0mArgs:{
"WorthFuzzing": false
}Results: null |
| Total Calls | Total Tokens | Avg Tokens | Total Duration (Seconds) | Avg Duration (Seconds) |
|---|
| Total Calls | Total Duration (Seconds) | Avg Duration (Seconds) |
|---|