Currently the msync() system call will simply return 0 if you provide a length parameter which, when page-aligned (rounding up) overflows (i.e. SIZE_MAX - n, where n is in the range [0, PAGE_SIZE - 1).) This requires broken input, and nobody has complained about this, but for correctness this should really return -ENOMEM, so do so. Also, since error is assigned within the following loop, remove the unnecessary assignments prior to it. Link: https://lore.kernel.org/linux-mm/20230321074035.1526157-5-mawupeng1@huawei.com/ Reported-by: Ding Feng Closes: https://lore.kernel.org/linux-mm/20261120051413.46167-1-dingf3ng@gmail.com/ Signed-off-by: Lorenzo Stoakes (ARM) --- mm/msync.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/mm/msync.c b/mm/msync.c index 90b491a27a14..ced41d3c2903 100644 --- a/mm/msync.c +++ b/mm/msync.c @@ -46,14 +46,12 @@ SYSCALL_DEFINE3(msync, unsigned long, start, size_t, len, int, flags) goto out; if ((flags & MS_ASYNC) && (flags & MS_SYNC)) goto out; - error = -ENOMEM; + if (!len) + return 0; len = (len + ~PAGE_MASK) & PAGE_MASK; end = start + len; - if (end < start) - goto out; - error = 0; - if (end == start) - goto out; + if (end <= start) + return -ENOMEM; /* * If the interval [start,end) covers some unmapped address ranges, * just ignore them, but return -ENOMEM at the end. Besides, if the --- base-commit: d12eccbcb79a4fa35c3aa588eb79056af62eb859 change-id: 20261120-msync-enomem-fix-95f830e305dd Cheers, -- Lorenzo Stoakes (ARM)