A UUID is normally set as a vf_token to correspond the VFs with the PFs, if they are both bound by the vfio-pci driver. This is true for iommufd-based approach and container-based approach. The token can be set either during device creation (VFIO_GROUP_GET_DEVICE_FD) in container-based approach or during iommu bind (VFIO_DEVICE_BIND_IOMMUFD) in the iommu-fd case. Hence, extend the vfio_pci_device_init() helper to accept vf_token during device setup. The tests depending on vfio_pci_device_init() are adjusted accordingly and no functional changes are expected. A later patch will add tests that passes actual token to test the UAPI. Signed-off-by: Raghavendra Rao Ananta --- .../selftests/vfio/lib/include/vfio_util.h | 4 +- tools/testing/selftests/vfio/lib/libvfio.mk | 4 +- .../selftests/vfio/lib/vfio_pci_device.c | 60 ++++++++++++++++--- .../selftests/vfio/vfio_dma_mapping_test.c | 2 +- .../selftests/vfio/vfio_pci_device_test.c | 4 +- .../selftests/vfio/vfio_pci_driver_test.c | 4 +- 6 files changed, 62 insertions(+), 16 deletions(-) diff --git a/tools/testing/selftests/vfio/lib/include/vfio_util.h b/tools/testing/selftests/vfio/lib/include/vfio_util.h index ed31606e01b78..b01068d98fdab 100644 --- a/tools/testing/selftests/vfio/lib/include/vfio_util.h +++ b/tools/testing/selftests/vfio/lib/include/vfio_util.h @@ -202,7 +202,9 @@ const char *vfio_pci_get_cdev_path(const char *bdf); extern const char *default_iommu_mode; -struct vfio_pci_device *vfio_pci_device_init(const char *bdf, const char *iommu_mode); +struct vfio_pci_device *vfio_pci_device_init(const char *bdf, + const char *iommu_mode, + const char *vf_token); void vfio_pci_device_cleanup(struct vfio_pci_device *device); void vfio_pci_device_reset(struct vfio_pci_device *device); diff --git a/tools/testing/selftests/vfio/lib/libvfio.mk b/tools/testing/selftests/vfio/lib/libvfio.mk index 5d11c3a89a28e..2dc85c41ffb4b 100644 --- a/tools/testing/selftests/vfio/lib/libvfio.mk +++ b/tools/testing/selftests/vfio/lib/libvfio.mk @@ -18,7 +18,9 @@ $(shell mkdir -p $(LIBVFIO_O_DIRS)) CFLAGS += -I$(VFIO_DIR)/lib/include +LDLIBS += -luuid + $(LIBVFIO_O): $(OUTPUT)/%.o : $(VFIO_DIR)/%.c - $(CC) $(CFLAGS) $(CPPFLAGS) $(TARGET_ARCH) -c $< -o $@ + $(CC) $(CFLAGS) $(CPPFLAGS) $(TARGET_ARCH) -c $< $(LDLIBS) -o $@ EXTRA_CLEAN += $(LIBVFIO_O) diff --git a/tools/testing/selftests/vfio/lib/vfio_pci_device.c b/tools/testing/selftests/vfio/lib/vfio_pci_device.c index 0921b2451ba5c..3f7be8d371d06 100644 --- a/tools/testing/selftests/vfio/lib/vfio_pci_device.c +++ b/tools/testing/selftests/vfio/lib/vfio_pci_device.c @@ -11,6 +11,7 @@ #include #include +#include #include #include #include @@ -22,6 +23,8 @@ #define PCI_SYSFS_PATH "/sys/bus/pci/devices" +#define VF_TOKEN_ARG "vf_token=" + #define ioctl_assert(_fd, _op, _arg) do { \ void *__arg = (_arg); \ int __ret = ioctl((_fd), (_op), (__arg)); \ @@ -328,7 +331,37 @@ static void vfio_pci_group_setup(struct vfio_pci_device *device, const char *bdf ioctl_assert(device->group_fd, VFIO_GROUP_SET_CONTAINER, &device->container_fd); } -static void vfio_pci_container_setup(struct vfio_pci_device *device, const char *bdf) +static void vfio_pci_container_get_device_fd(struct vfio_pci_device *device, + const char *bdf, + const char *vf_token) +{ + char *arg = (char *) bdf; + + /* + * If a vf_token exists, argument to VFIO_GROUP_GET_DEVICE_FD + * will be in the form of the following example: + * "0000:04:10.0 vf_token=bd8d9d2b-5a5f-4f5a-a211-f591514ba1f3" + */ + if (vf_token) { + size_t sz = strlen(bdf) + strlen(" "VF_TOKEN_ARG) + + strlen(vf_token) + 1; + + arg = calloc(1, sz); + VFIO_ASSERT_NOT_NULL(arg); + + snprintf(arg, sz, "%s %s%s", bdf, VF_TOKEN_ARG, vf_token); + } + + device->fd = ioctl(device->group_fd, VFIO_GROUP_GET_DEVICE_FD, arg); + + if (vf_token) + free((void *) arg); + + VFIO_ASSERT_GE(device->fd, 0); +} + +static void vfio_pci_container_setup(struct vfio_pci_device *device, + const char *bdf, const char *vf_token) { unsigned long iommu_type = device->iommu_mode->iommu_type; const char *path = device->iommu_mode->container_path; @@ -348,8 +381,7 @@ static void vfio_pci_container_setup(struct vfio_pci_device *device, const char ioctl_assert(device->container_fd, VFIO_SET_IOMMU, (void *)iommu_type); - device->fd = ioctl(device->group_fd, VFIO_GROUP_GET_DEVICE_FD, bdf); - VFIO_ASSERT_GE(device->fd, 0); + vfio_pci_container_get_device_fd(device, bdf, vf_token); } static void vfio_pci_device_setup(struct vfio_pci_device *device) @@ -456,12 +488,19 @@ static const struct vfio_iommu_mode *lookup_iommu_mode(const char *iommu_mode) VFIO_FAIL("Unrecognized IOMMU mode: %s\n", iommu_mode); } -static void vfio_device_bind_iommufd(int device_fd, int iommufd) +static void vfio_device_bind_iommufd(int device_fd, int iommufd, const char *vf_token) { struct vfio_device_bind_iommufd args = { .argsz = sizeof(args), .iommufd = iommufd, }; + uuid_t token_uuid = {0}; + + if (vf_token) { + VFIO_ASSERT_EQ(uuid_parse(vf_token, token_uuid), 0); + args.flags = VFIO_DEVICE_BIND_FLAG_TOKEN; + args.token_uuid_ptr = (u64) token_uuid; + } ioctl_assert(device_fd, VFIO_DEVICE_BIND_IOMMUFD, &args); } @@ -486,7 +525,8 @@ static void vfio_device_attach_iommufd_pt(int device_fd, u32 pt_id) ioctl_assert(device_fd, VFIO_DEVICE_ATTACH_IOMMUFD_PT, &args); } -static void vfio_pci_iommufd_setup(struct vfio_pci_device *device, const char *bdf) +static void vfio_pci_iommufd_setup(struct vfio_pci_device *device, + const char *bdf, const char *vf_token) { const char *cdev_path = vfio_pci_get_cdev_path(bdf); @@ -502,12 +542,14 @@ static void vfio_pci_iommufd_setup(struct vfio_pci_device *device, const char *b device->iommufd = open("/dev/iommu", O_RDWR); VFIO_ASSERT_GT(device->iommufd, 0); - vfio_device_bind_iommufd(device->fd, device->iommufd); + vfio_device_bind_iommufd(device->fd, device->iommufd, vf_token); device->ioas_id = iommufd_ioas_alloc(device->iommufd); vfio_device_attach_iommufd_pt(device->fd, device->ioas_id); } -struct vfio_pci_device *vfio_pci_device_init(const char *bdf, const char *iommu_mode) +struct vfio_pci_device *vfio_pci_device_init(const char *bdf, + const char *iommu_mode, + const char *vf_token) { struct vfio_pci_device *device; @@ -519,9 +561,9 @@ struct vfio_pci_device *vfio_pci_device_init(const char *bdf, const char *iommu_ device->iommu_mode = lookup_iommu_mode(iommu_mode); if (device->iommu_mode->container_path) - vfio_pci_container_setup(device, bdf); + vfio_pci_container_setup(device, bdf, vf_token); else - vfio_pci_iommufd_setup(device, bdf); + vfio_pci_iommufd_setup(device, bdf, vf_token); vfio_pci_device_setup(device); vfio_pci_driver_probe(device); diff --git a/tools/testing/selftests/vfio/vfio_dma_mapping_test.c b/tools/testing/selftests/vfio/vfio_dma_mapping_test.c index ab19c54a774da..3c53b808f7f87 100644 --- a/tools/testing/selftests/vfio/vfio_dma_mapping_test.c +++ b/tools/testing/selftests/vfio/vfio_dma_mapping_test.c @@ -114,7 +114,7 @@ FIXTURE_VARIANT_ADD_ALL_IOMMU_MODES(anonymous_hugetlb_1gb, SZ_1G, MAP_HUGETLB | FIXTURE_SETUP(vfio_dma_mapping_test) { - self->device = vfio_pci_device_init(device_bdf, variant->iommu_mode); + self->device = vfio_pci_device_init(device_bdf, variant->iommu_mode, NULL); } FIXTURE_TEARDOWN(vfio_dma_mapping_test) diff --git a/tools/testing/selftests/vfio/vfio_pci_device_test.c b/tools/testing/selftests/vfio/vfio_pci_device_test.c index 7a270698e4d24..ebf7fd3d1cf70 100644 --- a/tools/testing/selftests/vfio/vfio_pci_device_test.c +++ b/tools/testing/selftests/vfio/vfio_pci_device_test.c @@ -28,7 +28,7 @@ FIXTURE(vfio_pci_device_test) { FIXTURE_SETUP(vfio_pci_device_test) { - self->device = vfio_pci_device_init(device_bdf, default_iommu_mode); + self->device = vfio_pci_device_init(device_bdf, default_iommu_mode, NULL); } FIXTURE_TEARDOWN(vfio_pci_device_test) @@ -116,7 +116,7 @@ FIXTURE_VARIANT_ADD(vfio_pci_irq_test, msix) { FIXTURE_SETUP(vfio_pci_irq_test) { - self->device = vfio_pci_device_init(device_bdf, default_iommu_mode); + self->device = vfio_pci_device_init(device_bdf, default_iommu_mode, NULL); } FIXTURE_TEARDOWN(vfio_pci_irq_test) diff --git a/tools/testing/selftests/vfio/vfio_pci_driver_test.c b/tools/testing/selftests/vfio/vfio_pci_driver_test.c index 2dbd70b7db627..cfbaa05dda884 100644 --- a/tools/testing/selftests/vfio/vfio_pci_driver_test.c +++ b/tools/testing/selftests/vfio/vfio_pci_driver_test.c @@ -71,7 +71,7 @@ FIXTURE_SETUP(vfio_pci_driver_test) { struct vfio_pci_driver *driver; - self->device = vfio_pci_device_init(device_bdf, variant->iommu_mode); + self->device = vfio_pci_device_init(device_bdf, variant->iommu_mode, NULL); driver = &self->device->driver; @@ -233,7 +233,7 @@ int main(int argc, char *argv[]) device_bdf = vfio_selftests_get_bdf(&argc, argv); - device = vfio_pci_device_init(device_bdf, default_iommu_mode); + device = vfio_pci_device_init(device_bdf, default_iommu_mode, NULL); if (!device->driver.ops) { fprintf(stderr, "No driver found for device %s\n", device_bdf); return KSFT_SKIP; -- 2.51.2.997.g839fc31de9-goog Refactor and make the functions called under device initialization public. A later patch adds a test that calls these functions to validate the UAPI of SR-IOV devices. Opportunistically, to test the success and failure cases of the UAPI, split the functions dealing with VFIO_GROUP_GET_DEVICE_FD and VFIO_DEVICE_BIND_IOMMUFD into a core function and another one that asserts the ioctl. The former will be used for testing the SR-IOV UAPI, hence only export these. Signed-off-by: Raghavendra Rao Ananta --- .../selftests/vfio/lib/include/vfio_util.h | 13 ++++ .../selftests/vfio/lib/vfio_pci_device.c | 75 +++++++++++++------ 2 files changed, 67 insertions(+), 21 deletions(-) diff --git a/tools/testing/selftests/vfio/lib/include/vfio_util.h b/tools/testing/selftests/vfio/lib/include/vfio_util.h index b01068d98fdab..2baf12a888e67 100644 --- a/tools/testing/selftests/vfio/lib/include/vfio_util.h +++ b/tools/testing/selftests/vfio/lib/include/vfio_util.h @@ -294,4 +294,17 @@ void vfio_pci_driver_memcpy_start(struct vfio_pci_device *device, int vfio_pci_driver_memcpy_wait(struct vfio_pci_device *device); void vfio_pci_driver_send_msi(struct vfio_pci_device *device); +const char *iommu_mode_container_path(const char *iommu_mode); +const struct vfio_iommu_mode *lookup_iommu_mode(const char *iommu_mode); + +void vfio_container_open(struct vfio_pci_device *device); +void vfio_pci_group_setup(struct vfio_pci_device *device, const char *bdf); +void vfio_container_set_iommu(struct vfio_pci_device *device); +void __vfio_container_get_device_fd(struct vfio_pci_device *device, + const char *bdf, const char *vf_token); + +void vfio_pci_iommufd_cdev_open(struct vfio_pci_device *device, const char *bdf); +void vfio_pci_iommufd_iommudev_open(struct vfio_pci_device *device); +int __vfio_device_bind_iommufd(int device_fd, int iommufd, const char *vf_token); + #endif /* SELFTESTS_VFIO_LIB_INCLUDE_VFIO_UTIL_H */ diff --git a/tools/testing/selftests/vfio/lib/vfio_pci_device.c b/tools/testing/selftests/vfio/lib/vfio_pci_device.c index 3f7be8d371d06..7a1547e365870 100644 --- a/tools/testing/selftests/vfio/lib/vfio_pci_device.c +++ b/tools/testing/selftests/vfio/lib/vfio_pci_device.c @@ -311,7 +311,7 @@ static unsigned int vfio_pci_get_group_from_dev(const char *bdf) return group; } -static void vfio_pci_group_setup(struct vfio_pci_device *device, const char *bdf) +void vfio_pci_group_setup(struct vfio_pci_device *device, const char *bdf) { struct vfio_group_status group_status = { .argsz = sizeof(group_status), @@ -331,9 +331,8 @@ static void vfio_pci_group_setup(struct vfio_pci_device *device, const char *bdf ioctl_assert(device->group_fd, VFIO_GROUP_SET_CONTAINER, &device->container_fd); } -static void vfio_pci_container_get_device_fd(struct vfio_pci_device *device, - const char *bdf, - const char *vf_token) +void __vfio_container_get_device_fd(struct vfio_pci_device *device, + const char *bdf, const char *vf_token) { char *arg = (char *) bdf; @@ -356,32 +355,46 @@ static void vfio_pci_container_get_device_fd(struct vfio_pci_device *device, if (vf_token) free((void *) arg); +} +static void vfio_container_get_device_fd(struct vfio_pci_device *device, + const char *bdf, + const char *vf_token) +{ + __vfio_container_get_device_fd(device, bdf, vf_token); VFIO_ASSERT_GE(device->fd, 0); } -static void vfio_pci_container_setup(struct vfio_pci_device *device, - const char *bdf, const char *vf_token) +void vfio_container_set_iommu(struct vfio_pci_device *device) { unsigned long iommu_type = device->iommu_mode->iommu_type; + int ret; + + ret = ioctl(device->container_fd, VFIO_CHECK_EXTENSION, iommu_type); + VFIO_ASSERT_GT(ret, 0, "VFIO IOMMU type %lu not supported\n", iommu_type); + + ioctl_assert(device->container_fd, VFIO_SET_IOMMU, (void *)iommu_type); +} + +void vfio_container_open(struct vfio_pci_device *device) +{ const char *path = device->iommu_mode->container_path; int version; - int ret; device->container_fd = open(path, O_RDWR); VFIO_ASSERT_GE(device->container_fd, 0, "open(%s) failed\n", path); version = ioctl(device->container_fd, VFIO_GET_API_VERSION); VFIO_ASSERT_EQ(version, VFIO_API_VERSION, "Unsupported version: %d\n", version); +} +static void vfio_pci_container_setup(struct vfio_pci_device *device, + const char *bdf, const char *vf_token) +{ + vfio_container_open(device); vfio_pci_group_setup(device, bdf); - - ret = ioctl(device->container_fd, VFIO_CHECK_EXTENSION, iommu_type); - VFIO_ASSERT_GT(ret, 0, "VFIO IOMMU type %lu not supported\n", iommu_type); - - ioctl_assert(device->container_fd, VFIO_SET_IOMMU, (void *)iommu_type); - - vfio_pci_container_get_device_fd(device, bdf, vf_token); + vfio_container_set_iommu(device); + vfio_container_get_device_fd(device, bdf, vf_token); } static void vfio_pci_device_setup(struct vfio_pci_device *device) @@ -471,7 +484,7 @@ static const struct vfio_iommu_mode iommu_modes[] = { const char *default_iommu_mode = "iommufd"; -static const struct vfio_iommu_mode *lookup_iommu_mode(const char *iommu_mode) +const struct vfio_iommu_mode *lookup_iommu_mode(const char *iommu_mode) { int i; @@ -488,7 +501,12 @@ static const struct vfio_iommu_mode *lookup_iommu_mode(const char *iommu_mode) VFIO_FAIL("Unrecognized IOMMU mode: %s\n", iommu_mode); } -static void vfio_device_bind_iommufd(int device_fd, int iommufd, const char *vf_token) +const char *iommu_mode_container_path(const char *iommu_mode) +{ + return lookup_iommu_mode(iommu_mode)->container_path; +} + +int __vfio_device_bind_iommufd(int device_fd, int iommufd, const char *vf_token) { struct vfio_device_bind_iommufd args = { .argsz = sizeof(args), @@ -502,7 +520,14 @@ static void vfio_device_bind_iommufd(int device_fd, int iommufd, const char *vf_ args.token_uuid_ptr = (u64) token_uuid; } - ioctl_assert(device_fd, VFIO_DEVICE_BIND_IOMMUFD, &args); + return ioctl(device_fd, VFIO_DEVICE_BIND_IOMMUFD, &args); +} + +static void vfio_device_bind_iommufd(int device_fd, int iommufd, const char *vf_token) +{ + int ret = __vfio_device_bind_iommufd(device_fd, iommufd, vf_token); + + VFIO_ASSERT_EQ(ret, 0, "Failed VFIO_DEVICE_BIND_IOMMUFD ioctl\n"); } static u32 iommufd_ioas_alloc(int iommufd) @@ -525,23 +550,31 @@ static void vfio_device_attach_iommufd_pt(int device_fd, u32 pt_id) ioctl_assert(device_fd, VFIO_DEVICE_ATTACH_IOMMUFD_PT, &args); } -static void vfio_pci_iommufd_setup(struct vfio_pci_device *device, - const char *bdf, const char *vf_token) +void vfio_pci_iommufd_cdev_open(struct vfio_pci_device *device, const char *bdf) { const char *cdev_path = vfio_pci_get_cdev_path(bdf); device->fd = open(cdev_path, O_RDWR); VFIO_ASSERT_GE(device->fd, 0); free((void *)cdev_path); +} +void vfio_pci_iommufd_iommudev_open(struct vfio_pci_device *device) +{ /* * Require device->iommufd to be >0 so that a simple non-0 check can be * used to check if iommufd is enabled. In practice open() will never * return 0 unless stdin is closed. */ - device->iommufd = open("/dev/iommu", O_RDWR); - VFIO_ASSERT_GT(device->iommufd, 0); + device->iommufd = open("/dev/iommu", O_RDWR); + VFIO_ASSERT_GT(device->iommufd, 0); +} +static void vfio_pci_iommufd_setup(struct vfio_pci_device *device, + const char *bdf, const char *vf_token) +{ + vfio_pci_iommufd_cdev_open(device, bdf); + vfio_pci_iommufd_iommudev_open(device); vfio_device_bind_iommufd(device->fd, device->iommufd, vf_token); device->ioas_id = iommufd_ioas_alloc(device->iommufd); vfio_device_attach_iommufd_pt(device->fd, device->ioas_id); -- 2.51.2.997.g839fc31de9-goog Not only at init, but a vf_token can also be set via the VFIO_DEVICE_FEATURE ioctl, by setting the VFIO_DEVICE_FEATURE_PCI_VF_TOKEN flag. Add an API to utilize this functionality from the test code. Signed-off-by: Raghavendra Rao Ananta --- .../selftests/vfio/lib/include/vfio_util.h | 2 ++ .../selftests/vfio/lib/vfio_pci_device.c | 34 +++++++++++++++++++ 2 files changed, 36 insertions(+) diff --git a/tools/testing/selftests/vfio/lib/include/vfio_util.h b/tools/testing/selftests/vfio/lib/include/vfio_util.h index 2baf12a888e67..f0a12646456a9 100644 --- a/tools/testing/selftests/vfio/lib/include/vfio_util.h +++ b/tools/testing/selftests/vfio/lib/include/vfio_util.h @@ -307,4 +307,6 @@ void vfio_pci_iommufd_cdev_open(struct vfio_pci_device *device, const char *bdf) void vfio_pci_iommufd_iommudev_open(struct vfio_pci_device *device); int __vfio_device_bind_iommufd(int device_fd, int iommufd, const char *vf_token); +void vfio_device_set_vf_token(int fd, const char *vf_token); + #endif /* SELFTESTS_VFIO_LIB_INCLUDE_VFIO_UTIL_H */ diff --git a/tools/testing/selftests/vfio/lib/vfio_pci_device.c b/tools/testing/selftests/vfio/lib/vfio_pci_device.c index 7a1547e365870..c0fa4e27a96ef 100644 --- a/tools/testing/selftests/vfio/lib/vfio_pci_device.c +++ b/tools/testing/selftests/vfio/lib/vfio_pci_device.c @@ -144,6 +144,40 @@ static void vfio_pci_irq_get(struct vfio_pci_device *device, u32 index, ioctl_assert(device->fd, VFIO_DEVICE_GET_IRQ_INFO, irq_info); } +static int vfio_device_feature_ioctl(int fd, u32 flags, void *data, + size_t data_size) +{ + u8 buffer[sizeof(struct vfio_device_feature) + data_size] = {}; + struct vfio_device_feature *feature = (void *)buffer; + + memcpy(feature->data, data, data_size); + + feature->argsz = sizeof(buffer); + feature->flags = flags; + + return ioctl(fd, VFIO_DEVICE_FEATURE, feature); +} + +static void vfio_device_feature_set(int fd, u16 feature, void *data, size_t data_size) +{ + u32 flags = VFIO_DEVICE_FEATURE_SET | feature; + int ret; + + ret = vfio_device_feature_ioctl(fd, flags, data, data_size); + VFIO_ASSERT_EQ(ret, 0, "Failed to set feature %u\n", feature); +} + +void vfio_device_set_vf_token(int fd, const char *vf_token) +{ + uuid_t token_uuid = {0}; + + VFIO_ASSERT_NOT_NULL(vf_token, "vf_token is NULL"); + VFIO_ASSERT_EQ(uuid_parse(vf_token, token_uuid), 0); + + vfio_device_feature_set(fd, VFIO_DEVICE_FEATURE_PCI_VF_TOKEN, + token_uuid, sizeof(uuid_t)); +} + static void vfio_iommu_dma_map(struct vfio_pci_device *device, struct vfio_dma_region *region) { -- 2.51.2.997.g839fc31de9-goog Add a test to validate the SR-IOV UAPI, including the following cases, iterating over all the IOMMU modes currently supported: - Setting correct/incorrect/NULL tokens during device init. - Close the PF device immediately after setting the token. - Change/override the PF's token after device init. Signed-off-by: Raghavendra Rao Ananta --- tools/testing/selftests/vfio/Makefile | 1 + .../selftests/vfio/vfio_pci_sriov_uapi_test.c | 220 ++++++++++++++++++ 2 files changed, 221 insertions(+) create mode 100644 tools/testing/selftests/vfio/vfio_pci_sriov_uapi_test.c diff --git a/tools/testing/selftests/vfio/Makefile b/tools/testing/selftests/vfio/Makefile index 324ba0175a333..e9fad0acf4d13 100644 --- a/tools/testing/selftests/vfio/Makefile +++ b/tools/testing/selftests/vfio/Makefile @@ -3,6 +3,7 @@ TEST_GEN_PROGS += vfio_dma_mapping_test TEST_GEN_PROGS += vfio_iommufd_setup_test TEST_GEN_PROGS += vfio_pci_device_test TEST_GEN_PROGS += vfio_pci_driver_test +TEST_GEN_PROGS += vfio_pci_sriov_uapi_test TEST_PROGS_EXTENDED := run.sh include ../lib.mk include lib/libvfio.mk diff --git a/tools/testing/selftests/vfio/vfio_pci_sriov_uapi_test.c b/tools/testing/selftests/vfio/vfio_pci_sriov_uapi_test.c new file mode 100644 index 0000000000000..4d63359053230 --- /dev/null +++ b/tools/testing/selftests/vfio/vfio_pci_sriov_uapi_test.c @@ -0,0 +1,220 @@ +// SPDX-License-Identifier: GPL-2.0-only +#include +#include +#include +#include +#include + +#include + +#include "../kselftest_harness.h" + +#define PCI_SYSFS_PATH "/sys/bus/pci/devices" + +#define UUID_1 "52ac9bff-3a88-4fbd-901a-0d767c3b6c97" +#define UUID_2 "88594674-90a0-47a9-aea8-9d9b352ac08a" + +static const char *pf_dev_bdf; +static char vf_dev_bdf[16]; + +struct vfio_pci_device *pf_device; +struct vfio_pci_device *vf_device; + +static void test_vfio_pci_container_setup(struct vfio_pci_device *device, + const char *bdf, + const char *vf_token) +{ + vfio_container_open(device); + vfio_pci_group_setup(device, bdf); + vfio_container_set_iommu(device); + __vfio_container_get_device_fd(device, bdf, vf_token); +} + +static int test_vfio_pci_iommufd_setup(struct vfio_pci_device *device, + const char *bdf, const char *vf_token) +{ + vfio_pci_iommufd_cdev_open(device, bdf); + vfio_pci_iommufd_iommudev_open(device); + return __vfio_device_bind_iommufd(device->fd, device->iommufd, vf_token); +} + +static struct vfio_pci_device *test_vfio_pci_device_init(const char *bdf, + const char *iommu_mode, + const char *vf_token, + int *out_ret) +{ + struct vfio_pci_device *device; + + device = calloc(1, sizeof(*device)); + VFIO_ASSERT_NOT_NULL(device); + + device->iommu_mode = lookup_iommu_mode(iommu_mode); + + if (iommu_mode_container_path(iommu_mode)) { + test_vfio_pci_container_setup(device, bdf, vf_token); + /* The device fd will be -1 in case of mismatched tokens */ + *out_ret = (device->fd < 0); + } else { + *out_ret = test_vfio_pci_iommufd_setup(device, bdf, vf_token); + } + + return device; +} + +static void test_vfio_pci_device_cleanup(struct vfio_pci_device *device) +{ + if (device->fd > 0) + VFIO_ASSERT_EQ(close(device->fd), 0); + + if (device->iommufd) { + VFIO_ASSERT_EQ(close(device->iommufd), 0); + } else { + VFIO_ASSERT_EQ(close(device->group_fd), 0); + VFIO_ASSERT_EQ(close(device->container_fd), 0); + } + + free(device); +} + +FIXTURE(vfio_pci_sriov_uapi_test) {}; + +FIXTURE_SETUP(vfio_pci_sriov_uapi_test) +{ + char vf_path[PATH_MAX] = {0}; + char path[PATH_MAX] = {0}; + unsigned int nr_vfs; + char buf[32] = {0}; + int ret; + int fd; + + /* Check if SR-IOV is supported by the device */ + snprintf(path, PATH_MAX, "%s/%s/sriov_totalvfs", PCI_SYSFS_PATH, pf_dev_bdf); + fd = open(path, O_RDONLY); + if (fd < 0) { + fprintf(stderr, "SR-IOV may not be supported by the device\n"); + exit(KSFT_SKIP); + } + + ASSERT_GT(read(fd, buf, ARRAY_SIZE(buf)), 0); + ASSERT_EQ(close(fd), 0); + nr_vfs = strtoul(buf, NULL, 0); + if (nr_vfs < 0) { + fprintf(stderr, "SR-IOV may not be supported by the device\n"); + exit(KSFT_SKIP); + } + + /* Setup VFs, if already not done */ + snprintf(path, PATH_MAX, "%s/%s/sriov_numvfs", PCI_SYSFS_PATH, pf_dev_bdf); + ASSERT_GT(fd = open(path, O_RDWR), 0); + ASSERT_GT(read(fd, buf, ARRAY_SIZE(buf)), 0); + nr_vfs = strtoul(buf, NULL, 0); + if (nr_vfs == 0) + ASSERT_EQ(write(fd, "1", 1), 1); + ASSERT_EQ(close(fd), 0); + + /* Get the BDF of the first VF */ + snprintf(path, PATH_MAX, "%s/%s/virtfn0", PCI_SYSFS_PATH, pf_dev_bdf); + ret = readlink(path, vf_path, PATH_MAX); + ASSERT_NE(ret, -1); + ret = sscanf(basename(vf_path), "%s", vf_dev_bdf); + ASSERT_EQ(ret, 1); +} + +FIXTURE_TEARDOWN(vfio_pci_sriov_uapi_test) +{ +} + +FIXTURE_VARIANT(vfio_pci_sriov_uapi_test) { + const char *iommu_mode; + char *vf_token; +}; + +#define FIXTURE_VARIANT_ADD_IOMMU_MODE(_iommu_mode, _name, _vf_token) \ +FIXTURE_VARIANT_ADD(vfio_pci_sriov_uapi_test, _iommu_mode ## _ ## _name) { \ + .iommu_mode = #_iommu_mode, \ + .vf_token = (_vf_token), \ +} + +FIXTURE_VARIANT_ADD_ALL_IOMMU_MODES(same_uuid, UUID_1); +FIXTURE_VARIANT_ADD_ALL_IOMMU_MODES(diff_uuid, UUID_2); +FIXTURE_VARIANT_ADD_ALL_IOMMU_MODES(null_uuid, NULL); + +/* + * PF's token is always set with UUID_1 and VF's token is rotated with + * various tokens (including UUID_1 and NULL). + * This asserts if the VF device is successfully created for a match + * in the token or actually fails during a mismatch. + */ +#define ASSERT_VF_CREATION(_ret) do { \ + if (variant->vf_token == NULL || \ + strcmp(UUID_1, variant->vf_token)) { \ + ASSERT_NE((_ret), 0); \ + } else { \ + ASSERT_EQ((_ret), 0); \ + } \ +} while (0) + +/* + * Validate if the UAPI handles correctly and incorrectly set token on the VF. + */ +TEST_F(vfio_pci_sriov_uapi_test, init_token_match) +{ + int ret; + + pf_device = test_vfio_pci_device_init(pf_dev_bdf, variant->iommu_mode, + UUID_1, &ret); + vf_device = test_vfio_pci_device_init(vf_dev_bdf, variant->iommu_mode, + variant->vf_token, &ret); + + ASSERT_VF_CREATION(ret); + + test_vfio_pci_device_cleanup(vf_device); + test_vfio_pci_device_cleanup(pf_device); +} + +/* + * After setting a token on the PF, validate if the VF can still set the + * expected token. + */ +TEST_F(vfio_pci_sriov_uapi_test, pf_early_close) +{ + int ret; + + pf_device = test_vfio_pci_device_init(pf_dev_bdf, variant->iommu_mode, + UUID_1, &ret); + test_vfio_pci_device_cleanup(pf_device); + + vf_device = test_vfio_pci_device_init(vf_dev_bdf, variant->iommu_mode, + variant->vf_token, &ret); + + ASSERT_VF_CREATION(ret); + + test_vfio_pci_device_cleanup(vf_device); +} + +/* + * After PF device init, override the exsiting token and validate if the newly + * set token is the one that's active. + */ +TEST_F(vfio_pci_sriov_uapi_test, override_token) +{ + int ret; + + pf_device = test_vfio_pci_device_init(pf_dev_bdf, variant->iommu_mode, + UUID_2, &ret); + vfio_device_set_vf_token(pf_device->fd, UUID_1); + + vf_device = test_vfio_pci_device_init(vf_dev_bdf, variant->iommu_mode, + variant->vf_token, &ret); + + ASSERT_VF_CREATION(ret); + + test_vfio_pci_device_cleanup(vf_device); + test_vfio_pci_device_cleanup(pf_device); +} + +int main(int argc, char *argv[]) +{ + pf_dev_bdf = vfio_selftests_get_bdf(&argc, argv); + return test_harness_run(argc, argv); +} -- 2.51.2.997.g839fc31de9-goog