The TODO comment in nid_show() suggested returning an error if the goal was not using nid. However, this comment was found to be inaccurate and misleading. This patch removes the TODO comment without changing any existing behavior. This change follows feedback from SJ who pointed out that wiring-order independence is expected and the function should simply show the last set value. No functional code changes were made. Tested with KUnit: - Built kernel with KUnit and DAMON sysfs tests enabled. - Executed KUnit tests: ./kunit.py run --kunitconfig ./mm/mm/damon/tests/.kunitconfig - All 25 tests passed, including damon_sysfs_test_add_targets. Signed-off-by: Swaraj Gaikwad Suggested-by: SeongJae Park --- mm/damon/sysfs-schemes.c | 1 - 1 file changed, 1 deletion(-) diff --git a/mm/damon/sysfs-schemes.c b/mm/damon/sysfs-schemes.c index 6536f16006c9..760279092b4f 100644 --- a/mm/damon/sysfs-schemes.c +++ b/mm/damon/sysfs-schemes.c @@ -1112,7 +1112,6 @@ static ssize_t nid_show(struct kobject *kobj, struct damos_sysfs_quota_goal *goal = container_of(kobj, struct damos_sysfs_quota_goal, kobj); - /* todo: return error if the goal is not using nid */ return sysfs_emit(buf, "%d\n", goal->nid); } base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787 -- 2.51.0