In switchdev mode, rx_add_rule() calls mlx5_esw_ipsec_rx_setup_modify_header(), which allocates a mapped ID for the SA in ipsec->ipsec_obj_id_map. If a later step fails, the error path frees the modify header but leaves the ID in the XArray, and mlx5e_xfrm_add_state() then frees the SA entry. Each failed inbound packet offload SA leaks one of the 2047 IDs. Once they are used up, no new inbound SA can be offloaded until the IPsec context is cleaned up. Remove the mapping where the modify header is freed, as mlx5e_accel_ipsec_fs_del_rule() does. The modify header is set only after a new ID was allocated, so the copy that mlx5e_accel_ipsec_fs_modify() passes in never loses the ID of the original SA. Outside switchdev mode rx_mapped_id is 0 and the call does nothing. Fixes: 91bafc638ed4 ("net/mlx5e: Handle IPsec offload for RX datapath in switchdev mode") Signed-off-by: Changyul Lee --- Found with a static analysis tool we are developing. Compile-tested only, with x86_64_defconfig plus MLX5_CORE_EN, MLX5_ESWITCH, MLX5_EN_IPSEC and W=1. drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_fs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_fs.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_fs.c index 5c69e89b13a7..ef858374ae11 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_fs.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/ipsec_fs.c @@ -2161,8 +2161,10 @@ static int rx_add_rule(struct mlx5e_ipsec_sa_entry *sa_entry) if (flow_act.pkt_reformat) mlx5_packet_reformat_dealloc(mdev, flow_act.pkt_reformat); err_pkt_reformat: - if (flow_act.modify_hdr) + if (flow_act.modify_hdr) { mlx5_modify_header_dealloc(mdev, flow_act.modify_hdr); + mlx5_esw_ipsec_rx_id_mapping_remove(sa_entry); + } err_mod_header: kvfree(spec); err_alloc: base-commit: 2a324a58a084c5cfd7e5a2f55e0786bee170a4a5 -- 2.43.0