The interrupt handler schedules tx_clean_tasklet, which dereferences the private state and TX ring. free_irq() prevents new scheduling but does not wait for a tasklet that was already queued. Kill the tasklet after freeing the interrupt and before purging and freeing the DMA rings. Fixes: d6aa60a10b2f ("NET: Add Ethernet driver for Octeon MGMT devices.") Signed-off-by: Hongyan Xu --- drivers/net/ethernet/cavium/octeon/octeon_mgmt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c b/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c index c190fc6538d4..2cf3365b9636 100644 --- a/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c +++ b/drivers/net/ethernet/cavium/octeon/octeon_mgmt.c @@ -1254,6 +1254,7 @@ static int octeon_mgmt_stop(struct net_device *netdev) octeon_mgmt_reset_hw(p); free_irq(p->irq, netdev); + tasklet_kill(&p->tx_clean_tasklet); /* dma_unmap is a nop on Octeon, so just free everything. */ skb_queue_purge(&p->tx_list); -- 2.50.1.windows.1