ip route flush reuses route dump messages as RTM_DELROUTE requests. With nexthop compatibility mode enabled, the dump includes RTA_NH_ID alongside expanded nexthop attributes. rtm_to_fib_config() rejects the combination with -EINVAL, leaving the routes installed. Skip the mutual exclusion check for RTM_DELROUTE. fib_nh_match() already uses the ID to match the nexthop when an ID is supplied, so the expanded fields do not constrain that match. Keep the validation for RTM_NEWROUTE and leave the other delete selectors intact. The failure was reproduced while investigating the iproute2 flush report below. An unmodified kernel and iproute2 reproduced it without fault injection in a fresh network namespace with compatibility mode enabled. ip link add d0 type dummy ip link set d0 up ip -4 nexthop add id 101 via 192.0.2.1 dev d0 onlink ip -4 route add 198.51.100.0/24 table 1111 nhid 101 metric 10 ip -4 route flush table 1111 metric 10 Verified the flush and the existing new-route validation in QEMU/KVM. The IPv4 compatibility selftest reproduced the failure on the base kernel and passed with the fix. The IPv4 group and IPv6 compatibility selftests also passed with the fix. Codex assisted with isolating the IPv4 delete change, writing the regression test and running the QEMU comparisons. Fixes: 493ced1ac47c ("ipv4: Allow routes to use nexthop objects") Link: https://lists.openwall.net/netdev/2026/10/26/186 Signed-off-by: Yuen Su --- net/ipv4/fib_frontend.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/ipv4/fib_frontend.c b/net/ipv4/fib_frontend.c index 8c123b1..6b012c8 100644 --- a/net/ipv4/fib_frontend.c +++ b/net/ipv4/fib_frontend.c @@ -868,7 +868,10 @@ static int rtm_to_fib_config(struct net *net, struct sk_buff *skb, goto errout; } - if (cfg->fc_nh_id) { + /* Dumps can include both a nexthop ID and compatibility attributes. + * On deletion, fib_nh_match() uses the ID to match the nexthop. + */ + if (cfg->fc_nh_id && nlh->nlmsg_type != RTM_DELROUTE) { if (cfg->fc_oif || cfg->fc_gw_family || cfg->fc_encap || cfg->fc_mp) { NL_SET_ERR_MSG(extack, Exercise ip route flush on a route with a nexthop group while the dump includes both the group's ID and the expanded paths. Check that the flush succeeds and that the route is gone. Both checks fail before the IPv4 delete fix and pass after it in a QEMU/KVM guest with unmodified iproute2. Codex assisted with adding the case to the existing compatibility selftest and running it. Signed-off-by: Yuen Su --- tools/testing/selftests/net/fib_nexthops.sh | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/tools/testing/selftests/net/fib_nexthops.sh b/tools/testing/selftests/net/fib_nexthops.sh index adbec51..d3c8cf8 100755 --- a/tools/testing/selftests/net/fib_nexthops.sh +++ b/tools/testing/selftests/net/fib_nexthops.sh @@ -2183,6 +2183,13 @@ ipv4_compat_mode() stop_ip_monitor $ipmout 3 log_test $? 0 "IPv4 compat mode on - nexthop change" + run_cmd "$IP route add 192.0.2.1/32 nhid 122" + log_test $? 0 "IPv4 compat mode on - add route for flush" + run_cmd "$IP route flush to exact 192.0.2.1/32" + log_test $? 0 "IPv4 compat mode on - route flush" + check_route "192.0.2.1" "" + log_test $? 0 "IPv4 compat mode on - route removed by flush" + sysctl_nexthop_compat_mode_set 0 "IPv4" # cleanup