Commit 701981cab016 ("mtd: nand: Add a NAND page I/O request type") added a 'type' member to the 'nand_page_io_req' structure and updated the request iterators to utilize that, but the spinand_{is,mark}bad() functions were not updated by the commit. However in both of these functions the new member is implicitly inititalized to zero which corresponds to NAND_PAGE_READ. This is correct for the spinand_isbad() function since that uses a read request to get the bad block marker bytes, but the spinand_markbad() function does a write request so it should set the request type to NAND_PAGE_WRITE. Change the spinand_markbad() function to set the request type to the correct NAND_PAGE_WRITE value. For consistency, also update the spinand_isbad() function to set the request type to NAND_PAGE_READ explicitly. Cc: stable@vger.kernel.org Fixes: 701981cab016 ("mtd: nand: Add a NAND page I/O request type") Reported-by: Sashiko Link: https://sashiko.dev/#/log/192383 # See "**Investigating `req->type` in NAND Write Operations**" Signed-off-by: Gabor Juhos --- Changes in v2: - add stable tag --- drivers/mtd/nand/spi/core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c index 18bba02fbd31..35bcb4a8861b 100644 --- a/drivers/mtd/nand/spi/core.c +++ b/drivers/mtd/nand/spi/core.c @@ -1105,6 +1105,7 @@ static bool spinand_isbad(struct nand_device *nand, const struct nand_pos *pos) struct spinand_device *spinand = nand_to_spinand(nand); u8 marker[2] = { }; struct nand_page_io_req req = { + .type = NAND_PAGE_READ, .pos = *pos, .ooblen = sizeof(marker), .ooboffs = 0, @@ -1148,6 +1149,7 @@ static int spinand_markbad(struct nand_device *nand, const struct nand_pos *pos) struct spinand_device *spinand = nand_to_spinand(nand); u8 marker[2] = { }; struct nand_page_io_req req = { + .type = NAND_PAGE_WRITE, .pos = *pos, .ooboffs = 0, .ooblen = sizeof(marker), --- base-commit: 760d2efe91a84363d25c1051a10572242e75fe86 change-id: 20261117-spinand-set-req-type-in-bbm-functions-34775e6c14e0 Best regards, -- Gabor Juhos