Simplify if-true-return-true-else-false logic. Signed-off-by: Gregory Price Acked-by: David Hildenbrand --- include/linux/hugetlb.h | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h index eb21619206af..d5282d52493b 100644 --- a/include/linux/hugetlb.h +++ b/include/linux/hugetlb.h @@ -876,12 +876,9 @@ static inline void folio_clear_hugetlb_hwpoison(struct folio *folio) #ifndef arch_hugetlb_migration_supported static inline bool arch_hugetlb_migration_supported(struct hstate *h) { - if ((huge_page_shift(h) == PMD_SHIFT) || + return ((huge_page_shift(h) == PMD_SHIFT) || (huge_page_shift(h) == PUD_SHIFT) || - (huge_page_shift(h) == PGDIR_SHIFT)) - return true; - else - return false; + (huge_page_shift(h) == PGDIR_SHIFT)); } #endif #else -- 2.51.1 sysctl bits are mostly-read values. Suggested-by: Andrew Morton Signed-off-by: Gregory Price Acked-by: Oscar Salvador --- include/linux/hugetlb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h index d5282d52493b..d6705157c41d 100644 --- a/include/linux/hugetlb.h +++ b/include/linux/hugetlb.h @@ -172,7 +172,7 @@ bool hugetlbfs_pagecache_present(struct hstate *h, struct address_space *hugetlb_folio_mapping_lock_write(struct folio *folio); -extern int sysctl_hugetlb_shm_group; +extern int sysctl_hugetlb_shm_group __read_mostly; extern struct list_head huge_boot_pages[MAX_NUMNODES]; void hugetlb_bootmem_alloc(void); -- 2.51.1