__hw_addr_create() allocates struct netdev_hw_addr with kmalloc() and copies only addr_len bytes into ha->addr[MAX_ADDR_LEN], leaving the rest uninitialized. If dev->addr_len later grows while entries remain (e.g., adding a multicast address to a down TAP device with SIOCADDMULTI and then switching it to ARPHRD_TUNNEL6 via TUNSETLINK), readers using dev->addr_len such as /proc/net/dev_mcast and AF_PACKET RTM_GETMULTICAST expose the uninitialized trailing slab bytes, and __hw_addr_add_ex() reads them in memcmp(). Switch __hw_addr_create() to kzalloc() so the unused tail of ha->addr is always zero. Link: https://lore.kernel.org/netdev/179012275175.2160803.16091441325063775173@kernel.org/ Signed-off-by: Yuyang Huang --- net/core/dev_addr_lists.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/dev_addr_lists.c b/net/core/dev_addr_lists.c index b6f25e487984..ff0815d8f6a8 100644 --- a/net/core/dev_addr_lists.c +++ b/net/core/dev_addr_lists.c @@ -100,7 +100,7 @@ __hw_addr_create(const unsigned char *addr, int addr_len, alloc_size = sizeof(*ha); if (alloc_size < L1_CACHE_BYTES) alloc_size = L1_CACHE_BYTES; - ha = kmalloc(alloc_size, GFP_ATOMIC); + ha = kzalloc(alloc_size, GFP_ATOMIC); if (!ha) return NULL; memcpy(ha->addr, addr, addr_len); -- 2.56.1.750.gf70dc682cf-goog