Commit 16637fea001a ("usb-storage: alauda: Check whether the media is initialized") added a media_initialized flag to struct alauda_info to prevent divide-by-zero errors when alauda_init_media() has not succeeded. However, Alauda devices expose two LUNs (us->max_lun = 1) backed by info->port[0] (xD) and info->port[1] (SmartMedia). Storing media_initialized in struct alauda_info shares it across both ports: once port 0 initializes, media_initialized becomes true, allowing port 1 to skip alauda_init_media() when its media-change bit is clear and divide by port[1].uzonesize == 0 in alauda_read_data() or alauda_write_lba(): Oops: divide error: 0000 [#1] SMP KASAN NOPTI RIP: 0010:alauda_read_data drivers/usb/storage/alauda.c:953 [inline] RIP: 0010:alauda_transport+0xe5a/0x35c0 drivers/usb/storage/alauda.c:1187 Additionally, alauda_check_media() never cleared media_initialized when media was removed or before re-initializing on media change, leaving it true if a subsequent re-initialization failed. Move media_initialized into struct alauda_media_info so each port tracks its own initialization state, and clear it when media is absent or before re-initializing on media change. Reported-by: syzbot+dc208a8cf8d37cf3e5ac@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=dc208a8cf8d37cf3e5ac Fixes: 16637fea001a ("usb-storage: alauda: Check whether the media is initialized") Cc: stable@vger.kernel.org Signed-off-by: Arbab Haider --- drivers/usb/storage/alauda.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/usb/storage/alauda.c b/drivers/usb/storage/alauda.c index 5e7f99ba8..5493f25a7 100644 --- a/drivers/usb/storage/alauda.c +++ b/drivers/usb/storage/alauda.c @@ -96,6 +96,8 @@ struct alauda_media_info { u16 **lba_to_pba; /* logical to physical block map */ u16 **pba_to_lba; /* physical to logical block map */ + + bool media_initialized; }; struct alauda_info { @@ -105,8 +107,6 @@ struct alauda_info { unsigned char sense_key; unsigned long sense_asc; /* additional sense code */ unsigned long sense_ascq; /* additional sense code qualifier */ - - bool media_initialized; }; #define short_pack(lsb,msb) ( ((u16)(lsb)) | ( ((u16)(msb))<<8 ) ) @@ -471,6 +471,7 @@ static int alauda_check_media(struct us_data *us) || ((status[1] & 0x01) == 0)) { usb_stor_dbg(us, "No media, or door open\n"); alauda_free_maps(&MEDIA_INFO(us)); + MEDIA_INFO(us).media_initialized = false; info->sense_key = 0x02; info->sense_asc = 0x3A; info->sense_ascq = 0x00; @@ -478,12 +479,13 @@ static int alauda_check_media(struct us_data *us) } /* Check for media change */ - if (status[0] & 0x08 || !info->media_initialized) { + if (status[0] & 0x08 || !MEDIA_INFO(us).media_initialized) { usb_stor_dbg(us, "Media change detected\n"); alauda_free_maps(&MEDIA_INFO(us)); + MEDIA_INFO(us).media_initialized = false; rc = alauda_init_media(us); if (rc == USB_STOR_TRANSPORT_GOOD) - info->media_initialized = true; + MEDIA_INFO(us).media_initialized = true; info->sense_key = UNIT_ATTENTION; info->sense_asc = 0x28; info->sense_ascq = 0x00; -- 2.53.0