From: bui duc phuc The platform_get_irq_optional() function currently returns all negative error values without distinguishing between the case where no IRQ is available and actual errors occurring during the IRQ lookup. Use platform_get_irq() instead, as it matches the existing error handling by propagating any error encountered during the IRQ lookup. Found by manual code inspection. Signed-off-by: bui duc phuc --- drivers/net/ethernet/broadcom/asp2/bcmasp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/asp2/bcmasp.c b/drivers/net/ethernet/broadcom/asp2/bcmasp.c index 972474893a6b..d66a8bbd6e38 100644 --- a/drivers/net/ethernet/broadcom/asp2/bcmasp.c +++ b/drivers/net/ethernet/broadcom/asp2/bcmasp.c @@ -1094,7 +1094,7 @@ static int bcmasp_get_and_request_irq(struct bcmasp_priv *priv, int i) struct platform_device *pdev = priv->pdev; int irq, ret; - irq = platform_get_irq_optional(pdev, i); + irq = platform_get_irq(pdev, i); if (irq < 0) return irq; -- 2.43.0