PAGECACHE_TAG_DIRTY is the authoritative source of dirty folios present in the mapping. Use that instead of looking at I_DIRTY_PAGES inode state which can get stale (e.g. when folios are written directly with filemap_fdatawrite()). Signed-off-by: Jan Kara --- fs/orangefs/orangefs-utils.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/fs/orangefs/orangefs-utils.c b/fs/orangefs/orangefs-utils.c index 9ab1119ebd28..4c4036f470cd 100644 --- a/fs/orangefs/orangefs-utils.c +++ b/fs/orangefs/orangefs-utils.c @@ -247,7 +247,8 @@ int orangefs_inode_getattr(struct inode *inode, int flags) spin_lock(&inode->i_lock); /* Must have all the attributes in the mask and be within cache time. */ if ((!flags && time_before(jiffies, orangefs_inode->getattr_time)) || - orangefs_inode->attr_valid || inode_state_read(inode) & I_DIRTY_PAGES) { + orangefs_inode->attr_valid || + mapping_tagged(inode->i_mapping, PAGECACHE_TAG_DIRTY)) { if (orangefs_inode->attr_valid) { spin_unlock(&inode->i_lock); write_inode_now(inode, 1); @@ -281,13 +282,14 @@ int orangefs_inode_getattr(struct inode *inode, int flags) spin_lock(&inode->i_lock); /* Must have all the attributes in the mask and be within cache time. */ if ((!flags && time_before(jiffies, orangefs_inode->getattr_time)) || - orangefs_inode->attr_valid || inode_state_read(inode) & I_DIRTY_PAGES) { + orangefs_inode->attr_valid || + mapping_tagged(inode->i_mapping, PAGECACHE_TAG_DIRTY)) { if (orangefs_inode->attr_valid) { spin_unlock(&inode->i_lock); write_inode_now(inode, 1); goto again2; } - if (inode_state_read(inode) & I_DIRTY_PAGES) { + if (mapping_tagged(inode->i_mapping, PAGECACHE_TAG_DIRTY)) { ret = 0; goto out_unlock; } -- 2.53.0