When a USB em28xx device is disconnected while a V4L2 device node (e.g. /dev/video0) is still open, em28xx_usb_disconnect() calls em28xx_release_resources() -> em28xx_unregister_media_device(), which calls media_device_cleanup() and kfree(dev->media_dev) immediately. However, struct em28xx_v4l2 remains alive until the last open file handle is closed, and v4l2->v4l2_dev.mdev still points to the freed media_device. When userspace subsequently closes /dev/video0, v4l2_release() calls v4l2_device_supports_requests(vdev->v4l2_dev), dereferencing vdev->v4l2_dev->mdev->ops and triggering a KASAN slab-use-after-free: BUG: KASAN: slab-use-after-free in v4l2_release+0x325/0x380 Read of size 8 at addr ffff88800787a260 by task test_em28xx_uaf/53 ... Freed by task 30: kfree+0x162/0x410 em28xx_unregister_media_device+0xa4/0xe0 em28xx_release_resources+0x70/0x170 em28xx_usb_disconnect.cold+0x107/0x2a3 Split em28xx_unregister_media_device() so it only calls media_device_unregister(dev->media_dev) on disconnect, and move media_device_cleanup() and kfree(dev->media_dev) into a new em28xx_cleanup_media_device() helper called from em28xx_free_device() (once the last dev->ref reference, including em28xx_free_v4l2(), has been dropped) and from em28xx_init_dev()'s error path. Tested locally in QEMU (x86_64, KASAN+UBSAN) using dummy_hcd and raw-gadget emulating an EM2820 device across open->disconnect->close, repeated disconnect, dual-fd open->disconnect->close, and normal open->close->disconnect scenarios (4/4 passed, 0 KASAN reports). Cc: stable@vger.kernel.org Signed-off-by: Arbab Haider --- drivers/media/usb/em28xx/em28xx-cards.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/em28xx/em28xx-cards.c b/drivers/media/usb/em28xx/em28xx-cards.c index 1d4f30cba..d8f2e40b7 100644 --- a/drivers/media/usb/em28xx/em28xx-cards.c +++ b/drivers/media/usb/em28xx/em28xx-cards.c @@ -3773,8 +3773,15 @@ static int em28xx_media_device_init(struct em28xx *dev, static void em28xx_unregister_media_device(struct em28xx *dev) { #ifdef CONFIG_MEDIA_CONTROLLER - if (dev->media_dev) { + if (dev->media_dev) media_device_unregister(dev->media_dev); +#endif +} + +static void em28xx_cleanup_media_device(struct em28xx *dev) +{ +#ifdef CONFIG_MEDIA_CONTROLLER + if (dev->media_dev) { media_device_cleanup(dev->media_dev); kfree(dev->media_dev); dev->media_dev = NULL; @@ -3826,6 +3833,8 @@ void em28xx_free_device(struct kref *ref) if (!dev->disconnected) em28xx_release_resources(dev); + em28xx_cleanup_media_device(dev); + if (dev->ts == PRIMARY_TS) kfree(dev->alt_max_pkt_size_isoc); @@ -3997,6 +4006,7 @@ static int em28xx_init_dev(struct em28xx *dev, struct usb_device *udev, em28xx_i2c_unregister(dev, 0); err_deinit_media: em28xx_unregister_media_device(dev); + em28xx_cleanup_media_device(dev); return retval; } -- 2.53.0