From: Bruce Lane If sysfs_create_group() fails, the error path lacks some cleanup operations to release sources. Add corresponding cleanup functions under out_close_led label. Signed-off-by: Bruce Lane --- drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c index 3bee82bc0680..a6693f332d25 100644 --- a/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c +++ b/drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c @@ -3381,6 +3381,15 @@ static int init_one(struct pci_dev *pdev, const struct pci_device_id *ent) return 0; out_close_led: + if (is_offload(adapter)) + cxgb3_adapter_unofld(adapter); + + for_each_port(adapter, i) + if (test_bit(i, &adapter->registered_device_map)) + unregister_netdev(adapter->port[i]); + + cxgb_disable_msi(adapter); + t3_set_reg_field(adapter, A_T3DBG_GPIO_EN, F_GPIO0_OUT_VAL, 0); out_free_dev: -- 2.25.1