Incorrect vmlinux.h annotations can make valid context and socket accesses fail to load. Add load tests through the generated header for these cases: - fields in nested anonymous unions of context types, which vmlinux.h leaves unannotated, and a bpf_sock field. - skb_narrow_field(): a narrow skb->mark load, which the verifier rejects if __sk_buff carries __bpf_relocatable. - skb_merge_loads(): skb field loads merged across branches, which the verifier rejects without __bpf_static_offset. Built only if the compiler supports preserve_static_offset. Signed-off-by: Ihor Solodrai --- .../selftests/bpf/prog_tests/verifier.c | 2 + .../bpf/progs/verifier_ctx_rewritten.c | 60 +++++++++++++++++++ 2 files changed, 62 insertions(+) create mode 100644 tools/testing/selftests/bpf/progs/verifier_ctx_rewritten.c diff --git a/tools/testing/selftests/bpf/prog_tests/verifier.c b/tools/testing/selftests/bpf/prog_tests/verifier.c index ae23304c1340..d41339ef00d8 100644 --- a/tools/testing/selftests/bpf/prog_tests/verifier.c +++ b/tools/testing/selftests/bpf/prog_tests/verifier.c @@ -45,6 +45,7 @@ #include "verifier_const.skel.h" #include "verifier_const_or.skel.h" #include "verifier_ctx.skel.h" +#include "verifier_ctx_rewritten.skel.h" #include "verifier_ctx_sk_msg.skel.h" #include "verifier_d_path.skel.h" #include "verifier_default_trusted_ptr.skel.h" @@ -242,6 +243,7 @@ void test_verifier_cgroup_storage(void) { RUN(verifier_cgroup_storage); } void test_verifier_const(void) { RUN(verifier_const); } void test_verifier_const_or(void) { RUN(verifier_const_or); } void test_verifier_ctx(void) { RUN_TESTS(verifier_ctx); } +void test_verifier_ctx_rewritten(void) { RUN_TESTS(verifier_ctx_rewritten); } void test_verifier_ctx_sk_msg(void) { RUN(verifier_ctx_sk_msg); } void test_verifier_d_path(void) { RUN(verifier_d_path); } void test_verifier_default_trusted_ptr(void) { RUN_TESTS(verifier_default_trusted_ptr); } diff --git a/tools/testing/selftests/bpf/progs/verifier_ctx_rewritten.c b/tools/testing/selftests/bpf/progs/verifier_ctx_rewritten.c new file mode 100644 index 000000000000..5feba7e1af73 --- /dev/null +++ b/tools/testing/selftests/bpf/progs/verifier_ctx_rewritten.c @@ -0,0 +1,60 @@ +// SPDX-License-Identifier: GPL-2.0 +#include +#include +#include "bpf_misc.h" + +SEC("tc") +__success +int skb_socket(struct __sk_buff *skb) +{ + struct bpf_sock *sk = skb->sk; + + return sk ? sk->family : 0; +} + +SEC("sockops") +__success +int sockops_args_reply(struct bpf_sock_ops *skops) +{ + skops->reply = skops->args[1]; + return 0; +} + +SEC("sk_msg") +__success +int sk_msg_data(struct sk_msg_md *msg) +{ + return msg->data < msg->data_end; +} + +SEC("cgroup/getsockopt") +__success +int sockopt_optval(struct bpf_sockopt *ctx) +{ + return ctx->optval < ctx->optval_end; +} + +SEC("tc") +__success +int skb_narrow_field(struct __sk_buff *skb) +{ + /* a nonzero byte offset becomes pointer arithmetic with preserve_access_index */ + return ((__u8 *)&skb->mark)[1]; +} + +#if __has_attribute(preserve_static_offset) +SEC("tc") +__success +int skb_merge_loads(struct __sk_buff *skb) +{ + __u32 value; + + if (skb->len) + value = skb->pkt_type; + else + value = skb->mark; + return value; +} +#endif + +char _license[] SEC("license") = "GPL"; -- 2.56.0