"Scope of protection" lists only the PTE drops requested by the user and says the range has to be re-armed afterwards. On shmem the kernel can drop the PTE at any time (page reclaim and collapse are examples), and RWP has no marker by design: the next access is a minor or a missing fault, and the user is expected to register for those. Document this, together with the modes that sync and async tracking need. The VMM example registers guest_mem with RWP and MISSING only, so a vCPU write to an offset that is not mapped there can be lost during eviction. Add MINOR to the registration, describe how the handler treats faults on offsets that are being evicted, and fix the step 1 comment, since minor faults block even in async mode. Link: https://lore.kernel.org/linux-mm/856cdf21-7982-475a-b244-a7ceff4eb6aa@kernel.org/ Link: https://lore.kernel.org/linux-mm/avWnaR7VVEGa7yNp@thinkstation/ Suggested-by: Tal Zussman Signed-off-by: Jose A. Perez de Azpillaga --- Changes in v2: - keep the migration sentence out of the anonymous-only paragraph, it applies to shmem and hugetlbfs too, and say "uffd bit", not "marker" - state the rule instead of listing the operations that drop the PTE - say that a context switching to sync with UFFDIO_SET_MODE needs the sync registration, and fix the step 1 comment, since minor faults block in async mode - add {} around the comment-only if body in the example - make RWP and minor faults on any offset this pass will evict wait until that offset is punched v1: https://lore.kernel.org/20261113112806.109578-1-azpijr@gmail.com Documentation/admin-guide/mm/userfaultfd.rst | 88 ++++++++++++++++---- 1 file changed, 70 insertions(+), 18 deletions(-) diff --git a/Documentation/admin-guide/mm/userfaultfd.rst b/Documentation/admin-guide/mm/userfaultfd.rst index 97daea83b7f1..8d1aeef73ac2 100644 --- a/Documentation/admin-guide/mm/userfaultfd.rst +++ b/Documentation/admin-guide/mm/userfaultfd.rst @@ -384,17 +384,53 @@ normal missing path (``do_anonymous_page()``, ``do_swap_page()``, the population itself, co-register the range with ``UFFDIO_REGISTER_MODE_MISSING``. -Protection is preserved across page reclaim: a page swapped out while -RWP-protected carries the marker on its swap entry, and swap-in restores -the PROT_NONE state so the first access after swap-in still faults. The -same applies to pages temporarily replaced by migration entries. - -Operations that drop the PTE entirely — ``MADV_DONTNEED`` on anonymous -memory, hole-punch on shmem, truncation of a file mapping — also drop the -RWP marker: the next access re-populates the range without protection. +Protection is preserved while a page is temporarily replaced by a +migration entry: the migration entry keeps the uffd bit, and the PROT_NONE +state is restored when migration completes. This holds for anonymous, +shmem and hugetlbfs memory alike. + +Protection of anonymous memory is also preserved across page reclaim: a +page swapped out while RWP-protected keeps the uffd bit on its swap entry, +and swap-in restores the PROT_NONE state so the first access after swap-in +still faults. + +Any operation that drops the PTE also drops the RWP protection. On shmem +the kernel can drop the PTE at any time while the page stays in the page +cache or in swap; page reclaim and collapse into a huge page are examples. Unlike WP (which persists via ``PTE_MARKER_UFFD_WP``), there is no -persistent RWP marker today. The user needs to re-arm the range with -``UFFDIO_RWPROTECT`` after any operation that explicitly frees PTEs. +persistent RWP marker, and this is intentional: once the PTE is gone, the +next access takes a page fault that userfaultfd can deliver, and that fault +is the notification. Which fault it is depends on what happened to the +page: + +- The page is still in the page cache or in swap: the access is a minor + fault, delivered if the range is co-registered with + ``UFFDIO_REGISTER_MODE_MINOR``. + +- The page is gone: the access is a missing fault, delivered if the range + is co-registered with ``UFFDIO_REGISTER_MODE_MISSING``. + +WP cannot use the same scheme — a minor fault would trap reads as well as +writes — which is why it needs a marker. + +Without the matching mode the page is mapped back silently and without +protection, so what to co-register depends on the tracking mode: + +- Sync mode: the access would be lost. Co-register shmem and hugetlbfs + ranges with ``UFFDIO_REGISTER_MODE_MINOR`` (and + ``UFFDIO_REGISTER_MODE_MISSING`` if the file can have holes), and + anonymous ranges, where minor faults are not available, with + ``UFFDIO_REGISTER_MODE_MISSING``. + +- Async mode: neither is needed. A page faulted back in is mapped without + the uffd bit, so ``PAGEMAP_SCAN`` reports it as accessed. + +The registration is fixed, but the tracking mode is not: a context that +switches to sync mode with ``UFFDIO_SET_MODE``, as the workflow below does, +needs the sync registration. This has a cost in async mode, because minor +faults are always synchronous: an access that takes a minor fault blocks +until the handler resolves it, even while RWP faults are resolved by the +kernel. **Fault Handling:** @@ -484,17 +520,24 @@ never traps on its own :: .features = UFFD_FEATURE_RWP | UFFD_FEATURE_RWP_ASYNC, }; ioctl(uffd, UFFDIO_API, &api); - if (!(api.features & UFFD_FEATURE_RWP)) + if (!(api.features & UFFD_FEATURE_RWP)) { /* RWP unavailable on this kernel/arch -- fall back. */ + } + /* + * MINOR: an offset in the page cache but not mapped in guest_mem + * would be mapped back without a fault, and a vCPU write between + * the pwrite() and the hole punch in step 4 would be lost. + */ ioctl(uffd, UFFDIO_REGISTER, &(struct uffdio_register){ .range = { guest_mem, guest_size }, .mode = UFFDIO_REGISTER_MODE_RWP | - UFFDIO_REGISTER_MODE_MISSING, + UFFDIO_REGISTER_MODE_MISSING | + UFFDIO_REGISTER_MODE_MINOR, }); /* Tracking loop */ while (vm_running) { - /* 1. Detection phase (async -- no vCPU stalls) */ + /* 1. Detection phase (RWP faults async, minor faults still block) */ ioctl(uffd, UFFDIO_RWPROTECT, &(struct uffdio_rwprotect){ .range = full_range, .mode = UFFDIO_RWPROTECT_MODE_RWP }); @@ -544,11 +587,20 @@ never traps on its own :: .enable = UFFD_FEATURE_RWP_ASYNC }); } -During step 4, a vCPU that accesses a ``guest_mem`` offset being evicted -blocks with a ``UFFD_PAGEFAULT_FLAG_RWP`` fault while the eviction is in -progress. After ``fallocate()`` punches the page out and ``UFFDIO_WAKE`` -fires, the vCPU retries the access, faults as ``MISSING``, and the -handler resolves it with ``UFFDIO_COPY`` from storage. +During step 4, a vCPU that accesses an offset this pass will evict blocks +with a ``UFFD_PAGEFAULT_FLAG_RWP`` fault, or with a +``UFFD_PAGEFAULT_FLAG_MINOR`` fault if the offset is not mapped in +``guest_mem``. The handler leaves the fault pending until that offset has +been punched out, even if step 4 has not reached it yet: resolving it +earlier would let a vCPU write land between the ``pwrite()`` and the hole +punch, and the write would be lost. After ``fallocate()`` punches the page +out and ``UFFDIO_WAKE`` fires, the vCPU retries the access, faults as +``MISSING``, and the handler resolves it with ``UFFDIO_COPY`` from storage. + +Faults on any other offset are resolved right away: RWP faults with +``UFFDIO_RWPROTECT``, minor faults with ``UFFDIO_CONTINUE``. A page mapped +by ``UFFDIO_CONTINUE`` does not carry the uffd bit, so the next scan reports +it as accessed. This workflow targets shmem and hugetlbfs (both support a private ``io_mem`` mapping over the same fd). Anonymous-memory backings need a -- 2.56.0