Reducing limit or memory_limit in dualpi2_change() removes packets with qdisc_dequeue_internal(), bypassing the timestamp refresh performed by dequeue_packet(). The cached c_head_ts and l_head_ts can therefore refer to a packet that has already been removed. If a queue is drained, its timestamp remains nonzero. get_queue_delays() continues reporting an increasing delay for the empty queue, and calculate_probability() uses that delay as input to the PI2 controller. Partially trimmed queues also report the delay of the old head instead of the retained head. Refresh both cached timestamps from the internal queue heads after the trim loop, while still holding the qdisc tree lock. head_enqueue_time() returns zero when the corresponding queue is empty. I identified this issue and reviewed the fix. I used OpenAI Codex for root-cause analysis, drafting the fix and this changelog, and assistance with regression-test development. Codex also performed automated validation; the archived results are described below. I reproduced the issue using Codex-assisted automated tests on an unmodified arm64 net-tree kernel in QEMU, with real AF_PACKET traffic in an isolated network namespace and HFSC ls/ul shaping to retain packets. No source changes or fault injection were used to trigger the bug. The companion kernel selftest covers C/L dequeue, full and partial trimming, mixed queues and no-trim changes: the baseline passes three controls and fails eight trimming checks; the fixed kernel passes all 11. Runtime coverage is this DualPI2 selftest on arm64. I also used Codex to build arm64 Images and compile the modified object with W=1; additional build coverage is in the cover letter. Fixes: 8f9516daedd6 ("sched: Add enqueue/dequeue of dualpi2 qdisc") Cc: stable@vger.kernel.org Signed-off-by: Zhiqi Zhang --- net/sched/sch_dualpi2.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/sched/sch_dualpi2.c b/net/sched/sch_dualpi2.c index 4947def7c4..79eba7209e 100644 --- a/net/sched/sch_dualpi2.c +++ b/net/sched/sch_dualpi2.c @@ -938,6 +938,8 @@ static int dualpi2_change(struct Qdisc *sch, struct nlattr *opt, break; } } + WRITE_ONCE(q->c_head_ts, head_enqueue_time(sch)); + WRITE_ONCE(q->l_head_ts, head_enqueue_time(q->l_queue)); qdisc_tree_reduce_backlog(sch, old_qlen - qdisc_qlen(sch), old_backlog - sch->qstats.backlog); base-commit: 2a324a58a084c5cfd7e5a2f55e0786bee170a4a5 -- 2.54.0 (Apple Git-157)