The node obtained with of_find_node_by_path() is never released, both on the early return after a failed allocation and on the normal return path. Add the missing of_node_put() calls. Fixes: 7e66c5c74f73 ("of/selftest: Add self tests for manipulation of properties") Cc: stable@vger.kernel.org Signed-off-by: Wentao Liang --- drivers/of/unittest.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c index 5c90be158dd5..316f082c430d 100644 --- a/drivers/of/unittest.c +++ b/drivers/of/unittest.c @@ -200,6 +200,7 @@ static void __init of_unittest_dynamic(void) prop = kzalloc_objs(*prop, 4); if (!prop) { unittest(0, "kzalloc() failed\n"); + of_node_put(np); return; } @@ -244,6 +245,8 @@ static void __init of_unittest_dynamic(void) if (prop->value) unittest(of_add_property(np, prop) == 0, "Adding a large property should have passed\n"); + + of_node_put(np); } static int __init of_unittest_check_node_linkage(struct device_node *np) -- 2.34.1